1 files changed, 65 insertions, 36 deletions

diff --git a/drivers/usb/host/r8a66597-hcd.c b/drivers/usb/host/r8a66597-hcd.c
index ea7126f99cab..c18d8790c410 100644
--- a/drivers/usb/host/r8a66597-hcd.c
+++ b/drivers/usb/host/r8a66597-hcd.c
@@ -66,7 +66,7 @@ static unsigned short endian;
 module_param(endian, ushort, 0644);
 MODULE_PARM_DESC(endian, "data endian: big=256, little=0 (default=0)");
 
-static unsigned short irq_sense = INTL;
+static unsigned short irq_sense = 0xff;
 module_param(irq_sense, ushort, 0644);
 MODULE_PARM_DESC(irq_sense, "IRQ sense: low level=32, falling edge=0 "
                 "(default=32)");
@@ -118,7 +118,7 @@ static int r8a66597_clock_enable(struct r8a66597 *r8a66597)
                 r8a66597_write(r8a66597, SCKE, SYSCFG0);
                 tmp = r8a66597_read(r8a66597, SYSCFG0);
                 if (i++ > 1000) {
-                        err("register access fail.");
+                        printk(KERN_ERR "r8a66597: register access fail.\n");
                         return -ENXIO;
                 }
         } while ((tmp & SCKE) != SCKE);
@@ -128,7 +128,7 @@ static int r8a66597_clock_enable(struct r8a66597 *r8a66597)
                 r8a66597_write(r8a66597, USBE, SYSCFG0);
                 tmp = r8a66597_read(r8a66597, SYSCFG0);
                 if (i++ > 1000) {
-                        err("register access fail.");
+                        printk(KERN_ERR "r8a66597: register access fail.\n");
                         return -ENXIO;
                 }
         } while ((tmp & USBE) != USBE);
@@ -141,7 +141,7 @@ static int r8a66597_clock_enable(struct r8a66597 *r8a66597)
                 msleep(1);
                 tmp = r8a66597_read(r8a66597, SYSCFG0);
                 if (i++ > 500) {
-                        err("register access fail.");
+                        printk(KERN_ERR "r8a66597: register access fail.\n");
                         return -ENXIO;
                 }
         } while ((tmp & SCKE) != SCKE);
@@ -265,7 +265,7 @@ static void get_port_number(char *devpath, u16 *root_port, u16 *hub_port)
         if (root_port) {
                 *root_port = (devpath[0] & 0x0F) - 1;
                 if (*root_port >= R8A66597_MAX_ROOT_HUB)
-                        err("illegal root port number");
+                        printk(KERN_ERR "r8a66597: Illegal root port number.\n");
         }
         if (hub_port)
                 *hub_port = devpath[2] & 0x0F;
@@ -286,7 +286,7 @@ static u16 get_r8a66597_usb_speed(enum usb_device_speed speed)
                 usbspd = HSMODE;
                 break;
         default:
-                err("unknown speed");
+                printk(KERN_ERR "r8a66597: unknown speed\n");
                 break;
         }
 
@@ -385,7 +385,7 @@ static u8 alloc_usb_address(struct r8a66597 *r8a66597, struct urb *urb)
         struct r8a66597_device *dev;
 
         if (is_hub_limit(urb->dev->devpath)) {
-                err("Externel hub limit reached.");
+                dev_err(&urb->dev->dev, "External hub limit reached.\n");
                 return 0;
         }
 
@@ -406,8 +406,9 @@ static u8 alloc_usb_address(struct r8a66597 *r8a66597, struct urb *urb)
                 return addr;
         }
 
-        err("cannot communicate with a USB device more than 10.(%x)",
-            r8a66597->address_map);
+        dev_err(&urb->dev->dev,
+                "cannot communicate with a USB device more than 10.(%x)\n",
+                r8a66597->address_map);
 
         return 0;
 }
@@ -447,7 +448,8 @@ static void r8a66597_reg_wait(struct r8a66597 *r8a66597, unsigned long reg,
         do {
                 tmp = r8a66597_read(r8a66597, reg);
                 if (i++ > 1000000) {
-                        err("register%lx, loop %x is timeout", reg, loop);
+                        printk(KERN_ERR "r8a66597: register%lx, loop %x "
+                               "is timeout\n", reg, loop);
                         break;
                 }
                 ndelay(1);
@@ -675,7 +677,7 @@ static u16 get_empty_pipenum(struct r8a66597 *r8a66597,
                         array[i++] = 1;
                 break;
         default:
-                err("Illegal type");
+                printk(KERN_ERR "r8a66597: Illegal type\n");
                 return 0;
         }
 
@@ -705,7 +707,7 @@ static u16 get_r8a66597_type(__u8 type)
                 r8a66597_type = R8A66597_ISO;
                 break;
         default:
-                err("Illegal type");
+                printk(KERN_ERR "r8a66597: Illegal type\n");
                 r8a66597_type = 0x0000;
                 break;
         }
@@ -724,7 +726,7 @@ static u16 get_bufnum(u16 pipenum)
         else if (check_interrupt(pipenum))
                 bufnum = 4 + (pipenum - 6);
         else
-                err("Illegal pipenum (%d)", pipenum);
+                printk(KERN_ERR "r8a66597: Illegal pipenum (%d)\n", pipenum);
 
         return bufnum;
 }
@@ -740,7 +742,7 @@ static u16 get_buf_bsize(u16 pipenum)
         else if (check_interrupt(pipenum))
                 buf_bsize = 0;
         else
-                err("Illegal pipenum (%d)", pipenum);
+                printk(KERN_ERR "r8a66597: Illegal pipenum (%d)\n", pipenum);
 
         return buf_bsize;
 }
@@ -760,10 +762,12 @@ static void enable_r8a66597_pipe_dma(struct r8a66597 *r8a66597,
                         if ((r8a66597->dma_map & (1 << i)) != 0)
                                 continue;
 
-                        info("address %d, EndpointAddress 0x%02x use DMA FIFO",
-                             usb_pipedevice(urb->pipe),
-                             info->dir_in ? USB_ENDPOINT_DIR_MASK + info->epnum
-                                            : info->epnum);
+                        dev_info(&dev->udev->dev,
+                                 "address %d, EndpointAddress 0x%02x use "
+                                 "DMA FIFO\n", usb_pipedevice(urb->pipe),
+                                 info->dir_in ?
+                                        USB_ENDPOINT_DIR_MASK + info->epnum
+                                        : info->epnum);
 
                         r8a66597->dma_map |= 1 << i;
                         dev->dma_map |= 1 << i;
@@ -1187,7 +1191,7 @@ static int start_transfer(struct r8a66597 *r8a66597, struct r8a66597_td *td)
                 prepare_status_packet(r8a66597, td);
                 break;
         default:
-                err("invalid type.");
+                printk(KERN_ERR "r8a66597: invalid type.\n");
                 break;
         }
 
@@ -1295,7 +1299,7 @@ static void packet_read(struct r8a66597 *r8a66597, u16 pipenum)
         if (unlikely((tmp & FRDY) == 0)) {
                 pipe_stop(r8a66597, td->pipe);
                 pipe_irq_disable(r8a66597, pipenum);
-                err("in fifo not ready (%d)", pipenum);
+                printk(KERN_ERR "r8a66597: in fifo not ready (%d)\n", pipenum);
                 finish_request(r8a66597, td, pipenum, td->urb, -EPIPE);
                 return;
         }
@@ -1370,7 +1374,7 @@ static void packet_write(struct r8a66597 *r8a66597, u16 pipenum)
         if (unlikely((tmp & FRDY) == 0)) {
                 pipe_stop(r8a66597, td->pipe);
                 pipe_irq_disable(r8a66597, pipenum);
-                err("out write fifo not ready. (%d)", pipenum);
+                printk(KERN_ERR "r8a66597: out fifo not ready (%d)\n", pipenum);
                 finish_request(r8a66597, td, pipenum, urb, -EPIPE);
                 return;
         }
@@ -2005,7 +2009,7 @@ static struct r8a66597_device *get_r8a66597_device(struct r8a66597 *r8a66597,
                 return dev;
         }
 
-        err("get_r8a66597_device fail.(%d)\n", addr);
+        printk(KERN_ERR "r8a66597: get_r8a66597_device fail.(%d)\n", addr);
         return NULL;
 }
 
@@ -2263,7 +2267,7 @@ static int __init_or_module r8a66597_remove(struct platform_device *pdev)
 #define resource_len(r) (((r)->end - (r)->start) + 1)
 static int __init r8a66597_probe(struct platform_device *pdev)
 {
-        struct resource *res = NULL;
+        struct resource *res = NULL, *ires;
         int irq = -1;
         void __iomem *reg = NULL;
         struct usb_hcd *hcd = NULL;
@@ -2274,7 +2278,7 @@ static int __init r8a66597_probe(struct platform_device *pdev)
 
         if (pdev->dev.dma_mask) {
                 ret = -EINVAL;
-                err("dma not support");
+                dev_err(&pdev->dev, "dma not supported\n");
                 goto clean_up;
         }
 
@@ -2282,21 +2286,25 @@ static int __init r8a66597_probe(struct platform_device *pdev)
                                            (char *)hcd_name);
         if (!res) {
                 ret = -ENODEV;
-                err("platform_get_resource_byname error.");
+                dev_err(&pdev->dev, "platform_get_resource_byname error.\n");
                 goto clean_up;
         }
 
-        irq = platform_get_irq(pdev, 0);
-        if (irq < 0) {
+        ires = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
+        if (!ires) {
                 ret = -ENODEV;
-                err("platform_get_irq error.");
+                dev_err(&pdev->dev,
+                        "platform_get_resource IORESOURCE_IRQ error.\n");
                 goto clean_up;
         }
 
+        irq = ires->start;
+        irq_trigger = ires->flags & IRQF_TRIGGER_MASK;
+
         reg = ioremap(res->start, resource_len(res));
         if (reg == NULL) {
                 ret = -ENOMEM;
-                err("ioremap error.");
+                dev_err(&pdev->dev, "ioremap error.\n");
                 goto clean_up;
         }
 
@@ -2304,7 +2312,7 @@ static int __init r8a66597_probe(struct platform_device *pdev)
         hcd = usb_create_hcd(&r8a66597_hc_driver, &pdev->dev, (char *)hcd_name);
         if (!hcd) {
                 ret = -ENOMEM;
-                err("Failed to create hcd");
+                dev_err(&pdev->dev, "Failed to create hcd\n");
                 goto clean_up;
         }
         r8a66597 = hcd_to_r8a66597(hcd);
@@ -2329,13 +2337,33 @@ static int __init r8a66597_probe(struct platform_device *pdev)
         INIT_LIST_HEAD(&r8a66597->child_device);
 
         hcd->rsrc_start = res->start;
-        if (irq_sense == INTL)
-                irq_trigger = IRQF_TRIGGER_LOW;
-        else
-                irq_trigger = IRQF_TRIGGER_FALLING;
+
+        /* irq_sense setting on cmdline takes precedence over resource
+         * settings, so the introduction of irqflags in IRQ resourse
+         * won't disturb existing setups */
+        switch (irq_sense) {
+                case INTL:
+                        irq_trigger = IRQF_TRIGGER_LOW;
+                        break;
+                case 0:
+                        irq_trigger = IRQF_TRIGGER_FALLING;
+                        break;
+                case 0xff:
+                        if (irq_trigger)
+                                irq_sense = (irq_trigger & IRQF_TRIGGER_LOW) ?
+                                            INTL : 0;
+                        else {
+                                irq_sense = INTL;
+                                irq_trigger = IRQF_TRIGGER_LOW;
+                        }
+                        break;
+                default:
+                        dev_err(&pdev->dev, "Unknown irq_sense value.\n");
+        }
+
         ret = usb_add_hcd(hcd, irq, IRQF_DISABLED | irq_trigger);
         if (ret != 0) {
-                err("Failed to add hcd");
+                dev_err(&pdev->dev, "Failed to add hcd\n");
                 goto clean_up;
         }
 
@@ -2364,7 +2392,8 @@ static int __init r8a66597_init(void)
         if (usb_disabled())
                 return -ENODEV;
 
-        info("driver %s, %s", hcd_name, DRIVER_VERSION);
+        printk(KERN_INFO KBUILD_MODNAME ": driver %s, %s\n", hcd_name,
+               DRIVER_VERSION);
         return platform_driver_register(&r8a66597_driver);
 }
 module_init(r8a66597_init);