1 files changed, 42 insertions, 26 deletions

diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 546ea5431b8c..f03b136ecfce 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -1140,8 +1140,14 @@ static int dwc3_gadget_ep_queue(struct usb_ep *ep, struct usb_request *request,
         if (!dep->endpoint.desc) {
                 dev_dbg(dwc->dev, "trying to queue request %p to disabled %s\n",
                                 request, ep->name);
-                spin_unlock_irqrestore(&dwc->lock, flags);
-                return -ESHUTDOWN;
+                ret = -ESHUTDOWN;
+                goto out;
+        }
+
+        if (WARN(req->dep != dep, "request %p belongs to '%s'\n",
+                                request, req->dep->name)) {
+                ret = -EINVAL;
+                goto out;
         }
 
         dev_vdbg(dwc->dev, "queing request %p to %s length %d\n",
@@ -1149,6 +1155,8 @@ static int dwc3_gadget_ep_queue(struct usb_ep *ep, struct usb_request *request,
         trace_dwc3_ep_queue(req);
 
         ret = __dwc3_gadget_ep_queue(dep, req);
+
+out:
         spin_unlock_irqrestore(&dwc->lock, flags);
 
         return ret;
@@ -1622,8 +1630,7 @@ err0:
         return ret;
 }
 
-static int dwc3_gadget_stop(struct usb_gadget *g,
-                struct usb_gadget_driver *driver)
+static int dwc3_gadget_stop(struct usb_gadget *g)
 {
         struct dwc3             *dwc = gadget_to_dwc(g);
         unsigned long           flags;
@@ -2034,6 +2041,17 @@ static void dwc3_resume_gadget(struct dwc3 *dwc)
         if (dwc->gadget_driver && dwc->gadget_driver->resume) {
                 spin_unlock(&dwc->lock);
                 dwc->gadget_driver->resume(&dwc->gadget);
+        }
+}
+
+static void dwc3_reset_gadget(struct dwc3 *dwc)
+{
+        if (!dwc->gadget_driver)
+                return;
+
+        if (dwc->gadget.speed != USB_SPEED_UNKNOWN) {
+                spin_unlock(&dwc->lock);
+                usb_gadget_udc_reset(&dwc->gadget, dwc->gadget_driver);
                 spin_lock(&dwc->lock);
         }
 }
@@ -2140,6 +2158,7 @@ static void dwc3_gadget_disconnect_interrupt(struct dwc3 *dwc)
 
         dwc->gadget.speed = USB_SPEED_UNKNOWN;
         dwc->setup_packet_pending = false;
+        usb_gadget_set_state(&dwc->gadget, USB_STATE_NOTATTACHED);
 }
 
 static void dwc3_gadget_reset_interrupt(struct dwc3 *dwc)
@@ -2177,11 +2196,7 @@ static void dwc3_gadget_reset_interrupt(struct dwc3 *dwc)
                         dwc3_gadget_disconnect_interrupt(dwc);
         }
 
-        /* after reset -> Default State */
-        usb_gadget_set_state(&dwc->gadget, USB_STATE_DEFAULT);
-
-        if (dwc->gadget.speed != USB_SPEED_UNKNOWN)
-                dwc3_disconnect_gadget(dwc);
+        dwc3_reset_gadget(dwc);
 
         reg = dwc3_readl(dwc->regs, DWC3_DCTL);
         reg &= ~DWC3_DCTL_TSTCTRL_MASK;
@@ -2287,11 +2302,20 @@ static void dwc3_gadget_conndone_interrupt(struct dwc3 *dwc)
                 reg = dwc3_readl(dwc->regs, DWC3_DCTL);
                 reg &= ~(DWC3_DCTL_HIRD_THRES_MASK | DWC3_DCTL_L1_HIBER_EN);
 
+                reg |= DWC3_DCTL_HIRD_THRES(dwc->hird_threshold);
+
                 /*
-                 * TODO: This should be configurable. For now using
-                 * maximum allowed HIRD threshold value of 0b1100
+                 * When dwc3 revisions >= 2.40a, LPM Erratum is enabled and
+                 * DCFG.LPMCap is set, core responses with an ACK and the
+                 * BESL value in the LPM token is less than or equal to LPM
+                 * NYET threshold.
                  */
-                reg |= DWC3_DCTL_HIRD_THRES(12);
+                WARN_ONCE(dwc->revision < DWC3_REVISION_240A
+                                && dwc->has_lpm_erratum,
+                                "LPM Erratum not available on dwc3 revisisions < 2.40a\n");
+
+                if (dwc->has_lpm_erratum && dwc->revision >= DWC3_REVISION_240A)
+                        reg |= DWC3_DCTL_LPM_ERRATA(dwc->lpm_nyet_threshold);
 
                 dwc3_writel(dwc->regs, DWC3_DCTL, reg);
         } else {
@@ -2744,26 +2768,13 @@ void dwc3_gadget_exit(struct dwc3 *dwc)
                         dwc->ctrl_req, dwc->ctrl_req_addr);
 }
 
-int dwc3_gadget_prepare(struct dwc3 *dwc)
+int dwc3_gadget_suspend(struct dwc3 *dwc)
 {
         if (dwc->pullups_connected) {
                 dwc3_gadget_disable_irq(dwc);
                 dwc3_gadget_run_stop(dwc, true, true);
         }
 
-        return 0;
-}
-
-void dwc3_gadget_complete(struct dwc3 *dwc)
-{
-        if (dwc->pullups_connected) {
-                dwc3_gadget_enable_irq(dwc);
-                dwc3_gadget_run_stop(dwc, true, false);
-        }
-}
-
-int dwc3_gadget_suspend(struct dwc3 *dwc)
-{
         __dwc3_gadget_ep_disable(dwc->eps[0]);
         __dwc3_gadget_ep_disable(dwc->eps[1]);
 
@@ -2798,6 +2809,11 @@ int dwc3_gadget_resume(struct dwc3 *dwc)
 
         dwc3_writel(dwc->regs, DWC3_DCFG, dwc->dcfg);
 
+        if (dwc->pullups_connected) {
+                dwc3_gadget_enable_irq(dwc);
+                dwc3_gadget_run_stop(dwc, true, false);
+        }
+
         return 0;
 
 err1: