5 files changed, 16 insertions, 20 deletions

diff --git a/drivers/serial/68328serial.c b/drivers/serial/68328serial.c
index db92a0ceda79..feb8e73fc1c9 100644
--- a/drivers/serial/68328serial.c
+++ b/drivers/serial/68328serial.c
@@ -992,18 +992,17 @@ static int get_lsr_info(struct m68k_serial * info, unsigned int *value)
 /*
  * This routine sends a break character out the serial port.
  */
-static void send_break( struct m68k_serial * info, int duration)
+static void send_break(struct m68k_serial * info, unsigned int duration)
 {
         m68328_uart *uart = &uart_addr[info->line];
         unsigned long flags;
         if (!info->port)
                 return;
-        set_current_state(TASK_INTERRUPTIBLE);
         save_flags(flags);
         cli();
 #ifdef USE_INTS 
         uart->utx.w |= UTX_SEND_BREAK;
-        schedule_timeout(duration);
+        msleep_interruptible(duration);
         uart->utx.w &= ~UTX_SEND_BREAK;
 #endif          
         restore_flags(flags);
@@ -1033,14 +1032,14 @@ static int rs_ioctl(struct tty_struct *tty, struct file * file,
                                 return retval;
                         tty_wait_until_sent(tty, 0);
                         if (!arg)
-                                send_break(info, HZ/4); /* 1/4 second */
+                                send_break(info, 250);  /* 1/4 second */
                         return 0;
                 case TCSBRKP:   /* support for POSIX tcsendbreak() */
                         retval = tty_check_change(tty);
                         if (retval)
                                 return retval;
                         tty_wait_until_sent(tty, 0);
-                        send_break(info, arg ? arg*(HZ/10) : HZ/4);
+                        send_break(info, arg ? arg*(100) : 250);
                         return 0;
                 case TIOCGSOFTCAR:
                         error = put_user(C_CLOCAL(tty) ? 1 : 0,
diff --git a/drivers/serial/68360serial.c b/drivers/serial/68360serial.c
index f148022b6b4e..b116122e569a 100644
--- a/drivers/serial/68360serial.c
+++ b/drivers/serial/68360serial.c
@@ -1394,14 +1394,13 @@ static void end_break(ser_info_t *info)
 /*
  * This routine sends a break character out the serial port.
  */
-static void send_break(ser_info_t *info, int duration)
+static void send_break(ser_info_t *info, unsigned int duration)
 {
-        set_current_state(TASK_INTERRUPTIBLE);
 #ifdef SERIAL_DEBUG_SEND_BREAK
         printk("rs_send_break(%d) jiff=%lu...", duration, jiffies);
 #endif
         begin_break(info);
-        schedule_timeout(duration);
+        msleep_interruptible(duration);
         end_break(info);
 #ifdef SERIAL_DEBUG_SEND_BREAK
         printk("done jiffies=%lu\n", jiffies);
@@ -1436,7 +1435,7 @@ static int rs_360_ioctl(struct tty_struct *tty, struct file * file,
                         if (signal_pending(current))
                                 return -EINTR;
                         if (!arg) {
-                                send_break(info, HZ/4); /* 1/4 second */
+                                send_break(info, 250);  /* 1/4 second */
                                 if (signal_pending(current))
                                         return -EINTR;
                         }
@@ -1448,7 +1447,7 @@ static int rs_360_ioctl(struct tty_struct *tty, struct file * file,
                         tty_wait_until_sent(tty, 0);
                         if (signal_pending(current))
                                 return -EINTR;
-                        send_break(info, arg ? arg*(HZ/10) : HZ/4);
+                        send_break(info, arg ? arg*100 : 250);
                         if (signal_pending(current))
                                 return -EINTR;
                         return 0;
diff --git a/drivers/serial/icom.h b/drivers/serial/icom.h
index 23dc0f7ddf8b..798f1ef23712 100644
--- a/drivers/serial/icom.h
+++ b/drivers/serial/icom.h
@@ -286,5 +286,3 @@ struct lookup_int_table {
         u32     __iomem *global_int_mask;
         unsigned long   processor_id;
 };
-
-#define MSECS_TO_JIFFIES(ms) (((ms)*HZ+999)/1000)
diff --git a/drivers/serial/mpsc.c b/drivers/serial/mpsc.c
index a8314aee2ab8..a2a643318002 100644
--- a/drivers/serial/mpsc.c
+++ b/drivers/serial/mpsc.c
@@ -67,7 +67,11 @@
 
 static struct mpsc_port_info mpsc_ports[MPSC_NUM_CTLRS];
 static struct mpsc_shared_regs mpsc_shared_regs;
+static struct uart_driver mpsc_reg;
 
+static void mpsc_start_rx(struct mpsc_port_info *pi);
+static void mpsc_free_ring_mem(struct mpsc_port_info *pi);
+static void mpsc_release_port(struct uart_port *port);
 /*
  ******************************************************************************
  *
@@ -546,7 +550,6 @@ static int
 mpsc_alloc_ring_mem(struct mpsc_port_info *pi)
 {
         int rc = 0;
-        static void mpsc_free_ring_mem(struct mpsc_port_info *pi);
 
         pr_debug("mpsc_alloc_ring_mem[%d]: Allocating ring mem\n",
                 pi->port.line);
@@ -745,7 +748,6 @@ mpsc_rx_intr(struct mpsc_port_info *pi, struct pt_regs *regs)
         int     rc = 0;
         u8      *bp;
         char    flag = TTY_NORMAL;
-        static void mpsc_start_rx(struct mpsc_port_info *pi);
 
         pr_debug("mpsc_rx_intr[%d]: Handling Rx intr\n", pi->port.line);
 
@@ -1178,7 +1180,6 @@ static void
 mpsc_shutdown(struct uart_port *port)
 {
         struct mpsc_port_info *pi = (struct mpsc_port_info *)port;
-        static void mpsc_release_port(struct uart_port *port);
 
         pr_debug("mpsc_shutdown[%d]: Shutting down MPSC\n", port->line);
 
@@ -1448,7 +1449,6 @@ mpsc_console_setup(struct console *co, char *options)
         return uart_set_options(&pi->port, co, baud, parity, bits, flow);
 }
 
-extern struct uart_driver mpsc_reg;
 static struct console mpsc_console = {
         .name   = MPSC_DEV_NAME,
         .write  = mpsc_console_write,
diff --git a/drivers/serial/sunzilog.c b/drivers/serial/sunzilog.c
index 5c4231ae295b..8e65206d3d76 100644
--- a/drivers/serial/sunzilog.c
+++ b/drivers/serial/sunzilog.c
@@ -1071,7 +1071,7 @@ static void __init sunzilog_alloc_tables(void)
  */
 static struct zilog_layout __iomem * __init get_zs_sun4u(int chip, int zsnode)
 {
-        unsigned long mapped_addr;
+        void __iomem *mapped_addr;
         unsigned int sun4u_ino;
         struct sbus_bus *sbus = NULL;
         struct sbus_dev *sdev = NULL;
@@ -1111,9 +1111,9 @@ static struct zilog_layout __iomem * __init get_zs_sun4u(int chip, int zsnode)
                 apply_fhc_ranges(central_bus->child,
                                  &zsregs[0], 1);
                 apply_central_ranges(central_bus, &zsregs[0], 1);
-                mapped_addr =
-                        (((u64)zsregs[0].which_io)<<32UL) |
-                        ((u64)zsregs[0].phys_addr);
+                mapped_addr = (void __iomem *)
+                        ((((u64)zsregs[0].which_io)<<32UL) |
+                        ((u64)zsregs[0].phys_addr));
         }
 
         if (zilog_irq == -1) {