17 files changed, 165 insertions, 75 deletions

diff --git a/drivers/serial/68328serial.c b/drivers/serial/68328serial.c
index 993a702422ec..bac853c5abb5 100644
--- a/drivers/serial/68328serial.c
+++ b/drivers/serial/68328serial.c
@@ -1378,7 +1378,7 @@ void startup_console(void)
 #endif /* CONFIG_PM_LEGACY */
 
 
-static struct tty_operations rs_ops = {
+static const struct tty_operations rs_ops = {
         .open = rs_open,
         .close = rs_close,
         .write = rs_write,
diff --git a/drivers/serial/68360serial.c b/drivers/serial/68360serial.c
index e80e70e9b126..1b299e8c57cd 100644
--- a/drivers/serial/68360serial.c
+++ b/drivers/serial/68360serial.c
@@ -2424,7 +2424,7 @@ long console_360_init(long kmem_start, long kmem_end)
 */
 static  int     baud_idx;
 
-static struct tty_operations rs_360_ops = {
+static const struct tty_operations rs_360_ops = {
         .owner = THIS_MODULE,
         .open = rs_360_open,
         .close = rs_360_close,
diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c
index 0ede0ee64243..cc2a205d4230 100644
--- a/drivers/serial/8250.c
+++ b/drivers/serial/8250.c
@@ -320,8 +320,8 @@ static unsigned int serial_in(struct uart_8250_port *up, int offset)
 
         case UPIO_TSI:
                 if (offset == UART_IIR) {
-                        tmp = readl((u32 *)(up->port.membase + UART_RX));
-                        return (cpu_to_le32(tmp) >> 8) & 0xff;
+                        tmp = readl(up->port.membase + (UART_IIR & ~3));
+                        return (tmp >> 16) & 0xff; /* UART_IIR % 4 == 2 */
                 } else
                         return readb(up->port.membase + offset);
 
diff --git a/drivers/serial/8250_acorn.c b/drivers/serial/8250_acorn.c
index 32af3650e8b4..ef8cc8a70c60 100644
--- a/drivers/serial/8250_acorn.c
+++ b/drivers/serial/8250_acorn.c
@@ -35,6 +35,7 @@ struct serial_card_type {
 struct serial_card_info {
         unsigned int    num_ports;
         int             ports[MAX_PORTS];
+        void __iomem *vaddr;
 };
 
 static int __devinit
@@ -44,7 +45,6 @@ serial_card_probe(struct expansion_card *ec, const struct ecard_id *id)
         struct serial_card_type *type = id->data;
         struct uart_port port;
         unsigned long bus_addr;
-        unsigned char __iomem *virt_addr;
         unsigned int i;
 
         info = kmalloc(sizeof(struct serial_card_info), GFP_KERNEL);
@@ -55,8 +55,8 @@ serial_card_probe(struct expansion_card *ec, const struct ecard_id *id)
         info->num_ports = type->num_ports;
 
         bus_addr = ecard_resource_start(ec, type->type);
-        virt_addr = ioremap(bus_addr, ecard_resource_len(ec, type->type));
-        if (!virt_addr) {
+        info->vaddr = ioremap(bus_addr, ecard_resource_len(ec, type->type));
+        if (!info->vaddr) {
                 kfree(info);
                 return -ENOMEM;
         }
@@ -72,7 +72,7 @@ serial_card_probe(struct expansion_card *ec, const struct ecard_id *id)
         port.dev        = &ec->dev;
 
         for (i = 0; i < info->num_ports; i ++) {
-                port.membase = virt_addr + type->offset[i];
+                port.membase = info->vaddr + type->offset[i];
                 port.mapbase = bus_addr + type->offset[i];
 
                 info->ports[i] = serial8250_register_port(&port);
@@ -92,6 +92,7 @@ static void __devexit serial_card_remove(struct expansion_card *ec)
                 if (info->ports[i] > 0)
                         serial8250_unregister_port(info->ports[i]);
 
+        iounmap(info->vaddr);
         kfree(info);
 }
 
diff --git a/drivers/serial/8250_gsc.c b/drivers/serial/8250_gsc.c
index 913c71cc0569..1ebe6b585d2d 100644
--- a/drivers/serial/8250_gsc.c
+++ b/drivers/serial/8250_gsc.c
@@ -64,6 +64,7 @@ serial_init_chip(struct parisc_device *dev)
         err = serial8250_register_port(&port);
         if (err < 0) {
                 printk(KERN_WARNING "serial8250_register_port returned error %d\n", err);
+                iounmap(port.membase);
                 return err;
         }
         
diff --git a/drivers/serial/cpm_uart/cpm_uart_core.c b/drivers/serial/cpm_uart/cpm_uart_core.c
index 90ff96e3339b..a0d6136deb9b 100644
--- a/drivers/serial/cpm_uart/cpm_uart_core.c
+++ b/drivers/serial/cpm_uart/cpm_uart_core.c
@@ -46,6 +46,7 @@
 #include <asm/io.h>
 #include <asm/irq.h>
 #include <asm/delay.h>
+#include <asm/fs_pd.h>
 
 #if defined(CONFIG_SERIAL_CPM_CONSOLE) && defined(CONFIG_MAGIC_SYSRQ)
 #define SUPPORT_SYSRQ
@@ -1022,15 +1023,17 @@ int cpm_uart_drv_get_platform_data(struct platform_device *pdev, int is_con)
 {
         struct resource *r;
         struct fs_uart_platform_info *pdata = pdev->dev.platform_data;
-        int idx = pdata->fs_no; /* It is UART_SMCx or UART_SCCx index */
+        int idx;        /* It is UART_SMCx or UART_SCCx index */
         struct uart_cpm_port *pinfo;
         int line;
         u32 mem, pram;
 
+        idx = pdata->fs_no = fs_uart_get_id(pdata);
+
         line = cpm_uart_id2nr(idx);
         if(line < 0) {
                 printk(KERN_ERR"%s(): port %d is not registered", __FUNCTION__, idx);
-                return -1;
+                return -EINVAL;
         }
 
         pinfo = (struct uart_cpm_port *) &cpm_uart_ports[idx];
@@ -1044,11 +1047,11 @@ int cpm_uart_drv_get_platform_data(struct platform_device *pdev, int is_con)
 
         if (!(r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "regs")))
                 return -EINVAL;
-        mem = r->start;
+        mem = (u32)ioremap(r->start, r->end - r->start + 1);
 
         if (!(r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "pram")))
                 return -EINVAL;
-        pram = r->start;
+        pram = (u32)ioremap(r->start, r->end - r->start + 1);
 
         if(idx > fsid_smc2_uart) {
                 pinfo->sccp = (scc_t *)mem;
@@ -1179,7 +1182,7 @@ static int __init cpm_uart_console_setup(struct console *co, char *options)
                 pdata = pdev->dev.platform_data;
                 if (pdata)
                         if (pdata->init_ioports)
-                                pdata->init_ioports();
+                                pdata->init_ioports(pdata);
 
                 cpm_uart_drv_get_platform_data(pdev, 1);
         }
@@ -1189,11 +1192,7 @@ static int __init cpm_uart_console_setup(struct console *co, char *options)
         if (options) {
                 uart_parse_options(options, &baud, &parity, &bits, &flow);
         } else {
-                bd_t *bd = (bd_t *) __res;
-
-                if (bd->bi_baudrate)
-                        baud = bd->bi_baudrate;
-                else
+                if ((baud = uart_baudrate()) == -1)
                         baud = 9600;
         }
 
@@ -1266,13 +1265,14 @@ static int cpm_uart_drv_probe(struct device *dev)
         }
 
         pdata = pdev->dev.platform_data;
-        pr_debug("cpm_uart_drv_probe: Adding CPM UART %d\n", cpm_uart_id2nr(pdata->fs_no));
 
         if ((ret = cpm_uart_drv_get_platform_data(pdev, 0)))
                 return ret;
 
+        pr_debug("cpm_uart_drv_probe: Adding CPM UART %d\n", cpm_uart_id2nr(pdata->fs_no));
+
         if (pdata->init_ioports)
-                pdata->init_ioports();
+                pdata->init_ioports(pdata);
 
         ret = uart_add_one_port(&cpm_reg, &cpm_uart_ports[pdata->fs_no].port);
 
diff --git a/drivers/serial/cpm_uart/cpm_uart_cpm2.c b/drivers/serial/cpm_uart/cpm_uart_cpm2.c
index ef3bb476c432..b691d3e14754 100644
--- a/drivers/serial/cpm_uart/cpm_uart_cpm2.c
+++ b/drivers/serial/cpm_uart/cpm_uart_cpm2.c
@@ -40,6 +40,7 @@
 
 #include <asm/io.h>
 #include <asm/irq.h>
+#include <asm/fs_pd.h>
 
 #include <linux/serial_core.h>
 #include <linux/kernel.h>
@@ -50,8 +51,9 @@
 
 void cpm_line_cr_cmd(int line, int cmd)
 {
-        volatile cpm_cpm2_t *cp = cpmp;
         ulong val;
+        volatile cpm_cpm2_t *cp = cpm2_map(im_cpm);
+
 
         switch (line) {
         case UART_SMC1:
@@ -84,11 +86,14 @@ void cpm_line_cr_cmd(int line, int cmd)
         }
         cp->cp_cpcr = val;
         while (cp->cp_cpcr & CPM_CR_FLG) ;
+
+        cpm2_unmap(cp);
 }
 
 void smc1_lineif(struct uart_cpm_port *pinfo)
 {
-        volatile iop_cpm2_t *io = &cpm2_immr->im_ioport;
+        volatile iop_cpm2_t *io = cpm2_map(im_ioport);
+        volatile cpmux_t *cpmux = cpm2_map(im_cpmux);
 
         /* SMC1 is only on port D */
         io->iop_ppard |= 0x00c00000;
@@ -97,13 +102,17 @@ void smc1_lineif(struct uart_cpm_port *pinfo)
         io->iop_psord &= ~0x00c00000;
 
         /* Wire BRG1 to SMC1 */
-        cpm2_immr->im_cpmux.cmx_smr &= 0x0f;
+        cpmux->cmx_smr &= 0x0f;
         pinfo->brg = 1;
+
+        cpm2_unmap(cpmux);
+        cpm2_unmap(io);
 }
 
 void smc2_lineif(struct uart_cpm_port *pinfo)
 {
-        volatile iop_cpm2_t *io = &cpm2_immr->im_ioport;
+        volatile iop_cpm2_t *io = cpm2_map(im_ioport);
+        volatile cpmux_t *cpmux = cpm2_map(im_cpmux);
 
         /* SMC2 is only on port A */
         io->iop_ppara |= 0x00c00000;
@@ -112,13 +121,17 @@ void smc2_lineif(struct uart_cpm_port *pinfo)
         io->iop_psora &= ~0x00c00000;
 
         /* Wire BRG2 to SMC2 */
-        cpm2_immr->im_cpmux.cmx_smr &= 0xf0;
+        cpmux->cmx_smr &= 0xf0;
         pinfo->brg = 2;
+
+        cpm2_unmap(cpmux);
+        cpm2_unmap(io);
 }
 
 void scc1_lineif(struct uart_cpm_port *pinfo)
 {
-        volatile iop_cpm2_t *io = &cpm2_immr->im_ioport;
+        volatile iop_cpm2_t *io = cpm2_map(im_ioport);
+        volatile cpmux_t *cpmux = cpm2_map(im_cpmux);
 
         /* Use Port D for SCC1 instead of other functions.  */
         io->iop_ppard |= 0x00000003;
@@ -128,9 +141,12 @@ void scc1_lineif(struct uart_cpm_port *pinfo)
         io->iop_pdird |= 0x00000002;    /* Tx */
 
         /* Wire BRG1 to SCC1 */
-        cpm2_immr->im_cpmux.cmx_scr &= 0x00ffffff;
-        cpm2_immr->im_cpmux.cmx_scr |= 0x00000000;
+        cpmux->cmx_scr &= 0x00ffffff;
+        cpmux->cmx_scr |= 0x00000000;
         pinfo->brg = 1;
+
+        cpm2_unmap(cpmux);
+        cpm2_unmap(io);
 }
 
 void scc2_lineif(struct uart_cpm_port *pinfo)
@@ -143,43 +159,57 @@ void scc2_lineif(struct uart_cpm_port *pinfo)
          * be supported in a sane fashion.
          */
 #ifndef CONFIG_STX_GP3
-        volatile iop_cpm2_t *io = &cpm2_immr->im_ioport;
+        volatile iop_cpm2_t *io = cpm2_map(im_ioport);
+        volatile cpmux_t *cpmux = cpm2_map(im_cpmux);
+
         io->iop_pparb |= 0x008b0000;
         io->iop_pdirb |= 0x00880000;
         io->iop_psorb |= 0x00880000;
         io->iop_pdirb &= ~0x00030000;
         io->iop_psorb &= ~0x00030000;
 #endif
-        cpm2_immr->im_cpmux.cmx_scr &= 0xff00ffff;
-        cpm2_immr->im_cpmux.cmx_scr |= 0x00090000;
+        cpmux->cmx_scr &= 0xff00ffff;
+        cpmux->cmx_scr |= 0x00090000;
         pinfo->brg = 2;
+
+        cpm2_unmap(cpmux);
+        cpm2_unmap(io);
 }
 
 void scc3_lineif(struct uart_cpm_port *pinfo)
 {
-        volatile iop_cpm2_t *io = &cpm2_immr->im_ioport;
+        volatile iop_cpm2_t *io = cpm2_map(im_ioport);
+        volatile cpmux_t *cpmux = cpm2_map(im_cpmux);
+
         io->iop_pparb |= 0x008b0000;
         io->iop_pdirb |= 0x00880000;
         io->iop_psorb |= 0x00880000;
         io->iop_pdirb &= ~0x00030000;
         io->iop_psorb &= ~0x00030000;
-        cpm2_immr->im_cpmux.cmx_scr &= 0xffff00ff;
-        cpm2_immr->im_cpmux.cmx_scr |= 0x00001200;
+        cpmux->cmx_scr &= 0xffff00ff;
+        cpmux->cmx_scr |= 0x00001200;
         pinfo->brg = 3;
+
+        cpm2_unmap(cpmux);
+        cpm2_unmap(io);
 }
 
 void scc4_lineif(struct uart_cpm_port *pinfo)
 {
-        volatile iop_cpm2_t *io = &cpm2_immr->im_ioport;
+        volatile iop_cpm2_t *io = cpm2_map(im_ioport);
+        volatile cpmux_t *cpmux = cpm2_map(im_cpmux);
 
         io->iop_ppard |= 0x00000600;
         io->iop_psord &= ~0x00000600;   /* Tx/Rx */
         io->iop_pdird &= ~0x00000200;   /* Rx */
         io->iop_pdird |= 0x00000400;    /* Tx */
 
-        cpm2_immr->im_cpmux.cmx_scr &= 0xffffff00;
-        cpm2_immr->im_cpmux.cmx_scr |= 0x0000001b;
+        cpmux->cmx_scr &= 0xffffff00;
+        cpmux->cmx_scr |= 0x0000001b;
         pinfo->brg = 4;
+
+        cpm2_unmap(cpmux);
+        cpm2_unmap(io);
 }
 
 /*
@@ -254,88 +284,103 @@ void cpm_uart_freebuf(struct uart_cpm_port *pinfo)
 /* Setup any dynamic params in the uart desc */
 int cpm_uart_init_portdesc(void)
 {
+#if defined(CONFIG_SERIAL_CPM_SMC1) || defined(CONFIG_SERIAL_CPM_SMC2)
+        u32 addr;
+#endif
         pr_debug("CPM uart[-]:init portdesc\n");
 
         cpm_uart_nr = 0;
 #ifdef CONFIG_SERIAL_CPM_SMC1
-        cpm_uart_ports[UART_SMC1].smcp = (smc_t *) & cpm2_immr->im_smc[0];
-        cpm_uart_ports[UART_SMC1].smcup =
-            (smc_uart_t *) & cpm2_immr->im_dprambase[PROFF_SMC1];
-        *(u16 *)(&cpm2_immr->im_dprambase[PROFF_SMC1_BASE]) = PROFF_SMC1;
+        cpm_uart_ports[UART_SMC1].smcp = (smc_t *) cpm2_map(im_smc[0]);
         cpm_uart_ports[UART_SMC1].port.mapbase =
-            (unsigned long)&cpm2_immr->im_smc[0];
+            (unsigned long)cpm_uart_ports[UART_SMC1].smcp;
+
+        cpm_uart_ports[UART_SMC1].smcup =
+            (smc_uart_t *) cpm2_map_size(im_dprambase[PROFF_SMC1], PROFF_SMC_SIZE);
+        addr = (u16 *)cpm2_map_size(im_dprambase[PROFF_SMC1_BASE], 2);
+        *addr = PROFF_SMC1;
+        cpm2_unmap(addr);
+
         cpm_uart_ports[UART_SMC1].smcp->smc_smcm |= (SMCM_RX | SMCM_TX);
         cpm_uart_ports[UART_SMC1].smcp->smc_smcmr &= ~(SMCMR_REN | SMCMR_TEN);
-        cpm_uart_ports[UART_SMC1].port.uartclk = (((bd_t *) __res)->bi_intfreq);
+        cpm_uart_ports[UART_SMC1].port.uartclk = uart_clock();
         cpm_uart_port_map[cpm_uart_nr++] = UART_SMC1;
 #endif
 
 #ifdef CONFIG_SERIAL_CPM_SMC2
-        cpm_uart_ports[UART_SMC2].smcp = (smc_t *) & cpm2_immr->im_smc[1];
-        cpm_uart_ports[UART_SMC2].smcup =
-            (smc_uart_t *) & cpm2_immr->im_dprambase[PROFF_SMC2];
-        *(u16 *)(&cpm2_immr->im_dprambase[PROFF_SMC2_BASE]) = PROFF_SMC2;
+        cpm_uart_ports[UART_SMC2].smcp = (smc_t *) cpm2_map(im_smc[1]);
         cpm_uart_ports[UART_SMC2].port.mapbase =
-            (unsigned long)&cpm2_immr->im_smc[1];
+            (unsigned long)cpm_uart_ports[UART_SMC2].smcp;
+
+        cpm_uart_ports[UART_SMC2].smcup =
+            (smc_uart_t *) cpm2_map_size(im_dprambase[PROFF_SMC2], PROFF_SMC_SIZE);
+        addr = (u16 *)cpm2_map_size(im_dprambase[PROFF_SMC2_BASE], 2);
+        *addr = PROFF_SMC2;
+        cpm2_unmap(addr);
+
         cpm_uart_ports[UART_SMC2].smcp->smc_smcm |= (SMCM_RX | SMCM_TX);
         cpm_uart_ports[UART_SMC2].smcp->smc_smcmr &= ~(SMCMR_REN | SMCMR_TEN);
-        cpm_uart_ports[UART_SMC2].port.uartclk = (((bd_t *) __res)->bi_intfreq);
+        cpm_uart_ports[UART_SMC2].port.uartclk = uart_clock();
         cpm_uart_port_map[cpm_uart_nr++] = UART_SMC2;
 #endif
 
 #ifdef CONFIG_SERIAL_CPM_SCC1
-        cpm_uart_ports[UART_SCC1].sccp = (scc_t *) & cpm2_immr->im_scc[0];
-        cpm_uart_ports[UART_SCC1].sccup =
-            (scc_uart_t *) & cpm2_immr->im_dprambase[PROFF_SCC1];
+        cpm_uart_ports[UART_SCC1].sccp = (scc_t *) cpm2_map(im_scc[0]);
         cpm_uart_ports[UART_SCC1].port.mapbase =
-            (unsigned long)&cpm2_immr->im_scc[0];
+            (unsigned long)cpm_uart_ports[UART_SCC1].sccp;
+        cpm_uart_ports[UART_SCC1].sccup =
+            (scc_uart_t *) cpm2_map_size(im_dprambase[PROFF_SCC1], PROFF_SCC_SIZE);
+
         cpm_uart_ports[UART_SCC1].sccp->scc_sccm &=
             ~(UART_SCCM_TX | UART_SCCM_RX);
         cpm_uart_ports[UART_SCC1].sccp->scc_gsmrl &=
             ~(SCC_GSMRL_ENR | SCC_GSMRL_ENT);
-        cpm_uart_ports[UART_SCC1].port.uartclk = (((bd_t *) __res)->bi_intfreq);
+        cpm_uart_ports[UART_SCC1].port.uartclk = uart_clock();
         cpm_uart_port_map[cpm_uart_nr++] = UART_SCC1;
 #endif
 
 #ifdef CONFIG_SERIAL_CPM_SCC2
-        cpm_uart_ports[UART_SCC2].sccp = (scc_t *) & cpm2_immr->im_scc[1];
-        cpm_uart_ports[UART_SCC2].sccup =
-            (scc_uart_t *) & cpm2_immr->im_dprambase[PROFF_SCC2];
+        cpm_uart_ports[UART_SCC2].sccp = (scc_t *) cpm2_map(im_scc[1]);
         cpm_uart_ports[UART_SCC2].port.mapbase =
-            (unsigned long)&cpm2_immr->im_scc[1];
+            (unsigned long)cpm_uart_ports[UART_SCC2].sccp;
+        cpm_uart_ports[UART_SCC2].sccup =
+            (scc_uart_t *) cpm2_map_size(im_dprambase[PROFF_SCC2], PROFF_SCC_SIZE);
+
         cpm_uart_ports[UART_SCC2].sccp->scc_sccm &=
             ~(UART_SCCM_TX | UART_SCCM_RX);
         cpm_uart_ports[UART_SCC2].sccp->scc_gsmrl &=
             ~(SCC_GSMRL_ENR | SCC_GSMRL_ENT);
-        cpm_uart_ports[UART_SCC2].port.uartclk = (((bd_t *) __res)->bi_intfreq);
+        cpm_uart_ports[UART_SCC2].port.uartclk = uart_clock();
         cpm_uart_port_map[cpm_uart_nr++] = UART_SCC2;
 #endif
 
 #ifdef CONFIG_SERIAL_CPM_SCC3
-        cpm_uart_ports[UART_SCC3].sccp = (scc_t *) & cpm2_immr->im_scc[2];
-        cpm_uart_ports[UART_SCC3].sccup =
-            (scc_uart_t *) & cpm2_immr->im_dprambase[PROFF_SCC3];
+        cpm_uart_ports[UART_SCC3].sccp = (scc_t *) cpm2_map(im_scc[2]);
         cpm_uart_ports[UART_SCC3].port.mapbase =
-            (unsigned long)&cpm2_immr->im_scc[2];
+            (unsigned long)cpm_uart_ports[UART_SCC3].sccp;
+        cpm_uart_ports[UART_SCC3].sccup =
+            (scc_uart_t *) cpm2_map_size(im_dprambase[PROFF_SCC3], PROFF_SCC_SIZE);
+
         cpm_uart_ports[UART_SCC3].sccp->scc_sccm &=
             ~(UART_SCCM_TX | UART_SCCM_RX);
         cpm_uart_ports[UART_SCC3].sccp->scc_gsmrl &=
             ~(SCC_GSMRL_ENR | SCC_GSMRL_ENT);
-        cpm_uart_ports[UART_SCC3].port.uartclk = (((bd_t *) __res)->bi_intfreq);
+        cpm_uart_ports[UART_SCC3].port.uartclk = uart_clock();
         cpm_uart_port_map[cpm_uart_nr++] = UART_SCC3;
 #endif
 
 #ifdef CONFIG_SERIAL_CPM_SCC4
-        cpm_uart_ports[UART_SCC4].sccp = (scc_t *) & cpm2_immr->im_scc[3];
-        cpm_uart_ports[UART_SCC4].sccup =
-            (scc_uart_t *) & cpm2_immr->im_dprambase[PROFF_SCC4];
+        cpm_uart_ports[UART_SCC4].sccp = (scc_t *) cpm2_map(im_scc[3]);
         cpm_uart_ports[UART_SCC4].port.mapbase =
-            (unsigned long)&cpm2_immr->im_scc[3];
+            (unsigned long)cpm_uart_ports[UART_SCC4].sccp;
+        cpm_uart_ports[UART_SCC4].sccup =
+            (scc_uart_t *) cpm2_map_size(im_dprambase[PROFF_SCC4], PROFF_SCC_SIZE);
+
         cpm_uart_ports[UART_SCC4].sccp->scc_sccm &=
             ~(UART_SCCM_TX | UART_SCCM_RX);
         cpm_uart_ports[UART_SCC4].sccp->scc_gsmrl &=
             ~(SCC_GSMRL_ENR | SCC_GSMRL_ENT);
-        cpm_uart_ports[UART_SCC4].port.uartclk = (((bd_t *) __res)->bi_intfreq);
+        cpm_uart_ports[UART_SCC4].port.uartclk = uart_clock();
         cpm_uart_port_map[cpm_uart_nr++] = UART_SCC4;
 #endif
 
diff --git a/drivers/serial/cpm_uart/cpm_uart_cpm2.h b/drivers/serial/cpm_uart/cpm_uart_cpm2.h
index 4793fecf8ece..a663300d3476 100644
--- a/drivers/serial/cpm_uart/cpm_uart_cpm2.h
+++ b/drivers/serial/cpm_uart/cpm_uart_cpm2.h
@@ -40,6 +40,6 @@ static inline void cpm_set_smc_fcr(volatile smc_uart_t * up)
         up->smc_tfcr = CPMFCR_GBL | CPMFCR_EB;
 }
 
-#define DPRAM_BASE      ((unsigned char *)&cpm2_immr->im_dprambase[0])
+#define DPRAM_BASE      ((unsigned char *)cpm_dpram_addr(0))
 
 #endif
diff --git a/drivers/serial/crisv10.c b/drivers/serial/crisv10.c
index cabd048c8636..9851d9eff022 100644
--- a/drivers/serial/crisv10.c
+++ b/drivers/serial/crisv10.c
@@ -4825,7 +4825,7 @@ show_serial_version(void)
 
 /* rs_init inits the driver at boot (using the module_init chain) */
 
-static struct tty_operations rs_ops = {
+static const struct tty_operations rs_ops = {
         .open = rs_open,
         .close = rs_close,
         .write = rs_write,
diff --git a/drivers/serial/ioc4_serial.c b/drivers/serial/ioc4_serial.c
index 576ca1eaa2b6..5ec4716c99bf 100644
--- a/drivers/serial/ioc4_serial.c
+++ b/drivers/serial/ioc4_serial.c
@@ -2685,6 +2685,7 @@ static int ioc4_serial_remove_one(struct ioc4_driver_data *idd)
         if (soft) {
                 free_irq(control->ic_irq, soft);
                 if (soft->is_ioc4_serial_addr) {
+                        iounmap(soft->is_ioc4_serial_addr);
                         release_region((unsigned long)
                              soft->is_ioc4_serial_addr,
                                 sizeof(struct ioc4_serial));
@@ -2887,6 +2888,8 @@ out4:
 out3:
         kfree(control);
 out2:
+        if (serial)
+                iounmap(serial);
         release_region(tmp_addr1, sizeof(struct ioc4_serial));
 out1:
 
diff --git a/drivers/serial/ip22zilog.c b/drivers/serial/ip22zilog.c
index 5ff269fb604c..dbf13c03a1bb 100644
--- a/drivers/serial/ip22zilog.c
+++ b/drivers/serial/ip22zilog.c
@@ -1229,13 +1229,27 @@ static int __init ip22zilog_init(void)
 static void __exit ip22zilog_exit(void)
 {
         int i;
+        struct uart_ip22zilog_port *up;
 
         for (i = 0; i < NUM_CHANNELS; i++) {
-                struct uart_ip22zilog_port *up = &ip22zilog_port_table[i];
+                up = &ip22zilog_port_table[i];
 
                 uart_remove_one_port(&ip22zilog_reg, &up->port);
         }
 
+        /* Free IO mem */
+        up = &ip22zilog_port_table[0];
+        for (i = 0; i < NUM_IP22ZILOG; i++) {
+                if (up[(i * 2) + 0].port.mapbase) {
+                   iounmap((void*)up[(i * 2) + 0].port.mapbase);
+                   up[(i * 2) + 0].port.mapbase = 0;
+                }
+                if (up[(i * 2) + 1].port.mapbase) {
+                        iounmap((void*)up[(i * 2) + 1].port.mapbase);
+                        up[(i * 2) + 1].port.mapbase = 0;
+                }
+        }
+
         uart_unregister_driver(&ip22zilog_reg);
 }
 
diff --git a/drivers/serial/mcfserial.c b/drivers/serial/mcfserial.c
index 832abd3c4706..00d7859c167e 100644
--- a/drivers/serial/mcfserial.c
+++ b/drivers/serial/mcfserial.c
@@ -1666,7 +1666,7 @@ static void show_serial_version(void)
         printk(mcfrs_drivername);
 }
 
-static struct tty_operations mcfrs_ops = {
+static const struct tty_operations mcfrs_ops = {
         .open = mcfrs_open,
         .close = mcfrs_close,
         .write = mcfrs_write,
diff --git a/drivers/serial/mpc52xx_uart.c b/drivers/serial/mpc52xx_uart.c
index 7708e5dd3656..dbad0e31e005 100644
--- a/drivers/serial/mpc52xx_uart.c
+++ b/drivers/serial/mpc52xx_uart.c
@@ -338,14 +338,23 @@ mpc52xx_uart_release_port(struct uart_port *port)
 static int
 mpc52xx_uart_request_port(struct uart_port *port)
 {
+        int err;
+
         if (port->flags & UPF_IOREMAP) /* Need to remap ? */
                 port->membase = ioremap(port->mapbase, MPC52xx_PSC_SIZE);
 
         if (!port->membase)
                 return -EINVAL;
 
-        return request_mem_region(port->mapbase, MPC52xx_PSC_SIZE,
+        err = request_mem_region(port->mapbase, MPC52xx_PSC_SIZE,
                         "mpc52xx_psc_uart") != NULL ? 0 : -EBUSY;
+
+        if (err && (port->flags & UPF_IOREMAP)) {
+                iounmap(port->membase);
+                port->membase = NULL;
+        }
+
+        return err;
 }
 
 static void
diff --git a/drivers/serial/mpsc.c b/drivers/serial/mpsc.c
index 63d2a66e563b..704243c9f78a 100644
--- a/drivers/serial/mpsc.c
+++ b/drivers/serial/mpsc.c
@@ -1893,6 +1893,10 @@ mpsc_drv_map_regs(struct mpsc_port_info *pi, struct platform_device *pd)
         }
         else {
                 mpsc_resource_err("SDMA base");
+                if (pi->mpsc_base) {
+                        iounmap(pi->mpsc_base);
+                        pi->mpsc_base = NULL;
+                }
                 return -ENOMEM;
         }
 
@@ -1905,6 +1909,14 @@ mpsc_drv_map_regs(struct mpsc_port_info *pi, struct platform_device *pd)
         }
         else {
                 mpsc_resource_err("BRG base");
+                if (pi->mpsc_base) {
+                        iounmap(pi->mpsc_base);
+                        pi->mpsc_base = NULL;
+                }
+                if (pi->sdma_base) {
+                        iounmap(pi->sdma_base);
+                        pi->sdma_base = NULL;
+                }
                 return -ENOMEM;
         }
 
diff --git a/drivers/serial/mux.c b/drivers/serial/mux.c
index 4a1c9983f38f..aa819d3f8ee5 100644
--- a/drivers/serial/mux.c
+++ b/drivers/serial/mux.c
@@ -521,6 +521,8 @@ static void __exit mux_exit(void)
 
         for (i = 0; i < port_cnt; i++) {
                 uart_remove_one_port(&mux_driver, &mux_ports[i]);
+                if (mux_ports[i].membase)
+                        iounmap(mux_ports[i].membase);
         }
 
         uart_unregister_driver(&mux_driver);
diff --git a/drivers/serial/serial_core.c b/drivers/serial/serial_core.c
index 397147a7054f..c67b05e9a451 100644
--- a/drivers/serial/serial_core.c
+++ b/drivers/serial/serial_core.c
@@ -2117,7 +2117,7 @@ uart_configure_port(struct uart_driver *drv, struct uart_state *state,
         }
 }
 
-static struct tty_operations uart_ops = {
+static const struct tty_operations uart_ops = {
         .open           = uart_open,
         .close          = uart_close,
         .write          = uart_write,
diff --git a/drivers/serial/sunsu.c b/drivers/serial/sunsu.c
index d3a5aeee73a3..9b3b9aaa6b90 100644
--- a/drivers/serial/sunsu.c
+++ b/drivers/serial/sunsu.c
@@ -1499,6 +1499,9 @@ static int __devexit su_remove(struct of_device *dev)
                 uart_remove_one_port(&sunsu_reg, &up->port);
         }
 
+        if (up->port.membase)
+                of_iounmap(up->port.membase, up->reg_size);
+
         dev_set_drvdata(&dev->dev, NULL);
 
         return 0;