aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/scsi
diff options
context:
space:
mode:
Diffstat (limited to 'drivers/scsi')
-rw-r--r--drivers/scsi/NCR5380.c61
-rw-r--r--drivers/scsi/NCR5380.h6
-rw-r--r--drivers/scsi/arm/cumana_1.c1
-rw-r--r--drivers/scsi/arm/oak.c6
-rw-r--r--drivers/scsi/dtc.c3
-rw-r--r--drivers/scsi/dtc.h3
-rw-r--r--drivers/scsi/g_NCR5380.c51
-rw-r--r--drivers/scsi/mac_scsi.c3
-rw-r--r--drivers/scsi/mac_scsi.h3
-rw-r--r--drivers/scsi/pas16.c3
-rw-r--r--drivers/scsi/pas16.h3
-rw-r--r--drivers/scsi/t128.c3
-rw-r--r--drivers/scsi/t128.h3
13 files changed, 71 insertions, 78 deletions
diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c
index 450353e04dde..1e9d6ad9302b 100644
--- a/drivers/scsi/NCR5380.c
+++ b/drivers/scsi/NCR5380.c
@@ -695,33 +695,35 @@ static void NCR5380_print_status(struct Scsi_Host *instance)
695 * Return the number of bytes read from or written 695 * Return the number of bytes read from or written
696 */ 696 */
697 697
698static int __maybe_unused NCR5380_write_info(struct Scsi_Host *instance,
699 char *buffer, int length)
700{
701#ifdef DTC_PUBLIC_RELEASE
702 dtc_wmaxi = dtc_maxi = 0;
703#endif
704#ifdef PAS16_PUBLIC_RELEASE
705 pas_wmaxi = pas_maxi = 0;
706#endif
707 return (-ENOSYS); /* Currently this is a no-op */
708}
709
698#undef SPRINTF 710#undef SPRINTF
699#define SPRINTF(args...) do { if(pos < buffer + length-80) pos += sprintf(pos, ## args); } while(0) 711#define SPRINTF(args...) seq_printf(m, ## args)
700static 712static
701char *lprint_Scsi_Cmnd(Scsi_Cmnd * cmd, char *pos, char *buffer, int length); 713void lprint_Scsi_Cmnd(Scsi_Cmnd * cmd, struct seq_file *m);
702static 714static
703char *lprint_command(unsigned char *cmd, char *pos, char *buffer, int len); 715void lprint_command(unsigned char *cmd, struct seq_file *m);
704static 716static
705char *lprint_opcode(int opcode, char *pos, char *buffer, int length); 717void lprint_opcode(int opcode, struct seq_file *m);
706 718
707static int __maybe_unused NCR5380_proc_info(struct Scsi_Host *instance, 719static int __maybe_unused NCR5380_show_info(struct seq_file *m,
708 char *buffer, char **start, off_t offset, int length, int inout) 720 struct Scsi_Host *instance)
709{ 721{
710 char *pos = buffer;
711 struct NCR5380_hostdata *hostdata; 722 struct NCR5380_hostdata *hostdata;
712 Scsi_Cmnd *ptr; 723 Scsi_Cmnd *ptr;
713 724
714 hostdata = (struct NCR5380_hostdata *) instance->hostdata; 725 hostdata = (struct NCR5380_hostdata *) instance->hostdata;
715 726
716 if (inout) { /* Has data been written to the file ? */
717#ifdef DTC_PUBLIC_RELEASE
718 dtc_wmaxi = dtc_maxi = 0;
719#endif
720#ifdef PAS16_PUBLIC_RELEASE
721 pas_wmaxi = pas_maxi = 0;
722#endif
723 return (-ENOSYS); /* Currently this is a no-op */
724 }
725 SPRINTF("NCR5380 core release=%d. ", NCR5380_PUBLIC_RELEASE); 727 SPRINTF("NCR5380 core release=%d. ", NCR5380_PUBLIC_RELEASE);
726 if (((struct NCR5380_hostdata *) instance->hostdata)->flags & FLAG_NCR53C400) 728 if (((struct NCR5380_hostdata *) instance->hostdata)->flags & FLAG_NCR53C400)
727 SPRINTF("ncr53c400 release=%d. ", NCR53C400_PUBLIC_RELEASE); 729 SPRINTF("ncr53c400 release=%d. ", NCR53C400_PUBLIC_RELEASE);
@@ -755,46 +757,37 @@ static int __maybe_unused NCR5380_proc_info(struct Scsi_Host *instance,
755 if (!hostdata->connected) 757 if (!hostdata->connected)
756 SPRINTF("scsi%d: no currently connected command\n", instance->host_no); 758 SPRINTF("scsi%d: no currently connected command\n", instance->host_no);
757 else 759 else
758 pos = lprint_Scsi_Cmnd((Scsi_Cmnd *) hostdata->connected, pos, buffer, length); 760 lprint_Scsi_Cmnd((Scsi_Cmnd *) hostdata->connected, m);
759 SPRINTF("scsi%d: issue_queue\n", instance->host_no); 761 SPRINTF("scsi%d: issue_queue\n", instance->host_no);
760 for (ptr = (Scsi_Cmnd *) hostdata->issue_queue; ptr; ptr = (Scsi_Cmnd *) ptr->host_scribble) 762 for (ptr = (Scsi_Cmnd *) hostdata->issue_queue; ptr; ptr = (Scsi_Cmnd *) ptr->host_scribble)
761 pos = lprint_Scsi_Cmnd(ptr, pos, buffer, length); 763 lprint_Scsi_Cmnd(ptr, m);
762 764
763 SPRINTF("scsi%d: disconnected_queue\n", instance->host_no); 765 SPRINTF("scsi%d: disconnected_queue\n", instance->host_no);
764 for (ptr = (Scsi_Cmnd *) hostdata->disconnected_queue; ptr; ptr = (Scsi_Cmnd *) ptr->host_scribble) 766 for (ptr = (Scsi_Cmnd *) hostdata->disconnected_queue; ptr; ptr = (Scsi_Cmnd *) ptr->host_scribble)
765 pos = lprint_Scsi_Cmnd(ptr, pos, buffer, length); 767 lprint_Scsi_Cmnd(ptr, m);
766 spin_unlock_irq(instance->host_lock); 768 spin_unlock_irq(instance->host_lock);
767 769 return 0;
768 *start = buffer;
769 if (pos - buffer < offset)
770 return 0;
771 else if (pos - buffer - offset < length)
772 return pos - buffer - offset;
773 return length;
774} 770}
775 771
776static char *lprint_Scsi_Cmnd(Scsi_Cmnd * cmd, char *pos, char *buffer, int length) 772static void lprint_Scsi_Cmnd(Scsi_Cmnd * cmd, struct seq_file *m)
777{ 773{
778 SPRINTF("scsi%d : destination target %d, lun %d\n", cmd->device->host->host_no, cmd->device->id, cmd->device->lun); 774 SPRINTF("scsi%d : destination target %d, lun %d\n", cmd->device->host->host_no, cmd->device->id, cmd->device->lun);
779 SPRINTF(" command = "); 775 SPRINTF(" command = ");
780 pos = lprint_command(cmd->cmnd, pos, buffer, length); 776 lprint_command(cmd->cmnd, m);
781 return (pos);
782} 777}
783 778
784static char *lprint_command(unsigned char *command, char *pos, char *buffer, int length) 779static void lprint_command(unsigned char *command, struct seq_file *m)
785{ 780{
786 int i, s; 781 int i, s;
787 pos = lprint_opcode(command[0], pos, buffer, length); 782 lprint_opcode(command[0], m);
788 for (i = 1, s = COMMAND_SIZE(command[0]); i < s; ++i) 783 for (i = 1, s = COMMAND_SIZE(command[0]); i < s; ++i)
789 SPRINTF("%02x ", command[i]); 784 SPRINTF("%02x ", command[i]);
790 SPRINTF("\n"); 785 SPRINTF("\n");
791 return (pos);
792} 786}
793 787
794static char *lprint_opcode(int opcode, char *pos, char *buffer, int length) 788static void lprint_opcode(int opcode, struct seq_file *m)
795{ 789{
796 SPRINTF("%2d (0x%02x)", opcode, opcode); 790 SPRINTF("%2d (0x%02x)", opcode, opcode);
797 return (pos);
798} 791}
799 792
800 793
diff --git a/drivers/scsi/NCR5380.h b/drivers/scsi/NCR5380.h
index fd40a32b1f6f..14964d0a0e9d 100644
--- a/drivers/scsi/NCR5380.h
+++ b/drivers/scsi/NCR5380.h
@@ -314,8 +314,10 @@ static void NCR5380_print(struct Scsi_Host *instance);
314static int NCR5380_abort(Scsi_Cmnd * cmd); 314static int NCR5380_abort(Scsi_Cmnd * cmd);
315static int NCR5380_bus_reset(Scsi_Cmnd * cmd); 315static int NCR5380_bus_reset(Scsi_Cmnd * cmd);
316static int NCR5380_queue_command(struct Scsi_Host *, struct scsi_cmnd *); 316static int NCR5380_queue_command(struct Scsi_Host *, struct scsi_cmnd *);
317static int __maybe_unused NCR5380_proc_info(struct Scsi_Host *instance, 317static int __maybe_unused NCR5380_show_info(struct seq_file *,
318 char *buffer, char **start, off_t offset, int length, int inout); 318 struct Scsi_Host *);
319static int __maybe_unused NCR5380_write_info(struct Scsi_Host *instance,
320 char *buffer, int length);
319 321
320static void NCR5380_reselect(struct Scsi_Host *instance); 322static void NCR5380_reselect(struct Scsi_Host *instance);
321static int NCR5380_select(struct Scsi_Host *instance, Scsi_Cmnd * cmd, int tag); 323static int NCR5380_select(struct Scsi_Host *instance, Scsi_Cmnd * cmd, int tag);
diff --git a/drivers/scsi/arm/cumana_1.c b/drivers/scsi/arm/cumana_1.c
index c93938b246d5..b679778376c5 100644
--- a/drivers/scsi/arm/cumana_1.c
+++ b/drivers/scsi/arm/cumana_1.c
@@ -30,7 +30,6 @@
30#define NCR5380_write(reg, value) cumanascsi_write(_instance, reg, value) 30#define NCR5380_write(reg, value) cumanascsi_write(_instance, reg, value)
31#define NCR5380_intr cumanascsi_intr 31#define NCR5380_intr cumanascsi_intr
32#define NCR5380_queue_command cumanascsi_queue_command 32#define NCR5380_queue_command cumanascsi_queue_command
33#define NCR5380_proc_info cumanascsi_proc_info
34 33
35#define NCR5380_implementation_fields \ 34#define NCR5380_implementation_fields \
36 unsigned ctrl; \ 35 unsigned ctrl; \
diff --git a/drivers/scsi/arm/oak.c b/drivers/scsi/arm/oak.c
index 48facdc18002..4266eef8aca1 100644
--- a/drivers/scsi/arm/oak.c
+++ b/drivers/scsi/arm/oak.c
@@ -31,7 +31,8 @@
31#define NCR5380_write(reg, value) writeb(value, _base + ((reg) << 2)) 31#define NCR5380_write(reg, value) writeb(value, _base + ((reg) << 2))
32#define NCR5380_intr oakscsi_intr 32#define NCR5380_intr oakscsi_intr
33#define NCR5380_queue_command oakscsi_queue_command 33#define NCR5380_queue_command oakscsi_queue_command
34#define NCR5380_proc_info oakscsi_proc_info 34#define NCR5380_show_info oakscsi_show_info
35#define NCR5380_write_info oakscsi_write_info
35 36
36#define NCR5380_implementation_fields \ 37#define NCR5380_implementation_fields \
37 void __iomem *base 38 void __iomem *base
@@ -115,7 +116,8 @@ printk("reading %p len %d\n", addr, len);
115 116
116static struct scsi_host_template oakscsi_template = { 117static struct scsi_host_template oakscsi_template = {
117 .module = THIS_MODULE, 118 .module = THIS_MODULE,
118 .proc_info = oakscsi_proc_info, 119 .show_info = oakscsi_show_info,
120 .write_info = oakscsi_write_info,
119 .name = "Oak 16-bit SCSI", 121 .name = "Oak 16-bit SCSI",
120 .info = oakscsi_info, 122 .info = oakscsi_info,
121 .queuecommand = oakscsi_queue_command, 123 .queuecommand = oakscsi_queue_command,
diff --git a/drivers/scsi/dtc.c b/drivers/scsi/dtc.c
index 4b11bb04f5c4..d01f01604140 100644
--- a/drivers/scsi/dtc.c
+++ b/drivers/scsi/dtc.c
@@ -216,7 +216,8 @@ static int __init dtc_detect(struct scsi_host_template * tpnt)
216 int sig, count; 216 int sig, count;
217 217
218 tpnt->proc_name = "dtc3x80"; 218 tpnt->proc_name = "dtc3x80";
219 tpnt->proc_info = &dtc_proc_info; 219 tpnt->show_info = dtc_show_info;
220 tpnt->write_info = dtc_write_info;
220 221
221 for (count = 0; current_override < NO_OVERRIDES; ++current_override) { 222 for (count = 0; current_override < NO_OVERRIDES; ++current_override) {
222 addr = 0; 223 addr = 0;
diff --git a/drivers/scsi/dtc.h b/drivers/scsi/dtc.h
index cdc621204b66..92d7cfc3f4fc 100644
--- a/drivers/scsi/dtc.h
+++ b/drivers/scsi/dtc.h
@@ -88,7 +88,8 @@ static int dtc_bus_reset(Scsi_Cmnd *);
88#define NCR5380_queue_command dtc_queue_command 88#define NCR5380_queue_command dtc_queue_command
89#define NCR5380_abort dtc_abort 89#define NCR5380_abort dtc_abort
90#define NCR5380_bus_reset dtc_bus_reset 90#define NCR5380_bus_reset dtc_bus_reset
91#define NCR5380_proc_info dtc_proc_info 91#define NCR5380_show_info dtc_show_info
92#define NCR5380_write_info dtc_write_info
92 93
93/* 15 12 11 10 94/* 15 12 11 10
94 1001 1100 0000 0000 */ 95 1001 1100 0000 0000 */
diff --git a/drivers/scsi/g_NCR5380.c b/drivers/scsi/g_NCR5380.c
index 5041f925c191..5cec6c60ca22 100644
--- a/drivers/scsi/g_NCR5380.c
+++ b/drivers/scsi/g_NCR5380.c
@@ -745,42 +745,36 @@ static inline int NCR5380_pwrite(struct Scsi_Host *instance, unsigned char *src,
745 745
746#include "NCR5380.c" 746#include "NCR5380.c"
747 747
748#define PRINTP(x) len += sprintf(buffer+len, x) 748#define PRINTP(x) seq_printf(m, x)
749#define ANDP , 749#define ANDP ,
750 750
751static int sprint_opcode(char *buffer, int len, int opcode) 751static void sprint_opcode(struct seq_file *m, int opcode)
752{ 752{
753 int start = len;
754 PRINTP("0x%02x " ANDP opcode); 753 PRINTP("0x%02x " ANDP opcode);
755 return len - start;
756} 754}
757 755
758static int sprint_command(char *buffer, int len, unsigned char *command) 756static void sprint_command(struct seq_file *m, unsigned char *command)
759{ 757{
760 int i, s, start = len; 758 int i, s;
761 len += sprint_opcode(buffer, len, command[0]); 759 sprint_opcode(m, command[0]);
762 for (i = 1, s = COMMAND_SIZE(command[0]); i < s; ++i) 760 for (i = 1, s = COMMAND_SIZE(command[0]); i < s; ++i)
763 PRINTP("%02x " ANDP command[i]); 761 PRINTP("%02x " ANDP command[i]);
764 PRINTP("\n"); 762 PRINTP("\n");
765 return len - start;
766} 763}
767 764
768/** 765/**
769 * sprintf_Scsi_Cmnd - print a scsi command 766 * sprintf_Scsi_Cmnd - print a scsi command
770 * @buffer: buffr to print into 767 * @m: seq_fil to print into
771 * @len: buffer length
772 * @cmd: SCSI command block 768 * @cmd: SCSI command block
773 * 769 *
774 * Print out the target and command data in hex 770 * Print out the target and command data in hex
775 */ 771 */
776 772
777static int sprint_Scsi_Cmnd(char *buffer, int len, Scsi_Cmnd * cmd) 773static void sprint_Scsi_Cmnd(struct seq_file *m, Scsi_Cmnd * cmd)
778{ 774{
779 int start = len;
780 PRINTP("host number %d destination target %d, lun %d\n" ANDP cmd->device->host->host_no ANDP cmd->device->id ANDP cmd->device->lun); 775 PRINTP("host number %d destination target %d, lun %d\n" ANDP cmd->device->host->host_no ANDP cmd->device->id ANDP cmd->device->lun);
781 PRINTP(" command = "); 776 PRINTP(" command = ");
782 len += sprint_command(buffer, len, cmd->cmnd); 777 sprint_command(m, cmd->cmnd);
783 return len - start;
784} 778}
785 779
786/** 780/**
@@ -800,9 +794,8 @@ static int sprint_Scsi_Cmnd(char *buffer, int len, Scsi_Cmnd * cmd)
800 * Locks: global cli/lock for queue walk 794 * Locks: global cli/lock for queue walk
801 */ 795 */
802 796
803static int generic_NCR5380_proc_info(struct Scsi_Host *scsi_ptr, char *buffer, char **start, off_t offset, int length, int inout) 797static int generic_NCR5380_show_info(struct seq_file *m, struct Scsi_Host *scsi_ptr)
804{ 798{
805 int len = 0;
806 NCR5380_local_declare(); 799 NCR5380_local_declare();
807 unsigned long flags; 800 unsigned long flags;
808 unsigned char status; 801 unsigned char status;
@@ -853,16 +846,16 @@ static int generic_NCR5380_proc_info(struct Scsi_Host *scsi_ptr, char *buffer, c
853 PRINTP(" T:%d %s " ANDP dev->id ANDP scsi_device_type(dev->type)); 846 PRINTP(" T:%d %s " ANDP dev->id ANDP scsi_device_type(dev->type));
854 for (i = 0; i < 8; i++) 847 for (i = 0; i < 8; i++)
855 if (dev->vendor[i] >= 0x20) 848 if (dev->vendor[i] >= 0x20)
856 *(buffer + (len++)) = dev->vendor[i]; 849 seq_putc(m, dev->vendor[i]);
857 *(buffer + (len++)) = ' '; 850 seq_putc(m, ' ');
858 for (i = 0; i < 16; i++) 851 for (i = 0; i < 16; i++)
859 if (dev->model[i] >= 0x20) 852 if (dev->model[i] >= 0x20)
860 *(buffer + (len++)) = dev->model[i]; 853 seq_putc(m, dev->model[i]);
861 *(buffer + (len++)) = ' '; 854 seq_putc(m, ' ');
862 for (i = 0; i < 4; i++) 855 for (i = 0; i < 4; i++)
863 if (dev->rev[i] >= 0x20) 856 if (dev->rev[i] >= 0x20)
864 *(buffer + (len++)) = dev->rev[i]; 857 seq_putc(m, dev->rev[i]);
865 *(buffer + (len++)) = ' '; 858 seq_putc(m, ' ');
866 859
867 PRINTP("\n%10ld kb read in %5ld secs" ANDP br / 1024 ANDP tr); 860 PRINTP("\n%10ld kb read in %5ld secs" ANDP br / 1024 ANDP tr);
868 if (tr) 861 if (tr)
@@ -886,32 +879,28 @@ static int generic_NCR5380_proc_info(struct Scsi_Host *scsi_ptr, char *buffer, c
886 if (!hostdata->connected) { 879 if (!hostdata->connected) {
887 PRINTP("No currently connected command\n"); 880 PRINTP("No currently connected command\n");
888 } else { 881 } else {
889 len += sprint_Scsi_Cmnd(buffer, len, (Scsi_Cmnd *) hostdata->connected); 882 sprint_Scsi_Cmnd(m, (Scsi_Cmnd *) hostdata->connected);
890 } 883 }
891 884
892 PRINTP("issue_queue\n"); 885 PRINTP("issue_queue\n");
893 886
894 for (ptr = (Scsi_Cmnd *) hostdata->issue_queue; ptr; ptr = (Scsi_Cmnd *) ptr->host_scribble) 887 for (ptr = (Scsi_Cmnd *) hostdata->issue_queue; ptr; ptr = (Scsi_Cmnd *) ptr->host_scribble)
895 len += sprint_Scsi_Cmnd(buffer, len, ptr); 888 sprint_Scsi_Cmnd(m, ptr);
896 889
897 PRINTP("disconnected_queue\n"); 890 PRINTP("disconnected_queue\n");
898 891
899 for (ptr = (Scsi_Cmnd *) hostdata->disconnected_queue; ptr; ptr = (Scsi_Cmnd *) ptr->host_scribble) 892 for (ptr = (Scsi_Cmnd *) hostdata->disconnected_queue; ptr; ptr = (Scsi_Cmnd *) ptr->host_scribble)
900 len += sprint_Scsi_Cmnd(buffer, len, ptr); 893 sprint_Scsi_Cmnd(m, ptr);
901 894
902 *start = buffer + offset;
903 len -= offset;
904 if (len > length)
905 len = length;
906 spin_unlock_irqrestore(scsi_ptr->host_lock, flags); 895 spin_unlock_irqrestore(scsi_ptr->host_lock, flags);
907 return len; 896 return 0;
908} 897}
909 898
910#undef PRINTP 899#undef PRINTP
911#undef ANDP 900#undef ANDP
912 901
913static struct scsi_host_template driver_template = { 902static struct scsi_host_template driver_template = {
914 .proc_info = generic_NCR5380_proc_info, 903 .show_info = generic_NCR5380_show_info,
915 .name = "Generic NCR5380/NCR53C400 Scsi Driver", 904 .name = "Generic NCR5380/NCR53C400 Scsi Driver",
916 .detect = generic_NCR5380_detect, 905 .detect = generic_NCR5380_detect,
917 .release = generic_NCR5380_release_resources, 906 .release = generic_NCR5380_release_resources,
diff --git a/drivers/scsi/mac_scsi.c b/drivers/scsi/mac_scsi.c
index 24828b54773a..858075723c87 100644
--- a/drivers/scsi/mac_scsi.c
+++ b/drivers/scsi/mac_scsi.c
@@ -561,7 +561,8 @@ static int macscsi_pwrite (struct Scsi_Host *instance,
561 561
562static struct scsi_host_template driver_template = { 562static struct scsi_host_template driver_template = {
563 .proc_name = "Mac5380", 563 .proc_name = "Mac5380",
564 .proc_info = macscsi_proc_info, 564 .show_info = macscsi_show_info,
565 .write_info = macscsi_write_info,
565 .name = "Macintosh NCR5380 SCSI", 566 .name = "Macintosh NCR5380 SCSI",
566 .detect = macscsi_detect, 567 .detect = macscsi_detect,
567 .release = macscsi_release, 568 .release = macscsi_release,
diff --git a/drivers/scsi/mac_scsi.h b/drivers/scsi/mac_scsi.h
index d26e331c6c12..7dc62fce1c4c 100644
--- a/drivers/scsi/mac_scsi.h
+++ b/drivers/scsi/mac_scsi.h
@@ -72,7 +72,8 @@
72#define NCR5380_queue_command macscsi_queue_command 72#define NCR5380_queue_command macscsi_queue_command
73#define NCR5380_abort macscsi_abort 73#define NCR5380_abort macscsi_abort
74#define NCR5380_bus_reset macscsi_bus_reset 74#define NCR5380_bus_reset macscsi_bus_reset
75#define NCR5380_proc_info macscsi_proc_info 75#define NCR5380_show_info macscsi_show_info
76#define NCR5380_write_info macscsi_write_info
76 77
77#define BOARD_NORMAL 0 78#define BOARD_NORMAL 0
78#define BOARD_NCR53C400 1 79#define BOARD_NCR53C400 1
diff --git a/drivers/scsi/pas16.c b/drivers/scsi/pas16.c
index 2f72c9807b12..62f1a6031765 100644
--- a/drivers/scsi/pas16.c
+++ b/drivers/scsi/pas16.c
@@ -388,7 +388,8 @@ int __init pas16_detect(struct scsi_host_template * tpnt)
388 int count; 388 int count;
389 389
390 tpnt->proc_name = "pas16"; 390 tpnt->proc_name = "pas16";
391 tpnt->proc_info = &pas16_proc_info; 391 tpnt->show_info = pas16_show_info;
392 tpnt->write_info = pas16_write_info;
392 393
393 if (pas16_addr != 0) { 394 if (pas16_addr != 0) {
394 overrides[0].io_port = pas16_addr; 395 overrides[0].io_port = pas16_addr;
diff --git a/drivers/scsi/pas16.h b/drivers/scsi/pas16.h
index a04281cace2e..3721342835e9 100644
--- a/drivers/scsi/pas16.h
+++ b/drivers/scsi/pas16.h
@@ -163,7 +163,8 @@ static int pas16_bus_reset(Scsi_Cmnd *);
163#define NCR5380_queue_command pas16_queue_command 163#define NCR5380_queue_command pas16_queue_command
164#define NCR5380_abort pas16_abort 164#define NCR5380_abort pas16_abort
165#define NCR5380_bus_reset pas16_bus_reset 165#define NCR5380_bus_reset pas16_bus_reset
166#define NCR5380_proc_info pas16_proc_info 166#define NCR5380_show_info pas16_show_info
167#define NCR5380_write_info pas16_write_info
167 168
168/* 15 14 12 10 7 5 3 169/* 15 14 12 10 7 5 3
169 1101 0100 1010 1000 */ 170 1101 0100 1010 1000 */
diff --git a/drivers/scsi/t128.c b/drivers/scsi/t128.c
index d672d97fb84a..f1e4b4148c75 100644
--- a/drivers/scsi/t128.c
+++ b/drivers/scsi/t128.c
@@ -201,7 +201,8 @@ int __init t128_detect(struct scsi_host_template * tpnt){
201 int sig, count; 201 int sig, count;
202 202
203 tpnt->proc_name = "t128"; 203 tpnt->proc_name = "t128";
204 tpnt->proc_info = &t128_proc_info; 204 tpnt->show_info = t128_show_info;
205 tpnt->write_info = t128_write_info;
205 206
206 for (count = 0; current_override < NO_OVERRIDES; ++current_override) { 207 for (count = 0; current_override < NO_OVERRIDES; ++current_override) {
207 base = 0; 208 base = 0;
diff --git a/drivers/scsi/t128.h b/drivers/scsi/t128.h
index ada1115079c9..1df82c28e56d 100644
--- a/drivers/scsi/t128.h
+++ b/drivers/scsi/t128.h
@@ -140,7 +140,8 @@ static int t128_bus_reset(struct scsi_cmnd *);
140#define NCR5380_queue_command t128_queue_command 140#define NCR5380_queue_command t128_queue_command
141#define NCR5380_abort t128_abort 141#define NCR5380_abort t128_abort
142#define NCR5380_bus_reset t128_bus_reset 142#define NCR5380_bus_reset t128_bus_reset
143#define NCR5380_proc_info t128_proc_info 143#define NCR5380_show_info t128_show_info
144#define NCR5380_write_info t128_write_info
144 145
145/* 15 14 12 10 7 5 3 146/* 15 14 12 10 7 5 3
146 1101 0100 1010 1000 */ 147 1101 0100 1010 1000 */