5 files changed, 25 insertions, 35 deletions

diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
index 2bc30e32b67a..1fe0901e8119 100644
--- a/drivers/scsi/dpt_i2o.c
+++ b/drivers/scsi/dpt_i2o.c
@@ -271,8 +271,8 @@ rebuild_sys_tab:
                 pHba->initialized = TRUE;
                 pHba->state &= ~DPTI_STATE_RESET;
                 if (adpt_sysfs_class) {
-                        struct device *dev = device_create(adpt_sysfs_class,
-                                NULL, MKDEV(DPTI_I2O_MAJOR, pHba->unit),
+                        struct device *dev = device_create_drvdata(adpt_sysfs_class,
+                                NULL, MKDEV(DPTI_I2O_MAJOR, pHba->unit), NULL,
                                 "dpti%d", pHba->unit);
                         if (IS_ERR(dev)) {
                                 printk(KERN_WARNING"dpti%d: unable to "
diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c
index 35cd892dce04..fed0b02ebc1d 100644
--- a/drivers/scsi/hosts.c
+++ b/drivers/scsi/hosts.c
@@ -232,8 +232,8 @@ int scsi_add_host(struct Scsi_Host *shost, struct device *dev)
         }
 
         if (shost->transportt->create_work_queue) {
-                snprintf(shost->work_q_name, KOBJ_NAME_LEN, "scsi_wq_%d",
-                        shost->host_no);
+                snprintf(shost->work_q_name, sizeof(shost->work_q_name),
+                         "scsi_wq_%d", shost->host_no);
                 shost->work_q = create_singlethread_workqueue(
                                         shost->work_q_name);
                 if (!shost->work_q) {
@@ -466,7 +466,8 @@ struct Scsi_Host *scsi_host_lookup(unsigned short hostnum)
         struct device *cdev;
         struct Scsi_Host *shost = ERR_PTR(-ENXIO);
 
-        cdev = class_find_device(&shost_class, &hostnum, __scsi_host_match);
+        cdev = class_find_device(&shost_class, NULL, &hostnum,
+                                 __scsi_host_match);
         if (cdev) {
                 shost = scsi_host_get(class_to_shost(cdev));
                 put_device(cdev);
diff --git a/drivers/scsi/ide-scsi.c b/drivers/scsi/ide-scsi.c
index f843c1383a4b..538552495d48 100644
--- a/drivers/scsi/ide-scsi.c
+++ b/drivers/scsi/ide-scsi.c
@@ -84,7 +84,6 @@ typedef struct ide_scsi_obj {
         struct Scsi_Host        *host;
 
         struct ide_atapi_pc *pc;                /* Current packet command */
-        unsigned long flags;                    /* Status/Action flags */
         unsigned long transform;                /* SCSI cmd translation layer */
         unsigned long log;                      /* log flags */
 } idescsi_scsi_t;
@@ -126,23 +125,14 @@ static inline idescsi_scsi_t *drive_to_idescsi(ide_drive_t *ide_drive)
 }
 
 /*
- *      Per ATAPI device status bits.
- */
-#define IDESCSI_DRQ_INTERRUPT           0       /* DRQ interrupt device */
-
-/*
- *      ide-scsi requests.
- */
-#define IDESCSI_PC_RQ                   90
-
-/*
  *      PIO data transfer routine using the scatter gather table.
  */
 static void ide_scsi_io_buffers(ide_drive_t *drive, struct ide_atapi_pc *pc,
                                 unsigned int bcount, int write)
 {
         ide_hwif_t *hwif = drive->hwif;
-        xfer_func_t *xf = write ? hwif->output_data : hwif->input_data;
+        const struct ide_tp_ops *tp_ops = hwif->tp_ops;
+        xfer_func_t *xf = write ? tp_ops->output_data : tp_ops->input_data;
         char *buf;
         int count;
 
@@ -228,7 +218,6 @@ static int idescsi_check_condition(ide_drive_t *drive,
         rq->cmd_type = REQ_TYPE_SENSE;
         rq->cmd_flags |= REQ_PREEMPT;
         pc->timeout = jiffies + WAIT_READY;
-        pc->callback = ide_scsi_callback;
         /* NOTE! Save the failed packet command in "rq->buffer" */
         rq->buffer = (void *) failed_cmd->special;
         pc->scsi_cmd = ((struct ide_atapi_pc *) failed_cmd->special)->scsi_cmd;
@@ -237,6 +226,7 @@ static int idescsi_check_condition(ide_drive_t *drive,
                 ide_scsi_hex_dump(pc->c, 6);
         }
         rq->rq_disk = scsi->disk;
+        memcpy(rq->cmd, pc->c, 12);
         ide_do_drive_cmd(drive, rq);
         return 0;
 }
@@ -246,10 +236,9 @@ idescsi_atapi_error(ide_drive_t *drive, struct request *rq, u8 stat, u8 err)
 {
         ide_hwif_t *hwif = drive->hwif;
 
-        if (ide_read_status(drive) & (BUSY_STAT | DRQ_STAT))
+        if (hwif->tp_ops->read_status(hwif) & (BUSY_STAT | DRQ_STAT))
                 /* force an abort */
-                hwif->OUTBSYNC(hwif, WIN_IDLEIMMEDIATE,
-                               hwif->io_ports.command_addr);
+                hwif->tp_ops->exec_command(hwif, WIN_IDLEIMMEDIATE);
 
         rq->errors++;
 
@@ -421,10 +410,6 @@ static ide_startstop_t idescsi_do_request (ide_drive_t *drive, struct request *r
 
         if (blk_sense_request(rq) || blk_special_request(rq)) {
                 struct ide_atapi_pc *pc = (struct ide_atapi_pc *)rq->special;
-                idescsi_scsi_t *scsi = drive_to_idescsi(drive);
-
-                if (test_bit(IDESCSI_DRQ_INTERRUPT, &scsi->flags))
-                        pc->flags |= PC_FLAG_DRQ_INTERRUPT;
 
                 if (drive->using_dma && !idescsi_map_sg(drive, pc))
                         pc->flags |= PC_FLAG_DMA_OK;
@@ -460,11 +445,14 @@ static inline void idescsi_add_settings(ide_drive_t *drive) { ; }
 static void idescsi_setup (ide_drive_t *drive, idescsi_scsi_t *scsi)
 {
         if (drive->id && (drive->id->config & 0x0060) == 0x20)
-                set_bit (IDESCSI_DRQ_INTERRUPT, &scsi->flags);
+                set_bit(IDE_AFLAG_DRQ_INTERRUPT, &drive->atapi_flags);
         clear_bit(IDESCSI_SG_TRANSFORM, &scsi->transform);
 #if IDESCSI_DEBUG_LOG
         set_bit(IDESCSI_LOG_CMD, &scsi->log);
 #endif /* IDESCSI_DEBUG_LOG */
+
+        drive->pc_callback = ide_scsi_callback;
+
         idescsi_add_settings(drive);
 }
 
@@ -616,7 +604,6 @@ static int idescsi_queue (struct scsi_cmnd *cmd,
         pc->scsi_cmd = cmd;
         pc->done = done;
         pc->timeout = jiffies + cmd->timeout_per_command;
-        pc->callback = ide_scsi_callback;
 
         if (test_bit(IDESCSI_LOG_CMD, &scsi->log)) {
                 printk ("ide-scsi: %s: que %lu, cmd = ", drive->name, cmd->serial_number);
@@ -631,6 +618,7 @@ static int idescsi_queue (struct scsi_cmnd *cmd,
         rq->special = (char *) pc;
         rq->cmd_type = REQ_TYPE_SPECIAL;
         spin_unlock_irq(host->host_lock);
+        memcpy(rq->cmd, pc->c, 12);
         blk_execute_rq_nowait(drive->queue, scsi->disk, rq, 0, NULL);
         spin_lock_irq(host->host_lock);
         return 0;
diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c
index 5fd64e70029d..a272b9a2c869 100644
--- a/drivers/scsi/scsi_transport_fc.c
+++ b/drivers/scsi/scsi_transport_fc.c
@@ -417,15 +417,16 @@ static int fc_host_setup(struct transport_container *tc, struct device *dev,
         fc_host->next_vport_number = 0;
         fc_host->npiv_vports_inuse = 0;
 
-        snprintf(fc_host->work_q_name, KOBJ_NAME_LEN, "fc_wq_%d",
-                shost->host_no);
+        snprintf(fc_host->work_q_name, sizeof(fc_host->work_q_name),
+                 "fc_wq_%d", shost->host_no);
         fc_host->work_q = create_singlethread_workqueue(
                                         fc_host->work_q_name);
         if (!fc_host->work_q)
                 return -ENOMEM;
 
-        snprintf(fc_host->devloss_work_q_name, KOBJ_NAME_LEN, "fc_dl_%d",
-                shost->host_no);
+        snprintf(fc_host->devloss_work_q_name,
+                 sizeof(fc_host->devloss_work_q_name),
+                 "fc_dl_%d", shost->host_no);
         fc_host->devloss_work_q = create_singlethread_workqueue(
                                         fc_host->devloss_work_q_name);
         if (!fc_host->devloss_work_q) {
diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
index 3af7cbcc5c5d..043c3921164f 100644
--- a/drivers/scsi/scsi_transport_iscsi.c
+++ b/drivers/scsi/scsi_transport_iscsi.c
@@ -170,7 +170,7 @@ iscsi_create_endpoint(int dd_size)
         int err;
 
         for (id = 1; id < ISCSI_MAX_EPID; id++) {
-                dev = class_find_device(&iscsi_endpoint_class, &id,
+                dev = class_find_device(&iscsi_endpoint_class, NULL, &id,
                                         iscsi_match_epid);
                 if (!dev)
                         break;
@@ -222,7 +222,7 @@ struct iscsi_endpoint *iscsi_lookup_endpoint(u64 handle)
         struct iscsi_endpoint *ep;
         struct device *dev;
 
-        dev = class_find_device(&iscsi_endpoint_class, &handle,
+        dev = class_find_device(&iscsi_endpoint_class, NULL, &handle,
                                 iscsi_match_epid);
         if (!dev)
                 return NULL;
@@ -247,8 +247,8 @@ static int iscsi_setup_host(struct transport_container *tc, struct device *dev,
         atomic_set(&ihost->nr_scans, 0);
         mutex_init(&ihost->mutex);
 
-        snprintf(ihost->scan_workq_name, KOBJ_NAME_LEN, "iscsi_scan_%d",
-                shost->host_no);
+        snprintf(ihost->scan_workq_name, sizeof(ihost->scan_workq_name),
+                 "iscsi_scan_%d", shost->host_no);
         ihost->scan_workq = create_singlethread_workqueue(
                                                 ihost->scan_workq_name);
         if (!ihost->scan_workq)