diff options
Diffstat (limited to 'drivers/scsi/sg.c')
-rw-r--r-- | drivers/scsi/sg.c | 15 |
1 files changed, 9 insertions, 6 deletions
diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c index 78d616315d8e..5428d53f5a13 100644 --- a/drivers/scsi/sg.c +++ b/drivers/scsi/sg.c | |||
@@ -49,7 +49,7 @@ static int sg_version_num = 30534; /* 2 digits for each component */ | |||
49 | #include <linux/blkdev.h> | 49 | #include <linux/blkdev.h> |
50 | #include <linux/delay.h> | 50 | #include <linux/delay.h> |
51 | #include <linux/blktrace_api.h> | 51 | #include <linux/blktrace_api.h> |
52 | #include <linux/smp_lock.h> | 52 | #include <linux/mutex.h> |
53 | 53 | ||
54 | #include "scsi.h" | 54 | #include "scsi.h" |
55 | #include <scsi/scsi_dbg.h> | 55 | #include <scsi/scsi_dbg.h> |
@@ -103,6 +103,8 @@ static int scatter_elem_sz_prev = SG_SCATTER_SZ; | |||
103 | static int sg_add(struct device *, struct class_interface *); | 103 | static int sg_add(struct device *, struct class_interface *); |
104 | static void sg_remove(struct device *, struct class_interface *); | 104 | static void sg_remove(struct device *, struct class_interface *); |
105 | 105 | ||
106 | static DEFINE_MUTEX(sg_mutex); | ||
107 | |||
106 | static DEFINE_IDR(sg_index_idr); | 108 | static DEFINE_IDR(sg_index_idr); |
107 | static DEFINE_RWLOCK(sg_index_lock); /* Also used to lock | 109 | static DEFINE_RWLOCK(sg_index_lock); /* Also used to lock |
108 | file descriptor list for device */ | 110 | file descriptor list for device */ |
@@ -229,7 +231,7 @@ sg_open(struct inode *inode, struct file *filp) | |||
229 | int res; | 231 | int res; |
230 | int retval; | 232 | int retval; |
231 | 233 | ||
232 | lock_kernel(); | 234 | mutex_lock(&sg_mutex); |
233 | nonseekable_open(inode, filp); | 235 | nonseekable_open(inode, filp); |
234 | SCSI_LOG_TIMEOUT(3, printk("sg_open: dev=%d, flags=0x%x\n", dev, flags)); | 236 | SCSI_LOG_TIMEOUT(3, printk("sg_open: dev=%d, flags=0x%x\n", dev, flags)); |
235 | sdp = sg_get_dev(dev); | 237 | sdp = sg_get_dev(dev); |
@@ -314,7 +316,7 @@ sdp_put: | |||
314 | sg_put: | 316 | sg_put: |
315 | if (sdp) | 317 | if (sdp) |
316 | sg_put_dev(sdp); | 318 | sg_put_dev(sdp); |
317 | unlock_kernel(); | 319 | mutex_unlock(&sg_mutex); |
318 | return retval; | 320 | return retval; |
319 | } | 321 | } |
320 | 322 | ||
@@ -1092,9 +1094,9 @@ sg_unlocked_ioctl(struct file *filp, unsigned int cmd_in, unsigned long arg) | |||
1092 | { | 1094 | { |
1093 | int ret; | 1095 | int ret; |
1094 | 1096 | ||
1095 | lock_kernel(); | 1097 | mutex_lock(&sg_mutex); |
1096 | ret = sg_ioctl(filp, cmd_in, arg); | 1098 | ret = sg_ioctl(filp, cmd_in, arg); |
1097 | unlock_kernel(); | 1099 | mutex_unlock(&sg_mutex); |
1098 | 1100 | ||
1099 | return ret; | 1101 | return ret; |
1100 | } | 1102 | } |
@@ -1351,6 +1353,7 @@ static const struct file_operations sg_fops = { | |||
1351 | .mmap = sg_mmap, | 1353 | .mmap = sg_mmap, |
1352 | .release = sg_release, | 1354 | .release = sg_release, |
1353 | .fasync = sg_fasync, | 1355 | .fasync = sg_fasync, |
1356 | .llseek = no_llseek, | ||
1354 | }; | 1357 | }; |
1355 | 1358 | ||
1356 | static struct class *sg_sysfs_class; | 1359 | static struct class *sg_sysfs_class; |
@@ -1657,7 +1660,7 @@ static int sg_start_req(Sg_request *srp, unsigned char *cmd) | |||
1657 | if (sg_allow_dio && hp->flags & SG_FLAG_DIRECT_IO && | 1660 | if (sg_allow_dio && hp->flags & SG_FLAG_DIRECT_IO && |
1658 | dxfer_dir != SG_DXFER_UNKNOWN && !iov_count && | 1661 | dxfer_dir != SG_DXFER_UNKNOWN && !iov_count && |
1659 | !sfp->parentdp->device->host->unchecked_isa_dma && | 1662 | !sfp->parentdp->device->host->unchecked_isa_dma && |
1660 | blk_rq_aligned(q, hp->dxferp, dxfer_len)) | 1663 | blk_rq_aligned(q, (unsigned long)hp->dxferp, dxfer_len)) |
1661 | md = NULL; | 1664 | md = NULL; |
1662 | else | 1665 | else |
1663 | md = &map_data; | 1666 | md = &map_data; |