1 files changed, 17 insertions, 24 deletions

diff --git a/drivers/scsi/sata_sil24.c b/drivers/scsi/sata_sil24.c
index 51855d3bac64..c66548025657 100644
--- a/drivers/scsi/sata_sil24.c
+++ b/drivers/scsi/sata_sil24.c
@@ -35,6 +35,7 @@
 #include <linux/delay.h>
 #include <linux/interrupt.h>
 #include <linux/dma-mapping.h>
+#include <linux/device.h>
 #include <scsi/scsi_host.h>
 #include "scsi.h"
 #include <linux/libata.h>
@@ -225,7 +226,6 @@ struct sil24_host_priv {
 };
 
 static u8 sil24_check_status(struct ata_port *ap);
-static u8 sil24_check_err(struct ata_port *ap);
 static u32 sil24_scr_read(struct ata_port *ap, unsigned sc_reg);
 static void sil24_scr_write(struct ata_port *ap, unsigned sc_reg, u32 val);
 static void sil24_tf_read(struct ata_port *ap, struct ata_taskfile *tf);
@@ -280,7 +280,6 @@ static const struct ata_port_operations sil24_ops = {
 
         .check_status           = sil24_check_status,
         .check_altstatus        = sil24_check_status,
-        .check_err              = sil24_check_err,
         .dev_select             = ata_noop_dev_select,
 
         .tf_read                = sil24_tf_read,
@@ -363,12 +362,6 @@ static u8 sil24_check_status(struct ata_port *ap)
         return pp->tf.command;
 }
 
-static u8 sil24_check_err(struct ata_port *ap)
-{
-        struct sil24_port_priv *pp = ap->private_data;
-        return pp->tf.feature;
-}
-
 static int sil24_scr_map[] = {
         [SCR_CONTROL]   = 0,
         [SCR_STATUS]    = 1,
@@ -506,7 +499,7 @@ static void sil24_eng_timeout(struct ata_port *ap)
 
         qc = ata_qc_from_tag(ap, ap->active_tag);
         if (!qc) {
-                printk(KERN_ERR "ata%u: BUG: tiemout without command\n",
+                printk(KERN_ERR "ata%u: BUG: timeout without command\n",
                        ap->id);
                 return;
         }
@@ -520,7 +513,7 @@ static void sil24_eng_timeout(struct ata_port *ap)
          */
         printk(KERN_ERR "ata%u: command timeout\n", ap->id);
         qc->scsidone = scsi_finish_command;
-        ata_qc_complete(qc, ATA_ERR);
+        ata_qc_complete(qc, AC_ERR_OTHER);
 
         sil24_reset_controller(ap);
 }
@@ -531,6 +524,7 @@ static void sil24_error_intr(struct ata_port *ap, u32 slot_stat)
         struct sil24_port_priv *pp = ap->private_data;
         void __iomem *port = (void __iomem *)ap->ioaddr.cmd_addr;
         u32 irq_stat, cmd_err, sstatus, serror;
+        unsigned int err_mask;
 
         irq_stat = readl(port + PORT_IRQ_STAT);
         writel(irq_stat, port + PORT_IRQ_STAT);         /* clear irq */
@@ -558,17 +552,18 @@ static void sil24_error_intr(struct ata_port *ap, u32 slot_stat)
                  * Device is reporting error, tf registers are valid.
                  */
                 sil24_update_tf(ap);
+                err_mask = ac_err_mask(pp->tf.command);
         } else {
                 /*
                  * Other errors.  libata currently doesn't have any
                  * mechanism to report these errors.  Just turn on
                  * ATA_ERR.
                  */
-                pp->tf.command = ATA_ERR;
+                err_mask = AC_ERR_OTHER;
         }
 
         if (qc)
-                ata_qc_complete(qc, pp->tf.command);
+                ata_qc_complete(qc, err_mask);
 
         sil24_reset_controller(ap);
 }
@@ -593,7 +588,7 @@ static inline void sil24_host_intr(struct ata_port *ap)
                 sil24_update_tf(ap);
 
                 if (qc)
-                        ata_qc_complete(qc, pp->tf.command);
+                        ata_qc_complete(qc, ac_err_mask(pp->tf.command));
         } else
                 sil24_error_intr(ap, slot_stat);
 }
@@ -696,7 +691,7 @@ static int sil24_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
         int i, rc;
 
         if (!printed_version++)
-                printk(KERN_DEBUG DRV_NAME " version " DRV_VERSION "\n");
+                dev_printk(KERN_DEBUG, &pdev->dev, "version " DRV_VERSION "\n");
 
         rc = pci_enable_device(pdev);
         if (rc)
@@ -756,14 +751,14 @@ static int sil24_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
          */
         rc = pci_set_dma_mask(pdev, DMA_32BIT_MASK);
         if (rc) {
-                printk(KERN_ERR DRV_NAME "(%s): 32-bit DMA enable failed\n",
-                       pci_name(pdev));
+                dev_printk(KERN_ERR, &pdev->dev,
+                           "32-bit DMA enable failed\n");
                 goto out_free;
         }
         rc = pci_set_consistent_dma_mask(pdev, DMA_32BIT_MASK);
         if (rc) {
-                printk(KERN_ERR DRV_NAME "(%s): 32-bit consistent DMA enable failed\n",
-                       pci_name(pdev));
+                dev_printk(KERN_ERR, &pdev->dev,
+                           "32-bit consistent DMA enable failed\n");
                 goto out_free;
         }
 
@@ -799,9 +794,8 @@ static int sil24_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
                                         break;
                         }
                         if (tmp & PORT_CS_PORT_RST)
-                                printk(KERN_ERR DRV_NAME
-                                       "(%s): failed to clear port RST\n",
-                                       pci_name(pdev));
+                                dev_printk(KERN_ERR, &pdev->dev,
+                                           "failed to clear port RST\n");
                 }
 
                 /* Zero error counters. */
@@ -830,9 +824,8 @@ static int sil24_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 
                 /* Reset itself */
                 if (__sil24_reset_controller(port))
-                        printk(KERN_ERR DRV_NAME
-                               "(%s): failed to reset controller\n",
-                               pci_name(pdev));
+                        dev_printk(KERN_ERR, &pdev->dev,
+                                   "failed to reset controller\n");
         }
 
         /* Turn on interrupts */