1 files changed, 21 insertions, 24 deletions

diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c
index e473e9fb363c..7a7c0ecfe7dd 100644
--- a/drivers/scsi/qla2xxx/qla_mbx.c
+++ b/drivers/scsi/qla2xxx/qla_mbx.c
@@ -71,6 +71,13 @@ qla2x00_mailbox_command(scsi_qla_host_t *vha, mbx_cmd_t *mcp)
                 return QLA_FUNCTION_TIMEOUT;
         }
 
+        if (ha->flags.isp82xx_fw_hung) {
+                /* Setting Link-Down error */
+                mcp->mb[0] = MBS_LINK_DOWN_ERROR;
+                rval = QLA_FUNCTION_FAILED;
+                goto premature_exit;
+        }
+
         /*
          * Wait for active mailbox commands to finish by waiting at most tov
          * seconds. This is to serialize actual issuing of mailbox cmds during
@@ -83,13 +90,6 @@ qla2x00_mailbox_command(scsi_qla_host_t *vha, mbx_cmd_t *mcp)
                 return QLA_FUNCTION_TIMEOUT;
         }
 
-        if (IS_QLA82XX(ha) && ha->flags.fw_hung) {
-                /* Setting Link-Down error */
-                mcp->mb[0] = MBS_LINK_DOWN_ERROR;
-                rval = QLA_FUNCTION_FAILED;
-                goto premature_exit;
-        }
-
         ha->flags.mbox_busy = 1;
         /* Save mailbox command for debug */
         ha->mcp = mcp;
@@ -223,7 +223,7 @@ qla2x00_mailbox_command(scsi_qla_host_t *vha, mbx_cmd_t *mcp)
                 ha->flags.mbox_int = 0;
                 clear_bit(MBX_INTERRUPT, &ha->mbx_cmd_flags);
 
-                if (IS_QLA82XX(ha) && ha->flags.fw_hung) {
+                if (ha->flags.isp82xx_fw_hung) {
                         ha->flags.mbox_busy = 0;
                         /* Setting Link-Down error */
                         mcp->mb[0] = MBS_LINK_DOWN_ERROR;
@@ -2462,22 +2462,19 @@ __qla24xx_issue_tmf(char *name, uint32_t type, struct fc_port *fcport,
                     "-- completion status (%x).\n", __func__,
                     vha->host_no, le16_to_cpu(sts->comp_status)));
                 rval = QLA_FUNCTION_FAILED;
-        } else if (!(le16_to_cpu(sts->scsi_status) &
-            SS_RESPONSE_INFO_LEN_VALID)) {
-                DEBUG2_3_11(printk("%s(%ld): failed to complete IOCB "
-                    "-- no response info (%x).\n", __func__, vha->host_no,
-                    le16_to_cpu(sts->scsi_status)));
-                rval = QLA_FUNCTION_FAILED;
-        } else if (le32_to_cpu(sts->rsp_data_len) < 4) {
-                DEBUG2_3_11(printk("%s(%ld): failed to complete IOCB "
-                    "-- not enough response info (%d).\n", __func__,
-                    vha->host_no, le32_to_cpu(sts->rsp_data_len)));
-                rval = QLA_FUNCTION_FAILED;
-        } else if (sts->data[3]) {
-                DEBUG2_3_11(printk("%s(%ld): failed to complete IOCB "
-                    "-- response (%x).\n", __func__,
-                    vha->host_no, sts->data[3]));
-                rval = QLA_FUNCTION_FAILED;
+        } else if (le16_to_cpu(sts->scsi_status) &
+            SS_RESPONSE_INFO_LEN_VALID) {
+                if (le32_to_cpu(sts->rsp_data_len) < 4) {
+                        DEBUG2_3_11(printk("%s(%ld): ignoring inconsistent "
+                            "data length -- not enough response info (%d).\n",
+                            __func__, vha->host_no,
+                            le32_to_cpu(sts->rsp_data_len)));
+                } else if (sts->data[3]) {
+                        DEBUG2_3_11(printk("%s(%ld): failed to complete IOCB "
+                            "-- response (%x).\n", __func__,
+                            vha->host_no, sts->data[3]));
+                        rval = QLA_FUNCTION_FAILED;
+                }
         }
 
         /* Issue marker IOCB. */