1 files changed, 6 insertions, 8 deletions

diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c
index 1a058ec9bd0c..083997c3066e 100644
--- a/drivers/scsi/qla2xxx/qla_init.c
+++ b/drivers/scsi/qla2xxx/qla_init.c
@@ -1786,12 +1786,11 @@ qla2x00_alloc_fcport(scsi_qla_host_t *ha, gfp_t flags)
 {
         fc_port_t *fcport;
 
-        fcport = kmalloc(sizeof(fc_port_t), flags);
-        if (fcport == NULL)
-                return (fcport);
+        fcport = kzalloc(sizeof(fc_port_t), flags);
+        if (!fcport)
+                return NULL;
 
         /* Setup fcport template structure. */
-        memset(fcport, 0, sizeof (fc_port_t));
         fcport->ha = ha;
         fcport->vp_idx = ha->vp_idx;
         fcport->port_type = FCT_UNKNOWN;
@@ -1801,7 +1800,7 @@ qla2x00_alloc_fcport(scsi_qla_host_t *ha, gfp_t flags)
         fcport->supported_classes = FC_COS_UNSPECIFIED;
         spin_lock_init(&fcport->rport_lock);
 
-        return (fcport);
+        return fcport;
 }
 
 /*
@@ -2473,13 +2472,12 @@ qla2x00_find_all_fabric_devs(scsi_qla_host_t *ha, struct list_head *new_fcports)
         rval = QLA_SUCCESS;
 
         /* Try GID_PT to get device list, else GAN. */
-        swl = kmalloc(sizeof(sw_info_t) * MAX_FIBRE_DEVICES, GFP_ATOMIC);
-        if (swl == NULL) {
+        swl = kcalloc(MAX_FIBRE_DEVICES, sizeof(sw_info_t), GFP_ATOMIC);
+        if (!swl) {
                 /*EMPTY*/
                 DEBUG2(printk("scsi(%ld): GID_PT allocations failed, fallback "
                     "on GA_NXT\n", ha->host_no));
         } else {
-                memset(swl, 0, sizeof(sw_info_t) * MAX_FIBRE_DEVICES);
                 if (qla2x00_gid_pt(ha, swl) != QLA_SUCCESS) {
                         kfree(swl);
                         swl = NULL;