1 files changed, 92 insertions, 57 deletions

diff --git a/drivers/scsi/pm8001/pm8001_hwi.c b/drivers/scsi/pm8001/pm8001_hwi.c
index a3de306b9045..9b44c6f1b10e 100644
--- a/drivers/scsi/pm8001/pm8001_hwi.c
+++ b/drivers/scsi/pm8001/pm8001_hwi.c
@@ -373,10 +373,7 @@ static int bar4_shift(struct pm8001_hba_info *pm8001_ha, u32 shiftValue)
 static void __devinit
 mpi_set_phys_g3_with_ssc(struct pm8001_hba_info *pm8001_ha, u32 SSCbit)
 {
-        u32 offset;
-        u32 value;
-        u32 i, j;
-        u32 bit_cnt;
+        u32 value, offset, i;
 
 #define SAS2_SETTINGS_LOCAL_PHY_0_3_SHIFT_ADDR 0x00030000
 #define SAS2_SETTINGS_LOCAL_PHY_4_7_SHIFT_ADDR 0x00040000
@@ -392,55 +389,35 @@ mpi_set_phys_g3_with_ssc(struct pm8001_hba_info *pm8001_ha, u32 SSCbit)
     */
         if (-1 == bar4_shift(pm8001_ha, SAS2_SETTINGS_LOCAL_PHY_0_3_SHIFT_ADDR))
                 return;
-        /* set SSC bit of PHY 0 - 3 */
+
         for (i = 0; i < 4; i++) {
                 offset = SAS2_SETTINGS_LOCAL_PHY_0_3_OFFSET + 0x4000 * i;
-                value = pm8001_cr32(pm8001_ha, 2, offset);
-                if (SSCbit) {
-                        value |= 0x00000001 << PHY_G3_WITH_SSC_BIT_SHIFT;
-                        value &= ~(0x00000001 << PHY_G3_WITHOUT_SSC_BIT_SHIFT);
-                } else {
-                        value |= 0x00000001 << PHY_G3_WITHOUT_SSC_BIT_SHIFT;
-                        value &= ~(0x00000001 << PHY_G3_WITH_SSC_BIT_SHIFT);
-                }
-                bit_cnt = 0;
-                for (j = 0; j < 31; j++)
-                        if ((value >> j) & 0x00000001)
-                                bit_cnt++;
-                if (bit_cnt % 2)
-                        value &= ~(0x00000001 << SNW3_PHY_CAPABILITIES_PARITY);
-                else
-                        value |= 0x00000001 << SNW3_PHY_CAPABILITIES_PARITY;
-
-                pm8001_cw32(pm8001_ha, 2, offset, value);
+                pm8001_cw32(pm8001_ha, 2, offset, 0x80001501);
         }
-
         /* shift membase 3 for SAS2_SETTINGS_LOCAL_PHY 4 - 7 */
         if (-1 == bar4_shift(pm8001_ha, SAS2_SETTINGS_LOCAL_PHY_4_7_SHIFT_ADDR))
                 return;
-
-        /* set SSC bit of PHY 4 - 7 */
         for (i = 4; i < 8; i++) {
                 offset = SAS2_SETTINGS_LOCAL_PHY_4_7_OFFSET + 0x4000 * (i-4);
-                value = pm8001_cr32(pm8001_ha, 2, offset);
-                if (SSCbit) {
-                        value |= 0x00000001 << PHY_G3_WITH_SSC_BIT_SHIFT;
-                        value &= ~(0x00000001 << PHY_G3_WITHOUT_SSC_BIT_SHIFT);
-                } else {
-                        value |= 0x00000001 << PHY_G3_WITHOUT_SSC_BIT_SHIFT;
-                        value &= ~(0x00000001 << PHY_G3_WITH_SSC_BIT_SHIFT);
-                }
-                bit_cnt = 0;
-                for (j = 0; j < 31; j++)
-                        if ((value >> j) & 0x00000001)
-                                bit_cnt++;
-                if (bit_cnt % 2)
-                        value &= ~(0x00000001 << SNW3_PHY_CAPABILITIES_PARITY);
-                else
-                        value |= 0x00000001 << SNW3_PHY_CAPABILITIES_PARITY;
-
-                pm8001_cw32(pm8001_ha, 2, offset, value);
+                pm8001_cw32(pm8001_ha, 2, offset, 0x80001501);
         }
+        /*************************************************************
+        Change the SSC upspreading value to 0x0 so that upspreading is disabled.
+        Device MABC SMOD0 Controls
+        Address: (via MEMBASE-III):
+        Using shifted destination address 0x0_0000: with Offset 0xD8
+
+        31:28 R/W Reserved Do not change
+        27:24 R/W SAS_SMOD_SPRDUP 0000
+        23:20 R/W SAS_SMOD_SPRDDN 0000
+        19:0  R/W  Reserved Do not change
+        Upon power-up this register will read as 0x8990c016,
+        and I would like you to change the SAS_SMOD_SPRDUP bits to 0b0000
+        so that the written value will be 0x8090c016.
+        This will ensure only down-spreading SSC is enabled on the SPC.
+        *************************************************************/
+        value = pm8001_cr32(pm8001_ha, 2, 0xd8);
+        pm8001_cw32(pm8001_ha, 2, 0xd8, 0x8000C016);
 
         /*set the shifted destination address to 0x0 to avoid error operation */
         bar4_shift(pm8001_ha, 0x0);
@@ -1901,7 +1878,7 @@ mpi_sata_completion(struct pm8001_hba_info *pm8001_ha, void *piomb)
 {
         struct sas_task *t;
         struct pm8001_ccb_info *ccb;
-        unsigned long flags;
+        unsigned long flags = 0;
         u32 param;
         u32 status;
         u32 tag;
@@ -2040,7 +2017,9 @@ mpi_sata_completion(struct pm8001_hba_info *pm8001_ha, void *piomb)
                         ts->stat = SAS_QUEUE_FULL;
                         pm8001_ccb_task_free(pm8001_ha, t, ccb, tag);
                         mb();/*in order to force CPU ordering*/
+                        spin_unlock_irqrestore(&pm8001_ha->lock, flags);
                         t->task_done(t);
+                        spin_lock_irqsave(&pm8001_ha->lock, flags);
                         return;
                 }
                 break;
@@ -2058,7 +2037,9 @@ mpi_sata_completion(struct pm8001_hba_info *pm8001_ha, void *piomb)
                         ts->stat = SAS_QUEUE_FULL;
                         pm8001_ccb_task_free(pm8001_ha, t, ccb, tag);
                         mb();/*ditto*/
+                        spin_unlock_irqrestore(&pm8001_ha->lock, flags);
                         t->task_done(t);
+                        spin_lock_irqsave(&pm8001_ha->lock, flags);
                         return;
                 }
                 break;
@@ -2084,7 +2065,9 @@ mpi_sata_completion(struct pm8001_hba_info *pm8001_ha, void *piomb)
                         ts->stat = SAS_QUEUE_FULL;
                         pm8001_ccb_task_free(pm8001_ha, t, ccb, tag);
                         mb();/* ditto*/
+                        spin_unlock_irqrestore(&pm8001_ha->lock, flags);
                         t->task_done(t);
+                        spin_lock_irqsave(&pm8001_ha->lock, flags);
                         return;
                 }
                 break;
@@ -2149,7 +2132,9 @@ mpi_sata_completion(struct pm8001_hba_info *pm8001_ha, void *piomb)
                         ts->stat = SAS_QUEUE_FULL;
                         pm8001_ccb_task_free(pm8001_ha, t, ccb, tag);
                         mb();/*ditto*/
+                        spin_unlock_irqrestore(&pm8001_ha->lock, flags);
                         t->task_done(t);
+                        spin_lock_irqsave(&pm8001_ha->lock, flags);
                         return;
                 }
                 break;
@@ -2171,7 +2156,9 @@ mpi_sata_completion(struct pm8001_hba_info *pm8001_ha, void *piomb)
                         ts->stat = SAS_QUEUE_FULL;
                         pm8001_ccb_task_free(pm8001_ha, t, ccb, tag);
                         mb();/*ditto*/
+                        spin_unlock_irqrestore(&pm8001_ha->lock, flags);
                         t->task_done(t);
+                        spin_lock_irqsave(&pm8001_ha->lock, flags);
                         return;
                 }
                 break;
@@ -2200,11 +2187,20 @@ mpi_sata_completion(struct pm8001_hba_info *pm8001_ha, void *piomb)
                         " resp 0x%x stat 0x%x but aborted by upper layer!\n",
                         t, status, ts->resp, ts->stat));
                 pm8001_ccb_task_free(pm8001_ha, t, ccb, tag);
-        } else {
+        } else if (t->uldd_task) {
                 spin_unlock_irqrestore(&t->task_state_lock, flags);
                 pm8001_ccb_task_free(pm8001_ha, t, ccb, tag);
                 mb();/* ditto */
+                spin_unlock_irqrestore(&pm8001_ha->lock, flags);
                 t->task_done(t);
+                spin_lock_irqsave(&pm8001_ha->lock, flags);
+        } else if (!t->uldd_task) {
+                spin_unlock_irqrestore(&t->task_state_lock, flags);
+                pm8001_ccb_task_free(pm8001_ha, t, ccb, tag);
+                mb();/*ditto*/
+                spin_unlock_irqrestore(&pm8001_ha->lock, flags);
+                t->task_done(t);
+                spin_lock_irqsave(&pm8001_ha->lock, flags);
         }
 }
 
@@ -2212,7 +2208,7 @@ mpi_sata_completion(struct pm8001_hba_info *pm8001_ha, void *piomb)
 static void mpi_sata_event(struct pm8001_hba_info *pm8001_ha , void *piomb)
 {
         struct sas_task *t;
-        unsigned long flags;
+        unsigned long flags = 0;
         struct task_status_struct *ts;
         struct pm8001_ccb_info *ccb;
         struct pm8001_device *pm8001_dev;
@@ -2292,7 +2288,9 @@ static void mpi_sata_event(struct pm8001_hba_info *pm8001_ha , void *piomb)
                         ts->stat = SAS_QUEUE_FULL;
                         pm8001_ccb_task_free(pm8001_ha, t, ccb, tag);
                         mb();/*ditto*/
+                        spin_unlock_irqrestore(&pm8001_ha->lock, flags);
                         t->task_done(t);
+                        spin_lock_irqsave(&pm8001_ha->lock, flags);
                         return;
                 }
                 break;
@@ -2401,11 +2399,20 @@ static void mpi_sata_event(struct pm8001_hba_info *pm8001_ha , void *piomb)
                         " resp 0x%x stat 0x%x but aborted by upper layer!\n",
                         t, event, ts->resp, ts->stat));
                 pm8001_ccb_task_free(pm8001_ha, t, ccb, tag);
-        } else {
+        } else if (t->uldd_task) {
                 spin_unlock_irqrestore(&t->task_state_lock, flags);
                 pm8001_ccb_task_free(pm8001_ha, t, ccb, tag);
-                mb();/* in order to force CPU ordering */
+                mb();/* ditto */
+                spin_unlock_irqrestore(&pm8001_ha->lock, flags);
                 t->task_done(t);
+                spin_lock_irqsave(&pm8001_ha->lock, flags);
+        } else if (!t->uldd_task) {
+                spin_unlock_irqrestore(&t->task_state_lock, flags);
+                pm8001_ccb_task_free(pm8001_ha, t, ccb, tag);
+                mb();/*ditto*/
+                spin_unlock_irqrestore(&pm8001_ha->lock, flags);
+                t->task_done(t);
+                spin_lock_irqsave(&pm8001_ha->lock, flags);
         }
 }
 
@@ -2876,15 +2883,20 @@ hw_event_sas_phy_up(struct pm8001_hba_info *pm8001_ha, void *piomb)
                 le32_to_cpu(pPayload->lr_evt_status_phyid_portid);
         u8 link_rate =
                 (u8)((lr_evt_status_phyid_portid & 0xF0000000) >> 28);
+        u8 port_id = (u8)(lr_evt_status_phyid_portid & 0x0000000F);
         u8 phy_id =
                 (u8)((lr_evt_status_phyid_portid & 0x000000F0) >> 4);
+        u32 npip_portstate = le32_to_cpu(pPayload->npip_portstate);
+        u8 portstate = (u8)(npip_portstate & 0x0000000F);
+        struct pm8001_port *port = &pm8001_ha->port[port_id];
         struct sas_ha_struct *sas_ha = pm8001_ha->sas;
         struct pm8001_phy *phy = &pm8001_ha->phy[phy_id];
         unsigned long flags;
         u8 deviceType = pPayload->sas_identify.dev_type;
-
+        port->port_state =  portstate;
         PM8001_MSG_DBG(pm8001_ha,
-                pm8001_printk("HW_EVENT_SAS_PHY_UP \n"));
+                pm8001_printk("HW_EVENT_SAS_PHY_UP port id = %d, phy id = %d\n",
+                port_id, phy_id));
 
         switch (deviceType) {
         case SAS_PHY_UNUSED:
@@ -2895,16 +2907,19 @@ hw_event_sas_phy_up(struct pm8001_hba_info *pm8001_ha, void *piomb)
                 PM8001_MSG_DBG(pm8001_ha, pm8001_printk("end device.\n"));
                 pm8001_chip_phy_ctl_req(pm8001_ha, phy_id,
                         PHY_NOTIFY_ENABLE_SPINUP);
+                port->port_attached = 1;
                 get_lrate_mode(phy, link_rate);
                 break;
         case SAS_EDGE_EXPANDER_DEVICE:
                 PM8001_MSG_DBG(pm8001_ha,
                         pm8001_printk("expander device.\n"));
+                port->port_attached = 1;
                 get_lrate_mode(phy, link_rate);
                 break;
         case SAS_FANOUT_EXPANDER_DEVICE:
                 PM8001_MSG_DBG(pm8001_ha,
                         pm8001_printk("fanout expander device.\n"));
+                port->port_attached = 1;
                 get_lrate_mode(phy, link_rate);
                 break;
         default:
@@ -2946,11 +2961,20 @@ hw_event_sata_phy_up(struct pm8001_hba_info *pm8001_ha, void *piomb)
                 le32_to_cpu(pPayload->lr_evt_status_phyid_portid);
         u8 link_rate =
                 (u8)((lr_evt_status_phyid_portid & 0xF0000000) >> 28);
+        u8 port_id = (u8)(lr_evt_status_phyid_portid & 0x0000000F);
         u8 phy_id =
                 (u8)((lr_evt_status_phyid_portid & 0x000000F0) >> 4);
+        u32 npip_portstate = le32_to_cpu(pPayload->npip_portstate);
+        u8 portstate = (u8)(npip_portstate & 0x0000000F);
+        struct pm8001_port *port = &pm8001_ha->port[port_id];
         struct sas_ha_struct *sas_ha = pm8001_ha->sas;
         struct pm8001_phy *phy = &pm8001_ha->phy[phy_id];
         unsigned long flags;
+        PM8001_MSG_DBG(pm8001_ha,
+                pm8001_printk("HW_EVENT_SATA_PHY_UP port id = %d,"
+                " phy id = %d\n", port_id, phy_id));
+        port->port_state =  portstate;
+        port->port_attached = 1;
         get_lrate_mode(phy, link_rate);
         phy->phy_type |= PORT_TYPE_SATA;
         phy->phy_attached = 1;
@@ -2984,7 +3008,13 @@ hw_event_phy_down(struct pm8001_hba_info *pm8001_ha, void *piomb)
                 (u8)((lr_evt_status_phyid_portid & 0x000000F0) >> 4);
         u32 npip_portstate = le32_to_cpu(pPayload->npip_portstate);
         u8 portstate = (u8)(npip_portstate & 0x0000000F);
-
+        struct pm8001_port *port = &pm8001_ha->port[port_id];
+        struct pm8001_phy *phy = &pm8001_ha->phy[phy_id];
+        port->port_state =  portstate;
+        phy->phy_type = 0;
+        phy->identify.device_type = 0;
+        phy->phy_attached = 0;
+        memset(&phy->dev_sas_addr, 0, SAS_ADDR_SIZE);
         switch (portstate) {
         case PORT_VALID:
                 break;
@@ -2993,26 +3023,30 @@ hw_event_phy_down(struct pm8001_hba_info *pm8001_ha, void *piomb)
                         pm8001_printk(" PortInvalid portID %d \n", port_id));
                 PM8001_MSG_DBG(pm8001_ha,
                         pm8001_printk(" Last phy Down and port invalid\n"));
+                port->port_attached = 0;
                 pm8001_hw_event_ack_req(pm8001_ha, 0, HW_EVENT_PHY_DOWN,
                         port_id, phy_id, 0, 0);
                 break;
         case PORT_IN_RESET:
                 PM8001_MSG_DBG(pm8001_ha,
-                        pm8001_printk(" PortInReset portID %d \n", port_id));
+                        pm8001_printk(" Port In Reset portID %d \n", port_id));
                 break;
         case PORT_NOT_ESTABLISHED:
                 PM8001_MSG_DBG(pm8001_ha,
                         pm8001_printk(" phy Down and PORT_NOT_ESTABLISHED\n"));
+                port->port_attached = 0;
                 break;
         case PORT_LOSTCOMM:
                 PM8001_MSG_DBG(pm8001_ha,
                         pm8001_printk(" phy Down and PORT_LOSTCOMM\n"));
                 PM8001_MSG_DBG(pm8001_ha,
                         pm8001_printk(" Last phy Down and port invalid\n"));
+                port->port_attached = 0;
                 pm8001_hw_event_ack_req(pm8001_ha, 0, HW_EVENT_PHY_DOWN,
                         port_id, phy_id, 0, 0);
                 break;
         default:
+                port->port_attached = 0;
                 PM8001_MSG_DBG(pm8001_ha,
                         pm8001_printk(" phy Down and(default) = %x\n",
                         portstate));
@@ -3770,7 +3804,8 @@ static int pm8001_chip_ssp_io_req(struct pm8001_hba_info *pm8001_ha,
         u32 opc = OPC_INB_SSPINIIOSTART;
         memset(&ssp_cmd, 0, sizeof(ssp_cmd));
         memcpy(ssp_cmd.ssp_iu.lun, task->ssp_task.LUN, 8);
-        ssp_cmd.dir_m_tlr = data_dir_flags[task->data_dir] << 8 | 0x0;/*0 for
+        ssp_cmd.dir_m_tlr =
+                cpu_to_le32(data_dir_flags[task->data_dir] << 8 | 0x0);/*0 for
         SAS 1.1 compatible TLR*/
         ssp_cmd.data_len = cpu_to_le32(task->total_xfer_len);
         ssp_cmd.device_id = cpu_to_le32(pm8001_dev->device_id);
@@ -3841,7 +3876,7 @@ static int pm8001_chip_sata_req(struct pm8001_hba_info *pm8001_ha,
                 }
         }
         if (task->ata_task.use_ncq && pm8001_get_ncq_tag(task, &hdr_tag))
-                ncg_tag = cpu_to_le32(hdr_tag);
+                ncg_tag = hdr_tag;
         dir = data_dir_flags[task->data_dir] << 8;
         sata_cmd.tag = cpu_to_le32(tag);
         sata_cmd.device_id = cpu_to_le32(pm8001_ha_dev->device_id);
@@ -3986,7 +4021,7 @@ static int pm8001_chip_reg_dev_req(struct pm8001_hba_info *pm8001_ha,
                 ((stp_sspsmp_sata & 0x03) * 0x10000000));
         payload.firstburstsize_ITNexustimeout =
                 cpu_to_le32(ITNT | (firstBurstSize * 0x10000));
-        memcpy(&payload.sas_addr_hi, pm8001_dev->sas_device->sas_addr,
+        memcpy(payload.sas_addr, pm8001_dev->sas_device->sas_addr,
                 SAS_ADDR_SIZE);
         rc = mpi_build_cmd(pm8001_ha, circularQ, opc, &payload);
         return rc;
@@ -4027,7 +4062,7 @@ static int pm8001_chip_phy_ctl_req(struct pm8001_hba_info *pm8001_ha,
         struct inbound_queue_table *circularQ;
         int ret;
         u32 opc = OPC_INB_LOCAL_PHY_CONTROL;
-        memset((u8 *)&payload, 0, sizeof(payload));
+        memset(&payload, 0, sizeof(payload));
         circularQ = &pm8001_ha->inbnd_q_tbl[0];
         payload.tag = 1;
         payload.phyop_phyid =