1 files changed, 110 insertions, 142 deletions

diff --git a/drivers/scsi/mpt2sas/mpt2sas_scsih.c b/drivers/scsi/mpt2sas/mpt2sas_scsih.c
index 2e9a4445596f..774b34525bba 100644
--- a/drivers/scsi/mpt2sas/mpt2sas_scsih.c
+++ b/drivers/scsi/mpt2sas/mpt2sas_scsih.c
@@ -103,7 +103,6 @@ struct sense_info {
 };
 
 
-#define MPT2SAS_RESCAN_AFTER_HOST_RESET (0xFFFF)
 /**
  * struct fw_event_work - firmware event struct
  * @list: link list framework
@@ -1502,7 +1501,13 @@ _scsih_slave_configure(struct scsi_device *sdev)
                         break;
                 case MPI2_RAID_VOL_TYPE_RAID1E:
                         qdepth = MPT2SAS_RAID_QUEUE_DEPTH;
-                        r_level = "RAID1E";
+                        if (ioc->manu_pg10.OEMIdentifier &&
+                            (ioc->manu_pg10.GenericFlags0 &
+                            MFG10_GF0_R10_DISPLAY) &&
+                            !(raid_device->num_pds % 2))
+                                r_level = "RAID10";
+                        else
+                                r_level = "RAID1E";
                         break;
                 case MPI2_RAID_VOL_TYPE_RAID1:
                         qdepth = MPT2SAS_RAID_QUEUE_DEPTH;
@@ -1786,17 +1791,18 @@ mpt2sas_scsih_issue_tm(struct MPT2SAS_ADAPTER *ioc, u16 handle, uint lun,
         u32 ioc_state;
         unsigned long timeleft;
         u8 VF_ID = 0;
-        unsigned long flags;
 
-        spin_lock_irqsave(&ioc->ioc_reset_in_progress_lock, flags);
-        if (ioc->tm_cmds.status != MPT2_CMD_NOT_USED ||
-            ioc->shost_recovery) {
-                spin_unlock_irqrestore(&ioc->ioc_reset_in_progress_lock, flags);
+        if (ioc->tm_cmds.status != MPT2_CMD_NOT_USED) {
+                printk(MPT2SAS_INFO_FMT "%s: tm_cmd busy!!!\n",
+                    __func__, ioc->name);
+                return;
+        }
+
+        if (ioc->shost_recovery) {
                 printk(MPT2SAS_INFO_FMT "%s: host reset in progress!\n",
                     __func__, ioc->name);
                 return;
         }
-        spin_unlock_irqrestore(&ioc->ioc_reset_in_progress_lock, flags);
 
         ioc_state = mpt2sas_base_get_iocstate(ioc, 0);
         if (ioc_state & MPI2_DOORBELL_USED) {
@@ -1830,6 +1836,7 @@ mpt2sas_scsih_issue_tm(struct MPT2SAS_ADAPTER *ioc, u16 handle, uint lun,
         mpi_request->TaskMID = cpu_to_le16(smid_task);
         int_to_scsilun(lun, (struct scsi_lun *)mpi_request->LUN);
         mpt2sas_scsih_set_tm_flag(ioc, handle);
+        init_completion(&ioc->tm_cmds.done);
         mpt2sas_base_put_smid_hi_priority(ioc, smid, VF_ID);
         timeleft = wait_for_completion_timeout(&ioc->tm_cmds.done, timeout*HZ);
         mpt2sas_scsih_clear_tm_flag(ioc, handle);
@@ -2222,7 +2229,7 @@ _scsih_ublock_io_device(struct MPT2SAS_ADAPTER *ioc, u16 handle)
                             MPT2SAS_INFO_FMT "SDEV_RUNNING: "
                             "handle(0x%04x)\n", ioc->name, handle));
                         sas_device_priv_data->block = 0;
-                        scsi_device_set_state(sdev, SDEV_RUNNING);
+                        scsi_internal_device_unblock(sdev);
                 }
         }
 }
@@ -2251,7 +2258,7 @@ _scsih_block_io_device(struct MPT2SAS_ADAPTER *ioc, u16 handle)
                             MPT2SAS_INFO_FMT "SDEV_BLOCK: "
                             "handle(0x%04x)\n", ioc->name, handle));
                         sas_device_priv_data->block = 1;
-                        scsi_device_set_state(sdev, SDEV_BLOCK);
+                        scsi_internal_device_block(sdev);
                 }
         }
 }
@@ -2327,6 +2334,7 @@ _scsih_block_io_to_children_attached_directly(struct MPT2SAS_ADAPTER *ioc,
         u16 handle;
         u16 reason_code;
         u8 phy_number;
+        u8 link_rate;
 
         for (i = 0; i < event_data->NumEntries; i++) {
                 handle = le16_to_cpu(event_data->PHY[i].AttachedDevHandle);
@@ -2337,6 +2345,11 @@ _scsih_block_io_to_children_attached_directly(struct MPT2SAS_ADAPTER *ioc,
                     MPI2_EVENT_SAS_TOPO_RC_MASK;
                 if (reason_code == MPI2_EVENT_SAS_TOPO_RC_DELAY_NOT_RESPONDING)
                         _scsih_block_io_device(ioc, handle);
+                if (reason_code == MPI2_EVENT_SAS_TOPO_RC_PHY_CHANGED) {
+                        link_rate = event_data->PHY[i].LinkRate >> 4;
+                        if (link_rate >= MPI2_SAS_NEG_LINK_RATE_1_5)
+                                _scsih_ublock_io_device(ioc, handle);
+                }
         }
 }
 
@@ -2405,27 +2418,6 @@ _scsih_check_topo_delete_events(struct MPT2SAS_ADAPTER *ioc,
 }
 
 /**
- * _scsih_queue_rescan - queue a topology rescan from user context
- * @ioc: per adapter object
- *
- * Return nothing.
- */
-static void
-_scsih_queue_rescan(struct MPT2SAS_ADAPTER *ioc)
-{
-        struct fw_event_work *fw_event;
-
-        if (ioc->wait_for_port_enable_to_complete)
-                return;
-        fw_event = kzalloc(sizeof(struct fw_event_work), GFP_ATOMIC);
-        if (!fw_event)
-                return;
-        fw_event->event = MPT2SAS_RESCAN_AFTER_HOST_RESET;
-        fw_event->ioc = ioc;
-        _scsih_fw_event_add(ioc, fw_event);
-}
-
-/**
  * _scsih_flush_running_cmds - completing outstanding commands.
  * @ioc: per adapter object
  *
@@ -2456,46 +2448,6 @@ _scsih_flush_running_cmds(struct MPT2SAS_ADAPTER *ioc)
 }
 
 /**
- * mpt2sas_scsih_reset_handler - reset callback handler (for scsih)
- * @ioc: per adapter object
- * @reset_phase: phase
- *
- * The handler for doing any required cleanup or initialization.
- *
- * The reset phase can be MPT2_IOC_PRE_RESET, MPT2_IOC_AFTER_RESET,
- * MPT2_IOC_DONE_RESET
- *
- * Return nothing.
- */
-void
-mpt2sas_scsih_reset_handler(struct MPT2SAS_ADAPTER *ioc, int reset_phase)
-{
-        switch (reset_phase) {
-        case MPT2_IOC_PRE_RESET:
-                dtmprintk(ioc, printk(MPT2SAS_DEBUG_FMT "%s: "
-                    "MPT2_IOC_PRE_RESET\n", ioc->name, __func__));
-                _scsih_fw_event_off(ioc);
-                break;
-        case MPT2_IOC_AFTER_RESET:
-                dtmprintk(ioc, printk(MPT2SAS_DEBUG_FMT "%s: "
-                    "MPT2_IOC_AFTER_RESET\n", ioc->name, __func__));
-                if (ioc->tm_cmds.status & MPT2_CMD_PENDING) {
-                        ioc->tm_cmds.status |= MPT2_CMD_RESET;
-                        mpt2sas_base_free_smid(ioc, ioc->tm_cmds.smid);
-                        complete(&ioc->tm_cmds.done);
-                }
-                _scsih_fw_event_on(ioc);
-                _scsih_flush_running_cmds(ioc);
-                break;
-        case MPT2_IOC_DONE_RESET:
-                dtmprintk(ioc, printk(MPT2SAS_DEBUG_FMT "%s: "
-                    "MPT2_IOC_DONE_RESET\n", ioc->name, __func__));
-                _scsih_queue_rescan(ioc);
-                break;
-        }
-}
-
-/**
  * _scsih_setup_eedp - setup MPI request for EEDP transfer
  * @scmd: pointer to scsi command object
  * @mpi_request: pointer to the SCSI_IO reqest message frame
@@ -2615,7 +2567,6 @@ _scsih_qcmd(struct scsi_cmnd *scmd, void (*done)(struct scsi_cmnd *))
         Mpi2SCSIIORequest_t *mpi_request;
         u32 mpi_control;
         u16 smid;
-        unsigned long flags;
 
         scmd->scsi_done = done;
         sas_device_priv_data = scmd->device->hostdata;
@@ -2634,13 +2585,10 @@ _scsih_qcmd(struct scsi_cmnd *scmd, void (*done)(struct scsi_cmnd *))
         }
 
         /* see if we are busy with task managment stuff */
-        spin_lock_irqsave(&ioc->ioc_reset_in_progress_lock, flags);
-        if (sas_target_priv_data->tm_busy ||
-            ioc->shost_recovery || ioc->ioc_link_reset_in_progress) {
-                spin_unlock_irqrestore(&ioc->ioc_reset_in_progress_lock, flags);
+        if (sas_target_priv_data->tm_busy)
+                return SCSI_MLQUEUE_DEVICE_BUSY;
+        else if (ioc->shost_recovery || ioc->ioc_link_reset_in_progress)
                 return SCSI_MLQUEUE_HOST_BUSY;
-        }
-        spin_unlock_irqrestore(&ioc->ioc_reset_in_progress_lock, flags);
 
         if (scmd->sc_data_direction == DMA_FROM_DEVICE)
                 mpi_control = MPI2_SCSIIO_CONTROL_READ;
@@ -3189,25 +3137,6 @@ _scsih_io_done(struct MPT2SAS_ADAPTER *ioc, u16 smid, u8 VF_ID, u32 reply)
 }
 
 /**
- * _scsih_link_change - process phy link changes
- * @ioc: per adapter object
- * @handle: phy handle
- * @attached_handle: valid for devices attached to link
- * @phy_number: phy number
- * @link_rate: new link rate
- * Context: user.
- *
- * Return nothing.
- */
-static void
-_scsih_link_change(struct MPT2SAS_ADAPTER *ioc, u16 handle, u16 attached_handle,
-   u8 phy_number, u8 link_rate)
-{
-        mpt2sas_transport_update_phy_link_change(ioc, handle, attached_handle,
-            phy_number, link_rate);
-}
-
-/**
  * _scsih_sas_host_refresh - refreshing sas host object contents
  * @ioc: per adapter object
  * @update: update link information
@@ -3251,7 +3180,8 @@ _scsih_sas_host_refresh(struct MPT2SAS_ADAPTER *ioc, u8 update)
                             le16_to_cpu(sas_iounit_pg0->PhyData[i].
                                 ControllerDevHandle);
                         if (update)
-                                _scsih_link_change(ioc,
+                                mpt2sas_transport_update_links(
+                                    ioc,
                                     ioc->sas_hba.phy[i].handle,
                                     le16_to_cpu(sas_iounit_pg0->PhyData[i].
                                     AttachedDevHandle), i,
@@ -3436,6 +3366,9 @@ _scsih_expander_add(struct MPT2SAS_ADAPTER *ioc, u16 handle)
         if (!handle)
                 return -1;
 
+        if (ioc->shost_recovery)
+                return -1;
+
         if ((mpt2sas_config_get_expander_pg0(ioc, &mpi_reply, &expander_pg0,
             MPI2_SAS_EXPAND_PGAD_FORM_HNDL, handle))) {
                 printk(MPT2SAS_ERR_FMT "failure at %s:%d/%s()!\n",
@@ -3572,6 +3505,9 @@ _scsih_expander_remove(struct MPT2SAS_ADAPTER *ioc, u16 handle)
         struct _sas_node *sas_expander;
         unsigned long flags;
 
+        if (ioc->shost_recovery)
+                return;
+
         spin_lock_irqsave(&ioc->sas_node_lock, flags);
         sas_expander = mpt2sas_scsih_expander_find_by_handle(ioc, handle);
         spin_unlock_irqrestore(&ioc->sas_node_lock, flags);
@@ -3743,6 +3679,8 @@ _scsih_remove_device(struct MPT2SAS_ADAPTER *ioc, u16 handle)
                 mutex_unlock(&ioc->tm_cmds.mutex);
                 dewtprintk(ioc, printk(MPT2SAS_INFO_FMT "issue target reset "
                     "done: handle(0x%04x)\n", ioc->name, device_handle));
+                if (ioc->shost_recovery)
+                        goto out;
         }
 
         /* SAS_IO_UNIT_CNTR - send REMOVE_DEVICE */
@@ -3765,6 +3703,9 @@ _scsih_remove_device(struct MPT2SAS_ADAPTER *ioc, u16 handle)
             le32_to_cpu(mpi_reply.IOCLogInfo)));
 
  out:
+
+        _scsih_ublock_io_device(ioc, handle);
+
         mpt2sas_transport_port_remove(ioc, sas_device->sas_address,
             sas_device->parent_handle);
 
@@ -3908,6 +3849,8 @@ _scsih_sas_topology_change_event(struct MPT2SAS_ADAPTER *ioc, u8 VF_ID,
                             "expander event\n", ioc->name));
                         return;
                 }
+                if (ioc->shost_recovery)
+                        return;
                 if (event_data->PHY[i].PhyStatus &
                     MPI2_EVENT_SAS_TOPO_PHYSTATUS_VACANT)
                         continue;
@@ -3923,9 +3866,10 @@ _scsih_sas_topology_change_event(struct MPT2SAS_ADAPTER *ioc, u8 VF_ID,
                 case MPI2_EVENT_SAS_TOPO_RC_TARG_ADDED:
                         if (!parent_handle) {
                                 if (phy_number < ioc->sas_hba.num_phys)
-                                        _scsih_link_change(ioc,
-                                           ioc->sas_hba.phy[phy_number].handle,
-                                           handle, phy_number, link_rate_);
+                                        mpt2sas_transport_update_links(
+                                        ioc,
+                                        ioc->sas_hba.phy[phy_number].handle,
+                                        handle, phy_number, link_rate_);
                         } else {
                                 spin_lock_irqsave(&ioc->sas_node_lock, flags);
                                 sas_expander =
@@ -3935,17 +3879,14 @@ _scsih_sas_topology_change_event(struct MPT2SAS_ADAPTER *ioc, u8 VF_ID,
                                     flags);
                                 if (sas_expander) {
                                         if (phy_number < sas_expander->num_phys)
-                                                _scsih_link_change(ioc,
-                                                   sas_expander->
-                                                   phy[phy_number].handle,
-                                                   handle, phy_number,
-                                                   link_rate_);
+                                                mpt2sas_transport_update_links(
+                                                ioc,
+                                                sas_expander->
+                                                phy[phy_number].handle,
+                                                handle, phy_number,
+                                                link_rate_);
                                 }
                         }
-                        if (reason_code == MPI2_EVENT_SAS_TOPO_RC_PHY_CHANGED) {
-                                if (link_rate_ >= MPI2_SAS_NEG_LINK_RATE_1_5)
-                                        _scsih_ublock_io_device(ioc, handle);
-                        }
                         if (reason_code == MPI2_EVENT_SAS_TOPO_RC_TARG_ADDED) {
                                 if (link_rate_ < MPI2_SAS_NEG_LINK_RATE_1_5)
                                         break;
@@ -4455,7 +4396,7 @@ _scsih_sas_pd_add(struct MPT2SAS_ADAPTER *ioc,
                 return;
         }
 
-        _scsih_link_change(ioc,
+        mpt2sas_transport_update_links(ioc,
             le16_to_cpu(sas_device_pg0.ParentDevHandle),
             handle, sas_device_pg0.PhyNum, MPI2_SAS_NEG_LINK_RATE_1_5);
 
@@ -4744,7 +4685,7 @@ _scsih_sas_ir_physical_disk_event(struct MPT2SAS_ADAPTER *ioc, u8 VF_ID,
                         return;
                 }
 
-                _scsih_link_change(ioc,
+                mpt2sas_transport_update_links(ioc,
                     le16_to_cpu(sas_device_pg0.ParentDevHandle),
                     handle, sas_device_pg0.PhyNum, MPI2_SAS_NEG_LINK_RATE_1_5);
 
@@ -5156,22 +5097,9 @@ static void
 _scsih_remove_unresponding_devices(struct MPT2SAS_ADAPTER *ioc)
 {
         struct _sas_device *sas_device, *sas_device_next;
-        struct _sas_node *sas_expander, *sas_expander_next;
+        struct _sas_node *sas_expander;
         struct _raid_device *raid_device, *raid_device_next;
-        unsigned long flags;
 
-        _scsih_search_responding_sas_devices(ioc);
-        _scsih_search_responding_raid_devices(ioc);
-        _scsih_search_responding_expanders(ioc);
-
-        spin_lock_irqsave(&ioc->ioc_reset_in_progress_lock, flags);
-        ioc->shost_recovery = 0;
-        if (ioc->shost->shost_state == SHOST_RECOVERY) {
-                printk(MPT2SAS_INFO_FMT "putting controller into "
-                    "SHOST_RUNNING\n", ioc->name);
-                scsi_host_set_state(ioc->shost, SHOST_RUNNING);
-        }
-        spin_unlock_irqrestore(&ioc->ioc_reset_in_progress_lock, flags);
 
         list_for_each_entry_safe(sas_device, sas_device_next,
             &ioc->sas_device_list, list) {
@@ -5207,16 +5135,63 @@ _scsih_remove_unresponding_devices(struct MPT2SAS_ADAPTER *ioc)
                 _scsih_raid_device_remove(ioc, raid_device);
         }
 
-        list_for_each_entry_safe(sas_expander, sas_expander_next,
-            &ioc->sas_expander_list, list) {
+ retry_expander_search:
+        sas_expander = NULL;
+        list_for_each_entry(sas_expander, &ioc->sas_expander_list, list) {
                 if (sas_expander->responding) {
                         sas_expander->responding = 0;
                         continue;
                 }
-                printk("\tremoving expander: handle(0x%04x), "
-                    " sas_addr(0x%016llx)\n", sas_expander->handle,
-                    (unsigned long long)sas_expander->sas_address);
                 _scsih_expander_remove(ioc, sas_expander->handle);
+                goto retry_expander_search;
+        }
+}
+
+/**
+ * mpt2sas_scsih_reset_handler - reset callback handler (for scsih)
+ * @ioc: per adapter object
+ * @reset_phase: phase
+ *
+ * The handler for doing any required cleanup or initialization.
+ *
+ * The reset phase can be MPT2_IOC_PRE_RESET, MPT2_IOC_AFTER_RESET,
+ * MPT2_IOC_DONE_RESET
+ *
+ * Return nothing.
+ */
+void
+mpt2sas_scsih_reset_handler(struct MPT2SAS_ADAPTER *ioc, int reset_phase)
+{
+        switch (reset_phase) {
+        case MPT2_IOC_PRE_RESET:
+                dtmprintk(ioc, printk(MPT2SAS_DEBUG_FMT "%s: "
+                    "MPT2_IOC_PRE_RESET\n", ioc->name, __func__));
+                _scsih_fw_event_off(ioc);
+                break;
+        case MPT2_IOC_AFTER_RESET:
+                dtmprintk(ioc, printk(MPT2SAS_DEBUG_FMT "%s: "
+                    "MPT2_IOC_AFTER_RESET\n", ioc->name, __func__));
+                if (ioc->tm_cmds.status & MPT2_CMD_PENDING) {
+                        ioc->tm_cmds.status |= MPT2_CMD_RESET;
+                        mpt2sas_base_free_smid(ioc, ioc->tm_cmds.smid);
+                        complete(&ioc->tm_cmds.done);
+                }
+                _scsih_fw_event_on(ioc);
+                _scsih_flush_running_cmds(ioc);
+                break;
+        case MPT2_IOC_DONE_RESET:
+                dtmprintk(ioc, printk(MPT2SAS_DEBUG_FMT "%s: "
+                    "MPT2_IOC_DONE_RESET\n", ioc->name, __func__));
+                _scsih_sas_host_refresh(ioc, 0);
+                _scsih_search_responding_sas_devices(ioc);
+                _scsih_search_responding_raid_devices(ioc);
+                _scsih_search_responding_expanders(ioc);
+                break;
+        case MPT2_IOC_RUNNING:
+                dtmprintk(ioc, printk(MPT2SAS_DEBUG_FMT "%s: "
+                    "MPT2_IOC_RUNNING\n", ioc->name, __func__));
+                _scsih_remove_unresponding_devices(ioc);
+                break;
         }
 }
 
@@ -5236,14 +5211,6 @@ _firmware_event_work(struct work_struct *work)
         unsigned long flags;
         struct MPT2SAS_ADAPTER *ioc = fw_event->ioc;
 
-        /* This is invoked by calling _scsih_queue_rescan(). */
-        if (fw_event->event == MPT2SAS_RESCAN_AFTER_HOST_RESET) {
-                _scsih_fw_event_free(ioc, fw_event);
-                _scsih_sas_host_refresh(ioc, 1);
-                _scsih_remove_unresponding_devices(ioc);
-                return;
-        }
-
         /* the queue is being flushed so ignore this event */
         spin_lock_irqsave(&ioc->fw_event_lock, flags);
         if (ioc->fw_events_off || ioc->remove_host) {
@@ -5253,13 +5220,10 @@ _firmware_event_work(struct work_struct *work)
         }
         spin_unlock_irqrestore(&ioc->fw_event_lock, flags);
 
-        spin_lock_irqsave(&ioc->ioc_reset_in_progress_lock, flags);
         if (ioc->shost_recovery) {
-                spin_unlock_irqrestore(&ioc->ioc_reset_in_progress_lock, flags);
                 _scsih_fw_event_requeue(ioc, fw_event, 1000);
                 return;
         }
-        spin_unlock_irqrestore(&ioc->ioc_reset_in_progress_lock, flags);
 
         switch (fw_event->event) {
         case MPI2_EVENT_SAS_TOPOLOGY_CHANGE_LIST:
@@ -5461,6 +5425,8 @@ _scsih_expander_node_remove(struct MPT2SAS_ADAPTER *ioc,
                         if (!sas_device)
                                 continue;
                         _scsih_remove_device(ioc, sas_device->handle);
+                        if (ioc->shost_recovery)
+                                return;
                         goto retry_device_search;
                 }
         }
@@ -5482,6 +5448,8 @@ _scsih_expander_node_remove(struct MPT2SAS_ADAPTER *ioc,
                         if (!expander_sibling)
                                 continue;
                         _scsih_expander_remove(ioc, expander_sibling->handle);
+                        if (ioc->shost_recovery)
+                                return;
                         goto retry_expander_search;
                 }
         }