diff options
Diffstat (limited to 'drivers/scsi/megaraid')
-rw-r--r-- | drivers/scsi/megaraid/megaraid_mbox.c | 37 | ||||
-rw-r--r-- | drivers/scsi/megaraid/megaraid_sas_base.c | 13 |
2 files changed, 21 insertions, 29 deletions
diff --git a/drivers/scsi/megaraid/megaraid_mbox.c b/drivers/scsi/megaraid/megaraid_mbox.c index 1dba32870b4c..2e6619eff3ea 100644 --- a/drivers/scsi/megaraid/megaraid_mbox.c +++ b/drivers/scsi/megaraid/megaraid_mbox.c | |||
@@ -2315,8 +2315,8 @@ megaraid_mbox_dpc(unsigned long devp) | |||
2315 | // Was an abort issued for this command earlier | 2315 | // Was an abort issued for this command earlier |
2316 | if (scb->state & SCB_ABORT) { | 2316 | if (scb->state & SCB_ABORT) { |
2317 | con_log(CL_ANN, (KERN_NOTICE | 2317 | con_log(CL_ANN, (KERN_NOTICE |
2318 | "megaraid: aborted cmd %lx[%x] completed\n", | 2318 | "megaraid: aborted cmd [%x] completed\n", |
2319 | scp->serial_number, scb->sno)); | 2319 | scb->sno)); |
2320 | } | 2320 | } |
2321 | 2321 | ||
2322 | /* | 2322 | /* |
@@ -2472,8 +2472,8 @@ megaraid_abort_handler(struct scsi_cmnd *scp) | |||
2472 | raid_dev = ADAP2RAIDDEV(adapter); | 2472 | raid_dev = ADAP2RAIDDEV(adapter); |
2473 | 2473 | ||
2474 | con_log(CL_ANN, (KERN_WARNING | 2474 | con_log(CL_ANN, (KERN_WARNING |
2475 | "megaraid: aborting-%ld cmd=%x <c=%d t=%d l=%d>\n", | 2475 | "megaraid: aborting cmd=%x <c=%d t=%d l=%d>\n", |
2476 | scp->serial_number, scp->cmnd[0], SCP2CHANNEL(scp), | 2476 | scp->cmnd[0], SCP2CHANNEL(scp), |
2477 | SCP2TARGET(scp), SCP2LUN(scp))); | 2477 | SCP2TARGET(scp), SCP2LUN(scp))); |
2478 | 2478 | ||
2479 | // If FW has stopped responding, simply return failure | 2479 | // If FW has stopped responding, simply return failure |
@@ -2496,9 +2496,8 @@ megaraid_abort_handler(struct scsi_cmnd *scp) | |||
2496 | list_del_init(&scb->list); // from completed list | 2496 | list_del_init(&scb->list); // from completed list |
2497 | 2497 | ||
2498 | con_log(CL_ANN, (KERN_WARNING | 2498 | con_log(CL_ANN, (KERN_WARNING |
2499 | "megaraid: %ld:%d[%d:%d], abort from completed list\n", | 2499 | "megaraid: %d[%d:%d], abort from completed list\n", |
2500 | scp->serial_number, scb->sno, | 2500 | scb->sno, scb->dev_channel, scb->dev_target)); |
2501 | scb->dev_channel, scb->dev_target)); | ||
2502 | 2501 | ||
2503 | scp->result = (DID_ABORT << 16); | 2502 | scp->result = (DID_ABORT << 16); |
2504 | scp->scsi_done(scp); | 2503 | scp->scsi_done(scp); |
@@ -2527,9 +2526,8 @@ megaraid_abort_handler(struct scsi_cmnd *scp) | |||
2527 | ASSERT(!(scb->state & SCB_ISSUED)); | 2526 | ASSERT(!(scb->state & SCB_ISSUED)); |
2528 | 2527 | ||
2529 | con_log(CL_ANN, (KERN_WARNING | 2528 | con_log(CL_ANN, (KERN_WARNING |
2530 | "megaraid abort: %ld[%d:%d], driver owner\n", | 2529 | "megaraid abort: [%d:%d], driver owner\n", |
2531 | scp->serial_number, scb->dev_channel, | 2530 | scb->dev_channel, scb->dev_target)); |
2532 | scb->dev_target)); | ||
2533 | 2531 | ||
2534 | scp->result = (DID_ABORT << 16); | 2532 | scp->result = (DID_ABORT << 16); |
2535 | scp->scsi_done(scp); | 2533 | scp->scsi_done(scp); |
@@ -2560,25 +2558,21 @@ megaraid_abort_handler(struct scsi_cmnd *scp) | |||
2560 | 2558 | ||
2561 | if (!(scb->state & SCB_ISSUED)) { | 2559 | if (!(scb->state & SCB_ISSUED)) { |
2562 | con_log(CL_ANN, (KERN_WARNING | 2560 | con_log(CL_ANN, (KERN_WARNING |
2563 | "megaraid abort: %ld%d[%d:%d], invalid state\n", | 2561 | "megaraid abort: %d[%d:%d], invalid state\n", |
2564 | scp->serial_number, scb->sno, scb->dev_channel, | 2562 | scb->sno, scb->dev_channel, scb->dev_target)); |
2565 | scb->dev_target)); | ||
2566 | BUG(); | 2563 | BUG(); |
2567 | } | 2564 | } |
2568 | else { | 2565 | else { |
2569 | con_log(CL_ANN, (KERN_WARNING | 2566 | con_log(CL_ANN, (KERN_WARNING |
2570 | "megaraid abort: %ld:%d[%d:%d], fw owner\n", | 2567 | "megaraid abort: %d[%d:%d], fw owner\n", |
2571 | scp->serial_number, scb->sno, scb->dev_channel, | 2568 | scb->sno, scb->dev_channel, scb->dev_target)); |
2572 | scb->dev_target)); | ||
2573 | } | 2569 | } |
2574 | } | 2570 | } |
2575 | } | 2571 | } |
2576 | spin_unlock_irq(&adapter->lock); | 2572 | spin_unlock_irq(&adapter->lock); |
2577 | 2573 | ||
2578 | if (!found) { | 2574 | if (!found) { |
2579 | con_log(CL_ANN, (KERN_WARNING | 2575 | con_log(CL_ANN, (KERN_WARNING "megaraid abort: do now own\n")); |
2580 | "megaraid abort: scsi cmd:%ld, do now own\n", | ||
2581 | scp->serial_number)); | ||
2582 | 2576 | ||
2583 | // FIXME: Should there be a callback for this command? | 2577 | // FIXME: Should there be a callback for this command? |
2584 | return SUCCESS; | 2578 | return SUCCESS; |
@@ -2649,9 +2643,8 @@ megaraid_reset_handler(struct scsi_cmnd *scp) | |||
2649 | } else { | 2643 | } else { |
2650 | if (scb->scp == scp) { // Found command | 2644 | if (scb->scp == scp) { // Found command |
2651 | con_log(CL_ANN, (KERN_WARNING | 2645 | con_log(CL_ANN, (KERN_WARNING |
2652 | "megaraid: %ld:%d[%d:%d], reset from pending list\n", | 2646 | "megaraid: %d[%d:%d], reset from pending list\n", |
2653 | scp->serial_number, scb->sno, | 2647 | scb->sno, scb->dev_channel, scb->dev_target)); |
2654 | scb->dev_channel, scb->dev_target)); | ||
2655 | } else { | 2648 | } else { |
2656 | con_log(CL_ANN, (KERN_WARNING | 2649 | con_log(CL_ANN, (KERN_WARNING |
2657 | "megaraid: IO packet with %d[%d:%d] being reset\n", | 2650 | "megaraid: IO packet with %d[%d:%d] being reset\n", |
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c index 66d4cea4df98..89c623ebadbc 100644 --- a/drivers/scsi/megaraid/megaraid_sas_base.c +++ b/drivers/scsi/megaraid/megaraid_sas_base.c | |||
@@ -1751,10 +1751,9 @@ static int megasas_wait_for_outstanding(struct megasas_instance *instance) | |||
1751 | list_del_init(&reset_cmd->list); | 1751 | list_del_init(&reset_cmd->list); |
1752 | if (reset_cmd->scmd) { | 1752 | if (reset_cmd->scmd) { |
1753 | reset_cmd->scmd->result = DID_RESET << 16; | 1753 | reset_cmd->scmd->result = DID_RESET << 16; |
1754 | printk(KERN_NOTICE "%d:%p reset [%02x], %#lx\n", | 1754 | printk(KERN_NOTICE "%d:%p reset [%02x]\n", |
1755 | reset_index, reset_cmd, | 1755 | reset_index, reset_cmd, |
1756 | reset_cmd->scmd->cmnd[0], | 1756 | reset_cmd->scmd->cmnd[0]); |
1757 | reset_cmd->scmd->serial_number); | ||
1758 | 1757 | ||
1759 | reset_cmd->scmd->scsi_done(reset_cmd->scmd); | 1758 | reset_cmd->scmd->scsi_done(reset_cmd->scmd); |
1760 | megasas_return_cmd(instance, reset_cmd); | 1759 | megasas_return_cmd(instance, reset_cmd); |
@@ -1879,8 +1878,8 @@ static int megasas_generic_reset(struct scsi_cmnd *scmd) | |||
1879 | 1878 | ||
1880 | instance = (struct megasas_instance *)scmd->device->host->hostdata; | 1879 | instance = (struct megasas_instance *)scmd->device->host->hostdata; |
1881 | 1880 | ||
1882 | scmd_printk(KERN_NOTICE, scmd, "megasas: RESET -%ld cmd=%x retries=%x\n", | 1881 | scmd_printk(KERN_NOTICE, scmd, "megasas: RESET cmd=%x retries=%x\n", |
1883 | scmd->serial_number, scmd->cmnd[0], scmd->retries); | 1882 | scmd->cmnd[0], scmd->retries); |
1884 | 1883 | ||
1885 | if (instance->adprecovery == MEGASAS_HW_CRITICAL_ERROR) { | 1884 | if (instance->adprecovery == MEGASAS_HW_CRITICAL_ERROR) { |
1886 | printk(KERN_ERR "megasas: cannot recover from previous reset " | 1885 | printk(KERN_ERR "megasas: cannot recover from previous reset " |
@@ -2349,9 +2348,9 @@ megasas_issue_pending_cmds_again(struct megasas_instance *instance) | |||
2349 | cmd->frame_phys_addr , | 2348 | cmd->frame_phys_addr , |
2350 | 0, instance->reg_set); | 2349 | 0, instance->reg_set); |
2351 | } else if (cmd->scmd) { | 2350 | } else if (cmd->scmd) { |
2352 | printk(KERN_NOTICE "megasas: %p scsi cmd [%02x],%#lx" | 2351 | printk(KERN_NOTICE "megasas: %p scsi cmd [%02x]" |
2353 | "detected on the internal queue, issue again.\n", | 2352 | "detected on the internal queue, issue again.\n", |
2354 | cmd, cmd->scmd->cmnd[0], cmd->scmd->serial_number); | 2353 | cmd, cmd->scmd->cmnd[0]); |
2355 | 2354 | ||
2356 | atomic_inc(&instance->fw_outstanding); | 2355 | atomic_inc(&instance->fw_outstanding); |
2357 | instance->instancet->fire_cmd(instance, | 2356 | instance->instancet->fire_cmd(instance, |