diff options
Diffstat (limited to 'drivers/scsi/libsrp.c')
-rw-r--r-- | drivers/scsi/libsrp.c | 17 |
1 files changed, 9 insertions, 8 deletions
diff --git a/drivers/scsi/libsrp.c b/drivers/scsi/libsrp.c index 9ad38e81e343..ab19b3b4be52 100644 --- a/drivers/scsi/libsrp.c +++ b/drivers/scsi/libsrp.c | |||
@@ -58,19 +58,15 @@ static int srp_iu_pool_alloc(struct srp_queue *q, size_t max, | |||
58 | goto free_pool; | 58 | goto free_pool; |
59 | 59 | ||
60 | spin_lock_init(&q->lock); | 60 | spin_lock_init(&q->lock); |
61 | q->queue = kfifo_init((void *) q->pool, max * sizeof(void *), | 61 | kfifo_init(&q->queue, (void *) q->pool, max * sizeof(void *)); |
62 | GFP_KERNEL, &q->lock); | ||
63 | if (IS_ERR(q->queue)) | ||
64 | goto free_item; | ||
65 | 62 | ||
66 | for (i = 0, iue = q->items; i < max; i++) { | 63 | for (i = 0, iue = q->items; i < max; i++) { |
67 | __kfifo_put(q->queue, (void *) &iue, sizeof(void *)); | 64 | kfifo_in(&q->queue, (void *) &iue, sizeof(void *)); |
68 | iue->sbuf = ring[i]; | 65 | iue->sbuf = ring[i]; |
69 | iue++; | 66 | iue++; |
70 | } | 67 | } |
71 | return 0; | 68 | return 0; |
72 | 69 | ||
73 | free_item: | ||
74 | kfree(q->items); | 70 | kfree(q->items); |
75 | free_pool: | 71 | free_pool: |
76 | kfree(q->pool); | 72 | kfree(q->pool); |
@@ -167,7 +163,11 @@ struct iu_entry *srp_iu_get(struct srp_target *target) | |||
167 | { | 163 | { |
168 | struct iu_entry *iue = NULL; | 164 | struct iu_entry *iue = NULL; |
169 | 165 | ||
170 | kfifo_get(target->iu_queue.queue, (void *) &iue, sizeof(void *)); | 166 | if (kfifo_out_locked(&target->iu_queue.queue, (void *) &iue, |
167 | sizeof(void *), &target->iu_queue.lock) != sizeof(void *)) { | ||
168 | WARN_ONCE(1, "unexpected fifo state"); | ||
169 | return NULL; | ||
170 | } | ||
171 | if (!iue) | 171 | if (!iue) |
172 | return iue; | 172 | return iue; |
173 | iue->target = target; | 173 | iue->target = target; |
@@ -179,7 +179,8 @@ EXPORT_SYMBOL_GPL(srp_iu_get); | |||
179 | 179 | ||
180 | void srp_iu_put(struct iu_entry *iue) | 180 | void srp_iu_put(struct iu_entry *iue) |
181 | { | 181 | { |
182 | kfifo_put(iue->target->iu_queue.queue, (void *) &iue, sizeof(void *)); | 182 | kfifo_in_locked(&iue->target->iu_queue.queue, (void *) &iue, |
183 | sizeof(void *), &iue->target->iu_queue.lock); | ||
183 | } | 184 | } |
184 | EXPORT_SYMBOL_GPL(srp_iu_put); | 185 | EXPORT_SYMBOL_GPL(srp_iu_put); |
185 | 186 | ||