1 files changed, 183 insertions, 75 deletions

diff --git a/drivers/scsi/libsas/sas_scsi_host.c b/drivers/scsi/libsas/sas_scsi_host.c
index 22672d54aa27..cd2378010c7e 100644
--- a/drivers/scsi/libsas/sas_scsi_host.c
+++ b/drivers/scsi/libsas/sas_scsi_host.c
@@ -34,6 +34,7 @@
 #include <scsi/scsi_transport_sas.h>
 #include "../scsi_sas_internal.h"
 #include "../scsi_transport_api.h"
+#include "../scsi_priv.h"
 
 #include <linux/err.h>
 #include <linux/blkdev.h>
@@ -130,7 +131,7 @@ static enum task_attribute sas_scsi_get_task_attr(struct scsi_cmnd *cmd)
         if (cmd->request && blk_rq_tagged(cmd->request)) {
                 if (cmd->device->ordered_tags &&
                     (cmd->request->cmd_flags & REQ_HARDBARRIER))
-                        ta = TASK_ATTR_HOQ;
+                        ta = TASK_ATTR_ORDERED;
         }
         return ta;
 }
@@ -281,6 +282,7 @@ enum task_disposition {
         TASK_IS_ABORTED,
         TASK_IS_AT_LU,
         TASK_IS_NOT_AT_LU,
+        TASK_ABORT_FAILED,
 };
 
 static enum task_disposition sas_scsi_find_task(struct sas_task *task)
@@ -310,15 +312,6 @@ static enum task_disposition sas_scsi_find_task(struct sas_task *task)
                 spin_unlock_irqrestore(&core->task_queue_lock, flags);
         }
 
-        spin_lock_irqsave(&task->task_state_lock, flags);
-        if (task->task_state_flags & SAS_TASK_INITIATOR_ABORTED) {
-                spin_unlock_irqrestore(&task->task_state_lock, flags);
-                SAS_DPRINTK("%s: task 0x%p already aborted\n",
-                            __FUNCTION__, task);
-                return TASK_IS_ABORTED;
-        }
-        spin_unlock_irqrestore(&task->task_state_lock, flags);
-
         for (i = 0; i < 5; i++) {
                 SAS_DPRINTK("%s: aborting task 0x%p\n", __FUNCTION__, task);
                 res = si->dft->lldd_abort_task(task);
@@ -340,15 +333,21 @@ static enum task_disposition sas_scsi_find_task(struct sas_task *task)
                         SAS_DPRINTK("%s: querying task 0x%p\n",
                                     __FUNCTION__, task);
                         res = si->dft->lldd_query_task(task);
-                        if (res == TMF_RESP_FUNC_SUCC) {
+                        switch (res) {
+                        case TMF_RESP_FUNC_SUCC:
                                 SAS_DPRINTK("%s: task 0x%p at LU\n",
                                             __FUNCTION__, task);
                                 return TASK_IS_AT_LU;
-                        } else if (res == TMF_RESP_FUNC_COMPLETE) {
+                        case TMF_RESP_FUNC_COMPLETE:
                                 SAS_DPRINTK("%s: task 0x%p not at LU\n",
                                             __FUNCTION__, task);
                                 return TASK_IS_NOT_AT_LU;
-                        }
+                        case TMF_RESP_FUNC_FAILED:
+                                SAS_DPRINTK("%s: task 0x%p failed to abort\n",
+                                                __FUNCTION__, task);
+                                return TASK_ABORT_FAILED;
+                        }
+
                 }
         }
         return res;
@@ -398,35 +397,82 @@ static int sas_recover_I_T(struct domain_device *dev)
         return res;
 }
 
-void sas_scsi_recover_host(struct Scsi_Host *shost)
+/* Find the sas_phy that's attached to this device */
+struct sas_phy *find_local_sas_phy(struct domain_device *dev)
+{
+        struct domain_device *pdev = dev->parent;
+        struct ex_phy *exphy = NULL;
+        int i;
+
+        /* Directly attached device */
+        if (!pdev)
+                return dev->port->phy;
+
+        /* Otherwise look in the expander */
+        for (i = 0; i < pdev->ex_dev.num_phys; i++)
+                if (!memcmp(dev->sas_addr,
+                            pdev->ex_dev.ex_phy[i].attached_sas_addr,
+                            SAS_ADDR_SIZE)) {
+                        exphy = &pdev->ex_dev.ex_phy[i];
+                        break;
+                }
+
+        BUG_ON(!exphy);
+        return exphy->phy;
+}
+
+/* Attempt to send a target reset message to a device */
+int sas_eh_device_reset_handler(struct scsi_cmnd *cmd)
+{
+        struct domain_device *dev = cmd_to_domain_dev(cmd);
+        struct sas_phy *phy = find_local_sas_phy(dev);
+        int res;
+
+        res = sas_phy_reset(phy, 1);
+        if (res)
+                SAS_DPRINTK("Device reset of %s failed 0x%x\n",
+                            phy->dev.kobj.k_name,
+                            res);
+        if (res == TMF_RESP_FUNC_SUCC || res == TMF_RESP_FUNC_COMPLETE)
+                return SUCCESS;
+
+        return FAILED;
+}
+
+/* Try to reset a device */
+static int try_to_reset_cmd_device(struct Scsi_Host *shost,
+                                   struct scsi_cmnd *cmd)
+{
+        if (!shost->hostt->eh_device_reset_handler)
+                return FAILED;
+
+        return shost->hostt->eh_device_reset_handler(cmd);
+}
+
+static int sas_eh_handle_sas_errors(struct Scsi_Host *shost,
+                                    struct list_head *work_q,
+                                    struct list_head *done_q)
 {
-        struct sas_ha_struct *ha = SHOST_TO_SAS_HA(shost);
-        unsigned long flags;
-        LIST_HEAD(error_q);
         struct scsi_cmnd *cmd, *n;
         enum task_disposition res = TASK_IS_DONE;
-        int tmf_resp;
+        int tmf_resp, need_reset;
         struct sas_internal *i = to_sas_internal(shost->transportt);
+        unsigned long flags;
+        struct sas_ha_struct *ha = SHOST_TO_SAS_HA(shost);
 
-        spin_lock_irqsave(shost->host_lock, flags);
-        list_splice_init(&shost->eh_cmd_q, &error_q);
-        spin_unlock_irqrestore(shost->host_lock, flags);
-
-        SAS_DPRINTK("Enter %s\n", __FUNCTION__);
-
-        /* All tasks on this list were marked SAS_TASK_STATE_ABORTED
-         * by sas_scsi_timed_out() callback.
-         */
 Again:
-        SAS_DPRINTK("going over list...\n");
-        list_for_each_entry_safe(cmd, n, &error_q, eh_entry) {
+        list_for_each_entry_safe(cmd, n, work_q, eh_entry) {
                 struct sas_task *task = TO_SAS_TASK(cmd);
-                list_del_init(&cmd->eh_entry);
 
-                if (!task) {
-                        SAS_DPRINTK("%s: taskless cmd?!\n", __FUNCTION__);
+                if (!task)
                         continue;
-                }
+
+                list_del_init(&cmd->eh_entry);
+
+                spin_lock_irqsave(&task->task_state_lock, flags);
+                need_reset = task->task_state_flags & SAS_TASK_NEED_DEV_RESET;
+                spin_unlock_irqrestore(&task->task_state_lock, flags);
+
                 SAS_DPRINTK("trying to find task 0x%p\n", task);
                 res = sas_scsi_find_task(task);
 
@@ -437,11 +483,15 @@ Again:
                         SAS_DPRINTK("%s: task 0x%p is done\n", __FUNCTION__,
                                     task);
                         task->task_done(task);
+                        if (need_reset)
+                                try_to_reset_cmd_device(shost, cmd);
                         continue;
                 case TASK_IS_ABORTED:
                         SAS_DPRINTK("%s: task 0x%p is aborted\n",
                                     __FUNCTION__, task);
                         task->task_done(task);
+                        if (need_reset)
+                                try_to_reset_cmd_device(shost, cmd);
                         continue;
                 case TASK_IS_AT_LU:
                         SAS_DPRINTK("task 0x%p is at LU: lu recover\n", task);
@@ -452,11 +502,14 @@ Again:
                                             SAS_ADDR(task->dev),
                                             cmd->device->lun);
                                 task->task_done(task);
-                                sas_scsi_clear_queue_lu(&error_q, cmd);
+                                if (need_reset)
+                                        try_to_reset_cmd_device(shost, cmd);
+                                sas_scsi_clear_queue_lu(work_q, cmd);
                                 goto Again;
                         }
                         /* fallthrough */
                 case TASK_IS_NOT_AT_LU:
+                case TASK_ABORT_FAILED:
                         SAS_DPRINTK("task 0x%p is not at LU: I_T recover\n",
                                     task);
                         tmf_resp = sas_recover_I_T(task->dev);
@@ -464,7 +517,9 @@ Again:
                                 SAS_DPRINTK("I_T %016llx recovered\n",
                                             SAS_ADDR(task->dev->sas_addr));
                                 task->task_done(task);
-                                sas_scsi_clear_queue_I_T(&error_q, task->dev);
+                                if (need_reset)
+                                        try_to_reset_cmd_device(shost, cmd);
+                                sas_scsi_clear_queue_I_T(work_q, task->dev);
                                 goto Again;
                         }
                         /* Hammer time :-) */
@@ -477,7 +532,9 @@ Again:
                                         SAS_DPRINTK("clear nexus port:%d "
                                                     "succeeded\n", port->id);
                                         task->task_done(task);
-                                        sas_scsi_clear_queue_port(&error_q,
+                                        if (need_reset)
+                                                try_to_reset_cmd_device(shost, cmd);
+                                        sas_scsi_clear_queue_port(work_q,
                                                                   port);
                                         goto Again;
                                 }
@@ -489,6 +546,8 @@ Again:
                                         SAS_DPRINTK("clear nexus ha "
                                                     "succeeded\n");
                                         task->task_done(task);
+                                        if (need_reset)
+                                                try_to_reset_cmd_device(shost, cmd);
                                         goto out;
                                 }
                         }
@@ -502,20 +561,54 @@ Again:
                                     cmd->device->lun);
 
                         task->task_done(task);
+                        if (need_reset)
+                                try_to_reset_cmd_device(shost, cmd);
                         goto clear_q;
                 }
         }
 out:
-        scsi_eh_flush_done_q(&ha->eh_done_q);
-        SAS_DPRINTK("--- Exit %s\n", __FUNCTION__);
-        return;
+        return list_empty(work_q);
 clear_q:
         SAS_DPRINTK("--- Exit %s -- clear_q\n", __FUNCTION__);
-        list_for_each_entry_safe(cmd, n, &error_q, eh_entry) {
+        list_for_each_entry_safe(cmd, n, work_q, eh_entry) {
                 struct sas_task *task = TO_SAS_TASK(cmd);
                 list_del_init(&cmd->eh_entry);
                 task->task_done(task);
         }
+        return list_empty(work_q);
+}
+
+void sas_scsi_recover_host(struct Scsi_Host *shost)
+{
+        struct sas_ha_struct *ha = SHOST_TO_SAS_HA(shost);
+        unsigned long flags;
+        LIST_HEAD(eh_work_q);
+
+        spin_lock_irqsave(shost->host_lock, flags);
+        list_splice_init(&shost->eh_cmd_q, &eh_work_q);
+        spin_unlock_irqrestore(shost->host_lock, flags);
+
+        SAS_DPRINTK("Enter %s\n", __FUNCTION__);
+        /*
+         * Deal with commands that still have SAS tasks (i.e. they didn't
+         * complete via the normal sas_task completion mechanism)
+         */
+        if (sas_eh_handle_sas_errors(shost, &eh_work_q, &ha->eh_done_q))
+                goto out;
+
+        /*
+         * Now deal with SCSI commands that completed ok but have a an error
+         * code (and hopefully sense data) attached.  This is roughly what
+         * scsi_unjam_host does, but we skip scsi_eh_abort_cmds because any
+         * command we see here has no sas_task and is thus unknown to the HA.
+         */
+        if (!scsi_eh_get_sense(&eh_work_q, &ha->eh_done_q))
+                scsi_eh_ready_devs(shost, &eh_work_q, &ha->eh_done_q);
+
+out:
+        scsi_eh_flush_done_q(&ha->eh_done_q);
+        SAS_DPRINTK("--- Exit %s\n", __FUNCTION__);
+        return;
 }
 
 enum scsi_eh_timer_return sas_scsi_timed_out(struct scsi_cmnd *cmd)
@@ -524,24 +617,30 @@ enum scsi_eh_timer_return sas_scsi_timed_out(struct scsi_cmnd *cmd)
         unsigned long flags;
 
         if (!task) {
-                SAS_DPRINTK("command 0x%p, task 0x%p, gone: EH_HANDLED\n",
-                            cmd, task);
-                return EH_HANDLED;
+                cmd->timeout_per_command /= 2;
+                SAS_DPRINTK("command 0x%p, task 0x%p, gone: %s\n",
+                            cmd, task, (cmd->timeout_per_command ?
+                            "EH_RESET_TIMER" : "EH_NOT_HANDLED"));
+                if (!cmd->timeout_per_command)
+                        return EH_NOT_HANDLED;
+                return EH_RESET_TIMER;
         }
 
         spin_lock_irqsave(&task->task_state_lock, flags);
-        if (task->task_state_flags & SAS_TASK_INITIATOR_ABORTED) {
-                spin_unlock_irqrestore(&task->task_state_lock, flags);
-                SAS_DPRINTK("command 0x%p, task 0x%p, aborted by initiator: "
-                            "EH_NOT_HANDLED\n", cmd, task);
-                return EH_NOT_HANDLED;
-        }
+        BUG_ON(task->task_state_flags & SAS_TASK_STATE_ABORTED);
         if (task->task_state_flags & SAS_TASK_STATE_DONE) {
                 spin_unlock_irqrestore(&task->task_state_lock, flags);
                 SAS_DPRINTK("command 0x%p, task 0x%p, timed out: EH_HANDLED\n",
                             cmd, task);
                 return EH_HANDLED;
         }
+        if (!(task->task_state_flags & SAS_TASK_AT_INITIATOR)) {
+                spin_unlock_irqrestore(&task->task_state_lock, flags);
+                SAS_DPRINTK("command 0x%p, task 0x%p, not at initiator: "
+                            "EH_RESET_TIMER\n",
+                            cmd, task);
+                return EH_RESET_TIMER;
+        }
         task->task_state_flags |= SAS_TASK_STATE_ABORTED;
         spin_unlock_irqrestore(&task->task_state_lock, flags);
 
@@ -557,8 +656,9 @@ struct domain_device *sas_find_dev_by_rphy(struct sas_rphy *rphy)
         struct sas_ha_struct *ha = SHOST_TO_SAS_HA(shost);
         struct domain_device *found_dev = NULL;
         int i;
+        unsigned long flags;
 
-        spin_lock(&ha->phy_port_lock);
+        spin_lock_irqsave(&ha->phy_port_lock, flags);
         for (i = 0; i < ha->num_phys; i++) {
                 struct asd_sas_port *port = ha->sas_port[i];
                 struct domain_device *dev;
@@ -574,7 +674,7 @@ struct domain_device *sas_find_dev_by_rphy(struct sas_rphy *rphy)
                 spin_unlock(&port->dev_list_lock);
         }
  found:
-        spin_unlock(&ha->phy_port_lock);
+        spin_unlock_irqrestore(&ha->phy_port_lock, flags);
 
         return found_dev;
 }
@@ -623,6 +723,8 @@ int sas_slave_configure(struct scsi_device *scsi_dev)
                 scsi_deactivate_tcq(scsi_dev, 1);
         }
 
+        scsi_dev->allow_restart = 1;
+
         return 0;
 }
 
@@ -799,46 +901,42 @@ void sas_shutdown_queue(struct sas_ha_struct *sas_ha)
         spin_unlock_irqrestore(&core->task_queue_lock, flags);
 }
 
-static int do_sas_task_abort(struct sas_task *task)
+/*
+ * Call the LLDD task abort routine directly.  This function is intended for
+ * use by upper layers that need to tell the LLDD to abort a task.
+ */
+int __sas_task_abort(struct sas_task *task)
 {
-        struct scsi_cmnd *sc = task->uldd_task;
         struct sas_internal *si =
                 to_sas_internal(task->dev->port->ha->core.shost->transportt);
         unsigned long flags;
         int res;
 
         spin_lock_irqsave(&task->task_state_lock, flags);
-        if (task->task_state_flags & SAS_TASK_STATE_ABORTED) {
+        if (task->task_state_flags & SAS_TASK_STATE_ABORTED ||
+            task->task_state_flags & SAS_TASK_STATE_DONE) {
                 spin_unlock_irqrestore(&task->task_state_lock, flags);
-                SAS_DPRINTK("%s: Task %p already aborted.\n", __FUNCTION__,
+                SAS_DPRINTK("%s: Task %p already finished.\n", __FUNCTION__,
                             task);
                 return 0;
         }
-
-        task->task_state_flags |= SAS_TASK_INITIATOR_ABORTED;
-        if (!(task->task_state_flags & SAS_TASK_STATE_DONE))
-                task->task_state_flags |= SAS_TASK_STATE_ABORTED;
+        task->task_state_flags |= SAS_TASK_STATE_ABORTED;
         spin_unlock_irqrestore(&task->task_state_lock, flags);
 
         if (!si->dft->lldd_abort_task)
                 return -ENODEV;
 
         res = si->dft->lldd_abort_task(task);
+
+        spin_lock_irqsave(&task->task_state_lock, flags);
         if ((task->task_state_flags & SAS_TASK_STATE_DONE) ||
             (res == TMF_RESP_FUNC_COMPLETE))
         {
-                /* SMP commands don't have scsi_cmds(?) */
-                if (!sc) {
-                        task->task_done(task);
-                        return 0;
-                }
-                scsi_req_abort_cmd(sc);
-                scsi_schedule_eh(sc->device->host);
+                spin_unlock_irqrestore(&task->task_state_lock, flags);
+                task->task_done(task);
                 return 0;
         }
 
-        spin_lock_irqsave(&task->task_state_lock, flags);
-        task->task_state_flags &= ~SAS_TASK_INITIATOR_ABORTED;
         if (!(task->task_state_flags & SAS_TASK_STATE_DONE))
                 task->task_state_flags &= ~SAS_TASK_STATE_ABORTED;
         spin_unlock_irqrestore(&task->task_state_lock, flags);
@@ -846,17 +944,24 @@ static int do_sas_task_abort(struct sas_task *task)
         return -EAGAIN;
 }
 
-void sas_task_abort(struct work_struct *work)
+/*
+ * Tell an upper layer that it needs to initiate an abort for a given task.
+ * This should only ever be called by an LLDD.
+ */
+void sas_task_abort(struct sas_task *task)
 {
-        struct sas_task *task =
-                container_of(work, struct sas_task, abort_work);
-        int i;
+        struct scsi_cmnd *sc = task->uldd_task;
 
-        for (i = 0; i < 5; i++)
-                if (!do_sas_task_abort(task))
+        /* Escape for libsas internal commands */
+        if (!sc) {
+                if (!del_timer(&task->timer))
                         return;
+                task->timer.function(task->timer.data);
+                return;
+        }
 
-        SAS_DPRINTK("%s: Could not kill task!\n", __FUNCTION__);
+        scsi_req_abort_cmd(sc);
+        scsi_schedule_eh(sc->device->host);
 }
 
 EXPORT_SYMBOL_GPL(sas_queuecommand);
@@ -866,5 +971,8 @@ EXPORT_SYMBOL_GPL(sas_slave_destroy);
 EXPORT_SYMBOL_GPL(sas_change_queue_depth);
 EXPORT_SYMBOL_GPL(sas_change_queue_type);
 EXPORT_SYMBOL_GPL(sas_bios_param);
+EXPORT_SYMBOL_GPL(__sas_task_abort);
 EXPORT_SYMBOL_GPL(sas_task_abort);
 EXPORT_SYMBOL_GPL(sas_phy_reset);
+EXPORT_SYMBOL_GPL(sas_phy_enable);
+EXPORT_SYMBOL_GPL(sas_eh_device_reset_handler);