1 files changed, 56 insertions, 34 deletions

diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c
index 23808dfe22ba..518dbd91df85 100644
--- a/drivers/scsi/iscsi_tcp.c
+++ b/drivers/scsi/iscsi_tcp.c
@@ -48,13 +48,6 @@ MODULE_AUTHOR("Mike Christie <michaelc@cs.wisc.edu>, "
               "Alex Aizman <itn780@yahoo.com>");
 MODULE_DESCRIPTION("iSCSI/TCP data-path");
 MODULE_LICENSE("GPL");
-#undef DEBUG_TCP
-
-#ifdef DEBUG_TCP
-#define debug_tcp(fmt...) printk(KERN_INFO "tcp: " fmt)
-#else
-#define debug_tcp(fmt...)
-#endif
 
 static struct scsi_transport_template *iscsi_sw_tcp_scsi_transport;
 static struct scsi_host_template iscsi_sw_tcp_sht;
@@ -63,6 +56,21 @@ static struct iscsi_transport iscsi_sw_tcp_transport;
 static unsigned int iscsi_max_lun = 512;
 module_param_named(max_lun, iscsi_max_lun, uint, S_IRUGO);
 
+static int iscsi_sw_tcp_dbg;
+module_param_named(debug_iscsi_tcp, iscsi_sw_tcp_dbg, int,
+                   S_IRUGO | S_IWUSR);
+MODULE_PARM_DESC(debug_iscsi_tcp, "Turn on debugging for iscsi_tcp module "
+                 "Set to 1 to turn on, and zero to turn off. Default is off.");
+
+#define ISCSI_SW_TCP_DBG(_conn, dbg_fmt, arg...)                \
+        do {                                                    \
+                if (iscsi_sw_tcp_dbg)                           \
+                        iscsi_conn_printk(KERN_INFO, _conn,     \
+                                             "%s " dbg_fmt,     \
+                                             __func__, ##arg);  \
+        } while (0);
+
+
 /**
  * iscsi_sw_tcp_recv - TCP receive in sendfile fashion
  * @rd_desc: read descriptor
@@ -77,7 +85,7 @@ static int iscsi_sw_tcp_recv(read_descriptor_t *rd_desc, struct sk_buff *skb,
         unsigned int consumed, total_consumed = 0;
         int status;
 
-        debug_tcp("in %d bytes\n", skb->len - offset);
+        ISCSI_SW_TCP_DBG(conn, "in %d bytes\n", skb->len - offset);
 
         do {
                 status = 0;
@@ -86,7 +94,8 @@ static int iscsi_sw_tcp_recv(read_descriptor_t *rd_desc, struct sk_buff *skb,
                 total_consumed += consumed;
         } while (consumed != 0 && status != ISCSI_TCP_SKB_DONE);
 
-        debug_tcp("read %d bytes status %d\n", skb->len - offset, status);
+        ISCSI_SW_TCP_DBG(conn, "read %d bytes status %d\n",
+                         skb->len - offset, status);
         return total_consumed;
 }
 
@@ -131,7 +140,8 @@ static void iscsi_sw_tcp_state_change(struct sock *sk)
         if ((sk->sk_state == TCP_CLOSE_WAIT ||
              sk->sk_state == TCP_CLOSE) &&
             !atomic_read(&sk->sk_rmem_alloc)) {
-                debug_tcp("iscsi_tcp_state_change: TCP_CLOSE|TCP_CLOSE_WAIT\n");
+                ISCSI_SW_TCP_DBG(conn, "iscsi_tcp_state_change: "
+                                 "TCP_CLOSE|TCP_CLOSE_WAIT\n");
                 iscsi_conn_failure(conn, ISCSI_ERR_CONN_FAILED);
         }
 
@@ -155,8 +165,8 @@ static void iscsi_sw_tcp_write_space(struct sock *sk)
         struct iscsi_sw_tcp_conn *tcp_sw_conn = tcp_conn->dd_data;
 
         tcp_sw_conn->old_write_space(sk);
-        debug_tcp("iscsi_write_space: cid %d\n", conn->id);
-        scsi_queue_work(conn->session->host, &conn->xmitwork);
+        ISCSI_SW_TCP_DBG(conn, "iscsi_write_space\n");
+        iscsi_conn_queue_work(conn);
 }
 
 static void iscsi_sw_tcp_conn_set_callbacks(struct iscsi_conn *conn)
@@ -243,8 +253,6 @@ static int iscsi_sw_tcp_xmit_segment(struct iscsi_tcp_conn *tcp_conn,
 
                 if (r < 0) {
                         iscsi_tcp_segment_unmap(segment);
-                        if (copied || r == -EAGAIN)
-                                break;
                         return r;
                 }
                 copied += r;
@@ -265,11 +273,17 @@ static int iscsi_sw_tcp_xmit(struct iscsi_conn *conn)
 
         while (1) {
                 rc = iscsi_sw_tcp_xmit_segment(tcp_conn, segment);
-                if (rc < 0) {
+                /*
+                 * We may not have been able to send data because the conn
+                 * is getting stopped. libiscsi will know so propogate err
+                 * for it to do the right thing.
+                 */
+                if (rc == -EAGAIN)
+                        return rc;
+                else if (rc < 0) {
                         rc = ISCSI_ERR_XMIT_FAILED;
                         goto error;
-                }
-                if (rc == 0)
+                } else if (rc == 0)
                         break;
 
                 consumed += rc;
@@ -283,7 +297,7 @@ static int iscsi_sw_tcp_xmit(struct iscsi_conn *conn)
                 }
         }
 
-        debug_tcp("xmit %d bytes\n", consumed);
+        ISCSI_SW_TCP_DBG(conn, "xmit %d bytes\n", consumed);
 
         conn->txdata_octets += consumed;
         return consumed;
@@ -291,7 +305,7 @@ static int iscsi_sw_tcp_xmit(struct iscsi_conn *conn)
 error:
         /* Transmit error. We could initiate error recovery
          * here. */
-        debug_tcp("Error sending PDU, errno=%d\n", rc);
+        ISCSI_SW_TCP_DBG(conn, "Error sending PDU, errno=%d\n", rc);
         iscsi_conn_failure(conn, rc);
         return -EIO;
 }
@@ -334,9 +348,10 @@ static int iscsi_sw_tcp_send_hdr_done(struct iscsi_tcp_conn *tcp_conn,
         struct iscsi_sw_tcp_conn *tcp_sw_conn = tcp_conn->dd_data;
 
         tcp_sw_conn->out.segment = tcp_sw_conn->out.data_segment;
-        debug_tcp("Header done. Next segment size %u total_size %u\n",
-                  tcp_sw_conn->out.segment.size,
-                  tcp_sw_conn->out.segment.total_size);
+        ISCSI_SW_TCP_DBG(tcp_conn->iscsi_conn,
+                         "Header done. Next segment size %u total_size %u\n",
+                         tcp_sw_conn->out.segment.size,
+                         tcp_sw_conn->out.segment.total_size);
         return 0;
 }
 
@@ -346,8 +361,8 @@ static void iscsi_sw_tcp_send_hdr_prep(struct iscsi_conn *conn, void *hdr,
         struct iscsi_tcp_conn *tcp_conn = conn->dd_data;
         struct iscsi_sw_tcp_conn *tcp_sw_conn = tcp_conn->dd_data;
 
-        debug_tcp("%s(%p%s)\n", __func__, tcp_conn,
-                        conn->hdrdgst_en? ", digest enabled" : "");
+        ISCSI_SW_TCP_DBG(conn, "%s\n", conn->hdrdgst_en ?
+                         "digest enabled" : "digest disabled");
 
         /* Clear the data segment - needs to be filled in by the
          * caller using iscsi_tcp_send_data_prep() */
@@ -389,9 +404,9 @@ iscsi_sw_tcp_send_data_prep(struct iscsi_conn *conn, struct scatterlist *sg,
         struct hash_desc *tx_hash = NULL;
         unsigned int hdr_spec_len;
 
-        debug_tcp("%s(%p, offset=%d, datalen=%d%s)\n", __func__,
-                        tcp_conn, offset, len,
-                        conn->datadgst_en? ", digest enabled" : "");
+        ISCSI_SW_TCP_DBG(conn, "offset=%d, datalen=%d %s\n", offset, len,
+                         conn->datadgst_en ?
+                         "digest enabled" : "digest disabled");
 
         /* Make sure the datalen matches what the caller
            said he would send. */
@@ -415,8 +430,8 @@ iscsi_sw_tcp_send_linear_data_prep(struct iscsi_conn *conn, void *data,
         struct hash_desc *tx_hash = NULL;
         unsigned int hdr_spec_len;
 
-        debug_tcp("%s(%p, datalen=%d%s)\n", __func__, tcp_conn, len,
-                  conn->datadgst_en? ", digest enabled" : "");
+        ISCSI_SW_TCP_DBG(conn, "datalen=%zd %s\n", len, conn->datadgst_en ?
+                         "digest enabled" : "digest disabled");
 
         /* Make sure the datalen matches what the caller
            said he would send. */
@@ -452,7 +467,7 @@ static int iscsi_sw_tcp_pdu_init(struct iscsi_task *task,
         }
 
         if (err) {
-                iscsi_conn_failure(conn, err);
+                /* got invalid offset/len */
                 return -EIO;
         }
         return 0;
@@ -754,8 +769,7 @@ iscsi_sw_tcp_conn_get_stats(struct iscsi_cls_conn *cls_conn,
 
 static struct iscsi_cls_session *
 iscsi_sw_tcp_session_create(struct iscsi_endpoint *ep, uint16_t cmds_max,
-                            uint16_t qdepth, uint32_t initial_cmdsn,
-                            uint32_t *hostno)
+                            uint16_t qdepth, uint32_t initial_cmdsn)
 {
         struct iscsi_cls_session *cls_session;
         struct iscsi_session *session;
@@ -766,10 +780,11 @@ iscsi_sw_tcp_session_create(struct iscsi_endpoint *ep, uint16_t cmds_max,
                 return NULL;
         }
 
-        shost = iscsi_host_alloc(&iscsi_sw_tcp_sht, 0, qdepth);
+        shost = iscsi_host_alloc(&iscsi_sw_tcp_sht, 0, 1);
         if (!shost)
                 return NULL;
         shost->transportt = iscsi_sw_tcp_scsi_transport;
+        shost->cmd_per_lun = qdepth;
         shost->max_lun = iscsi_max_lun;
         shost->max_id = 0;
         shost->max_channel = 0;
@@ -777,7 +792,6 @@ iscsi_sw_tcp_session_create(struct iscsi_endpoint *ep, uint16_t cmds_max,
 
         if (iscsi_host_add(shost, NULL))
                 goto free_host;
-        *hostno = shost->host_no;
 
         cls_session = iscsi_session_setup(&iscsi_sw_tcp_transport, shost,
                                           cmds_max,
@@ -813,6 +827,12 @@ static void iscsi_sw_tcp_session_destroy(struct iscsi_cls_session *cls_session)
         iscsi_host_free(shost);
 }
 
+static int iscsi_sw_tcp_slave_alloc(struct scsi_device *sdev)
+{
+        set_bit(QUEUE_FLAG_BIDI, &sdev->request_queue->queue_flags);
+        return 0;
+}
+
 static int iscsi_sw_tcp_slave_configure(struct scsi_device *sdev)
 {
         blk_queue_bounce_limit(sdev->request_queue, BLK_BOUNCE_ANY);
@@ -833,7 +853,9 @@ static struct scsi_host_template iscsi_sw_tcp_sht = {
         .eh_device_reset_handler= iscsi_eh_device_reset,
         .eh_target_reset_handler= iscsi_eh_target_reset,
         .use_clustering         = DISABLE_CLUSTERING,
+        .slave_alloc            = iscsi_sw_tcp_slave_alloc,
         .slave_configure        = iscsi_sw_tcp_slave_configure,
+        .target_alloc           = iscsi_target_alloc,
         .proc_name              = "iscsi_tcp",
         .this_id                = -1,
 };