1 files changed, 56 insertions, 35 deletions

diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
index 9f75a6d519a2..00d08b25425f 100644
--- a/drivers/scsi/ibmvscsi/ibmvfc.c
+++ b/drivers/scsi/ibmvscsi/ibmvfc.c
@@ -50,7 +50,6 @@ static unsigned int max_lun = IBMVFC_MAX_LUN;
 static unsigned int max_targets = IBMVFC_MAX_TARGETS;
 static unsigned int max_requests = IBMVFC_MAX_REQUESTS_DEFAULT;
 static unsigned int disc_threads = IBMVFC_MAX_DISC_THREADS;
-static unsigned int dev_loss_tmo = IBMVFC_DEV_LOSS_TMO;
 static unsigned int ibmvfc_debug = IBMVFC_DEBUG;
 static unsigned int log_level = IBMVFC_DEFAULT_LOG_LEVEL;
 static LIST_HEAD(ibmvfc_head);
@@ -84,11 +83,6 @@ MODULE_PARM_DESC(disc_threads, "Number of device discovery threads to use. "
 module_param_named(debug, ibmvfc_debug, uint, S_IRUGO | S_IWUSR);
 MODULE_PARM_DESC(debug, "Enable driver debug information. "
                  "[Default=" __stringify(IBMVFC_DEBUG) "]");
-module_param_named(dev_loss_tmo, dev_loss_tmo, uint, S_IRUGO | S_IWUSR);
-MODULE_PARM_DESC(dev_loss_tmo, "Maximum number of seconds that the FC "
-                 "transport should insulate the loss of a remote port. Once this "
-                 "value is exceeded, the scsi target is removed. "
-                 "[Default=" __stringify(IBMVFC_DEV_LOSS_TMO) "]");
 module_param_named(log_level, log_level, uint, 0);
 MODULE_PARM_DESC(log_level, "Set to 0 - 4 for increasing verbosity of device driver. "
                  "[Default=" __stringify(IBMVFC_DEFAULT_LOG_LEVEL) "]");
@@ -2496,41 +2490,66 @@ static void ibmvfc_terminate_rport_io(struct fc_rport *rport)
         LEAVE;
 }
 
-static const struct {
-        enum ibmvfc_async_event ae;
-        const char *desc;
-} ae_desc [] = {
-        { IBMVFC_AE_ELS_PLOGI,          "PLOGI" },
-        { IBMVFC_AE_ELS_LOGO,           "LOGO" },
-        { IBMVFC_AE_ELS_PRLO,           "PRLO" },
-        { IBMVFC_AE_SCN_NPORT,          "N-Port SCN" },
-        { IBMVFC_AE_SCN_GROUP,          "Group SCN" },
-        { IBMVFC_AE_SCN_DOMAIN,         "Domain SCN" },
-        { IBMVFC_AE_SCN_FABRIC,         "Fabric SCN" },
-        { IBMVFC_AE_LINK_UP,            "Link Up" },
-        { IBMVFC_AE_LINK_DOWN,          "Link Down" },
-        { IBMVFC_AE_LINK_DEAD,          "Link Dead" },
-        { IBMVFC_AE_HALT,                       "Halt" },
-        { IBMVFC_AE_RESUME,             "Resume" },
-        { IBMVFC_AE_ADAPTER_FAILED,     "Adapter Failed" },
+static const struct ibmvfc_async_desc ae_desc [] = {
+        { IBMVFC_AE_ELS_PLOGI,          "PLOGI",                IBMVFC_DEFAULT_LOG_LEVEL + 1 },
+        { IBMVFC_AE_ELS_LOGO,           "LOGO",         IBMVFC_DEFAULT_LOG_LEVEL + 1 },
+        { IBMVFC_AE_ELS_PRLO,           "PRLO",         IBMVFC_DEFAULT_LOG_LEVEL + 1 },
+        { IBMVFC_AE_SCN_NPORT,          "N-Port SCN",   IBMVFC_DEFAULT_LOG_LEVEL + 1 },
+        { IBMVFC_AE_SCN_GROUP,          "Group SCN",    IBMVFC_DEFAULT_LOG_LEVEL + 1 },
+        { IBMVFC_AE_SCN_DOMAIN,         "Domain SCN",   IBMVFC_DEFAULT_LOG_LEVEL },
+        { IBMVFC_AE_SCN_FABRIC,         "Fabric SCN",   IBMVFC_DEFAULT_LOG_LEVEL },
+        { IBMVFC_AE_LINK_UP,            "Link Up",              IBMVFC_DEFAULT_LOG_LEVEL },
+        { IBMVFC_AE_LINK_DOWN,          "Link Down",    IBMVFC_DEFAULT_LOG_LEVEL },
+        { IBMVFC_AE_LINK_DEAD,          "Link Dead",    IBMVFC_DEFAULT_LOG_LEVEL },
+        { IBMVFC_AE_HALT,                       "Halt",         IBMVFC_DEFAULT_LOG_LEVEL },
+        { IBMVFC_AE_RESUME,             "Resume",               IBMVFC_DEFAULT_LOG_LEVEL },
+        { IBMVFC_AE_ADAPTER_FAILED,     "Adapter Failed",       IBMVFC_DEFAULT_LOG_LEVEL },
 };
 
-static const char *unknown_ae = "Unknown async";
+static const struct ibmvfc_async_desc unknown_ae = {
+        0, "Unknown async", IBMVFC_DEFAULT_LOG_LEVEL
+};
 
 /**
  * ibmvfc_get_ae_desc - Get text description for async event
  * @ae: async event
  *
  **/
-static const char *ibmvfc_get_ae_desc(u64 ae)
+static const struct ibmvfc_async_desc *ibmvfc_get_ae_desc(u64 ae)
 {
         int i;
 
         for (i = 0; i < ARRAY_SIZE(ae_desc); i++)
                 if (ae_desc[i].ae == ae)
-                        return ae_desc[i].desc;
+                        return &ae_desc[i];
+
+        return &unknown_ae;
+}
+
+static const struct {
+        enum ibmvfc_ae_link_state state;
+        const char *desc;
+} link_desc [] = {
+        { IBMVFC_AE_LS_LINK_UP,         " link up" },
+        { IBMVFC_AE_LS_LINK_BOUNCED,    " link bounced" },
+        { IBMVFC_AE_LS_LINK_DOWN,       " link down" },
+        { IBMVFC_AE_LS_LINK_DEAD,       " link dead" },
+};
 
-        return unknown_ae;
+/**
+ * ibmvfc_get_link_state - Get text description for link state
+ * @state:      link state
+ *
+ **/
+static const char *ibmvfc_get_link_state(enum ibmvfc_ae_link_state state)
+{
+        int i;
+
+        for (i = 0; i < ARRAY_SIZE(link_desc); i++)
+                if (link_desc[i].state == state)
+                        return link_desc[i].desc;
+
+        return "";
 }
 
 /**
@@ -2542,11 +2561,12 @@ static const char *ibmvfc_get_ae_desc(u64 ae)
 static void ibmvfc_handle_async(struct ibmvfc_async_crq *crq,
                                 struct ibmvfc_host *vhost)
 {
-        const char *desc = ibmvfc_get_ae_desc(crq->event);
+        const struct ibmvfc_async_desc *desc = ibmvfc_get_ae_desc(crq->event);
         struct ibmvfc_target *tgt;
 
-        ibmvfc_log(vhost, 3, "%s event received. scsi_id: %llx, wwpn: %llx,"
-                   " node_name: %llx\n", desc, crq->scsi_id, crq->wwpn, crq->node_name);
+        ibmvfc_log(vhost, desc->log_level, "%s event received. scsi_id: %llx, wwpn: %llx,"
+                   " node_name: %llx%s\n", desc->desc, crq->scsi_id, crq->wwpn, crq->node_name,
+                   ibmvfc_get_link_state(crq->link_state));
 
         switch (crq->event) {
         case IBMVFC_AE_RESUME:
@@ -2788,7 +2808,6 @@ static int ibmvfc_target_alloc(struct scsi_target *starget)
 static int ibmvfc_slave_configure(struct scsi_device *sdev)
 {
         struct Scsi_Host *shost = sdev->host;
-        struct fc_rport *rport = starget_to_rport(sdev->sdev_target);
         unsigned long flags = 0;
 
         spin_lock_irqsave(shost->host_lock, flags);
@@ -2800,8 +2819,6 @@ static int ibmvfc_slave_configure(struct scsi_device *sdev)
                 scsi_activate_tcq(sdev, sdev->queue_depth);
         } else
                 scsi_deactivate_tcq(sdev, sdev->queue_depth);
-
-        rport->dev_loss_tmo = dev_loss_tmo;
         spin_unlock_irqrestore(shost->host_lock, flags);
         return 0;
 }
@@ -4285,8 +4302,10 @@ static void ibmvfc_do_work(struct ibmvfc_host *vhost)
                 spin_unlock_irqrestore(vhost->host->host_lock, flags);
                 rc = ibmvfc_reset_crq(vhost);
                 spin_lock_irqsave(vhost->host->host_lock, flags);
-                if (rc || (rc = ibmvfc_send_crq_init(vhost)) ||
-                    (rc = vio_enable_interrupts(to_vio_dev(vhost->dev)))) {
+                if (rc == H_CLOSED)
+                        vio_enable_interrupts(to_vio_dev(vhost->dev));
+                else if (rc || (rc = ibmvfc_send_crq_init(vhost)) ||
+                         (rc = vio_enable_interrupts(to_vio_dev(vhost->dev)))) {
                         ibmvfc_link_down(vhost, IBMVFC_LINK_DEAD);
                         dev_err(vhost->dev, "Error after reset (rc=%d)\n", rc);
                 }
@@ -4744,6 +4763,8 @@ static int ibmvfc_probe(struct vio_dev *vdev, const struct vio_device_id *id)
         if ((rc = scsi_add_host(shost, dev)))
                 goto release_event_pool;
 
+        fc_host_dev_loss_tmo(shost) = IBMVFC_DEV_LOSS_TMO;
+
         if ((rc = ibmvfc_create_trace_file(&shost->shost_dev.kobj,
                                            &ibmvfc_trace_attr))) {
                 dev_err(dev, "Failed to create trace file. rc=%d\n", rc);