11 files changed, 126 insertions, 49 deletions

diff --git a/drivers/scsi/aic7xxx/aic7770.c b/drivers/scsi/aic7xxx/aic7770.c
index 527efd36f5c1..c4d17231c828 100644
--- a/drivers/scsi/aic7xxx/aic7770.c
+++ b/drivers/scsi/aic7xxx/aic7770.c
@@ -107,7 +107,7 @@ struct aic7770_identity aic7770_ident_table[] =
                 ahc_aic7770_EISA_setup
         }
 };
-const int ahc_num_aic7770_devs = NUM_ELEMENTS(aic7770_ident_table);
+const int ahc_num_aic7770_devs = ARRAY_SIZE(aic7770_ident_table);
 
 struct aic7770_identity *
 aic7770_find_device(uint32_t id)
diff --git a/drivers/scsi/aic7xxx/aic79xx.h b/drivers/scsi/aic7xxx/aic79xx.h
index bb5166da4358..eb7745692682 100644
--- a/drivers/scsi/aic7xxx/aic79xx.h
+++ b/drivers/scsi/aic7xxx/aic79xx.h
@@ -68,8 +68,6 @@ struct scb_platform_data;
 #define FALSE 0
 #endif
 
-#define NUM_ELEMENTS(array) (sizeof(array) / sizeof(*array))
-
 #define ALL_CHANNELS '\0'
 #define ALL_TARGETS_MASK 0xFFFF
 #define INITIATOR_WILDCARD      (~0)
diff --git a/drivers/scsi/aic7xxx/aic79xx_core.c b/drivers/scsi/aic7xxx/aic79xx_core.c
index 08771f6f6859..801fc81d0b20 100644
--- a/drivers/scsi/aic7xxx/aic79xx_core.c
+++ b/drivers/scsi/aic7xxx/aic79xx_core.c
@@ -59,7 +59,7 @@ char *ahd_chip_names[] =
         "aic7902",
         "aic7901A"
 };
-static const u_int num_chip_names = NUM_ELEMENTS(ahd_chip_names);
+static const u_int num_chip_names = ARRAY_SIZE(ahd_chip_names);
 
 /*
  * Hardware error codes.
@@ -77,7 +77,7 @@ static struct ahd_hard_error_entry ahd_hard_errors[] = {
         { MPARERR,      "Scratch or SCB Memory Parity Error" },
         { CIOPARERR,    "CIOBUS Parity Error" },
 };
-static const u_int num_errors = NUM_ELEMENTS(ahd_hard_errors);
+static const u_int num_errors = ARRAY_SIZE(ahd_hard_errors);
 
 static struct ahd_phase_table_entry ahd_phase_table[] =
 {
@@ -97,7 +97,7 @@ static struct ahd_phase_table_entry ahd_phase_table[] =
  * In most cases we only wish to itterate over real phases, so
  * exclude the last element from the count.
  */
-static const u_int num_phases = NUM_ELEMENTS(ahd_phase_table) - 1;
+static const u_int num_phases = ARRAY_SIZE(ahd_phase_table) - 1;
 
 /* Our Sequencer Program */
 #include "aic79xx_seq.h"
@@ -7259,7 +7259,7 @@ ahd_qinfifo_count(struct ahd_softc *ahd)
                 return (wrap_qinfifonext - wrap_qinpos);
         else
                 return (wrap_qinfifonext
-                      + NUM_ELEMENTS(ahd->qinfifo) - wrap_qinpos);
+                      + ARRAY_SIZE(ahd->qinfifo) - wrap_qinpos);
 }
 
 void
@@ -8619,7 +8619,7 @@ ahd_check_patch(struct ahd_softc *ahd, struct patch **start_patch,
         struct  patch *last_patch;
         u_int   num_patches;
 
-        num_patches = sizeof(patches)/sizeof(struct patch);
+        num_patches = ARRAY_SIZE(patches);
         last_patch = &patches[num_patches];
         cur_patch = *start_patch;
 
@@ -9396,8 +9396,8 @@ ahd_find_tmode_devs(struct ahd_softc *ahd, struct cam_sim *sim, union ccb *ccb,
         } else {
                 u_int max_id;
 
-                max_id = (ahd->features & AHD_WIDE) ? 15 : 7;
-                if (ccb->ccb_h.target_id > max_id)
+                max_id = (ahd->features & AHD_WIDE) ? 16 : 8;
+                if (ccb->ccb_h.target_id >= max_id)
                         return (CAM_TID_INVALID);
 
                 if (ccb->ccb_h.target_lun >= AHD_NUM_LUNS)
diff --git a/drivers/scsi/aic7xxx/aic79xx_osm.c b/drivers/scsi/aic7xxx/aic79xx_osm.c
index 66e4a47bb9ee..e0ccdf362200 100644
--- a/drivers/scsi/aic7xxx/aic79xx_osm.c
+++ b/drivers/scsi/aic7xxx/aic79xx_osm.c
@@ -916,7 +916,7 @@ ahd_linux_setup_iocell_info(u_long index, int instance, int targ, int32_t value)
 {
 
         if ((instance >= 0)
-         && (instance < NUM_ELEMENTS(aic79xx_iocell_info))) {
+         && (instance < ARRAY_SIZE(aic79xx_iocell_info))) {
                 uint8_t *iocell_info;
 
                 iocell_info = (uint8_t*)&aic79xx_iocell_info[instance];
@@ -934,7 +934,7 @@ ahd_linux_setup_tag_info_global(char *p)
         tags = simple_strtoul(p + 1, NULL, 0) & 0xff;
         printf("Setting Global Tags= %d\n", tags);
 
-        for (i = 0; i < NUM_ELEMENTS(aic79xx_tag_info); i++) {
+        for (i = 0; i < ARRAY_SIZE(aic79xx_tag_info); i++) {
                 for (j = 0; j < AHD_NUM_TARGETS; j++) {
                         aic79xx_tag_info[i].tag_commands[j] = tags;
                 }
@@ -946,7 +946,7 @@ ahd_linux_setup_tag_info(u_long arg, int instance, int targ, int32_t value)
 {
 
         if ((instance >= 0) && (targ >= 0)
-         && (instance < NUM_ELEMENTS(aic79xx_tag_info))
+         && (instance < ARRAY_SIZE(aic79xx_tag_info))
          && (targ < AHD_NUM_TARGETS)) {
                 aic79xx_tag_info[instance].tag_commands[targ] = value & 0x1FF;
                 if (bootverbose)
@@ -1072,21 +1072,21 @@ aic79xx_setup(char *s)
         end = strchr(s, '\0');
 
         /*
-         * XXX ia64 gcc isn't smart enough to know that NUM_ELEMENTS
+         * XXX ia64 gcc isn't smart enough to know that ARRAY_SIZE
          * will never be 0 in this case.
-         */      
-        n = 0;  
+         */
+        n = 0;
 
         while ((p = strsep(&s, ",.")) != NULL) {
                 if (*p == '\0')
                         continue;
-                for (i = 0; i < NUM_ELEMENTS(options); i++) {
+                for (i = 0; i < ARRAY_SIZE(options); i++) {
 
                         n = strlen(options[i].name);
                         if (strncmp(options[i].name, p, n) == 0)
                                 break;
                 }
-                if (i == NUM_ELEMENTS(options))
+                if (i == ARRAY_SIZE(options))
                         continue;
 
                 if (strncmp(p, "global_tag_depth", n) == 0) {
@@ -1294,7 +1294,7 @@ ahd_platform_init(struct ahd_softc *ahd)
         /*
          * Lookup and commit any modified IO Cell options.
          */
-        if (ahd->unit < NUM_ELEMENTS(aic79xx_iocell_info)) {
+        if (ahd->unit < ARRAY_SIZE(aic79xx_iocell_info)) {
                 struct ahd_linux_iocell_opts *iocell_opts;
 
                 iocell_opts = &aic79xx_iocell_info[ahd->unit];
@@ -1426,7 +1426,7 @@ ahd_linux_user_tagdepth(struct ahd_softc *ahd, struct ahd_devinfo *devinfo)
 
         tags = 0;
         if ((ahd->user_discenable & devinfo->target_mask) != 0) {
-                if (ahd->unit >= NUM_ELEMENTS(aic79xx_tag_info)) {
+                if (ahd->unit >= ARRAY_SIZE(aic79xx_tag_info)) {
 
                         if (warned_user == 0) {
                                 printf(KERN_WARNING
diff --git a/drivers/scsi/aic7xxx/aic79xx_pci.c b/drivers/scsi/aic7xxx/aic79xx_pci.c
index 757242e522c2..14850f31aafa 100644
--- a/drivers/scsi/aic7xxx/aic79xx_pci.c
+++ b/drivers/scsi/aic7xxx/aic79xx_pci.c
@@ -201,7 +201,7 @@ struct ahd_pci_identity ahd_pci_ident_table [] =
         }
 };
 
-const u_int ahd_num_pci_devs = NUM_ELEMENTS(ahd_pci_ident_table);
+const u_int ahd_num_pci_devs = ARRAY_SIZE(ahd_pci_ident_table);
                 
 #define DEVCONFIG               0x40
 #define         PCIXINITPAT     0x0000E000ul
diff --git a/drivers/scsi/aic7xxx/aic79xx_proc.c b/drivers/scsi/aic7xxx/aic79xx_proc.c
index 39a27840fce6..24fd59a230bf 100644
--- a/drivers/scsi/aic7xxx/aic79xx_proc.c
+++ b/drivers/scsi/aic7xxx/aic79xx_proc.c
@@ -76,11 +76,9 @@ static u_int
 ahd_calc_syncsrate(u_int period_factor)
 {
         int i;
-        int num_syncrates;
 
-        num_syncrates = sizeof(scsi_syncrates) / sizeof(scsi_syncrates[0]);
         /* See if the period is in the "exception" table */
-        for (i = 0; i < num_syncrates; i++) {
+        for (i = 0; i < ARRAY_SIZE(scsi_syncrates); i++) {
 
                 if (period_factor == scsi_syncrates[i].period_factor) {
                         /* Period in kHz */
diff --git a/drivers/scsi/aic7xxx/aic7xxx.h b/drivers/scsi/aic7xxx/aic7xxx.h
index 91d294c6334e..62ff8c3dc2bb 100644
--- a/drivers/scsi/aic7xxx/aic7xxx.h
+++ b/drivers/scsi/aic7xxx/aic7xxx.h
@@ -69,8 +69,6 @@ struct seeprom_descriptor;
 #define FALSE 0
 #endif
 
-#define NUM_ELEMENTS(array) (sizeof(array) / sizeof(*array))
-
 #define ALL_CHANNELS '\0'
 #define ALL_TARGETS_MASK 0xFFFF
 #define INITIATOR_WILDCARD      (~0)
@@ -233,6 +231,7 @@ typedef enum {
         AHC_TARGETMODE  = 0x20000,      /* Has tested target mode support */
         AHC_MULTIROLE   = 0x40000,      /* Space for two roles at a time */
         AHC_REMOVABLE   = 0x80000,      /* Hot-Swap supported */
+        AHC_HVD         = 0x100000,     /* HVD rather than SE */
         AHC_AIC7770_FE  = AHC_FENONE,
         /*
          * The real 7850 does not support Ultra modes, but there are
diff --git a/drivers/scsi/aic7xxx/aic7xxx_core.c b/drivers/scsi/aic7xxx/aic7xxx_core.c
index d37566978fba..93e4e40944b6 100644
--- a/drivers/scsi/aic7xxx/aic7xxx_core.c
+++ b/drivers/scsi/aic7xxx/aic7xxx_core.c
@@ -68,7 +68,7 @@ char *ahc_chip_names[] =
         "aic7892",
         "aic7899"
 };
-static const u_int num_chip_names = NUM_ELEMENTS(ahc_chip_names);
+static const u_int num_chip_names = ARRAY_SIZE(ahc_chip_names);
 
 /*
  * Hardware error codes.
@@ -88,7 +88,7 @@ static struct ahc_hard_error_entry ahc_hard_errors[] = {
         { PCIERRSTAT,   "PCI Error detected" },
         { CIOPARERR,    "CIOBUS Parity Error" },
 };
-static const u_int num_errors = NUM_ELEMENTS(ahc_hard_errors);
+static const u_int num_errors = ARRAY_SIZE(ahc_hard_errors);
 
 static struct ahc_phase_table_entry ahc_phase_table[] =
 {
@@ -108,7 +108,7 @@ static struct ahc_phase_table_entry ahc_phase_table[] =
  * In most cases we only wish to itterate over real phases, so
  * exclude the last element from the count.
  */
-static const u_int num_phases = NUM_ELEMENTS(ahc_phase_table) - 1;
+static const u_int num_phases = ARRAY_SIZE(ahc_phase_table) - 1;
 
 /*
  * Valid SCSIRATE values.  (p. 3-17)
@@ -6367,7 +6367,7 @@ ahc_check_patch(struct ahc_softc *ahc, struct patch **start_patch,
         struct  patch *last_patch;
         u_int   num_patches;
 
-        num_patches = sizeof(patches)/sizeof(struct patch);
+        num_patches = ARRAY_SIZE(patches);
         last_patch = &patches[num_patches];
         cur_patch = *start_patch;
 
@@ -6774,8 +6774,8 @@ ahc_find_tmode_devs(struct ahc_softc *ahc, struct cam_sim *sim, union ccb *ccb,
         } else {
                 u_int max_id;
 
-                max_id = (ahc->features & AHC_WIDE) ? 15 : 7;
-                if (ccb->ccb_h.target_id > max_id)
+                max_id = (ahc->features & AHC_WIDE) ? 16 : 8;
+                if (ccb->ccb_h.target_id >= max_id)
                         return (CAM_TID_INVALID);
 
                 if (ccb->ccb_h.target_lun >= AHC_NUM_LUNS)
diff --git a/drivers/scsi/aic7xxx/aic7xxx_osm.c b/drivers/scsi/aic7xxx/aic7xxx_osm.c
index 2c801672d8bb..debf3e2a0798 100644
--- a/drivers/scsi/aic7xxx/aic7xxx_osm.c
+++ b/drivers/scsi/aic7xxx/aic7xxx_osm.c
@@ -886,7 +886,7 @@ ahc_linux_setup_tag_info_global(char *p)
         tags = simple_strtoul(p + 1, NULL, 0) & 0xff;
         printf("Setting Global Tags= %d\n", tags);
 
-        for (i = 0; i < NUM_ELEMENTS(aic7xxx_tag_info); i++) {
+        for (i = 0; i < ARRAY_SIZE(aic7xxx_tag_info); i++) {
                 for (j = 0; j < AHC_NUM_TARGETS; j++) {
                         aic7xxx_tag_info[i].tag_commands[j] = tags;
                 }
@@ -898,7 +898,7 @@ ahc_linux_setup_tag_info(u_long arg, int instance, int targ, int32_t value)
 {
 
         if ((instance >= 0) && (targ >= 0)
-         && (instance < NUM_ELEMENTS(aic7xxx_tag_info))
+         && (instance < ARRAY_SIZE(aic7xxx_tag_info))
          && (targ < AHC_NUM_TARGETS)) {
                 aic7xxx_tag_info[instance].tag_commands[targ] = value & 0xff;
                 if (bootverbose)
@@ -1020,7 +1020,7 @@ aic7xxx_setup(char *s)
         end = strchr(s, '\0');
 
         /*
-         * XXX ia64 gcc isn't smart enough to know that NUM_ELEMENTS
+         * XXX ia64 gcc isn't smart enough to know that ARRAY_SIZE
          * will never be 0 in this case.
          */
         n = 0;
@@ -1028,13 +1028,13 @@ aic7xxx_setup(char *s)
         while ((p = strsep(&s, ",.")) != NULL) {
                 if (*p == '\0')
                         continue;
-                for (i = 0; i < NUM_ELEMENTS(options); i++) {
+                for (i = 0; i < ARRAY_SIZE(options); i++) {
 
                         n = strlen(options[i].name);
                         if (strncmp(options[i].name, p, n) == 0)
                                 break;
                 }
-                if (i == NUM_ELEMENTS(options))
+                if (i == ARRAY_SIZE(options))
                         continue;
 
                 if (strncmp(p, "global_tag_depth", n) == 0) {
@@ -1360,7 +1360,7 @@ ahc_linux_user_tagdepth(struct ahc_softc *ahc, struct ahc_devinfo *devinfo)
 
         tags = 0;
         if ((ahc->user_discenable & devinfo->target_mask) != 0) {
-                if (ahc->unit >= NUM_ELEMENTS(aic7xxx_tag_info)) {
+                if (ahc->unit >= ARRAY_SIZE(aic7xxx_tag_info)) {
                         if (warned_user == 0) {
 
                                 printf(KERN_WARNING
@@ -2537,6 +2537,22 @@ static void ahc_linux_set_iu(struct scsi_target *starget, int iu)
 }
 #endif
 
+static void ahc_linux_get_signalling(struct Scsi_Host *shost)
+{
+        struct ahc_softc *ahc = *(struct ahc_softc **)shost->hostdata;
+        u8 mode = ahc_inb(ahc, SBLKCTL);
+
+        if (mode & ENAB40)
+                spi_signalling(shost) = SPI_SIGNAL_LVD;
+        else if (mode & ENAB20)
+                spi_signalling(shost) = 
+                        ahc->features & AHC_HVD ?
+                        SPI_SIGNAL_HVD :
+                        SPI_SIGNAL_SE;
+        else
+                spi_signalling(shost) = SPI_SIGNAL_UNKNOWN;
+}
+
 static struct spi_function_template ahc_linux_transport_functions = {
         .set_offset     = ahc_linux_set_offset,
         .show_offset    = 1,
@@ -2552,6 +2568,7 @@ static struct spi_function_template ahc_linux_transport_functions = {
         .set_qas        = ahc_linux_set_qas,
         .show_qas       = 1,
 #endif
+        .get_signalling = ahc_linux_get_signalling,
 };
 
 
diff --git a/drivers/scsi/aic7xxx/aic7xxx_pci.c b/drivers/scsi/aic7xxx/aic7xxx_pci.c
index 3adecef21783..63cab2d74552 100644
--- a/drivers/scsi/aic7xxx/aic7xxx_pci.c
+++ b/drivers/scsi/aic7xxx/aic7xxx_pci.c
@@ -144,16 +144,22 @@ static ahc_device_setup_t ahc_aic785X_setup;
 static ahc_device_setup_t ahc_aic7860_setup;
 static ahc_device_setup_t ahc_apa1480_setup;
 static ahc_device_setup_t ahc_aic7870_setup;
+static ahc_device_setup_t ahc_aic7870h_setup;
 static ahc_device_setup_t ahc_aha394X_setup;
+static ahc_device_setup_t ahc_aha394Xh_setup;
 static ahc_device_setup_t ahc_aha494X_setup;
+static ahc_device_setup_t ahc_aha494Xh_setup;
 static ahc_device_setup_t ahc_aha398X_setup;
 static ahc_device_setup_t ahc_aic7880_setup;
+static ahc_device_setup_t ahc_aic7880h_setup;
 static ahc_device_setup_t ahc_aha2940Pro_setup;
 static ahc_device_setup_t ahc_aha394XU_setup;
+static ahc_device_setup_t ahc_aha394XUh_setup;
 static ahc_device_setup_t ahc_aha398XU_setup;
 static ahc_device_setup_t ahc_aic7890_setup;
 static ahc_device_setup_t ahc_aic7892_setup;
 static ahc_device_setup_t ahc_aic7895_setup;
+static ahc_device_setup_t ahc_aic7895h_setup;
 static ahc_device_setup_t ahc_aic7896_setup;
 static ahc_device_setup_t ahc_aic7899_setup;
 static ahc_device_setup_t ahc_aha29160C_setup;
@@ -225,19 +231,19 @@ struct ahc_pci_identity ahc_pci_ident_table [] =
                 ID_AHA_2944,
                 ID_ALL_MASK,
                 "Adaptec 2944 SCSI adapter",
-                ahc_aic7870_setup
+                ahc_aic7870h_setup
         },
         {
                 ID_AHA_3944,
                 ID_ALL_MASK,
                 "Adaptec 3944 SCSI adapter",
-                ahc_aha394X_setup
+                ahc_aha394Xh_setup
         },
         {
                 ID_AHA_4944,
                 ID_ALL_MASK,
                 "Adaptec 4944 SCSI adapter",
-                ahc_aha494X_setup
+                ahc_aha494Xh_setup
         },
         /* aic7880 based controllers */
         {
@@ -256,13 +262,13 @@ struct ahc_pci_identity ahc_pci_ident_table [] =
                 ID_AHA_2944U & ID_DEV_VENDOR_MASK,
                 ID_DEV_VENDOR_MASK,
                 "Adaptec 2944 Ultra SCSI adapter",
-                ahc_aic7880_setup
+                ahc_aic7880h_setup
         },
         {
                 ID_AHA_3944U & ID_DEV_VENDOR_MASK,
                 ID_DEV_VENDOR_MASK,
                 "Adaptec 3944 Ultra SCSI adapter",
-                ahc_aha394XU_setup
+                ahc_aha394XUh_setup
         },
         {
                 ID_AHA_398XU & ID_DEV_VENDOR_MASK,
@@ -278,7 +284,7 @@ struct ahc_pci_identity ahc_pci_ident_table [] =
                 ID_AHA_4944U & ID_DEV_VENDOR_MASK,
                 ID_DEV_VENDOR_MASK,
                 "Adaptec 4944 Ultra SCSI adapter",
-                ahc_aic7880_setup
+                ahc_aic7880h_setup
         },
         {
                 ID_AHA_2930U & ID_DEV_VENDOR_MASK,
@@ -414,7 +420,7 @@ struct ahc_pci_identity ahc_pci_ident_table [] =
                 ID_AHA_3944AU,
                 ID_ALL_MASK,
                 "Adaptec 3944A Ultra SCSI adapter",
-                ahc_aic7895_setup
+                ahc_aic7895h_setup
         },
         {
                 ID_AIC7895_ARO,
@@ -553,7 +559,7 @@ struct ahc_pci_identity ahc_pci_ident_table [] =
         }
 };
 
-const u_int ahc_num_pci_devs = NUM_ELEMENTS(ahc_pci_ident_table);
+const u_int ahc_num_pci_devs = ARRAY_SIZE(ahc_pci_ident_table);
                 
 #define AHC_394X_SLOT_CHANNEL_A 4
 #define AHC_394X_SLOT_CHANNEL_B 5
@@ -2121,6 +2127,16 @@ ahc_aic7870_setup(struct ahc_softc *ahc)
 }
 
 static int
+ahc_aic7870h_setup(struct ahc_softc *ahc)
+{
+        int error = ahc_aic7870_setup(ahc);
+
+        ahc->features |= AHC_HVD;
+
+        return error;
+}
+
+static int
 ahc_aha394X_setup(struct ahc_softc *ahc)
 {
         int error;
@@ -2132,6 +2148,16 @@ ahc_aha394X_setup(struct ahc_softc *ahc)
 }
 
 static int
+ahc_aha394Xh_setup(struct ahc_softc *ahc)
+{
+        int error = ahc_aha394X_setup(ahc);
+
+        ahc->features |= AHC_HVD;
+
+        return error;
+}
+
+static int
 ahc_aha398X_setup(struct ahc_softc *ahc)
 {
         int error;
@@ -2154,6 +2180,16 @@ ahc_aha494X_setup(struct ahc_softc *ahc)
 }
 
 static int
+ahc_aha494Xh_setup(struct ahc_softc *ahc)
+{
+        int error = ahc_aha494X_setup(ahc);
+
+        ahc->features |= AHC_HVD;
+
+        return error;
+}
+
+static int
 ahc_aic7880_setup(struct ahc_softc *ahc)
 {
         ahc_dev_softc_t pci;
@@ -2175,6 +2211,17 @@ ahc_aic7880_setup(struct ahc_softc *ahc)
 }
 
 static int
+ahc_aic7880h_setup(struct ahc_softc *ahc)
+{
+        int error = ahc_aic7880_setup(ahc);
+
+        ahc->features |= AHC_HVD;
+
+        return error;
+}
+
+
+static int
 ahc_aha2940Pro_setup(struct ahc_softc *ahc)
 {
 
@@ -2194,6 +2241,16 @@ ahc_aha394XU_setup(struct ahc_softc *ahc)
 }
 
 static int
+ahc_aha394XUh_setup(struct ahc_softc *ahc)
+{
+        int error = ahc_aha394XU_setup(ahc);
+
+        ahc->features |= AHC_HVD;
+
+        return error;
+}
+
+static int
 ahc_aha398XU_setup(struct ahc_softc *ahc)
 {
         int error;
@@ -2292,6 +2349,16 @@ ahc_aic7895_setup(struct ahc_softc *ahc)
 }
 
 static int
+ahc_aic7895h_setup(struct ahc_softc *ahc)
+{
+        int error = ahc_aic7895_setup(ahc);
+
+        ahc->features |= AHC_HVD;
+
+        return error;
+}
+
+static int
 ahc_aic7896_setup(struct ahc_softc *ahc)
 {
         ahc_dev_softc_t pci;
diff --git a/drivers/scsi/aic7xxx/aic7xxx_proc.c b/drivers/scsi/aic7xxx/aic7xxx_proc.c
index 04a3506cf340..5914b4aa4a8f 100644
--- a/drivers/scsi/aic7xxx/aic7xxx_proc.c
+++ b/drivers/scsi/aic7xxx/aic7xxx_proc.c
@@ -77,11 +77,9 @@ static u_int
 ahc_calc_syncsrate(u_int period_factor)
 {
         int i;
-        int num_syncrates;
 
-        num_syncrates = sizeof(scsi_syncrates) / sizeof(scsi_syncrates[0]);
         /* See if the period is in the "exception" table */
-        for (i = 0; i < num_syncrates; i++) {
+        for (i = 0; i < ARRAY_SIZE(scsi_syncrates); i++) {
 
                 if (period_factor == scsi_syncrates[i].period_factor) {
                         /* Period in kHz */