diff options
Diffstat (limited to 'drivers/scsi/aacraid')
-rw-r--r-- | drivers/scsi/aacraid/aachba.c | 283 | ||||
-rw-r--r-- | drivers/scsi/aacraid/aacraid.h | 17 | ||||
-rw-r--r-- | drivers/scsi/aacraid/comminit.c | 17 | ||||
-rw-r--r-- | drivers/scsi/aacraid/commsup.c | 581 | ||||
-rw-r--r-- | drivers/scsi/aacraid/linit.c | 12 |
5 files changed, 711 insertions, 199 deletions
diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c index a8e3dfcd0dc7..93416f760e5a 100644 --- a/drivers/scsi/aacraid/aachba.c +++ b/drivers/scsi/aacraid/aachba.c | |||
@@ -313,18 +313,37 @@ int aac_get_containers(struct aac_dev *dev) | |||
313 | } | 313 | } |
314 | dresp = (struct aac_mount *)fib_data(fibptr); | 314 | dresp = (struct aac_mount *)fib_data(fibptr); |
315 | 315 | ||
316 | if ((le32_to_cpu(dresp->status) == ST_OK) && | ||
317 | (le32_to_cpu(dresp->mnt[0].vol) == CT_NONE)) { | ||
318 | dinfo->command = cpu_to_le32(VM_NameServe64); | ||
319 | dinfo->count = cpu_to_le32(index); | ||
320 | dinfo->type = cpu_to_le32(FT_FILESYS); | ||
321 | |||
322 | if (fib_send(ContainerCommand, | ||
323 | fibptr, | ||
324 | sizeof(struct aac_query_mount), | ||
325 | FsaNormal, | ||
326 | 1, 1, | ||
327 | NULL, NULL) < 0) | ||
328 | continue; | ||
329 | } else | ||
330 | dresp->mnt[0].capacityhigh = 0; | ||
331 | |||
316 | dprintk ((KERN_DEBUG | 332 | dprintk ((KERN_DEBUG |
317 | "VM_NameServe cid=%d status=%d vol=%d state=%d cap=%u\n", | 333 | "VM_NameServe cid=%d status=%d vol=%d state=%d cap=%llu\n", |
318 | (int)index, (int)le32_to_cpu(dresp->status), | 334 | (int)index, (int)le32_to_cpu(dresp->status), |
319 | (int)le32_to_cpu(dresp->mnt[0].vol), | 335 | (int)le32_to_cpu(dresp->mnt[0].vol), |
320 | (int)le32_to_cpu(dresp->mnt[0].state), | 336 | (int)le32_to_cpu(dresp->mnt[0].state), |
321 | (unsigned)le32_to_cpu(dresp->mnt[0].capacity))); | 337 | ((u64)le32_to_cpu(dresp->mnt[0].capacity)) + |
338 | (((u64)le32_to_cpu(dresp->mnt[0].capacityhigh)) << 32))); | ||
322 | if ((le32_to_cpu(dresp->status) == ST_OK) && | 339 | if ((le32_to_cpu(dresp->status) == ST_OK) && |
323 | (le32_to_cpu(dresp->mnt[0].vol) != CT_NONE) && | 340 | (le32_to_cpu(dresp->mnt[0].vol) != CT_NONE) && |
324 | (le32_to_cpu(dresp->mnt[0].state) != FSCS_HIDDEN)) { | 341 | (le32_to_cpu(dresp->mnt[0].state) != FSCS_HIDDEN)) { |
325 | fsa_dev_ptr[index].valid = 1; | 342 | fsa_dev_ptr[index].valid = 1; |
326 | fsa_dev_ptr[index].type = le32_to_cpu(dresp->mnt[0].vol); | 343 | fsa_dev_ptr[index].type = le32_to_cpu(dresp->mnt[0].vol); |
327 | fsa_dev_ptr[index].size = le32_to_cpu(dresp->mnt[0].capacity); | 344 | fsa_dev_ptr[index].size |
345 | = ((u64)le32_to_cpu(dresp->mnt[0].capacity)) + | ||
346 | (((u64)le32_to_cpu(dresp->mnt[0].capacityhigh)) << 32); | ||
328 | if (le32_to_cpu(dresp->mnt[0].state) & FSCS_READONLY) | 347 | if (le32_to_cpu(dresp->mnt[0].state) & FSCS_READONLY) |
329 | fsa_dev_ptr[index].ro = 1; | 348 | fsa_dev_ptr[index].ro = 1; |
330 | } | 349 | } |
@@ -460,7 +479,7 @@ static int aac_get_container_name(struct scsi_cmnd * scsicmd, int cid) | |||
460 | * is updated in the struct fsa_dev_info structure rather than returned. | 479 | * is updated in the struct fsa_dev_info structure rather than returned. |
461 | */ | 480 | */ |
462 | 481 | ||
463 | static int probe_container(struct aac_dev *dev, int cid) | 482 | int probe_container(struct aac_dev *dev, int cid) |
464 | { | 483 | { |
465 | struct fsa_dev_info *fsa_dev_ptr; | 484 | struct fsa_dev_info *fsa_dev_ptr; |
466 | int status; | 485 | int status; |
@@ -497,11 +516,29 @@ static int probe_container(struct aac_dev *dev, int cid) | |||
497 | dresp = (struct aac_mount *) fib_data(fibptr); | 516 | dresp = (struct aac_mount *) fib_data(fibptr); |
498 | 517 | ||
499 | if ((le32_to_cpu(dresp->status) == ST_OK) && | 518 | if ((le32_to_cpu(dresp->status) == ST_OK) && |
519 | (le32_to_cpu(dresp->mnt[0].vol) == CT_NONE)) { | ||
520 | dinfo->command = cpu_to_le32(VM_NameServe64); | ||
521 | dinfo->count = cpu_to_le32(cid); | ||
522 | dinfo->type = cpu_to_le32(FT_FILESYS); | ||
523 | |||
524 | if (fib_send(ContainerCommand, | ||
525 | fibptr, | ||
526 | sizeof(struct aac_query_mount), | ||
527 | FsaNormal, | ||
528 | 1, 1, | ||
529 | NULL, NULL) < 0) | ||
530 | goto error; | ||
531 | } else | ||
532 | dresp->mnt[0].capacityhigh = 0; | ||
533 | |||
534 | if ((le32_to_cpu(dresp->status) == ST_OK) && | ||
500 | (le32_to_cpu(dresp->mnt[0].vol) != CT_NONE) && | 535 | (le32_to_cpu(dresp->mnt[0].vol) != CT_NONE) && |
501 | (le32_to_cpu(dresp->mnt[0].state) != FSCS_HIDDEN)) { | 536 | (le32_to_cpu(dresp->mnt[0].state) != FSCS_HIDDEN)) { |
502 | fsa_dev_ptr[cid].valid = 1; | 537 | fsa_dev_ptr[cid].valid = 1; |
503 | fsa_dev_ptr[cid].type = le32_to_cpu(dresp->mnt[0].vol); | 538 | fsa_dev_ptr[cid].type = le32_to_cpu(dresp->mnt[0].vol); |
504 | fsa_dev_ptr[cid].size = le32_to_cpu(dresp->mnt[0].capacity); | 539 | fsa_dev_ptr[cid].size |
540 | = ((u64)le32_to_cpu(dresp->mnt[0].capacity)) + | ||
541 | (((u64)le32_to_cpu(dresp->mnt[0].capacityhigh)) << 32); | ||
505 | if (le32_to_cpu(dresp->mnt[0].state) & FSCS_READONLY) | 542 | if (le32_to_cpu(dresp->mnt[0].state) & FSCS_READONLY) |
506 | fsa_dev_ptr[cid].ro = 1; | 543 | fsa_dev_ptr[cid].ro = 1; |
507 | } | 544 | } |
@@ -655,7 +692,7 @@ int aac_get_adapter_info(struct aac_dev* dev) | |||
655 | fibptr, | 692 | fibptr, |
656 | sizeof(*info), | 693 | sizeof(*info), |
657 | FsaNormal, | 694 | FsaNormal, |
658 | 1, 1, | 695 | -1, 1, /* First `interrupt' command uses special wait */ |
659 | NULL, | 696 | NULL, |
660 | NULL); | 697 | NULL); |
661 | 698 | ||
@@ -806,8 +843,8 @@ int aac_get_adapter_info(struct aac_dev* dev) | |||
806 | if (!(dev->raw_io_interface)) { | 843 | if (!(dev->raw_io_interface)) { |
807 | dev->scsi_host_ptr->sg_tablesize = (dev->max_fib_size - | 844 | dev->scsi_host_ptr->sg_tablesize = (dev->max_fib_size - |
808 | sizeof(struct aac_fibhdr) - | 845 | sizeof(struct aac_fibhdr) - |
809 | sizeof(struct aac_write) + sizeof(struct sgmap)) / | 846 | sizeof(struct aac_write) + sizeof(struct sgentry)) / |
810 | sizeof(struct sgmap); | 847 | sizeof(struct sgentry); |
811 | if (dev->dac_support) { | 848 | if (dev->dac_support) { |
812 | /* | 849 | /* |
813 | * 38 scatter gather elements | 850 | * 38 scatter gather elements |
@@ -816,8 +853,8 @@ int aac_get_adapter_info(struct aac_dev* dev) | |||
816 | (dev->max_fib_size - | 853 | (dev->max_fib_size - |
817 | sizeof(struct aac_fibhdr) - | 854 | sizeof(struct aac_fibhdr) - |
818 | sizeof(struct aac_write64) + | 855 | sizeof(struct aac_write64) + |
819 | sizeof(struct sgmap64)) / | 856 | sizeof(struct sgentry64)) / |
820 | sizeof(struct sgmap64); | 857 | sizeof(struct sgentry64); |
821 | } | 858 | } |
822 | dev->scsi_host_ptr->max_sectors = AAC_MAX_32BIT_SGBCOUNT; | 859 | dev->scsi_host_ptr->max_sectors = AAC_MAX_32BIT_SGBCOUNT; |
823 | if(!(dev->adapter_info.options & AAC_OPT_NEW_COMM)) { | 860 | if(!(dev->adapter_info.options & AAC_OPT_NEW_COMM)) { |
@@ -854,7 +891,40 @@ static void io_callback(void *context, struct fib * fibptr) | |||
854 | dev = (struct aac_dev *)scsicmd->device->host->hostdata; | 891 | dev = (struct aac_dev *)scsicmd->device->host->hostdata; |
855 | cid = ID_LUN_TO_CONTAINER(scsicmd->device->id, scsicmd->device->lun); | 892 | cid = ID_LUN_TO_CONTAINER(scsicmd->device->id, scsicmd->device->lun); |
856 | 893 | ||
857 | dprintk((KERN_DEBUG "io_callback[cpu %d]: lba = %u, t = %ld.\n", smp_processor_id(), ((scsicmd->cmnd[1] & 0x1F) << 16) | (scsicmd->cmnd[2] << 8) | scsicmd->cmnd[3], jiffies)); | 894 | if (nblank(dprintk(x))) { |
895 | u64 lba; | ||
896 | switch (scsicmd->cmnd[0]) { | ||
897 | case WRITE_6: | ||
898 | case READ_6: | ||
899 | lba = ((scsicmd->cmnd[1] & 0x1F) << 16) | | ||
900 | (scsicmd->cmnd[2] << 8) | scsicmd->cmnd[3]; | ||
901 | break; | ||
902 | case WRITE_16: | ||
903 | case READ_16: | ||
904 | lba = ((u64)scsicmd->cmnd[2] << 56) | | ||
905 | ((u64)scsicmd->cmnd[3] << 48) | | ||
906 | ((u64)scsicmd->cmnd[4] << 40) | | ||
907 | ((u64)scsicmd->cmnd[5] << 32) | | ||
908 | ((u64)scsicmd->cmnd[6] << 24) | | ||
909 | (scsicmd->cmnd[7] << 16) | | ||
910 | (scsicmd->cmnd[8] << 8) | scsicmd->cmnd[9]; | ||
911 | break; | ||
912 | case WRITE_12: | ||
913 | case READ_12: | ||
914 | lba = ((u64)scsicmd->cmnd[2] << 24) | | ||
915 | (scsicmd->cmnd[3] << 16) | | ||
916 | (scsicmd->cmnd[4] << 8) | scsicmd->cmnd[5]; | ||
917 | break; | ||
918 | default: | ||
919 | lba = ((u64)scsicmd->cmnd[2] << 24) | | ||
920 | (scsicmd->cmnd[3] << 16) | | ||
921 | (scsicmd->cmnd[4] << 8) | scsicmd->cmnd[5]; | ||
922 | break; | ||
923 | } | ||
924 | printk(KERN_DEBUG | ||
925 | "io_callback[cpu %d]: lba = %llu, t = %ld.\n", | ||
926 | smp_processor_id(), (unsigned long long)lba, jiffies); | ||
927 | } | ||
858 | 928 | ||
859 | if (fibptr == NULL) | 929 | if (fibptr == NULL) |
860 | BUG(); | 930 | BUG(); |
@@ -895,7 +965,7 @@ static void io_callback(void *context, struct fib * fibptr) | |||
895 | 965 | ||
896 | static int aac_read(struct scsi_cmnd * scsicmd, int cid) | 966 | static int aac_read(struct scsi_cmnd * scsicmd, int cid) |
897 | { | 967 | { |
898 | u32 lba; | 968 | u64 lba; |
899 | u32 count; | 969 | u32 count; |
900 | int status; | 970 | int status; |
901 | 971 | ||
@@ -907,23 +977,69 @@ static int aac_read(struct scsi_cmnd * scsicmd, int cid) | |||
907 | /* | 977 | /* |
908 | * Get block address and transfer length | 978 | * Get block address and transfer length |
909 | */ | 979 | */ |
910 | if (scsicmd->cmnd[0] == READ_6) /* 6 byte command */ | 980 | switch (scsicmd->cmnd[0]) { |
911 | { | 981 | case READ_6: |
912 | dprintk((KERN_DEBUG "aachba: received a read(6) command on id %d.\n", cid)); | 982 | dprintk((KERN_DEBUG "aachba: received a read(6) command on id %d.\n", cid)); |
913 | 983 | ||
914 | lba = ((scsicmd->cmnd[1] & 0x1F) << 16) | (scsicmd->cmnd[2] << 8) | scsicmd->cmnd[3]; | 984 | lba = ((scsicmd->cmnd[1] & 0x1F) << 16) | |
985 | (scsicmd->cmnd[2] << 8) | scsicmd->cmnd[3]; | ||
915 | count = scsicmd->cmnd[4]; | 986 | count = scsicmd->cmnd[4]; |
916 | 987 | ||
917 | if (count == 0) | 988 | if (count == 0) |
918 | count = 256; | 989 | count = 256; |
919 | } else { | 990 | break; |
991 | case READ_16: | ||
992 | dprintk((KERN_DEBUG "aachba: received a read(16) command on id %d.\n", cid)); | ||
993 | |||
994 | lba = ((u64)scsicmd->cmnd[2] << 56) | | ||
995 | ((u64)scsicmd->cmnd[3] << 48) | | ||
996 | ((u64)scsicmd->cmnd[4] << 40) | | ||
997 | ((u64)scsicmd->cmnd[5] << 32) | | ||
998 | ((u64)scsicmd->cmnd[6] << 24) | | ||
999 | (scsicmd->cmnd[7] << 16) | | ||
1000 | (scsicmd->cmnd[8] << 8) | scsicmd->cmnd[9]; | ||
1001 | count = (scsicmd->cmnd[10] << 24) | | ||
1002 | (scsicmd->cmnd[11] << 16) | | ||
1003 | (scsicmd->cmnd[12] << 8) | scsicmd->cmnd[13]; | ||
1004 | break; | ||
1005 | case READ_12: | ||
1006 | dprintk((KERN_DEBUG "aachba: received a read(12) command on id %d.\n", cid)); | ||
1007 | |||
1008 | lba = ((u64)scsicmd->cmnd[2] << 24) | | ||
1009 | (scsicmd->cmnd[3] << 16) | | ||
1010 | (scsicmd->cmnd[4] << 8) | scsicmd->cmnd[5]; | ||
1011 | count = (scsicmd->cmnd[6] << 24) | | ||
1012 | (scsicmd->cmnd[7] << 16) | | ||
1013 | (scsicmd->cmnd[8] << 8) | scsicmd->cmnd[9]; | ||
1014 | break; | ||
1015 | default: | ||
920 | dprintk((KERN_DEBUG "aachba: received a read(10) command on id %d.\n", cid)); | 1016 | dprintk((KERN_DEBUG "aachba: received a read(10) command on id %d.\n", cid)); |
921 | 1017 | ||
922 | lba = (scsicmd->cmnd[2] << 24) | (scsicmd->cmnd[3] << 16) | (scsicmd->cmnd[4] << 8) | scsicmd->cmnd[5]; | 1018 | lba = ((u64)scsicmd->cmnd[2] << 24) | |
1019 | (scsicmd->cmnd[3] << 16) | | ||
1020 | (scsicmd->cmnd[4] << 8) | scsicmd->cmnd[5]; | ||
923 | count = (scsicmd->cmnd[7] << 8) | scsicmd->cmnd[8]; | 1021 | count = (scsicmd->cmnd[7] << 8) | scsicmd->cmnd[8]; |
1022 | break; | ||
924 | } | 1023 | } |
925 | dprintk((KERN_DEBUG "aac_read[cpu %d]: lba = %u, t = %ld.\n", | 1024 | dprintk((KERN_DEBUG "aac_read[cpu %d]: lba = %llu, t = %ld.\n", |
926 | smp_processor_id(), (unsigned long long)lba, jiffies)); | 1025 | smp_processor_id(), (unsigned long long)lba, jiffies)); |
1026 | if ((!(dev->raw_io_interface) || !(dev->raw_io_64)) && | ||
1027 | (lba & 0xffffffff00000000LL)) { | ||
1028 | dprintk((KERN_DEBUG "aac_read: Illegal lba\n")); | ||
1029 | scsicmd->result = DID_OK << 16 | COMMAND_COMPLETE << 8 | | ||
1030 | SAM_STAT_CHECK_CONDITION; | ||
1031 | set_sense((u8 *) &dev->fsa_dev[cid].sense_data, | ||
1032 | HARDWARE_ERROR, | ||
1033 | SENCODE_INTERNAL_TARGET_FAILURE, | ||
1034 | ASENCODE_INTERNAL_TARGET_FAILURE, 0, 0, | ||
1035 | 0, 0); | ||
1036 | memcpy(scsicmd->sense_buffer, &dev->fsa_dev[cid].sense_data, | ||
1037 | (sizeof(dev->fsa_dev[cid].sense_data) > sizeof(scsicmd->sense_buffer)) | ||
1038 | ? sizeof(scsicmd->sense_buffer) | ||
1039 | : sizeof(dev->fsa_dev[cid].sense_data)); | ||
1040 | scsicmd->scsi_done(scsicmd); | ||
1041 | return 0; | ||
1042 | } | ||
927 | /* | 1043 | /* |
928 | * Alocate and initialize a Fib | 1044 | * Alocate and initialize a Fib |
929 | */ | 1045 | */ |
@@ -936,8 +1052,8 @@ static int aac_read(struct scsi_cmnd * scsicmd, int cid) | |||
936 | if (dev->raw_io_interface) { | 1052 | if (dev->raw_io_interface) { |
937 | struct aac_raw_io *readcmd; | 1053 | struct aac_raw_io *readcmd; |
938 | readcmd = (struct aac_raw_io *) fib_data(cmd_fibcontext); | 1054 | readcmd = (struct aac_raw_io *) fib_data(cmd_fibcontext); |
939 | readcmd->block[0] = cpu_to_le32(lba); | 1055 | readcmd->block[0] = cpu_to_le32((u32)(lba&0xffffffff)); |
940 | readcmd->block[1] = 0; | 1056 | readcmd->block[1] = cpu_to_le32((u32)((lba&0xffffffff00000000LL)>>32)); |
941 | readcmd->count = cpu_to_le32(count<<9); | 1057 | readcmd->count = cpu_to_le32(count<<9); |
942 | readcmd->cid = cpu_to_le16(cid); | 1058 | readcmd->cid = cpu_to_le16(cid); |
943 | readcmd->flags = cpu_to_le16(1); | 1059 | readcmd->flags = cpu_to_le16(1); |
@@ -964,7 +1080,7 @@ static int aac_read(struct scsi_cmnd * scsicmd, int cid) | |||
964 | readcmd->command = cpu_to_le32(VM_CtHostRead64); | 1080 | readcmd->command = cpu_to_le32(VM_CtHostRead64); |
965 | readcmd->cid = cpu_to_le16(cid); | 1081 | readcmd->cid = cpu_to_le16(cid); |
966 | readcmd->sector_count = cpu_to_le16(count); | 1082 | readcmd->sector_count = cpu_to_le16(count); |
967 | readcmd->block = cpu_to_le32(lba); | 1083 | readcmd->block = cpu_to_le32((u32)(lba&0xffffffff)); |
968 | readcmd->pad = 0; | 1084 | readcmd->pad = 0; |
969 | readcmd->flags = 0; | 1085 | readcmd->flags = 0; |
970 | 1086 | ||
@@ -989,7 +1105,7 @@ static int aac_read(struct scsi_cmnd * scsicmd, int cid) | |||
989 | readcmd = (struct aac_read *) fib_data(cmd_fibcontext); | 1105 | readcmd = (struct aac_read *) fib_data(cmd_fibcontext); |
990 | readcmd->command = cpu_to_le32(VM_CtBlockRead); | 1106 | readcmd->command = cpu_to_le32(VM_CtBlockRead); |
991 | readcmd->cid = cpu_to_le32(cid); | 1107 | readcmd->cid = cpu_to_le32(cid); |
992 | readcmd->block = cpu_to_le32(lba); | 1108 | readcmd->block = cpu_to_le32((u32)(lba&0xffffffff)); |
993 | readcmd->count = cpu_to_le32(count * 512); | 1109 | readcmd->count = cpu_to_le32(count * 512); |
994 | 1110 | ||
995 | aac_build_sg(scsicmd, &readcmd->sg); | 1111 | aac_build_sg(scsicmd, &readcmd->sg); |
@@ -1031,7 +1147,7 @@ static int aac_read(struct scsi_cmnd * scsicmd, int cid) | |||
1031 | 1147 | ||
1032 | static int aac_write(struct scsi_cmnd * scsicmd, int cid) | 1148 | static int aac_write(struct scsi_cmnd * scsicmd, int cid) |
1033 | { | 1149 | { |
1034 | u32 lba; | 1150 | u64 lba; |
1035 | u32 count; | 1151 | u32 count; |
1036 | int status; | 1152 | int status; |
1037 | u16 fibsize; | 1153 | u16 fibsize; |
@@ -1048,13 +1164,48 @@ static int aac_write(struct scsi_cmnd * scsicmd, int cid) | |||
1048 | count = scsicmd->cmnd[4]; | 1164 | count = scsicmd->cmnd[4]; |
1049 | if (count == 0) | 1165 | if (count == 0) |
1050 | count = 256; | 1166 | count = 256; |
1167 | } else if (scsicmd->cmnd[0] == WRITE_16) { /* 16 byte command */ | ||
1168 | dprintk((KERN_DEBUG "aachba: received a write(16) command on id %d.\n", cid)); | ||
1169 | |||
1170 | lba = ((u64)scsicmd->cmnd[2] << 56) | | ||
1171 | ((u64)scsicmd->cmnd[3] << 48) | | ||
1172 | ((u64)scsicmd->cmnd[4] << 40) | | ||
1173 | ((u64)scsicmd->cmnd[5] << 32) | | ||
1174 | ((u64)scsicmd->cmnd[6] << 24) | | ||
1175 | (scsicmd->cmnd[7] << 16) | | ||
1176 | (scsicmd->cmnd[8] << 8) | scsicmd->cmnd[9]; | ||
1177 | count = (scsicmd->cmnd[10] << 24) | (scsicmd->cmnd[11] << 16) | | ||
1178 | (scsicmd->cmnd[12] << 8) | scsicmd->cmnd[13]; | ||
1179 | } else if (scsicmd->cmnd[0] == WRITE_12) { /* 12 byte command */ | ||
1180 | dprintk((KERN_DEBUG "aachba: received a write(12) command on id %d.\n", cid)); | ||
1181 | |||
1182 | lba = ((u64)scsicmd->cmnd[2] << 24) | (scsicmd->cmnd[3] << 16) | ||
1183 | | (scsicmd->cmnd[4] << 8) | scsicmd->cmnd[5]; | ||
1184 | count = (scsicmd->cmnd[6] << 24) | (scsicmd->cmnd[7] << 16) | ||
1185 | | (scsicmd->cmnd[8] << 8) | scsicmd->cmnd[9]; | ||
1051 | } else { | 1186 | } else { |
1052 | dprintk((KERN_DEBUG "aachba: received a write(10) command on id %d.\n", cid)); | 1187 | dprintk((KERN_DEBUG "aachba: received a write(10) command on id %d.\n", cid)); |
1053 | lba = (scsicmd->cmnd[2] << 24) | (scsicmd->cmnd[3] << 16) | (scsicmd->cmnd[4] << 8) | scsicmd->cmnd[5]; | 1188 | lba = ((u64)scsicmd->cmnd[2] << 24) | (scsicmd->cmnd[3] << 16) | (scsicmd->cmnd[4] << 8) | scsicmd->cmnd[5]; |
1054 | count = (scsicmd->cmnd[7] << 8) | scsicmd->cmnd[8]; | 1189 | count = (scsicmd->cmnd[7] << 8) | scsicmd->cmnd[8]; |
1055 | } | 1190 | } |
1056 | dprintk((KERN_DEBUG "aac_write[cpu %d]: lba = %u, t = %ld.\n", | 1191 | dprintk((KERN_DEBUG "aac_write[cpu %d]: lba = %llu, t = %ld.\n", |
1057 | smp_processor_id(), (unsigned long long)lba, jiffies)); | 1192 | smp_processor_id(), (unsigned long long)lba, jiffies)); |
1193 | if ((!(dev->raw_io_interface) || !(dev->raw_io_64)) | ||
1194 | && (lba & 0xffffffff00000000LL)) { | ||
1195 | dprintk((KERN_DEBUG "aac_write: Illegal lba\n")); | ||
1196 | scsicmd->result = DID_OK << 16 | COMMAND_COMPLETE << 8 | SAM_STAT_CHECK_CONDITION; | ||
1197 | set_sense((u8 *) &dev->fsa_dev[cid].sense_data, | ||
1198 | HARDWARE_ERROR, | ||
1199 | SENCODE_INTERNAL_TARGET_FAILURE, | ||
1200 | ASENCODE_INTERNAL_TARGET_FAILURE, 0, 0, | ||
1201 | 0, 0); | ||
1202 | memcpy(scsicmd->sense_buffer, &dev->fsa_dev[cid].sense_data, | ||
1203 | (sizeof(dev->fsa_dev[cid].sense_data) > sizeof(scsicmd->sense_buffer)) | ||
1204 | ? sizeof(scsicmd->sense_buffer) | ||
1205 | : sizeof(dev->fsa_dev[cid].sense_data)); | ||
1206 | scsicmd->scsi_done(scsicmd); | ||
1207 | return 0; | ||
1208 | } | ||
1058 | /* | 1209 | /* |
1059 | * Allocate and initialize a Fib then setup a BlockWrite command | 1210 | * Allocate and initialize a Fib then setup a BlockWrite command |
1060 | */ | 1211 | */ |
@@ -1068,8 +1219,8 @@ static int aac_write(struct scsi_cmnd * scsicmd, int cid) | |||
1068 | if (dev->raw_io_interface) { | 1219 | if (dev->raw_io_interface) { |
1069 | struct aac_raw_io *writecmd; | 1220 | struct aac_raw_io *writecmd; |
1070 | writecmd = (struct aac_raw_io *) fib_data(cmd_fibcontext); | 1221 | writecmd = (struct aac_raw_io *) fib_data(cmd_fibcontext); |
1071 | writecmd->block[0] = cpu_to_le32(lba); | 1222 | writecmd->block[0] = cpu_to_le32((u32)(lba&0xffffffff)); |
1072 | writecmd->block[1] = 0; | 1223 | writecmd->block[1] = cpu_to_le32((u32)((lba&0xffffffff00000000LL)>>32)); |
1073 | writecmd->count = cpu_to_le32(count<<9); | 1224 | writecmd->count = cpu_to_le32(count<<9); |
1074 | writecmd->cid = cpu_to_le16(cid); | 1225 | writecmd->cid = cpu_to_le16(cid); |
1075 | writecmd->flags = 0; | 1226 | writecmd->flags = 0; |
@@ -1096,7 +1247,7 @@ static int aac_write(struct scsi_cmnd * scsicmd, int cid) | |||
1096 | writecmd->command = cpu_to_le32(VM_CtHostWrite64); | 1247 | writecmd->command = cpu_to_le32(VM_CtHostWrite64); |
1097 | writecmd->cid = cpu_to_le16(cid); | 1248 | writecmd->cid = cpu_to_le16(cid); |
1098 | writecmd->sector_count = cpu_to_le16(count); | 1249 | writecmd->sector_count = cpu_to_le16(count); |
1099 | writecmd->block = cpu_to_le32(lba); | 1250 | writecmd->block = cpu_to_le32((u32)(lba&0xffffffff)); |
1100 | writecmd->pad = 0; | 1251 | writecmd->pad = 0; |
1101 | writecmd->flags = 0; | 1252 | writecmd->flags = 0; |
1102 | 1253 | ||
@@ -1121,7 +1272,7 @@ static int aac_write(struct scsi_cmnd * scsicmd, int cid) | |||
1121 | writecmd = (struct aac_write *) fib_data(cmd_fibcontext); | 1272 | writecmd = (struct aac_write *) fib_data(cmd_fibcontext); |
1122 | writecmd->command = cpu_to_le32(VM_CtBlockWrite); | 1273 | writecmd->command = cpu_to_le32(VM_CtBlockWrite); |
1123 | writecmd->cid = cpu_to_le32(cid); | 1274 | writecmd->cid = cpu_to_le32(cid); |
1124 | writecmd->block = cpu_to_le32(lba); | 1275 | writecmd->block = cpu_to_le32((u32)(lba&0xffffffff)); |
1125 | writecmd->count = cpu_to_le32(count * 512); | 1276 | writecmd->count = cpu_to_le32(count * 512); |
1126 | writecmd->sg.count = cpu_to_le32(1); | 1277 | writecmd->sg.count = cpu_to_le32(1); |
1127 | /* ->stable is not used - it did mean which type of write */ | 1278 | /* ->stable is not used - it did mean which type of write */ |
@@ -1310,11 +1461,18 @@ int aac_scsi_cmd(struct scsi_cmnd * scsicmd) | |||
1310 | */ | 1461 | */ |
1311 | if ((fsa_dev_ptr[cid].valid & 1) == 0) { | 1462 | if ((fsa_dev_ptr[cid].valid & 1) == 0) { |
1312 | switch (scsicmd->cmnd[0]) { | 1463 | switch (scsicmd->cmnd[0]) { |
1464 | case SERVICE_ACTION_IN: | ||
1465 | if (!(dev->raw_io_interface) || | ||
1466 | !(dev->raw_io_64) || | ||
1467 | ((scsicmd->cmnd[1] & 0x1f) != SAI_READ_CAPACITY_16)) | ||
1468 | break; | ||
1313 | case INQUIRY: | 1469 | case INQUIRY: |
1314 | case READ_CAPACITY: | 1470 | case READ_CAPACITY: |
1315 | case TEST_UNIT_READY: | 1471 | case TEST_UNIT_READY: |
1316 | spin_unlock_irq(host->host_lock); | 1472 | spin_unlock_irq(host->host_lock); |
1317 | probe_container(dev, cid); | 1473 | probe_container(dev, cid); |
1474 | if ((fsa_dev_ptr[cid].valid & 1) == 0) | ||
1475 | fsa_dev_ptr[cid].valid = 0; | ||
1318 | spin_lock_irq(host->host_lock); | 1476 | spin_lock_irq(host->host_lock); |
1319 | if (fsa_dev_ptr[cid].valid == 0) { | 1477 | if (fsa_dev_ptr[cid].valid == 0) { |
1320 | scsicmd->result = DID_NO_CONNECT << 16; | 1478 | scsicmd->result = DID_NO_CONNECT << 16; |
@@ -1375,7 +1533,6 @@ int aac_scsi_cmd(struct scsi_cmnd * scsicmd) | |||
1375 | memset(&inq_data, 0, sizeof (struct inquiry_data)); | 1533 | memset(&inq_data, 0, sizeof (struct inquiry_data)); |
1376 | 1534 | ||
1377 | inq_data.inqd_ver = 2; /* claim compliance to SCSI-2 */ | 1535 | inq_data.inqd_ver = 2; /* claim compliance to SCSI-2 */ |
1378 | inq_data.inqd_dtq = 0x80; /* set RMB bit to one indicating that the medium is removable */ | ||
1379 | inq_data.inqd_rdf = 2; /* A response data format value of two indicates that the data shall be in the format specified in SCSI-2 */ | 1536 | inq_data.inqd_rdf = 2; /* A response data format value of two indicates that the data shall be in the format specified in SCSI-2 */ |
1380 | inq_data.inqd_len = 31; | 1537 | inq_data.inqd_len = 31; |
1381 | /*Format for "pad2" is RelAdr | WBus32 | WBus16 | Sync | Linked |Reserved| CmdQue | SftRe */ | 1538 | /*Format for "pad2" is RelAdr | WBus32 | WBus16 | Sync | Linked |Reserved| CmdQue | SftRe */ |
@@ -1397,13 +1554,55 @@ int aac_scsi_cmd(struct scsi_cmnd * scsicmd) | |||
1397 | aac_internal_transfer(scsicmd, &inq_data, 0, sizeof(inq_data)); | 1554 | aac_internal_transfer(scsicmd, &inq_data, 0, sizeof(inq_data)); |
1398 | return aac_get_container_name(scsicmd, cid); | 1555 | return aac_get_container_name(scsicmd, cid); |
1399 | } | 1556 | } |
1557 | case SERVICE_ACTION_IN: | ||
1558 | if (!(dev->raw_io_interface) || | ||
1559 | !(dev->raw_io_64) || | ||
1560 | ((scsicmd->cmnd[1] & 0x1f) != SAI_READ_CAPACITY_16)) | ||
1561 | break; | ||
1562 | { | ||
1563 | u64 capacity; | ||
1564 | char cp[12]; | ||
1565 | unsigned int offset = 0; | ||
1566 | |||
1567 | dprintk((KERN_DEBUG "READ CAPACITY_16 command.\n")); | ||
1568 | capacity = fsa_dev_ptr[cid].size - 1; | ||
1569 | if (scsicmd->cmnd[13] > 12) { | ||
1570 | offset = scsicmd->cmnd[13] - 12; | ||
1571 | if (offset > sizeof(cp)) | ||
1572 | break; | ||
1573 | memset(cp, 0, offset); | ||
1574 | aac_internal_transfer(scsicmd, cp, 0, offset); | ||
1575 | } | ||
1576 | cp[0] = (capacity >> 56) & 0xff; | ||
1577 | cp[1] = (capacity >> 48) & 0xff; | ||
1578 | cp[2] = (capacity >> 40) & 0xff; | ||
1579 | cp[3] = (capacity >> 32) & 0xff; | ||
1580 | cp[4] = (capacity >> 24) & 0xff; | ||
1581 | cp[5] = (capacity >> 16) & 0xff; | ||
1582 | cp[6] = (capacity >> 8) & 0xff; | ||
1583 | cp[7] = (capacity >> 0) & 0xff; | ||
1584 | cp[8] = 0; | ||
1585 | cp[9] = 0; | ||
1586 | cp[10] = 2; | ||
1587 | cp[11] = 0; | ||
1588 | aac_internal_transfer(scsicmd, cp, offset, sizeof(cp)); | ||
1589 | |||
1590 | /* Do not cache partition table for arrays */ | ||
1591 | scsicmd->device->removable = 1; | ||
1592 | |||
1593 | scsicmd->result = DID_OK << 16 | COMMAND_COMPLETE << 8 | SAM_STAT_GOOD; | ||
1594 | scsicmd->scsi_done(scsicmd); | ||
1595 | |||
1596 | return 0; | ||
1597 | } | ||
1598 | |||
1400 | case READ_CAPACITY: | 1599 | case READ_CAPACITY: |
1401 | { | 1600 | { |
1402 | u32 capacity; | 1601 | u32 capacity; |
1403 | char cp[8]; | 1602 | char cp[8]; |
1404 | 1603 | ||
1405 | dprintk((KERN_DEBUG "READ CAPACITY command.\n")); | 1604 | dprintk((KERN_DEBUG "READ CAPACITY command.\n")); |
1406 | if (fsa_dev_ptr[cid].size <= 0x100000000LL) | 1605 | if (fsa_dev_ptr[cid].size <= 0x100000000ULL) |
1407 | capacity = fsa_dev_ptr[cid].size - 1; | 1606 | capacity = fsa_dev_ptr[cid].size - 1; |
1408 | else | 1607 | else |
1409 | capacity = (u32)-1; | 1608 | capacity = (u32)-1; |
@@ -1417,6 +1616,8 @@ int aac_scsi_cmd(struct scsi_cmnd * scsicmd) | |||
1417 | cp[6] = 2; | 1616 | cp[6] = 2; |
1418 | cp[7] = 0; | 1617 | cp[7] = 0; |
1419 | aac_internal_transfer(scsicmd, cp, 0, sizeof(cp)); | 1618 | aac_internal_transfer(scsicmd, cp, 0, sizeof(cp)); |
1619 | /* Do not cache partition table for arrays */ | ||
1620 | scsicmd->device->removable = 1; | ||
1420 | 1621 | ||
1421 | scsicmd->result = DID_OK << 16 | COMMAND_COMPLETE << 8 | SAM_STAT_GOOD; | 1622 | scsicmd->result = DID_OK << 16 | COMMAND_COMPLETE << 8 | SAM_STAT_GOOD; |
1422 | scsicmd->scsi_done(scsicmd); | 1623 | scsicmd->scsi_done(scsicmd); |
@@ -1497,6 +1698,8 @@ int aac_scsi_cmd(struct scsi_cmnd * scsicmd) | |||
1497 | { | 1698 | { |
1498 | case READ_6: | 1699 | case READ_6: |
1499 | case READ_10: | 1700 | case READ_10: |
1701 | case READ_12: | ||
1702 | case READ_16: | ||
1500 | /* | 1703 | /* |
1501 | * Hack to keep track of ordinal number of the device that | 1704 | * Hack to keep track of ordinal number of the device that |
1502 | * corresponds to a container. Needed to convert | 1705 | * corresponds to a container. Needed to convert |
@@ -1504,17 +1707,19 @@ int aac_scsi_cmd(struct scsi_cmnd * scsicmd) | |||
1504 | */ | 1707 | */ |
1505 | 1708 | ||
1506 | spin_unlock_irq(host->host_lock); | 1709 | spin_unlock_irq(host->host_lock); |
1507 | if (scsicmd->request->rq_disk) | 1710 | if (scsicmd->request->rq_disk) |
1508 | memcpy(fsa_dev_ptr[cid].devname, | 1711 | strlcpy(fsa_dev_ptr[cid].devname, |
1509 | scsicmd->request->rq_disk->disk_name, | 1712 | scsicmd->request->rq_disk->disk_name, |
1510 | 8); | 1713 | min(sizeof(fsa_dev_ptr[cid].devname), |
1511 | 1714 | sizeof(scsicmd->request->rq_disk->disk_name) + 1)); | |
1512 | ret = aac_read(scsicmd, cid); | 1715 | ret = aac_read(scsicmd, cid); |
1513 | spin_lock_irq(host->host_lock); | 1716 | spin_lock_irq(host->host_lock); |
1514 | return ret; | 1717 | return ret; |
1515 | 1718 | ||
1516 | case WRITE_6: | 1719 | case WRITE_6: |
1517 | case WRITE_10: | 1720 | case WRITE_10: |
1721 | case WRITE_12: | ||
1722 | case WRITE_16: | ||
1518 | spin_unlock_irq(host->host_lock); | 1723 | spin_unlock_irq(host->host_lock); |
1519 | ret = aac_write(scsicmd, cid); | 1724 | ret = aac_write(scsicmd, cid); |
1520 | spin_lock_irq(host->host_lock); | 1725 | spin_lock_irq(host->host_lock); |
@@ -1745,6 +1950,8 @@ static void aac_srb_callback(void *context, struct fib * fibptr) | |||
1745 | case WRITE_10: | 1950 | case WRITE_10: |
1746 | case READ_12: | 1951 | case READ_12: |
1747 | case WRITE_12: | 1952 | case WRITE_12: |
1953 | case READ_16: | ||
1954 | case WRITE_16: | ||
1748 | if(le32_to_cpu(srbreply->data_xfer_length) < scsicmd->underflow ) { | 1955 | if(le32_to_cpu(srbreply->data_xfer_length) < scsicmd->underflow ) { |
1749 | printk(KERN_WARNING"aacraid: SCSI CMD underflow\n"); | 1956 | printk(KERN_WARNING"aacraid: SCSI CMD underflow\n"); |
1750 | } else { | 1957 | } else { |
@@ -1850,8 +2057,8 @@ static void aac_srb_callback(void *context, struct fib * fibptr) | |||
1850 | sizeof(scsicmd->sense_buffer) : | 2057 | sizeof(scsicmd->sense_buffer) : |
1851 | le32_to_cpu(srbreply->sense_data_size); | 2058 | le32_to_cpu(srbreply->sense_data_size); |
1852 | #ifdef AAC_DETAILED_STATUS_INFO | 2059 | #ifdef AAC_DETAILED_STATUS_INFO |
1853 | dprintk((KERN_WARNING "aac_srb_callback: check condition, status = %d len=%d\n", | 2060 | printk(KERN_WARNING "aac_srb_callback: check condition, status = %d len=%d\n", |
1854 | le32_to_cpu(srbreply->status), len)); | 2061 | le32_to_cpu(srbreply->status), len); |
1855 | #endif | 2062 | #endif |
1856 | memcpy(scsicmd->sense_buffer, srbreply->sense_data, len); | 2063 | memcpy(scsicmd->sense_buffer, srbreply->sense_data, len); |
1857 | 2064 | ||
diff --git a/drivers/scsi/aacraid/aacraid.h b/drivers/scsi/aacraid/aacraid.h index e40528185d48..4a99d2f000f4 100644 --- a/drivers/scsi/aacraid/aacraid.h +++ b/drivers/scsi/aacraid/aacraid.h | |||
@@ -1,6 +1,10 @@ | |||
1 | #if (!defined(dprintk)) | 1 | #if (!defined(dprintk)) |
2 | # define dprintk(x) | 2 | # define dprintk(x) |
3 | #endif | 3 | #endif |
4 | /* eg: if (nblank(dprintk(x))) */ | ||
5 | #define _nblank(x) #x | ||
6 | #define nblank(x) _nblank(x)[0] | ||
7 | |||
4 | 8 | ||
5 | /*------------------------------------------------------------------------------ | 9 | /*------------------------------------------------------------------------------ |
6 | * D E F I N E S | 10 | * D E F I N E S |
@@ -302,7 +306,6 @@ enum aac_queue_types { | |||
302 | */ | 306 | */ |
303 | 307 | ||
304 | #define FsaNormal 1 | 308 | #define FsaNormal 1 |
305 | #define FsaHigh 2 | ||
306 | 309 | ||
307 | /* | 310 | /* |
308 | * Define the FIB. The FIB is the where all the requested data and | 311 | * Define the FIB. The FIB is the where all the requested data and |
@@ -546,8 +549,6 @@ struct aac_queue { | |||
546 | /* This is only valid for adapter to host command queues. */ | 549 | /* This is only valid for adapter to host command queues. */ |
547 | spinlock_t *lock; /* Spinlock for this queue must take this lock before accessing the lock */ | 550 | spinlock_t *lock; /* Spinlock for this queue must take this lock before accessing the lock */ |
548 | spinlock_t lockdata; /* Actual lock (used only on one side of the lock) */ | 551 | spinlock_t lockdata; /* Actual lock (used only on one side of the lock) */ |
549 | unsigned long SavedIrql; /* Previous IRQL when the spin lock is taken */ | ||
550 | u32 padding; /* Padding - FIXME - can remove I believe */ | ||
551 | struct list_head cmdq; /* A queue of FIBs which need to be prcessed by the FS thread. This is */ | 552 | struct list_head cmdq; /* A queue of FIBs which need to be prcessed by the FS thread. This is */ |
552 | /* only valid for command queues which receive entries from the adapter. */ | 553 | /* only valid for command queues which receive entries from the adapter. */ |
553 | struct list_head pendingq; /* A queue of outstanding fib's to the adapter. */ | 554 | struct list_head pendingq; /* A queue of outstanding fib's to the adapter. */ |
@@ -776,7 +777,9 @@ struct fsa_dev_info { | |||
776 | u64 last; | 777 | u64 last; |
777 | u64 size; | 778 | u64 size; |
778 | u32 type; | 779 | u32 type; |
780 | u32 config_waiting_on; | ||
779 | u16 queue_depth; | 781 | u16 queue_depth; |
782 | u8 config_needed; | ||
780 | u8 valid; | 783 | u8 valid; |
781 | u8 ro; | 784 | u8 ro; |
782 | u8 locked; | 785 | u8 locked; |
@@ -1012,6 +1015,7 @@ struct aac_dev | |||
1012 | /* macro side-effects BEWARE */ | 1015 | /* macro side-effects BEWARE */ |
1013 | # define raw_io_interface \ | 1016 | # define raw_io_interface \ |
1014 | init->InitStructRevision==cpu_to_le32(ADAPTER_INIT_STRUCT_REVISION_4) | 1017 | init->InitStructRevision==cpu_to_le32(ADAPTER_INIT_STRUCT_REVISION_4) |
1018 | u8 raw_io_64; | ||
1015 | u8 printf_enabled; | 1019 | u8 printf_enabled; |
1016 | }; | 1020 | }; |
1017 | 1021 | ||
@@ -1362,8 +1366,10 @@ struct aac_srb_reply | |||
1362 | #define VM_CtBlockVerify64 18 | 1366 | #define VM_CtBlockVerify64 18 |
1363 | #define VM_CtHostRead64 19 | 1367 | #define VM_CtHostRead64 19 |
1364 | #define VM_CtHostWrite64 20 | 1368 | #define VM_CtHostWrite64 20 |
1369 | #define VM_DrvErrTblLog 21 | ||
1370 | #define VM_NameServe64 22 | ||
1365 | 1371 | ||
1366 | #define MAX_VMCOMMAND_NUM 21 /* used for sizing stats array - leave last */ | 1372 | #define MAX_VMCOMMAND_NUM 23 /* used for sizing stats array - leave last */ |
1367 | 1373 | ||
1368 | /* | 1374 | /* |
1369 | * Descriptive information (eg, vital stats) | 1375 | * Descriptive information (eg, vital stats) |
@@ -1472,6 +1478,7 @@ struct aac_mntent { | |||
1472 | manager (eg, filesystem) */ | 1478 | manager (eg, filesystem) */ |
1473 | __le32 altoid; /* != oid <==> snapshot or | 1479 | __le32 altoid; /* != oid <==> snapshot or |
1474 | broken mirror exists */ | 1480 | broken mirror exists */ |
1481 | __le32 capacityhigh; | ||
1475 | }; | 1482 | }; |
1476 | 1483 | ||
1477 | #define FSCS_NOTCLEAN 0x0001 /* fsck is neccessary before mounting */ | 1484 | #define FSCS_NOTCLEAN 0x0001 /* fsck is neccessary before mounting */ |
@@ -1707,6 +1714,7 @@ extern struct aac_common aac_config; | |||
1707 | #define AifCmdJobProgress 2 /* Progress report */ | 1714 | #define AifCmdJobProgress 2 /* Progress report */ |
1708 | #define AifJobCtrZero 101 /* Array Zero progress */ | 1715 | #define AifJobCtrZero 101 /* Array Zero progress */ |
1709 | #define AifJobStsSuccess 1 /* Job completes */ | 1716 | #define AifJobStsSuccess 1 /* Job completes */ |
1717 | #define AifJobStsRunning 102 /* Job running */ | ||
1710 | #define AifCmdAPIReport 3 /* Report from other user of API */ | 1718 | #define AifCmdAPIReport 3 /* Report from other user of API */ |
1711 | #define AifCmdDriverNotify 4 /* Notify host driver of event */ | 1719 | #define AifCmdDriverNotify 4 /* Notify host driver of event */ |
1712 | #define AifDenMorphComplete 200 /* A morph operation completed */ | 1720 | #define AifDenMorphComplete 200 /* A morph operation completed */ |
@@ -1777,6 +1785,7 @@ int fib_adapter_complete(struct fib * fibptr, unsigned short size); | |||
1777 | struct aac_driver_ident* aac_get_driver_ident(int devtype); | 1785 | struct aac_driver_ident* aac_get_driver_ident(int devtype); |
1778 | int aac_get_adapter_info(struct aac_dev* dev); | 1786 | int aac_get_adapter_info(struct aac_dev* dev); |
1779 | int aac_send_shutdown(struct aac_dev *dev); | 1787 | int aac_send_shutdown(struct aac_dev *dev); |
1788 | int probe_container(struct aac_dev *dev, int cid); | ||
1780 | extern int numacb; | 1789 | extern int numacb; |
1781 | extern int acbsize; | 1790 | extern int acbsize; |
1782 | extern char aac_driver_version[]; | 1791 | extern char aac_driver_version[]; |
diff --git a/drivers/scsi/aacraid/comminit.c b/drivers/scsi/aacraid/comminit.c index 75abd0453289..59a341b2aedc 100644 --- a/drivers/scsi/aacraid/comminit.c +++ b/drivers/scsi/aacraid/comminit.c | |||
@@ -195,7 +195,7 @@ int aac_send_shutdown(struct aac_dev * dev) | |||
195 | fibctx, | 195 | fibctx, |
196 | sizeof(struct aac_close), | 196 | sizeof(struct aac_close), |
197 | FsaNormal, | 197 | FsaNormal, |
198 | 1, 1, | 198 | -2 /* Timeout silently */, 1, |
199 | NULL, NULL); | 199 | NULL, NULL); |
200 | 200 | ||
201 | if (status == 0) | 201 | if (status == 0) |
@@ -313,8 +313,15 @@ struct aac_dev *aac_init_adapter(struct aac_dev *dev) | |||
313 | dev->max_fib_size = sizeof(struct hw_fib); | 313 | dev->max_fib_size = sizeof(struct hw_fib); |
314 | dev->sg_tablesize = host->sg_tablesize = (dev->max_fib_size | 314 | dev->sg_tablesize = host->sg_tablesize = (dev->max_fib_size |
315 | - sizeof(struct aac_fibhdr) | 315 | - sizeof(struct aac_fibhdr) |
316 | - sizeof(struct aac_write) + sizeof(struct sgmap)) | 316 | - sizeof(struct aac_write) + sizeof(struct sgentry)) |
317 | / sizeof(struct sgmap); | 317 | / sizeof(struct sgentry); |
318 | dev->raw_io_64 = 0; | ||
319 | if ((!aac_adapter_sync_cmd(dev, GET_ADAPTER_PROPERTIES, | ||
320 | 0, 0, 0, 0, 0, 0, status+0, status+1, status+2, NULL, NULL)) && | ||
321 | (status[0] == 0x00000001)) { | ||
322 | if (status[1] & AAC_OPT_NEW_COMM_64) | ||
323 | dev->raw_io_64 = 1; | ||
324 | } | ||
318 | if ((!aac_adapter_sync_cmd(dev, GET_COMM_PREFERRED_SETTINGS, | 325 | if ((!aac_adapter_sync_cmd(dev, GET_COMM_PREFERRED_SETTINGS, |
319 | 0, 0, 0, 0, 0, 0, | 326 | 0, 0, 0, 0, 0, 0, |
320 | status+0, status+1, status+2, status+3, status+4)) | 327 | status+0, status+1, status+2, status+3, status+4)) |
@@ -342,8 +349,8 @@ struct aac_dev *aac_init_adapter(struct aac_dev *dev) | |||
342 | dev->max_fib_size = 512; | 349 | dev->max_fib_size = 512; |
343 | dev->sg_tablesize = host->sg_tablesize | 350 | dev->sg_tablesize = host->sg_tablesize |
344 | = (512 - sizeof(struct aac_fibhdr) | 351 | = (512 - sizeof(struct aac_fibhdr) |
345 | - sizeof(struct aac_write) + sizeof(struct sgmap)) | 352 | - sizeof(struct aac_write) + sizeof(struct sgentry)) |
346 | / sizeof(struct sgmap); | 353 | / sizeof(struct sgentry); |
347 | host->can_queue = AAC_NUM_IO_FIB; | 354 | host->can_queue = AAC_NUM_IO_FIB; |
348 | } else if (acbsize == 2048) { | 355 | } else if (acbsize == 2048) { |
349 | host->max_sectors = 512; | 356 | host->max_sectors = 512; |
diff --git a/drivers/scsi/aacraid/commsup.c b/drivers/scsi/aacraid/commsup.c index a1d303f03480..e4d543a474ae 100644 --- a/drivers/scsi/aacraid/commsup.c +++ b/drivers/scsi/aacraid/commsup.c | |||
@@ -39,7 +39,9 @@ | |||
39 | #include <linux/completion.h> | 39 | #include <linux/completion.h> |
40 | #include <linux/blkdev.h> | 40 | #include <linux/blkdev.h> |
41 | #include <scsi/scsi_host.h> | 41 | #include <scsi/scsi_host.h> |
42 | #include <scsi/scsi_device.h> | ||
42 | #include <asm/semaphore.h> | 43 | #include <asm/semaphore.h> |
44 | #include <asm/delay.h> | ||
43 | 45 | ||
44 | #include "aacraid.h" | 46 | #include "aacraid.h" |
45 | 47 | ||
@@ -269,40 +271,22 @@ static int aac_get_entry (struct aac_dev * dev, u32 qid, struct aac_entry **entr | |||
269 | /* Interrupt Moderation, only interrupt for first two entries */ | 271 | /* Interrupt Moderation, only interrupt for first two entries */ |
270 | if (idx != le32_to_cpu(*(q->headers.consumer))) { | 272 | if (idx != le32_to_cpu(*(q->headers.consumer))) { |
271 | if (--idx == 0) { | 273 | if (--idx == 0) { |
272 | if (qid == AdapHighCmdQueue) | 274 | if (qid == AdapNormCmdQueue) |
273 | idx = ADAP_HIGH_CMD_ENTRIES; | ||
274 | else if (qid == AdapNormCmdQueue) | ||
275 | idx = ADAP_NORM_CMD_ENTRIES; | 275 | idx = ADAP_NORM_CMD_ENTRIES; |
276 | else if (qid == AdapHighRespQueue) | 276 | else |
277 | idx = ADAP_HIGH_RESP_ENTRIES; | ||
278 | else if (qid == AdapNormRespQueue) | ||
279 | idx = ADAP_NORM_RESP_ENTRIES; | 277 | idx = ADAP_NORM_RESP_ENTRIES; |
280 | } | 278 | } |
281 | if (idx != le32_to_cpu(*(q->headers.consumer))) | 279 | if (idx != le32_to_cpu(*(q->headers.consumer))) |
282 | *nonotify = 1; | 280 | *nonotify = 1; |
283 | } | 281 | } |
284 | 282 | ||
285 | if (qid == AdapHighCmdQueue) { | 283 | if (qid == AdapNormCmdQueue) { |
286 | if (*index >= ADAP_HIGH_CMD_ENTRIES) | ||
287 | *index = 0; | ||
288 | } else if (qid == AdapNormCmdQueue) { | ||
289 | if (*index >= ADAP_NORM_CMD_ENTRIES) | 284 | if (*index >= ADAP_NORM_CMD_ENTRIES) |
290 | *index = 0; /* Wrap to front of the Producer Queue. */ | 285 | *index = 0; /* Wrap to front of the Producer Queue. */ |
291 | } | 286 | } else { |
292 | else if (qid == AdapHighRespQueue) | ||
293 | { | ||
294 | if (*index >= ADAP_HIGH_RESP_ENTRIES) | ||
295 | *index = 0; | ||
296 | } | ||
297 | else if (qid == AdapNormRespQueue) | ||
298 | { | ||
299 | if (*index >= ADAP_NORM_RESP_ENTRIES) | 287 | if (*index >= ADAP_NORM_RESP_ENTRIES) |
300 | *index = 0; /* Wrap to front of the Producer Queue. */ | 288 | *index = 0; /* Wrap to front of the Producer Queue. */ |
301 | } | 289 | } |
302 | else { | ||
303 | printk("aacraid: invalid qid\n"); | ||
304 | BUG(); | ||
305 | } | ||
306 | 290 | ||
307 | if ((*index + 1) == le32_to_cpu(*(q->headers.consumer))) { /* Queue is full */ | 291 | if ((*index + 1) == le32_to_cpu(*(q->headers.consumer))) { /* Queue is full */ |
308 | printk(KERN_WARNING "Queue %d full, %u outstanding.\n", | 292 | printk(KERN_WARNING "Queue %d full, %u outstanding.\n", |
@@ -334,12 +318,8 @@ static int aac_queue_get(struct aac_dev * dev, u32 * index, u32 qid, struct hw_f | |||
334 | { | 318 | { |
335 | struct aac_entry * entry = NULL; | 319 | struct aac_entry * entry = NULL; |
336 | int map = 0; | 320 | int map = 0; |
337 | struct aac_queue * q = &dev->queues->queue[qid]; | ||
338 | |||
339 | spin_lock_irqsave(q->lock, q->SavedIrql); | ||
340 | 321 | ||
341 | if (qid == AdapHighCmdQueue || qid == AdapNormCmdQueue) | 322 | if (qid == AdapNormCmdQueue) { |
342 | { | ||
343 | /* if no entries wait for some if caller wants to */ | 323 | /* if no entries wait for some if caller wants to */ |
344 | while (!aac_get_entry(dev, qid, &entry, index, nonotify)) | 324 | while (!aac_get_entry(dev, qid, &entry, index, nonotify)) |
345 | { | 325 | { |
@@ -350,9 +330,7 @@ static int aac_queue_get(struct aac_dev * dev, u32 * index, u32 qid, struct hw_f | |||
350 | */ | 330 | */ |
351 | entry->size = cpu_to_le32(le16_to_cpu(hw_fib->header.Size)); | 331 | entry->size = cpu_to_le32(le16_to_cpu(hw_fib->header.Size)); |
352 | map = 1; | 332 | map = 1; |
353 | } | 333 | } else { |
354 | else if (qid == AdapHighRespQueue || qid == AdapNormRespQueue) | ||
355 | { | ||
356 | while(!aac_get_entry(dev, qid, &entry, index, nonotify)) | 334 | while(!aac_get_entry(dev, qid, &entry, index, nonotify)) |
357 | { | 335 | { |
358 | /* if no entries wait for some if caller wants to */ | 336 | /* if no entries wait for some if caller wants to */ |
@@ -375,42 +353,6 @@ static int aac_queue_get(struct aac_dev * dev, u32 * index, u32 qid, struct hw_f | |||
375 | return 0; | 353 | return 0; |
376 | } | 354 | } |
377 | 355 | ||
378 | |||
379 | /** | ||
380 | * aac_insert_entry - insert a queue entry | ||
381 | * @dev: Adapter | ||
382 | * @index: Index of entry to insert | ||
383 | * @qid: Queue number | ||
384 | * @nonotify: Suppress adapter notification | ||
385 | * | ||
386 | * Gets the next free QE off the requested priorty adapter command | ||
387 | * queue and associates the Fib with the QE. The QE represented by | ||
388 | * index is ready to insert on the queue when this routine returns | ||
389 | * success. | ||
390 | */ | ||
391 | |||
392 | static int aac_insert_entry(struct aac_dev * dev, u32 index, u32 qid, unsigned long nonotify) | ||
393 | { | ||
394 | struct aac_queue * q = &dev->queues->queue[qid]; | ||
395 | |||
396 | if(q == NULL) | ||
397 | BUG(); | ||
398 | *(q->headers.producer) = cpu_to_le32(index + 1); | ||
399 | spin_unlock_irqrestore(q->lock, q->SavedIrql); | ||
400 | |||
401 | if (qid == AdapHighCmdQueue || | ||
402 | qid == AdapNormCmdQueue || | ||
403 | qid == AdapHighRespQueue || | ||
404 | qid == AdapNormRespQueue) | ||
405 | { | ||
406 | if (!nonotify) | ||
407 | aac_adapter_notify(dev, qid); | ||
408 | } | ||
409 | else | ||
410 | printk("Suprise insert!\n"); | ||
411 | return 0; | ||
412 | } | ||
413 | |||
414 | /* | 356 | /* |
415 | * Define the highest level of host to adapter communication routines. | 357 | * Define the highest level of host to adapter communication routines. |
416 | * These routines will support host to adapter FS commuication. These | 358 | * These routines will support host to adapter FS commuication. These |
@@ -439,12 +381,13 @@ static int aac_insert_entry(struct aac_dev * dev, u32 index, u32 qid, unsigned l | |||
439 | int fib_send(u16 command, struct fib * fibptr, unsigned long size, int priority, int wait, int reply, fib_callback callback, void * callback_data) | 381 | int fib_send(u16 command, struct fib * fibptr, unsigned long size, int priority, int wait, int reply, fib_callback callback, void * callback_data) |
440 | { | 382 | { |
441 | u32 index; | 383 | u32 index; |
442 | u32 qid; | ||
443 | struct aac_dev * dev = fibptr->dev; | 384 | struct aac_dev * dev = fibptr->dev; |
444 | unsigned long nointr = 0; | 385 | unsigned long nointr = 0; |
445 | struct hw_fib * hw_fib = fibptr->hw_fib; | 386 | struct hw_fib * hw_fib = fibptr->hw_fib; |
446 | struct aac_queue * q; | 387 | struct aac_queue * q; |
447 | unsigned long flags = 0; | 388 | unsigned long flags = 0; |
389 | unsigned long qflags; | ||
390 | |||
448 | if (!(hw_fib->header.XferState & cpu_to_le32(HostOwned))) | 391 | if (!(hw_fib->header.XferState & cpu_to_le32(HostOwned))) |
449 | return -EBUSY; | 392 | return -EBUSY; |
450 | /* | 393 | /* |
@@ -497,26 +440,8 @@ int fib_send(u16 command, struct fib * fibptr, unsigned long size, int priority | |||
497 | * Get a queue entry connect the FIB to it and send an notify | 440 | * Get a queue entry connect the FIB to it and send an notify |
498 | * the adapter a command is ready. | 441 | * the adapter a command is ready. |
499 | */ | 442 | */ |
500 | if (priority == FsaHigh) { | 443 | hw_fib->header.XferState |= cpu_to_le32(NormalPriority); |
501 | hw_fib->header.XferState |= cpu_to_le32(HighPriority); | ||
502 | qid = AdapHighCmdQueue; | ||
503 | } else { | ||
504 | hw_fib->header.XferState |= cpu_to_le32(NormalPriority); | ||
505 | qid = AdapNormCmdQueue; | ||
506 | } | ||
507 | q = &dev->queues->queue[qid]; | ||
508 | 444 | ||
509 | if(wait) | ||
510 | spin_lock_irqsave(&fibptr->event_lock, flags); | ||
511 | if(aac_queue_get( dev, &index, qid, hw_fib, 1, fibptr, &nointr)<0) | ||
512 | return -EWOULDBLOCK; | ||
513 | dprintk((KERN_DEBUG "fib_send: inserting a queue entry at index %d.\n",index)); | ||
514 | dprintk((KERN_DEBUG "Fib contents:.\n")); | ||
515 | dprintk((KERN_DEBUG " Command = %d.\n", hw_fib->header.Command)); | ||
516 | dprintk((KERN_DEBUG " XferState = %x.\n", hw_fib->header.XferState)); | ||
517 | dprintk((KERN_DEBUG " hw_fib va being sent=%p\n",fibptr->hw_fib)); | ||
518 | dprintk((KERN_DEBUG " hw_fib pa being sent=%lx\n",(ulong)fibptr->hw_fib_pa)); | ||
519 | dprintk((KERN_DEBUG " fib being sent=%p\n",fibptr)); | ||
520 | /* | 445 | /* |
521 | * Fill in the Callback and CallbackContext if we are not | 446 | * Fill in the Callback and CallbackContext if we are not |
522 | * going to wait. | 447 | * going to wait. |
@@ -525,22 +450,67 @@ int fib_send(u16 command, struct fib * fibptr, unsigned long size, int priority | |||
525 | fibptr->callback = callback; | 450 | fibptr->callback = callback; |
526 | fibptr->callback_data = callback_data; | 451 | fibptr->callback_data = callback_data; |
527 | } | 452 | } |
528 | FIB_COUNTER_INCREMENT(aac_config.FibsSent); | ||
529 | list_add_tail(&fibptr->queue, &q->pendingq); | ||
530 | q->numpending++; | ||
531 | 453 | ||
532 | fibptr->done = 0; | 454 | fibptr->done = 0; |
533 | fibptr->flags = 0; | 455 | fibptr->flags = 0; |
534 | 456 | ||
535 | if(aac_insert_entry(dev, index, qid, (nointr & aac_config.irq_mod)) < 0) | 457 | FIB_COUNTER_INCREMENT(aac_config.FibsSent); |
536 | return -EWOULDBLOCK; | 458 | |
459 | dprintk((KERN_DEBUG "fib_send: inserting a queue entry at index %d.\n",index)); | ||
460 | dprintk((KERN_DEBUG "Fib contents:.\n")); | ||
461 | dprintk((KERN_DEBUG " Command = %d.\n", hw_fib->header.Command)); | ||
462 | dprintk((KERN_DEBUG " XferState = %x.\n", hw_fib->header.XferState)); | ||
463 | dprintk((KERN_DEBUG " hw_fib va being sent=%p\n",fibptr->hw_fib)); | ||
464 | dprintk((KERN_DEBUG " hw_fib pa being sent=%lx\n",(ulong)fibptr->hw_fib_pa)); | ||
465 | dprintk((KERN_DEBUG " fib being sent=%p\n",fibptr)); | ||
466 | |||
467 | q = &dev->queues->queue[AdapNormCmdQueue]; | ||
468 | |||
469 | if(wait) | ||
470 | spin_lock_irqsave(&fibptr->event_lock, flags); | ||
471 | spin_lock_irqsave(q->lock, qflags); | ||
472 | aac_queue_get( dev, &index, AdapNormCmdQueue, hw_fib, 1, fibptr, &nointr); | ||
473 | |||
474 | list_add_tail(&fibptr->queue, &q->pendingq); | ||
475 | q->numpending++; | ||
476 | *(q->headers.producer) = cpu_to_le32(index + 1); | ||
477 | spin_unlock_irqrestore(q->lock, qflags); | ||
478 | if (!(nointr & aac_config.irq_mod)) | ||
479 | aac_adapter_notify(dev, AdapNormCmdQueue); | ||
537 | /* | 480 | /* |
538 | * If the caller wanted us to wait for response wait now. | 481 | * If the caller wanted us to wait for response wait now. |
539 | */ | 482 | */ |
540 | 483 | ||
541 | if (wait) { | 484 | if (wait) { |
542 | spin_unlock_irqrestore(&fibptr->event_lock, flags); | 485 | spin_unlock_irqrestore(&fibptr->event_lock, flags); |
543 | down(&fibptr->event_wait); | 486 | /* Only set for first known interruptable command */ |
487 | if (wait < 0) { | ||
488 | /* | ||
489 | * *VERY* Dangerous to time out a command, the | ||
490 | * assumption is made that we have no hope of | ||
491 | * functioning because an interrupt routing or other | ||
492 | * hardware failure has occurred. | ||
493 | */ | ||
494 | unsigned long count = 36000000L; /* 3 minutes */ | ||
495 | unsigned long qflags; | ||
496 | while (down_trylock(&fibptr->event_wait)) { | ||
497 | if (--count == 0) { | ||
498 | spin_lock_irqsave(q->lock, qflags); | ||
499 | q->numpending--; | ||
500 | list_del(&fibptr->queue); | ||
501 | spin_unlock_irqrestore(q->lock, qflags); | ||
502 | if (wait == -1) { | ||
503 | printk(KERN_ERR "aacraid: fib_send: first asynchronous command timed out.\n" | ||
504 | "Usually a result of a PCI interrupt routing problem;\n" | ||
505 | "update mother board BIOS or consider utilizing one of\n" | ||
506 | "the SAFE mode kernel options (acpi, apic etc)\n"); | ||
507 | } | ||
508 | return -ETIMEDOUT; | ||
509 | } | ||
510 | udelay(5); | ||
511 | } | ||
512 | } else | ||
513 | down(&fibptr->event_wait); | ||
544 | if(fibptr->done == 0) | 514 | if(fibptr->done == 0) |
545 | BUG(); | 515 | BUG(); |
546 | 516 | ||
@@ -622,15 +592,9 @@ void aac_consumer_free(struct aac_dev * dev, struct aac_queue *q, u32 qid) | |||
622 | case HostNormCmdQueue: | 592 | case HostNormCmdQueue: |
623 | notify = HostNormCmdNotFull; | 593 | notify = HostNormCmdNotFull; |
624 | break; | 594 | break; |
625 | case HostHighCmdQueue: | ||
626 | notify = HostHighCmdNotFull; | ||
627 | break; | ||
628 | case HostNormRespQueue: | 595 | case HostNormRespQueue: |
629 | notify = HostNormRespNotFull; | 596 | notify = HostNormRespNotFull; |
630 | break; | 597 | break; |
631 | case HostHighRespQueue: | ||
632 | notify = HostHighRespNotFull; | ||
633 | break; | ||
634 | default: | 598 | default: |
635 | BUG(); | 599 | BUG(); |
636 | return; | 600 | return; |
@@ -652,9 +616,13 @@ int fib_adapter_complete(struct fib * fibptr, unsigned short size) | |||
652 | { | 616 | { |
653 | struct hw_fib * hw_fib = fibptr->hw_fib; | 617 | struct hw_fib * hw_fib = fibptr->hw_fib; |
654 | struct aac_dev * dev = fibptr->dev; | 618 | struct aac_dev * dev = fibptr->dev; |
619 | struct aac_queue * q; | ||
655 | unsigned long nointr = 0; | 620 | unsigned long nointr = 0; |
656 | if (hw_fib->header.XferState == 0) | 621 | unsigned long qflags; |
622 | |||
623 | if (hw_fib->header.XferState == 0) { | ||
657 | return 0; | 624 | return 0; |
625 | } | ||
658 | /* | 626 | /* |
659 | * If we plan to do anything check the structure type first. | 627 | * If we plan to do anything check the structure type first. |
660 | */ | 628 | */ |
@@ -669,37 +637,21 @@ int fib_adapter_complete(struct fib * fibptr, unsigned short size) | |||
669 | * send the completed cdb to the adapter. | 637 | * send the completed cdb to the adapter. |
670 | */ | 638 | */ |
671 | if (hw_fib->header.XferState & cpu_to_le32(SentFromAdapter)) { | 639 | if (hw_fib->header.XferState & cpu_to_le32(SentFromAdapter)) { |
640 | u32 index; | ||
672 | hw_fib->header.XferState |= cpu_to_le32(HostProcessed); | 641 | hw_fib->header.XferState |= cpu_to_le32(HostProcessed); |
673 | if (hw_fib->header.XferState & cpu_to_le32(HighPriority)) { | 642 | if (size) { |
674 | u32 index; | 643 | size += sizeof(struct aac_fibhdr); |
675 | if (size) | 644 | if (size > le16_to_cpu(hw_fib->header.SenderSize)) |
676 | { | 645 | return -EMSGSIZE; |
677 | size += sizeof(struct aac_fibhdr); | 646 | hw_fib->header.Size = cpu_to_le16(size); |
678 | if (size > le16_to_cpu(hw_fib->header.SenderSize)) | ||
679 | return -EMSGSIZE; | ||
680 | hw_fib->header.Size = cpu_to_le16(size); | ||
681 | } | ||
682 | if(aac_queue_get(dev, &index, AdapHighRespQueue, hw_fib, 1, NULL, &nointr) < 0) { | ||
683 | return -EWOULDBLOCK; | ||
684 | } | ||
685 | if (aac_insert_entry(dev, index, AdapHighRespQueue, (nointr & (int)aac_config.irq_mod)) != 0) { | ||
686 | } | ||
687 | } else if (hw_fib->header.XferState & | ||
688 | cpu_to_le32(NormalPriority)) { | ||
689 | u32 index; | ||
690 | |||
691 | if (size) { | ||
692 | size += sizeof(struct aac_fibhdr); | ||
693 | if (size > le16_to_cpu(hw_fib->header.SenderSize)) | ||
694 | return -EMSGSIZE; | ||
695 | hw_fib->header.Size = cpu_to_le16(size); | ||
696 | } | ||
697 | if (aac_queue_get(dev, &index, AdapNormRespQueue, hw_fib, 1, NULL, &nointr) < 0) | ||
698 | return -EWOULDBLOCK; | ||
699 | if (aac_insert_entry(dev, index, AdapNormRespQueue, (nointr & (int)aac_config.irq_mod)) != 0) | ||
700 | { | ||
701 | } | ||
702 | } | 647 | } |
648 | q = &dev->queues->queue[AdapNormRespQueue]; | ||
649 | spin_lock_irqsave(q->lock, qflags); | ||
650 | aac_queue_get(dev, &index, AdapNormRespQueue, hw_fib, 1, NULL, &nointr); | ||
651 | *(q->headers.producer) = cpu_to_le32(index + 1); | ||
652 | spin_unlock_irqrestore(q->lock, qflags); | ||
653 | if (!(nointr & (int)aac_config.irq_mod)) | ||
654 | aac_adapter_notify(dev, AdapNormRespQueue); | ||
703 | } | 655 | } |
704 | else | 656 | else |
705 | { | 657 | { |
@@ -791,6 +743,268 @@ void aac_printf(struct aac_dev *dev, u32 val) | |||
791 | memset(cp, 0, 256); | 743 | memset(cp, 0, 256); |
792 | } | 744 | } |
793 | 745 | ||
746 | |||
747 | /** | ||
748 | * aac_handle_aif - Handle a message from the firmware | ||
749 | * @dev: Which adapter this fib is from | ||
750 | * @fibptr: Pointer to fibptr from adapter | ||
751 | * | ||
752 | * This routine handles a driver notify fib from the adapter and | ||
753 | * dispatches it to the appropriate routine for handling. | ||
754 | */ | ||
755 | |||
756 | static void aac_handle_aif(struct aac_dev * dev, struct fib * fibptr) | ||
757 | { | ||
758 | struct hw_fib * hw_fib = fibptr->hw_fib; | ||
759 | struct aac_aifcmd * aifcmd = (struct aac_aifcmd *)hw_fib->data; | ||
760 | int busy; | ||
761 | u32 container; | ||
762 | struct scsi_device *device; | ||
763 | enum { | ||
764 | NOTHING, | ||
765 | DELETE, | ||
766 | ADD, | ||
767 | CHANGE | ||
768 | } device_config_needed; | ||
769 | |||
770 | /* Sniff for container changes */ | ||
771 | |||
772 | if (!dev) | ||
773 | return; | ||
774 | container = (u32)-1; | ||
775 | |||
776 | /* | ||
777 | * We have set this up to try and minimize the number of | ||
778 | * re-configures that take place. As a result of this when | ||
779 | * certain AIF's come in we will set a flag waiting for another | ||
780 | * type of AIF before setting the re-config flag. | ||
781 | */ | ||
782 | switch (le32_to_cpu(aifcmd->command)) { | ||
783 | case AifCmdDriverNotify: | ||
784 | switch (le32_to_cpu(((u32 *)aifcmd->data)[0])) { | ||
785 | /* | ||
786 | * Morph or Expand complete | ||
787 | */ | ||
788 | case AifDenMorphComplete: | ||
789 | case AifDenVolumeExtendComplete: | ||
790 | container = le32_to_cpu(((u32 *)aifcmd->data)[1]); | ||
791 | if (container >= dev->maximum_num_containers) | ||
792 | break; | ||
793 | |||
794 | /* | ||
795 | * Find the Scsi_Device associated with the SCSI | ||
796 | * address. Make sure we have the right array, and if | ||
797 | * so set the flag to initiate a new re-config once we | ||
798 | * see an AifEnConfigChange AIF come through. | ||
799 | */ | ||
800 | |||
801 | if ((dev != NULL) && (dev->scsi_host_ptr != NULL)) { | ||
802 | device = scsi_device_lookup(dev->scsi_host_ptr, | ||
803 | CONTAINER_TO_CHANNEL(container), | ||
804 | CONTAINER_TO_ID(container), | ||
805 | CONTAINER_TO_LUN(container)); | ||
806 | if (device) { | ||
807 | dev->fsa_dev[container].config_needed = CHANGE; | ||
808 | dev->fsa_dev[container].config_waiting_on = AifEnConfigChange; | ||
809 | scsi_device_put(device); | ||
810 | } | ||
811 | } | ||
812 | } | ||
813 | |||
814 | /* | ||
815 | * If we are waiting on something and this happens to be | ||
816 | * that thing then set the re-configure flag. | ||
817 | */ | ||
818 | if (container != (u32)-1) { | ||
819 | if (container >= dev->maximum_num_containers) | ||
820 | break; | ||
821 | if (dev->fsa_dev[container].config_waiting_on == | ||
822 | le32_to_cpu(*(u32 *)aifcmd->data)) | ||
823 | dev->fsa_dev[container].config_waiting_on = 0; | ||
824 | } else for (container = 0; | ||
825 | container < dev->maximum_num_containers; ++container) { | ||
826 | if (dev->fsa_dev[container].config_waiting_on == | ||
827 | le32_to_cpu(*(u32 *)aifcmd->data)) | ||
828 | dev->fsa_dev[container].config_waiting_on = 0; | ||
829 | } | ||
830 | break; | ||
831 | |||
832 | case AifCmdEventNotify: | ||
833 | switch (le32_to_cpu(((u32 *)aifcmd->data)[0])) { | ||
834 | /* | ||
835 | * Add an Array. | ||
836 | */ | ||
837 | case AifEnAddContainer: | ||
838 | container = le32_to_cpu(((u32 *)aifcmd->data)[1]); | ||
839 | if (container >= dev->maximum_num_containers) | ||
840 | break; | ||
841 | dev->fsa_dev[container].config_needed = ADD; | ||
842 | dev->fsa_dev[container].config_waiting_on = | ||
843 | AifEnConfigChange; | ||
844 | break; | ||
845 | |||
846 | /* | ||
847 | * Delete an Array. | ||
848 | */ | ||
849 | case AifEnDeleteContainer: | ||
850 | container = le32_to_cpu(((u32 *)aifcmd->data)[1]); | ||
851 | if (container >= dev->maximum_num_containers) | ||
852 | break; | ||
853 | dev->fsa_dev[container].config_needed = DELETE; | ||
854 | dev->fsa_dev[container].config_waiting_on = | ||
855 | AifEnConfigChange; | ||
856 | break; | ||
857 | |||
858 | /* | ||
859 | * Container change detected. If we currently are not | ||
860 | * waiting on something else, setup to wait on a Config Change. | ||
861 | */ | ||
862 | case AifEnContainerChange: | ||
863 | container = le32_to_cpu(((u32 *)aifcmd->data)[1]); | ||
864 | if (container >= dev->maximum_num_containers) | ||
865 | break; | ||
866 | if (dev->fsa_dev[container].config_waiting_on) | ||
867 | break; | ||
868 | dev->fsa_dev[container].config_needed = CHANGE; | ||
869 | dev->fsa_dev[container].config_waiting_on = | ||
870 | AifEnConfigChange; | ||
871 | break; | ||
872 | |||
873 | case AifEnConfigChange: | ||
874 | break; | ||
875 | |||
876 | } | ||
877 | |||
878 | /* | ||
879 | * If we are waiting on something and this happens to be | ||
880 | * that thing then set the re-configure flag. | ||
881 | */ | ||
882 | if (container != (u32)-1) { | ||
883 | if (container >= dev->maximum_num_containers) | ||
884 | break; | ||
885 | if (dev->fsa_dev[container].config_waiting_on == | ||
886 | le32_to_cpu(*(u32 *)aifcmd->data)) | ||
887 | dev->fsa_dev[container].config_waiting_on = 0; | ||
888 | } else for (container = 0; | ||
889 | container < dev->maximum_num_containers; ++container) { | ||
890 | if (dev->fsa_dev[container].config_waiting_on == | ||
891 | le32_to_cpu(*(u32 *)aifcmd->data)) | ||
892 | dev->fsa_dev[container].config_waiting_on = 0; | ||
893 | } | ||
894 | break; | ||
895 | |||
896 | case AifCmdJobProgress: | ||
897 | /* | ||
898 | * These are job progress AIF's. When a Clear is being | ||
899 | * done on a container it is initially created then hidden from | ||
900 | * the OS. When the clear completes we don't get a config | ||
901 | * change so we monitor the job status complete on a clear then | ||
902 | * wait for a container change. | ||
903 | */ | ||
904 | |||
905 | if ((((u32 *)aifcmd->data)[1] == cpu_to_le32(AifJobCtrZero)) | ||
906 | && ((((u32 *)aifcmd->data)[6] == ((u32 *)aifcmd->data)[5]) | ||
907 | || (((u32 *)aifcmd->data)[4] == cpu_to_le32(AifJobStsSuccess)))) { | ||
908 | for (container = 0; | ||
909 | container < dev->maximum_num_containers; | ||
910 | ++container) { | ||
911 | /* | ||
912 | * Stomp on all config sequencing for all | ||
913 | * containers? | ||
914 | */ | ||
915 | dev->fsa_dev[container].config_waiting_on = | ||
916 | AifEnContainerChange; | ||
917 | dev->fsa_dev[container].config_needed = ADD; | ||
918 | } | ||
919 | } | ||
920 | if ((((u32 *)aifcmd->data)[1] == cpu_to_le32(AifJobCtrZero)) | ||
921 | && (((u32 *)aifcmd->data)[6] == 0) | ||
922 | && (((u32 *)aifcmd->data)[4] == cpu_to_le32(AifJobStsRunning))) { | ||
923 | for (container = 0; | ||
924 | container < dev->maximum_num_containers; | ||
925 | ++container) { | ||
926 | /* | ||
927 | * Stomp on all config sequencing for all | ||
928 | * containers? | ||
929 | */ | ||
930 | dev->fsa_dev[container].config_waiting_on = | ||
931 | AifEnContainerChange; | ||
932 | dev->fsa_dev[container].config_needed = DELETE; | ||
933 | } | ||
934 | } | ||
935 | break; | ||
936 | } | ||
937 | |||
938 | device_config_needed = NOTHING; | ||
939 | for (container = 0; container < dev->maximum_num_containers; | ||
940 | ++container) { | ||
941 | if ((dev->fsa_dev[container].config_waiting_on == 0) | ||
942 | && (dev->fsa_dev[container].config_needed != NOTHING)) { | ||
943 | device_config_needed = | ||
944 | dev->fsa_dev[container].config_needed; | ||
945 | dev->fsa_dev[container].config_needed = NOTHING; | ||
946 | break; | ||
947 | } | ||
948 | } | ||
949 | if (device_config_needed == NOTHING) | ||
950 | return; | ||
951 | |||
952 | /* | ||
953 | * If we decided that a re-configuration needs to be done, | ||
954 | * schedule it here on the way out the door, please close the door | ||
955 | * behind you. | ||
956 | */ | ||
957 | |||
958 | busy = 0; | ||
959 | |||
960 | |||
961 | /* | ||
962 | * Find the Scsi_Device associated with the SCSI address, | ||
963 | * and mark it as changed, invalidating the cache. This deals | ||
964 | * with changes to existing device IDs. | ||
965 | */ | ||
966 | |||
967 | if (!dev || !dev->scsi_host_ptr) | ||
968 | return; | ||
969 | /* | ||
970 | * force reload of disk info via probe_container | ||
971 | */ | ||
972 | if ((device_config_needed == CHANGE) | ||
973 | && (dev->fsa_dev[container].valid == 1)) | ||
974 | dev->fsa_dev[container].valid = 2; | ||
975 | if ((device_config_needed == CHANGE) || | ||
976 | (device_config_needed == ADD)) | ||
977 | probe_container(dev, container); | ||
978 | device = scsi_device_lookup(dev->scsi_host_ptr, | ||
979 | CONTAINER_TO_CHANNEL(container), | ||
980 | CONTAINER_TO_ID(container), | ||
981 | CONTAINER_TO_LUN(container)); | ||
982 | if (device) { | ||
983 | switch (device_config_needed) { | ||
984 | case DELETE: | ||
985 | scsi_remove_device(device); | ||
986 | break; | ||
987 | case CHANGE: | ||
988 | if (!dev->fsa_dev[container].valid) { | ||
989 | scsi_remove_device(device); | ||
990 | break; | ||
991 | } | ||
992 | scsi_rescan_device(&device->sdev_gendev); | ||
993 | |||
994 | default: | ||
995 | break; | ||
996 | } | ||
997 | scsi_device_put(device); | ||
998 | } | ||
999 | if (device_config_needed == ADD) { | ||
1000 | scsi_add_device(dev->scsi_host_ptr, | ||
1001 | CONTAINER_TO_CHANNEL(container), | ||
1002 | CONTAINER_TO_ID(container), | ||
1003 | CONTAINER_TO_LUN(container)); | ||
1004 | } | ||
1005 | |||
1006 | } | ||
1007 | |||
794 | /** | 1008 | /** |
795 | * aac_command_thread - command processing thread | 1009 | * aac_command_thread - command processing thread |
796 | * @dev: Adapter to monitor | 1010 | * @dev: Adapter to monitor |
@@ -805,7 +1019,6 @@ int aac_command_thread(struct aac_dev * dev) | |||
805 | { | 1019 | { |
806 | struct hw_fib *hw_fib, *hw_newfib; | 1020 | struct hw_fib *hw_fib, *hw_newfib; |
807 | struct fib *fib, *newfib; | 1021 | struct fib *fib, *newfib; |
808 | struct aac_queue_block *queues = dev->queues; | ||
809 | struct aac_fib_context *fibctx; | 1022 | struct aac_fib_context *fibctx; |
810 | unsigned long flags; | 1023 | unsigned long flags; |
811 | DECLARE_WAITQUEUE(wait, current); | 1024 | DECLARE_WAITQUEUE(wait, current); |
@@ -825,21 +1038,22 @@ int aac_command_thread(struct aac_dev * dev) | |||
825 | * Let the DPC know it has a place to send the AIF's to. | 1038 | * Let the DPC know it has a place to send the AIF's to. |
826 | */ | 1039 | */ |
827 | dev->aif_thread = 1; | 1040 | dev->aif_thread = 1; |
828 | add_wait_queue(&queues->queue[HostNormCmdQueue].cmdready, &wait); | 1041 | add_wait_queue(&dev->queues->queue[HostNormCmdQueue].cmdready, &wait); |
829 | set_current_state(TASK_INTERRUPTIBLE); | 1042 | set_current_state(TASK_INTERRUPTIBLE); |
1043 | dprintk ((KERN_INFO "aac_command_thread start\n")); | ||
830 | while(1) | 1044 | while(1) |
831 | { | 1045 | { |
832 | spin_lock_irqsave(queues->queue[HostNormCmdQueue].lock, flags); | 1046 | spin_lock_irqsave(dev->queues->queue[HostNormCmdQueue].lock, flags); |
833 | while(!list_empty(&(queues->queue[HostNormCmdQueue].cmdq))) { | 1047 | while(!list_empty(&(dev->queues->queue[HostNormCmdQueue].cmdq))) { |
834 | struct list_head *entry; | 1048 | struct list_head *entry; |
835 | struct aac_aifcmd * aifcmd; | 1049 | struct aac_aifcmd * aifcmd; |
836 | 1050 | ||
837 | set_current_state(TASK_RUNNING); | 1051 | set_current_state(TASK_RUNNING); |
838 | 1052 | ||
839 | entry = queues->queue[HostNormCmdQueue].cmdq.next; | 1053 | entry = dev->queues->queue[HostNormCmdQueue].cmdq.next; |
840 | list_del(entry); | 1054 | list_del(entry); |
841 | 1055 | ||
842 | spin_unlock_irqrestore(queues->queue[HostNormCmdQueue].lock, flags); | 1056 | spin_unlock_irqrestore(dev->queues->queue[HostNormCmdQueue].lock, flags); |
843 | fib = list_entry(entry, struct fib, fiblink); | 1057 | fib = list_entry(entry, struct fib, fiblink); |
844 | /* | 1058 | /* |
845 | * We will process the FIB here or pass it to a | 1059 | * We will process the FIB here or pass it to a |
@@ -860,6 +1074,7 @@ int aac_command_thread(struct aac_dev * dev) | |||
860 | aifcmd = (struct aac_aifcmd *) hw_fib->data; | 1074 | aifcmd = (struct aac_aifcmd *) hw_fib->data; |
861 | if (aifcmd->command == cpu_to_le32(AifCmdDriverNotify)) { | 1075 | if (aifcmd->command == cpu_to_le32(AifCmdDriverNotify)) { |
862 | /* Handle Driver Notify Events */ | 1076 | /* Handle Driver Notify Events */ |
1077 | aac_handle_aif(dev, fib); | ||
863 | *(__le32 *)hw_fib->data = cpu_to_le32(ST_OK); | 1078 | *(__le32 *)hw_fib->data = cpu_to_le32(ST_OK); |
864 | fib_adapter_complete(fib, (u16)sizeof(u32)); | 1079 | fib_adapter_complete(fib, (u16)sizeof(u32)); |
865 | } else { | 1080 | } else { |
@@ -869,9 +1084,62 @@ int aac_command_thread(struct aac_dev * dev) | |||
869 | 1084 | ||
870 | u32 time_now, time_last; | 1085 | u32 time_now, time_last; |
871 | unsigned long flagv; | 1086 | unsigned long flagv; |
872 | 1087 | unsigned num; | |
1088 | struct hw_fib ** hw_fib_pool, ** hw_fib_p; | ||
1089 | struct fib ** fib_pool, ** fib_p; | ||
1090 | |||
1091 | /* Sniff events */ | ||
1092 | if ((aifcmd->command == | ||
1093 | cpu_to_le32(AifCmdEventNotify)) || | ||
1094 | (aifcmd->command == | ||
1095 | cpu_to_le32(AifCmdJobProgress))) { | ||
1096 | aac_handle_aif(dev, fib); | ||
1097 | } | ||
1098 | |||
873 | time_now = jiffies/HZ; | 1099 | time_now = jiffies/HZ; |
874 | 1100 | ||
1101 | /* | ||
1102 | * Warning: no sleep allowed while | ||
1103 | * holding spinlock. We take the estimate | ||
1104 | * and pre-allocate a set of fibs outside the | ||
1105 | * lock. | ||
1106 | */ | ||
1107 | num = le32_to_cpu(dev->init->AdapterFibsSize) | ||
1108 | / sizeof(struct hw_fib); /* some extra */ | ||
1109 | spin_lock_irqsave(&dev->fib_lock, flagv); | ||
1110 | entry = dev->fib_list.next; | ||
1111 | while (entry != &dev->fib_list) { | ||
1112 | entry = entry->next; | ||
1113 | ++num; | ||
1114 | } | ||
1115 | spin_unlock_irqrestore(&dev->fib_lock, flagv); | ||
1116 | hw_fib_pool = NULL; | ||
1117 | fib_pool = NULL; | ||
1118 | if (num | ||
1119 | && ((hw_fib_pool = kmalloc(sizeof(struct hw_fib *) * num, GFP_KERNEL))) | ||
1120 | && ((fib_pool = kmalloc(sizeof(struct fib *) * num, GFP_KERNEL)))) { | ||
1121 | hw_fib_p = hw_fib_pool; | ||
1122 | fib_p = fib_pool; | ||
1123 | while (hw_fib_p < &hw_fib_pool[num]) { | ||
1124 | if (!(*(hw_fib_p++) = kmalloc(sizeof(struct hw_fib), GFP_KERNEL))) { | ||
1125 | --hw_fib_p; | ||
1126 | break; | ||
1127 | } | ||
1128 | if (!(*(fib_p++) = kmalloc(sizeof(struct fib), GFP_KERNEL))) { | ||
1129 | kfree(*(--hw_fib_p)); | ||
1130 | break; | ||
1131 | } | ||
1132 | } | ||
1133 | if ((num = hw_fib_p - hw_fib_pool) == 0) { | ||
1134 | kfree(fib_pool); | ||
1135 | fib_pool = NULL; | ||
1136 | kfree(hw_fib_pool); | ||
1137 | hw_fib_pool = NULL; | ||
1138 | } | ||
1139 | } else if (hw_fib_pool) { | ||
1140 | kfree(hw_fib_pool); | ||
1141 | hw_fib_pool = NULL; | ||
1142 | } | ||
875 | spin_lock_irqsave(&dev->fib_lock, flagv); | 1143 | spin_lock_irqsave(&dev->fib_lock, flagv); |
876 | entry = dev->fib_list.next; | 1144 | entry = dev->fib_list.next; |
877 | /* | 1145 | /* |
@@ -880,6 +1148,8 @@ int aac_command_thread(struct aac_dev * dev) | |||
880 | * fib, and then set the event to wake up the | 1148 | * fib, and then set the event to wake up the |
881 | * thread that is waiting for it. | 1149 | * thread that is waiting for it. |
882 | */ | 1150 | */ |
1151 | hw_fib_p = hw_fib_pool; | ||
1152 | fib_p = fib_pool; | ||
883 | while (entry != &dev->fib_list) { | 1153 | while (entry != &dev->fib_list) { |
884 | /* | 1154 | /* |
885 | * Extract the fibctx | 1155 | * Extract the fibctx |
@@ -912,9 +1182,11 @@ int aac_command_thread(struct aac_dev * dev) | |||
912 | * Warning: no sleep allowed while | 1182 | * Warning: no sleep allowed while |
913 | * holding spinlock | 1183 | * holding spinlock |
914 | */ | 1184 | */ |
915 | hw_newfib = kmalloc(sizeof(struct hw_fib), GFP_ATOMIC); | 1185 | if (hw_fib_p < &hw_fib_pool[num]) { |
916 | newfib = kmalloc(sizeof(struct fib), GFP_ATOMIC); | 1186 | hw_newfib = *hw_fib_p; |
917 | if (newfib && hw_newfib) { | 1187 | *(hw_fib_p++) = NULL; |
1188 | newfib = *fib_p; | ||
1189 | *(fib_p++) = NULL; | ||
918 | /* | 1190 | /* |
919 | * Make the copy of the FIB | 1191 | * Make the copy of the FIB |
920 | */ | 1192 | */ |
@@ -929,15 +1201,11 @@ int aac_command_thread(struct aac_dev * dev) | |||
929 | fibctx->count++; | 1201 | fibctx->count++; |
930 | /* | 1202 | /* |
931 | * Set the event to wake up the | 1203 | * Set the event to wake up the |
932 | * thread that will waiting. | 1204 | * thread that is waiting. |
933 | */ | 1205 | */ |
934 | up(&fibctx->wait_sem); | 1206 | up(&fibctx->wait_sem); |
935 | } else { | 1207 | } else { |
936 | printk(KERN_WARNING "aifd: didn't allocate NewFib.\n"); | 1208 | printk(KERN_WARNING "aifd: didn't allocate NewFib.\n"); |
937 | if(newfib) | ||
938 | kfree(newfib); | ||
939 | if(hw_newfib) | ||
940 | kfree(hw_newfib); | ||
941 | } | 1209 | } |
942 | entry = entry->next; | 1210 | entry = entry->next; |
943 | } | 1211 | } |
@@ -947,21 +1215,38 @@ int aac_command_thread(struct aac_dev * dev) | |||
947 | *(__le32 *)hw_fib->data = cpu_to_le32(ST_OK); | 1215 | *(__le32 *)hw_fib->data = cpu_to_le32(ST_OK); |
948 | fib_adapter_complete(fib, sizeof(u32)); | 1216 | fib_adapter_complete(fib, sizeof(u32)); |
949 | spin_unlock_irqrestore(&dev->fib_lock, flagv); | 1217 | spin_unlock_irqrestore(&dev->fib_lock, flagv); |
1218 | /* Free up the remaining resources */ | ||
1219 | hw_fib_p = hw_fib_pool; | ||
1220 | fib_p = fib_pool; | ||
1221 | while (hw_fib_p < &hw_fib_pool[num]) { | ||
1222 | if (*hw_fib_p) | ||
1223 | kfree(*hw_fib_p); | ||
1224 | if (*fib_p) | ||
1225 | kfree(*fib_p); | ||
1226 | ++fib_p; | ||
1227 | ++hw_fib_p; | ||
1228 | } | ||
1229 | if (hw_fib_pool) | ||
1230 | kfree(hw_fib_pool); | ||
1231 | if (fib_pool) | ||
1232 | kfree(fib_pool); | ||
950 | } | 1233 | } |
951 | spin_lock_irqsave(queues->queue[HostNormCmdQueue].lock, flags); | ||
952 | kfree(fib); | 1234 | kfree(fib); |
1235 | spin_lock_irqsave(dev->queues->queue[HostNormCmdQueue].lock, flags); | ||
953 | } | 1236 | } |
954 | /* | 1237 | /* |
955 | * There are no more AIF's | 1238 | * There are no more AIF's |
956 | */ | 1239 | */ |
957 | spin_unlock_irqrestore(queues->queue[HostNormCmdQueue].lock, flags); | 1240 | spin_unlock_irqrestore(dev->queues->queue[HostNormCmdQueue].lock, flags); |
958 | schedule(); | 1241 | schedule(); |
959 | 1242 | ||
960 | if(signal_pending(current)) | 1243 | if(signal_pending(current)) |
961 | break; | 1244 | break; |
962 | set_current_state(TASK_INTERRUPTIBLE); | 1245 | set_current_state(TASK_INTERRUPTIBLE); |
963 | } | 1246 | } |
964 | remove_wait_queue(&queues->queue[HostNormCmdQueue].cmdready, &wait); | 1247 | if (dev->queues) |
1248 | remove_wait_queue(&dev->queues->queue[HostNormCmdQueue].cmdready, &wait); | ||
965 | dev->aif_thread = 0; | 1249 | dev->aif_thread = 0; |
966 | complete_and_exit(&dev->aif_completion, 0); | 1250 | complete_and_exit(&dev->aif_completion, 0); |
1251 | return 0; | ||
967 | } | 1252 | } |
diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c index 4ff29d7f5825..de8490a92831 100644 --- a/drivers/scsi/aacraid/linit.c +++ b/drivers/scsi/aacraid/linit.c | |||
@@ -748,7 +748,8 @@ static int __devinit aac_probe_one(struct pci_dev *pdev, | |||
748 | unique_id++; | 748 | unique_id++; |
749 | } | 749 | } |
750 | 750 | ||
751 | if (pci_enable_device(pdev)) | 751 | error = pci_enable_device(pdev); |
752 | if (error) | ||
752 | goto out; | 753 | goto out; |
753 | 754 | ||
754 | if (pci_set_dma_mask(pdev, 0xFFFFFFFFULL) || | 755 | if (pci_set_dma_mask(pdev, 0xFFFFFFFFULL) || |
@@ -772,6 +773,7 @@ static int __devinit aac_probe_one(struct pci_dev *pdev, | |||
772 | shost->irq = pdev->irq; | 773 | shost->irq = pdev->irq; |
773 | shost->base = pci_resource_start(pdev, 0); | 774 | shost->base = pci_resource_start(pdev, 0); |
774 | shost->unique_id = unique_id; | 775 | shost->unique_id = unique_id; |
776 | shost->max_cmd_len = 16; | ||
775 | 777 | ||
776 | aac = (struct aac_dev *)shost->hostdata; | 778 | aac = (struct aac_dev *)shost->hostdata; |
777 | aac->scsi_host_ptr = shost; | 779 | aac->scsi_host_ptr = shost; |
@@ -799,7 +801,9 @@ static int __devinit aac_probe_one(struct pci_dev *pdev, | |||
799 | goto out_free_fibs; | 801 | goto out_free_fibs; |
800 | 802 | ||
801 | aac->maximum_num_channels = aac_drivers[index].channels; | 803 | aac->maximum_num_channels = aac_drivers[index].channels; |
802 | aac_get_adapter_info(aac); | 804 | error = aac_get_adapter_info(aac); |
805 | if (error < 0) | ||
806 | goto out_deinit; | ||
803 | 807 | ||
804 | /* | 808 | /* |
805 | * Lets override negotiations and drop the maximum SG limit to 34 | 809 | * Lets override negotiations and drop the maximum SG limit to 34 |
@@ -927,8 +931,8 @@ static int __init aac_init(void) | |||
927 | printk(KERN_INFO "Adaptec %s driver (%s)\n", | 931 | printk(KERN_INFO "Adaptec %s driver (%s)\n", |
928 | AAC_DRIVERNAME, aac_driver_version); | 932 | AAC_DRIVERNAME, aac_driver_version); |
929 | 933 | ||
930 | error = pci_module_init(&aac_pci_driver); | 934 | error = pci_register_driver(&aac_pci_driver); |
931 | if (error) | 935 | if (error < 0) |
932 | return error; | 936 | return error; |
933 | 937 | ||
934 | aac_cfg_major = register_chrdev( 0, "aac", &aac_cfg_fops); | 938 | aac_cfg_major = register_chrdev( 0, "aac", &aac_cfg_fops); |