6 files changed, 20 insertions, 7 deletions

diff --git a/drivers/sbus/char/Kconfig b/drivers/sbus/char/Kconfig
index 35a73168333f..400c65bfb8c7 100644
--- a/drivers/sbus/char/Kconfig
+++ b/drivers/sbus/char/Kconfig
@@ -15,6 +15,7 @@ config SUN_OPENPROMIO
 
 config SUN_MOSTEK_RTC
         tristate "Mostek real time clock support"
+        depends on SPARC32
         help
           The Mostek RTC chip is used on all known Sun computers except
           some JavaStations. For a JavaStation you need to say Y both here
diff --git a/drivers/sbus/char/bbc_envctrl.c b/drivers/sbus/char/bbc_envctrl.c
index e821a155b658..0bde26989a23 100644
--- a/drivers/sbus/char/bbc_envctrl.c
+++ b/drivers/sbus/char/bbc_envctrl.c
@@ -479,11 +479,12 @@ static int kenvctrld(void *__unused)
 
 static void attach_one_temp(struct linux_ebus_child *echild, int temp_idx)
 {
-        struct bbc_cpu_temperature *tp = kmalloc(sizeof(*tp), GFP_KERNEL);
+        struct bbc_cpu_temperature *tp;
 
+        tp = kzalloc(sizeof(*tp), GFP_KERNEL);
         if (!tp)
                 return;
-        memset(tp, 0, sizeof(*tp));
+
         tp->client = bbc_i2c_attach(echild);
         if (!tp->client) {
                 kfree(tp);
@@ -525,11 +526,12 @@ static void attach_one_temp(struct linux_ebus_child *echild, int temp_idx)
 
 static void attach_one_fan(struct linux_ebus_child *echild, int fan_idx)
 {
-        struct bbc_fan_control *fp = kmalloc(sizeof(*fp), GFP_KERNEL);
+        struct bbc_fan_control *fp;
 
+        fp = kzalloc(sizeof(*fp), GFP_KERNEL);
         if (!fp)
                 return;
-        memset(fp, 0, sizeof(*fp));
+
         fp->client = bbc_i2c_attach(echild);
         if (!fp->client) {
                 kfree(fp);
diff --git a/drivers/sbus/char/bbc_i2c.c b/drivers/sbus/char/bbc_i2c.c
index fbadd4d761f3..ac8ef2ce07fb 100644
--- a/drivers/sbus/char/bbc_i2c.c
+++ b/drivers/sbus/char/bbc_i2c.c
@@ -357,13 +357,13 @@ static void __init reset_one_i2c(struct bbc_i2c_bus *bp)
 
 static int __init attach_one_i2c(struct linux_ebus_device *edev, int index)
 {
-        struct bbc_i2c_bus *bp = kmalloc(sizeof(*bp), GFP_KERNEL);
+        struct bbc_i2c_bus *bp;
         struct linux_ebus_child *echild;
         int entry;
 
+        bp = kzalloc(sizeof(*bp), GFP_KERNEL);
         if (!bp)
                 return -ENOMEM;
-        memset(bp, 0, sizeof(*bp));
 
         bp->i2c_control_regs = ioremap(edev->resource[0].start, 0x2);
         if (!bp->i2c_control_regs)
diff --git a/drivers/sbus/char/jsflash.c b/drivers/sbus/char/jsflash.c
index 5157a2abc58d..4b7079fdc10c 100644
--- a/drivers/sbus/char/jsflash.c
+++ b/drivers/sbus/char/jsflash.c
@@ -185,7 +185,7 @@ static void jsfd_read(char *buf, unsigned long p, size_t togo) {
         }
 }
 
-static void jsfd_do_request(request_queue_t *q)
+static void jsfd_do_request(struct request_queue *q)
 {
         struct request *req;
 
diff --git a/drivers/sbus/char/vfc_dev.c b/drivers/sbus/char/vfc_dev.c
index 26b1d2a17ed2..9269f7fbd363 100644
--- a/drivers/sbus/char/vfc_dev.c
+++ b/drivers/sbus/char/vfc_dev.c
@@ -248,6 +248,7 @@ static int vfc_debug(struct vfc_dev *dev, int cmd, void __user *argp)
                                         buffer,inout.len);
 
                 if (copy_to_user(argp,&inout,sizeof(inout))) {
+                        vfc_unlock_device(dev);
                         kfree(buffer);
                         return -EFAULT;
                 }
diff --git a/drivers/sbus/sbus.c b/drivers/sbus/sbus.c
index 2553629ec15d..c37d7c2587ff 100644
--- a/drivers/sbus/sbus.c
+++ b/drivers/sbus/sbus.c
@@ -210,6 +210,10 @@ static void __init walk_children(struct device_node *dp, struct sbus_dev *parent
 
                         sdev->bus = sbus;
                         sdev->parent = parent;
+                        sdev->ofdev.dev.archdata.iommu =
+                                sbus->ofdev.dev.archdata.iommu;
+                        sdev->ofdev.dev.archdata.stc =
+                                sbus->ofdev.dev.archdata.stc;
 
                         fill_sbus_device(dp, sdev);
 
@@ -269,6 +273,11 @@ static void __init build_one_sbus(struct device_node *dp, int num_sbus)
 
                         sdev->bus = sbus;
                         sdev->parent = NULL;
+                        sdev->ofdev.dev.archdata.iommu =
+                                sbus->ofdev.dev.archdata.iommu;
+                        sdev->ofdev.dev.archdata.stc =
+                                sbus->ofdev.dev.archdata.stc;
+
                         fill_sbus_device(dev_dp, sdev);
 
                         walk_children(dev_dp, sdev, sbus);