diff options
Diffstat (limited to 'drivers/s390')
-rw-r--r-- | drivers/s390/net/ctcm_main.c | 2 | ||||
-rw-r--r-- | drivers/s390/net/ctcm_mpc.c | 13 |
2 files changed, 4 insertions, 11 deletions
diff --git a/drivers/s390/net/ctcm_main.c b/drivers/s390/net/ctcm_main.c index c189296763a4..426787efc492 100644 --- a/drivers/s390/net/ctcm_main.c +++ b/drivers/s390/net/ctcm_main.c | |||
@@ -672,7 +672,6 @@ static int ctcmpc_transmit_skb(struct channel *ch, struct sk_buff *skb) | |||
672 | int ccw_idx; | 672 | int ccw_idx; |
673 | unsigned long hi; | 673 | unsigned long hi; |
674 | unsigned long saveflags = 0; /* avoids compiler warning */ | 674 | unsigned long saveflags = 0; /* avoids compiler warning */ |
675 | __u16 block_len; | ||
676 | 675 | ||
677 | CTCM_PR_DEBUG("Enter %s: %s, cp=%i ch=0x%p id=%s state=%s\n", | 676 | CTCM_PR_DEBUG("Enter %s: %s, cp=%i ch=0x%p id=%s state=%s\n", |
678 | __func__, dev->name, smp_processor_id(), ch, | 677 | __func__, dev->name, smp_processor_id(), ch, |
@@ -719,7 +718,6 @@ static int ctcmpc_transmit_skb(struct channel *ch, struct sk_buff *skb) | |||
719 | */ | 718 | */ |
720 | atomic_inc(&skb->users); | 719 | atomic_inc(&skb->users); |
721 | 720 | ||
722 | block_len = skb->len + TH_HEADER_LENGTH + PDU_HEADER_LENGTH; | ||
723 | /* | 721 | /* |
724 | * IDAL support in CTCM is broken, so we have to | 722 | * IDAL support in CTCM is broken, so we have to |
725 | * care about skb's above 2G ourselves. | 723 | * care about skb's above 2G ourselves. |
diff --git a/drivers/s390/net/ctcm_mpc.c b/drivers/s390/net/ctcm_mpc.c index b64881f33f23..da4c747335e7 100644 --- a/drivers/s390/net/ctcm_mpc.c +++ b/drivers/s390/net/ctcm_mpc.c | |||
@@ -653,7 +653,6 @@ static void ctcmpc_send_sweep_resp(struct channel *rch) | |||
653 | struct net_device *dev = rch->netdev; | 653 | struct net_device *dev = rch->netdev; |
654 | struct ctcm_priv *priv = dev->ml_priv; | 654 | struct ctcm_priv *priv = dev->ml_priv; |
655 | struct mpc_group *grp = priv->mpcg; | 655 | struct mpc_group *grp = priv->mpcg; |
656 | int rc = 0; | ||
657 | struct th_sweep *header; | 656 | struct th_sweep *header; |
658 | struct sk_buff *sweep_skb; | 657 | struct sk_buff *sweep_skb; |
659 | struct channel *ch = priv->channel[CTCM_WRITE]; | 658 | struct channel *ch = priv->channel[CTCM_WRITE]; |
@@ -665,16 +664,14 @@ static void ctcmpc_send_sweep_resp(struct channel *rch) | |||
665 | CTCM_DBF_TEXT_(MPC_ERROR, CTC_DBF_ERROR, | 664 | CTCM_DBF_TEXT_(MPC_ERROR, CTC_DBF_ERROR, |
666 | "%s(%s): sweep_skb allocation ERROR\n", | 665 | "%s(%s): sweep_skb allocation ERROR\n", |
667 | CTCM_FUNTAIL, rch->id); | 666 | CTCM_FUNTAIL, rch->id); |
668 | rc = -ENOMEM; | 667 | goto done; |
669 | goto done; | ||
670 | } | 668 | } |
671 | 669 | ||
672 | header = kmalloc(sizeof(struct th_sweep), gfp_type()); | 670 | header = kmalloc(sizeof(struct th_sweep), gfp_type()); |
673 | 671 | ||
674 | if (!header) { | 672 | if (!header) { |
675 | dev_kfree_skb_any(sweep_skb); | 673 | dev_kfree_skb_any(sweep_skb); |
676 | rc = -ENOMEM; | 674 | goto done; |
677 | goto done; | ||
678 | } | 675 | } |
679 | 676 | ||
680 | header->th.th_seg = 0x00 ; | 677 | header->th.th_seg = 0x00 ; |
@@ -1370,8 +1367,7 @@ static void mpc_action_go_inop(fsm_instance *fi, int event, void *arg) | |||
1370 | struct net_device *dev = arg; | 1367 | struct net_device *dev = arg; |
1371 | struct ctcm_priv *priv; | 1368 | struct ctcm_priv *priv; |
1372 | struct mpc_group *grp; | 1369 | struct mpc_group *grp; |
1373 | int rc = 0; | 1370 | struct channel *wch; |
1374 | struct channel *wch, *rch; | ||
1375 | 1371 | ||
1376 | BUG_ON(dev == NULL); | 1372 | BUG_ON(dev == NULL); |
1377 | CTCM_PR_DEBUG("Enter %s: %s\n", __func__, dev->name); | 1373 | CTCM_PR_DEBUG("Enter %s: %s\n", __func__, dev->name); |
@@ -1396,7 +1392,6 @@ static void mpc_action_go_inop(fsm_instance *fi, int event, void *arg) | |||
1396 | fsm_deltimer(&priv->restart_timer); | 1392 | fsm_deltimer(&priv->restart_timer); |
1397 | 1393 | ||
1398 | wch = priv->channel[CTCM_WRITE]; | 1394 | wch = priv->channel[CTCM_WRITE]; |
1399 | rch = priv->channel[CTCM_READ]; | ||
1400 | 1395 | ||
1401 | switch (grp->saved_state) { | 1396 | switch (grp->saved_state) { |
1402 | case MPCG_STATE_RESET: | 1397 | case MPCG_STATE_RESET: |
@@ -1435,7 +1430,7 @@ static void mpc_action_go_inop(fsm_instance *fi, int event, void *arg) | |||
1435 | 1430 | ||
1436 | if (grp->send_qllc_disc == 1) { | 1431 | if (grp->send_qllc_disc == 1) { |
1437 | grp->send_qllc_disc = 0; | 1432 | grp->send_qllc_disc = 0; |
1438 | rc = mpc_send_qllc_discontact(dev); | 1433 | mpc_send_qllc_discontact(dev); |
1439 | } | 1434 | } |
1440 | 1435 | ||
1441 | /* DO NOT issue DEV_EVENT_STOP directly out of this code */ | 1436 | /* DO NOT issue DEV_EVENT_STOP directly out of this code */ |