10 files changed, 221 insertions, 168 deletions

diff --git a/drivers/s390/block/dasd.c b/drivers/s390/block/dasd.c
index 6527ff6f4706..d5f53980749b 100644
--- a/drivers/s390/block/dasd.c
+++ b/drivers/s390/block/dasd.c
@@ -7,7 +7,7 @@
  * Bugreports.to..: <Linux390@de.ibm.com>
  * (C) IBM Corporation, IBM Deutschland Entwicklung GmbH, 1999-2001
  *
- * $Revision: 1.164 $
+ * $Revision: 1.165 $
  */
 
 #include <linux/config.h>
@@ -1740,6 +1740,10 @@ dasd_exit(void)
         dasd_proc_exit();
 #endif
         dasd_ioctl_exit();
+        if (dasd_page_cache != NULL) {
+                kmem_cache_destroy(dasd_page_cache);
+                dasd_page_cache = NULL;
+        }
         dasd_gendisk_exit();
         dasd_devmap_exit();
         devfs_remove("dasd");
diff --git a/drivers/s390/block/dasd_fba.c b/drivers/s390/block/dasd_fba.c
index 7963ae343eef..28cb4613b7f5 100644
--- a/drivers/s390/block/dasd_fba.c
+++ b/drivers/s390/block/dasd_fba.c
@@ -4,7 +4,7 @@
  * Bugreports.to..: <Linux390@de.ibm.com>
  * (C) IBM Corporation, IBM Deutschland Entwicklung GmbH, 1999,2000
  *
- * $Revision: 1.39 $
+ * $Revision: 1.40 $
  */
 
 #include <linux/config.h>
@@ -354,6 +354,8 @@ dasd_fba_build_cp(struct dasd_device * device, struct request *req)
         }
         cqr->device = device;
         cqr->expires = 5 * 60 * HZ;     /* 5 minutes */
+        cqr->retries = 32;
+        cqr->buildclk = get_clock();
         cqr->status = DASD_CQR_FILLED;
         return cqr;
 }
diff --git a/drivers/s390/char/tape.h b/drivers/s390/char/tape.h
index d04e6c2c3cc1..01d865d93791 100644
--- a/drivers/s390/char/tape.h
+++ b/drivers/s390/char/tape.h
@@ -3,10 +3,11 @@
  *    tape device driver for 3480/3490E/3590 tapes.
  *
  *  S390 and zSeries version
- *    Copyright (C) 2001,2002 IBM Deutschland Entwicklung GmbH, IBM Corporation
+ *    Copyright (C) 2001,2005 IBM Deutschland Entwicklung GmbH, IBM Corporation
  *    Author(s): Carsten Otte <cotte@de.ibm.com>
  *               Tuan Ngo-Anh <ngoanh@de.ibm.com>
  *               Martin Schwidefsky <schwidefsky@de.ibm.com>
+ *               Stefan Bader <shbader@de.ibm.com>
  */
 
 #ifndef _TAPE_H
@@ -111,6 +112,7 @@ enum tape_request_status {
         TAPE_REQUEST_QUEUED,    /* request is queued to be processed */
         TAPE_REQUEST_IN_IO,     /* request is currently in IO */
         TAPE_REQUEST_DONE,      /* request is completed. */
+        TAPE_REQUEST_CANCEL,    /* request should be canceled. */
 };
 
 /* Tape CCW request */
@@ -237,6 +239,9 @@ struct tape_device {
         /* Block dev frontend data */
         struct tape_blk_data            blk_data;
 #endif
+
+        /* Function to start or stop the next request later. */
+        struct work_struct              tape_dnr;
 };
 
 /* Externals from tape_core.c */
diff --git a/drivers/s390/char/tape_core.c b/drivers/s390/char/tape_core.c
index 0597aa0e27ee..6c52e8307dc5 100644
--- a/drivers/s390/char/tape_core.c
+++ b/drivers/s390/char/tape_core.c
@@ -3,11 +3,12 @@
  *    basic function of the tape device driver
  *
  *  S390 and zSeries version
- *    Copyright (C) 2001,2002 IBM Deutschland Entwicklung GmbH, IBM Corporation
+ *    Copyright (C) 2001,2005 IBM Deutschland Entwicklung GmbH, IBM Corporation
  *    Author(s): Carsten Otte <cotte@de.ibm.com>
  *               Michael Holzheu <holzheu@de.ibm.com>
  *               Tuan Ngo-Anh <ngoanh@de.ibm.com>
  *               Martin Schwidefsky <schwidefsky@de.ibm.com>
+ *               Stefan Bader <shbader@de.ibm.com>
  */
 
 #include <linux/config.h>
@@ -28,7 +29,7 @@
 #define PRINTK_HEADER "TAPE_CORE: "
 
 static void __tape_do_irq (struct ccw_device *, unsigned long, struct irb *);
-static void __tape_remove_request(struct tape_device *, struct tape_request *);
+static void tape_delayed_next_request(void * data);
 
 /*
  * One list to contain all tape devices of all disciplines, so
@@ -257,7 +258,7 @@ tape_med_state_set(struct tape_device *device, enum tape_medium_state newstate)
  * Stop running ccw. Has to be called with the device lock held.
  */
 static inline int
-__tape_halt_io(struct tape_device *device, struct tape_request *request)
+__tape_cancel_io(struct tape_device *device, struct tape_request *request)
 {
         int retries;
         int rc;
@@ -270,20 +271,23 @@ __tape_halt_io(struct tape_device *device, struct tape_request *request)
         for (retries = 0; retries < 5; retries++) {
                 rc = ccw_device_clear(device->cdev, (long) request);
 
-                if (rc == 0) {                     /* Termination successful */
-                        request->rc     = -EIO;
-                        request->status = TAPE_REQUEST_DONE;
-                        return 0;
+                switch (rc) {
+                        case 0:
+                                request->status = TAPE_REQUEST_DONE;
+                                return 0;
+                        case -EBUSY:
+                                request->status = TAPE_REQUEST_CANCEL;
+                                schedule_work(&device->tape_dnr);
+                                return 0;
+                        case -ENODEV:
+                                DBF_EXCEPTION(2, "device gone, retry\n");
+                                break;
+                        case -EIO:
+                                DBF_EXCEPTION(2, "I/O error, retry\n");
+                                break;
+                        default:
+                                BUG();
                 }
-
-                if (rc == -ENODEV)
-                        DBF_EXCEPTION(2, "device gone, retry\n");
-                else if (rc == -EIO)
-                        DBF_EXCEPTION(2, "I/O error, retry\n");
-                else if (rc == -EBUSY)
-                        DBF_EXCEPTION(2, "device busy, retry late\n");
-                else
-                        BUG();
         }
 
         return rc;
@@ -473,6 +477,7 @@ tape_alloc_device(void)
         *device->modeset_byte = 0;
         device->first_minor = -1;
         atomic_set(&device->ref_count, 1);
+        INIT_WORK(&device->tape_dnr, tape_delayed_next_request, device);
 
         return device;
 }
@@ -708,54 +713,119 @@ tape_free_request (struct tape_request * request)
         kfree(request);
 }
 
+static inline int
+__tape_start_io(struct tape_device *device, struct tape_request *request)
+{
+        int rc;
+
+#ifdef CONFIG_S390_TAPE_BLOCK
+        if (request->op == TO_BLOCK)
+                device->discipline->check_locate(device, request);
+#endif
+        rc = ccw_device_start(
+                device->cdev,
+                request->cpaddr,
+                (unsigned long) request,
+                0x00,
+                request->options
+        );
+        if (rc == 0) {
+                request->status = TAPE_REQUEST_IN_IO;
+        } else if (rc == -EBUSY) {
+                /* The common I/O subsystem is currently busy. Retry later. */
+                request->status = TAPE_REQUEST_QUEUED;
+                schedule_work(&device->tape_dnr);
+                rc = 0;
+        } else {
+                /* Start failed. Remove request and indicate failure. */
+                DBF_EVENT(1, "tape: start request failed with RC = %i\n", rc);
+        }
+        return rc;
+}
+
 static inline void
-__tape_do_io_list(struct tape_device *device)
+__tape_start_next_request(struct tape_device *device)
 {
         struct list_head *l, *n;
         struct tape_request *request;
         int rc;
 
-        DBF_LH(6, "__tape_do_io_list(%p)\n", device);
+        DBF_LH(6, "__tape_start_next_request(%p)\n", device);
         /*
          * Try to start each request on request queue until one is
          * started successful.
          */
         list_for_each_safe(l, n, &device->req_queue) {
                 request = list_entry(l, struct tape_request, list);
-#ifdef CONFIG_S390_TAPE_BLOCK
-                if (request->op == TO_BLOCK)
-                        device->discipline->check_locate(device, request);
-#endif
-                rc = ccw_device_start(device->cdev, request->cpaddr,
-                                      (unsigned long) request, 0x00,
-                                      request->options);
-                if (rc == 0) {
-                        request->status = TAPE_REQUEST_IN_IO;
-                        break;
+
+                /*
+                 * Avoid race condition if bottom-half was triggered more than
+                 * once.
+                 */
+                if (request->status == TAPE_REQUEST_IN_IO)
+                        return;
+
+                /*
+                 * We wanted to cancel the request but the common I/O layer
+                 * was busy at that time. This can only happen if this
+                 * function is called by delayed_next_request.
+                 * Otherwise we start the next request on the queue.
+                 */
+                if (request->status == TAPE_REQUEST_CANCEL) {
+                        rc = __tape_cancel_io(device, request);
+                } else {
+                        rc = __tape_start_io(device, request);
                 }
-                /* Start failed. Remove request and indicate failure. */
-                DBF_EVENT(1, "tape: DOIO failed with er = %i\n", rc);
+                if (rc == 0)
+                        return;
 
-                /* Set ending status and do callback. */
+                /* Set ending status. */
                 request->rc = rc;
                 request->status = TAPE_REQUEST_DONE;
-                __tape_remove_request(device, request);
+
+                /* Remove from request queue. */
+                list_del(&request->list);
+
+                /* Do callback. */
+                if (request->callback != NULL)
+                        request->callback(request, request->callback_data);
         }
 }
 
 static void
-__tape_remove_request(struct tape_device *device, struct tape_request *request)
+tape_delayed_next_request(void *data)
 {
-        /* Remove from request queue. */
-        list_del(&request->list);
+        struct tape_device *    device;
 
-        /* Do callback. */
-        if (request->callback != NULL)
-                request->callback(request, request->callback_data);
+        device = (struct tape_device *) data;
+        DBF_LH(6, "tape_delayed_next_request(%p)\n", device);
+        spin_lock_irq(get_ccwdev_lock(device->cdev));
+        __tape_start_next_request(device);
+        spin_unlock_irq(get_ccwdev_lock(device->cdev));
+}
+
+static inline void
+__tape_end_request(
+        struct tape_device *    device,
+        struct tape_request *   request,
+        int                     rc)
+{
+        DBF_LH(6, "__tape_end_request(%p, %p, %i)\n", device, request, rc);
+        if (request) {
+                request->rc = rc;
+                request->status = TAPE_REQUEST_DONE;
+
+                /* Remove from request queue. */
+                list_del(&request->list);
+
+                /* Do callback. */
+                if (request->callback != NULL)
+                        request->callback(request, request->callback_data);
+        }
 
         /* Start next request. */
         if (!list_empty(&device->req_queue))
-                __tape_do_io_list(device);
+                __tape_start_next_request(device);
 }
 
 /*
@@ -812,7 +882,7 @@ tape_dump_sense_dbf(struct tape_device *device, struct tape_request *request,
  * the device lock held.
  */
 static inline int
-__tape_do_io(struct tape_device *device, struct tape_request *request)
+__tape_start_request(struct tape_device *device, struct tape_request *request)
 {
         int rc;
 
@@ -837,24 +907,16 @@ __tape_do_io(struct tape_device *device, struct tape_request *request)
 
         if (list_empty(&device->req_queue)) {
                 /* No other requests are on the queue. Start this one. */
-#ifdef CONFIG_S390_TAPE_BLOCK
-                if (request->op == TO_BLOCK)
-                        device->discipline->check_locate(device, request);
-#endif
-                rc = ccw_device_start(device->cdev, request->cpaddr,
-                                      (unsigned long) request, 0x00,
-                                      request->options);
-                if (rc) {
-                        DBF_EVENT(1, "tape: DOIO failed with rc = %i\n", rc);
+                rc = __tape_start_io(device, request);
+                if (rc)
                         return rc;
-                }
+
                 DBF_LH(5, "Request %p added for execution.\n", request);
                 list_add(&request->list, &device->req_queue);
-                request->status = TAPE_REQUEST_IN_IO;
         } else {
                 DBF_LH(5, "Request %p add to queue.\n", request);
-                list_add_tail(&request->list, &device->req_queue);
                 request->status = TAPE_REQUEST_QUEUED;
+                list_add_tail(&request->list, &device->req_queue);
         }
         return 0;
 }
@@ -872,7 +934,7 @@ tape_do_io_async(struct tape_device *device, struct tape_request *request)
 
         spin_lock_irq(get_ccwdev_lock(device->cdev));
         /* Add request to request queue and try to start it. */
-        rc = __tape_do_io(device, request);
+        rc = __tape_start_request(device, request);
         spin_unlock_irq(get_ccwdev_lock(device->cdev));
         return rc;
 }
@@ -901,7 +963,7 @@ tape_do_io(struct tape_device *device, struct tape_request *request)
         request->callback = __tape_wake_up;
         request->callback_data = &wq;
         /* Add request to request queue and try to start it. */
-        rc = __tape_do_io(device, request);
+        rc = __tape_start_request(device, request);
         spin_unlock_irq(get_ccwdev_lock(device->cdev));
         if (rc)
                 return rc;
@@ -935,7 +997,7 @@ tape_do_io_interruptible(struct tape_device *device,
         /* Setup callback */
         request->callback = __tape_wake_up_interruptible;
         request->callback_data = &wq;
-        rc = __tape_do_io(device, request);
+        rc = __tape_start_request(device, request);
         spin_unlock_irq(get_ccwdev_lock(device->cdev));
         if (rc)
                 return rc;
@@ -944,36 +1006,27 @@ tape_do_io_interruptible(struct tape_device *device,
         if (rc != -ERESTARTSYS)
                 /* Request finished normally. */
                 return request->rc;
+
         /* Interrupted by a signal. We have to stop the current request. */
         spin_lock_irq(get_ccwdev_lock(device->cdev));
-        rc = __tape_halt_io(device, request);
+        rc = __tape_cancel_io(device, request);
+        spin_unlock_irq(get_ccwdev_lock(device->cdev));
         if (rc == 0) {
+                /* Wait for the interrupt that acknowledges the halt. */
+                do {
+                        rc = wait_event_interruptible(
+                                wq,
+                                (request->callback == NULL)
+                        );
+                } while (rc != -ERESTARTSYS);
+
                 DBF_EVENT(3, "IO stopped on %08x\n", device->cdev_id);
                 rc = -ERESTARTSYS;
         }
-        spin_unlock_irq(get_ccwdev_lock(device->cdev));
         return rc;
 }
 
 /*
- * Handle requests that return an i/o error in the irb.
- */
-static inline void
-tape_handle_killed_request(
-        struct tape_device *device,
-        struct tape_request *request)
-{
-        if(request != NULL) {
-                /* Set ending status. FIXME: Should the request be retried? */
-                request->rc = -EIO;
-                request->status = TAPE_REQUEST_DONE;
-                __tape_remove_request(device, request);
-        } else {
-                __tape_do_io_list(device);
-        }
-}
-
-/*
  * Tape interrupt routine, called from the ccw_device layer
  */
 static void
@@ -981,7 +1034,6 @@ __tape_do_irq (struct ccw_device *cdev, unsigned long intparm, struct irb *irb)
 {
         struct tape_device *device;
         struct tape_request *request;
-        int final;
         int rc;
 
         device = (struct tape_device *) cdev->dev.driver_data;
@@ -996,12 +1048,13 @@ __tape_do_irq (struct ccw_device *cdev, unsigned long intparm, struct irb *irb)
 
         /* On special conditions irb is an error pointer */
         if (IS_ERR(irb)) {
+                /* FIXME: What to do with the request? */
                 switch (PTR_ERR(irb)) {
                         case -ETIMEDOUT:
                                 PRINT_WARN("(%s): Request timed out\n",
                                         cdev->dev.bus_id);
                         case -EIO:
-                                tape_handle_killed_request(device, request);
+                                __tape_end_request(device, request, -EIO);
                                 break;
                         default:
                                 PRINT_ERR("(%s): Unexpected i/o error %li\n",
@@ -1011,6 +1064,21 @@ __tape_do_irq (struct ccw_device *cdev, unsigned long intparm, struct irb *irb)
                 return;
         }
 
+        /*
+         * If the condition code is not zero and the start function bit is
+         * still set, this is an deferred error and the last start I/O did
+         * not succeed. Restart the request now.
+         */
+        if (irb->scsw.cc != 0 && (irb->scsw.fctl & SCSW_FCTL_START_FUNC)) {
+                PRINT_WARN("(%s): deferred cc=%i. restaring\n",
+                        cdev->dev.bus_id,
+                        irb->scsw.cc);
+                rc = __tape_start_io(device, request);
+                if (rc)
+                        __tape_end_request(device, request, rc);
+                return;
+        }
+
         /* May be an unsolicited irq */
         if(request != NULL)
                 request->rescnt = irb->scsw.count;
@@ -1042,7 +1110,7 @@ __tape_do_irq (struct ccw_device *cdev, unsigned long intparm, struct irb *irb)
          * To detect these request the state will be set to TAPE_REQUEST_DONE.
          */
         if(request != NULL && request->status == TAPE_REQUEST_DONE) {
-                __tape_remove_request(device, request);
+                __tape_end_request(device, request, -EIO);
                 return;
         }
 
@@ -1054,51 +1122,34 @@ __tape_do_irq (struct ccw_device *cdev, unsigned long intparm, struct irb *irb)
          * rc == TAPE_IO_RETRY: request finished but needs another go.
          * rc == TAPE_IO_STOP: request needs to get terminated.
          */
-        final = 0;
         switch (rc) {
-        case TAPE_IO_SUCCESS:
-                /* Upon normal completion the device _is_ online */
-                device->tape_generic_status |= GMT_ONLINE(~0);
-                final = 1;
-                break;
-        case TAPE_IO_PENDING:
-                break;
-        case TAPE_IO_RETRY:
-#ifdef CONFIG_S390_TAPE_BLOCK
-                if (request->op == TO_BLOCK)
-                        device->discipline->check_locate(device, request);
-#endif
-                rc = ccw_device_start(cdev, request->cpaddr,
-                                      (unsigned long) request, 0x00,
-                                      request->options);
-                if (rc) {
-                        DBF_EVENT(1, "tape: DOIO failed with er = %i\n", rc);
-                        final = 1;
-                }
-                break;
-        case TAPE_IO_STOP:
-                __tape_halt_io(device, request);
-                break;
-        default:
-                if (rc > 0) {
-                        DBF_EVENT(6, "xunknownrc\n");
-                        PRINT_ERR("Invalid return code from discipline "
-                                  "interrupt function.\n");
-                        rc = -EIO;
-                }
-                final = 1;
-                break;
-        }
-        if (final) {
-                /* May be an unsolicited irq */
-                if(request != NULL) {
-                        /* Set ending status. */
-                        request->rc = rc;
-                        request->status = TAPE_REQUEST_DONE;
-                        __tape_remove_request(device, request);
-                } else {
-                        __tape_do_io_list(device);
-                }
+                case TAPE_IO_SUCCESS:
+                        /* Upon normal completion the device _is_ online */
+                        device->tape_generic_status |= GMT_ONLINE(~0);
+                        __tape_end_request(device, request, rc);
+                        break;
+                case TAPE_IO_PENDING:
+                        break;
+                case TAPE_IO_RETRY:
+                        rc = __tape_start_io(device, request);
+                        if (rc)
+                                __tape_end_request(device, request, rc);
+                        break;
+                case TAPE_IO_STOP:
+                        rc = __tape_cancel_io(device, request);
+                        if (rc)
+                                __tape_end_request(device, request, rc);
+                        break;
+                default:
+                        if (rc > 0) {
+                                DBF_EVENT(6, "xunknownrc\n");
+                                PRINT_ERR("Invalid return code from discipline "
+                                        "interrupt function.\n");
+                                __tape_end_request(device, request, -EIO);
+                        } else {
+                                __tape_end_request(device, request, rc);
+                        }
+                        break;
         }
 }
 
@@ -1191,7 +1242,7 @@ tape_init (void)
 #ifdef DBF_LIKE_HELL
         debug_set_level(TAPE_DBF_AREA, 6);
 #endif
-        DBF_EVENT(3, "tape init: ($Revision: 1.51 $)\n");
+        DBF_EVENT(3, "tape init: ($Revision: 1.54 $)\n");
         tape_proc_init();
         tapechar_init ();
         tapeblock_init ();
@@ -1216,7 +1267,7 @@ tape_exit(void)
 MODULE_AUTHOR("(C) 2001 IBM Deutschland Entwicklung GmbH by Carsten Otte and "
               "Michael Holzheu (cotte@de.ibm.com,holzheu@de.ibm.com)");
 MODULE_DESCRIPTION("Linux on zSeries channel attached "
-                   "tape device driver ($Revision: 1.51 $)");
+                   "tape device driver ($Revision: 1.54 $)");
 MODULE_LICENSE("GPL");
 
 module_init(tape_init);
diff --git a/drivers/s390/char/vmcp.c b/drivers/s390/char/vmcp.c
index 7f11a608a633..8990d8076e7d 100644
--- a/drivers/s390/char/vmcp.c
+++ b/drivers/s390/char/vmcp.c
@@ -115,9 +115,9 @@ vmcp_write(struct file *file, const char __user * buff, size_t count,
                 return -ENOMEM;
         }
         debug_text_event(vmcp_debug, 1, cmd);
-        session->resp_size = cpcmd(cmd, session->response,
-                                   session->bufsize,
-                                   &session->resp_code);
+        session->resp_size = __cpcmd(cmd, session->response,
+                                     session->bufsize,
+                                     &session->resp_code);
         up(&session->mutex);
         kfree(cmd);
         *ppos = 0;              /* reset the file pointer after a command */
diff --git a/drivers/s390/char/vmwatchdog.c b/drivers/s390/char/vmwatchdog.c
index 22cf4fec8da9..5473c23fcb52 100644
--- a/drivers/s390/char/vmwatchdog.c
+++ b/drivers/s390/char/vmwatchdog.c
@@ -23,11 +23,7 @@
 static char vmwdt_cmd[MAX_CMDLEN] = "IPL";
 static int vmwdt_conceal;
 
-#ifdef CONFIG_WATCHDOG_NOWAYOUT
-static int vmwdt_nowayout = 1;
-#else
-static int vmwdt_nowayout = 0;
-#endif
+static int vmwdt_nowayout = WATCHDOG_NOWAYOUT;
 
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Arnd Bergmann <arndb@de.ibm.com>");
diff --git a/drivers/s390/cio/chsc.c b/drivers/s390/cio/chsc.c
index b86f94ecd874..fa3c23b80e3a 100644
--- a/drivers/s390/cio/chsc.c
+++ b/drivers/s390/cio/chsc.c
@@ -1,7 +1,7 @@
 /*
  *  drivers/s390/cio/chsc.c
  *   S/390 common I/O routines -- channel subsystem call
- *   $Revision: 1.119 $
+ *   $Revision: 1.120 $
  *
  *    Copyright (C) 1999-2002 IBM Deutschland Entwicklung GmbH,
  *                            IBM Corporation
@@ -412,11 +412,7 @@ s390_process_res_acc (u8 chpid, __u16 fla, u32 fla_mask)
                 if (chp_mask == 0) {
 
                         spin_unlock_irq(&sch->lock);
-
-                        if (fla_mask != 0)
-                                break;
-                        else
-                                continue;
+                        continue;
                 }
                 old_lpm = sch->lpm;
                 sch->lpm = ((sch->schib.pmcw.pim &
@@ -430,7 +426,7 @@ s390_process_res_acc (u8 chpid, __u16 fla, u32 fla_mask)
 
                 spin_unlock_irq(&sch->lock);
                 put_device(&sch->dev);
-                if (fla_mask != 0)
+                if (fla_mask == 0xffff)
                         break;
         }
         return rc;
diff --git a/drivers/s390/cio/device_status.c b/drivers/s390/cio/device_status.c
index 4ab2e0d95009..12a24d4331a2 100644
--- a/drivers/s390/cio/device_status.c
+++ b/drivers/s390/cio/device_status.c
@@ -39,15 +39,14 @@ ccw_device_msg_control_check(struct ccw_device *cdev, struct irb *irb)
                       " ... device %04X on subchannel %04X, dev_stat "
                       ": %02X sch_stat : %02X\n",
                       cdev->private->devno, cdev->private->irq,
-                      cdev->private->irb.scsw.dstat,
-                      cdev->private->irb.scsw.cstat);
+                      irb->scsw.dstat, irb->scsw.cstat);
 
         if (irb->scsw.cc != 3) {
                 char dbf_text[15];
 
                 sprintf(dbf_text, "chk%x", cdev->private->irq);
                 CIO_TRACE_EVENT(0, dbf_text);
-                CIO_HEX_EVENT(0, &cdev->private->irb, sizeof (struct irb));
+                CIO_HEX_EVENT(0, irb, sizeof (struct irb));
         }
 }
 
diff --git a/drivers/s390/cio/qdio.c b/drivers/s390/cio/qdio.c
index 82194c4eadfb..d36258d6665f 100644
--- a/drivers/s390/cio/qdio.c
+++ b/drivers/s390/cio/qdio.c
@@ -432,7 +432,7 @@ tiqdio_clear_global_summary(void)
 
 /************************* OUTBOUND ROUTINES *******************************/
 
-inline static int
+static inline int
 qdio_get_outbound_buffer_frontier(struct qdio_q *q)
 {
         int f,f_mod_no;
@@ -510,7 +510,7 @@ out:
 }
 
 /* all buffers are processed */
-inline static int
+static inline int
 qdio_is_outbound_q_done(struct qdio_q *q)
 {
         int no_used;
@@ -532,7 +532,7 @@ qdio_is_outbound_q_done(struct qdio_q *q)
         return (no_used==0);
 }
 
-inline static int
+static inline int
 qdio_has_outbound_q_moved(struct qdio_q *q)
 {
         int i;
@@ -552,7 +552,7 @@ qdio_has_outbound_q_moved(struct qdio_q *q)
         }
 }
 
-inline static void
+static inline void
 qdio_kick_outbound_q(struct qdio_q *q)
 {
         int result;
@@ -641,7 +641,7 @@ qdio_kick_outbound_q(struct qdio_q *q)
                 }
 }
 
-inline static void
+static inline void
 qdio_kick_outbound_handler(struct qdio_q *q)
 {
         int start, end, real_end, count;
@@ -740,7 +740,7 @@ qdio_outbound_processing(struct qdio_q *q)
 /************************* INBOUND ROUTINES *******************************/
 
 
-inline static int
+static inline int
 qdio_get_inbound_buffer_frontier(struct qdio_q *q)
 {
         int f,f_mod_no;
@@ -865,7 +865,7 @@ out:
         return q->first_to_check;
 }
 
-inline static int
+static inline int
 qdio_has_inbound_q_moved(struct qdio_q *q)
 {
         int i;
@@ -898,7 +898,7 @@ qdio_has_inbound_q_moved(struct qdio_q *q)
 }
 
 /* means, no more buffers to be filled */
-inline static int
+static inline int
 tiqdio_is_inbound_q_done(struct qdio_q *q)
 {
         int no_used;
@@ -951,7 +951,7 @@ tiqdio_is_inbound_q_done(struct qdio_q *q)
         return 0;
 }
 
-inline static int
+static inline int
 qdio_is_inbound_q_done(struct qdio_q *q)
 {
         int no_used;
@@ -1010,7 +1010,7 @@ qdio_is_inbound_q_done(struct qdio_q *q)
         }
 }
 
-inline static void
+static inline void
 qdio_kick_inbound_handler(struct qdio_q *q)
 {
         int count, start, end, real_end, i;
diff --git a/drivers/s390/net/qeth.h b/drivers/s390/net/qeth.h
index 008e0a5d2eb3..3a0285669adf 100644
--- a/drivers/s390/net/qeth.h
+++ b/drivers/s390/net/qeth.h
@@ -824,7 +824,7 @@ extern struct list_head qeth_notify_list;
 
 #define QETH_CARD_IFNAME(card) (((card)->dev)? (card)->dev->name : "")
 
-inline static __u8
+static inline __u8
 qeth_get_ipa_adp_type(enum qeth_link_types link_type)
 {
         switch (link_type) {
@@ -835,7 +835,7 @@ qeth_get_ipa_adp_type(enum qeth_link_types link_type)
         }
 }
 
-inline static int
+static inline int
 qeth_realloc_headroom(struct qeth_card *card, struct sk_buff **skb, int size)
 {
         struct sk_buff *new_skb = NULL;
@@ -852,6 +852,7 @@ qeth_realloc_headroom(struct qeth_card *card, struct sk_buff **skb, int size)
         }
         return 0;
 }
+
 static inline struct sk_buff *
 qeth_pskb_unshare(struct sk_buff *skb, int pri)
 {
@@ -863,8 +864,7 @@ qeth_pskb_unshare(struct sk_buff *skb, int pri)
         return nskb;
 }
 
-
-inline static void *
+static inline void *
 qeth_push_skb(struct qeth_card *card, struct sk_buff **skb, int size)
 {
         void *hdr;
@@ -887,7 +887,7 @@ qeth_push_skb(struct qeth_card *card, struct sk_buff **skb, int size)
 }
 
 
-inline static int
+static inline int
 qeth_get_hlen(__u8 link_type)
 {
 #ifdef CONFIG_QETH_IPV6
@@ -911,7 +911,7 @@ qeth_get_hlen(__u8 link_type)
 #endif /* CONFIG_QETH_IPV6 */
 }
 
-inline static unsigned short
+static inline unsigned short
 qeth_get_netdev_flags(struct qeth_card *card)
 {
         if (card->options.layer2)
@@ -929,7 +929,7 @@ qeth_get_netdev_flags(struct qeth_card *card)
         }
 }
 
-inline static int
+static inline int
 qeth_get_initial_mtu_for_card(struct qeth_card * card)
 {
         switch (card->info.type) {
@@ -950,7 +950,7 @@ qeth_get_initial_mtu_for_card(struct qeth_card * card)
         }
 }
 
-inline static int
+static inline int
 qeth_get_max_mtu_for_card(int cardtype)
 {
         switch (cardtype) {
@@ -965,7 +965,7 @@ qeth_get_max_mtu_for_card(int cardtype)
         }
 }
 
-inline static int
+static inline int
 qeth_get_mtu_out_of_mpc(int cardtype)
 {
         switch (cardtype) {
@@ -976,7 +976,7 @@ qeth_get_mtu_out_of_mpc(int cardtype)
         }
 }
 
-inline static int
+static inline int
 qeth_get_mtu_outof_framesize(int framesize)
 {
         switch (framesize) {
@@ -993,7 +993,7 @@ qeth_get_mtu_outof_framesize(int framesize)
         }
 }
 
-inline static int
+static inline int
 qeth_mtu_is_valid(struct qeth_card * card, int mtu)
 {
         switch (card->info.type) {
@@ -1008,7 +1008,7 @@ qeth_mtu_is_valid(struct qeth_card * card, int mtu)
         }
 }
 
-inline static int
+static inline int
 qeth_get_arphdr_type(int cardtype, int linktype)
 {
         switch (cardtype) {
@@ -1027,7 +1027,7 @@ qeth_get_arphdr_type(int cardtype, int linktype)
 }
 
 #ifdef CONFIG_QETH_PERF_STATS
-inline static int
+static inline int
 qeth_get_micros(void)
 {
         return (int) (get_clock() >> 12);