diff options
Diffstat (limited to 'drivers/rtc')
-rw-r--r-- | drivers/rtc/Kconfig | 12 | ||||
-rw-r--r-- | drivers/rtc/Makefile | 1 | ||||
-rw-r--r-- | drivers/rtc/class.c | 13 | ||||
-rw-r--r-- | drivers/rtc/interface.c | 574 | ||||
-rw-r--r-- | drivers/rtc/rtc-dev.c | 104 | ||||
-rw-r--r-- | drivers/rtc/rtc-ds1305.c | 2 | ||||
-rw-r--r-- | drivers/rtc/rtc-ds1307.c | 12 | ||||
-rw-r--r-- | drivers/rtc/rtc-ds1374.c | 2 | ||||
-rw-r--r-- | drivers/rtc/rtc-ds3232.c | 2 | ||||
-rw-r--r-- | drivers/rtc/rtc-lib.c | 28 | ||||
-rw-r--r-- | drivers/rtc/rtc-mrst.c | 582 | ||||
-rw-r--r-- | drivers/rtc/rtc-rx8025.c | 2 | ||||
-rw-r--r-- | drivers/rtc/rtc-sa1100.c | 161 |
13 files changed, 1122 insertions, 373 deletions
diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig index 2883428d5ac8..4941cade319f 100644 --- a/drivers/rtc/Kconfig +++ b/drivers/rtc/Kconfig | |||
@@ -463,6 +463,18 @@ config RTC_DRV_CMOS | |||
463 | This driver can also be built as a module. If so, the module | 463 | This driver can also be built as a module. If so, the module |
464 | will be called rtc-cmos. | 464 | will be called rtc-cmos. |
465 | 465 | ||
466 | config RTC_DRV_VRTC | ||
467 | tristate "Virtual RTC for Moorestown platforms" | ||
468 | depends on X86_MRST | ||
469 | default y if X86_MRST | ||
470 | |||
471 | help | ||
472 | Say "yes" here to get direct support for the real time clock | ||
473 | found on Moorestown platforms. The VRTC is a emulated RTC that | ||
474 | derives its clock source from a real RTC in the PMIC. The MC146818 | ||
475 | style programming interface is mostly conserved, but any | ||
476 | updates are done via IPC calls to the system controller FW. | ||
477 | |||
466 | config RTC_DRV_DS1216 | 478 | config RTC_DRV_DS1216 |
467 | tristate "Dallas DS1216" | 479 | tristate "Dallas DS1216" |
468 | depends on SNI_RM | 480 | depends on SNI_RM |
diff --git a/drivers/rtc/Makefile b/drivers/rtc/Makefile index 4c2832df4697..2afdaf3ff986 100644 --- a/drivers/rtc/Makefile +++ b/drivers/rtc/Makefile | |||
@@ -30,6 +30,7 @@ obj-$(CONFIG_RTC_DRV_CMOS) += rtc-cmos.o | |||
30 | obj-$(CONFIG_RTC_DRV_COH901331) += rtc-coh901331.o | 30 | obj-$(CONFIG_RTC_DRV_COH901331) += rtc-coh901331.o |
31 | obj-$(CONFIG_RTC_DRV_DAVINCI) += rtc-davinci.o | 31 | obj-$(CONFIG_RTC_DRV_DAVINCI) += rtc-davinci.o |
32 | obj-$(CONFIG_RTC_DRV_DM355EVM) += rtc-dm355evm.o | 32 | obj-$(CONFIG_RTC_DRV_DM355EVM) += rtc-dm355evm.o |
33 | obj-$(CONFIG_RTC_DRV_VRTC) += rtc-mrst.o | ||
33 | obj-$(CONFIG_RTC_DRV_DS1216) += rtc-ds1216.o | 34 | obj-$(CONFIG_RTC_DRV_DS1216) += rtc-ds1216.o |
34 | obj-$(CONFIG_RTC_DRV_DS1286) += rtc-ds1286.o | 35 | obj-$(CONFIG_RTC_DRV_DS1286) += rtc-ds1286.o |
35 | obj-$(CONFIG_RTC_DRV_DS1302) += rtc-ds1302.o | 36 | obj-$(CONFIG_RTC_DRV_DS1302) += rtc-ds1302.o |
diff --git a/drivers/rtc/class.c b/drivers/rtc/class.c index e6539cbabb35..9583cbcc6b79 100644 --- a/drivers/rtc/class.c +++ b/drivers/rtc/class.c | |||
@@ -16,6 +16,7 @@ | |||
16 | #include <linux/kdev_t.h> | 16 | #include <linux/kdev_t.h> |
17 | #include <linux/idr.h> | 17 | #include <linux/idr.h> |
18 | #include <linux/slab.h> | 18 | #include <linux/slab.h> |
19 | #include <linux/workqueue.h> | ||
19 | 20 | ||
20 | #include "rtc-core.h" | 21 | #include "rtc-core.h" |
21 | 22 | ||
@@ -152,6 +153,18 @@ struct rtc_device *rtc_device_register(const char *name, struct device *dev, | |||
152 | spin_lock_init(&rtc->irq_task_lock); | 153 | spin_lock_init(&rtc->irq_task_lock); |
153 | init_waitqueue_head(&rtc->irq_queue); | 154 | init_waitqueue_head(&rtc->irq_queue); |
154 | 155 | ||
156 | /* Init timerqueue */ | ||
157 | timerqueue_init_head(&rtc->timerqueue); | ||
158 | INIT_WORK(&rtc->irqwork, rtc_timer_do_work); | ||
159 | /* Init aie timer */ | ||
160 | rtc_timer_init(&rtc->aie_timer, rtc_aie_update_irq, (void *)rtc); | ||
161 | /* Init uie timer */ | ||
162 | rtc_timer_init(&rtc->uie_rtctimer, rtc_uie_update_irq, (void *)rtc); | ||
163 | /* Init pie timer */ | ||
164 | hrtimer_init(&rtc->pie_timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL); | ||
165 | rtc->pie_timer.function = rtc_pie_update_irq; | ||
166 | rtc->pie_enabled = 0; | ||
167 | |||
155 | strlcpy(rtc->name, name, RTC_DEVICE_NAME_SIZE); | 168 | strlcpy(rtc->name, name, RTC_DEVICE_NAME_SIZE); |
156 | dev_set_name(&rtc->dev, "rtc%d", id); | 169 | dev_set_name(&rtc->dev, "rtc%d", id); |
157 | 170 | ||
diff --git a/drivers/rtc/interface.c b/drivers/rtc/interface.c index a0c816238aa9..90384b9f6b2c 100644 --- a/drivers/rtc/interface.c +++ b/drivers/rtc/interface.c | |||
@@ -14,15 +14,11 @@ | |||
14 | #include <linux/rtc.h> | 14 | #include <linux/rtc.h> |
15 | #include <linux/sched.h> | 15 | #include <linux/sched.h> |
16 | #include <linux/log2.h> | 16 | #include <linux/log2.h> |
17 | #include <linux/workqueue.h> | ||
17 | 18 | ||
18 | int rtc_read_time(struct rtc_device *rtc, struct rtc_time *tm) | 19 | static int __rtc_read_time(struct rtc_device *rtc, struct rtc_time *tm) |
19 | { | 20 | { |
20 | int err; | 21 | int err; |
21 | |||
22 | err = mutex_lock_interruptible(&rtc->ops_lock); | ||
23 | if (err) | ||
24 | return err; | ||
25 | |||
26 | if (!rtc->ops) | 22 | if (!rtc->ops) |
27 | err = -ENODEV; | 23 | err = -ENODEV; |
28 | else if (!rtc->ops->read_time) | 24 | else if (!rtc->ops->read_time) |
@@ -31,7 +27,18 @@ int rtc_read_time(struct rtc_device *rtc, struct rtc_time *tm) | |||
31 | memset(tm, 0, sizeof(struct rtc_time)); | 27 | memset(tm, 0, sizeof(struct rtc_time)); |
32 | err = rtc->ops->read_time(rtc->dev.parent, tm); | 28 | err = rtc->ops->read_time(rtc->dev.parent, tm); |
33 | } | 29 | } |
30 | return err; | ||
31 | } | ||
32 | |||
33 | int rtc_read_time(struct rtc_device *rtc, struct rtc_time *tm) | ||
34 | { | ||
35 | int err; | ||
34 | 36 | ||
37 | err = mutex_lock_interruptible(&rtc->ops_lock); | ||
38 | if (err) | ||
39 | return err; | ||
40 | |||
41 | err = __rtc_read_time(rtc, tm); | ||
35 | mutex_unlock(&rtc->ops_lock); | 42 | mutex_unlock(&rtc->ops_lock); |
36 | return err; | 43 | return err; |
37 | } | 44 | } |
@@ -106,188 +113,54 @@ int rtc_set_mmss(struct rtc_device *rtc, unsigned long secs) | |||
106 | } | 113 | } |
107 | EXPORT_SYMBOL_GPL(rtc_set_mmss); | 114 | EXPORT_SYMBOL_GPL(rtc_set_mmss); |
108 | 115 | ||
109 | static int rtc_read_alarm_internal(struct rtc_device *rtc, struct rtc_wkalrm *alarm) | 116 | int rtc_read_alarm(struct rtc_device *rtc, struct rtc_wkalrm *alarm) |
110 | { | 117 | { |
111 | int err; | 118 | int err; |
112 | 119 | ||
113 | err = mutex_lock_interruptible(&rtc->ops_lock); | 120 | err = mutex_lock_interruptible(&rtc->ops_lock); |
114 | if (err) | 121 | if (err) |
115 | return err; | 122 | return err; |
116 | 123 | alarm->enabled = rtc->aie_timer.enabled; | |
117 | if (rtc->ops == NULL) | 124 | if (alarm->enabled) |
118 | err = -ENODEV; | 125 | alarm->time = rtc_ktime_to_tm(rtc->aie_timer.node.expires); |
119 | else if (!rtc->ops->read_alarm) | ||
120 | err = -EINVAL; | ||
121 | else { | ||
122 | memset(alarm, 0, sizeof(struct rtc_wkalrm)); | ||
123 | err = rtc->ops->read_alarm(rtc->dev.parent, alarm); | ||
124 | } | ||
125 | |||
126 | mutex_unlock(&rtc->ops_lock); | 126 | mutex_unlock(&rtc->ops_lock); |
127 | return err; | 127 | |
128 | return 0; | ||
128 | } | 129 | } |
130 | EXPORT_SYMBOL_GPL(rtc_read_alarm); | ||
129 | 131 | ||
130 | int rtc_read_alarm(struct rtc_device *rtc, struct rtc_wkalrm *alarm) | 132 | int __rtc_set_alarm(struct rtc_device *rtc, struct rtc_wkalrm *alarm) |
131 | { | 133 | { |
134 | struct rtc_time tm; | ||
135 | long now, scheduled; | ||
132 | int err; | 136 | int err; |
133 | struct rtc_time before, now; | ||
134 | int first_time = 1; | ||
135 | unsigned long t_now, t_alm; | ||
136 | enum { none, day, month, year } missing = none; | ||
137 | unsigned days; | ||
138 | |||
139 | /* The lower level RTC driver may return -1 in some fields, | ||
140 | * creating invalid alarm->time values, for reasons like: | ||
141 | * | ||
142 | * - The hardware may not be capable of filling them in; | ||
143 | * many alarms match only on time-of-day fields, not | ||
144 | * day/month/year calendar data. | ||
145 | * | ||
146 | * - Some hardware uses illegal values as "wildcard" match | ||
147 | * values, which non-Linux firmware (like a BIOS) may try | ||
148 | * to set up as e.g. "alarm 15 minutes after each hour". | ||
149 | * Linux uses only oneshot alarms. | ||
150 | * | ||
151 | * When we see that here, we deal with it by using values from | ||
152 | * a current RTC timestamp for any missing (-1) values. The | ||
153 | * RTC driver prevents "periodic alarm" modes. | ||
154 | * | ||
155 | * But this can be racey, because some fields of the RTC timestamp | ||
156 | * may have wrapped in the interval since we read the RTC alarm, | ||
157 | * which would lead to us inserting inconsistent values in place | ||
158 | * of the -1 fields. | ||
159 | * | ||
160 | * Reading the alarm and timestamp in the reverse sequence | ||
161 | * would have the same race condition, and not solve the issue. | ||
162 | * | ||
163 | * So, we must first read the RTC timestamp, | ||
164 | * then read the RTC alarm value, | ||
165 | * and then read a second RTC timestamp. | ||
166 | * | ||
167 | * If any fields of the second timestamp have changed | ||
168 | * when compared with the first timestamp, then we know | ||
169 | * our timestamp may be inconsistent with that used by | ||
170 | * the low-level rtc_read_alarm_internal() function. | ||
171 | * | ||
172 | * So, when the two timestamps disagree, we just loop and do | ||
173 | * the process again to get a fully consistent set of values. | ||
174 | * | ||
175 | * This could all instead be done in the lower level driver, | ||
176 | * but since more than one lower level RTC implementation needs it, | ||
177 | * then it's probably best best to do it here instead of there.. | ||
178 | */ | ||
179 | 137 | ||
180 | /* Get the "before" timestamp */ | 138 | err = rtc_valid_tm(&alarm->time); |
181 | err = rtc_read_time(rtc, &before); | 139 | if (err) |
182 | if (err < 0) | ||
183 | return err; | 140 | return err; |
184 | do { | 141 | rtc_tm_to_time(&alarm->time, &scheduled); |
185 | if (!first_time) | ||
186 | memcpy(&before, &now, sizeof(struct rtc_time)); | ||
187 | first_time = 0; | ||
188 | |||
189 | /* get the RTC alarm values, which may be incomplete */ | ||
190 | err = rtc_read_alarm_internal(rtc, alarm); | ||
191 | if (err) | ||
192 | return err; | ||
193 | if (!alarm->enabled) | ||
194 | return 0; | ||
195 | |||
196 | /* full-function RTCs won't have such missing fields */ | ||
197 | if (rtc_valid_tm(&alarm->time) == 0) | ||
198 | return 0; | ||
199 | |||
200 | /* get the "after" timestamp, to detect wrapped fields */ | ||
201 | err = rtc_read_time(rtc, &now); | ||
202 | if (err < 0) | ||
203 | return err; | ||
204 | |||
205 | /* note that tm_sec is a "don't care" value here: */ | ||
206 | } while ( before.tm_min != now.tm_min | ||
207 | || before.tm_hour != now.tm_hour | ||
208 | || before.tm_mon != now.tm_mon | ||
209 | || before.tm_year != now.tm_year); | ||
210 | |||
211 | /* Fill in the missing alarm fields using the timestamp; we | ||
212 | * know there's at least one since alarm->time is invalid. | ||
213 | */ | ||
214 | if (alarm->time.tm_sec == -1) | ||
215 | alarm->time.tm_sec = now.tm_sec; | ||
216 | if (alarm->time.tm_min == -1) | ||
217 | alarm->time.tm_min = now.tm_min; | ||
218 | if (alarm->time.tm_hour == -1) | ||
219 | alarm->time.tm_hour = now.tm_hour; | ||
220 | |||
221 | /* For simplicity, only support date rollover for now */ | ||
222 | if (alarm->time.tm_mday == -1) { | ||
223 | alarm->time.tm_mday = now.tm_mday; | ||
224 | missing = day; | ||
225 | } | ||
226 | if (alarm->time.tm_mon == -1) { | ||
227 | alarm->time.tm_mon = now.tm_mon; | ||
228 | if (missing == none) | ||
229 | missing = month; | ||
230 | } | ||
231 | if (alarm->time.tm_year == -1) { | ||
232 | alarm->time.tm_year = now.tm_year; | ||
233 | if (missing == none) | ||
234 | missing = year; | ||
235 | } | ||
236 | |||
237 | /* with luck, no rollover is needed */ | ||
238 | rtc_tm_to_time(&now, &t_now); | ||
239 | rtc_tm_to_time(&alarm->time, &t_alm); | ||
240 | if (t_now < t_alm) | ||
241 | goto done; | ||
242 | |||
243 | switch (missing) { | ||
244 | 142 | ||
245 | /* 24 hour rollover ... if it's now 10am Monday, an alarm that | 143 | /* Make sure we're not setting alarms in the past */ |
246 | * that will trigger at 5am will do so at 5am Tuesday, which | 144 | err = __rtc_read_time(rtc, &tm); |
247 | * could also be in the next month or year. This is a common | 145 | rtc_tm_to_time(&tm, &now); |
248 | * case, especially for PCs. | 146 | if (scheduled <= now) |
249 | */ | 147 | return -ETIME; |
250 | case day: | 148 | /* |
251 | dev_dbg(&rtc->dev, "alarm rollover: %s\n", "day"); | 149 | * XXX - We just checked to make sure the alarm time is not |
252 | t_alm += 24 * 60 * 60; | 150 | * in the past, but there is still a race window where if |
253 | rtc_time_to_tm(t_alm, &alarm->time); | 151 | * the is alarm set for the next second and the second ticks |
254 | break; | 152 | * over right here, before we set the alarm. |
255 | |||
256 | /* Month rollover ... if it's the 31th, an alarm on the 3rd will | ||
257 | * be next month. An alarm matching on the 30th, 29th, or 28th | ||
258 | * may end up in the month after that! Many newer PCs support | ||
259 | * this type of alarm. | ||
260 | */ | 153 | */ |
261 | case month: | ||
262 | dev_dbg(&rtc->dev, "alarm rollover: %s\n", "month"); | ||
263 | do { | ||
264 | if (alarm->time.tm_mon < 11) | ||
265 | alarm->time.tm_mon++; | ||
266 | else { | ||
267 | alarm->time.tm_mon = 0; | ||
268 | alarm->time.tm_year++; | ||
269 | } | ||
270 | days = rtc_month_days(alarm->time.tm_mon, | ||
271 | alarm->time.tm_year); | ||
272 | } while (days < alarm->time.tm_mday); | ||
273 | break; | ||
274 | |||
275 | /* Year rollover ... easy except for leap years! */ | ||
276 | case year: | ||
277 | dev_dbg(&rtc->dev, "alarm rollover: %s\n", "year"); | ||
278 | do { | ||
279 | alarm->time.tm_year++; | ||
280 | } while (rtc_valid_tm(&alarm->time) != 0); | ||
281 | break; | ||
282 | |||
283 | default: | ||
284 | dev_warn(&rtc->dev, "alarm rollover not handled\n"); | ||
285 | } | ||
286 | 154 | ||
287 | done: | 155 | if (!rtc->ops) |
288 | return 0; | 156 | err = -ENODEV; |
157 | else if (!rtc->ops->set_alarm) | ||
158 | err = -EINVAL; | ||
159 | else | ||
160 | err = rtc->ops->set_alarm(rtc->dev.parent, alarm); | ||
161 | |||
162 | return err; | ||
289 | } | 163 | } |
290 | EXPORT_SYMBOL_GPL(rtc_read_alarm); | ||
291 | 164 | ||
292 | int rtc_set_alarm(struct rtc_device *rtc, struct rtc_wkalrm *alarm) | 165 | int rtc_set_alarm(struct rtc_device *rtc, struct rtc_wkalrm *alarm) |
293 | { | 166 | { |
@@ -300,16 +173,18 @@ int rtc_set_alarm(struct rtc_device *rtc, struct rtc_wkalrm *alarm) | |||
300 | err = mutex_lock_interruptible(&rtc->ops_lock); | 173 | err = mutex_lock_interruptible(&rtc->ops_lock); |
301 | if (err) | 174 | if (err) |
302 | return err; | 175 | return err; |
303 | 176 | if (rtc->aie_timer.enabled) { | |
304 | if (!rtc->ops) | 177 | rtc_timer_remove(rtc, &rtc->aie_timer); |
305 | err = -ENODEV; | 178 | rtc->aie_timer.enabled = 0; |
306 | else if (!rtc->ops->set_alarm) | 179 | } |
307 | err = -EINVAL; | 180 | rtc->aie_timer.node.expires = rtc_tm_to_ktime(alarm->time); |
308 | else | 181 | rtc->aie_timer.period = ktime_set(0, 0); |
309 | err = rtc->ops->set_alarm(rtc->dev.parent, alarm); | 182 | if (alarm->enabled) { |
310 | 183 | rtc->aie_timer.enabled = 1; | |
184 | rtc_timer_enqueue(rtc, &rtc->aie_timer); | ||
185 | } | ||
311 | mutex_unlock(&rtc->ops_lock); | 186 | mutex_unlock(&rtc->ops_lock); |
312 | return err; | 187 | return 0; |
313 | } | 188 | } |
314 | EXPORT_SYMBOL_GPL(rtc_set_alarm); | 189 | EXPORT_SYMBOL_GPL(rtc_set_alarm); |
315 | 190 | ||
@@ -319,6 +194,16 @@ int rtc_alarm_irq_enable(struct rtc_device *rtc, unsigned int enabled) | |||
319 | if (err) | 194 | if (err) |
320 | return err; | 195 | return err; |
321 | 196 | ||
197 | if (rtc->aie_timer.enabled != enabled) { | ||
198 | if (enabled) { | ||
199 | rtc->aie_timer.enabled = 1; | ||
200 | rtc_timer_enqueue(rtc, &rtc->aie_timer); | ||
201 | } else { | ||
202 | rtc_timer_remove(rtc, &rtc->aie_timer); | ||
203 | rtc->aie_timer.enabled = 0; | ||
204 | } | ||
205 | } | ||
206 | |||
322 | if (!rtc->ops) | 207 | if (!rtc->ops) |
323 | err = -ENODEV; | 208 | err = -ENODEV; |
324 | else if (!rtc->ops->alarm_irq_enable) | 209 | else if (!rtc->ops->alarm_irq_enable) |
@@ -337,52 +222,53 @@ int rtc_update_irq_enable(struct rtc_device *rtc, unsigned int enabled) | |||
337 | if (err) | 222 | if (err) |
338 | return err; | 223 | return err; |
339 | 224 | ||
340 | #ifdef CONFIG_RTC_INTF_DEV_UIE_EMUL | 225 | /* make sure we're changing state */ |
341 | if (enabled == 0 && rtc->uie_irq_active) { | 226 | if (rtc->uie_rtctimer.enabled == enabled) |
342 | mutex_unlock(&rtc->ops_lock); | 227 | goto out; |
343 | return rtc_dev_update_irq_enable_emul(rtc, enabled); | 228 | |
229 | if (enabled) { | ||
230 | struct rtc_time tm; | ||
231 | ktime_t now, onesec; | ||
232 | |||
233 | __rtc_read_time(rtc, &tm); | ||
234 | onesec = ktime_set(1, 0); | ||
235 | now = rtc_tm_to_ktime(tm); | ||
236 | rtc->uie_rtctimer.node.expires = ktime_add(now, onesec); | ||
237 | rtc->uie_rtctimer.period = ktime_set(1, 0); | ||
238 | rtc->uie_rtctimer.enabled = 1; | ||
239 | rtc_timer_enqueue(rtc, &rtc->uie_rtctimer); | ||
240 | } else { | ||
241 | rtc_timer_remove(rtc, &rtc->uie_rtctimer); | ||
242 | rtc->uie_rtctimer.enabled = 0; | ||
344 | } | 243 | } |
345 | #endif | ||
346 | |||
347 | if (!rtc->ops) | ||
348 | err = -ENODEV; | ||
349 | else if (!rtc->ops->update_irq_enable) | ||
350 | err = -EINVAL; | ||
351 | else | ||
352 | err = rtc->ops->update_irq_enable(rtc->dev.parent, enabled); | ||
353 | 244 | ||
245 | out: | ||
354 | mutex_unlock(&rtc->ops_lock); | 246 | mutex_unlock(&rtc->ops_lock); |
355 | |||
356 | #ifdef CONFIG_RTC_INTF_DEV_UIE_EMUL | ||
357 | /* | ||
358 | * Enable emulation if the driver did not provide | ||
359 | * the update_irq_enable function pointer or if returned | ||
360 | * -EINVAL to signal that it has been configured without | ||
361 | * interrupts or that are not available at the moment. | ||
362 | */ | ||
363 | if (err == -EINVAL) | ||
364 | err = rtc_dev_update_irq_enable_emul(rtc, enabled); | ||
365 | #endif | ||
366 | return err; | 247 | return err; |
248 | |||
367 | } | 249 | } |
368 | EXPORT_SYMBOL_GPL(rtc_update_irq_enable); | 250 | EXPORT_SYMBOL_GPL(rtc_update_irq_enable); |
369 | 251 | ||
252 | |||
370 | /** | 253 | /** |
371 | * rtc_update_irq - report RTC periodic, alarm, and/or update irqs | 254 | * rtc_handle_legacy_irq - AIE, UIE and PIE event hook |
372 | * @rtc: the rtc device | 255 | * @rtc: pointer to the rtc device |
373 | * @num: how many irqs are being reported (usually one) | 256 | * |
374 | * @events: mask of RTC_IRQF with one or more of RTC_PF, RTC_AF, RTC_UF | 257 | * This function is called when an AIE, UIE or PIE mode interrupt |
375 | * Context: any | 258 | * has occured (or been emulated). |
259 | * | ||
260 | * Triggers the registered irq_task function callback. | ||
376 | */ | 261 | */ |
377 | void rtc_update_irq(struct rtc_device *rtc, | 262 | static void rtc_handle_legacy_irq(struct rtc_device *rtc, int num, int mode) |
378 | unsigned long num, unsigned long events) | ||
379 | { | 263 | { |
380 | unsigned long flags; | 264 | unsigned long flags; |
381 | 265 | ||
266 | /* mark one irq of the appropriate mode */ | ||
382 | spin_lock_irqsave(&rtc->irq_lock, flags); | 267 | spin_lock_irqsave(&rtc->irq_lock, flags); |
383 | rtc->irq_data = (rtc->irq_data + (num << 8)) | events; | 268 | rtc->irq_data = (rtc->irq_data + (num << 8)) | (RTC_IRQF|mode); |
384 | spin_unlock_irqrestore(&rtc->irq_lock, flags); | 269 | spin_unlock_irqrestore(&rtc->irq_lock, flags); |
385 | 270 | ||
271 | /* call the task func */ | ||
386 | spin_lock_irqsave(&rtc->irq_task_lock, flags); | 272 | spin_lock_irqsave(&rtc->irq_task_lock, flags); |
387 | if (rtc->irq_task) | 273 | if (rtc->irq_task) |
388 | rtc->irq_task->func(rtc->irq_task->private_data); | 274 | rtc->irq_task->func(rtc->irq_task->private_data); |
@@ -391,6 +277,69 @@ void rtc_update_irq(struct rtc_device *rtc, | |||
391 | wake_up_interruptible(&rtc->irq_queue); | 277 | wake_up_interruptible(&rtc->irq_queue); |
392 | kill_fasync(&rtc->async_queue, SIGIO, POLL_IN); | 278 | kill_fasync(&rtc->async_queue, SIGIO, POLL_IN); |
393 | } | 279 | } |
280 | |||
281 | |||
282 | /** | ||
283 | * rtc_aie_update_irq - AIE mode rtctimer hook | ||
284 | * @private: pointer to the rtc_device | ||
285 | * | ||
286 | * This functions is called when the aie_timer expires. | ||
287 | */ | ||
288 | void rtc_aie_update_irq(void *private) | ||
289 | { | ||
290 | struct rtc_device *rtc = (struct rtc_device *)private; | ||
291 | rtc_handle_legacy_irq(rtc, 1, RTC_AF); | ||
292 | } | ||
293 | |||
294 | |||
295 | /** | ||
296 | * rtc_uie_update_irq - UIE mode rtctimer hook | ||
297 | * @private: pointer to the rtc_device | ||
298 | * | ||
299 | * This functions is called when the uie_timer expires. | ||
300 | */ | ||
301 | void rtc_uie_update_irq(void *private) | ||
302 | { | ||
303 | struct rtc_device *rtc = (struct rtc_device *)private; | ||
304 | rtc_handle_legacy_irq(rtc, 1, RTC_UF); | ||
305 | } | ||
306 | |||
307 | |||
308 | /** | ||
309 | * rtc_pie_update_irq - PIE mode hrtimer hook | ||
310 | * @timer: pointer to the pie mode hrtimer | ||
311 | * | ||
312 | * This function is used to emulate PIE mode interrupts | ||
313 | * using an hrtimer. This function is called when the periodic | ||
314 | * hrtimer expires. | ||
315 | */ | ||
316 | enum hrtimer_restart rtc_pie_update_irq(struct hrtimer *timer) | ||
317 | { | ||
318 | struct rtc_device *rtc; | ||
319 | ktime_t period; | ||
320 | int count; | ||
321 | rtc = container_of(timer, struct rtc_device, pie_timer); | ||
322 | |||
323 | period = ktime_set(0, NSEC_PER_SEC/rtc->irq_freq); | ||
324 | count = hrtimer_forward_now(timer, period); | ||
325 | |||
326 | rtc_handle_legacy_irq(rtc, count, RTC_PF); | ||
327 | |||
328 | return HRTIMER_RESTART; | ||
329 | } | ||
330 | |||
331 | /** | ||
332 | * rtc_update_irq - Triggered when a RTC interrupt occurs. | ||
333 | * @rtc: the rtc device | ||
334 | * @num: how many irqs are being reported (usually one) | ||
335 | * @events: mask of RTC_IRQF with one or more of RTC_PF, RTC_AF, RTC_UF | ||
336 | * Context: any | ||
337 | */ | ||
338 | void rtc_update_irq(struct rtc_device *rtc, | ||
339 | unsigned long num, unsigned long events) | ||
340 | { | ||
341 | schedule_work(&rtc->irqwork); | ||
342 | } | ||
394 | EXPORT_SYMBOL_GPL(rtc_update_irq); | 343 | EXPORT_SYMBOL_GPL(rtc_update_irq); |
395 | 344 | ||
396 | static int __rtc_match(struct device *dev, void *data) | 345 | static int __rtc_match(struct device *dev, void *data) |
@@ -477,18 +426,20 @@ int rtc_irq_set_state(struct rtc_device *rtc, struct rtc_task *task, int enabled | |||
477 | int err = 0; | 426 | int err = 0; |
478 | unsigned long flags; | 427 | unsigned long flags; |
479 | 428 | ||
480 | if (rtc->ops->irq_set_state == NULL) | ||
481 | return -ENXIO; | ||
482 | |||
483 | spin_lock_irqsave(&rtc->irq_task_lock, flags); | 429 | spin_lock_irqsave(&rtc->irq_task_lock, flags); |
484 | if (rtc->irq_task != NULL && task == NULL) | 430 | if (rtc->irq_task != NULL && task == NULL) |
485 | err = -EBUSY; | 431 | err = -EBUSY; |
486 | if (rtc->irq_task != task) | 432 | if (rtc->irq_task != task) |
487 | err = -EACCES; | 433 | err = -EACCES; |
488 | spin_unlock_irqrestore(&rtc->irq_task_lock, flags); | ||
489 | 434 | ||
490 | if (err == 0) | 435 | if (enabled) { |
491 | err = rtc->ops->irq_set_state(rtc->dev.parent, enabled); | 436 | ktime_t period = ktime_set(0, NSEC_PER_SEC/rtc->irq_freq); |
437 | hrtimer_start(&rtc->pie_timer, period, HRTIMER_MODE_REL); | ||
438 | } else { | ||
439 | hrtimer_cancel(&rtc->pie_timer); | ||
440 | } | ||
441 | rtc->pie_enabled = enabled; | ||
442 | spin_unlock_irqrestore(&rtc->irq_task_lock, flags); | ||
492 | 443 | ||
493 | return err; | 444 | return err; |
494 | } | 445 | } |
@@ -509,21 +460,194 @@ int rtc_irq_set_freq(struct rtc_device *rtc, struct rtc_task *task, int freq) | |||
509 | int err = 0; | 460 | int err = 0; |
510 | unsigned long flags; | 461 | unsigned long flags; |
511 | 462 | ||
512 | if (rtc->ops->irq_set_freq == NULL) | ||
513 | return -ENXIO; | ||
514 | |||
515 | spin_lock_irqsave(&rtc->irq_task_lock, flags); | 463 | spin_lock_irqsave(&rtc->irq_task_lock, flags); |
516 | if (rtc->irq_task != NULL && task == NULL) | 464 | if (rtc->irq_task != NULL && task == NULL) |
517 | err = -EBUSY; | 465 | err = -EBUSY; |
518 | if (rtc->irq_task != task) | 466 | if (rtc->irq_task != task) |
519 | err = -EACCES; | 467 | err = -EACCES; |
520 | spin_unlock_irqrestore(&rtc->irq_task_lock, flags); | ||
521 | |||
522 | if (err == 0) { | 468 | if (err == 0) { |
523 | err = rtc->ops->irq_set_freq(rtc->dev.parent, freq); | 469 | rtc->irq_freq = freq; |
524 | if (err == 0) | 470 | if (rtc->pie_enabled) { |
525 | rtc->irq_freq = freq; | 471 | ktime_t period; |
472 | hrtimer_cancel(&rtc->pie_timer); | ||
473 | period = ktime_set(0, NSEC_PER_SEC/rtc->irq_freq); | ||
474 | hrtimer_start(&rtc->pie_timer, period, | ||
475 | HRTIMER_MODE_REL); | ||
476 | } | ||
526 | } | 477 | } |
478 | spin_unlock_irqrestore(&rtc->irq_task_lock, flags); | ||
527 | return err; | 479 | return err; |
528 | } | 480 | } |
529 | EXPORT_SYMBOL_GPL(rtc_irq_set_freq); | 481 | EXPORT_SYMBOL_GPL(rtc_irq_set_freq); |
482 | |||
483 | /** | ||
484 | * rtc_timer_enqueue - Adds a rtc_timer to the rtc_device timerqueue | ||
485 | * @rtc rtc device | ||
486 | * @timer timer being added. | ||
487 | * | ||
488 | * Enqueues a timer onto the rtc devices timerqueue and sets | ||
489 | * the next alarm event appropriately. | ||
490 | * | ||
491 | * Must hold ops_lock for proper serialization of timerqueue | ||
492 | */ | ||
493 | void rtc_timer_enqueue(struct rtc_device *rtc, struct rtc_timer *timer) | ||
494 | { | ||
495 | timerqueue_add(&rtc->timerqueue, &timer->node); | ||
496 | if (&timer->node == timerqueue_getnext(&rtc->timerqueue)) { | ||
497 | struct rtc_wkalrm alarm; | ||
498 | int err; | ||
499 | alarm.time = rtc_ktime_to_tm(timer->node.expires); | ||
500 | alarm.enabled = 1; | ||
501 | err = __rtc_set_alarm(rtc, &alarm); | ||
502 | if (err == -ETIME) | ||
503 | schedule_work(&rtc->irqwork); | ||
504 | } | ||
505 | } | ||
506 | |||
507 | /** | ||
508 | * rtc_timer_remove - Removes a rtc_timer from the rtc_device timerqueue | ||
509 | * @rtc rtc device | ||
510 | * @timer timer being removed. | ||
511 | * | ||
512 | * Removes a timer onto the rtc devices timerqueue and sets | ||
513 | * the next alarm event appropriately. | ||
514 | * | ||
515 | * Must hold ops_lock for proper serialization of timerqueue | ||
516 | */ | ||
517 | void rtc_timer_remove(struct rtc_device *rtc, struct rtc_timer *timer) | ||
518 | { | ||
519 | struct timerqueue_node *next = timerqueue_getnext(&rtc->timerqueue); | ||
520 | timerqueue_del(&rtc->timerqueue, &timer->node); | ||
521 | |||
522 | if (next == &timer->node) { | ||
523 | struct rtc_wkalrm alarm; | ||
524 | int err; | ||
525 | next = timerqueue_getnext(&rtc->timerqueue); | ||
526 | if (!next) | ||
527 | return; | ||
528 | alarm.time = rtc_ktime_to_tm(next->expires); | ||
529 | alarm.enabled = 1; | ||
530 | err = __rtc_set_alarm(rtc, &alarm); | ||
531 | if (err == -ETIME) | ||
532 | schedule_work(&rtc->irqwork); | ||
533 | } | ||
534 | } | ||
535 | |||
536 | /** | ||
537 | * rtc_timer_do_work - Expires rtc timers | ||
538 | * @rtc rtc device | ||
539 | * @timer timer being removed. | ||
540 | * | ||
541 | * Expires rtc timers. Reprograms next alarm event if needed. | ||
542 | * Called via worktask. | ||
543 | * | ||
544 | * Serializes access to timerqueue via ops_lock mutex | ||
545 | */ | ||
546 | void rtc_timer_do_work(struct work_struct *work) | ||
547 | { | ||
548 | struct rtc_timer *timer; | ||
549 | struct timerqueue_node *next; | ||
550 | ktime_t now; | ||
551 | struct rtc_time tm; | ||
552 | |||
553 | struct rtc_device *rtc = | ||
554 | container_of(work, struct rtc_device, irqwork); | ||
555 | |||
556 | mutex_lock(&rtc->ops_lock); | ||
557 | again: | ||
558 | __rtc_read_time(rtc, &tm); | ||
559 | now = rtc_tm_to_ktime(tm); | ||
560 | while ((next = timerqueue_getnext(&rtc->timerqueue))) { | ||
561 | if (next->expires.tv64 > now.tv64) | ||
562 | break; | ||
563 | |||
564 | /* expire timer */ | ||
565 | timer = container_of(next, struct rtc_timer, node); | ||
566 | timerqueue_del(&rtc->timerqueue, &timer->node); | ||
567 | timer->enabled = 0; | ||
568 | if (timer->task.func) | ||
569 | timer->task.func(timer->task.private_data); | ||
570 | |||
571 | /* Re-add/fwd periodic timers */ | ||
572 | if (ktime_to_ns(timer->period)) { | ||
573 | timer->node.expires = ktime_add(timer->node.expires, | ||
574 | timer->period); | ||
575 | timer->enabled = 1; | ||
576 | timerqueue_add(&rtc->timerqueue, &timer->node); | ||
577 | } | ||
578 | } | ||
579 | |||
580 | /* Set next alarm */ | ||
581 | if (next) { | ||
582 | struct rtc_wkalrm alarm; | ||
583 | int err; | ||
584 | alarm.time = rtc_ktime_to_tm(next->expires); | ||
585 | alarm.enabled = 1; | ||
586 | err = __rtc_set_alarm(rtc, &alarm); | ||
587 | if (err == -ETIME) | ||
588 | goto again; | ||
589 | } | ||
590 | |||
591 | mutex_unlock(&rtc->ops_lock); | ||
592 | } | ||
593 | |||
594 | |||
595 | /* rtc_timer_init - Initializes an rtc_timer | ||
596 | * @timer: timer to be intiialized | ||
597 | * @f: function pointer to be called when timer fires | ||
598 | * @data: private data passed to function pointer | ||
599 | * | ||
600 | * Kernel interface to initializing an rtc_timer. | ||
601 | */ | ||
602 | void rtc_timer_init(struct rtc_timer *timer, void (*f)(void* p), void* data) | ||
603 | { | ||
604 | timerqueue_init(&timer->node); | ||
605 | timer->enabled = 0; | ||
606 | timer->task.func = f; | ||
607 | timer->task.private_data = data; | ||
608 | } | ||
609 | |||
610 | /* rtc_timer_start - Sets an rtc_timer to fire in the future | ||
611 | * @ rtc: rtc device to be used | ||
612 | * @ timer: timer being set | ||
613 | * @ expires: time at which to expire the timer | ||
614 | * @ period: period that the timer will recur | ||
615 | * | ||
616 | * Kernel interface to set an rtc_timer | ||
617 | */ | ||
618 | int rtc_timer_start(struct rtc_device *rtc, struct rtc_timer* timer, | ||
619 | ktime_t expires, ktime_t period) | ||
620 | { | ||
621 | int ret = 0; | ||
622 | mutex_lock(&rtc->ops_lock); | ||
623 | if (timer->enabled) | ||
624 | rtc_timer_remove(rtc, timer); | ||
625 | |||
626 | timer->node.expires = expires; | ||
627 | timer->period = period; | ||
628 | |||
629 | timer->enabled = 1; | ||
630 | rtc_timer_enqueue(rtc, timer); | ||
631 | |||
632 | mutex_unlock(&rtc->ops_lock); | ||
633 | return ret; | ||
634 | } | ||
635 | |||
636 | /* rtc_timer_cancel - Stops an rtc_timer | ||
637 | * @ rtc: rtc device to be used | ||
638 | * @ timer: timer being set | ||
639 | * | ||
640 | * Kernel interface to cancel an rtc_timer | ||
641 | */ | ||
642 | int rtc_timer_cancel(struct rtc_device *rtc, struct rtc_timer* timer) | ||
643 | { | ||
644 | int ret = 0; | ||
645 | mutex_lock(&rtc->ops_lock); | ||
646 | if (timer->enabled) | ||
647 | rtc_timer_remove(rtc, timer); | ||
648 | timer->enabled = 0; | ||
649 | mutex_unlock(&rtc->ops_lock); | ||
650 | return ret; | ||
651 | } | ||
652 | |||
653 | |||
diff --git a/drivers/rtc/rtc-dev.c b/drivers/rtc/rtc-dev.c index 62227cd52410..212b16edafc0 100644 --- a/drivers/rtc/rtc-dev.c +++ b/drivers/rtc/rtc-dev.c | |||
@@ -46,105 +46,6 @@ static int rtc_dev_open(struct inode *inode, struct file *file) | |||
46 | return err; | 46 | return err; |
47 | } | 47 | } |
48 | 48 | ||
49 | #ifdef CONFIG_RTC_INTF_DEV_UIE_EMUL | ||
50 | /* | ||
51 | * Routine to poll RTC seconds field for change as often as possible, | ||
52 | * after first RTC_UIE use timer to reduce polling | ||
53 | */ | ||
54 | static void rtc_uie_task(struct work_struct *work) | ||
55 | { | ||
56 | struct rtc_device *rtc = | ||
57 | container_of(work, struct rtc_device, uie_task); | ||
58 | struct rtc_time tm; | ||
59 | int num = 0; | ||
60 | int err; | ||
61 | |||
62 | err = rtc_read_time(rtc, &tm); | ||
63 | |||
64 | spin_lock_irq(&rtc->irq_lock); | ||
65 | if (rtc->stop_uie_polling || err) { | ||
66 | rtc->uie_task_active = 0; | ||
67 | } else if (rtc->oldsecs != tm.tm_sec) { | ||
68 | num = (tm.tm_sec + 60 - rtc->oldsecs) % 60; | ||
69 | rtc->oldsecs = tm.tm_sec; | ||
70 | rtc->uie_timer.expires = jiffies + HZ - (HZ/10); | ||
71 | rtc->uie_timer_active = 1; | ||
72 | rtc->uie_task_active = 0; | ||
73 | add_timer(&rtc->uie_timer); | ||
74 | } else if (schedule_work(&rtc->uie_task) == 0) { | ||
75 | rtc->uie_task_active = 0; | ||
76 | } | ||
77 | spin_unlock_irq(&rtc->irq_lock); | ||
78 | if (num) | ||
79 | rtc_update_irq(rtc, num, RTC_UF | RTC_IRQF); | ||
80 | } | ||
81 | static void rtc_uie_timer(unsigned long data) | ||
82 | { | ||
83 | struct rtc_device *rtc = (struct rtc_device *)data; | ||
84 | unsigned long flags; | ||
85 | |||
86 | spin_lock_irqsave(&rtc->irq_lock, flags); | ||
87 | rtc->uie_timer_active = 0; | ||
88 | rtc->uie_task_active = 1; | ||
89 | if ((schedule_work(&rtc->uie_task) == 0)) | ||
90 | rtc->uie_task_active = 0; | ||
91 | spin_unlock_irqrestore(&rtc->irq_lock, flags); | ||
92 | } | ||
93 | |||
94 | static int clear_uie(struct rtc_device *rtc) | ||
95 | { | ||
96 | spin_lock_irq(&rtc->irq_lock); | ||
97 | if (rtc->uie_irq_active) { | ||
98 | rtc->stop_uie_polling = 1; | ||
99 | if (rtc->uie_timer_active) { | ||
100 | spin_unlock_irq(&rtc->irq_lock); | ||
101 | del_timer_sync(&rtc->uie_timer); | ||
102 | spin_lock_irq(&rtc->irq_lock); | ||
103 | rtc->uie_timer_active = 0; | ||
104 | } | ||
105 | if (rtc->uie_task_active) { | ||
106 | spin_unlock_irq(&rtc->irq_lock); | ||
107 | flush_scheduled_work(); | ||
108 | spin_lock_irq(&rtc->irq_lock); | ||
109 | } | ||
110 | rtc->uie_irq_active = 0; | ||
111 | } | ||
112 | spin_unlock_irq(&rtc->irq_lock); | ||
113 | return 0; | ||
114 | } | ||
115 | |||
116 | static int set_uie(struct rtc_device *rtc) | ||
117 | { | ||
118 | struct rtc_time tm; | ||
119 | int err; | ||
120 | |||
121 | err = rtc_read_time(rtc, &tm); | ||
122 | if (err) | ||
123 | return err; | ||
124 | spin_lock_irq(&rtc->irq_lock); | ||
125 | if (!rtc->uie_irq_active) { | ||
126 | rtc->uie_irq_active = 1; | ||
127 | rtc->stop_uie_polling = 0; | ||
128 | rtc->oldsecs = tm.tm_sec; | ||
129 | rtc->uie_task_active = 1; | ||
130 | if (schedule_work(&rtc->uie_task) == 0) | ||
131 | rtc->uie_task_active = 0; | ||
132 | } | ||
133 | rtc->irq_data = 0; | ||
134 | spin_unlock_irq(&rtc->irq_lock); | ||
135 | return 0; | ||
136 | } | ||
137 | |||
138 | int rtc_dev_update_irq_enable_emul(struct rtc_device *rtc, unsigned int enabled) | ||
139 | { | ||
140 | if (enabled) | ||
141 | return set_uie(rtc); | ||
142 | else | ||
143 | return clear_uie(rtc); | ||
144 | } | ||
145 | EXPORT_SYMBOL(rtc_dev_update_irq_enable_emul); | ||
146 | |||
147 | #endif /* CONFIG_RTC_INTF_DEV_UIE_EMUL */ | ||
148 | 49 | ||
149 | static ssize_t | 50 | static ssize_t |
150 | rtc_dev_read(struct file *file, char __user *buf, size_t count, loff_t *ppos) | 51 | rtc_dev_read(struct file *file, char __user *buf, size_t count, loff_t *ppos) |
@@ -493,11 +394,6 @@ void rtc_dev_prepare(struct rtc_device *rtc) | |||
493 | 394 | ||
494 | rtc->dev.devt = MKDEV(MAJOR(rtc_devt), rtc->id); | 395 | rtc->dev.devt = MKDEV(MAJOR(rtc_devt), rtc->id); |
495 | 396 | ||
496 | #ifdef CONFIG_RTC_INTF_DEV_UIE_EMUL | ||
497 | INIT_WORK(&rtc->uie_task, rtc_uie_task); | ||
498 | setup_timer(&rtc->uie_timer, rtc_uie_timer, (unsigned long)rtc); | ||
499 | #endif | ||
500 | |||
501 | cdev_init(&rtc->char_dev, &rtc_dev_fops); | 397 | cdev_init(&rtc->char_dev, &rtc_dev_fops); |
502 | rtc->char_dev.owner = rtc->owner; | 398 | rtc->char_dev.owner = rtc->owner; |
503 | } | 399 | } |
diff --git a/drivers/rtc/rtc-ds1305.c b/drivers/rtc/rtc-ds1305.c index 48da85e97ca4..077af1d7b9e4 100644 --- a/drivers/rtc/rtc-ds1305.c +++ b/drivers/rtc/rtc-ds1305.c | |||
@@ -813,7 +813,7 @@ static int __devexit ds1305_remove(struct spi_device *spi) | |||
813 | if (spi->irq) { | 813 | if (spi->irq) { |
814 | set_bit(FLAG_EXITING, &ds1305->flags); | 814 | set_bit(FLAG_EXITING, &ds1305->flags); |
815 | free_irq(spi->irq, ds1305); | 815 | free_irq(spi->irq, ds1305); |
816 | flush_scheduled_work(); | 816 | cancel_work_sync(&ds1305->work); |
817 | } | 817 | } |
818 | 818 | ||
819 | rtc_device_unregister(ds1305->rtc); | 819 | rtc_device_unregister(ds1305->rtc); |
diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c index d827ce570a8c..0d559b6416dd 100644 --- a/drivers/rtc/rtc-ds1307.c +++ b/drivers/rtc/rtc-ds1307.c | |||
@@ -106,9 +106,9 @@ struct ds1307 { | |||
106 | struct i2c_client *client; | 106 | struct i2c_client *client; |
107 | struct rtc_device *rtc; | 107 | struct rtc_device *rtc; |
108 | struct work_struct work; | 108 | struct work_struct work; |
109 | s32 (*read_block_data)(struct i2c_client *client, u8 command, | 109 | s32 (*read_block_data)(const struct i2c_client *client, u8 command, |
110 | u8 length, u8 *values); | 110 | u8 length, u8 *values); |
111 | s32 (*write_block_data)(struct i2c_client *client, u8 command, | 111 | s32 (*write_block_data)(const struct i2c_client *client, u8 command, |
112 | u8 length, const u8 *values); | 112 | u8 length, const u8 *values); |
113 | }; | 113 | }; |
114 | 114 | ||
@@ -158,8 +158,8 @@ MODULE_DEVICE_TABLE(i2c, ds1307_id); | |||
158 | 158 | ||
159 | #define BLOCK_DATA_MAX_TRIES 10 | 159 | #define BLOCK_DATA_MAX_TRIES 10 |
160 | 160 | ||
161 | static s32 ds1307_read_block_data_once(struct i2c_client *client, u8 command, | 161 | static s32 ds1307_read_block_data_once(const struct i2c_client *client, |
162 | u8 length, u8 *values) | 162 | u8 command, u8 length, u8 *values) |
163 | { | 163 | { |
164 | s32 i, data; | 164 | s32 i, data; |
165 | 165 | ||
@@ -172,7 +172,7 @@ static s32 ds1307_read_block_data_once(struct i2c_client *client, u8 command, | |||
172 | return i; | 172 | return i; |
173 | } | 173 | } |
174 | 174 | ||
175 | static s32 ds1307_read_block_data(struct i2c_client *client, u8 command, | 175 | static s32 ds1307_read_block_data(const struct i2c_client *client, u8 command, |
176 | u8 length, u8 *values) | 176 | u8 length, u8 *values) |
177 | { | 177 | { |
178 | u8 oldvalues[I2C_SMBUS_BLOCK_MAX]; | 178 | u8 oldvalues[I2C_SMBUS_BLOCK_MAX]; |
@@ -198,7 +198,7 @@ static s32 ds1307_read_block_data(struct i2c_client *client, u8 command, | |||
198 | return length; | 198 | return length; |
199 | } | 199 | } |
200 | 200 | ||
201 | static s32 ds1307_write_block_data(struct i2c_client *client, u8 command, | 201 | static s32 ds1307_write_block_data(const struct i2c_client *client, u8 command, |
202 | u8 length, const u8 *values) | 202 | u8 length, const u8 *values) |
203 | { | 203 | { |
204 | u8 currvalues[I2C_SMBUS_BLOCK_MAX]; | 204 | u8 currvalues[I2C_SMBUS_BLOCK_MAX]; |
diff --git a/drivers/rtc/rtc-ds1374.c b/drivers/rtc/rtc-ds1374.c index 1f0007fd4431..47fb6357c346 100644 --- a/drivers/rtc/rtc-ds1374.c +++ b/drivers/rtc/rtc-ds1374.c | |||
@@ -417,7 +417,7 @@ static int __devexit ds1374_remove(struct i2c_client *client) | |||
417 | mutex_unlock(&ds1374->mutex); | 417 | mutex_unlock(&ds1374->mutex); |
418 | 418 | ||
419 | free_irq(client->irq, client); | 419 | free_irq(client->irq, client); |
420 | flush_scheduled_work(); | 420 | cancel_work_sync(&ds1374->work); |
421 | } | 421 | } |
422 | 422 | ||
423 | rtc_device_unregister(ds1374->rtc); | 423 | rtc_device_unregister(ds1374->rtc); |
diff --git a/drivers/rtc/rtc-ds3232.c b/drivers/rtc/rtc-ds3232.c index 57063552d3b7..23a9ee19764c 100644 --- a/drivers/rtc/rtc-ds3232.c +++ b/drivers/rtc/rtc-ds3232.c | |||
@@ -463,7 +463,7 @@ static int __devexit ds3232_remove(struct i2c_client *client) | |||
463 | mutex_unlock(&ds3232->mutex); | 463 | mutex_unlock(&ds3232->mutex); |
464 | 464 | ||
465 | free_irq(client->irq, client); | 465 | free_irq(client->irq, client); |
466 | flush_scheduled_work(); | 466 | cancel_work_sync(&ds3232->work); |
467 | } | 467 | } |
468 | 468 | ||
469 | rtc_device_unregister(ds3232->rtc); | 469 | rtc_device_unregister(ds3232->rtc); |
diff --git a/drivers/rtc/rtc-lib.c b/drivers/rtc/rtc-lib.c index 773851f338b8..075f1708deae 100644 --- a/drivers/rtc/rtc-lib.c +++ b/drivers/rtc/rtc-lib.c | |||
@@ -117,4 +117,32 @@ int rtc_tm_to_time(struct rtc_time *tm, unsigned long *time) | |||
117 | } | 117 | } |
118 | EXPORT_SYMBOL(rtc_tm_to_time); | 118 | EXPORT_SYMBOL(rtc_tm_to_time); |
119 | 119 | ||
120 | /* | ||
121 | * Convert rtc_time to ktime | ||
122 | */ | ||
123 | ktime_t rtc_tm_to_ktime(struct rtc_time tm) | ||
124 | { | ||
125 | time_t time; | ||
126 | rtc_tm_to_time(&tm, &time); | ||
127 | return ktime_set(time, 0); | ||
128 | } | ||
129 | EXPORT_SYMBOL_GPL(rtc_tm_to_ktime); | ||
130 | |||
131 | /* | ||
132 | * Convert ktime to rtc_time | ||
133 | */ | ||
134 | struct rtc_time rtc_ktime_to_tm(ktime_t kt) | ||
135 | { | ||
136 | struct timespec ts; | ||
137 | struct rtc_time ret; | ||
138 | |||
139 | ts = ktime_to_timespec(kt); | ||
140 | /* Round up any ns */ | ||
141 | if (ts.tv_nsec) | ||
142 | ts.tv_sec++; | ||
143 | rtc_time_to_tm(ts.tv_sec, &ret); | ||
144 | return ret; | ||
145 | } | ||
146 | EXPORT_SYMBOL_GPL(rtc_ktime_to_tm); | ||
147 | |||
120 | MODULE_LICENSE("GPL"); | 148 | MODULE_LICENSE("GPL"); |
diff --git a/drivers/rtc/rtc-mrst.c b/drivers/rtc/rtc-mrst.c new file mode 100644 index 000000000000..bcd0cf63eb16 --- /dev/null +++ b/drivers/rtc/rtc-mrst.c | |||
@@ -0,0 +1,582 @@ | |||
1 | /* | ||
2 | * rtc-mrst.c: Driver for Moorestown virtual RTC | ||
3 | * | ||
4 | * (C) Copyright 2009 Intel Corporation | ||
5 | * Author: Jacob Pan (jacob.jun.pan@intel.com) | ||
6 | * Feng Tang (feng.tang@intel.com) | ||
7 | * | ||
8 | * This program is free software; you can redistribute it and/or | ||
9 | * modify it under the terms of the GNU General Public License | ||
10 | * as published by the Free Software Foundation; version 2 | ||
11 | * of the License. | ||
12 | * | ||
13 | * Note: | ||
14 | * VRTC is emulated by system controller firmware, the real HW | ||
15 | * RTC is located in the PMIC device. SCU FW shadows PMIC RTC | ||
16 | * in a memory mapped IO space that is visible to the host IA | ||
17 | * processor. | ||
18 | * | ||
19 | * This driver is based upon drivers/rtc/rtc-cmos.c | ||
20 | */ | ||
21 | |||
22 | /* | ||
23 | * Note: | ||
24 | * * vRTC only supports binary mode and 24H mode | ||
25 | * * vRTC only support PIE and AIE, no UIE, and its PIE only happens | ||
26 | * at 23:59:59pm everyday, no support for adjustable frequency | ||
27 | * * Alarm function is also limited to hr/min/sec. | ||
28 | */ | ||
29 | |||
30 | #include <linux/mod_devicetable.h> | ||
31 | #include <linux/platform_device.h> | ||
32 | #include <linux/interrupt.h> | ||
33 | #include <linux/spinlock.h> | ||
34 | #include <linux/kernel.h> | ||
35 | #include <linux/module.h> | ||
36 | #include <linux/init.h> | ||
37 | #include <linux/sfi.h> | ||
38 | |||
39 | #include <asm-generic/rtc.h> | ||
40 | #include <asm/intel_scu_ipc.h> | ||
41 | #include <asm/mrst.h> | ||
42 | #include <asm/mrst-vrtc.h> | ||
43 | |||
44 | struct mrst_rtc { | ||
45 | struct rtc_device *rtc; | ||
46 | struct device *dev; | ||
47 | int irq; | ||
48 | struct resource *iomem; | ||
49 | |||
50 | u8 enabled_wake; | ||
51 | u8 suspend_ctrl; | ||
52 | }; | ||
53 | |||
54 | static const char driver_name[] = "rtc_mrst"; | ||
55 | |||
56 | #define RTC_IRQMASK (RTC_PF | RTC_AF) | ||
57 | |||
58 | static inline int is_intr(u8 rtc_intr) | ||
59 | { | ||
60 | if (!(rtc_intr & RTC_IRQF)) | ||
61 | return 0; | ||
62 | return rtc_intr & RTC_IRQMASK; | ||
63 | } | ||
64 | |||
65 | /* | ||
66 | * rtc_time's year contains the increment over 1900, but vRTC's YEAR | ||
67 | * register can't be programmed to value larger than 0x64, so vRTC | ||
68 | * driver chose to use 1960 (1970 is UNIX time start point) as the base, | ||
69 | * and does the translation at read/write time. | ||
70 | * | ||
71 | * Why not just use 1970 as the offset? it's because using 1960 will | ||
72 | * make it consistent in leap year setting for both vrtc and low-level | ||
73 | * physical rtc devices. | ||
74 | */ | ||
75 | static int mrst_read_time(struct device *dev, struct rtc_time *time) | ||
76 | { | ||
77 | unsigned long flags; | ||
78 | |||
79 | if (rtc_is_updating()) | ||
80 | mdelay(20); | ||
81 | |||
82 | spin_lock_irqsave(&rtc_lock, flags); | ||
83 | time->tm_sec = vrtc_cmos_read(RTC_SECONDS); | ||
84 | time->tm_min = vrtc_cmos_read(RTC_MINUTES); | ||
85 | time->tm_hour = vrtc_cmos_read(RTC_HOURS); | ||
86 | time->tm_mday = vrtc_cmos_read(RTC_DAY_OF_MONTH); | ||
87 | time->tm_mon = vrtc_cmos_read(RTC_MONTH); | ||
88 | time->tm_year = vrtc_cmos_read(RTC_YEAR); | ||
89 | spin_unlock_irqrestore(&rtc_lock, flags); | ||
90 | |||
91 | /* Adjust for the 1960/1900 */ | ||
92 | time->tm_year += 60; | ||
93 | time->tm_mon--; | ||
94 | return RTC_24H; | ||
95 | } | ||
96 | |||
97 | static int mrst_set_time(struct device *dev, struct rtc_time *time) | ||
98 | { | ||
99 | int ret; | ||
100 | unsigned long flags; | ||
101 | unsigned char mon, day, hrs, min, sec; | ||
102 | unsigned int yrs; | ||
103 | |||
104 | yrs = time->tm_year; | ||
105 | mon = time->tm_mon + 1; /* tm_mon starts at zero */ | ||
106 | day = time->tm_mday; | ||
107 | hrs = time->tm_hour; | ||
108 | min = time->tm_min; | ||
109 | sec = time->tm_sec; | ||
110 | |||
111 | if (yrs < 70 || yrs > 138) | ||
112 | return -EINVAL; | ||
113 | yrs -= 60; | ||
114 | |||
115 | spin_lock_irqsave(&rtc_lock, flags); | ||
116 | |||
117 | vrtc_cmos_write(yrs, RTC_YEAR); | ||
118 | vrtc_cmos_write(mon, RTC_MONTH); | ||
119 | vrtc_cmos_write(day, RTC_DAY_OF_MONTH); | ||
120 | vrtc_cmos_write(hrs, RTC_HOURS); | ||
121 | vrtc_cmos_write(min, RTC_MINUTES); | ||
122 | vrtc_cmos_write(sec, RTC_SECONDS); | ||
123 | |||
124 | spin_unlock_irqrestore(&rtc_lock, flags); | ||
125 | |||
126 | ret = intel_scu_ipc_simple_command(IPCMSG_VRTC, IPC_CMD_VRTC_SETTIME); | ||
127 | return ret; | ||
128 | } | ||
129 | |||
130 | static int mrst_read_alarm(struct device *dev, struct rtc_wkalrm *t) | ||
131 | { | ||
132 | struct mrst_rtc *mrst = dev_get_drvdata(dev); | ||
133 | unsigned char rtc_control; | ||
134 | |||
135 | if (mrst->irq <= 0) | ||
136 | return -EIO; | ||
137 | |||
138 | /* Basic alarms only support hour, minute, and seconds fields. | ||
139 | * Some also support day and month, for alarms up to a year in | ||
140 | * the future. | ||
141 | */ | ||
142 | t->time.tm_mday = -1; | ||
143 | t->time.tm_mon = -1; | ||
144 | t->time.tm_year = -1; | ||
145 | |||
146 | /* vRTC only supports binary mode */ | ||
147 | spin_lock_irq(&rtc_lock); | ||
148 | t->time.tm_sec = vrtc_cmos_read(RTC_SECONDS_ALARM); | ||
149 | t->time.tm_min = vrtc_cmos_read(RTC_MINUTES_ALARM); | ||
150 | t->time.tm_hour = vrtc_cmos_read(RTC_HOURS_ALARM); | ||
151 | |||
152 | rtc_control = vrtc_cmos_read(RTC_CONTROL); | ||
153 | spin_unlock_irq(&rtc_lock); | ||
154 | |||
155 | t->enabled = !!(rtc_control & RTC_AIE); | ||
156 | t->pending = 0; | ||
157 | |||
158 | return 0; | ||
159 | } | ||
160 | |||
161 | static void mrst_checkintr(struct mrst_rtc *mrst, unsigned char rtc_control) | ||
162 | { | ||
163 | unsigned char rtc_intr; | ||
164 | |||
165 | /* | ||
166 | * NOTE after changing RTC_xIE bits we always read INTR_FLAGS; | ||
167 | * allegedly some older rtcs need that to handle irqs properly | ||
168 | */ | ||
169 | rtc_intr = vrtc_cmos_read(RTC_INTR_FLAGS); | ||
170 | rtc_intr &= (rtc_control & RTC_IRQMASK) | RTC_IRQF; | ||
171 | if (is_intr(rtc_intr)) | ||
172 | rtc_update_irq(mrst->rtc, 1, rtc_intr); | ||
173 | } | ||
174 | |||
175 | static void mrst_irq_enable(struct mrst_rtc *mrst, unsigned char mask) | ||
176 | { | ||
177 | unsigned char rtc_control; | ||
178 | |||
179 | /* | ||
180 | * Flush any pending IRQ status, notably for update irqs, | ||
181 | * before we enable new IRQs | ||
182 | */ | ||
183 | rtc_control = vrtc_cmos_read(RTC_CONTROL); | ||
184 | mrst_checkintr(mrst, rtc_control); | ||
185 | |||
186 | rtc_control |= mask; | ||
187 | vrtc_cmos_write(rtc_control, RTC_CONTROL); | ||
188 | |||
189 | mrst_checkintr(mrst, rtc_control); | ||
190 | } | ||
191 | |||
192 | static void mrst_irq_disable(struct mrst_rtc *mrst, unsigned char mask) | ||
193 | { | ||
194 | unsigned char rtc_control; | ||
195 | |||
196 | rtc_control = vrtc_cmos_read(RTC_CONTROL); | ||
197 | rtc_control &= ~mask; | ||
198 | vrtc_cmos_write(rtc_control, RTC_CONTROL); | ||
199 | mrst_checkintr(mrst, rtc_control); | ||
200 | } | ||
201 | |||
202 | static int mrst_set_alarm(struct device *dev, struct rtc_wkalrm *t) | ||
203 | { | ||
204 | struct mrst_rtc *mrst = dev_get_drvdata(dev); | ||
205 | unsigned char hrs, min, sec; | ||
206 | int ret = 0; | ||
207 | |||
208 | if (!mrst->irq) | ||
209 | return -EIO; | ||
210 | |||
211 | hrs = t->time.tm_hour; | ||
212 | min = t->time.tm_min; | ||
213 | sec = t->time.tm_sec; | ||
214 | |||
215 | spin_lock_irq(&rtc_lock); | ||
216 | /* Next rtc irq must not be from previous alarm setting */ | ||
217 | mrst_irq_disable(mrst, RTC_AIE); | ||
218 | |||
219 | /* Update alarm */ | ||
220 | vrtc_cmos_write(hrs, RTC_HOURS_ALARM); | ||
221 | vrtc_cmos_write(min, RTC_MINUTES_ALARM); | ||
222 | vrtc_cmos_write(sec, RTC_SECONDS_ALARM); | ||
223 | |||
224 | spin_unlock_irq(&rtc_lock); | ||
225 | |||
226 | ret = intel_scu_ipc_simple_command(IPCMSG_VRTC, IPC_CMD_VRTC_SETALARM); | ||
227 | if (ret) | ||
228 | return ret; | ||
229 | |||
230 | spin_lock_irq(&rtc_lock); | ||
231 | if (t->enabled) | ||
232 | mrst_irq_enable(mrst, RTC_AIE); | ||
233 | |||
234 | spin_unlock_irq(&rtc_lock); | ||
235 | |||
236 | return 0; | ||
237 | } | ||
238 | |||
239 | static int mrst_irq_set_state(struct device *dev, int enabled) | ||
240 | { | ||
241 | struct mrst_rtc *mrst = dev_get_drvdata(dev); | ||
242 | unsigned long flags; | ||
243 | |||
244 | if (!mrst->irq) | ||
245 | return -ENXIO; | ||
246 | |||
247 | spin_lock_irqsave(&rtc_lock, flags); | ||
248 | |||
249 | if (enabled) | ||
250 | mrst_irq_enable(mrst, RTC_PIE); | ||
251 | else | ||
252 | mrst_irq_disable(mrst, RTC_PIE); | ||
253 | |||
254 | spin_unlock_irqrestore(&rtc_lock, flags); | ||
255 | return 0; | ||
256 | } | ||
257 | |||
258 | #if defined(CONFIG_RTC_INTF_DEV) || defined(CONFIG_RTC_INTF_DEV_MODULE) | ||
259 | |||
260 | /* Currently, the vRTC doesn't support UIE ON/OFF */ | ||
261 | static int | ||
262 | mrst_rtc_ioctl(struct device *dev, unsigned int cmd, unsigned long arg) | ||
263 | { | ||
264 | struct mrst_rtc *mrst = dev_get_drvdata(dev); | ||
265 | unsigned long flags; | ||
266 | |||
267 | switch (cmd) { | ||
268 | case RTC_AIE_OFF: | ||
269 | case RTC_AIE_ON: | ||
270 | if (!mrst->irq) | ||
271 | return -EINVAL; | ||
272 | break; | ||
273 | default: | ||
274 | /* PIE ON/OFF is handled by mrst_irq_set_state() */ | ||
275 | return -ENOIOCTLCMD; | ||
276 | } | ||
277 | |||
278 | spin_lock_irqsave(&rtc_lock, flags); | ||
279 | switch (cmd) { | ||
280 | case RTC_AIE_OFF: /* alarm off */ | ||
281 | mrst_irq_disable(mrst, RTC_AIE); | ||
282 | break; | ||
283 | case RTC_AIE_ON: /* alarm on */ | ||
284 | mrst_irq_enable(mrst, RTC_AIE); | ||
285 | break; | ||
286 | } | ||
287 | spin_unlock_irqrestore(&rtc_lock, flags); | ||
288 | return 0; | ||
289 | } | ||
290 | |||
291 | #else | ||
292 | #define mrst_rtc_ioctl NULL | ||
293 | #endif | ||
294 | |||
295 | #if defined(CONFIG_RTC_INTF_PROC) || defined(CONFIG_RTC_INTF_PROC_MODULE) | ||
296 | |||
297 | static int mrst_procfs(struct device *dev, struct seq_file *seq) | ||
298 | { | ||
299 | unsigned char rtc_control, valid; | ||
300 | |||
301 | spin_lock_irq(&rtc_lock); | ||
302 | rtc_control = vrtc_cmos_read(RTC_CONTROL); | ||
303 | valid = vrtc_cmos_read(RTC_VALID); | ||
304 | spin_unlock_irq(&rtc_lock); | ||
305 | |||
306 | return seq_printf(seq, | ||
307 | "periodic_IRQ\t: %s\n" | ||
308 | "alarm\t\t: %s\n" | ||
309 | "BCD\t\t: no\n" | ||
310 | "periodic_freq\t: daily (not adjustable)\n", | ||
311 | (rtc_control & RTC_PIE) ? "on" : "off", | ||
312 | (rtc_control & RTC_AIE) ? "on" : "off"); | ||
313 | } | ||
314 | |||
315 | #else | ||
316 | #define mrst_procfs NULL | ||
317 | #endif | ||
318 | |||
319 | static const struct rtc_class_ops mrst_rtc_ops = { | ||
320 | .ioctl = mrst_rtc_ioctl, | ||
321 | .read_time = mrst_read_time, | ||
322 | .set_time = mrst_set_time, | ||
323 | .read_alarm = mrst_read_alarm, | ||
324 | .set_alarm = mrst_set_alarm, | ||
325 | .proc = mrst_procfs, | ||
326 | .irq_set_state = mrst_irq_set_state, | ||
327 | }; | ||
328 | |||
329 | static struct mrst_rtc mrst_rtc; | ||
330 | |||
331 | /* | ||
332 | * When vRTC IRQ is captured by SCU FW, FW will clear the AIE bit in | ||
333 | * Reg B, so no need for this driver to clear it | ||
334 | */ | ||
335 | static irqreturn_t mrst_rtc_irq(int irq, void *p) | ||
336 | { | ||
337 | u8 irqstat; | ||
338 | |||
339 | spin_lock(&rtc_lock); | ||
340 | /* This read will clear all IRQ flags inside Reg C */ | ||
341 | irqstat = vrtc_cmos_read(RTC_INTR_FLAGS); | ||
342 | spin_unlock(&rtc_lock); | ||
343 | |||
344 | irqstat &= RTC_IRQMASK | RTC_IRQF; | ||
345 | if (is_intr(irqstat)) { | ||
346 | rtc_update_irq(p, 1, irqstat); | ||
347 | return IRQ_HANDLED; | ||
348 | } | ||
349 | return IRQ_NONE; | ||
350 | } | ||
351 | |||
352 | static int __init | ||
353 | vrtc_mrst_do_probe(struct device *dev, struct resource *iomem, int rtc_irq) | ||
354 | { | ||
355 | int retval = 0; | ||
356 | unsigned char rtc_control; | ||
357 | |||
358 | /* There can be only one ... */ | ||
359 | if (mrst_rtc.dev) | ||
360 | return -EBUSY; | ||
361 | |||
362 | if (!iomem) | ||
363 | return -ENODEV; | ||
364 | |||
365 | iomem = request_mem_region(iomem->start, | ||
366 | iomem->end + 1 - iomem->start, | ||
367 | driver_name); | ||
368 | if (!iomem) { | ||
369 | dev_dbg(dev, "i/o mem already in use.\n"); | ||
370 | return -EBUSY; | ||
371 | } | ||
372 | |||
373 | mrst_rtc.irq = rtc_irq; | ||
374 | mrst_rtc.iomem = iomem; | ||
375 | |||
376 | mrst_rtc.rtc = rtc_device_register(driver_name, dev, | ||
377 | &mrst_rtc_ops, THIS_MODULE); | ||
378 | if (IS_ERR(mrst_rtc.rtc)) { | ||
379 | retval = PTR_ERR(mrst_rtc.rtc); | ||
380 | goto cleanup0; | ||
381 | } | ||
382 | |||
383 | mrst_rtc.dev = dev; | ||
384 | dev_set_drvdata(dev, &mrst_rtc); | ||
385 | rename_region(iomem, dev_name(&mrst_rtc.rtc->dev)); | ||
386 | |||
387 | spin_lock_irq(&rtc_lock); | ||
388 | mrst_irq_disable(&mrst_rtc, RTC_PIE | RTC_AIE); | ||
389 | rtc_control = vrtc_cmos_read(RTC_CONTROL); | ||
390 | spin_unlock_irq(&rtc_lock); | ||
391 | |||
392 | if (!(rtc_control & RTC_24H) || (rtc_control & (RTC_DM_BINARY))) | ||
393 | dev_dbg(dev, "TODO: support more than 24-hr BCD mode\n"); | ||
394 | |||
395 | if (rtc_irq) { | ||
396 | retval = request_irq(rtc_irq, mrst_rtc_irq, | ||
397 | IRQF_DISABLED, dev_name(&mrst_rtc.rtc->dev), | ||
398 | mrst_rtc.rtc); | ||
399 | if (retval < 0) { | ||
400 | dev_dbg(dev, "IRQ %d is already in use, err %d\n", | ||
401 | rtc_irq, retval); | ||
402 | goto cleanup1; | ||
403 | } | ||
404 | } | ||
405 | dev_dbg(dev, "initialised\n"); | ||
406 | return 0; | ||
407 | |||
408 | cleanup1: | ||
409 | mrst_rtc.dev = NULL; | ||
410 | rtc_device_unregister(mrst_rtc.rtc); | ||
411 | cleanup0: | ||
412 | release_region(iomem->start, iomem->end + 1 - iomem->start); | ||
413 | dev_err(dev, "rtc-mrst: unable to initialise\n"); | ||
414 | return retval; | ||
415 | } | ||
416 | |||
417 | static void rtc_mrst_do_shutdown(void) | ||
418 | { | ||
419 | spin_lock_irq(&rtc_lock); | ||
420 | mrst_irq_disable(&mrst_rtc, RTC_IRQMASK); | ||
421 | spin_unlock_irq(&rtc_lock); | ||
422 | } | ||
423 | |||
424 | static void __exit rtc_mrst_do_remove(struct device *dev) | ||
425 | { | ||
426 | struct mrst_rtc *mrst = dev_get_drvdata(dev); | ||
427 | struct resource *iomem; | ||
428 | |||
429 | rtc_mrst_do_shutdown(); | ||
430 | |||
431 | if (mrst->irq) | ||
432 | free_irq(mrst->irq, mrst->rtc); | ||
433 | |||
434 | rtc_device_unregister(mrst->rtc); | ||
435 | mrst->rtc = NULL; | ||
436 | |||
437 | iomem = mrst->iomem; | ||
438 | release_region(iomem->start, iomem->end + 1 - iomem->start); | ||
439 | mrst->iomem = NULL; | ||
440 | |||
441 | mrst->dev = NULL; | ||
442 | dev_set_drvdata(dev, NULL); | ||
443 | } | ||
444 | |||
445 | #ifdef CONFIG_PM | ||
446 | static int mrst_suspend(struct device *dev, pm_message_t mesg) | ||
447 | { | ||
448 | struct mrst_rtc *mrst = dev_get_drvdata(dev); | ||
449 | unsigned char tmp; | ||
450 | |||
451 | /* Only the alarm might be a wakeup event source */ | ||
452 | spin_lock_irq(&rtc_lock); | ||
453 | mrst->suspend_ctrl = tmp = vrtc_cmos_read(RTC_CONTROL); | ||
454 | if (tmp & (RTC_PIE | RTC_AIE)) { | ||
455 | unsigned char mask; | ||
456 | |||
457 | if (device_may_wakeup(dev)) | ||
458 | mask = RTC_IRQMASK & ~RTC_AIE; | ||
459 | else | ||
460 | mask = RTC_IRQMASK; | ||
461 | tmp &= ~mask; | ||
462 | vrtc_cmos_write(tmp, RTC_CONTROL); | ||
463 | |||
464 | mrst_checkintr(mrst, tmp); | ||
465 | } | ||
466 | spin_unlock_irq(&rtc_lock); | ||
467 | |||
468 | if (tmp & RTC_AIE) { | ||
469 | mrst->enabled_wake = 1; | ||
470 | enable_irq_wake(mrst->irq); | ||
471 | } | ||
472 | |||
473 | dev_dbg(&mrst_rtc.rtc->dev, "suspend%s, ctrl %02x\n", | ||
474 | (tmp & RTC_AIE) ? ", alarm may wake" : "", | ||
475 | tmp); | ||
476 | |||
477 | return 0; | ||
478 | } | ||
479 | |||
480 | /* | ||
481 | * We want RTC alarms to wake us from the deep power saving state | ||
482 | */ | ||
483 | static inline int mrst_poweroff(struct device *dev) | ||
484 | { | ||
485 | return mrst_suspend(dev, PMSG_HIBERNATE); | ||
486 | } | ||
487 | |||
488 | static int mrst_resume(struct device *dev) | ||
489 | { | ||
490 | struct mrst_rtc *mrst = dev_get_drvdata(dev); | ||
491 | unsigned char tmp = mrst->suspend_ctrl; | ||
492 | |||
493 | /* Re-enable any irqs previously active */ | ||
494 | if (tmp & RTC_IRQMASK) { | ||
495 | unsigned char mask; | ||
496 | |||
497 | if (mrst->enabled_wake) { | ||
498 | disable_irq_wake(mrst->irq); | ||
499 | mrst->enabled_wake = 0; | ||
500 | } | ||
501 | |||
502 | spin_lock_irq(&rtc_lock); | ||
503 | do { | ||
504 | vrtc_cmos_write(tmp, RTC_CONTROL); | ||
505 | |||
506 | mask = vrtc_cmos_read(RTC_INTR_FLAGS); | ||
507 | mask &= (tmp & RTC_IRQMASK) | RTC_IRQF; | ||
508 | if (!is_intr(mask)) | ||
509 | break; | ||
510 | |||
511 | rtc_update_irq(mrst->rtc, 1, mask); | ||
512 | tmp &= ~RTC_AIE; | ||
513 | } while (mask & RTC_AIE); | ||
514 | spin_unlock_irq(&rtc_lock); | ||
515 | } | ||
516 | |||
517 | dev_dbg(&mrst_rtc.rtc->dev, "resume, ctrl %02x\n", tmp); | ||
518 | |||
519 | return 0; | ||
520 | } | ||
521 | |||
522 | #else | ||
523 | #define mrst_suspend NULL | ||
524 | #define mrst_resume NULL | ||
525 | |||
526 | static inline int mrst_poweroff(struct device *dev) | ||
527 | { | ||
528 | return -ENOSYS; | ||
529 | } | ||
530 | |||
531 | #endif | ||
532 | |||
533 | static int __init vrtc_mrst_platform_probe(struct platform_device *pdev) | ||
534 | { | ||
535 | return vrtc_mrst_do_probe(&pdev->dev, | ||
536 | platform_get_resource(pdev, IORESOURCE_MEM, 0), | ||
537 | platform_get_irq(pdev, 0)); | ||
538 | } | ||
539 | |||
540 | static int __exit vrtc_mrst_platform_remove(struct platform_device *pdev) | ||
541 | { | ||
542 | rtc_mrst_do_remove(&pdev->dev); | ||
543 | return 0; | ||
544 | } | ||
545 | |||
546 | static void vrtc_mrst_platform_shutdown(struct platform_device *pdev) | ||
547 | { | ||
548 | if (system_state == SYSTEM_POWER_OFF && !mrst_poweroff(&pdev->dev)) | ||
549 | return; | ||
550 | |||
551 | rtc_mrst_do_shutdown(); | ||
552 | } | ||
553 | |||
554 | MODULE_ALIAS("platform:vrtc_mrst"); | ||
555 | |||
556 | static struct platform_driver vrtc_mrst_platform_driver = { | ||
557 | .probe = vrtc_mrst_platform_probe, | ||
558 | .remove = __exit_p(vrtc_mrst_platform_remove), | ||
559 | .shutdown = vrtc_mrst_platform_shutdown, | ||
560 | .driver = { | ||
561 | .name = (char *) driver_name, | ||
562 | .suspend = mrst_suspend, | ||
563 | .resume = mrst_resume, | ||
564 | } | ||
565 | }; | ||
566 | |||
567 | static int __init vrtc_mrst_init(void) | ||
568 | { | ||
569 | return platform_driver_register(&vrtc_mrst_platform_driver); | ||
570 | } | ||
571 | |||
572 | static void __exit vrtc_mrst_exit(void) | ||
573 | { | ||
574 | platform_driver_unregister(&vrtc_mrst_platform_driver); | ||
575 | } | ||
576 | |||
577 | module_init(vrtc_mrst_init); | ||
578 | module_exit(vrtc_mrst_exit); | ||
579 | |||
580 | MODULE_AUTHOR("Jacob Pan; Feng Tang"); | ||
581 | MODULE_DESCRIPTION("Driver for Moorestown virtual RTC"); | ||
582 | MODULE_LICENSE("GPL"); | ||
diff --git a/drivers/rtc/rtc-rx8025.c b/drivers/rtc/rtc-rx8025.c index 1146e3522d3c..af32a62e12a8 100644 --- a/drivers/rtc/rtc-rx8025.c +++ b/drivers/rtc/rtc-rx8025.c | |||
@@ -650,7 +650,7 @@ static int __devexit rx8025_remove(struct i2c_client *client) | |||
650 | mutex_unlock(lock); | 650 | mutex_unlock(lock); |
651 | 651 | ||
652 | free_irq(client->irq, client); | 652 | free_irq(client->irq, client); |
653 | flush_scheduled_work(); | 653 | cancel_work_sync(&rx8025->work); |
654 | } | 654 | } |
655 | 655 | ||
656 | rx8025_sysfs_unregister(&client->dev); | 656 | rx8025_sysfs_unregister(&client->dev); |
diff --git a/drivers/rtc/rtc-sa1100.c b/drivers/rtc/rtc-sa1100.c index e4a44b641702..88ea52b8647a 100644 --- a/drivers/rtc/rtc-sa1100.c +++ b/drivers/rtc/rtc-sa1100.c | |||
@@ -39,10 +39,10 @@ | |||
39 | #include <mach/regs-ost.h> | 39 | #include <mach/regs-ost.h> |
40 | #endif | 40 | #endif |
41 | 41 | ||
42 | #define RTC_DEF_DIVIDER 32768 - 1 | 42 | #define RTC_DEF_DIVIDER (32768 - 1) |
43 | #define RTC_DEF_TRIM 0 | 43 | #define RTC_DEF_TRIM 0 |
44 | 44 | ||
45 | static unsigned long rtc_freq = 1024; | 45 | static const unsigned long RTC_FREQ = 1024; |
46 | static unsigned long timer_freq; | 46 | static unsigned long timer_freq; |
47 | static struct rtc_time rtc_alarm; | 47 | static struct rtc_time rtc_alarm; |
48 | static DEFINE_SPINLOCK(sa1100_rtc_lock); | 48 | static DEFINE_SPINLOCK(sa1100_rtc_lock); |
@@ -61,7 +61,8 @@ static inline int rtc_periodic_alarm(struct rtc_time *tm) | |||
61 | * Calculate the next alarm time given the requested alarm time mask | 61 | * Calculate the next alarm time given the requested alarm time mask |
62 | * and the current time. | 62 | * and the current time. |
63 | */ | 63 | */ |
64 | static void rtc_next_alarm_time(struct rtc_time *next, struct rtc_time *now, struct rtc_time *alrm) | 64 | static void rtc_next_alarm_time(struct rtc_time *next, struct rtc_time *now, |
65 | struct rtc_time *alrm) | ||
65 | { | 66 | { |
66 | unsigned long next_time; | 67 | unsigned long next_time; |
67 | unsigned long now_time; | 68 | unsigned long now_time; |
@@ -116,7 +117,23 @@ static irqreturn_t sa1100_rtc_interrupt(int irq, void *dev_id) | |||
116 | rtsr = RTSR; | 117 | rtsr = RTSR; |
117 | /* clear interrupt sources */ | 118 | /* clear interrupt sources */ |
118 | RTSR = 0; | 119 | RTSR = 0; |
119 | RTSR = (RTSR_AL | RTSR_HZ) & (rtsr >> 2); | 120 | /* Fix for a nasty initialization problem the in SA11xx RTSR register. |
121 | * See also the comments in sa1100_rtc_probe(). */ | ||
122 | if (rtsr & (RTSR_ALE | RTSR_HZE)) { | ||
123 | /* This is the original code, before there was the if test | ||
124 | * above. This code does not clear interrupts that were not | ||
125 | * enabled. */ | ||
126 | RTSR = (RTSR_AL | RTSR_HZ) & (rtsr >> 2); | ||
127 | } else { | ||
128 | /* For some reason, it is possible to enter this routine | ||
129 | * without interruptions enabled, it has been tested with | ||
130 | * several units (Bug in SA11xx chip?). | ||
131 | * | ||
132 | * This situation leads to an infinite "loop" of interrupt | ||
133 | * routine calling and as a result the processor seems to | ||
134 | * lock on its first call to open(). */ | ||
135 | RTSR = RTSR_AL | RTSR_HZ; | ||
136 | } | ||
120 | 137 | ||
121 | /* clear alarm interrupt if it has occurred */ | 138 | /* clear alarm interrupt if it has occurred */ |
122 | if (rtsr & RTSR_AL) | 139 | if (rtsr & RTSR_AL) |
@@ -139,8 +156,58 @@ static irqreturn_t sa1100_rtc_interrupt(int irq, void *dev_id) | |||
139 | return IRQ_HANDLED; | 156 | return IRQ_HANDLED; |
140 | } | 157 | } |
141 | 158 | ||
159 | static int sa1100_irq_set_freq(struct device *dev, int freq) | ||
160 | { | ||
161 | if (freq < 1 || freq > timer_freq) { | ||
162 | return -EINVAL; | ||
163 | } else { | ||
164 | struct rtc_device *rtc = (struct rtc_device *)dev; | ||
165 | |||
166 | rtc->irq_freq = freq; | ||
167 | |||
168 | return 0; | ||
169 | } | ||
170 | } | ||
171 | |||
142 | static int rtc_timer1_count; | 172 | static int rtc_timer1_count; |
143 | 173 | ||
174 | static int sa1100_irq_set_state(struct device *dev, int enabled) | ||
175 | { | ||
176 | spin_lock_irq(&sa1100_rtc_lock); | ||
177 | if (enabled) { | ||
178 | struct rtc_device *rtc = (struct rtc_device *)dev; | ||
179 | |||
180 | OSMR1 = timer_freq / rtc->irq_freq + OSCR; | ||
181 | OIER |= OIER_E1; | ||
182 | rtc_timer1_count = 1; | ||
183 | } else { | ||
184 | OIER &= ~OIER_E1; | ||
185 | } | ||
186 | spin_unlock_irq(&sa1100_rtc_lock); | ||
187 | |||
188 | return 0; | ||
189 | } | ||
190 | |||
191 | static inline int sa1100_timer1_retrigger(struct rtc_device *rtc) | ||
192 | { | ||
193 | unsigned long diff; | ||
194 | unsigned long period = timer_freq / rtc->irq_freq; | ||
195 | |||
196 | spin_lock_irq(&sa1100_rtc_lock); | ||
197 | |||
198 | do { | ||
199 | OSMR1 += period; | ||
200 | diff = OSMR1 - OSCR; | ||
201 | /* If OSCR > OSMR1, diff is a very large number (unsigned | ||
202 | * math). This means we have a lost interrupt. */ | ||
203 | } while (diff > period); | ||
204 | OIER |= OIER_E1; | ||
205 | |||
206 | spin_unlock_irq(&sa1100_rtc_lock); | ||
207 | |||
208 | return 0; | ||
209 | } | ||
210 | |||
144 | static irqreturn_t timer1_interrupt(int irq, void *dev_id) | 211 | static irqreturn_t timer1_interrupt(int irq, void *dev_id) |
145 | { | 212 | { |
146 | struct platform_device *pdev = to_platform_device(dev_id); | 213 | struct platform_device *pdev = to_platform_device(dev_id); |
@@ -158,7 +225,11 @@ static irqreturn_t timer1_interrupt(int irq, void *dev_id) | |||
158 | rtc_update_irq(rtc, rtc_timer1_count, RTC_PF | RTC_IRQF); | 225 | rtc_update_irq(rtc, rtc_timer1_count, RTC_PF | RTC_IRQF); |
159 | 226 | ||
160 | if (rtc_timer1_count == 1) | 227 | if (rtc_timer1_count == 1) |
161 | rtc_timer1_count = (rtc_freq * ((1 << 30) / (timer_freq >> 2))); | 228 | rtc_timer1_count = |
229 | (rtc->irq_freq * ((1 << 30) / (timer_freq >> 2))); | ||
230 | |||
231 | /* retrigger. */ | ||
232 | sa1100_timer1_retrigger(rtc); | ||
162 | 233 | ||
163 | return IRQ_HANDLED; | 234 | return IRQ_HANDLED; |
164 | } | 235 | } |
@@ -166,8 +237,10 @@ static irqreturn_t timer1_interrupt(int irq, void *dev_id) | |||
166 | static int sa1100_rtc_read_callback(struct device *dev, int data) | 237 | static int sa1100_rtc_read_callback(struct device *dev, int data) |
167 | { | 238 | { |
168 | if (data & RTC_PF) { | 239 | if (data & RTC_PF) { |
240 | struct rtc_device *rtc = (struct rtc_device *)dev; | ||
241 | |||
169 | /* interpolate missed periods and set match for the next */ | 242 | /* interpolate missed periods and set match for the next */ |
170 | unsigned long period = timer_freq / rtc_freq; | 243 | unsigned long period = timer_freq / rtc->irq_freq; |
171 | unsigned long oscr = OSCR; | 244 | unsigned long oscr = OSCR; |
172 | unsigned long osmr1 = OSMR1; | 245 | unsigned long osmr1 = OSMR1; |
173 | unsigned long missed = (oscr - osmr1)/period; | 246 | unsigned long missed = (oscr - osmr1)/period; |
@@ -178,7 +251,7 @@ static int sa1100_rtc_read_callback(struct device *dev, int data) | |||
178 | * Here we compare (match - OSCR) 8 instead of 0 -- | 251 | * Here we compare (match - OSCR) 8 instead of 0 -- |
179 | * see comment in pxa_timer_interrupt() for explanation. | 252 | * see comment in pxa_timer_interrupt() for explanation. |
180 | */ | 253 | */ |
181 | while( (signed long)((osmr1 = OSMR1) - OSCR) <= 8 ) { | 254 | while ((signed long)((osmr1 = OSMR1) - OSCR) <= 8) { |
182 | data += 0x100; | 255 | data += 0x100; |
183 | OSSR = OSSR_M1; /* clear match on timer 1 */ | 256 | OSSR = OSSR_M1; /* clear match on timer 1 */ |
184 | OSMR1 = osmr1 + period; | 257 | OSMR1 = osmr1 + period; |
@@ -190,25 +263,29 @@ static int sa1100_rtc_read_callback(struct device *dev, int data) | |||
190 | static int sa1100_rtc_open(struct device *dev) | 263 | static int sa1100_rtc_open(struct device *dev) |
191 | { | 264 | { |
192 | int ret; | 265 | int ret; |
266 | struct rtc_device *rtc = (struct rtc_device *)dev; | ||
193 | 267 | ||
194 | ret = request_irq(IRQ_RTC1Hz, sa1100_rtc_interrupt, IRQF_DISABLED, | 268 | ret = request_irq(IRQ_RTC1Hz, sa1100_rtc_interrupt, IRQF_DISABLED, |
195 | "rtc 1Hz", dev); | 269 | "rtc 1Hz", dev); |
196 | if (ret) { | 270 | if (ret) { |
197 | dev_err(dev, "IRQ %d already in use.\n", IRQ_RTC1Hz); | 271 | dev_err(dev, "IRQ %d already in use.\n", IRQ_RTC1Hz); |
198 | goto fail_ui; | 272 | goto fail_ui; |
199 | } | 273 | } |
200 | ret = request_irq(IRQ_RTCAlrm, sa1100_rtc_interrupt, IRQF_DISABLED, | 274 | ret = request_irq(IRQ_RTCAlrm, sa1100_rtc_interrupt, IRQF_DISABLED, |
201 | "rtc Alrm", dev); | 275 | "rtc Alrm", dev); |
202 | if (ret) { | 276 | if (ret) { |
203 | dev_err(dev, "IRQ %d already in use.\n", IRQ_RTCAlrm); | 277 | dev_err(dev, "IRQ %d already in use.\n", IRQ_RTCAlrm); |
204 | goto fail_ai; | 278 | goto fail_ai; |
205 | } | 279 | } |
206 | ret = request_irq(IRQ_OST1, timer1_interrupt, IRQF_DISABLED, | 280 | ret = request_irq(IRQ_OST1, timer1_interrupt, IRQF_DISABLED, |
207 | "rtc timer", dev); | 281 | "rtc timer", dev); |
208 | if (ret) { | 282 | if (ret) { |
209 | dev_err(dev, "IRQ %d already in use.\n", IRQ_OST1); | 283 | dev_err(dev, "IRQ %d already in use.\n", IRQ_OST1); |
210 | goto fail_pi; | 284 | goto fail_pi; |
211 | } | 285 | } |
286 | rtc->max_user_freq = RTC_FREQ; | ||
287 | sa1100_irq_set_freq(dev, RTC_FREQ); | ||
288 | |||
212 | return 0; | 289 | return 0; |
213 | 290 | ||
214 | fail_pi: | 291 | fail_pi: |
@@ -236,7 +313,7 @@ static void sa1100_rtc_release(struct device *dev) | |||
236 | static int sa1100_rtc_ioctl(struct device *dev, unsigned int cmd, | 313 | static int sa1100_rtc_ioctl(struct device *dev, unsigned int cmd, |
237 | unsigned long arg) | 314 | unsigned long arg) |
238 | { | 315 | { |
239 | switch(cmd) { | 316 | switch (cmd) { |
240 | case RTC_AIE_OFF: | 317 | case RTC_AIE_OFF: |
241 | spin_lock_irq(&sa1100_rtc_lock); | 318 | spin_lock_irq(&sa1100_rtc_lock); |
242 | RTSR &= ~RTSR_ALE; | 319 | RTSR &= ~RTSR_ALE; |
@@ -257,25 +334,6 @@ static int sa1100_rtc_ioctl(struct device *dev, unsigned int cmd, | |||
257 | RTSR |= RTSR_HZE; | 334 | RTSR |= RTSR_HZE; |
258 | spin_unlock_irq(&sa1100_rtc_lock); | 335 | spin_unlock_irq(&sa1100_rtc_lock); |
259 | return 0; | 336 | return 0; |
260 | case RTC_PIE_OFF: | ||
261 | spin_lock_irq(&sa1100_rtc_lock); | ||
262 | OIER &= ~OIER_E1; | ||
263 | spin_unlock_irq(&sa1100_rtc_lock); | ||
264 | return 0; | ||
265 | case RTC_PIE_ON: | ||
266 | spin_lock_irq(&sa1100_rtc_lock); | ||
267 | OSMR1 = timer_freq / rtc_freq + OSCR; | ||
268 | OIER |= OIER_E1; | ||
269 | rtc_timer1_count = 1; | ||
270 | spin_unlock_irq(&sa1100_rtc_lock); | ||
271 | return 0; | ||
272 | case RTC_IRQP_READ: | ||
273 | return put_user(rtc_freq, (unsigned long *)arg); | ||
274 | case RTC_IRQP_SET: | ||
275 | if (arg < 1 || arg > timer_freq) | ||
276 | return -EINVAL; | ||
277 | rtc_freq = arg; | ||
278 | return 0; | ||
279 | } | 337 | } |
280 | return -ENOIOCTLCMD; | 338 | return -ENOIOCTLCMD; |
281 | } | 339 | } |
@@ -327,12 +385,15 @@ static int sa1100_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alrm) | |||
327 | 385 | ||
328 | static int sa1100_rtc_proc(struct device *dev, struct seq_file *seq) | 386 | static int sa1100_rtc_proc(struct device *dev, struct seq_file *seq) |
329 | { | 387 | { |
388 | struct rtc_device *rtc = (struct rtc_device *)dev; | ||
389 | |||
330 | seq_printf(seq, "trim/divider\t: 0x%08x\n", (u32) RTTR); | 390 | seq_printf(seq, "trim/divider\t: 0x%08x\n", (u32) RTTR); |
331 | seq_printf(seq, "update_IRQ\t: %s\n", | 391 | seq_printf(seq, "update_IRQ\t: %s\n", |
332 | (RTSR & RTSR_HZE) ? "yes" : "no"); | 392 | (RTSR & RTSR_HZE) ? "yes" : "no"); |
333 | seq_printf(seq, "periodic_IRQ\t: %s\n", | 393 | seq_printf(seq, "periodic_IRQ\t: %s\n", |
334 | (OIER & OIER_E1) ? "yes" : "no"); | 394 | (OIER & OIER_E1) ? "yes" : "no"); |
335 | seq_printf(seq, "periodic_freq\t: %ld\n", rtc_freq); | 395 | seq_printf(seq, "periodic_freq\t: %d\n", rtc->irq_freq); |
396 | seq_printf(seq, "RTSR\t\t: 0x%08x\n", (u32)RTSR); | ||
336 | 397 | ||
337 | return 0; | 398 | return 0; |
338 | } | 399 | } |
@@ -347,6 +408,8 @@ static const struct rtc_class_ops sa1100_rtc_ops = { | |||
347 | .read_alarm = sa1100_rtc_read_alarm, | 408 | .read_alarm = sa1100_rtc_read_alarm, |
348 | .set_alarm = sa1100_rtc_set_alarm, | 409 | .set_alarm = sa1100_rtc_set_alarm, |
349 | .proc = sa1100_rtc_proc, | 410 | .proc = sa1100_rtc_proc, |
411 | .irq_set_freq = sa1100_irq_set_freq, | ||
412 | .irq_set_state = sa1100_irq_set_state, | ||
350 | }; | 413 | }; |
351 | 414 | ||
352 | static int sa1100_rtc_probe(struct platform_device *pdev) | 415 | static int sa1100_rtc_probe(struct platform_device *pdev) |
@@ -364,7 +427,8 @@ static int sa1100_rtc_probe(struct platform_device *pdev) | |||
364 | */ | 427 | */ |
365 | if (RTTR == 0) { | 428 | if (RTTR == 0) { |
366 | RTTR = RTC_DEF_DIVIDER + (RTC_DEF_TRIM << 16); | 429 | RTTR = RTC_DEF_DIVIDER + (RTC_DEF_TRIM << 16); |
367 | dev_warn(&pdev->dev, "warning: initializing default clock divider/trim value\n"); | 430 | dev_warn(&pdev->dev, "warning: " |
431 | "initializing default clock divider/trim value\n"); | ||
368 | /* The current RTC value probably doesn't make sense either */ | 432 | /* The current RTC value probably doesn't make sense either */ |
369 | RCNR = 0; | 433 | RCNR = 0; |
370 | } | 434 | } |
@@ -372,13 +436,42 @@ static int sa1100_rtc_probe(struct platform_device *pdev) | |||
372 | device_init_wakeup(&pdev->dev, 1); | 436 | device_init_wakeup(&pdev->dev, 1); |
373 | 437 | ||
374 | rtc = rtc_device_register(pdev->name, &pdev->dev, &sa1100_rtc_ops, | 438 | rtc = rtc_device_register(pdev->name, &pdev->dev, &sa1100_rtc_ops, |
375 | THIS_MODULE); | 439 | THIS_MODULE); |
376 | 440 | ||
377 | if (IS_ERR(rtc)) | 441 | if (IS_ERR(rtc)) |
378 | return PTR_ERR(rtc); | 442 | return PTR_ERR(rtc); |
379 | 443 | ||
380 | platform_set_drvdata(pdev, rtc); | 444 | platform_set_drvdata(pdev, rtc); |
381 | 445 | ||
446 | /* Set the irq_freq */ | ||
447 | /*TODO: Find out who is messing with this value after we initialize | ||
448 | * it here.*/ | ||
449 | rtc->irq_freq = RTC_FREQ; | ||
450 | |||
451 | /* Fix for a nasty initialization problem the in SA11xx RTSR register. | ||
452 | * See also the comments in sa1100_rtc_interrupt(). | ||
453 | * | ||
454 | * Sometimes bit 1 of the RTSR (RTSR_HZ) will wake up 1, which means an | ||
455 | * interrupt pending, even though interrupts were never enabled. | ||
456 | * In this case, this bit it must be reset before enabling | ||
457 | * interruptions to avoid a nonexistent interrupt to occur. | ||
458 | * | ||
459 | * In principle, the same problem would apply to bit 0, although it has | ||
460 | * never been observed to happen. | ||
461 | * | ||
462 | * This issue is addressed both here and in sa1100_rtc_interrupt(). | ||
463 | * If the issue is not addressed here, in the times when the processor | ||
464 | * wakes up with the bit set there will be one spurious interrupt. | ||
465 | * | ||
466 | * The issue is also dealt with in sa1100_rtc_interrupt() to be on the | ||
467 | * safe side, once the condition that lead to this strange | ||
468 | * initialization is unknown and could in principle happen during | ||
469 | * normal processing. | ||
470 | * | ||
471 | * Notice that clearing bit 1 and 0 is accomplished by writting ONES to | ||
472 | * the corresponding bits in RTSR. */ | ||
473 | RTSR = RTSR_AL | RTSR_HZ; | ||
474 | |||
382 | return 0; | 475 | return 0; |
383 | } | 476 | } |
384 | 477 | ||
@@ -386,7 +479,7 @@ static int sa1100_rtc_remove(struct platform_device *pdev) | |||
386 | { | 479 | { |
387 | struct rtc_device *rtc = platform_get_drvdata(pdev); | 480 | struct rtc_device *rtc = platform_get_drvdata(pdev); |
388 | 481 | ||
389 | if (rtc) | 482 | if (rtc) |
390 | rtc_device_unregister(rtc); | 483 | rtc_device_unregister(rtc); |
391 | 484 | ||
392 | return 0; | 485 | return 0; |