diff options
Diffstat (limited to 'drivers/rtc')
| -rw-r--r-- | drivers/rtc/Kconfig | 6 | ||||
| -rw-r--r-- | drivers/rtc/Makefile | 2 | ||||
| -rw-r--r-- | drivers/rtc/rtc-pcf50633.c | 5 | ||||
| -rw-r--r-- | drivers/rtc/rtc-pxa.c | 2 | ||||
| -rw-r--r-- | drivers/rtc/rtc-sa1100.c | 2 | ||||
| -rw-r--r-- | drivers/rtc/rtc-sh.c | 2 | ||||
| -rw-r--r-- | drivers/rtc/rtc-twl.c (renamed from drivers/rtc/rtc-twl4030.c) | 284 | ||||
| -rw-r--r-- | drivers/rtc/rtc-wm831x.c | 2 | ||||
| -rw-r--r-- | drivers/rtc/rtc-wm8350.c | 25 |
9 files changed, 199 insertions, 131 deletions
diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig index f2e1004d12c7..71fbd6e8edf7 100644 --- a/drivers/rtc/Kconfig +++ b/drivers/rtc/Kconfig | |||
| @@ -258,14 +258,14 @@ config RTC_DRV_TWL92330 | |||
| 258 | the Menelaus driver; it's not separate module. | 258 | the Menelaus driver; it's not separate module. |
| 259 | 259 | ||
| 260 | config RTC_DRV_TWL4030 | 260 | config RTC_DRV_TWL4030 |
| 261 | tristate "TI TWL4030/TWL5030/TPS659x0" | 261 | tristate "TI TWL4030/TWL5030/TWL6030/TPS659x0" |
| 262 | depends on RTC_CLASS && TWL4030_CORE | 262 | depends on RTC_CLASS && TWL4030_CORE |
| 263 | help | 263 | help |
| 264 | If you say yes here you get support for the RTC on the | 264 | If you say yes here you get support for the RTC on the |
| 265 | TWL4030 family chips, used mostly with OMAP3 platforms. | 265 | TWL4030/TWL5030/TWL6030 family chips, used mostly with OMAP3 platforms. |
| 266 | 266 | ||
| 267 | This driver can also be built as a module. If so, the module | 267 | This driver can also be built as a module. If so, the module |
| 268 | will be called rtc-twl4030. | 268 | will be called rtc-twl. |
| 269 | 269 | ||
| 270 | config RTC_DRV_S35390A | 270 | config RTC_DRV_S35390A |
| 271 | tristate "Seiko Instruments S-35390A" | 271 | tristate "Seiko Instruments S-35390A" |
diff --git a/drivers/rtc/Makefile b/drivers/rtc/Makefile index af1ba7ae2857..7da6efb3e953 100644 --- a/drivers/rtc/Makefile +++ b/drivers/rtc/Makefile | |||
| @@ -80,7 +80,7 @@ obj-$(CONFIG_RTC_DRV_STK17TA8) += rtc-stk17ta8.o | |||
| 80 | obj-$(CONFIG_RTC_DRV_STMP) += rtc-stmp3xxx.o | 80 | obj-$(CONFIG_RTC_DRV_STMP) += rtc-stmp3xxx.o |
| 81 | obj-$(CONFIG_RTC_DRV_SUN4V) += rtc-sun4v.o | 81 | obj-$(CONFIG_RTC_DRV_SUN4V) += rtc-sun4v.o |
| 82 | obj-$(CONFIG_RTC_DRV_TEST) += rtc-test.o | 82 | obj-$(CONFIG_RTC_DRV_TEST) += rtc-test.o |
| 83 | obj-$(CONFIG_RTC_DRV_TWL4030) += rtc-twl4030.o | 83 | obj-$(CONFIG_RTC_DRV_TWL4030) += rtc-twl.o |
| 84 | obj-$(CONFIG_RTC_DRV_TX4939) += rtc-tx4939.o | 84 | obj-$(CONFIG_RTC_DRV_TX4939) += rtc-tx4939.o |
| 85 | obj-$(CONFIG_RTC_DRV_V3020) += rtc-v3020.o | 85 | obj-$(CONFIG_RTC_DRV_V3020) += rtc-v3020.o |
| 86 | obj-$(CONFIG_RTC_DRV_VR41XX) += rtc-vr41xx.o | 86 | obj-$(CONFIG_RTC_DRV_VR41XX) += rtc-vr41xx.o |
diff --git a/drivers/rtc/rtc-pcf50633.c b/drivers/rtc/rtc-pcf50633.c index 4c5d5d0c4cfc..9b74e9c9151c 100644 --- a/drivers/rtc/rtc-pcf50633.c +++ b/drivers/rtc/rtc-pcf50633.c | |||
| @@ -277,16 +277,13 @@ static void pcf50633_rtc_irq(int irq, void *data) | |||
| 277 | 277 | ||
| 278 | static int __devinit pcf50633_rtc_probe(struct platform_device *pdev) | 278 | static int __devinit pcf50633_rtc_probe(struct platform_device *pdev) |
| 279 | { | 279 | { |
| 280 | struct pcf50633_subdev_pdata *pdata; | ||
| 281 | struct pcf50633_rtc *rtc; | 280 | struct pcf50633_rtc *rtc; |
| 282 | 281 | ||
| 283 | |||
| 284 | rtc = kzalloc(sizeof(*rtc), GFP_KERNEL); | 282 | rtc = kzalloc(sizeof(*rtc), GFP_KERNEL); |
| 285 | if (!rtc) | 283 | if (!rtc) |
| 286 | return -ENOMEM; | 284 | return -ENOMEM; |
| 287 | 285 | ||
| 288 | pdata = pdev->dev.platform_data; | 286 | rtc->pcf = dev_to_pcf50633(pdev->dev.parent); |
| 289 | rtc->pcf = pdata->pcf; | ||
| 290 | platform_set_drvdata(pdev, rtc); | 287 | platform_set_drvdata(pdev, rtc); |
| 291 | rtc->rtc_dev = rtc_device_register("pcf50633-rtc", &pdev->dev, | 288 | rtc->rtc_dev = rtc_device_register("pcf50633-rtc", &pdev->dev, |
| 292 | &pcf50633_rtc_ops, THIS_MODULE); | 289 | &pcf50633_rtc_ops, THIS_MODULE); |
diff --git a/drivers/rtc/rtc-pxa.c b/drivers/rtc/rtc-pxa.c index 747ca194fad4..e6351b743da6 100644 --- a/drivers/rtc/rtc-pxa.c +++ b/drivers/rtc/rtc-pxa.c | |||
| @@ -456,7 +456,7 @@ static int pxa_rtc_resume(struct device *dev) | |||
| 456 | return 0; | 456 | return 0; |
| 457 | } | 457 | } |
| 458 | 458 | ||
| 459 | static struct dev_pm_ops pxa_rtc_pm_ops = { | 459 | static const struct dev_pm_ops pxa_rtc_pm_ops = { |
| 460 | .suspend = pxa_rtc_suspend, | 460 | .suspend = pxa_rtc_suspend, |
| 461 | .resume = pxa_rtc_resume, | 461 | .resume = pxa_rtc_resume, |
| 462 | }; | 462 | }; |
diff --git a/drivers/rtc/rtc-sa1100.c b/drivers/rtc/rtc-sa1100.c index 29f98a70586e..e4a44b641702 100644 --- a/drivers/rtc/rtc-sa1100.c +++ b/drivers/rtc/rtc-sa1100.c | |||
| @@ -407,7 +407,7 @@ static int sa1100_rtc_resume(struct device *dev) | |||
| 407 | return 0; | 407 | return 0; |
| 408 | } | 408 | } |
| 409 | 409 | ||
| 410 | static struct dev_pm_ops sa1100_rtc_pm_ops = { | 410 | static const struct dev_pm_ops sa1100_rtc_pm_ops = { |
| 411 | .suspend = sa1100_rtc_suspend, | 411 | .suspend = sa1100_rtc_suspend, |
| 412 | .resume = sa1100_rtc_resume, | 412 | .resume = sa1100_rtc_resume, |
| 413 | }; | 413 | }; |
diff --git a/drivers/rtc/rtc-sh.c b/drivers/rtc/rtc-sh.c index e6ed5404bca0..e95cc6f8d61e 100644 --- a/drivers/rtc/rtc-sh.c +++ b/drivers/rtc/rtc-sh.c | |||
| @@ -826,7 +826,7 @@ static int sh_rtc_resume(struct device *dev) | |||
| 826 | return 0; | 826 | return 0; |
| 827 | } | 827 | } |
| 828 | 828 | ||
| 829 | static struct dev_pm_ops sh_rtc_dev_pm_ops = { | 829 | static const struct dev_pm_ops sh_rtc_dev_pm_ops = { |
| 830 | .suspend = sh_rtc_suspend, | 830 | .suspend = sh_rtc_suspend, |
| 831 | .resume = sh_rtc_resume, | 831 | .resume = sh_rtc_resume, |
| 832 | }; | 832 | }; |
diff --git a/drivers/rtc/rtc-twl4030.c b/drivers/rtc/rtc-twl.c index 9c8c70c497dc..c6a83a2a722c 100644 --- a/drivers/rtc/rtc-twl4030.c +++ b/drivers/rtc/rtc-twl.c | |||
| @@ -1,5 +1,5 @@ | |||
| 1 | /* | 1 | /* |
| 2 | * rtc-twl4030.c -- TWL4030 Real Time Clock interface | 2 | * rtc-twl.c -- TWL Real Time Clock interface |
| 3 | * | 3 | * |
| 4 | * Copyright (C) 2007 MontaVista Software, Inc | 4 | * Copyright (C) 2007 MontaVista Software, Inc |
| 5 | * Author: Alexandre Rusev <source@mvista.com> | 5 | * Author: Alexandre Rusev <source@mvista.com> |
| @@ -28,33 +28,81 @@ | |||
| 28 | #include <linux/platform_device.h> | 28 | #include <linux/platform_device.h> |
| 29 | #include <linux/interrupt.h> | 29 | #include <linux/interrupt.h> |
| 30 | 30 | ||
| 31 | #include <linux/i2c/twl4030.h> | 31 | #include <linux/i2c/twl.h> |
| 32 | 32 | ||
| 33 | 33 | ||
| 34 | /* | 34 | /* |
| 35 | * RTC block register offsets (use TWL_MODULE_RTC) | 35 | * RTC block register offsets (use TWL_MODULE_RTC) |
| 36 | */ | 36 | */ |
| 37 | #define REG_SECONDS_REG 0x00 | 37 | enum { |
| 38 | #define REG_MINUTES_REG 0x01 | 38 | REG_SECONDS_REG = 0, |
| 39 | #define REG_HOURS_REG 0x02 | 39 | REG_MINUTES_REG, |
| 40 | #define REG_DAYS_REG 0x03 | 40 | REG_HOURS_REG, |
| 41 | #define REG_MONTHS_REG 0x04 | 41 | REG_DAYS_REG, |
| 42 | #define REG_YEARS_REG 0x05 | 42 | REG_MONTHS_REG, |
| 43 | #define REG_WEEKS_REG 0x06 | 43 | REG_YEARS_REG, |
| 44 | 44 | REG_WEEKS_REG, | |
| 45 | #define REG_ALARM_SECONDS_REG 0x07 | 45 | |
| 46 | #define REG_ALARM_MINUTES_REG 0x08 | 46 | REG_ALARM_SECONDS_REG, |
| 47 | #define REG_ALARM_HOURS_REG 0x09 | 47 | REG_ALARM_MINUTES_REG, |
| 48 | #define REG_ALARM_DAYS_REG 0x0A | 48 | REG_ALARM_HOURS_REG, |
| 49 | #define REG_ALARM_MONTHS_REG 0x0B | 49 | REG_ALARM_DAYS_REG, |
| 50 | #define REG_ALARM_YEARS_REG 0x0C | 50 | REG_ALARM_MONTHS_REG, |
| 51 | 51 | REG_ALARM_YEARS_REG, | |
| 52 | #define REG_RTC_CTRL_REG 0x0D | 52 | |
| 53 | #define REG_RTC_STATUS_REG 0x0E | 53 | REG_RTC_CTRL_REG, |
| 54 | #define REG_RTC_INTERRUPTS_REG 0x0F | 54 | REG_RTC_STATUS_REG, |
| 55 | 55 | REG_RTC_INTERRUPTS_REG, | |
| 56 | #define REG_RTC_COMP_LSB_REG 0x10 | 56 | |
| 57 | #define REG_RTC_COMP_MSB_REG 0x11 | 57 | REG_RTC_COMP_LSB_REG, |
| 58 | REG_RTC_COMP_MSB_REG, | ||
| 59 | }; | ||
| 60 | const static u8 twl4030_rtc_reg_map[] = { | ||
| 61 | [REG_SECONDS_REG] = 0x00, | ||
| 62 | [REG_MINUTES_REG] = 0x01, | ||
| 63 | [REG_HOURS_REG] = 0x02, | ||
| 64 | [REG_DAYS_REG] = 0x03, | ||
| 65 | [REG_MONTHS_REG] = 0x04, | ||
| 66 | [REG_YEARS_REG] = 0x05, | ||
| 67 | [REG_WEEKS_REG] = 0x06, | ||
| 68 | |||
| 69 | [REG_ALARM_SECONDS_REG] = 0x07, | ||
| 70 | [REG_ALARM_MINUTES_REG] = 0x08, | ||
| 71 | [REG_ALARM_HOURS_REG] = 0x09, | ||
| 72 | [REG_ALARM_DAYS_REG] = 0x0A, | ||
| 73 | [REG_ALARM_MONTHS_REG] = 0x0B, | ||
| 74 | [REG_ALARM_YEARS_REG] = 0x0C, | ||
| 75 | |||
| 76 | [REG_RTC_CTRL_REG] = 0x0D, | ||
| 77 | [REG_RTC_STATUS_REG] = 0x0E, | ||
| 78 | [REG_RTC_INTERRUPTS_REG] = 0x0F, | ||
| 79 | |||
| 80 | [REG_RTC_COMP_LSB_REG] = 0x10, | ||
| 81 | [REG_RTC_COMP_MSB_REG] = 0x11, | ||
| 82 | }; | ||
| 83 | const static u8 twl6030_rtc_reg_map[] = { | ||
| 84 | [REG_SECONDS_REG] = 0x00, | ||
| 85 | [REG_MINUTES_REG] = 0x01, | ||
| 86 | [REG_HOURS_REG] = 0x02, | ||
| 87 | [REG_DAYS_REG] = 0x03, | ||
| 88 | [REG_MONTHS_REG] = 0x04, | ||
| 89 | [REG_YEARS_REG] = 0x05, | ||
| 90 | [REG_WEEKS_REG] = 0x06, | ||
| 91 | |||
| 92 | [REG_ALARM_SECONDS_REG] = 0x08, | ||
| 93 | [REG_ALARM_MINUTES_REG] = 0x09, | ||
| 94 | [REG_ALARM_HOURS_REG] = 0x0A, | ||
| 95 | [REG_ALARM_DAYS_REG] = 0x0B, | ||
| 96 | [REG_ALARM_MONTHS_REG] = 0x0C, | ||
| 97 | [REG_ALARM_YEARS_REG] = 0x0D, | ||
| 98 | |||
| 99 | [REG_RTC_CTRL_REG] = 0x10, | ||
| 100 | [REG_RTC_STATUS_REG] = 0x11, | ||
| 101 | [REG_RTC_INTERRUPTS_REG] = 0x12, | ||
| 102 | |||
| 103 | [REG_RTC_COMP_LSB_REG] = 0x13, | ||
| 104 | [REG_RTC_COMP_MSB_REG] = 0x14, | ||
| 105 | }; | ||
| 58 | 106 | ||
| 59 | /* RTC_CTRL_REG bitfields */ | 107 | /* RTC_CTRL_REG bitfields */ |
| 60 | #define BIT_RTC_CTRL_REG_STOP_RTC_M 0x01 | 108 | #define BIT_RTC_CTRL_REG_STOP_RTC_M 0x01 |
| @@ -84,31 +132,32 @@ | |||
| 84 | #define ALL_TIME_REGS 6 | 132 | #define ALL_TIME_REGS 6 |
| 85 | 133 | ||
| 86 | /*----------------------------------------------------------------------*/ | 134 | /*----------------------------------------------------------------------*/ |
| 135 | static u8 *rtc_reg_map; | ||
| 87 | 136 | ||
| 88 | /* | 137 | /* |
| 89 | * Supports 1 byte read from TWL4030 RTC register. | 138 | * Supports 1 byte read from TWL RTC register. |
| 90 | */ | 139 | */ |
| 91 | static int twl4030_rtc_read_u8(u8 *data, u8 reg) | 140 | static int twl_rtc_read_u8(u8 *data, u8 reg) |
| 92 | { | 141 | { |
| 93 | int ret; | 142 | int ret; |
| 94 | 143 | ||
| 95 | ret = twl4030_i2c_read_u8(TWL4030_MODULE_RTC, data, reg); | 144 | ret = twl_i2c_read_u8(TWL_MODULE_RTC, data, (rtc_reg_map[reg])); |
| 96 | if (ret < 0) | 145 | if (ret < 0) |
| 97 | pr_err("twl4030_rtc: Could not read TWL4030" | 146 | pr_err("twl_rtc: Could not read TWL" |
| 98 | "register %X - error %d\n", reg, ret); | 147 | "register %X - error %d\n", reg, ret); |
| 99 | return ret; | 148 | return ret; |
| 100 | } | 149 | } |
| 101 | 150 | ||
| 102 | /* | 151 | /* |
| 103 | * Supports 1 byte write to TWL4030 RTC registers. | 152 | * Supports 1 byte write to TWL RTC registers. |
| 104 | */ | 153 | */ |
| 105 | static int twl4030_rtc_write_u8(u8 data, u8 reg) | 154 | static int twl_rtc_write_u8(u8 data, u8 reg) |
| 106 | { | 155 | { |
| 107 | int ret; | 156 | int ret; |
| 108 | 157 | ||
| 109 | ret = twl4030_i2c_write_u8(TWL4030_MODULE_RTC, data, reg); | 158 | ret = twl_i2c_write_u8(TWL_MODULE_RTC, data, (rtc_reg_map[reg])); |
| 110 | if (ret < 0) | 159 | if (ret < 0) |
| 111 | pr_err("twl4030_rtc: Could not write TWL4030" | 160 | pr_err("twl_rtc: Could not write TWL" |
| 112 | "register %X - error %d\n", reg, ret); | 161 | "register %X - error %d\n", reg, ret); |
| 113 | return ret; | 162 | return ret; |
| 114 | } | 163 | } |
| @@ -129,7 +178,7 @@ static int set_rtc_irq_bit(unsigned char bit) | |||
| 129 | 178 | ||
| 130 | val = rtc_irq_bits | bit; | 179 | val = rtc_irq_bits | bit; |
| 131 | val &= ~BIT_RTC_INTERRUPTS_REG_EVERY_M; | 180 | val &= ~BIT_RTC_INTERRUPTS_REG_EVERY_M; |
| 132 | ret = twl4030_rtc_write_u8(val, REG_RTC_INTERRUPTS_REG); | 181 | ret = twl_rtc_write_u8(val, REG_RTC_INTERRUPTS_REG); |
| 133 | if (ret == 0) | 182 | if (ret == 0) |
| 134 | rtc_irq_bits = val; | 183 | rtc_irq_bits = val; |
| 135 | 184 | ||
| @@ -145,14 +194,14 @@ static int mask_rtc_irq_bit(unsigned char bit) | |||
| 145 | int ret; | 194 | int ret; |
| 146 | 195 | ||
| 147 | val = rtc_irq_bits & ~bit; | 196 | val = rtc_irq_bits & ~bit; |
| 148 | ret = twl4030_rtc_write_u8(val, REG_RTC_INTERRUPTS_REG); | 197 | ret = twl_rtc_write_u8(val, REG_RTC_INTERRUPTS_REG); |
| 149 | if (ret == 0) | 198 | if (ret == 0) |
| 150 | rtc_irq_bits = val; | 199 | rtc_irq_bits = val; |
| 151 | 200 | ||
| 152 | return ret; | 201 | return ret; |
| 153 | } | 202 | } |
| 154 | 203 | ||
| 155 | static int twl4030_rtc_alarm_irq_enable(struct device *dev, unsigned enabled) | 204 | static int twl_rtc_alarm_irq_enable(struct device *dev, unsigned enabled) |
| 156 | { | 205 | { |
| 157 | int ret; | 206 | int ret; |
| 158 | 207 | ||
| @@ -164,7 +213,7 @@ static int twl4030_rtc_alarm_irq_enable(struct device *dev, unsigned enabled) | |||
| 164 | return ret; | 213 | return ret; |
| 165 | } | 214 | } |
| 166 | 215 | ||
| 167 | static int twl4030_rtc_update_irq_enable(struct device *dev, unsigned enabled) | 216 | static int twl_rtc_update_irq_enable(struct device *dev, unsigned enabled) |
| 168 | { | 217 | { |
| 169 | int ret; | 218 | int ret; |
| 170 | 219 | ||
| @@ -177,7 +226,7 @@ static int twl4030_rtc_update_irq_enable(struct device *dev, unsigned enabled) | |||
| 177 | } | 226 | } |
| 178 | 227 | ||
| 179 | /* | 228 | /* |
| 180 | * Gets current TWL4030 RTC time and date parameters. | 229 | * Gets current TWL RTC time and date parameters. |
| 181 | * | 230 | * |
| 182 | * The RTC's time/alarm representation is not what gmtime(3) requires | 231 | * The RTC's time/alarm representation is not what gmtime(3) requires |
| 183 | * Linux to use: | 232 | * Linux to use: |
| @@ -185,24 +234,24 @@ static int twl4030_rtc_update_irq_enable(struct device *dev, unsigned enabled) | |||
| 185 | * - Months are 1..12 vs Linux 0-11 | 234 | * - Months are 1..12 vs Linux 0-11 |
| 186 | * - Years are 0..99 vs Linux 1900..N (we assume 21st century) | 235 | * - Years are 0..99 vs Linux 1900..N (we assume 21st century) |
| 187 | */ | 236 | */ |
| 188 | static int twl4030_rtc_read_time(struct device *dev, struct rtc_time *tm) | 237 | static int twl_rtc_read_time(struct device *dev, struct rtc_time *tm) |
| 189 | { | 238 | { |
| 190 | unsigned char rtc_data[ALL_TIME_REGS + 1]; | 239 | unsigned char rtc_data[ALL_TIME_REGS + 1]; |
| 191 | int ret; | 240 | int ret; |
| 192 | u8 save_control; | 241 | u8 save_control; |
| 193 | 242 | ||
| 194 | ret = twl4030_rtc_read_u8(&save_control, REG_RTC_CTRL_REG); | 243 | ret = twl_rtc_read_u8(&save_control, REG_RTC_CTRL_REG); |
| 195 | if (ret < 0) | 244 | if (ret < 0) |
| 196 | return ret; | 245 | return ret; |
| 197 | 246 | ||
| 198 | save_control |= BIT_RTC_CTRL_REG_GET_TIME_M; | 247 | save_control |= BIT_RTC_CTRL_REG_GET_TIME_M; |
| 199 | 248 | ||
| 200 | ret = twl4030_rtc_write_u8(save_control, REG_RTC_CTRL_REG); | 249 | ret = twl_rtc_write_u8(save_control, REG_RTC_CTRL_REG); |
| 201 | if (ret < 0) | 250 | if (ret < 0) |
| 202 | return ret; | 251 | return ret; |
| 203 | 252 | ||
| 204 | ret = twl4030_i2c_read(TWL4030_MODULE_RTC, rtc_data, | 253 | ret = twl_i2c_read(TWL_MODULE_RTC, rtc_data, |
| 205 | REG_SECONDS_REG, ALL_TIME_REGS); | 254 | (rtc_reg_map[REG_SECONDS_REG]), ALL_TIME_REGS); |
| 206 | 255 | ||
| 207 | if (ret < 0) { | 256 | if (ret < 0) { |
| 208 | dev_err(dev, "rtc_read_time error %d\n", ret); | 257 | dev_err(dev, "rtc_read_time error %d\n", ret); |
| @@ -219,7 +268,7 @@ static int twl4030_rtc_read_time(struct device *dev, struct rtc_time *tm) | |||
| 219 | return ret; | 268 | return ret; |
| 220 | } | 269 | } |
| 221 | 270 | ||
| 222 | static int twl4030_rtc_set_time(struct device *dev, struct rtc_time *tm) | 271 | static int twl_rtc_set_time(struct device *dev, struct rtc_time *tm) |
| 223 | { | 272 | { |
| 224 | unsigned char save_control; | 273 | unsigned char save_control; |
| 225 | unsigned char rtc_data[ALL_TIME_REGS + 1]; | 274 | unsigned char rtc_data[ALL_TIME_REGS + 1]; |
| @@ -233,18 +282,18 @@ static int twl4030_rtc_set_time(struct device *dev, struct rtc_time *tm) | |||
| 233 | rtc_data[6] = bin2bcd(tm->tm_year - 100); | 282 | rtc_data[6] = bin2bcd(tm->tm_year - 100); |
| 234 | 283 | ||
| 235 | /* Stop RTC while updating the TC registers */ | 284 | /* Stop RTC while updating the TC registers */ |
| 236 | ret = twl4030_rtc_read_u8(&save_control, REG_RTC_CTRL_REG); | 285 | ret = twl_rtc_read_u8(&save_control, REG_RTC_CTRL_REG); |
| 237 | if (ret < 0) | 286 | if (ret < 0) |
| 238 | goto out; | 287 | goto out; |
| 239 | 288 | ||
| 240 | save_control &= ~BIT_RTC_CTRL_REG_STOP_RTC_M; | 289 | save_control &= ~BIT_RTC_CTRL_REG_STOP_RTC_M; |
| 241 | twl4030_rtc_write_u8(save_control, REG_RTC_CTRL_REG); | 290 | twl_rtc_write_u8(save_control, REG_RTC_CTRL_REG); |
| 242 | if (ret < 0) | 291 | if (ret < 0) |
| 243 | goto out; | 292 | goto out; |
| 244 | 293 | ||
| 245 | /* update all the time registers in one shot */ | 294 | /* update all the time registers in one shot */ |
| 246 | ret = twl4030_i2c_write(TWL4030_MODULE_RTC, rtc_data, | 295 | ret = twl_i2c_write(TWL_MODULE_RTC, rtc_data, |
| 247 | REG_SECONDS_REG, ALL_TIME_REGS); | 296 | (rtc_reg_map[REG_SECONDS_REG]), ALL_TIME_REGS); |
| 248 | if (ret < 0) { | 297 | if (ret < 0) { |
| 249 | dev_err(dev, "rtc_set_time error %d\n", ret); | 298 | dev_err(dev, "rtc_set_time error %d\n", ret); |
| 250 | goto out; | 299 | goto out; |
| @@ -252,22 +301,22 @@ static int twl4030_rtc_set_time(struct device *dev, struct rtc_time *tm) | |||
| 252 | 301 | ||
| 253 | /* Start back RTC */ | 302 | /* Start back RTC */ |
| 254 | save_control |= BIT_RTC_CTRL_REG_STOP_RTC_M; | 303 | save_control |= BIT_RTC_CTRL_REG_STOP_RTC_M; |
| 255 | ret = twl4030_rtc_write_u8(save_control, REG_RTC_CTRL_REG); | 304 | ret = twl_rtc_write_u8(save_control, REG_RTC_CTRL_REG); |
| 256 | 305 | ||
| 257 | out: | 306 | out: |
| 258 | return ret; | 307 | return ret; |
| 259 | } | 308 | } |
| 260 | 309 | ||
| 261 | /* | 310 | /* |
| 262 | * Gets current TWL4030 RTC alarm time. | 311 | * Gets current TWL RTC alarm time. |
| 263 | */ | 312 | */ |
| 264 | static int twl4030_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alm) | 313 | static int twl_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alm) |
| 265 | { | 314 | { |
| 266 | unsigned char rtc_data[ALL_TIME_REGS + 1]; | 315 | unsigned char rtc_data[ALL_TIME_REGS + 1]; |
| 267 | int ret; | 316 | int ret; |
| 268 | 317 | ||
| 269 | ret = twl4030_i2c_read(TWL4030_MODULE_RTC, rtc_data, | 318 | ret = twl_i2c_read(TWL_MODULE_RTC, rtc_data, |
| 270 | REG_ALARM_SECONDS_REG, ALL_TIME_REGS); | 319 | (rtc_reg_map[REG_ALARM_SECONDS_REG]), ALL_TIME_REGS); |
| 271 | if (ret < 0) { | 320 | if (ret < 0) { |
| 272 | dev_err(dev, "rtc_read_alarm error %d\n", ret); | 321 | dev_err(dev, "rtc_read_alarm error %d\n", ret); |
| 273 | return ret; | 322 | return ret; |
| @@ -288,12 +337,12 @@ static int twl4030_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alm) | |||
| 288 | return ret; | 337 | return ret; |
| 289 | } | 338 | } |
| 290 | 339 | ||
| 291 | static int twl4030_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alm) | 340 | static int twl_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alm) |
| 292 | { | 341 | { |
| 293 | unsigned char alarm_data[ALL_TIME_REGS + 1]; | 342 | unsigned char alarm_data[ALL_TIME_REGS + 1]; |
| 294 | int ret; | 343 | int ret; |
| 295 | 344 | ||
| 296 | ret = twl4030_rtc_alarm_irq_enable(dev, 0); | 345 | ret = twl_rtc_alarm_irq_enable(dev, 0); |
| 297 | if (ret) | 346 | if (ret) |
| 298 | goto out; | 347 | goto out; |
| 299 | 348 | ||
| @@ -305,20 +354,20 @@ static int twl4030_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alm) | |||
| 305 | alarm_data[6] = bin2bcd(alm->time.tm_year - 100); | 354 | alarm_data[6] = bin2bcd(alm->time.tm_year - 100); |
| 306 | 355 | ||
| 307 | /* update all the alarm registers in one shot */ | 356 | /* update all the alarm registers in one shot */ |
| 308 | ret = twl4030_i2c_write(TWL4030_MODULE_RTC, alarm_data, | 357 | ret = twl_i2c_write(TWL_MODULE_RTC, alarm_data, |
| 309 | REG_ALARM_SECONDS_REG, ALL_TIME_REGS); | 358 | (rtc_reg_map[REG_ALARM_SECONDS_REG]), ALL_TIME_REGS); |
| 310 | if (ret) { | 359 | if (ret) { |
| 311 | dev_err(dev, "rtc_set_alarm error %d\n", ret); | 360 | dev_err(dev, "rtc_set_alarm error %d\n", ret); |
| 312 | goto out; | 361 | goto out; |
| 313 | } | 362 | } |
| 314 | 363 | ||
| 315 | if (alm->enabled) | 364 | if (alm->enabled) |
| 316 | ret = twl4030_rtc_alarm_irq_enable(dev, 1); | 365 | ret = twl_rtc_alarm_irq_enable(dev, 1); |
| 317 | out: | 366 | out: |
| 318 | return ret; | 367 | return ret; |
| 319 | } | 368 | } |
| 320 | 369 | ||
| 321 | static irqreturn_t twl4030_rtc_interrupt(int irq, void *rtc) | 370 | static irqreturn_t twl_rtc_interrupt(int irq, void *rtc) |
| 322 | { | 371 | { |
| 323 | unsigned long events = 0; | 372 | unsigned long events = 0; |
| 324 | int ret = IRQ_NONE; | 373 | int ret = IRQ_NONE; |
| @@ -333,7 +382,7 @@ static irqreturn_t twl4030_rtc_interrupt(int irq, void *rtc) | |||
| 333 | local_irq_enable(); | 382 | local_irq_enable(); |
| 334 | #endif | 383 | #endif |
| 335 | 384 | ||
| 336 | res = twl4030_rtc_read_u8(&rd_reg, REG_RTC_STATUS_REG); | 385 | res = twl_rtc_read_u8(&rd_reg, REG_RTC_STATUS_REG); |
| 337 | if (res) | 386 | if (res) |
| 338 | goto out; | 387 | goto out; |
| 339 | /* | 388 | /* |
| @@ -347,26 +396,28 @@ static irqreturn_t twl4030_rtc_interrupt(int irq, void *rtc) | |||
| 347 | else | 396 | else |
| 348 | events |= RTC_IRQF | RTC_UF; | 397 | events |= RTC_IRQF | RTC_UF; |
| 349 | 398 | ||
| 350 | res = twl4030_rtc_write_u8(rd_reg | BIT_RTC_STATUS_REG_ALARM_M, | 399 | res = twl_rtc_write_u8(rd_reg | BIT_RTC_STATUS_REG_ALARM_M, |
| 351 | REG_RTC_STATUS_REG); | 400 | REG_RTC_STATUS_REG); |
| 352 | if (res) | 401 | if (res) |
| 353 | goto out; | 402 | goto out; |
| 354 | 403 | ||
| 355 | /* Clear on Read enabled. RTC_IT bit of TWL4030_INT_PWR_ISR1 | 404 | if (twl_class_is_4030()) { |
| 356 | * needs 2 reads to clear the interrupt. One read is done in | 405 | /* Clear on Read enabled. RTC_IT bit of TWL4030_INT_PWR_ISR1 |
| 357 | * do_twl4030_pwrirq(). Doing the second read, to clear | 406 | * needs 2 reads to clear the interrupt. One read is done in |
| 358 | * the bit. | 407 | * do_twl_pwrirq(). Doing the second read, to clear |
| 359 | * | 408 | * the bit. |
| 360 | * FIXME the reason PWR_ISR1 needs an extra read is that | 409 | * |
| 361 | * RTC_IF retriggered until we cleared REG_ALARM_M above. | 410 | * FIXME the reason PWR_ISR1 needs an extra read is that |
| 362 | * But re-reading like this is a bad hack; by doing so we | 411 | * RTC_IF retriggered until we cleared REG_ALARM_M above. |
| 363 | * risk wrongly clearing status for some other IRQ (losing | 412 | * But re-reading like this is a bad hack; by doing so we |
| 364 | * the interrupt). Be smarter about handling RTC_UF ... | 413 | * risk wrongly clearing status for some other IRQ (losing |
| 365 | */ | 414 | * the interrupt). Be smarter about handling RTC_UF ... |
| 366 | res = twl4030_i2c_read_u8(TWL4030_MODULE_INT, | 415 | */ |
| 416 | res = twl_i2c_read_u8(TWL4030_MODULE_INT, | ||
| 367 | &rd_reg, TWL4030_INT_PWR_ISR1); | 417 | &rd_reg, TWL4030_INT_PWR_ISR1); |
| 368 | if (res) | 418 | if (res) |
| 369 | goto out; | 419 | goto out; |
| 420 | } | ||
| 370 | 421 | ||
| 371 | /* Notify RTC core on event */ | 422 | /* Notify RTC core on event */ |
| 372 | rtc_update_irq(rtc, 1, events); | 423 | rtc_update_irq(rtc, 1, events); |
| @@ -376,18 +427,18 @@ out: | |||
| 376 | return ret; | 427 | return ret; |
| 377 | } | 428 | } |
| 378 | 429 | ||
| 379 | static struct rtc_class_ops twl4030_rtc_ops = { | 430 | static struct rtc_class_ops twl_rtc_ops = { |
| 380 | .read_time = twl4030_rtc_read_time, | 431 | .read_time = twl_rtc_read_time, |
| 381 | .set_time = twl4030_rtc_set_time, | 432 | .set_time = twl_rtc_set_time, |
| 382 | .read_alarm = twl4030_rtc_read_alarm, | 433 | .read_alarm = twl_rtc_read_alarm, |
| 383 | .set_alarm = twl4030_rtc_set_alarm, | 434 | .set_alarm = twl_rtc_set_alarm, |
| 384 | .alarm_irq_enable = twl4030_rtc_alarm_irq_enable, | 435 | .alarm_irq_enable = twl_rtc_alarm_irq_enable, |
| 385 | .update_irq_enable = twl4030_rtc_update_irq_enable, | 436 | .update_irq_enable = twl_rtc_update_irq_enable, |
| 386 | }; | 437 | }; |
| 387 | 438 | ||
| 388 | /*----------------------------------------------------------------------*/ | 439 | /*----------------------------------------------------------------------*/ |
| 389 | 440 | ||
| 390 | static int __devinit twl4030_rtc_probe(struct platform_device *pdev) | 441 | static int __devinit twl_rtc_probe(struct platform_device *pdev) |
| 391 | { | 442 | { |
| 392 | struct rtc_device *rtc; | 443 | struct rtc_device *rtc; |
| 393 | int ret = 0; | 444 | int ret = 0; |
| @@ -398,7 +449,7 @@ static int __devinit twl4030_rtc_probe(struct platform_device *pdev) | |||
| 398 | return -EINVAL; | 449 | return -EINVAL; |
| 399 | 450 | ||
| 400 | rtc = rtc_device_register(pdev->name, | 451 | rtc = rtc_device_register(pdev->name, |
| 401 | &pdev->dev, &twl4030_rtc_ops, THIS_MODULE); | 452 | &pdev->dev, &twl_rtc_ops, THIS_MODULE); |
| 402 | if (IS_ERR(rtc)) { | 453 | if (IS_ERR(rtc)) { |
| 403 | ret = PTR_ERR(rtc); | 454 | ret = PTR_ERR(rtc); |
| 404 | dev_err(&pdev->dev, "can't register RTC device, err %ld\n", | 455 | dev_err(&pdev->dev, "can't register RTC device, err %ld\n", |
| @@ -409,7 +460,7 @@ static int __devinit twl4030_rtc_probe(struct platform_device *pdev) | |||
| 409 | 460 | ||
| 410 | platform_set_drvdata(pdev, rtc); | 461 | platform_set_drvdata(pdev, rtc); |
| 411 | 462 | ||
| 412 | ret = twl4030_rtc_read_u8(&rd_reg, REG_RTC_STATUS_REG); | 463 | ret = twl_rtc_read_u8(&rd_reg, REG_RTC_STATUS_REG); |
| 413 | if (ret < 0) | 464 | if (ret < 0) |
| 414 | goto out1; | 465 | goto out1; |
| 415 | 466 | ||
| @@ -420,11 +471,11 @@ static int __devinit twl4030_rtc_probe(struct platform_device *pdev) | |||
| 420 | dev_warn(&pdev->dev, "Pending Alarm interrupt detected.\n"); | 471 | dev_warn(&pdev->dev, "Pending Alarm interrupt detected.\n"); |
| 421 | 472 | ||
| 422 | /* Clear RTC Power up reset and pending alarm interrupts */ | 473 | /* Clear RTC Power up reset and pending alarm interrupts */ |
| 423 | ret = twl4030_rtc_write_u8(rd_reg, REG_RTC_STATUS_REG); | 474 | ret = twl_rtc_write_u8(rd_reg, REG_RTC_STATUS_REG); |
| 424 | if (ret < 0) | 475 | if (ret < 0) |
| 425 | goto out1; | 476 | goto out1; |
| 426 | 477 | ||
| 427 | ret = request_irq(irq, twl4030_rtc_interrupt, | 478 | ret = request_irq(irq, twl_rtc_interrupt, |
| 428 | IRQF_TRIGGER_RISING, | 479 | IRQF_TRIGGER_RISING, |
| 429 | dev_name(&rtc->dev), rtc); | 480 | dev_name(&rtc->dev), rtc); |
| 430 | if (ret < 0) { | 481 | if (ret < 0) { |
| @@ -432,21 +483,28 @@ static int __devinit twl4030_rtc_probe(struct platform_device *pdev) | |||
| 432 | goto out1; | 483 | goto out1; |
| 433 | } | 484 | } |
| 434 | 485 | ||
| 486 | if (twl_class_is_6030()) { | ||
| 487 | twl6030_interrupt_unmask(TWL6030_RTC_INT_MASK, | ||
| 488 | REG_INT_MSK_LINE_A); | ||
| 489 | twl6030_interrupt_unmask(TWL6030_RTC_INT_MASK, | ||
| 490 | REG_INT_MSK_STS_A); | ||
| 491 | } | ||
| 492 | |||
| 435 | /* Check RTC module status, Enable if it is off */ | 493 | /* Check RTC module status, Enable if it is off */ |
| 436 | ret = twl4030_rtc_read_u8(&rd_reg, REG_RTC_CTRL_REG); | 494 | ret = twl_rtc_read_u8(&rd_reg, REG_RTC_CTRL_REG); |
| 437 | if (ret < 0) | 495 | if (ret < 0) |
| 438 | goto out2; | 496 | goto out2; |
| 439 | 497 | ||
| 440 | if (!(rd_reg & BIT_RTC_CTRL_REG_STOP_RTC_M)) { | 498 | if (!(rd_reg & BIT_RTC_CTRL_REG_STOP_RTC_M)) { |
| 441 | dev_info(&pdev->dev, "Enabling TWL4030-RTC.\n"); | 499 | dev_info(&pdev->dev, "Enabling TWL-RTC.\n"); |
| 442 | rd_reg = BIT_RTC_CTRL_REG_STOP_RTC_M; | 500 | rd_reg = BIT_RTC_CTRL_REG_STOP_RTC_M; |
| 443 | ret = twl4030_rtc_write_u8(rd_reg, REG_RTC_CTRL_REG); | 501 | ret = twl_rtc_write_u8(rd_reg, REG_RTC_CTRL_REG); |
| 444 | if (ret < 0) | 502 | if (ret < 0) |
| 445 | goto out2; | 503 | goto out2; |
| 446 | } | 504 | } |
| 447 | 505 | ||
| 448 | /* init cached IRQ enable bits */ | 506 | /* init cached IRQ enable bits */ |
| 449 | ret = twl4030_rtc_read_u8(&rtc_irq_bits, REG_RTC_INTERRUPTS_REG); | 507 | ret = twl_rtc_read_u8(&rtc_irq_bits, REG_RTC_INTERRUPTS_REG); |
| 450 | if (ret < 0) | 508 | if (ret < 0) |
| 451 | goto out2; | 509 | goto out2; |
| 452 | 510 | ||
| @@ -461,10 +519,10 @@ out0: | |||
| 461 | } | 519 | } |
| 462 | 520 | ||
| 463 | /* | 521 | /* |
| 464 | * Disable all TWL4030 RTC module interrupts. | 522 | * Disable all TWL RTC module interrupts. |
| 465 | * Sets status flag to free. | 523 | * Sets status flag to free. |
| 466 | */ | 524 | */ |
| 467 | static int __devexit twl4030_rtc_remove(struct platform_device *pdev) | 525 | static int __devexit twl_rtc_remove(struct platform_device *pdev) |
| 468 | { | 526 | { |
| 469 | /* leave rtc running, but disable irqs */ | 527 | /* leave rtc running, but disable irqs */ |
| 470 | struct rtc_device *rtc = platform_get_drvdata(pdev); | 528 | struct rtc_device *rtc = platform_get_drvdata(pdev); |
| @@ -472,6 +530,13 @@ static int __devexit twl4030_rtc_remove(struct platform_device *pdev) | |||
| 472 | 530 | ||
| 473 | mask_rtc_irq_bit(BIT_RTC_INTERRUPTS_REG_IT_ALARM_M); | 531 | mask_rtc_irq_bit(BIT_RTC_INTERRUPTS_REG_IT_ALARM_M); |
| 474 | mask_rtc_irq_bit(BIT_RTC_INTERRUPTS_REG_IT_TIMER_M); | 532 | mask_rtc_irq_bit(BIT_RTC_INTERRUPTS_REG_IT_TIMER_M); |
| 533 | if (twl_class_is_6030()) { | ||
| 534 | twl6030_interrupt_mask(TWL6030_RTC_INT_MASK, | ||
| 535 | REG_INT_MSK_LINE_A); | ||
| 536 | twl6030_interrupt_mask(TWL6030_RTC_INT_MASK, | ||
| 537 | REG_INT_MSK_STS_A); | ||
| 538 | } | ||
| 539 | |||
| 475 | 540 | ||
| 476 | free_irq(irq, rtc); | 541 | free_irq(irq, rtc); |
| 477 | 542 | ||
| @@ -480,7 +545,7 @@ static int __devexit twl4030_rtc_remove(struct platform_device *pdev) | |||
| 480 | return 0; | 545 | return 0; |
| 481 | } | 546 | } |
| 482 | 547 | ||
| 483 | static void twl4030_rtc_shutdown(struct platform_device *pdev) | 548 | static void twl_rtc_shutdown(struct platform_device *pdev) |
| 484 | { | 549 | { |
| 485 | /* mask timer interrupts, but leave alarm interrupts on to enable | 550 | /* mask timer interrupts, but leave alarm interrupts on to enable |
| 486 | power-on when alarm is triggered */ | 551 | power-on when alarm is triggered */ |
| @@ -491,7 +556,7 @@ static void twl4030_rtc_shutdown(struct platform_device *pdev) | |||
| 491 | 556 | ||
| 492 | static unsigned char irqstat; | 557 | static unsigned char irqstat; |
| 493 | 558 | ||
| 494 | static int twl4030_rtc_suspend(struct platform_device *pdev, pm_message_t state) | 559 | static int twl_rtc_suspend(struct platform_device *pdev, pm_message_t state) |
| 495 | { | 560 | { |
| 496 | irqstat = rtc_irq_bits; | 561 | irqstat = rtc_irq_bits; |
| 497 | 562 | ||
| @@ -499,42 +564,47 @@ static int twl4030_rtc_suspend(struct platform_device *pdev, pm_message_t state) | |||
| 499 | return 0; | 564 | return 0; |
| 500 | } | 565 | } |
| 501 | 566 | ||
| 502 | static int twl4030_rtc_resume(struct platform_device *pdev) | 567 | static int twl_rtc_resume(struct platform_device *pdev) |
| 503 | { | 568 | { |
| 504 | set_rtc_irq_bit(irqstat); | 569 | set_rtc_irq_bit(irqstat); |
| 505 | return 0; | 570 | return 0; |
| 506 | } | 571 | } |
| 507 | 572 | ||
| 508 | #else | 573 | #else |
| 509 | #define twl4030_rtc_suspend NULL | 574 | #define twl_rtc_suspend NULL |
| 510 | #define twl4030_rtc_resume NULL | 575 | #define twl_rtc_resume NULL |
| 511 | #endif | 576 | #endif |
| 512 | 577 | ||
| 513 | MODULE_ALIAS("platform:twl4030_rtc"); | 578 | MODULE_ALIAS("platform:twl_rtc"); |
| 514 | 579 | ||
| 515 | static struct platform_driver twl4030rtc_driver = { | 580 | static struct platform_driver twl4030rtc_driver = { |
| 516 | .probe = twl4030_rtc_probe, | 581 | .probe = twl_rtc_probe, |
| 517 | .remove = __devexit_p(twl4030_rtc_remove), | 582 | .remove = __devexit_p(twl_rtc_remove), |
| 518 | .shutdown = twl4030_rtc_shutdown, | 583 | .shutdown = twl_rtc_shutdown, |
| 519 | .suspend = twl4030_rtc_suspend, | 584 | .suspend = twl_rtc_suspend, |
| 520 | .resume = twl4030_rtc_resume, | 585 | .resume = twl_rtc_resume, |
| 521 | .driver = { | 586 | .driver = { |
| 522 | .owner = THIS_MODULE, | 587 | .owner = THIS_MODULE, |
| 523 | .name = "twl4030_rtc", | 588 | .name = "twl_rtc", |
| 524 | }, | 589 | }, |
| 525 | }; | 590 | }; |
| 526 | 591 | ||
| 527 | static int __init twl4030_rtc_init(void) | 592 | static int __init twl_rtc_init(void) |
| 528 | { | 593 | { |
| 594 | if (twl_class_is_4030()) | ||
| 595 | rtc_reg_map = (u8 *) twl4030_rtc_reg_map; | ||
| 596 | else | ||
| 597 | rtc_reg_map = (u8 *) twl6030_rtc_reg_map; | ||
| 598 | |||
| 529 | return platform_driver_register(&twl4030rtc_driver); | 599 | return platform_driver_register(&twl4030rtc_driver); |
| 530 | } | 600 | } |
| 531 | module_init(twl4030_rtc_init); | 601 | module_init(twl_rtc_init); |
| 532 | 602 | ||
| 533 | static void __exit twl4030_rtc_exit(void) | 603 | static void __exit twl_rtc_exit(void) |
| 534 | { | 604 | { |
| 535 | platform_driver_unregister(&twl4030rtc_driver); | 605 | platform_driver_unregister(&twl4030rtc_driver); |
| 536 | } | 606 | } |
| 537 | module_exit(twl4030_rtc_exit); | 607 | module_exit(twl_rtc_exit); |
| 538 | 608 | ||
| 539 | MODULE_AUTHOR("Texas Instruments, MontaVista Software"); | 609 | MODULE_AUTHOR("Texas Instruments, MontaVista Software"); |
| 540 | MODULE_LICENSE("GPL"); | 610 | MODULE_LICENSE("GPL"); |
diff --git a/drivers/rtc/rtc-wm831x.c b/drivers/rtc/rtc-wm831x.c index 79795cdf6ed8..000c7e481e59 100644 --- a/drivers/rtc/rtc-wm831x.c +++ b/drivers/rtc/rtc-wm831x.c | |||
| @@ -485,7 +485,7 @@ static int __devexit wm831x_rtc_remove(struct platform_device *pdev) | |||
| 485 | return 0; | 485 | return 0; |
| 486 | } | 486 | } |
| 487 | 487 | ||
| 488 | static struct dev_pm_ops wm831x_rtc_pm_ops = { | 488 | static const struct dev_pm_ops wm831x_rtc_pm_ops = { |
| 489 | .suspend = wm831x_rtc_suspend, | 489 | .suspend = wm831x_rtc_suspend, |
| 490 | .resume = wm831x_rtc_resume, | 490 | .resume = wm831x_rtc_resume, |
| 491 | 491 | ||
diff --git a/drivers/rtc/rtc-wm8350.c b/drivers/rtc/rtc-wm8350.c index c91edc572eb6..f16486635a8e 100644 --- a/drivers/rtc/rtc-wm8350.c +++ b/drivers/rtc/rtc-wm8350.c | |||
| @@ -315,9 +315,9 @@ static int wm8350_rtc_update_irq_enable(struct device *dev, | |||
| 315 | return 0; | 315 | return 0; |
| 316 | } | 316 | } |
| 317 | 317 | ||
| 318 | static void wm8350_rtc_alarm_handler(struct wm8350 *wm8350, int irq, | 318 | static irqreturn_t wm8350_rtc_alarm_handler(int irq, void *data) |
| 319 | void *data) | ||
| 320 | { | 319 | { |
| 320 | struct wm8350 *wm8350 = data; | ||
| 321 | struct rtc_device *rtc = wm8350->rtc.rtc; | 321 | struct rtc_device *rtc = wm8350->rtc.rtc; |
| 322 | int ret; | 322 | int ret; |
| 323 | 323 | ||
| @@ -330,14 +330,18 @@ static void wm8350_rtc_alarm_handler(struct wm8350 *wm8350, int irq, | |||
| 330 | dev_err(&(wm8350->rtc.pdev->dev), | 330 | dev_err(&(wm8350->rtc.pdev->dev), |
| 331 | "Failed to disable alarm: %d\n", ret); | 331 | "Failed to disable alarm: %d\n", ret); |
| 332 | } | 332 | } |
| 333 | |||
| 334 | return IRQ_HANDLED; | ||
| 333 | } | 335 | } |
| 334 | 336 | ||
| 335 | static void wm8350_rtc_update_handler(struct wm8350 *wm8350, int irq, | 337 | static irqreturn_t wm8350_rtc_update_handler(int irq, void *data) |
| 336 | void *data) | ||
| 337 | { | 338 | { |
| 339 | struct wm8350 *wm8350 = data; | ||
| 338 | struct rtc_device *rtc = wm8350->rtc.rtc; | 340 | struct rtc_device *rtc = wm8350->rtc.rtc; |
| 339 | 341 | ||
| 340 | rtc_update_irq(rtc, 1, RTC_IRQF | RTC_UF); | 342 | rtc_update_irq(rtc, 1, RTC_IRQF | RTC_UF); |
| 343 | |||
| 344 | return IRQ_HANDLED; | ||
| 341 | } | 345 | } |
| 342 | 346 | ||
| 343 | static const struct rtc_class_ops wm8350_rtc_ops = { | 347 | static const struct rtc_class_ops wm8350_rtc_ops = { |
| @@ -455,15 +459,14 @@ static int wm8350_rtc_probe(struct platform_device *pdev) | |||
| 455 | return ret; | 459 | return ret; |
| 456 | } | 460 | } |
| 457 | 461 | ||
| 458 | wm8350_mask_irq(wm8350, WM8350_IRQ_RTC_SEC); | ||
| 459 | wm8350_mask_irq(wm8350, WM8350_IRQ_RTC_PER); | ||
| 460 | |||
| 461 | wm8350_register_irq(wm8350, WM8350_IRQ_RTC_SEC, | 462 | wm8350_register_irq(wm8350, WM8350_IRQ_RTC_SEC, |
| 462 | wm8350_rtc_update_handler, NULL); | 463 | wm8350_rtc_update_handler, 0, |
| 464 | "RTC Seconds", wm8350); | ||
| 465 | wm8350_mask_irq(wm8350, WM8350_IRQ_RTC_SEC); | ||
| 463 | 466 | ||
| 464 | wm8350_register_irq(wm8350, WM8350_IRQ_RTC_ALM, | 467 | wm8350_register_irq(wm8350, WM8350_IRQ_RTC_ALM, |
| 465 | wm8350_rtc_alarm_handler, NULL); | 468 | wm8350_rtc_alarm_handler, 0, |
| 466 | wm8350_unmask_irq(wm8350, WM8350_IRQ_RTC_ALM); | 469 | "RTC Alarm", wm8350); |
| 467 | 470 | ||
| 468 | return 0; | 471 | return 0; |
| 469 | } | 472 | } |
| @@ -473,8 +476,6 @@ static int __devexit wm8350_rtc_remove(struct platform_device *pdev) | |||
| 473 | struct wm8350 *wm8350 = platform_get_drvdata(pdev); | 476 | struct wm8350 *wm8350 = platform_get_drvdata(pdev); |
| 474 | struct wm8350_rtc *wm_rtc = &wm8350->rtc; | 477 | struct wm8350_rtc *wm_rtc = &wm8350->rtc; |
| 475 | 478 | ||
| 476 | wm8350_mask_irq(wm8350, WM8350_IRQ_RTC_SEC); | ||
| 477 | |||
| 478 | wm8350_free_irq(wm8350, WM8350_IRQ_RTC_SEC); | 479 | wm8350_free_irq(wm8350, WM8350_IRQ_RTC_SEC); |
| 479 | wm8350_free_irq(wm8350, WM8350_IRQ_RTC_ALM); | 480 | wm8350_free_irq(wm8350, WM8350_IRQ_RTC_ALM); |
| 480 | 481 | ||
