1 files changed, 24 insertions, 29 deletions

diff --git a/drivers/rtc/rtc-mxc.c b/drivers/rtc/rtc-mxc.c
index 6bd5072d4eb7..25ec921db07c 100644
--- a/drivers/rtc/rtc-mxc.c
+++ b/drivers/rtc/rtc-mxc.c
@@ -12,6 +12,7 @@
 #include <linux/io.h>
 #include <linux/rtc.h>
 #include <linux/module.h>
+#include <linux/slab.h>
 #include <linux/interrupt.h>
 #include <linux/platform_device.h>
 #include <linux/clk.h>
@@ -378,29 +379,37 @@ static struct rtc_class_ops mxc_rtc_ops = {
 
 static int __init mxc_rtc_probe(struct platform_device *pdev)
 {
-        struct clk *clk;
         struct resource *res;
         struct rtc_device *rtc;
         struct rtc_plat_data *pdata = NULL;
         u32 reg;
-        int ret, rate;
+        unsigned long rate;
+        int ret;
 
         res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
         if (!res)
                 return -ENODEV;
 
-        pdata = kzalloc(sizeof(*pdata), GFP_KERNEL);
+        pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL);
         if (!pdata)
                 return -ENOMEM;
 
-        pdata->ioaddr = ioremap(res->start, resource_size(res));
+        if (!devm_request_mem_region(&pdev->dev, res->start,
+                                     resource_size(res), pdev->name))
+                return -EBUSY;
 
-        clk = clk_get(&pdev->dev, "ckil");
-        if (IS_ERR(clk))
-                return PTR_ERR(clk);
+        pdata->ioaddr = devm_ioremap(&pdev->dev, res->start,
+                                     resource_size(res));
 
-        rate = clk_get_rate(clk);
-        clk_put(clk);
+        pdata->clk = clk_get(&pdev->dev, "rtc");
+        if (IS_ERR(pdata->clk)) {
+                dev_err(&pdev->dev, "unable to get clock!\n");
+                ret = PTR_ERR(pdata->clk);
+                goto exit_free_pdata;
+        }
+
+        clk_enable(pdata->clk);
+        rate = clk_get_rate(pdata->clk);
 
         if (rate == 32768)
                 reg = RTC_INPUT_CLK_32768HZ;
@@ -409,10 +418,9 @@ static int __init mxc_rtc_probe(struct platform_device *pdev)
         else if (rate == 38400)
                 reg = RTC_INPUT_CLK_38400HZ;
         else {
-                dev_err(&pdev->dev, "rtc clock is not valid (%lu)\n",
-                        clk_get_rate(clk));
+                dev_err(&pdev->dev, "rtc clock is not valid (%lu)\n", rate);
                 ret = -EINVAL;
-                goto exit_free_pdata;
+                goto exit_put_clk;
         }
 
         reg |= RTC_ENABLE_BIT;
@@ -420,18 +428,9 @@ static int __init mxc_rtc_probe(struct platform_device *pdev)
         if (((readw(pdata->ioaddr + RTC_RTCCTL)) & RTC_ENABLE_BIT) == 0) {
                 dev_err(&pdev->dev, "hardware module can't be enabled!\n");
                 ret = -EIO;
-                goto exit_free_pdata;
-        }
-
-        pdata->clk = clk_get(&pdev->dev, "rtc");
-        if (IS_ERR(pdata->clk)) {
-                dev_err(&pdev->dev, "unable to get clock!\n");
-                ret = PTR_ERR(pdata->clk);
-                goto exit_free_pdata;
+                goto exit_put_clk;
         }
 
-        clk_enable(pdata->clk);
-
         rtc = rtc_device_register(pdev->name, &pdev->dev, &mxc_rtc_ops,
                                   THIS_MODULE);
         if (IS_ERR(rtc)) {
@@ -446,8 +445,8 @@ static int __init mxc_rtc_probe(struct platform_device *pdev)
         pdata->irq = platform_get_irq(pdev, 0);
 
         if (pdata->irq >= 0 &&
-            request_irq(pdata->irq, mxc_rtc_interrupt, IRQF_SHARED,
-                        pdev->name, pdev) < 0) {
+            devm_request_irq(&pdev->dev, pdata->irq, mxc_rtc_interrupt,
+                             IRQF_SHARED, pdev->name, pdev) < 0) {
                 dev_warn(&pdev->dev, "interrupt not available.\n");
                 pdata->irq = -1;
         }
@@ -455,10 +454,10 @@ static int __init mxc_rtc_probe(struct platform_device *pdev)
         return 0;
 
 exit_put_clk:
+        clk_disable(pdata->clk);
         clk_put(pdata->clk);
 
 exit_free_pdata:
-        kfree(pdata);
 
         return ret;
 }
@@ -469,12 +468,8 @@ static int __exit mxc_rtc_remove(struct platform_device *pdev)
 
         rtc_device_unregister(pdata->rtc);
 
-        if (pdata->irq >= 0)
-                free_irq(pdata->irq, pdev);
-
         clk_disable(pdata->clk);
         clk_put(pdata->clk);
-        kfree(pdata);
         platform_set_drvdata(pdev, NULL);
 
         return 0;