diff options
Diffstat (limited to 'drivers/rtc/rtc-davinci.c')
-rw-r--r-- | drivers/rtc/rtc-davinci.c | 13 |
1 files changed, 3 insertions, 10 deletions
diff --git a/drivers/rtc/rtc-davinci.c b/drivers/rtc/rtc-davinci.c index a55048c3e26f..24677ef8c39a 100644 --- a/drivers/rtc/rtc-davinci.c +++ b/drivers/rtc/rtc-davinci.c | |||
@@ -117,7 +117,7 @@ | |||
117 | static DEFINE_SPINLOCK(davinci_rtc_lock); | 117 | static DEFINE_SPINLOCK(davinci_rtc_lock); |
118 | 118 | ||
119 | struct davinci_rtc { | 119 | struct davinci_rtc { |
120 | struct rtc_device *rtc; | 120 | struct rtc_device *rtc; |
121 | void __iomem *base; | 121 | void __iomem *base; |
122 | resource_size_t pbase; | 122 | resource_size_t pbase; |
123 | size_t base_size; | 123 | size_t base_size; |
@@ -526,10 +526,9 @@ static int __init davinci_rtc_probe(struct platform_device *pdev) | |||
526 | davinci_rtc->rtc = devm_rtc_device_register(&pdev->dev, pdev->name, | 526 | davinci_rtc->rtc = devm_rtc_device_register(&pdev->dev, pdev->name, |
527 | &davinci_rtc_ops, THIS_MODULE); | 527 | &davinci_rtc_ops, THIS_MODULE); |
528 | if (IS_ERR(davinci_rtc->rtc)) { | 528 | if (IS_ERR(davinci_rtc->rtc)) { |
529 | ret = PTR_ERR(davinci_rtc->rtc); | ||
530 | dev_err(dev, "unable to register RTC device, err %d\n", | 529 | dev_err(dev, "unable to register RTC device, err %d\n", |
531 | ret); | 530 | ret); |
532 | goto fail1; | 531 | return PTR_ERR(davinci_rtc->rtc); |
533 | } | 532 | } |
534 | 533 | ||
535 | rtcif_write(davinci_rtc, PRTCIF_INTFLG_RTCSS, PRTCIF_INTFLG); | 534 | rtcif_write(davinci_rtc, PRTCIF_INTFLG_RTCSS, PRTCIF_INTFLG); |
@@ -543,7 +542,7 @@ static int __init davinci_rtc_probe(struct platform_device *pdev) | |||
543 | 0, "davinci_rtc", davinci_rtc); | 542 | 0, "davinci_rtc", davinci_rtc); |
544 | if (ret < 0) { | 543 | if (ret < 0) { |
545 | dev_err(dev, "unable to register davinci RTC interrupt\n"); | 544 | dev_err(dev, "unable to register davinci RTC interrupt\n"); |
546 | goto fail1; | 545 | return ret; |
547 | } | 546 | } |
548 | 547 | ||
549 | /* Enable interrupts */ | 548 | /* Enable interrupts */ |
@@ -556,10 +555,6 @@ static int __init davinci_rtc_probe(struct platform_device *pdev) | |||
556 | device_init_wakeup(&pdev->dev, 0); | 555 | device_init_wakeup(&pdev->dev, 0); |
557 | 556 | ||
558 | return 0; | 557 | return 0; |
559 | |||
560 | fail1: | ||
561 | platform_set_drvdata(pdev, NULL); | ||
562 | return ret; | ||
563 | } | 558 | } |
564 | 559 | ||
565 | static int __exit davinci_rtc_remove(struct platform_device *pdev) | 560 | static int __exit davinci_rtc_remove(struct platform_device *pdev) |
@@ -570,8 +565,6 @@ static int __exit davinci_rtc_remove(struct platform_device *pdev) | |||
570 | 565 | ||
571 | rtcif_write(davinci_rtc, 0, PRTCIF_INTEN); | 566 | rtcif_write(davinci_rtc, 0, PRTCIF_INTEN); |
572 | 567 | ||
573 | platform_set_drvdata(pdev, NULL); | ||
574 | |||
575 | return 0; | 568 | return 0; |
576 | } | 569 | } |
577 | 570 | ||