4 files changed, 96 insertions, 48 deletions

diff --git a/drivers/pnp/interface.c b/drivers/pnp/interface.c
index cfaf5b73540b..0c201317284b 100644
--- a/drivers/pnp/interface.c
+++ b/drivers/pnp/interface.c
@@ -298,6 +298,39 @@ static ssize_t pnp_show_current_resources(struct device *dmdev,
         return ret;
 }
 
+static char *pnp_get_resource_value(char *buf,
+                                    unsigned long type,
+                                    resource_size_t *start,
+                                    resource_size_t *end,
+                                    unsigned long *flags)
+{
+        if (start)
+                *start = 0;
+        if (end)
+                *end = 0;
+        if (flags)
+                *flags = 0;
+
+        /* TBD: allow for disabled resources */
+
+        buf = skip_spaces(buf);
+        if (start) {
+                *start = simple_strtoull(buf, &buf, 0);
+                if (end) {
+                        buf = skip_spaces(buf);
+                        if (*buf == '-') {
+                                buf = skip_spaces(buf + 1);
+                                *end = simple_strtoull(buf, &buf, 0);
+                        } else
+                                *end = *start;
+                }
+        }
+
+        /* TBD: allow for additional flags, e.g., IORESOURCE_WINDOW */
+
+        return buf;
+}
+
 static ssize_t pnp_set_current_resources(struct device *dmdev,
                                          struct device_attribute *attr,
                                          const char *ubuf, size_t count)
@@ -305,7 +338,6 @@ static ssize_t pnp_set_current_resources(struct device *dmdev,
         struct pnp_dev *dev = to_pnp_dev(dmdev);
         char *buf = (void *)ubuf;
         int retval = 0;
-        resource_size_t start, end;
 
         if (dev->status & PNP_ATTACHED) {
                 retval = -EBUSY;
@@ -349,6 +381,10 @@ static ssize_t pnp_set_current_resources(struct device *dmdev,
                 goto done;
         }
         if (!strnicmp(buf, "set", 3)) {
+                resource_size_t start;
+                resource_size_t end;
+                unsigned long flags;
+
                 if (dev->active)
                         goto done;
                 buf += 3;
@@ -357,42 +393,37 @@ static ssize_t pnp_set_current_resources(struct device *dmdev,
                 while (1) {
                         buf = skip_spaces(buf);
                         if (!strnicmp(buf, "io", 2)) {
-                                buf = skip_spaces(buf + 2);
-                                start = simple_strtoul(buf, &buf, 0);
-                                buf = skip_spaces(buf);
-                                if (*buf == '-') {
-                                        buf = skip_spaces(buf + 1);
-                                        end = simple_strtoul(buf, &buf, 0);
-                                } else
-                                        end = start;
-                                pnp_add_io_resource(dev, start, end, 0);
-                                continue;
-                        }
-                        if (!strnicmp(buf, "mem", 3)) {
-                                buf = skip_spaces(buf + 3);
-                                start = simple_strtoul(buf, &buf, 0);
-                                buf = skip_spaces(buf);
-                                if (*buf == '-') {
-                                        buf = skip_spaces(buf + 1);
-                                        end = simple_strtoul(buf, &buf, 0);
-                                } else
-                                        end = start;
-                                pnp_add_mem_resource(dev, start, end, 0);
-                                continue;
-                        }
-                        if (!strnicmp(buf, "irq", 3)) {
-                                buf = skip_spaces(buf + 3);
-                                start = simple_strtoul(buf, &buf, 0);
-                                pnp_add_irq_resource(dev, start, 0);
-                                continue;
-                        }
-                        if (!strnicmp(buf, "dma", 3)) {
-                                buf = skip_spaces(buf + 3);
-                                start = simple_strtoul(buf, &buf, 0);
-                                pnp_add_dma_resource(dev, start, 0);
-                                continue;
-                        }
-                        break;
+                                buf = pnp_get_resource_value(buf + 2,
+                                                             IORESOURCE_IO,
+                                                             &start, &end,
+                                                             &flags);
+                                pnp_add_io_resource(dev, start, end, flags);
+                        } else if (!strnicmp(buf, "mem", 3)) {
+                                buf = pnp_get_resource_value(buf + 3,
+                                                             IORESOURCE_MEM,
+                                                             &start, &end,
+                                                             &flags);
+                                pnp_add_mem_resource(dev, start, end, flags);
+                        } else if (!strnicmp(buf, "irq", 3)) {
+                                buf = pnp_get_resource_value(buf + 3,
+                                                             IORESOURCE_IRQ,
+                                                             &start, NULL,
+                                                             &flags);
+                                pnp_add_irq_resource(dev, start, flags);
+                        } else if (!strnicmp(buf, "dma", 3)) {
+                                buf = pnp_get_resource_value(buf + 3,
+                                                             IORESOURCE_DMA,
+                                                             &start, NULL,
+                                                             &flags);
+                                pnp_add_dma_resource(dev, start, flags);
+                        } else if (!strnicmp(buf, "bus", 3)) {
+                                buf = pnp_get_resource_value(buf + 3,
+                                                             IORESOURCE_BUS,
+                                                             &start, &end,
+                                                             NULL);
+                                pnp_add_bus_resource(dev, start, end);
+                        } else
+                                break;
                 }
                 mutex_unlock(&pnp_res_mutex);
                 goto done;
diff --git a/drivers/pnp/manager.c b/drivers/pnp/manager.c
index ed9ce507149a..95cebf0185de 100644
--- a/drivers/pnp/manager.c
+++ b/drivers/pnp/manager.c
@@ -18,11 +18,27 @@
 
 DEFINE_MUTEX(pnp_res_mutex);
 
+static struct resource *pnp_find_resource(struct pnp_dev *dev,
+                                          unsigned char rule,
+                                          unsigned long type,
+                                          unsigned int bar)
+{
+        struct resource *res = pnp_get_resource(dev, type, bar);
+
+        /* when the resource already exists, set its resource bits from rule */
+        if (res) {
+                res->flags &= ~IORESOURCE_BITS;
+                res->flags |= rule & IORESOURCE_BITS;
+        }
+
+        return res;
+}
+
 static int pnp_assign_port(struct pnp_dev *dev, struct pnp_port *rule, int idx)
 {
         struct resource *res, local_res;
 
-        res = pnp_get_resource(dev, IORESOURCE_IO, idx);
+        res = pnp_find_resource(dev, rule->flags, IORESOURCE_IO, idx);
         if (res) {
                 pnp_dbg(&dev->dev, "  io %d already set to %#llx-%#llx "
                         "flags %#lx\n", idx, (unsigned long long) res->start,
@@ -65,7 +81,7 @@ static int pnp_assign_mem(struct pnp_dev *dev, struct pnp_mem *rule, int idx)
 {
         struct resource *res, local_res;
 
-        res = pnp_get_resource(dev, IORESOURCE_MEM, idx);
+        res = pnp_find_resource(dev, rule->flags, IORESOURCE_MEM, idx);
         if (res) {
                 pnp_dbg(&dev->dev, "  mem %d already set to %#llx-%#llx "
                         "flags %#lx\n", idx, (unsigned long long) res->start,
@@ -78,6 +94,7 @@ static int pnp_assign_mem(struct pnp_dev *dev, struct pnp_mem *rule, int idx)
         res->start = 0;
         res->end = 0;
 
+        /* ??? rule->flags restricted to 8 bits, all tests bogus ??? */
         if (!(rule->flags & IORESOURCE_MEM_WRITEABLE))
                 res->flags |= IORESOURCE_READONLY;
         if (rule->flags & IORESOURCE_MEM_CACHEABLE)
@@ -123,7 +140,7 @@ static int pnp_assign_irq(struct pnp_dev *dev, struct pnp_irq *rule, int idx)
                 5, 10, 11, 12, 9, 14, 15, 7, 3, 4, 13, 0, 1, 6, 8, 2
         };
 
-        res = pnp_get_resource(dev, IORESOURCE_IRQ, idx);
+        res = pnp_find_resource(dev, rule->flags, IORESOURCE_IRQ, idx);
         if (res) {
                 pnp_dbg(&dev->dev, "  irq %d already set to %d flags %#lx\n",
                         idx, (int) res->start, res->flags);
@@ -182,7 +199,7 @@ static int pnp_assign_dma(struct pnp_dev *dev, struct pnp_dma *rule, int idx)
                 1, 3, 5, 6, 7, 0, 2, 4
         };
 
-        res = pnp_get_resource(dev, IORESOURCE_DMA, idx);
+        res = pnp_find_resource(dev, rule->flags, IORESOURCE_DMA, idx);
         if (res) {
                 pnp_dbg(&dev->dev, "  dma %d already set to %d flags %#lx\n",
                         idx, (int) res->start, res->flags);
diff --git a/drivers/pnp/pnpacpi/core.c b/drivers/pnp/pnpacpi/core.c
index 72e822e17d47..8813fc03aa09 100644
--- a/drivers/pnp/pnpacpi/core.c
+++ b/drivers/pnp/pnpacpi/core.c
@@ -90,7 +90,7 @@ static int pnpacpi_set_resources(struct pnp_dev *dev)
         pnp_dbg(&dev->dev, "set resources\n");
 
         handle = DEVICE_ACPI_HANDLE(&dev->dev);
-        if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &acpi_dev))) {
+        if (!handle || acpi_bus_get_device(handle, &acpi_dev)) {
                 dev_dbg(&dev->dev, "ACPI device not found in %s!\n", __func__);
                 return -ENODEV;
         }
@@ -123,7 +123,7 @@ static int pnpacpi_disable_resources(struct pnp_dev *dev)
         dev_dbg(&dev->dev, "disable resources\n");
 
         handle = DEVICE_ACPI_HANDLE(&dev->dev);
-        if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &acpi_dev))) {
+        if (!handle || acpi_bus_get_device(handle, &acpi_dev)) {
                 dev_dbg(&dev->dev, "ACPI device not found in %s!\n", __func__);
                 return 0;
         }
@@ -145,7 +145,7 @@ static bool pnpacpi_can_wakeup(struct pnp_dev *dev)
         acpi_handle handle;
 
         handle = DEVICE_ACPI_HANDLE(&dev->dev);
-        if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &acpi_dev))) {
+        if (!handle || acpi_bus_get_device(handle, &acpi_dev)) {
                 dev_dbg(&dev->dev, "ACPI device not found in %s!\n", __func__);
                 return false;
         }
@@ -160,7 +160,7 @@ static int pnpacpi_suspend(struct pnp_dev *dev, pm_message_t state)
         int error = 0;
 
         handle = DEVICE_ACPI_HANDLE(&dev->dev);
-        if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &acpi_dev))) {
+        if (!handle || acpi_bus_get_device(handle, &acpi_dev)) {
                 dev_dbg(&dev->dev, "ACPI device not found in %s!\n", __func__);
                 return 0;
         }
@@ -197,7 +197,7 @@ static int pnpacpi_resume(struct pnp_dev *dev)
         acpi_handle handle = DEVICE_ACPI_HANDLE(&dev->dev);
         int error = 0;
 
-        if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &acpi_dev))) {
+        if (!handle || acpi_bus_get_device(handle, &acpi_dev)) {
                 dev_dbg(&dev->dev, "ACPI device not found in %s!\n", __func__);
                 return -ENODEV;
         }
diff --git a/drivers/pnp/pnpbios/Kconfig b/drivers/pnp/pnpbios/Kconfig
index b986d9fa3b9a..50c3dd065e03 100644
--- a/drivers/pnp/pnpbios/Kconfig
+++ b/drivers/pnp/pnpbios/Kconfig
@@ -2,8 +2,8 @@
 # Plug and Play BIOS configuration
 #
 config PNPBIOS
-        bool "Plug and Play BIOS support (EXPERIMENTAL)"
-        depends on ISA && X86 && EXPERIMENTAL
+        bool "Plug and Play BIOS support"
+        depends on ISA && X86
         default n
         ---help---
           Linux uses the PNPBIOS as defined in "Plug and Play BIOS