1 files changed, 25 insertions, 0 deletions

diff --git a/drivers/pinctrl/freescale/pinctrl-mxs.c b/drivers/pinctrl/freescale/pinctrl-mxs.c
index f98c6bb0f769..646d5c244af1 100644
--- a/drivers/pinctrl/freescale/pinctrl-mxs.c
+++ b/drivers/pinctrl/freescale/pinctrl-mxs.c
@@ -445,6 +445,31 @@ static int mxs_pinctrl_probe_dt(struct platform_device *pdev,
                 if (of_property_read_u32(child, "reg", &val))
                         continue;
                 if (strcmp(fn, child->name)) {
+                        struct device_node *child2;
+
+                        /*
+                         * This reference is dropped by
+                         * of_get_next_child(np, * child)
+                         */
+                        of_node_get(child);
+
+                        /*
+                         * The logic parsing the functions from dt currently
+                         * doesn't handle if functions with the same name are
+                         * not grouped together. Only the first contiguous
+                         * cluster is usable for each function name. This is a
+                         * bug that is not trivial to fix, but at least warn
+                         * about it.
+                         */
+                        for (child2 = of_get_next_child(np, child);
+                             child2 != NULL;
+                             child2 = of_get_next_child(np, child2)) {
+                                if (!strcmp(child2->name, fn))
+                                        dev_warn(&pdev->dev,
+                                                 "function nodes must be grouped by name (failed for: %s)",
+                                                 fn);
+                        }
+
                         f = &soc->functions[idxf++];
                         f->name = fn = child->name;
                 }