2 files changed, 54 insertions, 27 deletions

diff --git a/drivers/pcmcia/cs.c b/drivers/pcmcia/cs.c
index fc1c0c6baae2..790af87a922f 100644
--- a/drivers/pcmcia/cs.c
+++ b/drivers/pcmcia/cs.c
@@ -87,10 +87,13 @@ EXPORT_SYMBOL(pcmcia_socket_list_rwsem);
  * These functions check for the appropriate struct pcmcia_soket arrays,
  * and pass them to the low-level functions pcmcia_{suspend,resume}_socket
  */
+static int socket_early_resume(struct pcmcia_socket *skt);
+static int socket_late_resume(struct pcmcia_socket *skt);
 static int socket_resume(struct pcmcia_socket *skt);
 static int socket_suspend(struct pcmcia_socket *skt);
 
-int pcmcia_socket_dev_suspend(struct device *dev)
+static void pcmcia_socket_dev_run(struct device *dev,
+                                  int (*cb)(struct pcmcia_socket *))
 {
         struct pcmcia_socket *socket;
 
@@ -99,29 +102,34 @@ int pcmcia_socket_dev_suspend(struct device *dev)
                 if (socket->dev.parent != dev)
                         continue;
                 mutex_lock(&socket->skt_mutex);
-                socket_suspend(socket);
+                cb(socket);
                 mutex_unlock(&socket->skt_mutex);
         }
         up_read(&pcmcia_socket_list_rwsem);
+}
 
+int pcmcia_socket_dev_suspend(struct device *dev)
+{
+        pcmcia_socket_dev_run(dev, socket_suspend);
         return 0;
 }
 EXPORT_SYMBOL(pcmcia_socket_dev_suspend);
 
-int pcmcia_socket_dev_resume(struct device *dev)
+void pcmcia_socket_dev_early_resume(struct device *dev)
 {
-        struct pcmcia_socket *socket;
+        pcmcia_socket_dev_run(dev, socket_early_resume);
+}
+EXPORT_SYMBOL(pcmcia_socket_dev_early_resume);
 
-        down_read(&pcmcia_socket_list_rwsem);
-        list_for_each_entry(socket, &pcmcia_socket_list, socket_list) {
-                if (socket->dev.parent != dev)
-                        continue;
-                mutex_lock(&socket->skt_mutex);
-                socket_resume(socket);
-                mutex_unlock(&socket->skt_mutex);
-        }
-        up_read(&pcmcia_socket_list_rwsem);
+void pcmcia_socket_dev_late_resume(struct device *dev)
+{
+        pcmcia_socket_dev_run(dev, socket_late_resume);
+}
+EXPORT_SYMBOL(pcmcia_socket_dev_late_resume);
 
+int pcmcia_socket_dev_resume(struct device *dev)
+{
+        pcmcia_socket_dev_run(dev, socket_resume);
         return 0;
 }
 EXPORT_SYMBOL(pcmcia_socket_dev_resume);
@@ -544,29 +552,24 @@ static int socket_suspend(struct pcmcia_socket *skt)
         return 0;
 }
 
-/*
- * Resume a socket.  If a card is present, verify its CIS against
- * our cached copy.  If they are different, the card has been
- * replaced, and we need to tell the drivers.
- */
-static int socket_resume(struct pcmcia_socket *skt)
+static int socket_early_resume(struct pcmcia_socket *skt)
 {
-        int ret;
-
-        if (!(skt->state & SOCKET_SUSPEND))
-                return -EBUSY;
-
         skt->socket = dead_socket;
         skt->ops->init(skt);
         skt->ops->set_socket(skt, &skt->socket);
+        if (skt->state & SOCKET_PRESENT)
+                skt->resume_status = socket_setup(skt, resume_delay);
+        return 0;
+}
 
+static int socket_late_resume(struct pcmcia_socket *skt)
+{
         if (!(skt->state & SOCKET_PRESENT)) {
                 skt->state &= ~SOCKET_SUSPEND;
                 return socket_insert(skt);
         }
 
-        ret = socket_setup(skt, resume_delay);
-        if (ret == 0) {
+        if (skt->resume_status == 0) {
                 /*
                  * FIXME: need a better check here for cardbus cards.
                  */
@@ -594,6 +597,20 @@ static int socket_resume(struct pcmcia_socket *skt)
         return 0;
 }
 
+/*
+ * Resume a socket.  If a card is present, verify its CIS against
+ * our cached copy.  If they are different, the card has been
+ * replaced, and we need to tell the drivers.
+ */
+static int socket_resume(struct pcmcia_socket *skt)
+{
+        if (!(skt->state & SOCKET_SUSPEND))
+                return -EBUSY;
+
+        socket_early_resume(skt);
+        return socket_late_resume(skt);
+}
+
 static void socket_remove(struct pcmcia_socket *skt)
 {
         dev_printk(KERN_NOTICE, &skt->dev,
diff --git a/drivers/pcmcia/yenta_socket.c b/drivers/pcmcia/yenta_socket.c
index abe0e44c6e9e..8be4cc447a17 100644
--- a/drivers/pcmcia/yenta_socket.c
+++ b/drivers/pcmcia/yenta_socket.c
@@ -1275,16 +1275,26 @@ static int yenta_dev_resume_noirq(struct device *dev)
         if (socket->type && socket->type->restore_state)
                 socket->type->restore_state(socket);
 
-        return pcmcia_socket_dev_resume(dev);
+        pcmcia_socket_dev_early_resume(dev);
+        return 0;
+}
+
+static int yenta_dev_resume(struct device *dev)
+{
+        pcmcia_socket_dev_late_resume(dev);
+        return 0;
 }
 
 static struct dev_pm_ops yenta_pm_ops = {
         .suspend_noirq = yenta_dev_suspend_noirq,
         .resume_noirq = yenta_dev_resume_noirq,
+        .resume = yenta_dev_resume,
         .freeze_noirq = yenta_dev_suspend_noirq,
         .thaw_noirq = yenta_dev_resume_noirq,
+        .thaw = yenta_dev_resume,
         .poweroff_noirq = yenta_dev_suspend_noirq,
         .restore_noirq = yenta_dev_resume_noirq,
+        .restore = yenta_dev_resume,
 };
 
 #define YENTA_PM_OPS    (&yenta_pm_ops)