7 files changed, 95 insertions, 114 deletions

diff --git a/drivers/pci/host/pci-mvebu.c b/drivers/pci/host/pci-mvebu.c
index c269e430c760..2aa7b77c7c88 100644
--- a/drivers/pci/host/pci-mvebu.c
+++ b/drivers/pci/host/pci-mvebu.c
@@ -447,6 +447,11 @@ static int mvebu_sw_pci_bridge_read(struct mvebu_pcie_port *port,
                 *value = 0;
                 break;
 
+        case PCI_INTERRUPT_LINE:
+                /* LINE PIN MIN_GNT MAX_LAT */
+                *value = 0;
+                break;
+
         default:
                 *value = 0xffffffff;
                 return PCIBIOS_BAD_REGISTER_NUMBER;
diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c
index ce31eb0cdca7..733a8222b13f 100644
--- a/drivers/pci/pci-acpi.c
+++ b/drivers/pci/pci-acpi.c
@@ -325,29 +325,32 @@ static struct acpi_device *acpi_pci_find_companion(struct device *dev)
 static void pci_acpi_setup(struct device *dev)
 {
         struct pci_dev *pci_dev = to_pci_dev(dev);
-        acpi_handle handle = ACPI_HANDLE(dev);
-        struct acpi_device *adev;
+        struct acpi_device *adev = ACPI_COMPANION(dev);
 
-        if (acpi_bus_get_device(handle, &adev) || !adev->wakeup.flags.valid)
+        if (!adev)
+                return;
+
+        pci_acpi_add_pm_notifier(adev, pci_dev);
+        if (!adev->wakeup.flags.valid)
                 return;
 
         device_set_wakeup_capable(dev, true);
         acpi_pci_sleep_wake(pci_dev, false);
-
-        pci_acpi_add_pm_notifier(adev, pci_dev);
         if (adev->wakeup.flags.run_wake)
                 device_set_run_wake(dev, true);
 }
 
 static void pci_acpi_cleanup(struct device *dev)
 {
-        acpi_handle handle = ACPI_HANDLE(dev);
-        struct acpi_device *adev;
+        struct acpi_device *adev = ACPI_COMPANION(dev);
+
+        if (!adev)
+                return;
 
-        if (!acpi_bus_get_device(handle, &adev) && adev->wakeup.flags.valid) {
+        pci_acpi_remove_pm_notifier(adev);
+        if (adev->wakeup.flags.valid) {
                 device_set_wakeup_capable(dev, false);
                 device_set_run_wake(dev, false);
-                pci_acpi_remove_pm_notifier(adev);
         }
 }
 
diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c
index 9042fdbd7244..25f0bc659164 100644
--- a/drivers/pci/pci-driver.c
+++ b/drivers/pci/pci-driver.c
@@ -19,6 +19,7 @@
 #include <linux/cpu.h>
 #include <linux/pm_runtime.h>
 #include <linux/suspend.h>
+#include <linux/kexec.h>
 #include "pci.h"
 
 struct pci_dynid {
@@ -288,12 +289,27 @@ static int pci_call_probe(struct pci_driver *drv, struct pci_dev *dev,
         int error, node;
         struct drv_dev_and_id ddi = { drv, dev, id };
 
-        /* Execute driver initialization on node where the device's
-           bus is attached to.  This way the driver likely allocates
-           its local memory on the right node without any need to
-           change it. */
+        /*
+         * Execute driver initialization on node where the device is
+         * attached.  This way the driver likely allocates its local memory
+         * on the right node.
+         */
         node = dev_to_node(&dev->dev);
-        if (node >= 0) {
+
+        /*
+         * On NUMA systems, we are likely to call a PF probe function using
+         * work_on_cpu().  If that probe calls pci_enable_sriov() (which
+         * adds the VF devices via pci_bus_add_device()), we may re-enter
+         * this function to call the VF probe function.  Calling
+         * work_on_cpu() again will cause a lockdep warning.  Since VFs are
+         * always on the same node as the PF, we can work around this by
+         * avoiding work_on_cpu() when we're already on the correct node.
+         *
+         * Preemption is enabled, so it's theoretically unsafe to use
+         * numa_node_id(), but even if we run the probe function on the
+         * wrong node, it should be functionally correct.
+         */
+        if (node >= 0 && node != numa_node_id()) {
                 int cpu;
 
                 get_online_cpus();
@@ -305,6 +321,7 @@ static int pci_call_probe(struct pci_driver *drv, struct pci_dev *dev,
                 put_online_cpus();
         } else
                 error = local_pci_probe(&ddi);
+
         return error;
 }
 
@@ -399,12 +416,17 @@ static void pci_device_shutdown(struct device *dev)
         pci_msi_shutdown(pci_dev);
         pci_msix_shutdown(pci_dev);
 
+#ifdef CONFIG_KEXEC
         /*
-         * Turn off Bus Master bit on the device to tell it to not
-         * continue to do DMA. Don't touch devices in D3cold or unknown states.
+         * If this is a kexec reboot, turn off Bus Master bit on the
+         * device to tell it to not continue to do DMA. Don't touch
+         * devices in D3cold or unknown states.
+         * If it is not a kexec reboot, firmware will hit the PCI
+         * devices with big hammer and stop their DMA any way.
          */
-        if (pci_dev->current_state <= PCI_D3hot)
+        if (kexec_in_progress && (pci_dev->current_state <= PCI_D3hot))
                 pci_clear_master(pci_dev);
+#endif
 }
 
 #ifdef CONFIG_PM
diff --git a/drivers/pci/pci-label.c b/drivers/pci/pci-label.c
index dbafcc8ef673..d2d1ceccad4b 100644
--- a/drivers/pci/pci-label.c
+++ b/drivers/pci/pci-label.c
@@ -186,7 +186,6 @@ static const char device_label_dsm_uuid[] = {
 };
 
 enum acpi_attr_enum {
-        ACPI_ATTR_NONE = 0,
         ACPI_ATTR_LABEL_SHOW,
         ACPI_ATTR_INDEX_SHOW,
 };
@@ -194,84 +193,61 @@ enum acpi_attr_enum {
 static void dsm_label_utf16s_to_utf8s(union acpi_object *obj, char *buf)
 {
         int len;
-        len = utf16s_to_utf8s((const wchar_t *)obj->
-                              package.elements[1].string.pointer,
-                              obj->package.elements[1].string.length,
+        len = utf16s_to_utf8s((const wchar_t *)obj->string.pointer,
+                              obj->string.length,
                               UTF16_LITTLE_ENDIAN,
                               buf, PAGE_SIZE);
         buf[len] = '\n';
 }
 
 static int
-dsm_get_label(acpi_handle handle, int func,
-              struct acpi_buffer *output,
-              char *buf, enum acpi_attr_enum attribute)
+dsm_get_label(struct device *dev, char *buf, enum acpi_attr_enum attr)
 {
-        struct acpi_object_list input;
-        union acpi_object params[4];
-        union acpi_object *obj;
-        int len = 0;
-
-        int err;
-
-        input.count = 4;
-        input.pointer = params;
-        params[0].type = ACPI_TYPE_BUFFER;
-        params[0].buffer.length = sizeof(device_label_dsm_uuid);
-        params[0].buffer.pointer = (char *)device_label_dsm_uuid;
-        params[1].type = ACPI_TYPE_INTEGER;
-        params[1].integer.value = 0x02;
-        params[2].type = ACPI_TYPE_INTEGER;
-        params[2].integer.value = func;
-        params[3].type = ACPI_TYPE_PACKAGE;
-        params[3].package.count = 0;
-        params[3].package.elements = NULL;
-
-        err = acpi_evaluate_object(handle, "_DSM", &input, output);
-        if (err)
+        acpi_handle handle;
+        union acpi_object *obj, *tmp;
+        int len = -1;
+
+        handle = ACPI_HANDLE(dev);
+        if (!handle)
                 return -1;
 
-        obj = (union acpi_object *)output->pointer;
-
-        switch (obj->type) {
-        case ACPI_TYPE_PACKAGE:
-                if (obj->package.count != 2)
-                        break;
-                len = obj->package.elements[0].integer.value;
-                if (buf) {
-                        if (attribute == ACPI_ATTR_INDEX_SHOW)
-                                scnprintf(buf, PAGE_SIZE, "%llu\n",
-                                obj->package.elements[0].integer.value);
-                        else if (attribute == ACPI_ATTR_LABEL_SHOW)
-                                dsm_label_utf16s_to_utf8s(obj, buf);
-                        kfree(output->pointer);
-                        return strlen(buf);
-                }
-                kfree(output->pointer);
-                return len;
-        break;
-        default:
-                kfree(output->pointer);
+        obj = acpi_evaluate_dsm(handle, device_label_dsm_uuid, 0x2,
+                                DEVICE_LABEL_DSM, NULL);
+        if (!obj)
+                return -1;
+
+        tmp = obj->package.elements;
+        if (obj->type == ACPI_TYPE_PACKAGE && obj->package.count == 2 &&
+            tmp[0].type == ACPI_TYPE_INTEGER &&
+            tmp[1].type == ACPI_TYPE_STRING) {
+                /*
+                 * The second string element is optional even when
+                 * this _DSM is implemented; when not implemented,
+                 * this entry must return a null string.
+                 */
+                if (attr == ACPI_ATTR_INDEX_SHOW)
+                        scnprintf(buf, PAGE_SIZE, "%llu\n", tmp->integer.value);
+                else if (attr == ACPI_ATTR_LABEL_SHOW)
+                        dsm_label_utf16s_to_utf8s(tmp + 1, buf);
+                len = strlen(buf) > 0 ? strlen(buf) : -1;
         }
-        return -1;
+
+        ACPI_FREE(obj);
+
+        return len;
 }
 
 static bool
 device_has_dsm(struct device *dev)
 {
         acpi_handle handle;
-        struct acpi_buffer output = {ACPI_ALLOCATE_BUFFER, NULL};
 
         handle = ACPI_HANDLE(dev);
-
         if (!handle)
-                return FALSE;
+                return false;
 
-        if (dsm_get_label(handle, DEVICE_LABEL_DSM, &output, NULL,
-                          ACPI_ATTR_NONE) > 0)
-                return TRUE;
-
-        return FALSE;
+        return !!acpi_check_dsm(handle, device_label_dsm_uuid, 0x2,
+                                1 << DEVICE_LABEL_DSM);
 }
 
 static umode_t
@@ -290,44 +266,13 @@ acpi_index_string_exist(struct kobject *kobj, struct attribute *attr, int n)
 static ssize_t
 acpilabel_show(struct device *dev, struct device_attribute *attr, char *buf)
 {
-        struct acpi_buffer output = {ACPI_ALLOCATE_BUFFER, NULL};
-        acpi_handle handle;
-        int length;
-
-        handle = ACPI_HANDLE(dev);
-
-        if (!handle)
-                return -1;
-
-        length = dsm_get_label(handle, DEVICE_LABEL_DSM,
-                               &output, buf, ACPI_ATTR_LABEL_SHOW);
-
-        if (length < 1)
-                return -1;
-
-        return length;
+        return dsm_get_label(dev, buf, ACPI_ATTR_LABEL_SHOW);
 }
 
 static ssize_t
 acpiindex_show(struct device *dev, struct device_attribute *attr, char *buf)
 {
-        struct acpi_buffer output = {ACPI_ALLOCATE_BUFFER, NULL};
-        acpi_handle handle;
-        int length;
-
-        handle = ACPI_HANDLE(dev);
-
-        if (!handle)
-                return -1;
-
-        length = dsm_get_label(handle, DEVICE_LABEL_DSM,
-                               &output, buf, ACPI_ATTR_INDEX_SHOW);
-
-        if (length < 0)
-                return -1;
-
-        return length;
-
+        return dsm_get_label(dev, buf, ACPI_ATTR_INDEX_SHOW);
 }
 
 static struct device_attribute acpi_attr_label = {
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 33120d156668..07369f32e8bb 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -4165,6 +4165,14 @@ int pci_set_vga_state(struct pci_dev *dev, bool decode,
         return 0;
 }
 
+bool pci_device_is_present(struct pci_dev *pdev)
+{
+        u32 v;
+
+        return pci_bus_read_dev_vendor_id(pdev->bus, pdev->devfn, &v, 0);
+}
+EXPORT_SYMBOL_GPL(pci_device_is_present);
+
 #define RESOURCE_ALIGNMENT_PARAM_SIZE COMMAND_LINE_SIZE
 static char resource_alignment_param[RESOURCE_ALIGNMENT_PARAM_SIZE] = {0};
 static DEFINE_SPINLOCK(resource_alignment_lock);
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index b3b1b9aa8863..3a02717473ad 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -9,10 +9,6 @@
  *
  *  Init/reset quirks for USB host controllers should be in the
  *  USB quirks file, where their drivers can access reuse it.
- *
- *  The bridge optimization stuff has been removed. If you really
- *  have a silly BIOS which is unable to set your host bridge right,
- *  use the PowerTweak utility (see http://powertweak.sourceforge.net).
  */
 
 #include <linux/types.h>
diff --git a/drivers/pci/remove.c b/drivers/pci/remove.c
index 1576851028db..cc9337a71529 100644
--- a/drivers/pci/remove.c
+++ b/drivers/pci/remove.c
@@ -24,7 +24,7 @@ static void pci_stop_dev(struct pci_dev *dev)
         if (dev->is_added) {
                 pci_proc_detach_device(dev);
                 pci_remove_sysfs_dev_files(dev);
-                device_del(&dev->dev);
+                device_release_driver(&dev->dev);
                 dev->is_added = 0;
         }
 
@@ -34,6 +34,8 @@ static void pci_stop_dev(struct pci_dev *dev)
 
 static void pci_destroy_dev(struct pci_dev *dev)
 {
+        device_del(&dev->dev);
+
         down_write(&pci_bus_sem);
         list_del(&dev->bus_list);
         up_write(&pci_bus_sem);