aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/pci/probe.c
diff options
context:
space:
mode:
Diffstat (limited to 'drivers/pci/probe.c')
-rw-r--r--drivers/pci/probe.c64
1 files changed, 25 insertions, 39 deletions
diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
index 9b4673df27e7..8b505bd925aa 100644
--- a/drivers/pci/probe.c
+++ b/drivers/pci/probe.c
@@ -54,7 +54,7 @@ static void pci_create_legacy_files(struct pci_bus *b)
54 b->legacy_io->attr.mode = S_IRUSR | S_IWUSR; 54 b->legacy_io->attr.mode = S_IRUSR | S_IWUSR;
55 b->legacy_io->read = pci_read_legacy_io; 55 b->legacy_io->read = pci_read_legacy_io;
56 b->legacy_io->write = pci_write_legacy_io; 56 b->legacy_io->write = pci_write_legacy_io;
57 class_device_create_bin_file(&b->class_dev, b->legacy_io); 57 device_create_bin_file(&b->dev, b->legacy_io);
58 58
59 /* Allocated above after the legacy_io struct */ 59 /* Allocated above after the legacy_io struct */
60 b->legacy_mem = b->legacy_io + 1; 60 b->legacy_mem = b->legacy_io + 1;
@@ -62,15 +62,15 @@ static void pci_create_legacy_files(struct pci_bus *b)
62 b->legacy_mem->size = 1024*1024; 62 b->legacy_mem->size = 1024*1024;
63 b->legacy_mem->attr.mode = S_IRUSR | S_IWUSR; 63 b->legacy_mem->attr.mode = S_IRUSR | S_IWUSR;
64 b->legacy_mem->mmap = pci_mmap_legacy_mem; 64 b->legacy_mem->mmap = pci_mmap_legacy_mem;
65 class_device_create_bin_file(&b->class_dev, b->legacy_mem); 65 device_create_bin_file(&b->dev, b->legacy_mem);
66 } 66 }
67} 67}
68 68
69void pci_remove_legacy_files(struct pci_bus *b) 69void pci_remove_legacy_files(struct pci_bus *b)
70{ 70{
71 if (b->legacy_io) { 71 if (b->legacy_io) {
72 class_device_remove_bin_file(&b->class_dev, b->legacy_io); 72 device_remove_bin_file(&b->dev, b->legacy_io);
73 class_device_remove_bin_file(&b->class_dev, b->legacy_mem); 73 device_remove_bin_file(&b->dev, b->legacy_mem);
74 kfree(b->legacy_io); /* both are allocated here */ 74 kfree(b->legacy_io); /* both are allocated here */
75 } 75 }
76} 76}
@@ -82,26 +82,27 @@ void pci_remove_legacy_files(struct pci_bus *bus) { return; }
82/* 82/*
83 * PCI Bus Class Devices 83 * PCI Bus Class Devices
84 */ 84 */
85static ssize_t pci_bus_show_cpuaffinity(struct class_device *class_dev, 85static ssize_t pci_bus_show_cpuaffinity(struct device *dev,
86 struct device_attribute *attr,
86 char *buf) 87 char *buf)
87{ 88{
88 int ret; 89 int ret;
89 cpumask_t cpumask; 90 cpumask_t cpumask;
90 91
91 cpumask = pcibus_to_cpumask(to_pci_bus(class_dev)); 92 cpumask = pcibus_to_cpumask(to_pci_bus(dev));
92 ret = cpumask_scnprintf(buf, PAGE_SIZE, cpumask); 93 ret = cpumask_scnprintf(buf, PAGE_SIZE, cpumask);
93 if (ret < PAGE_SIZE) 94 if (ret < PAGE_SIZE)
94 buf[ret++] = '\n'; 95 buf[ret++] = '\n';
95 return ret; 96 return ret;
96} 97}
97CLASS_DEVICE_ATTR(cpuaffinity, S_IRUGO, pci_bus_show_cpuaffinity, NULL); 98DEVICE_ATTR(cpuaffinity, S_IRUGO, pci_bus_show_cpuaffinity, NULL);
98 99
99/* 100/*
100 * PCI Bus Class 101 * PCI Bus Class
101 */ 102 */
102static void release_pcibus_dev(struct class_device *class_dev) 103static void release_pcibus_dev(struct device *dev)
103{ 104{
104 struct pci_bus *pci_bus = to_pci_bus(class_dev); 105 struct pci_bus *pci_bus = to_pci_bus(dev);
105 106
106 if (pci_bus->bridge) 107 if (pci_bus->bridge)
107 put_device(pci_bus->bridge); 108 put_device(pci_bus->bridge);
@@ -110,7 +111,7 @@ static void release_pcibus_dev(struct class_device *class_dev)
110 111
111static struct class pcibus_class = { 112static struct class pcibus_class = {
112 .name = "pci_bus", 113 .name = "pci_bus",
113 .release = &release_pcibus_dev, 114 .dev_release = &release_pcibus_dev,
114}; 115};
115 116
116static int __init pcibus_class_init(void) 117static int __init pcibus_class_init(void)
@@ -393,7 +394,6 @@ pci_alloc_child_bus(struct pci_bus *parent, struct pci_dev *bridge, int busnr)
393{ 394{
394 struct pci_bus *child; 395 struct pci_bus *child;
395 int i; 396 int i;
396 int retval;
397 397
398 /* 398 /*
399 * Allocate a new bus, and inherit stuff from the parent.. 399 * Allocate a new bus, and inherit stuff from the parent..
@@ -409,15 +409,12 @@ pci_alloc_child_bus(struct pci_bus *parent, struct pci_dev *bridge, int busnr)
409 child->bus_flags = parent->bus_flags; 409 child->bus_flags = parent->bus_flags;
410 child->bridge = get_device(&bridge->dev); 410 child->bridge = get_device(&bridge->dev);
411 411
412 child->class_dev.class = &pcibus_class; 412 /* initialize some portions of the bus device, but don't register it
413 sprintf(child->class_dev.class_id, "%04x:%02x", pci_domain_nr(child), busnr); 413 * now as the parent is not properly set up yet. This device will get
414 retval = class_device_register(&child->class_dev); 414 * registered later in pci_bus_add_devices()
415 if (retval) 415 */
416 goto error_register; 416 child->dev.class = &pcibus_class;
417 retval = class_device_create_file(&child->class_dev, 417 sprintf(child->dev.bus_id, "%04x:%02x", pci_domain_nr(child), busnr);
418 &class_device_attr_cpuaffinity);
419 if (retval)
420 goto error_file_create;
421 418
422 /* 419 /*
423 * Set up the primary, secondary and subordinate 420 * Set up the primary, secondary and subordinate
@@ -435,12 +432,6 @@ pci_alloc_child_bus(struct pci_bus *parent, struct pci_dev *bridge, int busnr)
435 bridge->subordinate = child; 432 bridge->subordinate = child;
436 433
437 return child; 434 return child;
438
439error_file_create:
440 class_device_unregister(&child->class_dev);
441error_register:
442 kfree(child);
443 return NULL;
444} 435}
445 436
446struct pci_bus *pci_add_new_bus(struct pci_bus *parent, struct pci_dev *dev, int busnr) 437struct pci_bus *pci_add_new_bus(struct pci_bus *parent, struct pci_dev *dev, int busnr)
@@ -1107,32 +1098,27 @@ struct pci_bus * pci_create_bus(struct device *parent,
1107 goto dev_reg_err; 1098 goto dev_reg_err;
1108 b->bridge = get_device(dev); 1099 b->bridge = get_device(dev);
1109 1100
1110 b->class_dev.class = &pcibus_class; 1101 b->dev.class = &pcibus_class;
1111 sprintf(b->class_dev.class_id, "%04x:%02x", pci_domain_nr(b), bus); 1102 b->dev.parent = b->bridge;
1112 error = class_device_register(&b->class_dev); 1103 sprintf(b->dev.bus_id, "%04x:%02x", pci_domain_nr(b), bus);
1104 error = device_register(&b->dev);
1113 if (error) 1105 if (error)
1114 goto class_dev_reg_err; 1106 goto class_dev_reg_err;
1115 error = class_device_create_file(&b->class_dev, &class_device_attr_cpuaffinity); 1107 error = device_create_file(&b->dev, &dev_attr_cpuaffinity);
1116 if (error) 1108 if (error)
1117 goto class_dev_create_file_err; 1109 goto dev_create_file_err;
1118 1110
1119 /* Create legacy_io and legacy_mem files for this bus */ 1111 /* Create legacy_io and legacy_mem files for this bus */
1120 pci_create_legacy_files(b); 1112 pci_create_legacy_files(b);
1121 1113
1122 error = sysfs_create_link(&b->class_dev.kobj, &b->bridge->kobj, "bridge");
1123 if (error)
1124 goto sys_create_link_err;
1125
1126 b->number = b->secondary = bus; 1114 b->number = b->secondary = bus;
1127 b->resource[0] = &ioport_resource; 1115 b->resource[0] = &ioport_resource;
1128 b->resource[1] = &iomem_resource; 1116 b->resource[1] = &iomem_resource;
1129 1117
1130 return b; 1118 return b;
1131 1119
1132sys_create_link_err: 1120dev_create_file_err:
1133 class_device_remove_file(&b->class_dev, &class_device_attr_cpuaffinity); 1121 device_unregister(&b->dev);
1134class_dev_create_file_err:
1135 class_device_unregister(&b->class_dev);
1136class_dev_reg_err: 1122class_dev_reg_err:
1137 device_unregister(dev); 1123 device_unregister(dev);
1138dev_reg_err: 1124dev_reg_err: