aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/parisc
diff options
context:
space:
mode:
Diffstat (limited to 'drivers/parisc')
-rw-r--r--drivers/parisc/eisa_eeprom.c10
-rw-r--r--drivers/parisc/led.c7
2 files changed, 2 insertions, 15 deletions
diff --git a/drivers/parisc/eisa_eeprom.c b/drivers/parisc/eisa_eeprom.c
index 8c0b26e9b98a..cce00ed81f37 100644
--- a/drivers/parisc/eisa_eeprom.c
+++ b/drivers/parisc/eisa_eeprom.c
@@ -75,17 +75,8 @@ static ssize_t eisa_eeprom_read(struct file * file,
75 return ret; 75 return ret;
76} 76}
77 77
78static int eisa_eeprom_ioctl(struct inode *inode, struct file *file,
79 unsigned int cmd,
80 unsigned long arg)
81{
82 return -ENOTTY;
83}
84
85static int eisa_eeprom_open(struct inode *inode, struct file *file) 78static int eisa_eeprom_open(struct inode *inode, struct file *file)
86{ 79{
87 cycle_kernel_lock();
88
89 if (file->f_mode & FMODE_WRITE) 80 if (file->f_mode & FMODE_WRITE)
90 return -EINVAL; 81 return -EINVAL;
91 82
@@ -104,7 +95,6 @@ static const struct file_operations eisa_eeprom_fops = {
104 .owner = THIS_MODULE, 95 .owner = THIS_MODULE,
105 .llseek = eisa_eeprom_llseek, 96 .llseek = eisa_eeprom_llseek,
106 .read = eisa_eeprom_read, 97 .read = eisa_eeprom_read,
107 .ioctl = eisa_eeprom_ioctl,
108 .open = eisa_eeprom_open, 98 .open = eisa_eeprom_open,
109 .release = eisa_eeprom_release, 99 .release = eisa_eeprom_release,
110}; 100};
diff --git a/drivers/parisc/led.c b/drivers/parisc/led.c
index 9581d3619450..79caf1ca4a29 100644
--- a/drivers/parisc/led.c
+++ b/drivers/parisc/led.c
@@ -352,11 +352,9 @@ static __inline__ int led_get_net_activity(void)
352 352
353 rx_total = tx_total = 0; 353 rx_total = tx_total = 0;
354 354
355 /* we are running as a workqueue task, so locking dev_base 355 /* we are running as a workqueue task, so we can use an RCU lookup */
356 * for reading should be OK */
357 read_lock(&dev_base_lock);
358 rcu_read_lock(); 356 rcu_read_lock();
359 for_each_netdev(&init_net, dev) { 357 for_each_netdev_rcu(&init_net, dev) {
360 const struct net_device_stats *stats; 358 const struct net_device_stats *stats;
361 struct in_device *in_dev = __in_dev_get_rcu(dev); 359 struct in_device *in_dev = __in_dev_get_rcu(dev);
362 if (!in_dev || !in_dev->ifa_list) 360 if (!in_dev || !in_dev->ifa_list)
@@ -368,7 +366,6 @@ static __inline__ int led_get_net_activity(void)
368 tx_total += stats->tx_packets; 366 tx_total += stats->tx_packets;
369 } 367 }
370 rcu_read_unlock(); 368 rcu_read_unlock();
371 read_unlock(&dev_base_lock);
372 369
373 retval = 0; 370 retval = 0;
374 371