aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net
diff options
context:
space:
mode:
Diffstat (limited to 'drivers/net')
-rw-r--r--drivers/net/ethernet/renesas/sh_eth.c12
1 files changed, 7 insertions, 5 deletions
diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
index 1ccd5959c0bf..3426d32a1803 100644
--- a/drivers/net/ethernet/renesas/sh_eth.c
+++ b/drivers/net/ethernet/renesas/sh_eth.c
@@ -1857,11 +1857,13 @@ static int sh_eth_open(struct net_device *ndev)
1857 1857
1858 pm_runtime_get_sync(&mdp->pdev->dev); 1858 pm_runtime_get_sync(&mdp->pdev->dev);
1859 1859
1860 napi_enable(&mdp->napi);
1861
1860 ret = request_irq(ndev->irq, sh_eth_interrupt, 1862 ret = request_irq(ndev->irq, sh_eth_interrupt,
1861 mdp->cd->irq_flags, ndev->name, ndev); 1863 mdp->cd->irq_flags, ndev->name, ndev);
1862 if (ret) { 1864 if (ret) {
1863 dev_err(&ndev->dev, "Can not assign IRQ number\n"); 1865 dev_err(&ndev->dev, "Can not assign IRQ number\n");
1864 return ret; 1866 goto out_napi_off;
1865 } 1867 }
1866 1868
1867 /* Descriptor set */ 1869 /* Descriptor set */
@@ -1879,12 +1881,12 @@ static int sh_eth_open(struct net_device *ndev)
1879 if (ret) 1881 if (ret)
1880 goto out_free_irq; 1882 goto out_free_irq;
1881 1883
1882 napi_enable(&mdp->napi);
1883
1884 return ret; 1884 return ret;
1885 1885
1886out_free_irq: 1886out_free_irq:
1887 free_irq(ndev->irq, ndev); 1887 free_irq(ndev->irq, ndev);
1888out_napi_off:
1889 napi_disable(&mdp->napi);
1888 pm_runtime_put_sync(&mdp->pdev->dev); 1890 pm_runtime_put_sync(&mdp->pdev->dev);
1889 return ret; 1891 return ret;
1890} 1892}
@@ -1976,8 +1978,6 @@ static int sh_eth_close(struct net_device *ndev)
1976{ 1978{
1977 struct sh_eth_private *mdp = netdev_priv(ndev); 1979 struct sh_eth_private *mdp = netdev_priv(ndev);
1978 1980
1979 napi_disable(&mdp->napi);
1980
1981 netif_stop_queue(ndev); 1981 netif_stop_queue(ndev);
1982 1982
1983 /* Disable interrupts by clearing the interrupt mask. */ 1983 /* Disable interrupts by clearing the interrupt mask. */
@@ -1995,6 +1995,8 @@ static int sh_eth_close(struct net_device *ndev)
1995 1995
1996 free_irq(ndev->irq, ndev); 1996 free_irq(ndev->irq, ndev);
1997 1997
1998 napi_disable(&mdp->napi);
1999
1998 /* Free all the skbuffs in the Rx queue. */ 2000 /* Free all the skbuffs in the Rx queue. */
1999 sh_eth_ring_free(ndev); 2001 sh_eth_ring_free(ndev);
2000 2002