9 files changed, 145 insertions, 98 deletions

diff --git a/drivers/net/3c527.h b/drivers/net/3c527.h
index c10f009ce9b6..53b5b071df08 100644
--- a/drivers/net/3c527.h
+++ b/drivers/net/3c527.h
@@ -32,43 +32,43 @@
 
 struct mc32_mailbox
 {
-        u16     mbox __attribute((packed));
-        u16     data[1] __attribute((packed));
-};
+        u16 mbox;
+        u16 data[1];
+} __attribute((packed));
 
 struct skb_header
 {
-        u8      status __attribute((packed));
-        u8      control __attribute((packed));
-        u16     next __attribute((packed));     /* Do not change! */
-        u16     length __attribute((packed));
-        u32     data __attribute((packed));
-};
+        u8 status;
+        u8 control;
+        u16 next;       /* Do not change! */
+        u16 length;
+        u32 data;
+} __attribute((packed));
 
 struct mc32_stats
 {
         /* RX Errors */
-        u32     rx_crc_errors       __attribute((packed));      
-        u32     rx_alignment_errors  __attribute((packed));     
-        u32     rx_overrun_errors    __attribute((packed));
-        u32     rx_tooshort_errors  __attribute((packed));
-        u32     rx_toolong_errors   __attribute((packed));
-        u32     rx_outofresource_errors  __attribute((packed)); 
+        u32 rx_crc_errors;
+        u32 rx_alignment_errors;
+        u32 rx_overrun_errors;
+        u32 rx_tooshort_errors;
+        u32 rx_toolong_errors;
+        u32 rx_outofresource_errors;
 
-        u32     rx_discarded   __attribute((packed));  /* via card pattern match filter */ 
+        u32 rx_discarded;  /* via card pattern match filter */
 
         /* TX Errors */
-        u32     tx_max_collisions __attribute((packed)); 
-        u32     tx_carrier_errors __attribute((packed)); 
-        u32     tx_underrun_errors __attribute((packed)); 
-        u32     tx_cts_errors     __attribute((packed)); 
-        u32     tx_timeout_errors __attribute((packed)) ;
+        u32 tx_max_collisions;
+        u32 tx_carrier_errors;
+        u32 tx_underrun_errors;
+        u32 tx_cts_errors;
+        u32 tx_timeout_errors;
         
         /* various cruft */
-        u32     dataA[6] __attribute((packed));   
-        u16     dataB[5] __attribute((packed));   
-        u32     dataC[14] __attribute((packed));        
-};
+        u32 dataA[6];
+        u16 dataB[5];
+        u32 dataC[14];
+} __attribute((packed));
 
 #define STATUS_MASK     0x0F
 #define COMPLETED       (1<<7)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index e2fa29b612cd..1960961bf28e 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -1374,7 +1374,7 @@ config FORCEDETH
 
 config CS89x0
         tristate "CS89x0 support"
-        depends on (NET_PCI && (ISA || ARCH_IXDP2X01)) || ARCH_PNX0105
+        depends on NET_PCI && (ISA || ARCH_IXDP2X01 || ARCH_PNX010X)
         ---help---
           Support for CS89x0 chipset based Ethernet cards. If you have a
           network (Ethernet) card of this type, say Y and read the
diff --git a/drivers/net/cs89x0.c b/drivers/net/cs89x0.c
index a6078ad9b654..907c01009746 100644
--- a/drivers/net/cs89x0.c
+++ b/drivers/net/cs89x0.c
@@ -175,7 +175,7 @@ static unsigned int cs8900_irq_map[] = {1,0,0,0};
 #include <asm/irq.h>
 static unsigned int netcard_portlist[] __initdata = {IXDP2X01_CS8900_VIRT_BASE, 0};
 static unsigned int cs8900_irq_map[] = {IRQ_IXDP2X01_CS8900, 0, 0, 0};
-#elif defined(CONFIG_ARCH_PNX0105)
+#elif defined(CONFIG_ARCH_PNX010X)
 #include <asm/irq.h>
 #include <asm/arch/gpio.h>
 #define CIRRUS_DEFAULT_BASE     IO_ADDRESS(EXT_STATIC2_s0_BASE + 0x200000)      /* = Physical address 0x48200000 */
@@ -338,30 +338,86 @@ out:
 }
 #endif
 
+#if defined(CONFIG_ARCH_IXDP2X01)
 static int
-readreg(struct net_device *dev, int portno)
+readword(unsigned long base_addr, int portno)
 {
-        outw(portno, dev->base_addr + ADD_PORT);
-        return inw(dev->base_addr + DATA_PORT);
+        return (u16)__raw_readl(base_addr + (portno << 1));
 }
 
 static void
-writereg(struct net_device *dev, int portno, int value)
+writeword(unsigned long base_addr, int portno, int value)
 {
-        outw(portno, dev->base_addr + ADD_PORT);
-        outw(value, dev->base_addr + DATA_PORT);
+        __raw_writel((u16)value, base_addr + (portno << 1));
+}
+#else
+#if defined(CONFIG_ARCH_PNX010X)
+static int
+readword(unsigned long base_addr, int portno)
+{
+        return inw(base_addr + (portno << 1));
+}
+
+static void
+writeword(unsigned long base_addr, int portno, int value)
+{
+        outw(value, base_addr + (portno << 1));
+}
+#else
+static int
+readword(unsigned long base_addr, int portno)
+{
+        return inw(base_addr + portno);
+}
+
+static void
+writeword(unsigned long base_addr, int portno, int value)
+{
+        outw(value, base_addr + portno);
+}
+#endif
+#endif
+
+static void
+readwords(unsigned long base_addr, int portno, void *buf, int length)
+{
+        u8 *buf8 = (u8 *)buf;
+
+        do {
+                u32 tmp32;
+
+                tmp32 = readword(base_addr, portno);
+                *buf8++ = (u8)tmp32;
+                *buf8++ = (u8)(tmp32 >> 8);
+        } while (--length);
+}
+
+static void
+writewords(unsigned long base_addr, int portno, void *buf, int length)
+{
+        u8 *buf8 = (u8 *)buf;
+
+        do {
+                u32 tmp32;
+
+                tmp32 = *buf8++;
+                tmp32 |= (*buf8++) << 8;
+                writeword(base_addr, portno, tmp32);
+        } while (--length);
 }
 
 static int
-readword(struct net_device *dev, int portno)
+readreg(struct net_device *dev, int regno)
 {
-        return inw(dev->base_addr + portno);
+        writeword(dev->base_addr, ADD_PORT, regno);
+        return readword(dev->base_addr, DATA_PORT);
 }
 
 static void
-writeword(struct net_device *dev, int portno, int value)
+writereg(struct net_device *dev, int regno, int value)
 {
-        outw(value, dev->base_addr + portno);
+        writeword(dev->base_addr, ADD_PORT, regno);
+        writeword(dev->base_addr, DATA_PORT, value);
 }
 
 static int __init
@@ -456,7 +512,7 @@ cs89x0_probe1(struct net_device *dev, int ioaddr, int modular)
 #endif
         }
 
-#ifdef CONFIG_ARCH_PNX0105
+#ifdef CONFIG_ARCH_PNX010X
         initialize_ebi();
 
         /* Map GPIO registers for the pins connected to the CS8900a. */
@@ -491,8 +547,8 @@ cs89x0_probe1(struct net_device *dev, int ioaddr, int modular)
 
 #ifdef CONFIG_SH_HICOSH4
         /* truely reset the chip */
-        outw(0x0114, ioaddr + ADD_PORT);
-        outw(0x0040, ioaddr + DATA_PORT);
+        writeword(ioaddr, ADD_PORT, 0x0114);
+        writeword(ioaddr, DATA_PORT, 0x0040);
 #endif
 
         /* if they give us an odd I/O address, then do ONE write to
@@ -503,24 +559,24 @@ cs89x0_probe1(struct net_device *dev, int ioaddr, int modular)
                 if (net_debug > 1)
                         printk(KERN_INFO "%s: odd ioaddr 0x%x\n", dev->name, ioaddr);
                 if ((ioaddr & 2) != 2)
-                        if ((inw((ioaddr & ~3)+ ADD_PORT) & ADD_MASK) != ADD_SIG) {
+                        if ((readword(ioaddr & ~3, ADD_PORT) & ADD_MASK) != ADD_SIG) {
                                 printk(KERN_ERR "%s: bad signature 0x%x\n",
-                                        dev->name, inw((ioaddr & ~3)+ ADD_PORT));
+                                        dev->name, readword(ioaddr & ~3, ADD_PORT));
                                 retval = -ENODEV;
                                 goto out2;
                         }
         }
-        printk(KERN_DEBUG "PP_addr at %x: 0x%x\n",
-                        ioaddr + ADD_PORT, inw(ioaddr + ADD_PORT));
+        printk(KERN_DEBUG "PP_addr at %x[%x]: 0x%x\n",
+                        ioaddr, ADD_PORT, readword(ioaddr, ADD_PORT));
 
         ioaddr &= ~3;
-        outw(PP_ChipID, ioaddr + ADD_PORT);
+        writeword(ioaddr, ADD_PORT, PP_ChipID);
 
-        tmp = inw(ioaddr + DATA_PORT);
+        tmp = readword(ioaddr, DATA_PORT);
         if (tmp != CHIP_EISA_ID_SIG) {
-                printk(KERN_DEBUG "%s: incorrect signature at %x: 0x%x!="
+                printk(KERN_DEBUG "%s: incorrect signature at %x[%x]: 0x%x!="
                         CHIP_EISA_ID_SIG_STR "\n",
-                        dev->name, ioaddr + DATA_PORT, tmp);
+                        dev->name, ioaddr, DATA_PORT, tmp);
                 retval = -ENODEV;
                 goto out2;
         }
@@ -724,7 +780,7 @@ cs89x0_probe1(struct net_device *dev, int ioaddr, int modular)
         } else {
                 i = lp->isa_config & INT_NO_MASK;
                 if (lp->chip_type == CS8900) {
-#if defined(CONFIG_ARCH_IXDP2X01) || defined(CONFIG_ARCH_PNX0105)
+#if defined(CONFIG_ARCH_IXDP2X01) || defined(CONFIG_ARCH_PNX010X)
                         i = cs8900_irq_map[0];
 #else
                         /* Translate the IRQ using the IRQ mapping table. */
@@ -790,7 +846,7 @@ cs89x0_probe1(struct net_device *dev, int ioaddr, int modular)
                 goto out3;
         return 0;
 out3:
-        outw(PP_ChipID, dev->base_addr + ADD_PORT);
+        writeword(dev->base_addr, ADD_PORT, PP_ChipID);
 out2:
         release_region(ioaddr & ~3, NETCARD_IO_EXTENT);
 out1:
@@ -970,11 +1026,11 @@ void  __init reset_chip(struct net_device *dev)
 #ifndef CONFIG_ARCH_IXDP2X01
         if (lp->chip_type != CS8900) {
                 /* Hardware problem requires PNP registers to be reconfigured after a reset */
-                outw(PP_CS8920_ISAINT, ioaddr + ADD_PORT);
+                writeword(ioaddr, ADD_PORT, PP_CS8920_ISAINT);
                 outb(dev->irq, ioaddr + DATA_PORT);
                 outb(0,      ioaddr + DATA_PORT + 1);
 
-                outw(PP_CS8920_ISAMemB, ioaddr + ADD_PORT);
+                writeword(ioaddr, ADD_PORT, PP_CS8920_ISAMemB);
                 outb((dev->mem_start >> 16) & 0xff, ioaddr + DATA_PORT);
                 outb((dev->mem_start >> 8) & 0xff,   ioaddr + DATA_PORT + 1);
         }
@@ -1104,8 +1160,8 @@ send_test_pkt(struct net_device *dev)
         memcpy(test_packet,          dev->dev_addr, ETH_ALEN);
         memcpy(test_packet+ETH_ALEN, dev->dev_addr, ETH_ALEN);
 
-        writeword(dev, TX_CMD_PORT, TX_AFTER_ALL);
-        writeword(dev, TX_LEN_PORT, ETH_ZLEN);
+        writeword(dev->base_addr, TX_CMD_PORT, TX_AFTER_ALL);
+        writeword(dev->base_addr, TX_LEN_PORT, ETH_ZLEN);
 
         /* Test to see if the chip has allocated memory for the packet */
         while (jiffies - timenow < 5)
@@ -1115,7 +1171,7 @@ send_test_pkt(struct net_device *dev)
                 return 0;       /* this shouldn't happen */
 
         /* Write the contents of the packet */
-        outsw(dev->base_addr + TX_FRAME_PORT,test_packet,(ETH_ZLEN+1) >>1);
+        writewords(dev->base_addr, TX_FRAME_PORT,test_packet,(ETH_ZLEN+1) >>1);
 
         if (net_debug > 1) printk("Sending test packet ");
         /* wait a couple of jiffies for packet to be received */
@@ -1200,7 +1256,7 @@ net_open(struct net_device *dev)
         int i;
         int ret;
 
-#if !defined(CONFIG_SH_HICOSH4) && !defined(CONFIG_ARCH_PNX0105) /* uses irq#1, so this won't work */
+#if !defined(CONFIG_SH_HICOSH4) && !defined(CONFIG_ARCH_PNX010X) /* uses irq#1, so this won't work */
         if (dev->irq < 2) {
                 /* Allow interrupts to be generated by the chip */
 /* Cirrus' release had this: */
@@ -1231,7 +1287,7 @@ net_open(struct net_device *dev)
         else
 #endif
         {
-#if !defined(CONFIG_ARCH_IXDP2X01) && !defined(CONFIG_ARCH_PNX0105)
+#if !defined(CONFIG_ARCH_IXDP2X01) && !defined(CONFIG_ARCH_PNX010X)
                 if (((1 << dev->irq) & lp->irq_map) == 0) {
                         printk(KERN_ERR "%s: IRQ %d is not in our map of allowable IRQs, which is %x\n",
                                dev->name, dev->irq, lp->irq_map);
@@ -1316,7 +1372,7 @@ net_open(struct net_device *dev)
         case A_CNF_MEDIA_10B_2: result = lp->adapter_cnf & A_CNF_10B_2; break;
         default: result = lp->adapter_cnf & (A_CNF_10B_T | A_CNF_AUI | A_CNF_10B_2);
         }
-#ifdef CONFIG_ARCH_PNX0105
+#ifdef CONFIG_ARCH_PNX010X
         result = A_CNF_10B_T;
 #endif
         if (!result) {
@@ -1457,8 +1513,8 @@ static int net_send_packet(struct sk_buff *skb, struct net_device *dev)
         netif_stop_queue(dev);
 
         /* initiate a transmit sequence */
-        writeword(dev, TX_CMD_PORT, lp->send_cmd);
-        writeword(dev, TX_LEN_PORT, skb->len);
+        writeword(dev->base_addr, TX_CMD_PORT, lp->send_cmd);
+        writeword(dev->base_addr, TX_LEN_PORT, skb->len);
 
         /* Test to see if the chip has allocated memory for the packet */
         if ((readreg(dev, PP_BusST) & READY_FOR_TX_NOW) == 0) {
@@ -1472,7 +1528,7 @@ static int net_send_packet(struct sk_buff *skb, struct net_device *dev)
                 return 1;
         }
         /* Write the contents of the packet */
-        outsw(dev->base_addr + TX_FRAME_PORT,skb->data,(skb->len+1) >>1);
+        writewords(dev->base_addr, TX_FRAME_PORT,skb->data,(skb->len+1) >>1);
         spin_unlock_irq(&lp->lock);
         lp->stats.tx_bytes += skb->len;
         dev->trans_start = jiffies;
@@ -1512,7 +1568,7 @@ static irqreturn_t net_interrupt(int irq, void *dev_id, struct pt_regs * regs)
            course, if you're on a slow machine, and packets are arriving
            faster than you can read them off, you're screwed.  Hasta la
            vista, baby!  */
-        while ((status = readword(dev, ISQ_PORT))) {
+        while ((status = readword(dev->base_addr, ISQ_PORT))) {
                 if (net_debug > 4)printk("%s: event=%04x\n", dev->name, status);
                 handled = 1;
                 switch(status & ISQ_EVENT_MASK) {
@@ -1606,8 +1662,8 @@ net_rx(struct net_device *dev)
         int status, length;
 
         int ioaddr = dev->base_addr;
-        status = inw(ioaddr + RX_FRAME_PORT);
-        length = inw(ioaddr + RX_FRAME_PORT);
+        status = readword(ioaddr, RX_FRAME_PORT);
+        length = readword(ioaddr, RX_FRAME_PORT);
 
         if ((status & RX_OK) == 0) {
                 count_rx_errors(status, lp);
@@ -1626,9 +1682,9 @@ net_rx(struct net_device *dev)
         skb_reserve(skb, 2);    /* longword align L3 header */
         skb->dev = dev;
 
-        insw(ioaddr + RX_FRAME_PORT, skb_put(skb, length), length >> 1);
+        readwords(ioaddr, RX_FRAME_PORT, skb_put(skb, length), length >> 1);
         if (length & 1)
-                skb->data[length-1] = inw(ioaddr + RX_FRAME_PORT);
+                skb->data[length-1] = readword(ioaddr, RX_FRAME_PORT);
 
         if (net_debug > 3) {
                 printk( "%s: received %d byte packet of type %x\n",
@@ -1901,7 +1957,7 @@ void
 cleanup_module(void)
 {
         unregister_netdev(dev_cs89x0);
-        outw(PP_ChipID, dev_cs89x0->base_addr + ADD_PORT);
+        writeword(dev_cs89x0->base_addr, ADD_PORT, PP_ChipID);
         release_region(dev_cs89x0->base_addr, NETCARD_IO_EXTENT);
         free_netdev(dev_cs89x0);
 }
diff --git a/drivers/net/cs89x0.h b/drivers/net/cs89x0.h
index decea264f121..bd954aaa636f 100644
--- a/drivers/net/cs89x0.h
+++ b/drivers/net/cs89x0.h
@@ -16,13 +16,6 @@
 
 #include <linux/config.h>
 
-#if defined(CONFIG_ARCH_IXDP2X01) || defined(CONFIG_ARCH_PNX0105)
-/* IXDP2401/IXDP2801 uses dword-aligned register addressing */
-#define CS89x0_PORT(reg) ((reg) * 2)
-#else
-#define CS89x0_PORT(reg) (reg)
-#endif
-
 #define PP_ChipID 0x0000        /* offset   0h -> Corp -ID              */
                                 /* offset   2h -> Model/Product Number  */
                                 /* offset   3h -> Chip Revision Number  */
@@ -332,16 +325,16 @@
 #define RAM_SIZE        0x1000       /*  The card has 4k bytes or RAM */
 #define PKT_START PP_TxFrame  /*  Start of packet RAM */
 
-#define RX_FRAME_PORT   CS89x0_PORT(0x0000)
+#define RX_FRAME_PORT   0x0000
 #define TX_FRAME_PORT RX_FRAME_PORT
-#define TX_CMD_PORT     CS89x0_PORT(0x0004)
+#define TX_CMD_PORT     0x0004
 #define TX_NOW          0x0000       /*  Tx packet after   5 bytes copied */
 #define TX_AFTER_381    0x0040       /*  Tx packet after 381 bytes copied */
 #define TX_AFTER_ALL    0x00c0       /*  Tx packet after all bytes copied */
-#define TX_LEN_PORT     CS89x0_PORT(0x0006)
-#define ISQ_PORT        CS89x0_PORT(0x0008)
-#define ADD_PORT        CS89x0_PORT(0x000A)
-#define DATA_PORT       CS89x0_PORT(0x000C)
+#define TX_LEN_PORT     0x0006
+#define ISQ_PORT        0x0008
+#define ADD_PORT        0x000A
+#define DATA_PORT       0x000C
 
 #define EEPROM_WRITE_EN         0x00F0
 #define EEPROM_WRITE_DIS        0x0000
diff --git a/drivers/net/hamradio/mkiss.c b/drivers/net/hamradio/mkiss.c
index 3e9accf137e7..41b3d83c2ab8 100644
--- a/drivers/net/hamradio/mkiss.c
+++ b/drivers/net/hamradio/mkiss.c
@@ -524,6 +524,7 @@ static void ax_encaps(struct net_device *dev, unsigned char *icp, int len)
         ax->dev->trans_start = jiffies;
         ax->xleft = count - actual;
         ax->xhead = ax->xbuff + actual;
+        spin_unlock_bh(&ax->buflock);
 }
 
 /* Encapsulate an AX.25 packet and kick it into a TTY queue. */
diff --git a/drivers/net/irda/vlsi_ir.h b/drivers/net/irda/vlsi_ir.h
index 741aecc655df..a82a4ba8de4f 100644
--- a/drivers/net/irda/vlsi_ir.h
+++ b/drivers/net/irda/vlsi_ir.h
@@ -577,8 +577,8 @@ struct ring_descr_hw {
                 struct {
                         u8              addr_res[3];
                         volatile u8     status;         /* descriptor status */
-                } rd_s __attribute__((packed));
-        } rd_u __attribute((packed));
+                } __attribute__((packed)) rd_s;
+        } __attribute((packed)) rd_u;
 } __attribute__ ((packed));
 
 #define rd_addr         rd_u.addr
diff --git a/drivers/net/smc91x.c b/drivers/net/smc91x.c
index 28bf2e69eb5e..7ec08127c9d6 100644
--- a/drivers/net/smc91x.c
+++ b/drivers/net/smc91x.c
@@ -88,7 +88,6 @@ static const char version[] =
 #include <linux/skbuff.h>
 
 #include <asm/io.h>
-#include <asm/irq.h>
 
 #include "smc91x.h"
 
@@ -2007,12 +2006,10 @@ static int __init smc_probe(struct net_device *dev, void __iomem *ioaddr)
         }
 
         /* Grab the IRQ */
-        retval = request_irq(dev->irq, &smc_interrupt, 0, dev->name, dev);
+        retval = request_irq(dev->irq, &smc_interrupt, SMC_IRQ_FLAGS, dev->name, dev);
         if (retval)
                 goto err_out;
 
-        set_irq_type(dev->irq, SMC_IRQ_TRIGGER_TYPE);
-
 #ifdef SMC_USE_PXA_DMA
         {
                 int dma = pxa_request_dma(dev->name, DMA_PRIO_LOW,
diff --git a/drivers/net/smc91x.h b/drivers/net/smc91x.h
index 5c2824be4ee6..e0efd1964e72 100644
--- a/drivers/net/smc91x.h
+++ b/drivers/net/smc91x.h
@@ -90,7 +90,7 @@
                         __l--;                                          \
                 }                                                       \
         } while (0)
-#define set_irq_type(irq, type)
+#define SMC_IRQ_FLAGS           (0)
 
 #elif defined(CONFIG_SA1100_PLEB)
 /* We can only do 16-bit reads and writes in the static memory space. */
@@ -109,7 +109,7 @@
 #define SMC_outw(v, a, r)       writew(v, (a) + (r))
 #define SMC_outsw(a, r, p, l)   writesw((a) + (r), p, l)
 
-#define set_irq_type(irq, type) do {} while (0)
+#define SMC_IRQ_FLAGS           (0)
 
 #elif defined(CONFIG_SA1100_ASSABET)
 
@@ -185,11 +185,11 @@ SMC_outw(u16 val, void __iomem *ioaddr, int reg)
 #include <asm/mach-types.h>
 #include <asm/arch/cpu.h>
 
-#define SMC_IRQ_TRIGGER_TYPE (( \
+#define SMC_IRQ_FLAGS (( \
                    machine_is_omap_h2() \
                 || machine_is_omap_h3() \
                 || (machine_is_omap_innovator() && !cpu_is_omap1510()) \
-        ) ? IRQT_FALLING : IRQT_RISING)
+        ) ? SA_TRIGGER_FALLING : SA_TRIGGER_RISING)
 
 
 #elif   defined(CONFIG_SH_SH4202_MICRODEV)
@@ -209,7 +209,7 @@ SMC_outw(u16 val, void __iomem *ioaddr, int reg)
 #define SMC_insw(a, r, p, l)    insw((a) + (r) - 0xa0000000, p, l)
 #define SMC_outsw(a, r, p, l)   outsw((a) + (r) - 0xa0000000, p, l)
 
-#define set_irq_type(irq, type) do {} while(0)
+#define SMC_IRQ_FLAGS           (0)
 
 #elif   defined(CONFIG_ISA)
 
@@ -237,7 +237,7 @@ SMC_outw(u16 val, void __iomem *ioaddr, int reg)
 #define SMC_insw(a, r, p, l)    insw(((u32)a) + (r), p, l)
 #define SMC_outsw(a, r, p, l)   outsw(((u32)a) + (r), p, l)
 
-#define set_irq_type(irq, type) do {} while(0)
+#define SMC_IRQ_FLAGS           (0)
 
 #define RPC_LSA_DEFAULT         RPC_LED_TX_RX
 #define RPC_LSB_DEFAULT         RPC_LED_100_10
@@ -319,7 +319,7 @@ static inline void SMC_outsw (unsigned long a, int r, unsigned char* p, int l)
                         au_writew(*_p++ , _a); \
         } while(0)
 
-#define set_irq_type(irq, type) do {} while (0)
+#define SMC_IRQ_FLAGS           (0)
 
 #else
 
@@ -342,8 +342,8 @@ static inline void SMC_outsw (unsigned long a, int r, unsigned char* p, int l)
 
 #endif
 
-#ifndef SMC_IRQ_TRIGGER_TYPE
-#define SMC_IRQ_TRIGGER_TYPE    IRQT_RISING
+#ifndef SMC_IRQ_FLAGS
+#define SMC_IRQ_FLAGS           SA_TRIGGER_RISING
 #endif
 
 #ifdef SMC_USE_PXA_DMA
diff --git a/drivers/net/wan/sdla.c b/drivers/net/wan/sdla.c
index 036adc4f8ba7..22e794071cf4 100644
--- a/drivers/net/wan/sdla.c
+++ b/drivers/net/wan/sdla.c
@@ -329,9 +329,9 @@ static int sdla_cpuspeed(struct net_device *dev, struct ifreq *ifr)
 
 struct _dlci_stat 
 {
-        short dlci              __attribute__((packed));
-        char  flags             __attribute__((packed));
-};
+        short dlci;
+        char  flags;
+} __attribute__((packed));
 
 struct _frad_stat 
 {