5 files changed, 26 insertions, 45 deletions

diff --git a/drivers/net/wireless/bcm43xx/bcm43xx_main.c b/drivers/net/wireless/bcm43xx/bcm43xx_main.c
index d8f5600578b4..df317c1e12a8 100644
--- a/drivers/net/wireless/bcm43xx/bcm43xx_main.c
+++ b/drivers/net/wireless/bcm43xx/bcm43xx_main.c
@@ -1547,7 +1547,7 @@ static void handle_irq_noise(struct bcm43xx_private *bcm)
                 goto generate_new;
 
         /* Get the noise samples. */
-        assert(bcm->noisecalc.nr_samples <= 8);
+        assert(bcm->noisecalc.nr_samples < 8);
         i = bcm->noisecalc.nr_samples;
         noise[0] = limit_value(noise[0], 0, ARRAY_SIZE(radio->nrssi_lt) - 1);
         noise[1] = limit_value(noise[1], 0, ARRAY_SIZE(radio->nrssi_lt) - 1);
@@ -1885,6 +1885,15 @@ static irqreturn_t bcm43xx_interrupt_handler(int irq, void *dev_id, struct pt_re
 
         spin_lock(&bcm->irq_lock);
 
+        /* Only accept IRQs, if we are initialized properly.
+         * This avoids an RX race while initializing.
+         * We should probably not enable IRQs before we are initialized
+         * completely, but some careful work is needed to fix this. I think it
+         * is best to stay with this cheap workaround for now... .
+         */
+        if (unlikely(bcm43xx_status(bcm) != BCM43xx_STAT_INITIALIZED))
+                goto out;
+
         reason = bcm43xx_read32(bcm, BCM43xx_MMIO_GEN_IRQ_REASON);
         if (reason == 0xffffffff) {
                 /* irq not for us (shared irq) */
@@ -1906,19 +1915,11 @@ static irqreturn_t bcm43xx_interrupt_handler(int irq, void *dev_id, struct pt_re
 
         bcm43xx_interrupt_ack(bcm, reason);
 
-        /* Only accept IRQs, if we are initialized properly.
-         * This avoids an RX race while initializing.
-         * We should probably not enable IRQs before we are initialized
-         * completely, but some careful work is needed to fix this. I think it
-         * is best to stay with this cheap workaround for now... .
-         */
-        if (likely(bcm43xx_status(bcm) == BCM43xx_STAT_INITIALIZED)) {
-                /* disable all IRQs. They are enabled again in the bottom half. */
-                bcm->irq_savedstate = bcm43xx_interrupt_disable(bcm, BCM43xx_IRQ_ALL);
-                /* save the reason code and call our bottom half. */
-                bcm->irq_reason = reason;
-                tasklet_schedule(&bcm->isr_tasklet);
-        }
+        /* disable all IRQs. They are enabled again in the bottom half. */
+        bcm->irq_savedstate = bcm43xx_interrupt_disable(bcm, BCM43xx_IRQ_ALL);
+        /* save the reason code and call our bottom half. */
+        bcm->irq_reason = reason;
+        tasklet_schedule(&bcm->isr_tasklet);
 
 out:
         mmiowb();
@@ -3698,6 +3699,10 @@ static void bcm43xx_ieee80211_set_security(struct net_device *net_dev,
                 secinfo->encrypt = sec->encrypt;
                 dprintk(", .encrypt = %d", sec->encrypt);
         }
+        if (sec->flags & SEC_AUTH_MODE) {
+                secinfo->auth_mode = sec->auth_mode;
+                dprintk(", .auth_mode = %d", sec->auth_mode);
+        }
         dprintk("\n");
         if (bcm43xx_status(bcm) == BCM43xx_STAT_INITIALIZED &&
             !bcm->ieee->host_encrypt) {
diff --git a/drivers/net/wireless/bcm43xx/bcm43xx_main.h b/drivers/net/wireless/bcm43xx/bcm43xx_main.h
index 30a202b258b5..116493671f88 100644
--- a/drivers/net/wireless/bcm43xx/bcm43xx_main.h
+++ b/drivers/net/wireless/bcm43xx/bcm43xx_main.h
@@ -112,30 +112,6 @@ int bcm43xx_channel_to_freq(struct bcm43xx_private *bcm,
         return bcm43xx_channel_to_freq_bg(channel);
 }
 
-/* Lightweight function to check if a channel number is valid.
- * Note that this does _NOT_ check for geographical restrictions!
- */
-static inline
-int bcm43xx_is_valid_channel_a(u8 channel)
-{
-        return (channel >= IEEE80211_52GHZ_MIN_CHANNEL
-               && channel <= IEEE80211_52GHZ_MAX_CHANNEL);
-}
-static inline
-int bcm43xx_is_valid_channel_bg(u8 channel)
-{
-        return (channel >= IEEE80211_24GHZ_MIN_CHANNEL
-               && channel <= IEEE80211_24GHZ_MAX_CHANNEL);
-}
-static inline
-int bcm43xx_is_valid_channel(struct bcm43xx_private *bcm,
-                             u8 channel)
-{
-        if (bcm43xx_current_phy(bcm)->type == BCM43xx_PHYTYPE_A)
-                return bcm43xx_is_valid_channel_a(channel);
-        return bcm43xx_is_valid_channel_bg(channel);
-}
-
 void bcm43xx_tsf_read(struct bcm43xx_private *bcm, u64 *tsf);
 void bcm43xx_tsf_write(struct bcm43xx_private *bcm, u64 tsf);
 
diff --git a/drivers/net/wireless/bcm43xx/bcm43xx_radio.c b/drivers/net/wireless/bcm43xx/bcm43xx_radio.c
index af5c0bff1696..bb9c484d7e19 100644
--- a/drivers/net/wireless/bcm43xx/bcm43xx_radio.c
+++ b/drivers/net/wireless/bcm43xx/bcm43xx_radio.c
@@ -1594,11 +1594,11 @@ int bcm43xx_radio_selectchannel(struct bcm43xx_private *bcm,
         u16 r8, tmp;
         u16 freq;
 
+        if (!ieee80211_is_valid_channel(bcm->ieee, channel))
+                return -EINVAL;
         if ((radio->manufact == 0x17F) &&
             (radio->version == 0x2060) &&
             (radio->revision == 1)) {
-                if (channel > 200)
-                        return -EINVAL;
                 freq = channel2freq_a(channel);
 
                 r8 = bcm43xx_radio_read16(bcm, 0x0008);
@@ -1651,9 +1651,6 @@ int bcm43xx_radio_selectchannel(struct bcm43xx_private *bcm,
                 TODO(); //TODO: TSSI2dbm workaround
                 bcm43xx_phy_xmitpower(bcm);//FIXME correct?
         } else {
-                if ((channel < 1) || (channel > 14))
-                        return -EINVAL;
-
                 if (synthetic_pu_workaround)
                         bcm43xx_synth_pu_workaround(bcm, channel);
 
diff --git a/drivers/net/wireless/bcm43xx/bcm43xx_wx.c b/drivers/net/wireless/bcm43xx/bcm43xx_wx.c
index c35cb3a0777e..5c36e29efff7 100644
--- a/drivers/net/wireless/bcm43xx/bcm43xx_wx.c
+++ b/drivers/net/wireless/bcm43xx/bcm43xx_wx.c
@@ -119,7 +119,7 @@ static int bcm43xx_wx_set_channelfreq(struct net_device *net_dev,
                 channel = bcm43xx_freq_to_channel(bcm, data->freq.m);
                 freq = data->freq.m;
         }
-        if (!bcm43xx_is_valid_channel(bcm, channel))
+        if (!ieee80211_is_valid_channel(bcm->ieee, channel))
                 goto out_unlock;
         if (bcm43xx_status(bcm) == BCM43xx_STAT_INITIALIZED) {
                 //ieee80211softmac_disassoc(softmac, $REASON);
diff --git a/drivers/net/wireless/bcm43xx/bcm43xx_xmit.c b/drivers/net/wireless/bcm43xx/bcm43xx_xmit.c
index d8ece28c079f..6dbd855b3647 100644
--- a/drivers/net/wireless/bcm43xx/bcm43xx_xmit.c
+++ b/drivers/net/wireless/bcm43xx/bcm43xx_xmit.c
@@ -296,11 +296,14 @@ void bcm43xx_generate_txhdr(struct bcm43xx_private *bcm,
         u16 control = 0;
         u16 wsec_rate = 0;
         u16 encrypt_frame;
+        const u16 ftype = WLAN_FC_GET_TYPE(le16_to_cpu(wireless_header->frame_ctl));
+        const int is_mgt = (ftype == IEEE80211_FTYPE_MGMT);
 
         /* Now construct the TX header. */
         memset(txhdr, 0, sizeof(*txhdr));
 
-        bitrate = bcm->softmac->txrates.default_rate;
+        bitrate = ieee80211softmac_suggest_txrate(bcm->softmac,
+                is_multicast_ether_addr(wireless_header->addr1), is_mgt);
         ofdm_modulation = !(ieee80211_is_cck_rate(bitrate));
         fallback_bitrate = bcm43xx_calc_fallback_rate(bitrate);
         fallback_ofdm_modulation = !(ieee80211_is_cck_rate(fallback_bitrate));