5 files changed, 32 insertions, 23 deletions

diff --git a/drivers/net/wan/cycx_x25.c b/drivers/net/wan/cycx_x25.c
index cd8cb95c5bd7..cf9e15fd8d91 100644
--- a/drivers/net/wan/cycx_x25.c
+++ b/drivers/net/wan/cycx_x25.c
@@ -634,11 +634,12 @@ static netdev_tx_t cycx_netdevice_hard_start_xmit(struct sk_buff *skb,
         }
         } else { /* chan->protocol == ETH_P_X25 */
                 switch (skb->data[0]) {
-                case 0: break;
-                case 1: /* Connect request */
+                case X25_IFACE_DATA:
+                        break;
+                case X25_IFACE_CONNECT:
                         cycx_x25_chan_connect(dev);
                         goto free_packet;
-                case 2: /* Disconnect request */
+                case X25_IFACE_DISCONNECT:
                         cycx_x25_chan_disconnect(dev);
                         goto free_packet;
                 default:
@@ -1406,7 +1407,8 @@ static void cycx_x25_set_chan_state(struct net_device *dev, u8 state)
                         reset_timer(dev);
 
                         if (chan->protocol == ETH_P_X25)
-                                cycx_x25_chan_send_event(dev, 1);
+                                cycx_x25_chan_send_event(dev,
+                                        X25_IFACE_CONNECT);
 
                         break;
                 case WAN_CONNECTING:
@@ -1424,7 +1426,8 @@ static void cycx_x25_set_chan_state(struct net_device *dev, u8 state)
                         }
 
                         if (chan->protocol == ETH_P_X25)
-                                cycx_x25_chan_send_event(dev, 2);
+                                cycx_x25_chan_send_event(dev,
+                                        X25_IFACE_DISCONNECT);
 
                         netif_wake_queue(dev);
                         break;
diff --git a/drivers/net/wan/hdlc_ppp.c b/drivers/net/wan/hdlc_ppp.c
index b9b9d6b01c0b..941f053e650e 100644
--- a/drivers/net/wan/hdlc_ppp.c
+++ b/drivers/net/wan/hdlc_ppp.c
@@ -628,9 +628,15 @@ static void ppp_stop(struct net_device *dev)
         ppp_cp_event(dev, PID_LCP, STOP, 0, 0, 0, NULL);
 }
 
+static void ppp_close(struct net_device *dev)
+{
+        ppp_tx_flush();
+}
+
 static struct hdlc_proto proto = {
         .start          = ppp_start,
         .stop           = ppp_stop,
+        .close          = ppp_close,
         .type_trans     = ppp_type_trans,
         .ioctl          = ppp_ioctl,
         .netif_rx       = ppp_rx,
diff --git a/drivers/net/wan/hdlc_x25.c b/drivers/net/wan/hdlc_x25.c
index c7adbb79f7cc..70527e5a54a2 100644
--- a/drivers/net/wan/hdlc_x25.c
+++ b/drivers/net/wan/hdlc_x25.c
@@ -49,14 +49,14 @@ static void x25_connect_disconnect(struct net_device *dev, int reason, int code)
 
 static void x25_connected(struct net_device *dev, int reason)
 {
-        x25_connect_disconnect(dev, reason, 1);
+        x25_connect_disconnect(dev, reason, X25_IFACE_CONNECT);
 }
 
 
 
 static void x25_disconnected(struct net_device *dev, int reason)
 {
-        x25_connect_disconnect(dev, reason, 2);
+        x25_connect_disconnect(dev, reason, X25_IFACE_DISCONNECT);
 }
 
 
@@ -71,7 +71,7 @@ static int x25_data_indication(struct net_device *dev, struct sk_buff *skb)
                 return NET_RX_DROP;
 
         ptr  = skb->data;
-        *ptr = 0;
+        *ptr = X25_IFACE_DATA;
 
         skb->protocol = x25_type_trans(skb, dev);
         return netif_rx(skb);
@@ -94,13 +94,13 @@ static netdev_tx_t x25_xmit(struct sk_buff *skb, struct net_device *dev)
 
         /* X.25 to LAPB */
         switch (skb->data[0]) {
-        case 0:         /* Data to be transmitted */
+        case X25_IFACE_DATA:    /* Data to be transmitted */
                 skb_pull(skb, 1);
                 if ((result = lapb_data_request(dev, skb)) != LAPB_OK)
                         dev_kfree_skb(skb);
                 return NETDEV_TX_OK;
 
-        case 1:
+        case X25_IFACE_CONNECT:
                 if ((result = lapb_connect_request(dev))!= LAPB_OK) {
                         if (result == LAPB_CONNECTED)
                                 /* Send connect confirm. msg to level 3 */
@@ -112,7 +112,7 @@ static netdev_tx_t x25_xmit(struct sk_buff *skb, struct net_device *dev)
                 }
                 break;
 
-        case 2:
+        case X25_IFACE_DISCONNECT:
                 if ((result = lapb_disconnect_request(dev)) != LAPB_OK) {
                         if (result == LAPB_NOTCONNECTED)
                                 /* Send disconnect confirm. msg to level 3 */
diff --git a/drivers/net/wan/lapbether.c b/drivers/net/wan/lapbether.c
index 98e2f99903d7..4d4dc38c7290 100644
--- a/drivers/net/wan/lapbether.c
+++ b/drivers/net/wan/lapbether.c
@@ -139,7 +139,7 @@ static int lapbeth_data_indication(struct net_device *dev, struct sk_buff *skb)
                 return NET_RX_DROP;
 
         ptr  = skb->data;
-        *ptr = 0x00;
+        *ptr = X25_IFACE_DATA;
 
         skb->protocol = x25_type_trans(skb, dev);
         return netif_rx(skb);
@@ -161,14 +161,14 @@ static netdev_tx_t lapbeth_xmit(struct sk_buff *skb,
                 goto drop;
 
         switch (skb->data[0]) {
-        case 0x00:
+        case X25_IFACE_DATA:
                 break;
-        case 0x01:
+        case X25_IFACE_CONNECT:
                 if ((err = lapb_connect_request(dev)) != LAPB_OK)
                         printk(KERN_ERR "lapbeth: lapb_connect_request "
                                "error: %d\n", err);
                 goto drop;
-        case 0x02:
+        case X25_IFACE_DISCONNECT:
                 if ((err = lapb_disconnect_request(dev)) != LAPB_OK)
                         printk(KERN_ERR "lapbeth: lapb_disconnect_request "
                                "err: %d\n", err);
@@ -225,7 +225,7 @@ static void lapbeth_connected(struct net_device *dev, int reason)
         }
 
         ptr  = skb_put(skb, 1);
-        *ptr = 0x01;
+        *ptr = X25_IFACE_CONNECT;
 
         skb->protocol = x25_type_trans(skb, dev);
         netif_rx(skb);
@@ -242,7 +242,7 @@ static void lapbeth_disconnected(struct net_device *dev, int reason)
         }
 
         ptr  = skb_put(skb, 1);
-        *ptr = 0x02;
+        *ptr = X25_IFACE_DISCONNECT;
 
         skb->protocol = x25_type_trans(skb, dev);
         netif_rx(skb);
diff --git a/drivers/net/wan/x25_asy.c b/drivers/net/wan/x25_asy.c
index 80d5c5834a0b..166e77dfffda 100644
--- a/drivers/net/wan/x25_asy.c
+++ b/drivers/net/wan/x25_asy.c
@@ -29,12 +29,12 @@
 #include <linux/etherdevice.h>
 #include <linux/skbuff.h>
 #include <linux/if_arp.h>
-#include <linux/x25.h>
 #include <linux/lapb.h>
 #include <linux/init.h>
 #include <linux/rtnetlink.h>
 #include <linux/compat.h>
 #include <linux/slab.h>
+#include <net/x25device.h>
 #include "x25_asy.h"
 
 #include <net/x25device.h>
@@ -315,15 +315,15 @@ static netdev_tx_t x25_asy_xmit(struct sk_buff *skb,
         }
 
         switch (skb->data[0]) {
-        case 0x00:
+        case X25_IFACE_DATA:
                 break;
-        case 0x01: /* Connection request .. do nothing */
+        case X25_IFACE_CONNECT: /* Connection request .. do nothing */
                 err = lapb_connect_request(dev);
                 if (err != LAPB_OK)
                         printk(KERN_ERR "x25_asy: lapb_connect_request error - %d\n", err);
                 kfree_skb(skb);
                 return NETDEV_TX_OK;
-        case 0x02: /* Disconnect request .. do nothing - hang up ?? */
+        case X25_IFACE_DISCONNECT: /* do nothing - hang up ?? */
                 err = lapb_disconnect_request(dev);
                 if (err != LAPB_OK)
                         printk(KERN_ERR "x25_asy: lapb_disconnect_request error - %d\n", err);
@@ -411,7 +411,7 @@ static void x25_asy_connected(struct net_device *dev, int reason)
         }
 
         ptr  = skb_put(skb, 1);
-        *ptr = 0x01;
+        *ptr = X25_IFACE_CONNECT;
 
         skb->protocol = x25_type_trans(skb, sl->dev);
         netif_rx(skb);
@@ -430,7 +430,7 @@ static void x25_asy_disconnected(struct net_device *dev, int reason)
         }
 
         ptr  = skb_put(skb, 1);
-        *ptr = 0x02;
+        *ptr = X25_IFACE_DISCONNECT;
 
         skb->protocol = x25_type_trans(skb, sl->dev);
         netif_rx(skb);