8 files changed, 69 insertions, 105 deletions

diff --git a/drivers/net/usb/asix.c b/drivers/net/usb/asix.c
index 35f56fc82803..8e7d2374558b 100644
--- a/drivers/net/usb/asix.c
+++ b/drivers/net/usb/asix.c
@@ -558,16 +558,14 @@ static void asix_set_multicast(struct net_device *net)
                  * for our 8 byte filter buffer
                  * to avoid allocating memory that
                  * is tricky to free later */
-                struct dev_mc_list *mc_list;
+                struct netdev_hw_addr *ha;
                 u32 crc_bits;
 
                 memset(data->multi_filter, 0, AX_MCAST_FILTER_SIZE);
 
                 /* Build the multicast hash filter. */
-                netdev_for_each_mc_addr(mc_list, net) {
-                        crc_bits =
-                            ether_crc(ETH_ALEN,
-                                      mc_list->dmi_addr) >> 26;
+                netdev_for_each_mc_addr(ha, net) {
+                        crc_bits = ether_crc(ETH_ALEN, ha->addr) >> 26;
                         data->multi_filter[crc_bits >> 3] |=
                             1 << (crc_bits & 7);
                 }
@@ -794,16 +792,14 @@ static void ax88172_set_multicast(struct net_device *net)
                  * for our 8 byte filter buffer
                  * to avoid allocating memory that
                  * is tricky to free later */
-                struct dev_mc_list *mc_list;
+                struct netdev_hw_addr *ha;
                 u32 crc_bits;
 
                 memset(data->multi_filter, 0, AX_MCAST_FILTER_SIZE);
 
                 /* Build the multicast hash filter. */
-                netdev_for_each_mc_addr(mc_list, net) {
-                        crc_bits =
-                            ether_crc(ETH_ALEN,
-                                      mc_list->dmi_addr) >> 26;
+                netdev_for_each_mc_addr(ha, net) {
+                        crc_bits = ether_crc(ETH_ALEN, ha->addr) >> 26;
                         data->multi_filter[crc_bits >> 3] |=
                             1 << (crc_bits & 7);
                 }
diff --git a/drivers/net/usb/catc.c b/drivers/net/usb/catc.c
index 602e123b2741..97687d335903 100644
--- a/drivers/net/usb/catc.c
+++ b/drivers/net/usb/catc.c
@@ -629,7 +629,7 @@ static void catc_multicast(unsigned char *addr, u8 *multicast)
 static void catc_set_multicast_list(struct net_device *netdev)
 {
         struct catc *catc = netdev_priv(netdev);
-        struct dev_mc_list *mc;
+        struct netdev_hw_addr *ha;
         u8 broadcast[6];
         u8 rx = RxEnable | RxPolarity | RxMultiCast;
 
@@ -647,8 +647,8 @@ static void catc_set_multicast_list(struct net_device *netdev)
         if (netdev->flags & IFF_ALLMULTI) {
                 memset(catc->multicast, 0xff, 64);
         } else {
-                netdev_for_each_mc_addr(mc, netdev) {
-                        u32 crc = ether_crc_le(6, mc->dmi_addr);
+                netdev_for_each_mc_addr(ha, netdev) {
+                        u32 crc = ether_crc_le(6, ha->addr);
                         if (!catc->is_f5u011) {
                                 catc->multicast[(crc >> 3) & 0x3f] |= 1 << (crc & 7);
                         } else {
diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ether.c
index 3547cf13d219..b3fe0de40469 100644
--- a/drivers/net/usb/cdc_ether.c
+++ b/drivers/net/usb/cdc_ether.c
@@ -64,6 +64,11 @@ static int is_wireless_rndis(struct usb_interface_descriptor *desc)
 
 #endif
 
+static const u8 mbm_guid[16] = {
+        0xa3, 0x17, 0xa8, 0x8b, 0x04, 0x5e, 0x4f, 0x01,
+        0xa6, 0x07, 0xc0, 0xff, 0xcb, 0x7e, 0x39, 0x2a,
+};
+
 /*
  * probes control interface, claims data interface, collects the bulk
  * endpoints, activates data interface (if needed), maybe sets MTU.
@@ -79,6 +84,8 @@ int usbnet_generic_cdc_bind(struct usbnet *dev, struct usb_interface *intf)
         int                             status;
         int                             rndis;
         struct usb_driver               *driver = driver_of(intf);
+        struct usb_cdc_mdlm_desc        *desc = NULL;
+        struct usb_cdc_mdlm_detail_desc *detail = NULL;
 
         if (sizeof dev->data < sizeof *info)
                 return -EDOM;
@@ -229,6 +236,34 @@ int usbnet_generic_cdc_bind(struct usbnet *dev, struct usb_interface *intf)
                          * side link address we were given.
                          */
                         break;
+                case USB_CDC_MDLM_TYPE:
+                        if (desc) {
+                                dev_dbg(&intf->dev, "extra MDLM descriptor\n");
+                                goto bad_desc;
+                        }
+
+                        desc = (void *)buf;
+
+                        if (desc->bLength != sizeof(*desc))
+                                goto bad_desc;
+
+                        if (memcmp(&desc->bGUID, mbm_guid, 16))
+                                goto bad_desc;
+                        break;
+                case USB_CDC_MDLM_DETAIL_TYPE:
+                        if (detail) {
+                                dev_dbg(&intf->dev, "extra MDLM detail descriptor\n");
+                                goto bad_desc;
+                        }
+
+                        detail = (void *)buf;
+
+                        if (detail->bGuidDescriptorType == 0) {
+                                if (detail->bLength < (sizeof(*detail) + 1))
+                                        goto bad_desc;
+                        } else
+                                goto bad_desc;
+                        break;
                 }
 next_desc:
                 len -= buf [0]; /* bLength */
@@ -543,80 +578,10 @@ static const struct usb_device_id	products [] = {
                         USB_CDC_PROTO_NONE),
         .driver_info = (unsigned long) &cdc_info,
 }, {
-        /* Ericsson F3507g */
-        USB_DEVICE_AND_INTERFACE_INFO(0x0bdb, 0x1900, USB_CLASS_COMM,
-                        USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE),
-        .driver_info = (unsigned long) &mbm_info,
-}, {
-        /* Ericsson F3507g ver. 2 */
-        USB_DEVICE_AND_INTERFACE_INFO(0x0bdb, 0x1902, USB_CLASS_COMM,
-                        USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE),
-        .driver_info = (unsigned long) &mbm_info,
-}, {
-        /* Ericsson F3607gw */
-        USB_DEVICE_AND_INTERFACE_INFO(0x0bdb, 0x1904, USB_CLASS_COMM,
-                        USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE),
-        .driver_info = (unsigned long) &mbm_info,
-}, {
-        /* Ericsson F3607gw ver 2 */
-        USB_DEVICE_AND_INTERFACE_INFO(0x0bdb, 0x1905, USB_CLASS_COMM,
-                        USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE),
-        .driver_info = (unsigned long) &mbm_info,
-}, {
-        /* Ericsson F3607gw ver 3 */
-        USB_DEVICE_AND_INTERFACE_INFO(0x0bdb, 0x1906, USB_CLASS_COMM,
-                        USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE),
-        .driver_info = (unsigned long) &mbm_info,
-}, {
-        /* Ericsson F3307 */
-        USB_DEVICE_AND_INTERFACE_INFO(0x0bdb, 0x190a, USB_CLASS_COMM,
-                        USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE),
-        .driver_info = (unsigned long) &mbm_info,
-}, {
-        /* Ericsson F3307 ver 2 */
-        USB_DEVICE_AND_INTERFACE_INFO(0x0bdb, 0x1909, USB_CLASS_COMM,
-                        USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE),
-        .driver_info = (unsigned long) &mbm_info,
-}, {
-        /* Ericsson C3607w */
-        USB_DEVICE_AND_INTERFACE_INFO(0x0bdb, 0x1049, USB_CLASS_COMM,
-                        USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE),
-        .driver_info = (unsigned long) &mbm_info,
-}, {
-        /* Ericsson C3607w ver 2 */
-        USB_DEVICE_AND_INTERFACE_INFO(0x0bdb, 0x190b, USB_CLASS_COMM,
-                        USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE),
-        .driver_info = (unsigned long) &mbm_info,
-}, {
-        /* Toshiba F3507g */
-        USB_DEVICE_AND_INTERFACE_INFO(0x0930, 0x130b, USB_CLASS_COMM,
-                        USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE),
-        .driver_info = (unsigned long) &mbm_info,
-}, {
-        /* Toshiba F3607gw */
-        USB_DEVICE_AND_INTERFACE_INFO(0x0930, 0x130c, USB_CLASS_COMM,
-                        USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE),
-        .driver_info = (unsigned long) &mbm_info,
-}, {
-        /* Toshiba F3607gw ver 2 */
-        USB_DEVICE_AND_INTERFACE_INFO(0x0930, 0x1311, USB_CLASS_COMM,
-                        USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE),
-        .driver_info = (unsigned long) &mbm_info,
-}, {
-        /* Dell F3507g */
-        USB_DEVICE_AND_INTERFACE_INFO(0x413c, 0x8147, USB_CLASS_COMM,
-                        USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE),
-        .driver_info = (unsigned long) &mbm_info,
-}, {
-        /* Dell F3607gw */
-        USB_DEVICE_AND_INTERFACE_INFO(0x413c, 0x8183, USB_CLASS_COMM,
-                        USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE),
-        .driver_info = (unsigned long) &mbm_info,
-}, {
-        /* Dell F3607gw ver 2 */
-        USB_DEVICE_AND_INTERFACE_INFO(0x413c, 0x8184, USB_CLASS_COMM,
-                        USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE),
-        .driver_info = (unsigned long) &mbm_info,
+        USB_INTERFACE_INFO(USB_CLASS_COMM, USB_CDC_SUBCLASS_MDLM,
+                        USB_CDC_PROTO_NONE),
+        .driver_info = (unsigned long)&mbm_info,
+
 },
         { },            // END
 };
diff --git a/drivers/net/usb/dm9601.c b/drivers/net/usb/dm9601.c
index 04b281002a76..291add255246 100644
--- a/drivers/net/usb/dm9601.c
+++ b/drivers/net/usb/dm9601.c
@@ -387,10 +387,10 @@ static void dm9601_set_multicast(struct net_device *net)
                    netdev_mc_count(net) > DM_MAX_MCAST) {
                 rx_ctl |= 0x04;
         } else if (!netdev_mc_empty(net)) {
-                struct dev_mc_list *mc_list;
+                struct netdev_hw_addr *ha;
 
-                netdev_for_each_mc_addr(mc_list, net) {
-                        u32 crc = ether_crc(ETH_ALEN, mc_list->dmi_addr) >> 26;
+                netdev_for_each_mc_addr(ha, net) {
+                        u32 crc = ether_crc(ETH_ALEN, ha->addr) >> 26;
                         hashes[crc >> 3] |= 1 << (crc & 0x7);
                 }
         }
diff --git a/drivers/net/usb/mcs7830.c b/drivers/net/usb/mcs7830.c
index 9f24e3f871e1..834d8cd3005d 100644
--- a/drivers/net/usb/mcs7830.c
+++ b/drivers/net/usb/mcs7830.c
@@ -453,12 +453,12 @@ static void mcs7830_data_set_multicast(struct net_device *net)
                  * for our 8 byte filter buffer
                  * to avoid allocating memory that
                  * is tricky to free later */
-                struct dev_mc_list *mc_list;
+                struct netdev_hw_addr *ha;
                 u32 crc_bits;
 
                 /* Build the multicast hash filter. */
-                netdev_for_each_mc_addr(mc_list, net) {
-                        crc_bits = ether_crc(ETH_ALEN, mc_list->dmi_addr) >> 26;
+                netdev_for_each_mc_addr(ha, net) {
+                        crc_bits = ether_crc(ETH_ALEN, ha->addr) >> 26;
                         data->multi_filter[crc_bits >> 3] |= 1 << (crc_bits & 7);
                 }
         }
diff --git a/drivers/net/usb/smsc75xx.c b/drivers/net/usb/smsc75xx.c
index 35b98b1b79e4..753ee6eb7edd 100644
--- a/drivers/net/usb/smsc75xx.c
+++ b/drivers/net/usb/smsc75xx.c
@@ -445,14 +445,14 @@ static void smsc75xx_set_multicast(struct net_device *netdev)
                 netif_dbg(dev, drv, dev->net, "receive all multicast enabled");
                 pdata->rfe_ctl |= RFE_CTL_AM | RFE_CTL_DPF;
         } else if (!netdev_mc_empty(dev->net)) {
-                struct dev_mc_list *mc_list;
+                struct netdev_hw_addr *ha;
 
                 netif_dbg(dev, drv, dev->net, "receive multicast hash filter");
 
                 pdata->rfe_ctl |= RFE_CTL_MHF | RFE_CTL_DPF;
 
-                netdev_for_each_mc_addr(mc_list, netdev) {
-                        u32 bitnum = smsc75xx_hash(mc_list->dmi_addr);
+                netdev_for_each_mc_addr(ha, netdev) {
+                        u32 bitnum = smsc75xx_hash(ha->addr);
                         pdata->multicast_hash_table[bitnum / 32] |=
                                 (1 << (bitnum % 32));
                 }
diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
index 3135af63d378..12a3c88c5282 100644
--- a/drivers/net/usb/smsc95xx.c
+++ b/drivers/net/usb/smsc95xx.c
@@ -385,13 +385,13 @@ static void smsc95xx_set_multicast(struct net_device *netdev)
                 pdata->mac_cr |= MAC_CR_MCPAS_;
                 pdata->mac_cr &= ~(MAC_CR_PRMS_ | MAC_CR_HPFILT_);
         } else if (!netdev_mc_empty(dev->net)) {
-                struct dev_mc_list *mc_list;
+                struct netdev_hw_addr *ha;
 
                 pdata->mac_cr |= MAC_CR_HPFILT_;
                 pdata->mac_cr &= ~(MAC_CR_PRMS_ | MAC_CR_MCPAS_);
 
-                netdev_for_each_mc_addr(mc_list, netdev) {
-                        u32 bitnum = smsc95xx_hash(mc_list->dmi_addr);
+                netdev_for_each_mc_addr(ha, netdev) {
+                        u32 bitnum = smsc95xx_hash(ha->addr);
                         u32 mask = 0x01 << (bitnum & 0x1F);
                         if (bitnum & 0x20)
                                 hash_hi |= mask;
diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index 7177abc78dc6..a95c73de5824 100644
--- a/drivers/net/usb/usbnet.c
+++ b/drivers/net/usb/usbnet.c
@@ -1069,12 +1069,15 @@ netdev_tx_t usbnet_start_xmit (struct sk_buff *skb,
          * NOTE:  strictly conforming cdc-ether devices should expect
          * the ZLP here, but ignore the one-byte packet.
          */
-        if (!(info->flags & FLAG_SEND_ZLP) && (length % dev->maxpacket) == 0) {
-                urb->transfer_buffer_length++;
-                if (skb_tailroom(skb)) {
-                        skb->data[skb->len] = 0;
-                        __skb_put(skb, 1);
-                }
+        if (length % dev->maxpacket == 0) {
+                if (!(info->flags & FLAG_SEND_ZLP)) {
+                        urb->transfer_buffer_length++;
+                        if (skb_tailroom(skb)) {
+                                skb->data[skb->len] = 0;
+                                __skb_put(skb, 1);
+                        }
+                } else
+                        urb->transfer_flags |= URB_ZERO_PACKET;
         }
 
         spin_lock_irqsave(&dev->txq.lock, flags);