3 files changed, 20 insertions, 28 deletions

diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index fe98acaead97..a074c16e2a62 100644
--- a/drivers/net/usb/hso.c
+++ b/drivers/net/usb/hso.c
@@ -936,8 +936,7 @@ static void packetizeRx(struct hso_net *odev, unsigned char *ip_pkt,
                         if (!odev->rx_buf_missing) {
                                 /* Packet is complete. Inject into stack. */
                                 /* We have IP packet here */
-                                odev->skb_rx_buf->protocol =
-                                                __constant_htons(ETH_P_IP);
+                                odev->skb_rx_buf->protocol = cpu_to_be16(ETH_P_IP);
                                 /* don't check it */
                                 odev->skb_rx_buf->ip_summed =
                                         CHECKSUM_UNNECESSARY;
@@ -1247,7 +1246,7 @@ static void hso_std_serial_read_bulk_callback(struct urb *urb)
  * This needs to be a tasklet otherwise we will
  * end up recursively calling this function.
  */
-void hso_unthrottle_tasklet(struct hso_serial *serial)
+static void hso_unthrottle_tasklet(struct hso_serial *serial)
 {
         unsigned long flags;
 
@@ -1266,7 +1265,7 @@ static	void hso_unthrottle(struct tty_struct *tty)
         tasklet_hi_schedule(&serial->unthrottle_tasklet);
 }
 
-void hso_unthrottle_workfunc(struct work_struct *work)
+static void hso_unthrottle_workfunc(struct work_struct *work)
 {
         struct hso_serial *serial =
             container_of(work, struct hso_serial,
@@ -1465,9 +1464,9 @@ static int hso_serial_chars_in_buffer(struct tty_struct *tty)
 
         return chars;
 }
-int tiocmget_submit_urb(struct hso_serial *serial,
-                        struct hso_tiocmget  *tiocmget,
-                        struct usb_device *usb)
+static int tiocmget_submit_urb(struct hso_serial *serial,
+                               struct hso_tiocmget *tiocmget,
+                               struct usb_device *usb)
 {
         int result;
 
diff --git a/drivers/net/usb/rndis_host.c b/drivers/net/usb/rndis_host.c
index bcd858c567e0..b7f763e1298c 100644
--- a/drivers/net/usb/rndis_host.c
+++ b/drivers/net/usb/rndis_host.c
@@ -169,7 +169,7 @@ int rndis_command(struct usbnet *dev, struct rndis_msg_hdr *buf, int buflen)
                                 struct rndis_keepalive_c *msg = (void *)buf;
 
                                 msg->msg_type = RNDIS_MSG_KEEPALIVE_C;
-                                msg->msg_len = ccpu2(sizeof *msg);
+                                msg->msg_len = cpu_to_le32(sizeof *msg);
                                 msg->status = RNDIS_STATUS_SUCCESS;
                                 retval = usb_control_msg(dev->udev,
                                         usb_sndctrlpipe(dev->udev, 0),
@@ -237,7 +237,7 @@ static int rndis_query(struct usbnet *dev, struct usb_interface *intf,
         u.get->msg_len = cpu_to_le32(sizeof *u.get + in_len);
         u.get->oid = oid;
         u.get->len = cpu_to_le32(in_len);
-        u.get->offset = ccpu2(20);
+        u.get->offset = cpu_to_le32(20);
 
         retval = rndis_command(dev, u.header, CONTROL_BUFFER_SIZE);
         if (unlikely(retval < 0)) {
@@ -297,9 +297,9 @@ generic_rndis_bind(struct usbnet *dev, struct usb_interface *intf, int flags)
                 goto fail;
 
         u.init->msg_type = RNDIS_MSG_INIT;
-        u.init->msg_len = ccpu2(sizeof *u.init);
-        u.init->major_version = ccpu2(1);
-        u.init->minor_version = ccpu2(0);
+        u.init->msg_len = cpu_to_le32(sizeof *u.init);
+        u.init->major_version = cpu_to_le32(1);
+        u.init->minor_version = cpu_to_le32(0);
 
         /* max transfer (in spec) is 0x4000 at full speed, but for
          * TX we'll stick to one Ethernet packet plus RNDIS framing.
@@ -403,10 +403,10 @@ generic_rndis_bind(struct usbnet *dev, struct usb_interface *intf, int flags)
         /* set a nonzero filter to enable data transfers */
         memset(u.set, 0, sizeof *u.set);
         u.set->msg_type = RNDIS_MSG_SET;
-        u.set->msg_len = ccpu2(4 + sizeof *u.set);
+        u.set->msg_len = cpu_to_le32(4 + sizeof *u.set);
         u.set->oid = OID_GEN_CURRENT_PACKET_FILTER;
-        u.set->len = ccpu2(4);
-        u.set->offset = ccpu2((sizeof *u.set) - 8);
+        u.set->len = cpu_to_le32(4);
+        u.set->offset = cpu_to_le32((sizeof *u.set) - 8);
         *(__le32 *)(u.buf + sizeof *u.set) = RNDIS_DEFAULT_FILTER;
 
         retval = rndis_command(dev, u.header, CONTROL_BUFFER_SIZE);
@@ -423,7 +423,7 @@ generic_rndis_bind(struct usbnet *dev, struct usb_interface *intf, int flags)
 halt_fail_and_release:
         memset(u.halt, 0, sizeof *u.halt);
         u.halt->msg_type = RNDIS_MSG_HALT;
-        u.halt->msg_len = ccpu2(sizeof *u.halt);
+        u.halt->msg_len = cpu_to_le32(sizeof *u.halt);
         (void) rndis_command(dev, (void *)u.halt, CONTROL_BUFFER_SIZE);
 fail_and_release:
         usb_set_intfdata(info->data, NULL);
@@ -448,7 +448,7 @@ void rndis_unbind(struct usbnet *dev, struct usb_interface *intf)
         halt = kzalloc(CONTROL_BUFFER_SIZE, GFP_KERNEL);
         if (halt) {
                 halt->msg_type = RNDIS_MSG_HALT;
-                halt->msg_len = ccpu2(sizeof *halt);
+                halt->msg_len = cpu_to_le32(sizeof *halt);
                 (void) rndis_command(dev, (void *)halt, CONTROL_BUFFER_SIZE);
                 kfree(halt);
         }
@@ -543,7 +543,7 @@ fill:
         memset(hdr, 0, sizeof *hdr);
         hdr->msg_type = RNDIS_MSG_PACKET;
         hdr->msg_len = cpu_to_le32(skb->len);
-        hdr->data_offset = ccpu2(sizeof(*hdr) - 8);
+        hdr->data_offset = cpu_to_le32(sizeof(*hdr) - 8);
         hdr->data_len = cpu_to_le32(len);
 
         /* FIXME make the last packet always be short ... */
@@ -562,9 +562,6 @@ static const struct driver_info	rndis_info = {
         .tx_fixup =     rndis_tx_fixup,
 };
 
-#undef ccpu2
-
-
 /*-------------------------------------------------------------------------*/
 
 static const struct usb_device_id       products [] = {
diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
index 5574abe29c73..3e6155a38f0c 100644
--- a/drivers/net/usb/smsc95xx.c
+++ b/drivers/net/usb/smsc95xx.c
@@ -55,11 +55,10 @@ struct smsc95xx_priv {
 
 struct usb_context {
         struct usb_ctrlrequest req;
-        struct completion notify;
         struct usbnet *dev;
 };
 
-int turbo_mode = true;
+static int turbo_mode = true;
 module_param(turbo_mode, bool, 0644);
 MODULE_PARM_DESC(turbo_mode, "Enable multiple frames per Rx transaction");
 
@@ -307,7 +306,7 @@ static int smsc95xx_write_eeprom(struct usbnet *dev, u32 offset, u32 length,
         return 0;
 }
 
-static void smsc95xx_async_cmd_callback(struct urb *urb, struct pt_regs *regs)
+static void smsc95xx_async_cmd_callback(struct urb *urb)
 {
         struct usb_context *usb_context = urb->context;
         struct usbnet *dev = usb_context->dev;
@@ -316,8 +315,6 @@ static void smsc95xx_async_cmd_callback(struct urb *urb, struct pt_regs *regs)
         if (status < 0)
                 devwarn(dev, "async callback failed with %d", status);
 
-        complete(&usb_context->notify);
-
         kfree(usb_context);
         usb_free_urb(urb);
 }
@@ -348,11 +345,10 @@ static int smsc95xx_write_reg_async(struct usbnet *dev, u16 index, u32 *data)
         usb_context->req.wValue = 00;
         usb_context->req.wIndex = cpu_to_le16(index);
         usb_context->req.wLength = cpu_to_le16(size);
-        init_completion(&usb_context->notify);
 
         usb_fill_control_urb(urb, dev->udev, usb_sndctrlpipe(dev->udev, 0),
                 (void *)&usb_context->req, data, size,
-                (usb_complete_t)smsc95xx_async_cmd_callback,
+                smsc95xx_async_cmd_callback,
                 (void *)usb_context);
 
         status = usb_submit_urb(urb, GFP_ATOMIC);