4 files changed, 25 insertions, 29 deletions

diff --git a/drivers/net/tulip/de4x5.c b/drivers/net/tulip/de4x5.c
index 6c6fc325c8f9..bc30c6e8fea2 100644
--- a/drivers/net/tulip/de4x5.c
+++ b/drivers/net/tulip/de4x5.c
@@ -482,7 +482,6 @@
 static char version[] __devinitdata = "de4x5.c:V0.546 2001/02/22 davies@maniac.ultranet.com\n";
 
 #define c_char const char
-#define TWIDDLE(a) (u_short)le16_to_cpu(get_unaligned((__le16 *)(a)))
 
 /*
 ** MII Information
@@ -4405,7 +4404,7 @@ srom_infoleaf_info(struct net_device *dev)
         }
     }
 
-    lp->infoleaf_offset = TWIDDLE(p+1);
+        lp->infoleaf_offset = get_unaligned_le16(p + 1);
 
     return 0;
 }
@@ -4476,7 +4475,7 @@ srom_exec(struct net_device *dev, u_char *p)
 
     while (count--) {
         gep_wr(((lp->chipset==DC21140) && (lp->ibn!=5) ?
-                                                   *p++ : TWIDDLE(w++)), dev);
+                                                   *p++ : get_unaligned_le16(w++)), dev);
         mdelay(2);                          /* 2ms per action */
     }
 
@@ -4711,10 +4710,10 @@ type1_infoblock(struct net_device *dev, u_char count, u_char *p)
         lp->active = *p++;
         lp->phy[lp->active].gep = (*p ? p : NULL); p += (*p + 1);
         lp->phy[lp->active].rst = (*p ? p : NULL); p += (*p + 1);
-        lp->phy[lp->active].mc  = TWIDDLE(p); p += 2;
-        lp->phy[lp->active].ana = TWIDDLE(p); p += 2;
-        lp->phy[lp->active].fdx = TWIDDLE(p); p += 2;
-        lp->phy[lp->active].ttm = TWIDDLE(p);
+        lp->phy[lp->active].mc  = get_unaligned_le16(p); p += 2;
+        lp->phy[lp->active].ana = get_unaligned_le16(p); p += 2;
+        lp->phy[lp->active].fdx = get_unaligned_le16(p); p += 2;
+        lp->phy[lp->active].ttm = get_unaligned_le16(p);
         return 0;
     } else if ((lp->media == INIT) && (lp->timeout < 0)) {
         lp->ibn = 1;
@@ -4751,16 +4750,16 @@ type2_infoblock(struct net_device *dev, u_char count, u_char *p)
         lp->infoblock_media = (*p) & MEDIA_CODE;
 
         if ((*p++) & EXT_FIELD) {
-            lp->cache.csr13 = TWIDDLE(p); p += 2;
-            lp->cache.csr14 = TWIDDLE(p); p += 2;
-            lp->cache.csr15 = TWIDDLE(p); p += 2;
+            lp->cache.csr13 = get_unaligned_le16(p); p += 2;
+            lp->cache.csr14 = get_unaligned_le16(p); p += 2;
+            lp->cache.csr15 = get_unaligned_le16(p); p += 2;
         } else {
             lp->cache.csr13 = CSR13;
             lp->cache.csr14 = CSR14;
             lp->cache.csr15 = CSR15;
         }
-        lp->cache.gepc = ((s32)(TWIDDLE(p)) << 16); p += 2;
-        lp->cache.gep  = ((s32)(TWIDDLE(p)) << 16);
+        lp->cache.gepc = ((s32)(get_unaligned_le16(p)) << 16); p += 2;
+        lp->cache.gep  = ((s32)(get_unaligned_le16(p)) << 16);
         lp->infoblock_csr6 = OMR_SIA;
         lp->useMII = false;
 
@@ -4792,10 +4791,10 @@ type3_infoblock(struct net_device *dev, u_char count, u_char *p)
         if (MOTO_SROM_BUG) lp->active = 0;
         lp->phy[lp->active].gep = (*p ? p : NULL); p += (2 * (*p) + 1);
         lp->phy[lp->active].rst = (*p ? p : NULL); p += (2 * (*p) + 1);
-        lp->phy[lp->active].mc  = TWIDDLE(p); p += 2;
-        lp->phy[lp->active].ana = TWIDDLE(p); p += 2;
-        lp->phy[lp->active].fdx = TWIDDLE(p); p += 2;
-        lp->phy[lp->active].ttm = TWIDDLE(p); p += 2;
+        lp->phy[lp->active].mc  = get_unaligned_le16(p); p += 2;
+        lp->phy[lp->active].ana = get_unaligned_le16(p); p += 2;
+        lp->phy[lp->active].fdx = get_unaligned_le16(p); p += 2;
+        lp->phy[lp->active].ttm = get_unaligned_le16(p); p += 2;
         lp->phy[lp->active].mci = *p;
         return 0;
     } else if ((lp->media == INIT) && (lp->timeout < 0)) {
@@ -4835,8 +4834,8 @@ type4_infoblock(struct net_device *dev, u_char count, u_char *p)
         lp->cache.csr13 = CSR13;              /* Hard coded defaults */
         lp->cache.csr14 = CSR14;
         lp->cache.csr15 = CSR15;
-        lp->cache.gepc = ((s32)(TWIDDLE(p)) << 16); p += 2;
-        lp->cache.gep  = ((s32)(TWIDDLE(p)) << 16); p += 2;
+        lp->cache.gepc = ((s32)(get_unaligned_le16(p)) << 16); p += 2;
+        lp->cache.gep  = ((s32)(get_unaligned_le16(p)) << 16); p += 2;
         csr6 = *p++;
         flags = *p++;
 
diff --git a/drivers/net/tulip/de4x5.h b/drivers/net/tulip/de4x5.h
index 9fb8d7f07994..f5f33b3eb067 100644
--- a/drivers/net/tulip/de4x5.h
+++ b/drivers/net/tulip/de4x5.h
@@ -1017,4 +1017,4 @@ struct de4x5_ioctl {
 #define DE4X5_SET_OMR           0x0d /* Set the OMR Register contents */
 #define DE4X5_GET_REG           0x0e /* Get the DE4X5 Registers */
 
-#define MOTO_SROM_BUG    ((lp->active == 8) && (((le32_to_cpu(get_unaligned(((__le32 *)dev->dev_addr))))&0x00ffffff)==0x3e0008))
+#define MOTO_SROM_BUG    (lp->active == 8 && (get_unaligned_le32(dev->dev_addr) & 0x00ffffff) == 0x3e0008)
diff --git a/drivers/net/tulip/tulip.h b/drivers/net/tulip/tulip.h
index 908422f2f320..92c68a22f16b 100644
--- a/drivers/net/tulip/tulip.h
+++ b/drivers/net/tulip/tulip.h
@@ -25,6 +25,7 @@
 #include <linux/pci.h>
 #include <asm/io.h>
 #include <asm/irq.h>
+#include <asm/unaligned.h>
 
 
 
@@ -304,11 +305,7 @@ enum t21143_csr6_bits {
 
 #define RUN_AT(x) (jiffies + (x))
 
-#if defined(__i386__)                   /* AKA get_unaligned() */
-#define get_u16(ptr) (*(u16 *)(ptr))
-#else
-#define get_u16(ptr) (((u8*)(ptr))[0] + (((u8*)(ptr))[1]<<8))
-#endif
+#define get_u16(ptr) get_unaligned_le16((ptr))
 
 struct medialeaf {
         u8 type;
diff --git a/drivers/net/tulip/tulip_core.c b/drivers/net/tulip/tulip_core.c
index fa1c1c329a2d..f9d13fa05d64 100644
--- a/drivers/net/tulip/tulip_core.c
+++ b/drivers/net/tulip/tulip_core.c
@@ -327,8 +327,8 @@ static void tulip_up(struct net_device *dev)
         tp->dirty_rx = tp->dirty_tx = 0;
 
         if (tp->flags & MC_HASH_ONLY) {
-                u32 addr_low = le32_to_cpu(get_unaligned((__le32 *)dev->dev_addr));
-                u32 addr_high = le16_to_cpu(get_unaligned((__le16 *)(dev->dev_addr+4)));
+                u32 addr_low = get_unaligned_le32(dev->dev_addr);
+                u32 addr_high = get_unaligned_le16(dev->dev_addr + 4);
                 if (tp->chip_id == AX88140) {
                         iowrite32(0, ioaddr + CSR13);
                         iowrite32(addr_low,  ioaddr + CSR14);
@@ -1437,13 +1437,13 @@ static int __devinit tulip_init_one (struct pci_dev *pdev,
                         do
                                 value = ioread32(ioaddr + CSR9);
                         while (value < 0  && --boguscnt > 0);
-                        put_unaligned(cpu_to_le16(value), ((__le16*)dev->dev_addr) + i);
+                        put_unaligned_le16(value, ((__le16 *)dev->dev_addr) + i);
                         sum += value & 0xffff;
                 }
         } else if (chip_idx == COMET) {
                 /* No need to read the EEPROM. */
-                put_unaligned(cpu_to_le32(ioread32(ioaddr + 0xA4)), (__le32 *)dev->dev_addr);
-                put_unaligned(cpu_to_le16(ioread32(ioaddr + 0xA8)), (__le16 *)(dev->dev_addr + 4));
+                put_unaligned_le32(ioread32(ioaddr + 0xA4), dev->dev_addr);
+                put_unaligned_le16(ioread32(ioaddr + 0xA8), dev->dev_addr + 4);
                 for (i = 0; i < 6; i ++)
                         sum += dev->dev_addr[i];
         } else {