4 files changed, 78 insertions, 116 deletions

diff --git a/drivers/net/qlge/qlge.h b/drivers/net/qlge/qlge.h
index ba2e1c5b6bcf..459663a4023d 100644
--- a/drivers/net/qlge/qlge.h
+++ b/drivers/net/qlge/qlge.h
@@ -818,15 +818,6 @@ struct tx_doorbell_context {
 };
 
 /* DATA STRUCTURES SHARED WITH HARDWARE. */
-
-struct bq_element {
-        u32 addr_lo;
-#define BQ_END  0x00000001
-#define BQ_CONT 0x00000002
-#define BQ_MASK 0x00000003
-        u32 addr_hi;
-} __attribute((packed));
-
 struct tx_buf_desc {
         __le64 addr;
         __le32 len;
@@ -860,8 +851,8 @@ struct ob_mac_iocb_req {
         __le16 frame_len;
 #define OB_MAC_IOCB_LEN_MASK 0x3ffff
         __le16 reserved2;
-        __le32 tid;
-        __le32 txq_idx;
+        u32 tid;
+        u32 txq_idx;
         __le32 reserved3;
         __le16 vlan_tci;
         __le16 reserved4;
@@ -880,8 +871,8 @@ struct ob_mac_iocb_rsp {
         u8 flags2;              /* */
         u8 flags3;              /* */
 #define OB_MAC_IOCB_RSP_B       0x80    /* */
-        __le32 tid;
-        __le32 txq_idx;
+        u32 tid;
+        u32 txq_idx;
         __le32 reserved[13];
 } __attribute((packed));
 
@@ -903,8 +894,8 @@ struct ob_mac_tso_iocb_req {
 #define OB_MAC_TSO_IOCB_V       0x04
         __le32 reserved1[2];
         __le32 frame_len;
-        __le32 tid;
-        __le32 txq_idx;
+        u32 tid;
+        u32 txq_idx;
         __le16 total_hdrs_len;
         __le16 net_trans_offset;
 #define OB_MAC_TRANSPORT_HDR_SHIFT 6
@@ -925,8 +916,8 @@ struct ob_mac_tso_iocb_rsp {
         u8 flags2;              /* */
         u8 flags3;              /* */
 #define OB_MAC_TSO_IOCB_RSP_B   0x8000
-        __le32 tid;
-        __le32 txq_idx;
+        u32 tid;
+        u32 txq_idx;
         __le32 reserved2[13];
 } __attribute((packed));
 
@@ -979,10 +970,11 @@ struct ib_mac_iocb_rsp {
 
         __le16 reserved1;
         __le32 reserved2[6];
-        __le32 flags4;
-#define IB_MAC_IOCB_RSP_HV      0x20000000      /* */
-#define IB_MAC_IOCB_RSP_HS      0x40000000      /* */
-#define IB_MAC_IOCB_RSP_HL      0x80000000      /* */
+        u8 reserved3[3];
+        u8 flags4;
+#define IB_MAC_IOCB_RSP_HV      0x20
+#define IB_MAC_IOCB_RSP_HS      0x40
+#define IB_MAC_IOCB_RSP_HL      0x80
         __le32 hdr_len;         /* */
         __le32 hdr_addr_lo;     /* */
         __le32 hdr_addr_hi;     /* */
@@ -1126,7 +1118,7 @@ struct map_list {
 struct tx_ring_desc {
         struct sk_buff *skb;
         struct ob_mac_iocb_req *queue_entry;
-        int index;
+        u32 index;
         struct oal oal;
         struct map_list map[MAX_SKB_FRAGS + 1];
         int map_cnt;
@@ -1138,8 +1130,8 @@ struct bq_desc {
                 struct page *lbq_page;
                 struct sk_buff *skb;
         } p;
-        struct bq_element *bq;
-        int index;
+        __le64 *addr;
+        u32 index;
          DECLARE_PCI_UNMAP_ADDR(mapaddr);
          DECLARE_PCI_UNMAP_LEN(maplen);
 };
@@ -1189,7 +1181,7 @@ struct rx_ring {
         u32 cq_size;
         u32 cq_len;
         u16 cq_id;
-        u32 *prod_idx_sh_reg;   /* Shadowed producer register. */
+        volatile __le32 *prod_idx_sh_reg;       /* Shadowed producer register. */
         dma_addr_t prod_idx_sh_reg_dma;
         void __iomem *cnsmr_idx_db_reg; /* PCI doorbell mem area + 0 */
         u32 cnsmr_idx;          /* current sw idx */
@@ -1467,21 +1459,6 @@ static inline void ql_write_db_reg(u32 val, void __iomem *addr)
         mmiowb();
 }
 
-/*
- * Shadow Registers:
- * Outbound queues have a consumer index that is maintained by the chip.
- * Inbound queues have a producer index that is maintained by the chip.
- * For lower overhead, these registers are "shadowed" to host memory
- * which allows the device driver to track the queue progress without
- * PCI reads. When an entry is placed on an inbound queue, the chip will
- * update the relevant index register and then copy the value to the
- * shadow register in host memory.
- */
-static inline unsigned int ql_read_sh_reg(const volatile void  *addr)
-{
-        return *(volatile unsigned int __force *)addr;
-}
-
 extern char qlge_driver_name[];
 extern const char qlge_driver_version[];
 extern const struct ethtool_ops qlge_ethtool_ops;
diff --git a/drivers/net/qlge/qlge_dbg.c b/drivers/net/qlge/qlge_dbg.c
index 47df304a02c8..3f5e02d2e4a9 100644
--- a/drivers/net/qlge/qlge_dbg.c
+++ b/drivers/net/qlge/qlge_dbg.c
@@ -821,14 +821,11 @@ void ql_dump_ib_mac_rsp(struct ib_mac_iocb_rsp *ib_mac_rsp)
                        le16_to_cpu(ib_mac_rsp->vlan_id));
 
         printk(KERN_ERR PFX "flags4 = %s%s%s.\n",
-               le32_to_cpu(ib_mac_rsp->
-                           flags4) & IB_MAC_IOCB_RSP_HV ? "HV " : "",
-               le32_to_cpu(ib_mac_rsp->
-                           flags4) & IB_MAC_IOCB_RSP_HS ? "HS " : "",
-               le32_to_cpu(ib_mac_rsp->
-                           flags4) & IB_MAC_IOCB_RSP_HL ? "HL " : "");
-
-        if (le32_to_cpu(ib_mac_rsp->flags4) & IB_MAC_IOCB_RSP_HV) {
+                ib_mac_rsp->flags4 & IB_MAC_IOCB_RSP_HV ? "HV " : "",
+                ib_mac_rsp->flags4 & IB_MAC_IOCB_RSP_HS ? "HS " : "",
+                ib_mac_rsp->flags4 & IB_MAC_IOCB_RSP_HL ? "HL " : "");
+
+        if (ib_mac_rsp->flags4 & IB_MAC_IOCB_RSP_HV) {
                 printk(KERN_ERR PFX "hdr length = %d.\n",
                        le32_to_cpu(ib_mac_rsp->hdr_len));
                 printk(KERN_ERR PFX "hdr addr_hi    = 0x%x.\n",
diff --git a/drivers/net/qlge/qlge_ethtool.c b/drivers/net/qlge/qlge_ethtool.c
index eefb81b13758..9d922e2ff226 100644
--- a/drivers/net/qlge/qlge_ethtool.c
+++ b/drivers/net/qlge/qlge_ethtool.c
@@ -56,9 +56,9 @@ static int ql_update_ring_coalescing(struct ql_adapter *qdev)
                 for (i = 1; i < qdev->rss_ring_first_cq_id; i++, rx_ring++) {
                         rx_ring = &qdev->rx_ring[i];
                         cqicb = (struct cqicb *)rx_ring;
-                        cqicb->irq_delay = le16_to_cpu(qdev->tx_coalesce_usecs);
+                        cqicb->irq_delay = cpu_to_le16(qdev->tx_coalesce_usecs);
                         cqicb->pkt_delay =
-                            le16_to_cpu(qdev->tx_max_coalesced_frames);
+                            cpu_to_le16(qdev->tx_max_coalesced_frames);
                         cqicb->flags = FLAGS_LI;
                         status = ql_write_cfg(qdev, cqicb, sizeof(cqicb),
                                                 CFG_LCQ, rx_ring->cq_id);
@@ -79,9 +79,9 @@ static int ql_update_ring_coalescing(struct ql_adapter *qdev)
                      i++) {
                         rx_ring = &qdev->rx_ring[i];
                         cqicb = (struct cqicb *)rx_ring;
-                        cqicb->irq_delay = le16_to_cpu(qdev->rx_coalesce_usecs);
+                        cqicb->irq_delay = cpu_to_le16(qdev->rx_coalesce_usecs);
                         cqicb->pkt_delay =
-                            le16_to_cpu(qdev->rx_max_coalesced_frames);
+                            cpu_to_le16(qdev->rx_max_coalesced_frames);
                         cqicb->flags = FLAGS_LI;
                         status = ql_write_cfg(qdev, cqicb, sizeof(cqicb),
                                                 CFG_LCQ, rx_ring->cq_id);
diff --git a/drivers/net/qlge/qlge_main.c b/drivers/net/qlge/qlge_main.c
index 718a7bd0cd1a..f4c016012f18 100644
--- a/drivers/net/qlge/qlge_main.c
+++ b/drivers/net/qlge/qlge_main.c
@@ -257,7 +257,7 @@ int ql_get_mac_addr_reg(struct ql_adapter *qdev, u32 type, u16 index,
                 {
                         status =
                             ql_wait_reg_rdy(qdev,
-                                MAC_ADDR_IDX, MAC_ADDR_MW, MAC_ADDR_E);
+                                MAC_ADDR_IDX, MAC_ADDR_MW, 0);
                         if (status)
                                 goto exit;
                         ql_write32(qdev, MAC_ADDR_IDX, (offset++) | /* offset */
@@ -265,13 +265,13 @@ int ql_get_mac_addr_reg(struct ql_adapter *qdev, u32 type, u16 index,
                                    MAC_ADDR_ADR | MAC_ADDR_RS | type); /* type */
                         status =
                             ql_wait_reg_rdy(qdev,
-                                MAC_ADDR_IDX, MAC_ADDR_MR, MAC_ADDR_E);
+                                MAC_ADDR_IDX, MAC_ADDR_MR, 0);
                         if (status)
                                 goto exit;
                         *value++ = ql_read32(qdev, MAC_ADDR_DATA);
                         status =
                             ql_wait_reg_rdy(qdev,
-                                MAC_ADDR_IDX, MAC_ADDR_MW, MAC_ADDR_E);
+                                MAC_ADDR_IDX, MAC_ADDR_MW, 0);
                         if (status)
                                 goto exit;
                         ql_write32(qdev, MAC_ADDR_IDX, (offset++) | /* offset */
@@ -279,14 +279,14 @@ int ql_get_mac_addr_reg(struct ql_adapter *qdev, u32 type, u16 index,
                                    MAC_ADDR_ADR | MAC_ADDR_RS | type); /* type */
                         status =
                             ql_wait_reg_rdy(qdev,
-                                MAC_ADDR_IDX, MAC_ADDR_MR, MAC_ADDR_E);
+                                MAC_ADDR_IDX, MAC_ADDR_MR, 0);
                         if (status)
                                 goto exit;
                         *value++ = ql_read32(qdev, MAC_ADDR_DATA);
                         if (type == MAC_ADDR_TYPE_CAM_MAC) {
                                 status =
                                     ql_wait_reg_rdy(qdev,
-                                        MAC_ADDR_IDX, MAC_ADDR_MW, MAC_ADDR_E);
+                                        MAC_ADDR_IDX, MAC_ADDR_MW, 0);
                                 if (status)
                                         goto exit;
                                 ql_write32(qdev, MAC_ADDR_IDX, (offset++) | /* offset */
@@ -294,7 +294,7 @@ int ql_get_mac_addr_reg(struct ql_adapter *qdev, u32 type, u16 index,
                                            MAC_ADDR_ADR | MAC_ADDR_RS | type); /* type */
                                 status =
                                     ql_wait_reg_rdy(qdev, MAC_ADDR_IDX,
-                                                    MAC_ADDR_MR, MAC_ADDR_E);
+                                                    MAC_ADDR_MR, 0);
                                 if (status)
                                         goto exit;
                                 *value++ = ql_read32(qdev, MAC_ADDR_DATA);
@@ -344,7 +344,7 @@ static int ql_set_mac_addr_reg(struct ql_adapter *qdev, u8 *addr, u32 type,
 
                         status =
                             ql_wait_reg_rdy(qdev,
-                                MAC_ADDR_IDX, MAC_ADDR_MW, MAC_ADDR_E);
+                                MAC_ADDR_IDX, MAC_ADDR_MW, 0);
                         if (status)
                                 goto exit;
                         ql_write32(qdev, MAC_ADDR_IDX, (offset++) | /* offset */
@@ -353,7 +353,7 @@ static int ql_set_mac_addr_reg(struct ql_adapter *qdev, u8 *addr, u32 type,
                         ql_write32(qdev, MAC_ADDR_DATA, lower);
                         status =
                             ql_wait_reg_rdy(qdev,
-                                MAC_ADDR_IDX, MAC_ADDR_MW, MAC_ADDR_E);
+                                MAC_ADDR_IDX, MAC_ADDR_MW, 0);
                         if (status)
                                 goto exit;
                         ql_write32(qdev, MAC_ADDR_IDX, (offset++) | /* offset */
@@ -362,7 +362,7 @@ static int ql_set_mac_addr_reg(struct ql_adapter *qdev, u8 *addr, u32 type,
                         ql_write32(qdev, MAC_ADDR_DATA, upper);
                         status =
                             ql_wait_reg_rdy(qdev,
-                                MAC_ADDR_IDX, MAC_ADDR_MW, MAC_ADDR_E);
+                                MAC_ADDR_IDX, MAC_ADDR_MW, 0);
                         if (status)
                                 goto exit;
                         ql_write32(qdev, MAC_ADDR_IDX, (offset) |       /* offset */
@@ -400,7 +400,7 @@ static int ql_set_mac_addr_reg(struct ql_adapter *qdev, u8 *addr, u32 type,
 
                         status =
                             ql_wait_reg_rdy(qdev,
-                                MAC_ADDR_IDX, MAC_ADDR_MW, MAC_ADDR_E);
+                                MAC_ADDR_IDX, MAC_ADDR_MW, 0);
                         if (status)
                                 goto exit;
                         ql_write32(qdev, MAC_ADDR_IDX, offset | /* offset */
@@ -431,13 +431,13 @@ int ql_get_routing_reg(struct ql_adapter *qdev, u32 index, u32 *value)
         if (status)
                 goto exit;
 
-        status = ql_wait_reg_rdy(qdev, RT_IDX, RT_IDX_MW, RT_IDX_E);
+        status = ql_wait_reg_rdy(qdev, RT_IDX, RT_IDX_MW, 0);
         if (status)
                 goto exit;
 
         ql_write32(qdev, RT_IDX,
                    RT_IDX_TYPE_NICQ | RT_IDX_RS | (index << RT_IDX_IDX_SHIFT));
-        status = ql_wait_reg_rdy(qdev, RT_IDX, RT_IDX_MR, RT_IDX_E);
+        status = ql_wait_reg_rdy(qdev, RT_IDX, RT_IDX_MR, 0);
         if (status)
                 goto exit;
         *value = ql_read32(qdev, RT_DATA);
@@ -874,7 +874,6 @@ static void ql_update_lbq(struct ql_adapter *qdev, struct rx_ring *rx_ring)
 {
         int clean_idx = rx_ring->lbq_clean_idx;
         struct bq_desc *lbq_desc;
-        struct bq_element *bq;
         u64 map;
         int i;
 
@@ -884,7 +883,6 @@ static void ql_update_lbq(struct ql_adapter *qdev, struct rx_ring *rx_ring)
                                 "lbq: try cleaning clean_idx = %d.\n",
                                 clean_idx);
                         lbq_desc = &rx_ring->lbq[clean_idx];
-                        bq = lbq_desc->bq;
                         if (lbq_desc->p.lbq_page == NULL) {
                                 QPRINTK(qdev, RX_STATUS, DEBUG,
                                         "lbq: getting new page for index %d.\n",
@@ -906,10 +904,7 @@ static void ql_update_lbq(struct ql_adapter *qdev, struct rx_ring *rx_ring)
                                 }
                                 pci_unmap_addr_set(lbq_desc, mapaddr, map);
                                 pci_unmap_len_set(lbq_desc, maplen, PAGE_SIZE);
-                                bq->addr_lo =   /*lbq_desc->addr_lo = */
-                                    cpu_to_le32(map);
-                                bq->addr_hi =   /*lbq_desc->addr_hi = */
-                                    cpu_to_le32(map >> 32);
+                                *lbq_desc->addr = cpu_to_le64(map);
                         }
                         clean_idx++;
                         if (clean_idx == rx_ring->lbq_len)
@@ -934,7 +929,6 @@ static void ql_update_sbq(struct ql_adapter *qdev, struct rx_ring *rx_ring)
 {
         int clean_idx = rx_ring->sbq_clean_idx;
         struct bq_desc *sbq_desc;
-        struct bq_element *bq;
         u64 map;
         int i;
 
@@ -944,7 +938,6 @@ static void ql_update_sbq(struct ql_adapter *qdev, struct rx_ring *rx_ring)
                         QPRINTK(qdev, RX_STATUS, DEBUG,
                                 "sbq: try cleaning clean_idx = %d.\n",
                                 clean_idx);
-                        bq = sbq_desc->bq;
                         if (sbq_desc->p.skb == NULL) {
                                 QPRINTK(qdev, RX_STATUS, DEBUG,
                                         "sbq: getting new skb for index %d.\n",
@@ -963,11 +956,15 @@ static void ql_update_sbq(struct ql_adapter *qdev, struct rx_ring *rx_ring)
                                                      sbq_desc->p.skb->data,
                                                      rx_ring->sbq_buf_size /
                                                      2, PCI_DMA_FROMDEVICE);
+                                if (pci_dma_mapping_error(qdev->pdev, map)) {
+                                        QPRINTK(qdev, IFUP, ERR, "PCI mapping failed.\n");
+                                        rx_ring->sbq_clean_idx = clean_idx;
+                                        return;
+                                }
                                 pci_unmap_addr_set(sbq_desc, mapaddr, map);
                                 pci_unmap_len_set(sbq_desc, maplen,
                                                   rx_ring->sbq_buf_size / 2);
-                                bq->addr_lo = cpu_to_le32(map);
-                                bq->addr_hi = cpu_to_le32(map >> 32);
+                                *sbq_desc->addr = cpu_to_le64(map);
                         }
 
                         clean_idx++;
@@ -1303,6 +1300,11 @@ static struct sk_buff *ql_build_rx_skb(struct ql_adapter *qdev,
                                         "No skb available, drop the packet.\n");
                                 return NULL;
                         }
+                        pci_unmap_page(qdev->pdev,
+                                       pci_unmap_addr(lbq_desc,
+                                                      mapaddr),
+                                       pci_unmap_len(lbq_desc, maplen),
+                                       PCI_DMA_FROMDEVICE);
                         skb_reserve(skb, NET_IP_ALIGN);
                         QPRINTK(qdev, RX_STATUS, DEBUG,
                                 "%d bytes of headers and data in large. Chain page to new skb and pull tail.\n", length);
@@ -1330,7 +1332,7 @@ static struct sk_buff *ql_build_rx_skb(struct ql_adapter *qdev,
                  *          eventually be in trouble.
                  */
                 int size, offset, i = 0;
-                struct bq_element *bq, bq_array[8];
+                __le64 *bq, bq_array[8];
                 sbq_desc = ql_get_curr_sbuf(rx_ring);
                 pci_unmap_single(qdev->pdev,
                                  pci_unmap_addr(sbq_desc, mapaddr),
@@ -1356,16 +1358,10 @@ static struct sk_buff *ql_build_rx_skb(struct ql_adapter *qdev,
                 } else {
                         QPRINTK(qdev, RX_STATUS, DEBUG,
                                 "Headers in small, %d bytes of data in chain of large.\n", length);
-                        bq = (struct bq_element *)sbq_desc->p.skb->data;
+                        bq = (__le64 *)sbq_desc->p.skb->data;
                 }
                 while (length > 0) {
                         lbq_desc = ql_get_curr_lbuf(rx_ring);
-                        if ((bq->addr_lo & ~BQ_MASK) != lbq_desc->bq->addr_lo) {
-                                QPRINTK(qdev, RX_STATUS, ERR,
-                                        "Panic!!! bad large buffer address, expected 0x%.08x, got 0x%.08x.\n",
-                                        lbq_desc->bq->addr_lo, bq->addr_lo);
-                                return NULL;
-                        }
                         pci_unmap_page(qdev->pdev,
                                        pci_unmap_addr(lbq_desc,
                                                       mapaddr),
@@ -1549,7 +1545,7 @@ static void ql_process_chip_ae_intr(struct ql_adapter *qdev,
 static int ql_clean_outbound_rx_ring(struct rx_ring *rx_ring)
 {
         struct ql_adapter *qdev = rx_ring->qdev;
-        u32 prod = ql_read_sh_reg(rx_ring->prod_idx_sh_reg);
+        u32 prod = le32_to_cpu(*rx_ring->prod_idx_sh_reg);
         struct ob_mac_iocb_rsp *net_rsp = NULL;
         int count = 0;
 
@@ -1575,7 +1571,7 @@ static int ql_clean_outbound_rx_ring(struct rx_ring *rx_ring)
                 }
                 count++;
                 ql_update_cq(rx_ring);
-                prod = ql_read_sh_reg(rx_ring->prod_idx_sh_reg);
+                prod = le32_to_cpu(*rx_ring->prod_idx_sh_reg);
         }
         ql_write_cq_idx(rx_ring);
         if (netif_queue_stopped(qdev->ndev) && net_rsp != NULL) {
@@ -1595,7 +1591,7 @@ static int ql_clean_outbound_rx_ring(struct rx_ring *rx_ring)
 static int ql_clean_inbound_rx_ring(struct rx_ring *rx_ring, int budget)
 {
         struct ql_adapter *qdev = rx_ring->qdev;
-        u32 prod = ql_read_sh_reg(rx_ring->prod_idx_sh_reg);
+        u32 prod = le32_to_cpu(*rx_ring->prod_idx_sh_reg);
         struct ql_net_rsp_iocb *net_rsp;
         int count = 0;
 
@@ -1628,7 +1624,7 @@ static int ql_clean_inbound_rx_ring(struct rx_ring *rx_ring, int budget)
                 }
                 count++;
                 ql_update_cq(rx_ring);
-                prod = ql_read_sh_reg(rx_ring->prod_idx_sh_reg);
+                prod = le32_to_cpu(*rx_ring->prod_idx_sh_reg);
                 if (count == budget)
                         break;
         }
@@ -1791,7 +1787,7 @@ static irqreturn_t qlge_isr(int irq, void *dev_id)
          * Check the default queue and wake handler if active.
          */
         rx_ring = &qdev->rx_ring[0];
-        if (ql_read_sh_reg(rx_ring->prod_idx_sh_reg) != rx_ring->cnsmr_idx) {
+        if (le32_to_cpu(*rx_ring->prod_idx_sh_reg) != rx_ring->cnsmr_idx) {
                 QPRINTK(qdev, INTR, INFO, "Waking handler for rx_ring[0].\n");
                 ql_disable_completion_interrupt(qdev, intr_context->intr);
                 queue_delayed_work_on(smp_processor_id(), qdev->q_workqueue,
@@ -1805,7 +1801,7 @@ static irqreturn_t qlge_isr(int irq, void *dev_id)
                  */
                 for (i = 1; i < qdev->rx_ring_count; i++) {
                         rx_ring = &qdev->rx_ring[i];
-                        if (ql_read_sh_reg(rx_ring->prod_idx_sh_reg) !=
+                        if (le32_to_cpu(*rx_ring->prod_idx_sh_reg) !=
                             rx_ring->cnsmr_idx) {
                                 QPRINTK(qdev, INTR, INFO,
                                         "Waking handler for rx_ring[%d].\n", i);
@@ -1874,7 +1870,7 @@ static void ql_hw_csum_setup(struct sk_buff *skb,
 {
         int len;
         struct iphdr *iph = ip_hdr(skb);
-        u16 *check;
+        __sum16 *check;
         mac_iocb_ptr->opcode = OPCODE_OB_MAC_TSO_IOCB;
         mac_iocb_ptr->frame_len = cpu_to_le32((u32) skb->len);
         mac_iocb_ptr->net_trans_offset =
@@ -2083,8 +2079,6 @@ static void ql_free_lbq_buffers(struct ql_adapter *qdev, struct rx_ring *rx_ring
                         put_page(lbq_desc->p.lbq_page);
                         lbq_desc->p.lbq_page = NULL;
                 }
-                lbq_desc->bq->addr_lo = 0;
-                lbq_desc->bq->addr_hi = 0;
         }
 }
 
@@ -2097,12 +2091,12 @@ static int ql_alloc_lbq_buffers(struct ql_adapter *qdev,
         int i;
         struct bq_desc *lbq_desc;
         u64 map;
-        struct bq_element *bq = rx_ring->lbq_base;
+        __le64 *bq = rx_ring->lbq_base;
 
         for (i = 0; i < rx_ring->lbq_len; i++) {
                 lbq_desc = &rx_ring->lbq[i];
                 memset(lbq_desc, 0, sizeof(lbq_desc));
-                lbq_desc->bq = bq;
+                lbq_desc->addr = bq;
                 lbq_desc->index = i;
                 lbq_desc->p.lbq_page = alloc_page(GFP_ATOMIC);
                 if (unlikely(!lbq_desc->p.lbq_page)) {
@@ -2119,8 +2113,7 @@ static int ql_alloc_lbq_buffers(struct ql_adapter *qdev,
                         }
                         pci_unmap_addr_set(lbq_desc, mapaddr, map);
                         pci_unmap_len_set(lbq_desc, maplen, PAGE_SIZE);
-                        bq->addr_lo = cpu_to_le32(map);
-                        bq->addr_hi = cpu_to_le32(map >> 32);
+                        *lbq_desc->addr = cpu_to_le64(map);
                 }
                 bq++;
         }
@@ -2149,13 +2142,6 @@ static void ql_free_sbq_buffers(struct ql_adapter *qdev, struct rx_ring *rx_ring
                         dev_kfree_skb(sbq_desc->p.skb);
                         sbq_desc->p.skb = NULL;
                 }
-                if (sbq_desc->bq == NULL) {
-                        QPRINTK(qdev, IFUP, ERR, "sbq_desc->bq %d is NULL.\n",
-                                i);
-                        return;
-                }
-                sbq_desc->bq->addr_lo = 0;
-                sbq_desc->bq->addr_hi = 0;
         }
 }
 
@@ -2167,13 +2153,13 @@ static int ql_alloc_sbq_buffers(struct ql_adapter *qdev,
         struct bq_desc *sbq_desc;
         struct sk_buff *skb;
         u64 map;
-        struct bq_element *bq = rx_ring->sbq_base;
+        __le64 *bq = rx_ring->sbq_base;
 
         for (i = 0; i < rx_ring->sbq_len; i++) {
                 sbq_desc = &rx_ring->sbq[i];
                 memset(sbq_desc, 0, sizeof(sbq_desc));
                 sbq_desc->index = i;
-                sbq_desc->bq = bq;
+                sbq_desc->addr = bq;
                 skb = netdev_alloc_skb(qdev->ndev, rx_ring->sbq_buf_size);
                 if (unlikely(!skb)) {
                         /* Better luck next round */
@@ -2199,10 +2185,7 @@ static int ql_alloc_sbq_buffers(struct ql_adapter *qdev,
                 }
                 pci_unmap_addr_set(sbq_desc, mapaddr, map);
                 pci_unmap_len_set(sbq_desc, maplen, rx_ring->sbq_buf_size / 2);
-                bq->addr_lo =   /*sbq_desc->addr_lo = */
-                    cpu_to_le32(map);
-                bq->addr_hi =   /*sbq_desc->addr_hi = */
-                    cpu_to_le32(map >> 32);
+                *sbq_desc->addr = cpu_to_le64(map);
                 bq++;
         }
         return 0;
@@ -2481,7 +2464,8 @@ static int ql_start_rx_ring(struct ql_adapter *qdev, struct rx_ring *rx_ring)
         memset((void *)cqicb, 0, sizeof(struct cqicb));
         cqicb->msix_vect = rx_ring->irq;
 
-        cqicb->len = cpu_to_le16(rx_ring->cq_len | LEN_V | LEN_CPP_CONT);
+        bq_len = (rx_ring->cq_len == 65536) ? 0 : (u16) rx_ring->cq_len;
+        cqicb->len = cpu_to_le16(bq_len | LEN_V | LEN_CPP_CONT);
 
         cqicb->addr_lo = cpu_to_le32(rx_ring->cq_base_dma);
         cqicb->addr_hi = cpu_to_le32((u64) rx_ring->cq_base_dma >> 32);
@@ -2503,8 +2487,11 @@ static int ql_start_rx_ring(struct ql_adapter *qdev, struct rx_ring *rx_ring)
                     cpu_to_le32(rx_ring->lbq_base_indirect_dma);
                 cqicb->lbq_addr_hi =
                     cpu_to_le32((u64) rx_ring->lbq_base_indirect_dma >> 32);
-                cqicb->lbq_buf_size = cpu_to_le32(rx_ring->lbq_buf_size);
-                bq_len = (u16) rx_ring->lbq_len;
+                bq_len = (rx_ring->lbq_buf_size == 65536) ? 0 :
+                        (u16) rx_ring->lbq_buf_size;
+                cqicb->lbq_buf_size = cpu_to_le16(bq_len);
+                bq_len = (rx_ring->lbq_len == 65536) ? 0 :
+                        (u16) rx_ring->lbq_len;
                 cqicb->lbq_len = cpu_to_le16(bq_len);
                 rx_ring->lbq_prod_idx = rx_ring->lbq_len - 16;
                 rx_ring->lbq_curr_idx = 0;
@@ -2520,7 +2507,8 @@ static int ql_start_rx_ring(struct ql_adapter *qdev, struct rx_ring *rx_ring)
                     cpu_to_le32((u64) rx_ring->sbq_base_indirect_dma >> 32);
                 cqicb->sbq_buf_size =
                     cpu_to_le16(((rx_ring->sbq_buf_size / 2) + 8) & 0xfffffff8);
-                bq_len = (u16) rx_ring->sbq_len;
+                bq_len = (rx_ring->sbq_len == 65536) ? 0 :
+                        (u16) rx_ring->sbq_len;
                 cqicb->sbq_len = cpu_to_le16(bq_len);
                 rx_ring->sbq_prod_idx = rx_ring->sbq_len - 16;
                 rx_ring->sbq_curr_idx = 0;
@@ -3341,11 +3329,11 @@ static int ql_configure_rings(struct ql_adapter *qdev)
                             rx_ring->cq_len * sizeof(struct ql_net_rsp_iocb);
                         rx_ring->lbq_len = NUM_LARGE_BUFFERS;
                         rx_ring->lbq_size =
-                            rx_ring->lbq_len * sizeof(struct bq_element);
+                            rx_ring->lbq_len * sizeof(__le64);
                         rx_ring->lbq_buf_size = LARGE_BUFFER_SIZE;
                         rx_ring->sbq_len = NUM_SMALL_BUFFERS;
                         rx_ring->sbq_size =
-                            rx_ring->sbq_len * sizeof(struct bq_element);
+                            rx_ring->sbq_len * sizeof(__le64);
                         rx_ring->sbq_buf_size = SMALL_BUFFER_SIZE * 2;
                         rx_ring->type = DEFAULT_Q;
                 } else if (i < qdev->rss_ring_first_cq_id) {
@@ -3372,11 +3360,11 @@ static int ql_configure_rings(struct ql_adapter *qdev)
                             rx_ring->cq_len * sizeof(struct ql_net_rsp_iocb);
                         rx_ring->lbq_len = NUM_LARGE_BUFFERS;
                         rx_ring->lbq_size =
-                            rx_ring->lbq_len * sizeof(struct bq_element);
+                            rx_ring->lbq_len * sizeof(__le64);
                         rx_ring->lbq_buf_size = LARGE_BUFFER_SIZE;
                         rx_ring->sbq_len = NUM_SMALL_BUFFERS;
                         rx_ring->sbq_size =
-                            rx_ring->sbq_len * sizeof(struct bq_element);
+                            rx_ring->sbq_len * sizeof(__le64);
                         rx_ring->sbq_buf_size = SMALL_BUFFER_SIZE * 2;
                         rx_ring->type = RX_Q;
                 }