4 files changed, 76 insertions, 33 deletions

diff --git a/drivers/net/phy/mdio-gpio.c b/drivers/net/phy/mdio-gpio.c
index e701433bf52f..5f1a2250018f 100644
--- a/drivers/net/phy/mdio-gpio.c
+++ b/drivers/net/phy/mdio-gpio.c
@@ -32,29 +32,39 @@
 
 struct mdio_gpio_info {
         struct mdiobb_ctrl ctrl;
-        int mdc, mdio;
+        int mdc, mdio, mdo;
+        int mdc_active_low, mdio_active_low, mdo_active_low;
 };
 
 static void *mdio_gpio_of_get_data(struct platform_device *pdev)
 {
         struct device_node *np = pdev->dev.of_node;
         struct mdio_gpio_platform_data *pdata;
+        enum of_gpio_flags flags;
         int ret;
 
         pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL);
         if (!pdata)
                 return NULL;
 
-        ret = of_get_gpio(np, 0);
+        ret = of_get_gpio_flags(np, 0, &flags);
         if (ret < 0)
                 return NULL;
 
         pdata->mdc = ret;
+        pdata->mdc_active_low = flags & OF_GPIO_ACTIVE_LOW;
 
-        ret = of_get_gpio(np, 1);
+        ret = of_get_gpio_flags(np, 1, &flags);
         if (ret < 0)
                 return NULL;
         pdata->mdio = ret;
+        pdata->mdio_active_low = flags & OF_GPIO_ACTIVE_LOW;
+
+        ret = of_get_gpio_flags(np, 2, &flags);
+        if (ret > 0) {
+                pdata->mdo = ret;
+                pdata->mdo_active_low = flags & OF_GPIO_ACTIVE_LOW;
+        }
 
         return pdata;
 }
@@ -64,8 +74,19 @@ static void mdio_dir(struct mdiobb_ctrl *ctrl, int dir)
         struct mdio_gpio_info *bitbang =
                 container_of(ctrl, struct mdio_gpio_info, ctrl);
 
+        if (bitbang->mdo) {
+                /* Separate output pin. Always set its value to high
+                 * when changing direction. If direction is input,
+                 * assume the pin serves as pull-up. If direction is
+                 * output, the default value is high.
+                 */
+                gpio_set_value(bitbang->mdo, 1 ^ bitbang->mdo_active_low);
+                return;
+        }
+
         if (dir)
-                gpio_direction_output(bitbang->mdio, 1);
+                gpio_direction_output(bitbang->mdio,
+                                      1 ^ bitbang->mdio_active_low);
         else
                 gpio_direction_input(bitbang->mdio);
 }
@@ -75,7 +96,7 @@ static int mdio_get(struct mdiobb_ctrl *ctrl)
         struct mdio_gpio_info *bitbang =
                 container_of(ctrl, struct mdio_gpio_info, ctrl);
 
-        return gpio_get_value(bitbang->mdio);
+        return gpio_get_value(bitbang->mdio) ^ bitbang->mdio_active_low;
 }
 
 static void mdio_set(struct mdiobb_ctrl *ctrl, int what)
@@ -83,7 +104,10 @@ static void mdio_set(struct mdiobb_ctrl *ctrl, int what)
         struct mdio_gpio_info *bitbang =
                 container_of(ctrl, struct mdio_gpio_info, ctrl);
 
-        gpio_set_value(bitbang->mdio, what);
+        if (bitbang->mdo)
+                gpio_set_value(bitbang->mdo, what ^ bitbang->mdo_active_low);
+        else
+                gpio_set_value(bitbang->mdio, what ^ bitbang->mdio_active_low);
 }
 
 static void mdc_set(struct mdiobb_ctrl *ctrl, int what)
@@ -91,7 +115,7 @@ static void mdc_set(struct mdiobb_ctrl *ctrl, int what)
         struct mdio_gpio_info *bitbang =
                 container_of(ctrl, struct mdio_gpio_info, ctrl);
 
-        gpio_set_value(bitbang->mdc, what);
+        gpio_set_value(bitbang->mdc, what ^ bitbang->mdc_active_low);
 }
 
 static struct mdiobb_ops mdio_gpio_ops = {
@@ -110,18 +134,22 @@ static struct mii_bus *mdio_gpio_bus_init(struct device *dev,
         struct mdio_gpio_info *bitbang;
         int i;
 
-        bitbang = kzalloc(sizeof(*bitbang), GFP_KERNEL);
+        bitbang = devm_kzalloc(dev, sizeof(*bitbang), GFP_KERNEL);
         if (!bitbang)
                 goto out;
 
         bitbang->ctrl.ops = &mdio_gpio_ops;
         bitbang->ctrl.reset = pdata->reset;
         bitbang->mdc = pdata->mdc;
+        bitbang->mdc_active_low = pdata->mdc_active_low;
         bitbang->mdio = pdata->mdio;
+        bitbang->mdio_active_low = pdata->mdio_active_low;
+        bitbang->mdo = pdata->mdo;
+        bitbang->mdo_active_low = pdata->mdo_active_low;
 
         new_bus = alloc_mdio_bitbang(&bitbang->ctrl);
         if (!new_bus)
-                goto out_free_bitbang;
+                goto out;
 
         new_bus->name = "GPIO Bitbanged MDIO",
 
@@ -138,11 +166,18 @@ static struct mii_bus *mdio_gpio_bus_init(struct device *dev,
 
         snprintf(new_bus->id, MII_BUS_ID_SIZE, "gpio-%x", bus_id);
 
-        if (gpio_request(bitbang->mdc, "mdc"))
+        if (devm_gpio_request(dev, bitbang->mdc, "mdc"))
+                goto out_free_bus;
+
+        if (devm_gpio_request(dev, bitbang->mdio, "mdio"))
                 goto out_free_bus;
 
-        if (gpio_request(bitbang->mdio, "mdio"))
-                goto out_free_mdc;
+        if (bitbang->mdo) {
+                if (devm_gpio_request(dev, bitbang->mdo, "mdo"))
+                        goto out_free_bus;
+                gpio_direction_output(bitbang->mdo, 1);
+                gpio_direction_input(bitbang->mdio);
+        }
 
         gpio_direction_output(bitbang->mdc, 0);
 
@@ -150,12 +185,8 @@ static struct mii_bus *mdio_gpio_bus_init(struct device *dev,
 
         return new_bus;
 
-out_free_mdc:
-        gpio_free(bitbang->mdc);
 out_free_bus:
         free_mdio_bitbang(new_bus);
-out_free_bitbang:
-        kfree(bitbang);
 out:
         return NULL;
 }
@@ -163,13 +194,8 @@ out:
 static void mdio_gpio_bus_deinit(struct device *dev)
 {
         struct mii_bus *bus = dev_get_drvdata(dev);
-        struct mdio_gpio_info *bitbang = bus->priv;
 
-        dev_set_drvdata(dev, NULL);
-        gpio_free(bitbang->mdio);
-        gpio_free(bitbang->mdc);
         free_mdio_bitbang(bus);
-        kfree(bitbang);
 }
 
 static void mdio_gpio_bus_destroy(struct device *dev)
@@ -189,6 +215,10 @@ static int mdio_gpio_probe(struct platform_device *pdev)
         if (pdev->dev.of_node) {
                 pdata = mdio_gpio_of_get_data(pdev);
                 bus_id = of_alias_get_id(pdev->dev.of_node, "mdio-gpio");
+                if (bus_id < 0) {
+                        dev_warn(&pdev->dev, "failed to get alias id\n");
+                        bus_id = 0;
+                }
         } else {
                 pdata = dev_get_platdata(&pdev->dev);
                 bus_id = pdev->id;
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index 5ad971a55c5d..d849684231c1 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -246,13 +246,13 @@ static int ksz9021_load_values_from_of(struct phy_device *phydev,
         if (val1 != -1)
                 newval = ((newval & 0xfff0) | ((val1 / PS_TO_REG) & 0xf) << 0);
 
-        if (val2 != -1)
+        if (val2 != -2)
                 newval = ((newval & 0xff0f) | ((val2 / PS_TO_REG) & 0xf) << 4);
 
-        if (val3 != -1)
+        if (val3 != -3)
                 newval = ((newval & 0xf0ff) | ((val3 / PS_TO_REG) & 0xf) << 8);
 
-        if (val4 != -1)
+        if (val4 != -4)
                 newval = ((newval & 0x0fff) | ((val4 / PS_TO_REG) & 0xf) << 12);
 
         return kszphy_extended_write(phydev, reg, newval);
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index 1b6d09aef427..3bc079a67a3d 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -715,7 +715,7 @@ void phy_state_machine(struct work_struct *work)
         struct delayed_work *dwork = to_delayed_work(work);
         struct phy_device *phydev =
                         container_of(dwork, struct phy_device, state_queue);
-        int needs_aneg = 0, do_suspend = 0;
+        bool needs_aneg = false, do_suspend = false, do_resume = false;
         int err = 0;
 
         mutex_lock(&phydev->lock);
@@ -727,7 +727,7 @@ void phy_state_machine(struct work_struct *work)
         case PHY_PENDING:
                 break;
         case PHY_UP:
-                needs_aneg = 1;
+                needs_aneg = true;
 
                 phydev->link_timeout = PHY_AN_TIMEOUT;
 
@@ -757,7 +757,7 @@ void phy_state_machine(struct work_struct *work)
                         phydev->adjust_link(phydev->attached_dev);
 
                 } else if (0 == phydev->link_timeout--)
-                        needs_aneg = 1;
+                        needs_aneg = true;
                 break;
         case PHY_NOLINK:
                 err = phy_read_status(phydev);
@@ -765,6 +765,17 @@ void phy_state_machine(struct work_struct *work)
                         break;
 
                 if (phydev->link) {
+                        if (AUTONEG_ENABLE == phydev->autoneg) {
+                                err = phy_aneg_done(phydev);
+                                if (err < 0)
+                                        break;
+
+                                if (!err) {
+                                        phydev->state = PHY_AN;
+                                        phydev->link_timeout = PHY_AN_TIMEOUT;
+                                        break;
+                                }
+                        }
                         phydev->state = PHY_RUNNING;
                         netif_carrier_on(phydev->attached_dev);
                         phydev->adjust_link(phydev->attached_dev);
@@ -780,7 +791,7 @@ void phy_state_machine(struct work_struct *work)
                         netif_carrier_on(phydev->attached_dev);
                 } else {
                         if (0 == phydev->link_timeout--)
-                                needs_aneg = 1;
+                                needs_aneg = true;
                 }
 
                 phydev->adjust_link(phydev->attached_dev);
@@ -816,7 +827,7 @@ void phy_state_machine(struct work_struct *work)
                         phydev->link = 0;
                         netif_carrier_off(phydev->attached_dev);
                         phydev->adjust_link(phydev->attached_dev);
-                        do_suspend = 1;
+                        do_suspend = true;
                 }
                 break;
         case PHY_RESUMING:
@@ -865,6 +876,7 @@ void phy_state_machine(struct work_struct *work)
                         }
                         phydev->adjust_link(phydev->attached_dev);
                 }
+                do_resume = true;
                 break;
         }
 
@@ -872,9 +884,10 @@ void phy_state_machine(struct work_struct *work)
 
         if (needs_aneg)
                 err = phy_start_aneg(phydev);
-
-        if (do_suspend)
+        else if (do_suspend)
                 phy_suspend(phydev);
+        else if (do_resume)
+                phy_resume(phydev);
 
         if (err < 0)
                 phy_error(phydev);
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index 0ce606624296..4987a1c6dc52 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -614,8 +614,8 @@ int phy_attach_direct(struct net_device *dev, struct phy_device *phydev,
         err = phy_init_hw(phydev);
         if (err)
                 phy_detach(phydev);
-
-        phy_resume(phydev);
+        else
+                phy_resume(phydev);
 
         return err;
 }