4 files changed, 49 insertions, 17 deletions

diff --git a/drivers/net/phy/fixed.c b/drivers/net/phy/fixed.c
index 1cec8967a089..b5e13f8d5e31 100644
--- a/drivers/net/phy/fixed.c
+++ b/drivers/net/phy/fixed.c
@@ -24,7 +24,7 @@
 
 struct fixed_mdio_bus {
         int irqs[PHY_MAX_ADDR];
-        struct mii_bus mii_bus;
+        struct mii_bus *mii_bus;
         struct list_head phys;
 };
 
@@ -213,19 +213,27 @@ static int __init fixed_mdio_bus_init(void)
                 goto err_pdev;
         }
 
-        snprintf(fmb->mii_bus.id, MII_BUS_ID_SIZE, "0");
-        fmb->mii_bus.name = "Fixed MDIO Bus";
-        fmb->mii_bus.parent = &pdev->dev;
-        fmb->mii_bus.read = &fixed_mdio_read;
-        fmb->mii_bus.write = &fixed_mdio_write;
-        fmb->mii_bus.irq = fmb->irqs;
+        fmb->mii_bus = mdiobus_alloc();
+        if (fmb->mii_bus == NULL) {
+                ret = -ENOMEM;
+                goto err_mdiobus_reg;
+        }
 
-        ret = mdiobus_register(&fmb->mii_bus);
+        snprintf(fmb->mii_bus->id, MII_BUS_ID_SIZE, "0");
+        fmb->mii_bus->name = "Fixed MDIO Bus";
+        fmb->mii_bus->parent = &pdev->dev;
+        fmb->mii_bus->read = &fixed_mdio_read;
+        fmb->mii_bus->write = &fixed_mdio_write;
+        fmb->mii_bus->irq = fmb->irqs;
+
+        ret = mdiobus_register(fmb->mii_bus);
         if (ret)
-                goto err_mdiobus_reg;
+                goto err_mdiobus_alloc;
 
         return 0;
 
+err_mdiobus_alloc:
+        mdiobus_free(fmb->mii_bus);
 err_mdiobus_reg:
         platform_device_unregister(pdev);
 err_pdev:
@@ -238,7 +246,8 @@ static void __exit fixed_mdio_bus_exit(void)
         struct fixed_mdio_bus *fmb = &platform_fmb;
         struct fixed_phy *fp, *tmp;
 
-        mdiobus_unregister(&fmb->mii_bus);
+        mdiobus_unregister(fmb->mii_bus);
+        mdiobus_free(fmb->mii_bus);
         platform_device_unregister(pdev);
 
         list_for_each_entry_safe(fp, tmp, &fmb->phys, node) {
diff --git a/drivers/net/phy/mdio-bitbang.c b/drivers/net/phy/mdio-bitbang.c
index c01b78013ddc..2576055b350b 100644
--- a/drivers/net/phy/mdio-bitbang.c
+++ b/drivers/net/phy/mdio-bitbang.c
@@ -165,7 +165,7 @@ struct mii_bus *alloc_mdio_bitbang(struct mdiobb_ctrl *ctrl)
 {
         struct mii_bus *bus;
 
-        bus = kzalloc(sizeof(struct mii_bus), GFP_KERNEL);
+        bus = mdiobus_alloc();
         if (!bus)
                 return NULL;
 
@@ -184,7 +184,7 @@ void free_mdio_bitbang(struct mii_bus *bus)
         struct mdiobb_ctrl *ctrl = bus->priv;
 
         module_put(ctrl->ops->owner);
-        kfree(bus);
+        mdiobus_free(bus);
 }
 EXPORT_SYMBOL(free_mdio_bitbang);
 
diff --git a/drivers/net/phy/mdio-ofgpio.c b/drivers/net/phy/mdio-ofgpio.c
index 27bd4539d089..2ff97754e574 100644
--- a/drivers/net/phy/mdio-ofgpio.c
+++ b/drivers/net/phy/mdio-ofgpio.c
@@ -122,7 +122,7 @@ static int __devinit mdio_ofgpio_probe(struct of_device *ofdev,
 
         new_bus = alloc_mdio_bitbang(&bitbang->ctrl);
         if (!new_bus)
-                goto out_free_priv;
+                goto out_free_bitbang;
 
         new_bus->name = "GPIO Bitbanged MII",
 
@@ -155,9 +155,9 @@ out_free_irqs:
         dev_set_drvdata(&ofdev->dev, NULL);
         kfree(new_bus->irq);
 out_free_bus:
-        kfree(new_bus);
-out_free_priv:
         free_mdio_bitbang(new_bus);
+out_free_bitbang:
+        kfree(bitbang);
 out:
         return ret;
 }
@@ -168,11 +168,10 @@ static int mdio_ofgpio_remove(struct of_device *ofdev)
         struct mdio_gpio_info *bitbang = bus->priv;
 
         mdiobus_unregister(bus);
+        kfree(bus->irq);
         free_mdio_bitbang(bus);
         dev_set_drvdata(&ofdev->dev, NULL);
-        kfree(bus->irq);
         kfree(bitbang);
-        kfree(bus);
 
         return 0;
 }
diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
index a7211a32bb4a..d206691f15d8 100644
--- a/drivers/net/phy/mdio_bus.c
+++ b/drivers/net/phy/mdio_bus.c
@@ -36,6 +36,18 @@
 #include <asm/uaccess.h>
 
 /**
+ * mdiobus_alloc - allocate a mii_bus structure
+ *
+ * Description: called by a bus driver to allocate an mii_bus
+ * structure to fill in.
+ */
+struct mii_bus *mdiobus_alloc(void)
+{
+        return kzalloc(sizeof(struct mii_bus), GFP_KERNEL);
+}
+EXPORT_SYMBOL(mdiobus_alloc);
+
+/**
  * mdiobus_register - bring up all the PHYs on a given bus and attach them to bus
  * @bus: target mii_bus
  *
@@ -87,6 +99,18 @@ void mdiobus_unregister(struct mii_bus *bus)
 }
 EXPORT_SYMBOL(mdiobus_unregister);
 
+/**
+ * mdiobus_free - free a struct mii_bus
+ * @bus: mii_bus to free
+ *
+ * This function frees the mii_bus.
+ */
+void mdiobus_free(struct mii_bus *bus)
+{
+        kfree(bus);
+}
+EXPORT_SYMBOL(mdiobus_free);
+
 struct phy_device *mdiobus_scan(struct mii_bus *bus, int addr)
 {
         struct phy_device *phydev;