diff options
Diffstat (limited to 'drivers/net/hamradio')
-rw-r--r-- | drivers/net/hamradio/6pack.c | 10 | ||||
-rw-r--r-- | drivers/net/hamradio/mkiss.c | 41 |
2 files changed, 30 insertions, 21 deletions
diff --git a/drivers/net/hamradio/6pack.c b/drivers/net/hamradio/6pack.c index 155160052c8b..913a56406594 100644 --- a/drivers/net/hamradio/6pack.c +++ b/drivers/net/hamradio/6pack.c | |||
@@ -398,13 +398,14 @@ static DEFINE_RWLOCK(disc_data_lock); | |||
398 | 398 | ||
399 | static struct sixpack *sp_get(struct tty_struct *tty) | 399 | static struct sixpack *sp_get(struct tty_struct *tty) |
400 | { | 400 | { |
401 | unsigned long flags; | ||
401 | struct sixpack *sp; | 402 | struct sixpack *sp; |
402 | 403 | ||
403 | read_lock(&disc_data_lock); | 404 | read_lock_irqsave(&disc_data_lock, flags); |
404 | sp = tty->disc_data; | 405 | sp = tty->disc_data; |
405 | if (sp) | 406 | if (sp) |
406 | atomic_inc(&sp->refcnt); | 407 | atomic_inc(&sp->refcnt); |
407 | read_unlock(&disc_data_lock); | 408 | read_unlock_irqrestore(&disc_data_lock, flags); |
408 | 409 | ||
409 | return sp; | 410 | return sp; |
410 | } | 411 | } |
@@ -688,12 +689,13 @@ out: | |||
688 | */ | 689 | */ |
689 | static void sixpack_close(struct tty_struct *tty) | 690 | static void sixpack_close(struct tty_struct *tty) |
690 | { | 691 | { |
692 | unsigned long flags; | ||
691 | struct sixpack *sp; | 693 | struct sixpack *sp; |
692 | 694 | ||
693 | write_lock(&disc_data_lock); | 695 | write_lock_irqsave(&disc_data_lock, flags); |
694 | sp = tty->disc_data; | 696 | sp = tty->disc_data; |
695 | tty->disc_data = NULL; | 697 | tty->disc_data = NULL; |
696 | write_unlock(&disc_data_lock); | 698 | write_unlock_irqrestore(&disc_data_lock, flags); |
697 | if (!sp) | 699 | if (!sp) |
698 | return; | 700 | return; |
699 | 701 | ||
diff --git a/drivers/net/hamradio/mkiss.c b/drivers/net/hamradio/mkiss.c index fda2fc83e9a1..a7286500c186 100644 --- a/drivers/net/hamradio/mkiss.c +++ b/drivers/net/hamradio/mkiss.c | |||
@@ -244,15 +244,16 @@ static int kiss_esc_crc(unsigned char *s, unsigned char *d, unsigned short crc, | |||
244 | /* Send one completely decapsulated AX.25 packet to the AX.25 layer. */ | 244 | /* Send one completely decapsulated AX.25 packet to the AX.25 layer. */ |
245 | static void ax_bump(struct mkiss *ax) | 245 | static void ax_bump(struct mkiss *ax) |
246 | { | 246 | { |
247 | unsigned long flags; | ||
247 | struct sk_buff *skb; | 248 | struct sk_buff *skb; |
248 | int count; | 249 | int count; |
249 | 250 | ||
250 | spin_lock_bh(&ax->buflock); | 251 | spin_lock_irqsave(&ax->buflock, flags); |
251 | if (ax->rbuff[0] > 0x0f) { | 252 | if (ax->rbuff[0] > 0x0f) { |
252 | if (ax->rbuff[0] & 0x80) { | 253 | if (ax->rbuff[0] & 0x80) { |
253 | if (check_crc_16(ax->rbuff, ax->rcount) < 0) { | 254 | if (check_crc_16(ax->rbuff, ax->rcount) < 0) { |
254 | ax->dev->stats.rx_errors++; | 255 | ax->dev->stats.rx_errors++; |
255 | spin_unlock_bh(&ax->buflock); | 256 | spin_unlock_irqrestore(&ax->buflock, flags); |
256 | 257 | ||
257 | return; | 258 | return; |
258 | } | 259 | } |
@@ -267,7 +268,7 @@ static void ax_bump(struct mkiss *ax) | |||
267 | } else if (ax->rbuff[0] & 0x20) { | 268 | } else if (ax->rbuff[0] & 0x20) { |
268 | if (check_crc_flex(ax->rbuff, ax->rcount) < 0) { | 269 | if (check_crc_flex(ax->rbuff, ax->rcount) < 0) { |
269 | ax->dev->stats.rx_errors++; | 270 | ax->dev->stats.rx_errors++; |
270 | spin_unlock_bh(&ax->buflock); | 271 | spin_unlock_irqrestore(&ax->buflock, flags); |
271 | return; | 272 | return; |
272 | } | 273 | } |
273 | if (ax->crcmode != CRC_MODE_FLEX && ax->crcauto) { | 274 | if (ax->crcmode != CRC_MODE_FLEX && ax->crcauto) { |
@@ -294,7 +295,7 @@ static void ax_bump(struct mkiss *ax) | |||
294 | printk(KERN_ERR "mkiss: %s: memory squeeze, dropping packet.\n", | 295 | printk(KERN_ERR "mkiss: %s: memory squeeze, dropping packet.\n", |
295 | ax->dev->name); | 296 | ax->dev->name); |
296 | ax->dev->stats.rx_dropped++; | 297 | ax->dev->stats.rx_dropped++; |
297 | spin_unlock_bh(&ax->buflock); | 298 | spin_unlock_irqrestore(&ax->buflock, flags); |
298 | return; | 299 | return; |
299 | } | 300 | } |
300 | 301 | ||
@@ -303,11 +304,13 @@ static void ax_bump(struct mkiss *ax) | |||
303 | netif_rx(skb); | 304 | netif_rx(skb); |
304 | ax->dev->stats.rx_packets++; | 305 | ax->dev->stats.rx_packets++; |
305 | ax->dev->stats.rx_bytes += count; | 306 | ax->dev->stats.rx_bytes += count; |
306 | spin_unlock_bh(&ax->buflock); | 307 | spin_unlock_irqrestore(&ax->buflock, flags); |
307 | } | 308 | } |
308 | 309 | ||
309 | static void kiss_unesc(struct mkiss *ax, unsigned char s) | 310 | static void kiss_unesc(struct mkiss *ax, unsigned char s) |
310 | { | 311 | { |
312 | unsigned long flags; | ||
313 | |||
311 | switch (s) { | 314 | switch (s) { |
312 | case END: | 315 | case END: |
313 | /* drop keeptest bit = VSV */ | 316 | /* drop keeptest bit = VSV */ |
@@ -334,18 +337,18 @@ static void kiss_unesc(struct mkiss *ax, unsigned char s) | |||
334 | break; | 337 | break; |
335 | } | 338 | } |
336 | 339 | ||
337 | spin_lock_bh(&ax->buflock); | 340 | spin_lock_irqsave(&ax->buflock, flags); |
338 | if (!test_bit(AXF_ERROR, &ax->flags)) { | 341 | if (!test_bit(AXF_ERROR, &ax->flags)) { |
339 | if (ax->rcount < ax->buffsize) { | 342 | if (ax->rcount < ax->buffsize) { |
340 | ax->rbuff[ax->rcount++] = s; | 343 | ax->rbuff[ax->rcount++] = s; |
341 | spin_unlock_bh(&ax->buflock); | 344 | spin_unlock_irqrestore(&ax->buflock, flags); |
342 | return; | 345 | return; |
343 | } | 346 | } |
344 | 347 | ||
345 | ax->dev->stats.rx_over_errors++; | 348 | ax->dev->stats.rx_over_errors++; |
346 | set_bit(AXF_ERROR, &ax->flags); | 349 | set_bit(AXF_ERROR, &ax->flags); |
347 | } | 350 | } |
348 | spin_unlock_bh(&ax->buflock); | 351 | spin_unlock_irqrestore(&ax->buflock, flags); |
349 | } | 352 | } |
350 | 353 | ||
351 | static int ax_set_mac_address(struct net_device *dev, void *addr) | 354 | static int ax_set_mac_address(struct net_device *dev, void *addr) |
@@ -367,6 +370,7 @@ static void ax_changedmtu(struct mkiss *ax) | |||
367 | { | 370 | { |
368 | struct net_device *dev = ax->dev; | 371 | struct net_device *dev = ax->dev; |
369 | unsigned char *xbuff, *rbuff, *oxbuff, *orbuff; | 372 | unsigned char *xbuff, *rbuff, *oxbuff, *orbuff; |
373 | unsigned long flags; | ||
370 | int len; | 374 | int len; |
371 | 375 | ||
372 | len = dev->mtu * 2; | 376 | len = dev->mtu * 2; |
@@ -392,7 +396,7 @@ static void ax_changedmtu(struct mkiss *ax) | |||
392 | return; | 396 | return; |
393 | } | 397 | } |
394 | 398 | ||
395 | spin_lock_bh(&ax->buflock); | 399 | spin_lock_irqsave(&ax->buflock, flags); |
396 | 400 | ||
397 | oxbuff = ax->xbuff; | 401 | oxbuff = ax->xbuff; |
398 | ax->xbuff = xbuff; | 402 | ax->xbuff = xbuff; |
@@ -423,7 +427,7 @@ static void ax_changedmtu(struct mkiss *ax) | |||
423 | ax->mtu = dev->mtu + 73; | 427 | ax->mtu = dev->mtu + 73; |
424 | ax->buffsize = len; | 428 | ax->buffsize = len; |
425 | 429 | ||
426 | spin_unlock_bh(&ax->buflock); | 430 | spin_unlock_irqrestore(&ax->buflock, flags); |
427 | 431 | ||
428 | kfree(oxbuff); | 432 | kfree(oxbuff); |
429 | kfree(orbuff); | 433 | kfree(orbuff); |
@@ -433,6 +437,7 @@ static void ax_changedmtu(struct mkiss *ax) | |||
433 | static void ax_encaps(struct net_device *dev, unsigned char *icp, int len) | 437 | static void ax_encaps(struct net_device *dev, unsigned char *icp, int len) |
434 | { | 438 | { |
435 | struct mkiss *ax = netdev_priv(dev); | 439 | struct mkiss *ax = netdev_priv(dev); |
440 | unsigned long flags; | ||
436 | unsigned char *p; | 441 | unsigned char *p; |
437 | int actual, count; | 442 | int actual, count; |
438 | 443 | ||
@@ -449,7 +454,7 @@ static void ax_encaps(struct net_device *dev, unsigned char *icp, int len) | |||
449 | 454 | ||
450 | p = icp; | 455 | p = icp; |
451 | 456 | ||
452 | spin_lock_bh(&ax->buflock); | 457 | spin_lock_irqsave(&ax->buflock, flags); |
453 | if ((*p & 0x0f) != 0) { | 458 | if ((*p & 0x0f) != 0) { |
454 | /* Configuration Command (kissparms(1). | 459 | /* Configuration Command (kissparms(1). |
455 | * Protocol spec says: never append CRC. | 460 | * Protocol spec says: never append CRC. |
@@ -479,7 +484,7 @@ static void ax_encaps(struct net_device *dev, unsigned char *icp, int len) | |||
479 | ax->crcauto = (cmd ? 0 : 1); | 484 | ax->crcauto = (cmd ? 0 : 1); |
480 | printk(KERN_INFO "mkiss: %s: crc mode %s %d\n", ax->dev->name, (len) ? "set to" : "is", cmd); | 485 | printk(KERN_INFO "mkiss: %s: crc mode %s %d\n", ax->dev->name, (len) ? "set to" : "is", cmd); |
481 | } | 486 | } |
482 | spin_unlock_bh(&ax->buflock); | 487 | spin_unlock_irqrestore(&ax->buflock, flags); |
483 | netif_start_queue(dev); | 488 | netif_start_queue(dev); |
484 | 489 | ||
485 | return; | 490 | return; |
@@ -512,7 +517,7 @@ static void ax_encaps(struct net_device *dev, unsigned char *icp, int len) | |||
512 | count = kiss_esc(p, (unsigned char *)ax->xbuff, len); | 517 | count = kiss_esc(p, (unsigned char *)ax->xbuff, len); |
513 | } | 518 | } |
514 | } | 519 | } |
515 | spin_unlock_bh(&ax->buflock); | 520 | spin_unlock_irqrestore(&ax->buflock, flags); |
516 | 521 | ||
517 | set_bit(TTY_DO_WRITE_WAKEUP, &ax->tty->flags); | 522 | set_bit(TTY_DO_WRITE_WAKEUP, &ax->tty->flags); |
518 | actual = ax->tty->ops->write(ax->tty, ax->xbuff, count); | 523 | actual = ax->tty->ops->write(ax->tty, ax->xbuff, count); |
@@ -704,13 +709,14 @@ static DEFINE_RWLOCK(disc_data_lock); | |||
704 | 709 | ||
705 | static struct mkiss *mkiss_get(struct tty_struct *tty) | 710 | static struct mkiss *mkiss_get(struct tty_struct *tty) |
706 | { | 711 | { |
712 | unsigned long flags; | ||
707 | struct mkiss *ax; | 713 | struct mkiss *ax; |
708 | 714 | ||
709 | read_lock(&disc_data_lock); | 715 | read_lock_irqsave(&disc_data_lock, flags); |
710 | ax = tty->disc_data; | 716 | ax = tty->disc_data; |
711 | if (ax) | 717 | if (ax) |
712 | atomic_inc(&ax->refcnt); | 718 | atomic_inc(&ax->refcnt); |
713 | read_unlock(&disc_data_lock); | 719 | read_unlock_irqrestore(&disc_data_lock, flags); |
714 | 720 | ||
715 | return ax; | 721 | return ax; |
716 | } | 722 | } |
@@ -809,12 +815,13 @@ out: | |||
809 | 815 | ||
810 | static void mkiss_close(struct tty_struct *tty) | 816 | static void mkiss_close(struct tty_struct *tty) |
811 | { | 817 | { |
818 | unsigned long flags; | ||
812 | struct mkiss *ax; | 819 | struct mkiss *ax; |
813 | 820 | ||
814 | write_lock(&disc_data_lock); | 821 | write_lock_irqsave(&disc_data_lock, flags); |
815 | ax = tty->disc_data; | 822 | ax = tty->disc_data; |
816 | tty->disc_data = NULL; | 823 | tty->disc_data = NULL; |
817 | write_unlock(&disc_data_lock); | 824 | write_unlock_irqrestore(&disc_data_lock, flags); |
818 | 825 | ||
819 | if (!ax) | 826 | if (!ax) |
820 | return; | 827 | return; |