diff options
Diffstat (limited to 'drivers/net/forcedeth.c')
-rw-r--r-- | drivers/net/forcedeth.c | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/drivers/net/forcedeth.c b/drivers/net/forcedeth.c index feb5b223cd60..5a8651b4b01d 100644 --- a/drivers/net/forcedeth.c +++ b/drivers/net/forcedeth.c | |||
@@ -533,9 +533,9 @@ typedef union _ring_type { | |||
533 | * critical parts: | 533 | * critical parts: |
534 | * - rx is (pseudo-) lockless: it relies on the single-threading provided | 534 | * - rx is (pseudo-) lockless: it relies on the single-threading provided |
535 | * by the arch code for interrupts. | 535 | * by the arch code for interrupts. |
536 | * - tx setup is lockless: it relies on dev->xmit_lock. Actual submission | 536 | * - tx setup is lockless: it relies on netif_tx_lock. Actual submission |
537 | * needs dev->priv->lock :-( | 537 | * needs dev->priv->lock :-( |
538 | * - set_multicast_list: preparation lockless, relies on dev->xmit_lock. | 538 | * - set_multicast_list: preparation lockless, relies on netif_tx_lock. |
539 | */ | 539 | */ |
540 | 540 | ||
541 | /* in dev: base, irq */ | 541 | /* in dev: base, irq */ |
@@ -1213,7 +1213,7 @@ static void drain_ring(struct net_device *dev) | |||
1213 | 1213 | ||
1214 | /* | 1214 | /* |
1215 | * nv_start_xmit: dev->hard_start_xmit function | 1215 | * nv_start_xmit: dev->hard_start_xmit function |
1216 | * Called with dev->xmit_lock held. | 1216 | * Called with netif_tx_lock held. |
1217 | */ | 1217 | */ |
1218 | static int nv_start_xmit(struct sk_buff *skb, struct net_device *dev) | 1218 | static int nv_start_xmit(struct sk_buff *skb, struct net_device *dev) |
1219 | { | 1219 | { |
@@ -1407,7 +1407,7 @@ static void nv_tx_done(struct net_device *dev) | |||
1407 | 1407 | ||
1408 | /* | 1408 | /* |
1409 | * nv_tx_timeout: dev->tx_timeout function | 1409 | * nv_tx_timeout: dev->tx_timeout function |
1410 | * Called with dev->xmit_lock held. | 1410 | * Called with netif_tx_lock held. |
1411 | */ | 1411 | */ |
1412 | static void nv_tx_timeout(struct net_device *dev) | 1412 | static void nv_tx_timeout(struct net_device *dev) |
1413 | { | 1413 | { |
@@ -1737,7 +1737,7 @@ static int nv_change_mtu(struct net_device *dev, int new_mtu) | |||
1737 | * Changing the MTU is a rare event, it shouldn't matter. | 1737 | * Changing the MTU is a rare event, it shouldn't matter. |
1738 | */ | 1738 | */ |
1739 | nv_disable_irq(dev); | 1739 | nv_disable_irq(dev); |
1740 | spin_lock_bh(&dev->xmit_lock); | 1740 | netif_tx_lock_bh(dev); |
1741 | spin_lock(&np->lock); | 1741 | spin_lock(&np->lock); |
1742 | /* stop engines */ | 1742 | /* stop engines */ |
1743 | nv_stop_rx(dev); | 1743 | nv_stop_rx(dev); |
@@ -1768,7 +1768,7 @@ static int nv_change_mtu(struct net_device *dev, int new_mtu) | |||
1768 | nv_start_rx(dev); | 1768 | nv_start_rx(dev); |
1769 | nv_start_tx(dev); | 1769 | nv_start_tx(dev); |
1770 | spin_unlock(&np->lock); | 1770 | spin_unlock(&np->lock); |
1771 | spin_unlock_bh(&dev->xmit_lock); | 1771 | netif_tx_unlock_bh(dev); |
1772 | nv_enable_irq(dev); | 1772 | nv_enable_irq(dev); |
1773 | } | 1773 | } |
1774 | return 0; | 1774 | return 0; |
@@ -1803,7 +1803,7 @@ static int nv_set_mac_address(struct net_device *dev, void *addr) | |||
1803 | memcpy(dev->dev_addr, macaddr->sa_data, ETH_ALEN); | 1803 | memcpy(dev->dev_addr, macaddr->sa_data, ETH_ALEN); |
1804 | 1804 | ||
1805 | if (netif_running(dev)) { | 1805 | if (netif_running(dev)) { |
1806 | spin_lock_bh(&dev->xmit_lock); | 1806 | netif_tx_lock_bh(dev); |
1807 | spin_lock_irq(&np->lock); | 1807 | spin_lock_irq(&np->lock); |
1808 | 1808 | ||
1809 | /* stop rx engine */ | 1809 | /* stop rx engine */ |
@@ -1815,7 +1815,7 @@ static int nv_set_mac_address(struct net_device *dev, void *addr) | |||
1815 | /* restart rx engine */ | 1815 | /* restart rx engine */ |
1816 | nv_start_rx(dev); | 1816 | nv_start_rx(dev); |
1817 | spin_unlock_irq(&np->lock); | 1817 | spin_unlock_irq(&np->lock); |
1818 | spin_unlock_bh(&dev->xmit_lock); | 1818 | netif_tx_unlock_bh(dev); |
1819 | } else { | 1819 | } else { |
1820 | nv_copy_mac_to_hw(dev); | 1820 | nv_copy_mac_to_hw(dev); |
1821 | } | 1821 | } |
@@ -1824,7 +1824,7 @@ static int nv_set_mac_address(struct net_device *dev, void *addr) | |||
1824 | 1824 | ||
1825 | /* | 1825 | /* |
1826 | * nv_set_multicast: dev->set_multicast function | 1826 | * nv_set_multicast: dev->set_multicast function |
1827 | * Called with dev->xmit_lock held. | 1827 | * Called with netif_tx_lock held. |
1828 | */ | 1828 | */ |
1829 | static void nv_set_multicast(struct net_device *dev) | 1829 | static void nv_set_multicast(struct net_device *dev) |
1830 | { | 1830 | { |