aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/forcedeth.c
diff options
context:
space:
mode:
Diffstat (limited to 'drivers/net/forcedeth.c')
-rw-r--r--drivers/net/forcedeth.c18
1 files changed, 9 insertions, 9 deletions
diff --git a/drivers/net/forcedeth.c b/drivers/net/forcedeth.c
index 4ab39c554d0d..04a53f1dfdbd 100644
--- a/drivers/net/forcedeth.c
+++ b/drivers/net/forcedeth.c
@@ -669,9 +669,9 @@ static const struct register_test nv_registers_test[] = {
669 * critical parts: 669 * critical parts:
670 * - rx is (pseudo-) lockless: it relies on the single-threading provided 670 * - rx is (pseudo-) lockless: it relies on the single-threading provided
671 * by the arch code for interrupts. 671 * by the arch code for interrupts.
672 * - tx setup is lockless: it relies on dev->xmit_lock. Actual submission 672 * - tx setup is lockless: it relies on netif_tx_lock. Actual submission
673 * needs dev->priv->lock :-( 673 * needs dev->priv->lock :-(
674 * - set_multicast_list: preparation lockless, relies on dev->xmit_lock. 674 * - set_multicast_list: preparation lockless, relies on netif_tx_lock.
675 */ 675 */
676 676
677/* in dev: base, irq */ 677/* in dev: base, irq */
@@ -1405,7 +1405,7 @@ static void drain_ring(struct net_device *dev)
1405 1405
1406/* 1406/*
1407 * nv_start_xmit: dev->hard_start_xmit function 1407 * nv_start_xmit: dev->hard_start_xmit function
1408 * Called with dev->xmit_lock held. 1408 * Called with netif_tx_lock held.
1409 */ 1409 */
1410static int nv_start_xmit(struct sk_buff *skb, struct net_device *dev) 1410static int nv_start_xmit(struct sk_buff *skb, struct net_device *dev)
1411{ 1411{
@@ -1599,7 +1599,7 @@ static void nv_tx_done(struct net_device *dev)
1599 1599
1600/* 1600/*
1601 * nv_tx_timeout: dev->tx_timeout function 1601 * nv_tx_timeout: dev->tx_timeout function
1602 * Called with dev->xmit_lock held. 1602 * Called with netif_tx_lock held.
1603 */ 1603 */
1604static void nv_tx_timeout(struct net_device *dev) 1604static void nv_tx_timeout(struct net_device *dev)
1605{ 1605{
@@ -1930,7 +1930,7 @@ static int nv_change_mtu(struct net_device *dev, int new_mtu)
1930 * Changing the MTU is a rare event, it shouldn't matter. 1930 * Changing the MTU is a rare event, it shouldn't matter.
1931 */ 1931 */
1932 nv_disable_irq(dev); 1932 nv_disable_irq(dev);
1933 spin_lock_bh(&dev->xmit_lock); 1933 netif_tx_lock_bh(dev);
1934 spin_lock(&np->lock); 1934 spin_lock(&np->lock);
1935 /* stop engines */ 1935 /* stop engines */
1936 nv_stop_rx(dev); 1936 nv_stop_rx(dev);
@@ -1958,7 +1958,7 @@ static int nv_change_mtu(struct net_device *dev, int new_mtu)
1958 nv_start_rx(dev); 1958 nv_start_rx(dev);
1959 nv_start_tx(dev); 1959 nv_start_tx(dev);
1960 spin_unlock(&np->lock); 1960 spin_unlock(&np->lock);
1961 spin_unlock_bh(&dev->xmit_lock); 1961 netif_tx_unlock_bh(dev);
1962 nv_enable_irq(dev); 1962 nv_enable_irq(dev);
1963 } 1963 }
1964 return 0; 1964 return 0;
@@ -1993,7 +1993,7 @@ static int nv_set_mac_address(struct net_device *dev, void *addr)
1993 memcpy(dev->dev_addr, macaddr->sa_data, ETH_ALEN); 1993 memcpy(dev->dev_addr, macaddr->sa_data, ETH_ALEN);
1994 1994
1995 if (netif_running(dev)) { 1995 if (netif_running(dev)) {
1996 spin_lock_bh(&dev->xmit_lock); 1996 netif_tx_lock_bh(dev);
1997 spin_lock_irq(&np->lock); 1997 spin_lock_irq(&np->lock);
1998 1998
1999 /* stop rx engine */ 1999 /* stop rx engine */
@@ -2005,7 +2005,7 @@ static int nv_set_mac_address(struct net_device *dev, void *addr)
2005 /* restart rx engine */ 2005 /* restart rx engine */
2006 nv_start_rx(dev); 2006 nv_start_rx(dev);
2007 spin_unlock_irq(&np->lock); 2007 spin_unlock_irq(&np->lock);
2008 spin_unlock_bh(&dev->xmit_lock); 2008 netif_tx_unlock_bh(dev);
2009 } else { 2009 } else {
2010 nv_copy_mac_to_hw(dev); 2010 nv_copy_mac_to_hw(dev);
2011 } 2011 }
@@ -2014,7 +2014,7 @@ static int nv_set_mac_address(struct net_device *dev, void *addr)
2014 2014
2015/* 2015/*
2016 * nv_set_multicast: dev->set_multicast function 2016 * nv_set_multicast: dev->set_multicast function
2017 * Called with dev->xmit_lock held. 2017 * Called with netif_tx_lock held.
2018 */ 2018 */
2019static void nv_set_multicast(struct net_device *dev) 2019static void nv_set_multicast(struct net_device *dev)
2020{ 2020{