8 files changed, 175 insertions, 110 deletions

diff --git a/drivers/net/ethernet/altera/Kconfig b/drivers/net/ethernet/altera/Kconfig
index 80c1ab74a4b8..fdddba51473e 100644
--- a/drivers/net/ethernet/altera/Kconfig
+++ b/drivers/net/ethernet/altera/Kconfig
@@ -1,5 +1,6 @@
 config ALTERA_TSE
         tristate "Altera Triple-Speed Ethernet MAC support"
+        depends on HAS_DMA
         select PHYLIB
         ---help---
           This driver supports the Altera Triple-Speed (TSE) Ethernet MAC.
diff --git a/drivers/net/ethernet/altera/altera_msgdma.c b/drivers/net/ethernet/altera/altera_msgdma.c
index 3df18669ea30..4d1f2fdd5c32 100644
--- a/drivers/net/ethernet/altera/altera_msgdma.c
+++ b/drivers/net/ethernet/altera/altera_msgdma.c
@@ -18,6 +18,7 @@
 #include "altera_utils.h"
 #include "altera_tse.h"
 #include "altera_msgdmahw.h"
+#include "altera_msgdma.h"
 
 /* No initialization work to do for MSGDMA */
 int msgdma_initialize(struct altera_tse_private *priv)
@@ -29,6 +30,10 @@ void msgdma_uninitialize(struct altera_tse_private *priv)
 {
 }
 
+void msgdma_start_rxdma(struct altera_tse_private *priv)
+{
+}
+
 void msgdma_reset(struct altera_tse_private *priv)
 {
         int counter;
@@ -154,7 +159,7 @@ u32 msgdma_tx_completions(struct altera_tse_private *priv)
 
 /* Put buffer to the mSGDMA RX FIFO
  */
-int msgdma_add_rx_desc(struct altera_tse_private *priv,
+void msgdma_add_rx_desc(struct altera_tse_private *priv,
                         struct tse_buffer *rxbuffer)
 {
         struct msgdma_extended_desc *desc = priv->rx_dma_desc;
@@ -175,7 +180,6 @@ int msgdma_add_rx_desc(struct altera_tse_private *priv,
         iowrite32(0, &desc->burst_seq_num);
         iowrite32(0x00010001, &desc->stride);
         iowrite32(control, &desc->control);
-        return 1;
 }
 
 /* status is returned on upper 16 bits,
diff --git a/drivers/net/ethernet/altera/altera_msgdma.h b/drivers/net/ethernet/altera/altera_msgdma.h
index 7f0f5bf2bba2..42cf61c81057 100644
--- a/drivers/net/ethernet/altera/altera_msgdma.h
+++ b/drivers/net/ethernet/altera/altera_msgdma.h
@@ -25,10 +25,11 @@ void msgdma_disable_txirq(struct altera_tse_private *);
 void msgdma_clear_rxirq(struct altera_tse_private *);
 void msgdma_clear_txirq(struct altera_tse_private *);
 u32 msgdma_tx_completions(struct altera_tse_private *);
-int msgdma_add_rx_desc(struct altera_tse_private *, struct tse_buffer *);
+void msgdma_add_rx_desc(struct altera_tse_private *, struct tse_buffer *);
 int msgdma_tx_buffer(struct altera_tse_private *, struct tse_buffer *);
 u32 msgdma_rx_status(struct altera_tse_private *);
 int msgdma_initialize(struct altera_tse_private *);
 void msgdma_uninitialize(struct altera_tse_private *);
+void msgdma_start_rxdma(struct altera_tse_private *);
 
 #endif /*  __ALTERA_MSGDMA_H__ */
diff --git a/drivers/net/ethernet/altera/altera_sgdma.c b/drivers/net/ethernet/altera/altera_sgdma.c
index 0ee96639ae44..9ce8630692b6 100644
--- a/drivers/net/ethernet/altera/altera_sgdma.c
+++ b/drivers/net/ethernet/altera/altera_sgdma.c
@@ -20,15 +20,15 @@
 #include "altera_sgdmahw.h"
 #include "altera_sgdma.h"
 
-static void sgdma_descrip(struct sgdma_descrip *desc,
-                          struct sgdma_descrip *ndesc,
-                          dma_addr_t ndesc_phys,
-                          dma_addr_t raddr,
-                          dma_addr_t waddr,
-                          u16 length,
-                          int generate_eop,
-                          int rfixed,
-                          int wfixed);
+static void sgdma_setup_descrip(struct sgdma_descrip *desc,
+                                struct sgdma_descrip *ndesc,
+                                dma_addr_t ndesc_phys,
+                                dma_addr_t raddr,
+                                dma_addr_t waddr,
+                                u16 length,
+                                int generate_eop,
+                                int rfixed,
+                                int wfixed);
 
 static int sgdma_async_write(struct altera_tse_private *priv,
                               struct sgdma_descrip *desc);
@@ -64,11 +64,15 @@ queue_rx_peekhead(struct altera_tse_private *priv);
 
 int sgdma_initialize(struct altera_tse_private *priv)
 {
-        priv->txctrlreg = SGDMA_CTRLREG_ILASTD;
+        priv->txctrlreg = SGDMA_CTRLREG_ILASTD |
+                      SGDMA_CTRLREG_INTEN;
 
         priv->rxctrlreg = SGDMA_CTRLREG_IDESCRIP |
+                      SGDMA_CTRLREG_INTEN |
                       SGDMA_CTRLREG_ILASTD;
 
+        priv->sgdmadesclen = sizeof(struct sgdma_descrip);
+
         INIT_LIST_HEAD(&priv->txlisthd);
         INIT_LIST_HEAD(&priv->rxlisthd);
 
@@ -93,6 +97,16 @@ int sgdma_initialize(struct altera_tse_private *priv)
                 return -EINVAL;
         }
 
+        /* Initialize descriptor memory to all 0's, sync memory to cache */
+        memset(priv->tx_dma_desc, 0, priv->txdescmem);
+        memset(priv->rx_dma_desc, 0, priv->rxdescmem);
+
+        dma_sync_single_for_device(priv->device, priv->txdescphys,
+                                   priv->txdescmem, DMA_TO_DEVICE);
+
+        dma_sync_single_for_device(priv->device, priv->rxdescphys,
+                                   priv->rxdescmem, DMA_TO_DEVICE);
+
         return 0;
 }
 
@@ -130,26 +144,23 @@ void sgdma_reset(struct altera_tse_private *priv)
         iowrite32(0, &prxsgdma->control);
 }
 
+/* For SGDMA, interrupts remain enabled after initially enabling,
+ * so no need to provide implementations for abstract enable
+ * and disable
+ */
+
 void sgdma_enable_rxirq(struct altera_tse_private *priv)
 {
-        struct sgdma_csr *csr = (struct sgdma_csr *)priv->rx_dma_csr;
-        priv->rxctrlreg |= SGDMA_CTRLREG_INTEN;
-        tse_set_bit(&csr->control, SGDMA_CTRLREG_INTEN);
 }
 
 void sgdma_enable_txirq(struct altera_tse_private *priv)
 {
-        struct sgdma_csr *csr = (struct sgdma_csr *)priv->tx_dma_csr;
-        priv->txctrlreg |= SGDMA_CTRLREG_INTEN;
-        tse_set_bit(&csr->control, SGDMA_CTRLREG_INTEN);
 }
 
-/* for SGDMA, RX interrupts remain enabled after enabling */
 void sgdma_disable_rxirq(struct altera_tse_private *priv)
 {
 }
 
-/* for SGDMA, TX interrupts remain enabled after enabling */
 void sgdma_disable_txirq(struct altera_tse_private *priv)
 {
 }
@@ -184,15 +195,15 @@ int sgdma_tx_buffer(struct altera_tse_private *priv, struct tse_buffer *buffer)
         if (sgdma_txbusy(priv))
                 return 0;
 
-        sgdma_descrip(cdesc,                    /* current descriptor */
-                      ndesc,                    /* next descriptor */
-                      sgdma_txphysaddr(priv, ndesc),
-                      buffer->dma_addr,         /* address of packet to xmit */
-                      0,                        /* write addr 0 for tx dma */
-                      buffer->len,              /* length of packet */
-                      SGDMA_CONTROL_EOP,        /* Generate EOP */
-                      0,                        /* read fixed */
-                      SGDMA_CONTROL_WR_FIXED);  /* Generate SOP */
+        sgdma_setup_descrip(cdesc,                      /* current descriptor */
+                            ndesc,                      /* next descriptor */
+                            sgdma_txphysaddr(priv, ndesc),
+                            buffer->dma_addr,           /* address of packet to xmit */
+                            0,                          /* write addr 0 for tx dma */
+                            buffer->len,                /* length of packet */
+                            SGDMA_CONTROL_EOP,          /* Generate EOP */
+                            0,                          /* read fixed */
+                            SGDMA_CONTROL_WR_FIXED);    /* Generate SOP */
 
         pktstx = sgdma_async_write(priv, cdesc);
 
@@ -219,11 +230,15 @@ u32 sgdma_tx_completions(struct altera_tse_private *priv)
         return ready;
 }
 
-int sgdma_add_rx_desc(struct altera_tse_private *priv,
-                      struct tse_buffer *rxbuffer)
+void sgdma_start_rxdma(struct altera_tse_private *priv)
+{
+        sgdma_async_read(priv);
+}
+
+void sgdma_add_rx_desc(struct altera_tse_private *priv,
+                       struct tse_buffer *rxbuffer)
 {
         queue_rx(priv, rxbuffer);
-        return sgdma_async_read(priv);
 }
 
 /* status is returned on upper 16 bits,
@@ -240,28 +255,52 @@ u32 sgdma_rx_status(struct altera_tse_private *priv)
         unsigned int pktstatus = 0;
         struct tse_buffer *rxbuffer = NULL;
 
-        dma_sync_single_for_cpu(priv->device,
-                                priv->rxdescphys,
-                                priv->rxdescmem,
-                                DMA_BIDIRECTIONAL);
+        u32 sts = ioread32(&csr->status);
 
         desc = &base[0];
-        if ((ioread32(&csr->status) & SGDMA_STSREG_EOP) ||
-            (desc->status & SGDMA_STATUS_EOP)) {
+        if (sts & SGDMA_STSREG_EOP) {
+                dma_sync_single_for_cpu(priv->device,
+                                        priv->rxdescphys,
+                                        priv->sgdmadesclen,
+                                        DMA_FROM_DEVICE);
+
                 pktlength = desc->bytes_xferred;
                 pktstatus = desc->status & 0x3f;
                 rxstatus = pktstatus;
                 rxstatus = rxstatus << 16;
                 rxstatus |= (pktlength & 0xffff);
 
-                desc->status = 0;
+                if (rxstatus) {
+                        desc->status = 0;
 
-                rxbuffer = dequeue_rx(priv);
-                if (rxbuffer == NULL)
-                        netdev_err(priv->dev,
-                                   "sgdma rx and rx queue empty!\n");
+                        rxbuffer = dequeue_rx(priv);
+                        if (rxbuffer == NULL)
+                                netdev_info(priv->dev,
+                                            "sgdma rx and rx queue empty!\n");
+
+                        /* Clear control */
+                        iowrite32(0, &csr->control);
+                        /* clear status */
+                        iowrite32(0xf, &csr->status);
 
-                /* kick the rx sgdma after reaping this descriptor */
+                        /* kick the rx sgdma after reaping this descriptor */
+                        pktsrx = sgdma_async_read(priv);
+
+                } else {
+                        /* If the SGDMA indicated an end of packet on recv,
+                         * then it's expected that the rxstatus from the
+                         * descriptor is non-zero - meaning a valid packet
+                         * with a nonzero length, or an error has been
+                         * indicated. if not, then all we can do is signal
+                         * an error and return no packet received. Most likely
+                         * there is a system design error, or an error in the
+                         * underlying kernel (cache or cache management problem)
+                         */
+                        netdev_err(priv->dev,
+                                   "SGDMA RX Error Info: %x, %x, %x\n",
+                                   sts, desc->status, rxstatus);
+                }
+        } else if (sts == 0) {
                 pktsrx = sgdma_async_read(priv);
         }
 
@@ -270,15 +309,15 @@ u32 sgdma_rx_status(struct altera_tse_private *priv)
 
 
 /* Private functions */
-static void sgdma_descrip(struct sgdma_descrip *desc,
-                          struct sgdma_descrip *ndesc,
-                          dma_addr_t ndesc_phys,
-                          dma_addr_t raddr,
-                          dma_addr_t waddr,
-                          u16 length,
-                          int generate_eop,
-                          int rfixed,
-                          int wfixed)
+static void sgdma_setup_descrip(struct sgdma_descrip *desc,
+                                struct sgdma_descrip *ndesc,
+                                dma_addr_t ndesc_phys,
+                                dma_addr_t raddr,
+                                dma_addr_t waddr,
+                                u16 length,
+                                int generate_eop,
+                                int rfixed,
+                                int wfixed)
 {
         /* Clear the next descriptor as not owned by hardware */
         u32 ctrl = ndesc->control;
@@ -319,35 +358,29 @@ static int sgdma_async_read(struct altera_tse_private *priv)
         struct sgdma_descrip *cdesc = &descbase[0];
         struct sgdma_descrip *ndesc = &descbase[1];
 
-        unsigned int sts = ioread32(&csr->status);
         struct tse_buffer *rxbuffer = NULL;
 
         if (!sgdma_rxbusy(priv)) {
                 rxbuffer = queue_rx_peekhead(priv);
-                if (rxbuffer == NULL)
+                if (rxbuffer == NULL) {
+                        netdev_err(priv->dev, "no rx buffers available\n");
                         return 0;
-
-                sgdma_descrip(cdesc,            /* current descriptor */
-                              ndesc,            /* next descriptor */
-                              sgdma_rxphysaddr(priv, ndesc),
-                              0,                /* read addr 0 for rx dma */
-                              rxbuffer->dma_addr, /* write addr for rx dma */
-                              0,                /* read 'til EOP */
-                              0,                /* EOP: NA for rx dma */
-                              0,                /* read fixed: NA for rx dma */
-                              0);               /* SOP: NA for rx DMA */
-
-                /* clear control and status */
-                iowrite32(0, &csr->control);
-
-                /* If status available, clear those bits */
-                if (sts & 0xf)
-                        iowrite32(0xf, &csr->status);
+                }
+
+                sgdma_setup_descrip(cdesc,              /* current descriptor */
+                                    ndesc,              /* next descriptor */
+                                    sgdma_rxphysaddr(priv, ndesc),
+                                    0,                  /* read addr 0 for rx dma */
+                                    rxbuffer->dma_addr, /* write addr for rx dma */
+                                    0,                  /* read 'til EOP */
+                                    0,                  /* EOP: NA for rx dma */
+                                    0,                  /* read fixed: NA for rx dma */
+                                    0);                 /* SOP: NA for rx DMA */
 
                 dma_sync_single_for_device(priv->device,
                                            priv->rxdescphys,
-                                           priv->rxdescmem,
-                                           DMA_BIDIRECTIONAL);
+                                           priv->sgdmadesclen,
+                                           DMA_TO_DEVICE);
 
                 iowrite32(lower_32_bits(sgdma_rxphysaddr(priv, cdesc)),
                           &csr->next_descrip);
@@ -374,7 +407,7 @@ static int sgdma_async_write(struct altera_tse_private *priv,
         iowrite32(0x1f, &csr->status);
 
         dma_sync_single_for_device(priv->device, priv->txdescphys,
-                                   priv->txdescmem, DMA_TO_DEVICE);
+                                   priv->sgdmadesclen, DMA_TO_DEVICE);
 
         iowrite32(lower_32_bits(sgdma_txphysaddr(priv, desc)),
                   &csr->next_descrip);
diff --git a/drivers/net/ethernet/altera/altera_sgdma.h b/drivers/net/ethernet/altera/altera_sgdma.h
index 07d471729dc4..584977e29ef9 100644
--- a/drivers/net/ethernet/altera/altera_sgdma.h
+++ b/drivers/net/ethernet/altera/altera_sgdma.h
@@ -26,10 +26,11 @@ void sgdma_clear_rxirq(struct altera_tse_private *);
 void sgdma_clear_txirq(struct altera_tse_private *);
 int sgdma_tx_buffer(struct altera_tse_private *priv, struct tse_buffer *);
 u32 sgdma_tx_completions(struct altera_tse_private *);
-int sgdma_add_rx_desc(struct altera_tse_private *priv, struct tse_buffer *);
+void sgdma_add_rx_desc(struct altera_tse_private *priv, struct tse_buffer *);
 void sgdma_status(struct altera_tse_private *);
 u32 sgdma_rx_status(struct altera_tse_private *);
 int sgdma_initialize(struct altera_tse_private *);
 void sgdma_uninitialize(struct altera_tse_private *);
+void sgdma_start_rxdma(struct altera_tse_private *);
 
 #endif /*  __ALTERA_SGDMA_H__ */
diff --git a/drivers/net/ethernet/altera/altera_tse.h b/drivers/net/ethernet/altera/altera_tse.h
index 8feeed05de0e..465c4aabebbd 100644
--- a/drivers/net/ethernet/altera/altera_tse.h
+++ b/drivers/net/ethernet/altera/altera_tse.h
@@ -58,6 +58,8 @@
 /* MAC function configuration default settings */
 #define ALTERA_TSE_TX_IPG_LENGTH        12
 
+#define ALTERA_TSE_PAUSE_QUANTA         0xffff
+
 #define GET_BIT_VALUE(v, bit)           (((v) >> (bit)) & 0x1)
 
 /* MAC Command_Config Register Bit Definitions
@@ -390,10 +392,11 @@ struct altera_dmaops {
         void (*clear_rxirq)(struct altera_tse_private *);
         int (*tx_buffer)(struct altera_tse_private *, struct tse_buffer *);
         u32 (*tx_completions)(struct altera_tse_private *);
-        int (*add_rx_desc)(struct altera_tse_private *, struct tse_buffer *);
+        void (*add_rx_desc)(struct altera_tse_private *, struct tse_buffer *);
         u32 (*get_rx_status)(struct altera_tse_private *);
         int (*init_dma)(struct altera_tse_private *);
         void (*uninit_dma)(struct altera_tse_private *);
+        void (*start_rxdma)(struct altera_tse_private *);
 };
 
 /* This structure is private to each device.
@@ -453,6 +456,7 @@ struct altera_tse_private {
         u32 rxctrlreg;
         dma_addr_t rxdescphys;
         dma_addr_t txdescphys;
+        size_t sgdmadesclen;
 
         struct list_head txlisthd;
         struct list_head rxlisthd;
diff --git a/drivers/net/ethernet/altera/altera_tse_ethtool.c b/drivers/net/ethernet/altera/altera_tse_ethtool.c
index 319ca74f5e74..76133caffa78 100644
--- a/drivers/net/ethernet/altera/altera_tse_ethtool.c
+++ b/drivers/net/ethernet/altera/altera_tse_ethtool.c
@@ -77,7 +77,7 @@ static void tse_get_drvinfo(struct net_device *dev,
         struct altera_tse_private *priv = netdev_priv(dev);
         u32 rev = ioread32(&priv->mac_dev->megacore_revision);
 
-        strcpy(info->driver, "Altera TSE MAC IP Driver");
+        strcpy(info->driver, "altera_tse");
         strcpy(info->version, "v8.0");
         snprintf(info->fw_version, ETHTOOL_FWVERS_LEN, "v%d.%d",
                  rev & 0xFFFF, (rev & 0xFFFF0000) >> 16);
@@ -185,6 +185,12 @@ static void tse_get_regs(struct net_device *dev, struct ethtool_regs *regs,
          * how to do any special formatting of this data.
          * This version number will need to change if and
          * when this register table is changed.
+         *
+         * version[31:0] = 1: Dump the first 128 TSE Registers
+         *      Upper bits are all 0 by default
+         *
+         * Upper 16-bits will indicate feature presence for
+         * Ethtool register decoding in future version.
          */
 
         regs->version = 1;
diff --git a/drivers/net/ethernet/altera/altera_tse_main.c b/drivers/net/ethernet/altera/altera_tse_main.c
index c70a29e0b9f7..e44a4aeb9701 100644
--- a/drivers/net/ethernet/altera/altera_tse_main.c
+++ b/drivers/net/ethernet/altera/altera_tse_main.c
@@ -224,6 +224,7 @@ static int tse_init_rx_buffer(struct altera_tse_private *priv,
                 dev_kfree_skb_any(rxbuffer->skb);
                 return -EINVAL;
         }
+        rxbuffer->dma_addr &= (dma_addr_t)~3;
         rxbuffer->len = len;
         return 0;
 }
@@ -425,9 +426,10 @@ static int tse_rx(struct altera_tse_private *priv, int limit)
                 priv->dev->stats.rx_bytes += pktlength;
 
                 entry = next_entry;
+
+                tse_rx_refill(priv);
         }
 
-        tse_rx_refill(priv);
         return count;
 }
 
@@ -520,7 +522,6 @@ static irqreturn_t altera_isr(int irq, void *dev_id)
         struct altera_tse_private *priv;
         unsigned long int flags;
 
-
         if (unlikely(!dev)) {
                 pr_err("%s: invalid dev pointer\n", __func__);
                 return IRQ_NONE;
@@ -868,13 +869,13 @@ static int init_mac(struct altera_tse_private *priv)
         /* Disable RX/TX shift 16 for alignment of all received frames on 16-bit
          * start address
          */
-        tse_clear_bit(&mac->rx_cmd_stat, ALTERA_TSE_RX_CMD_STAT_RX_SHIFT16);
+        tse_set_bit(&mac->rx_cmd_stat, ALTERA_TSE_RX_CMD_STAT_RX_SHIFT16);
         tse_clear_bit(&mac->tx_cmd_stat, ALTERA_TSE_TX_CMD_STAT_TX_SHIFT16 |
                                          ALTERA_TSE_TX_CMD_STAT_OMIT_CRC);
 
         /* Set the MAC options */
         cmd = ioread32(&mac->command_config);
-        cmd |= MAC_CMDCFG_PAD_EN;       /* Padding Removal on Receive */
+        cmd &= ~MAC_CMDCFG_PAD_EN;      /* No padding Removal on Receive */
         cmd &= ~MAC_CMDCFG_CRC_FWD;     /* CRC Removal */
         cmd |= MAC_CMDCFG_RX_ERR_DISC;  /* Automatically discard frames
                                          * with CRC errors
@@ -882,8 +883,16 @@ static int init_mac(struct altera_tse_private *priv)
         cmd |= MAC_CMDCFG_CNTL_FRM_ENA;
         cmd &= ~MAC_CMDCFG_TX_ENA;
         cmd &= ~MAC_CMDCFG_RX_ENA;
+
+        /* Default speed and duplex setting, full/100 */
+        cmd &= ~MAC_CMDCFG_HD_ENA;
+        cmd &= ~MAC_CMDCFG_ETH_SPEED;
+        cmd &= ~MAC_CMDCFG_ENA_10;
+
         iowrite32(cmd, &mac->command_config);
 
+        iowrite32(ALTERA_TSE_PAUSE_QUANTA, &mac->pause_quanta);
+
         if (netif_msg_hw(priv))
                 dev_dbg(priv->device,
                         "MAC post-initialization: CMD_CONFIG = 0x%08x\n", cmd);
@@ -1085,17 +1094,19 @@ static int tse_open(struct net_device *dev)
 
         spin_unlock_irqrestore(&priv->rxdma_irq_lock, flags);
 
-        /* Start MAC Rx/Tx */
-        spin_lock(&priv->mac_cfg_lock);
-        tse_set_mac(priv, true);
-        spin_unlock(&priv->mac_cfg_lock);
-
         if (priv->phydev)
                 phy_start(priv->phydev);
 
         napi_enable(&priv->napi);
         netif_start_queue(dev);
 
+        priv->dmaops->start_rxdma(priv);
+
+        /* Start MAC Rx/Tx */
+        spin_lock(&priv->mac_cfg_lock);
+        tse_set_mac(priv, true);
+        spin_unlock(&priv->mac_cfg_lock);
+
         return 0;
 
 tx_request_irq_error:
@@ -1167,7 +1178,6 @@ static struct net_device_ops altera_tse_netdev_ops = {
         .ndo_validate_addr      = eth_validate_addr,
 };
 
-
 static int request_and_map(struct platform_device *pdev, const char *name,
                            struct resource **res, void __iomem **ptr)
 {
@@ -1235,7 +1245,7 @@ static int altera_tse_probe(struct platform_device *pdev)
                 /* Get the mapped address to the SGDMA descriptor memory */
                 ret = request_and_map(pdev, "s1", &dma_res, &descmap);
                 if (ret)
-                        goto out_free;
+                        goto err_free_netdev;
 
                 /* Start of that memory is for transmit descriptors */
                 priv->tx_dma_desc = descmap;
@@ -1254,24 +1264,24 @@ static int altera_tse_probe(struct platform_device *pdev)
                 if (upper_32_bits(priv->rxdescmem_busaddr)) {
                         dev_dbg(priv->device,
                                 "SGDMA bus addresses greater than 32-bits\n");
-                        goto out_free;
+                        goto err_free_netdev;
                 }
                 if (upper_32_bits(priv->txdescmem_busaddr)) {
                         dev_dbg(priv->device,
                                 "SGDMA bus addresses greater than 32-bits\n");
-                        goto out_free;
+                        goto err_free_netdev;
                 }
         } else if (priv->dmaops &&
                    priv->dmaops->altera_dtype == ALTERA_DTYPE_MSGDMA) {
                 ret = request_and_map(pdev, "rx_resp", &dma_res,
                                       &priv->rx_dma_resp);
                 if (ret)
-                        goto out_free;
+                        goto err_free_netdev;
 
                 ret = request_and_map(pdev, "tx_desc", &dma_res,
                                       &priv->tx_dma_desc);
                 if (ret)
-                        goto out_free;
+                        goto err_free_netdev;
 
                 priv->txdescmem = resource_size(dma_res);
                 priv->txdescmem_busaddr = dma_res->start;
@@ -1279,13 +1289,13 @@ static int altera_tse_probe(struct platform_device *pdev)
                 ret = request_and_map(pdev, "rx_desc", &dma_res,
                                       &priv->rx_dma_desc);
                 if (ret)
-                        goto out_free;
+                        goto err_free_netdev;
 
                 priv->rxdescmem = resource_size(dma_res);
                 priv->rxdescmem_busaddr = dma_res->start;
 
         } else {
-                goto out_free;
+                goto err_free_netdev;
         }
 
         if (!dma_set_mask(priv->device, DMA_BIT_MASK(priv->dmaops->dmamask)))
@@ -1294,26 +1304,26 @@ static int altera_tse_probe(struct platform_device *pdev)
         else if (!dma_set_mask(priv->device, DMA_BIT_MASK(32)))
                 dma_set_coherent_mask(priv->device, DMA_BIT_MASK(32));
         else
-                goto out_free;
+                goto err_free_netdev;
 
         /* MAC address space */
         ret = request_and_map(pdev, "control_port", &control_port,
                               (void __iomem **)&priv->mac_dev);
         if (ret)
-                goto out_free;
+                goto err_free_netdev;
 
         /* xSGDMA Rx Dispatcher address space */
         ret = request_and_map(pdev, "rx_csr", &dma_res,
                               &priv->rx_dma_csr);
         if (ret)
-                goto out_free;
+                goto err_free_netdev;
 
 
         /* xSGDMA Tx Dispatcher address space */
         ret = request_and_map(pdev, "tx_csr", &dma_res,
                               &priv->tx_dma_csr);
         if (ret)
-                goto out_free;
+                goto err_free_netdev;
 
 
         /* Rx IRQ */
@@ -1321,7 +1331,7 @@ static int altera_tse_probe(struct platform_device *pdev)
         if (priv->rx_irq == -ENXIO) {
                 dev_err(&pdev->dev, "cannot obtain Rx IRQ\n");
                 ret = -ENXIO;
-                goto out_free;
+                goto err_free_netdev;
         }
 
         /* Tx IRQ */
@@ -1329,7 +1339,7 @@ static int altera_tse_probe(struct platform_device *pdev)
         if (priv->tx_irq == -ENXIO) {
                 dev_err(&pdev->dev, "cannot obtain Tx IRQ\n");
                 ret = -ENXIO;
-                goto out_free;
+                goto err_free_netdev;
         }
 
         /* get FIFO depths from device tree */
@@ -1337,14 +1347,14 @@ static int altera_tse_probe(struct platform_device *pdev)
                                  &priv->rx_fifo_depth)) {
                 dev_err(&pdev->dev, "cannot obtain rx-fifo-depth\n");
                 ret = -ENXIO;
-                goto out_free;
+                goto err_free_netdev;
         }
 
         if (of_property_read_u32(pdev->dev.of_node, "tx-fifo-depth",
                                  &priv->rx_fifo_depth)) {
                 dev_err(&pdev->dev, "cannot obtain tx-fifo-depth\n");
                 ret = -ENXIO;
-                goto out_free;
+                goto err_free_netdev;
         }
 
         /* get hash filter settings for this instance */
@@ -1393,7 +1403,7 @@ static int altera_tse_probe(struct platform_device *pdev)
               ((priv->phy_addr >= 0) && (priv->phy_addr < PHY_MAX_ADDR)))) {
                 dev_err(&pdev->dev, "invalid phy-addr specified %d\n",
                         priv->phy_addr);
-                goto out_free;
+                goto err_free_netdev;
         }
 
         /* Create/attach to MDIO bus */
@@ -1401,7 +1411,7 @@ static int altera_tse_probe(struct platform_device *pdev)
                                      atomic_add_return(1, &instance_count));
 
         if (ret)
-                goto out_free;
+                goto err_free_netdev;
 
         /* initialize netdev */
         ether_setup(ndev);
@@ -1438,7 +1448,7 @@ static int altera_tse_probe(struct platform_device *pdev)
         ret = register_netdev(ndev);
         if (ret) {
                 dev_err(&pdev->dev, "failed to register TSE net device\n");
-                goto out_free_mdio;
+                goto err_register_netdev;
         }
 
         platform_set_drvdata(pdev, ndev);
@@ -1455,13 +1465,16 @@ static int altera_tse_probe(struct platform_device *pdev)
         ret = init_phy(ndev);
         if (ret != 0) {
                 netdev_err(ndev, "Cannot attach to PHY (error: %d)\n", ret);
-                goto out_free_mdio;
+                goto err_init_phy;
         }
         return 0;
 
-out_free_mdio:
+err_init_phy:
+        unregister_netdev(ndev);
+err_register_netdev:
+        netif_napi_del(&priv->napi);
         altera_tse_mdio_destroy(ndev);
-out_free:
+err_free_netdev:
         free_netdev(ndev);
         return ret;
 }
@@ -1496,6 +1509,7 @@ struct altera_dmaops altera_dtype_sgdma = {
         .get_rx_status = sgdma_rx_status,
         .init_dma = sgdma_initialize,
         .uninit_dma = sgdma_uninitialize,
+        .start_rxdma = sgdma_start_rxdma,
 };
 
 struct altera_dmaops altera_dtype_msgdma = {
@@ -1514,6 +1528,7 @@ struct altera_dmaops altera_dtype_msgdma = {
         .get_rx_status = msgdma_rx_status,
         .init_dma = msgdma_initialize,
         .uninit_dma = msgdma_uninitialize,
+        .start_rxdma = msgdma_start_rxdma,
 };
 
 static struct of_device_id altera_tse_ids[] = {