7 files changed, 63 insertions, 27 deletions

diff --git a/drivers/net/enic/cq_enet_desc.h b/drivers/net/enic/cq_enet_desc.h
index 03dce9ed612c..337d1943af46 100644
--- a/drivers/net/enic/cq_enet_desc.h
+++ b/drivers/net/enic/cq_enet_desc.h
@@ -101,14 +101,18 @@ static inline void cq_enet_rq_desc_dec(struct cq_enet_rq_desc *desc,
         u8 *tcp_udp_csum_ok, u8 *udp, u8 *tcp, u8 *ipv4_csum_ok,
         u8 *ipv6, u8 *ipv4, u8 *ipv4_fragment, u8 *fcs_ok)
 {
-        u16 completed_index_flags = le16_to_cpu(desc->completed_index_flags);
-        u16 q_number_rss_type_flags =
-                le16_to_cpu(desc->q_number_rss_type_flags);
-        u16 bytes_written_flags = le16_to_cpu(desc->bytes_written_flags);
+        u16 completed_index_flags;
+        u16 q_number_rss_type_flags;
+        u16 bytes_written_flags;
 
         cq_desc_dec((struct cq_desc *)desc, type,
                 color, q_number, completed_index);
 
+        completed_index_flags = le16_to_cpu(desc->completed_index_flags);
+        q_number_rss_type_flags =
+                le16_to_cpu(desc->q_number_rss_type_flags);
+        bytes_written_flags = le16_to_cpu(desc->bytes_written_flags);
+
         *ingress_port = (completed_index_flags &
                 CQ_ENET_RQ_DESC_FLAGS_INGRESS_PORT) ? 1 : 0;
         *fcoe = (completed_index_flags & CQ_ENET_RQ_DESC_FLAGS_FCOE) ?
diff --git a/drivers/net/enic/enic.h b/drivers/net/enic/enic.h
index ee01f5a6d0d4..5fa56f1e5590 100644
--- a/drivers/net/enic/enic.h
+++ b/drivers/net/enic/enic.h
@@ -33,8 +33,8 @@
 #include "vnic_rss.h"
 
 #define DRV_NAME                "enic"
-#define DRV_DESCRIPTION         "Cisco 10G Ethernet Driver"
-#define DRV_VERSION             "1.1.0.241a"
+#define DRV_DESCRIPTION         "Cisco VIC Ethernet NIC Driver"
+#define DRV_VERSION             "1.3.1.1"
 #define DRV_COPYRIGHT           "Copyright 2008-2009 Cisco Systems, Inc"
 #define PFX                     DRV_NAME ": "
 
diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c
index cf098bb636b8..1232887c243d 100644
--- a/drivers/net/enic/enic_main.c
+++ b/drivers/net/enic/enic_main.c
@@ -822,14 +822,14 @@ static int enic_set_mac_addr(struct net_device *netdev, char *addr)
 static void enic_set_multicast_list(struct net_device *netdev)
 {
         struct enic *enic = netdev_priv(netdev);
-        struct dev_mc_list *list;
+        struct netdev_hw_addr *ha;
         int directed = 1;
         int multicast = (netdev->flags & IFF_MULTICAST) ? 1 : 0;
         int broadcast = (netdev->flags & IFF_BROADCAST) ? 1 : 0;
         int promisc = (netdev->flags & IFF_PROMISC) ? 1 : 0;
         unsigned int mc_count = netdev_mc_count(netdev);
         int allmulti = (netdev->flags & IFF_ALLMULTI) ||
-                       mc_count > ENIC_MULTICAST_PERFECT_FILTERS;
+                mc_count > ENIC_MULTICAST_PERFECT_FILTERS;
         unsigned int flags = netdev->flags | (allmulti ? IFF_ALLMULTI : 0);
         u8 mc_addr[ENIC_MULTICAST_PERFECT_FILTERS][ETH_ALEN];
         unsigned int i, j;
@@ -852,10 +852,10 @@ static void enic_set_multicast_list(struct net_device *netdev)
          */
 
         i = 0;
-        netdev_for_each_mc_addr(list, netdev) {
+        netdev_for_each_mc_addr(ha, netdev) {
                 if (i == mc_count)
                         break;
-                memcpy(mc_addr[i++], list->dmi_addr, ETH_ALEN);
+                memcpy(mc_addr[i++], ha->addr, ETH_ALEN);
         }
 
         for (i = 0; i < enic->mc_count; i++) {
@@ -2058,8 +2058,7 @@ static int __devinit enic_probe(struct pci_dev *pdev,
         netdev->watchdog_timeo = 2 * HZ;
         netdev->ethtool_ops = &enic_ethtool_ops;
 
-        netdev->features |= NETIF_F_HW_VLAN_TX |
-                NETIF_F_HW_VLAN_RX | NETIF_F_HW_VLAN_FILTER;
+        netdev->features |= NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX;
         if (ENIC_SETTING(enic, TXCSUM))
                 netdev->features |= NETIF_F_SG | NETIF_F_HW_CSUM;
         if (ENIC_SETTING(enic, TSO))
diff --git a/drivers/net/enic/vnic_dev.c b/drivers/net/enic/vnic_dev.c
index cf22de71014e..d43a9d43bbff 100644
--- a/drivers/net/enic/vnic_dev.c
+++ b/drivers/net/enic/vnic_dev.c
@@ -574,22 +574,18 @@ int vnic_dev_raise_intr(struct vnic_dev *vdev, u16 intr)
         return err;
 }
 
-int vnic_dev_notify_set(struct vnic_dev *vdev, u16 intr)
+int vnic_dev_notify_setcmd(struct vnic_dev *vdev,
+        void *notify_addr, dma_addr_t notify_pa, u16 intr)
 {
         u64 a0, a1;
         int wait = 1000;
         int r;
 
-        if (!vdev->notify) {
-                vdev->notify = pci_alloc_consistent(vdev->pdev,
-                        sizeof(struct vnic_devcmd_notify),
-                        &vdev->notify_pa);
-                if (!vdev->notify)
-                        return -ENOMEM;
-                memset(vdev->notify, 0, sizeof(struct vnic_devcmd_notify));
-        }
+        memset(notify_addr, 0, sizeof(struct vnic_devcmd_notify));
+        vdev->notify = notify_addr;
+        vdev->notify_pa = notify_pa;
 
-        a0 = vdev->notify_pa;
+        a0 = (u64)notify_pa;
         a1 = ((u64)intr << 32) & 0x0000ffff00000000ULL;
         a1 += sizeof(struct vnic_devcmd_notify);
 
@@ -598,7 +594,27 @@ int vnic_dev_notify_set(struct vnic_dev *vdev, u16 intr)
         return r;
 }
 
-void vnic_dev_notify_unset(struct vnic_dev *vdev)
+int vnic_dev_notify_set(struct vnic_dev *vdev, u16 intr)
+{
+        void *notify_addr;
+        dma_addr_t notify_pa;
+
+        if (vdev->notify || vdev->notify_pa) {
+                printk(KERN_ERR "notify block %p still allocated",
+                        vdev->notify);
+                return -EINVAL;
+        }
+
+        notify_addr = pci_alloc_consistent(vdev->pdev,
+                        sizeof(struct vnic_devcmd_notify),
+                        &notify_pa);
+        if (!notify_addr)
+                return -ENOMEM;
+
+        return vnic_dev_notify_setcmd(vdev, notify_addr, notify_pa, intr);
+}
+
+void vnic_dev_notify_unsetcmd(struct vnic_dev *vdev)
 {
         u64 a0, a1;
         int wait = 1000;
@@ -608,9 +624,23 @@ void vnic_dev_notify_unset(struct vnic_dev *vdev)
         a1 += sizeof(struct vnic_devcmd_notify);
 
         vnic_dev_cmd(vdev, CMD_NOTIFY, &a0, &a1, wait);
+        vdev->notify = NULL;
+        vdev->notify_pa = 0;
         vdev->notify_sz = 0;
 }
 
+void vnic_dev_notify_unset(struct vnic_dev *vdev)
+{
+        if (vdev->notify) {
+                pci_free_consistent(vdev->pdev,
+                        sizeof(struct vnic_devcmd_notify),
+                        vdev->notify,
+                        vdev->notify_pa);
+        }
+
+        vnic_dev_notify_unsetcmd(vdev);
+}
+
 static int vnic_dev_notify_ready(struct vnic_dev *vdev)
 {
         u32 *words;
diff --git a/drivers/net/enic/vnic_dev.h b/drivers/net/enic/vnic_dev.h
index fc5e3eb35a5e..f5be640b0b5c 100644
--- a/drivers/net/enic/vnic_dev.h
+++ b/drivers/net/enic/vnic_dev.h
@@ -107,7 +107,10 @@ void vnic_dev_add_addr(struct vnic_dev *vdev, u8 *addr);
 void vnic_dev_del_addr(struct vnic_dev *vdev, u8 *addr);
 int vnic_dev_mac_addr(struct vnic_dev *vdev, u8 *mac_addr);
 int vnic_dev_raise_intr(struct vnic_dev *vdev, u16 intr);
+int vnic_dev_notify_setcmd(struct vnic_dev *vdev,
+        void *notify_addr, dma_addr_t notify_pa, u16 intr);
 int vnic_dev_notify_set(struct vnic_dev *vdev, u16 intr);
+void vnic_dev_notify_unsetcmd(struct vnic_dev *vdev);
 void vnic_dev_notify_unset(struct vnic_dev *vdev);
 int vnic_dev_link_status(struct vnic_dev *vdev);
 u32 vnic_dev_port_speed(struct vnic_dev *vdev);
diff --git a/drivers/net/enic/vnic_rq.c b/drivers/net/enic/vnic_rq.c
index e186efaf9da1..cc580cfec41d 100644
--- a/drivers/net/enic/vnic_rq.c
+++ b/drivers/net/enic/vnic_rq.c
@@ -168,10 +168,10 @@ int vnic_rq_disable(struct vnic_rq *rq)
         iowrite32(0, &rq->ctrl->enable);
 
         /* Wait for HW to ACK disable request */
-        for (wait = 0; wait < 100; wait++) {
+        for (wait = 0; wait < 1000; wait++) {
                 if (!(ioread32(&rq->ctrl->running)))
                         return 0;
-                udelay(1);
+                udelay(10);
         }
 
         printk(KERN_ERR "Failed to disable RQ[%d]\n", rq->index);
diff --git a/drivers/net/enic/vnic_wq.c b/drivers/net/enic/vnic_wq.c
index d5f984357f5c..1378afbdfe67 100644
--- a/drivers/net/enic/vnic_wq.c
+++ b/drivers/net/enic/vnic_wq.c
@@ -161,10 +161,10 @@ int vnic_wq_disable(struct vnic_wq *wq)
         iowrite32(0, &wq->ctrl->enable);
 
         /* Wait for HW to ACK disable request */
-        for (wait = 0; wait < 100; wait++) {
+        for (wait = 0; wait < 1000; wait++) {
                 if (!(ioread32(&wq->ctrl->running)))
                         return 0;
-                udelay(1);
+                udelay(10);
         }
 
         printk(KERN_ERR "Failed to disable WQ[%d]\n", wq->index);