diff options
Diffstat (limited to 'drivers/net/e1000/e1000_ethtool.c')
-rw-r--r-- | drivers/net/e1000/e1000_ethtool.c | 26 |
1 files changed, 12 insertions, 14 deletions
diff --git a/drivers/net/e1000/e1000_ethtool.c b/drivers/net/e1000/e1000_ethtool.c index a094288f0277..2881da1c6fe3 100644 --- a/drivers/net/e1000/e1000_ethtool.c +++ b/drivers/net/e1000/e1000_ethtool.c | |||
@@ -654,14 +654,11 @@ e1000_set_ringparam(struct net_device *netdev, | |||
654 | e1000_mac_type mac_type = adapter->hw.mac_type; | 654 | e1000_mac_type mac_type = adapter->hw.mac_type; |
655 | struct e1000_tx_ring *txdr, *tx_old; | 655 | struct e1000_tx_ring *txdr, *tx_old; |
656 | struct e1000_rx_ring *rxdr, *rx_old; | 656 | struct e1000_rx_ring *rxdr, *rx_old; |
657 | int i, err, tx_ring_size, rx_ring_size; | 657 | int i, err; |
658 | 658 | ||
659 | if ((ring->rx_mini_pending) || (ring->rx_jumbo_pending)) | 659 | if ((ring->rx_mini_pending) || (ring->rx_jumbo_pending)) |
660 | return -EINVAL; | 660 | return -EINVAL; |
661 | 661 | ||
662 | tx_ring_size = sizeof(struct e1000_tx_ring) * adapter->num_tx_queues; | ||
663 | rx_ring_size = sizeof(struct e1000_rx_ring) * adapter->num_rx_queues; | ||
664 | |||
665 | while (test_and_set_bit(__E1000_RESETTING, &adapter->flags)) | 662 | while (test_and_set_bit(__E1000_RESETTING, &adapter->flags)) |
666 | msleep(1); | 663 | msleep(1); |
667 | 664 | ||
@@ -672,11 +669,11 @@ e1000_set_ringparam(struct net_device *netdev, | |||
672 | rx_old = adapter->rx_ring; | 669 | rx_old = adapter->rx_ring; |
673 | 670 | ||
674 | err = -ENOMEM; | 671 | err = -ENOMEM; |
675 | txdr = kzalloc(tx_ring_size, GFP_KERNEL); | 672 | txdr = kcalloc(adapter->num_tx_queues, sizeof(struct e1000_tx_ring), GFP_KERNEL); |
676 | if (!txdr) | 673 | if (!txdr) |
677 | goto err_alloc_tx; | 674 | goto err_alloc_tx; |
678 | 675 | ||
679 | rxdr = kzalloc(rx_ring_size, GFP_KERNEL); | 676 | rxdr = kcalloc(adapter->num_rx_queues, sizeof(struct e1000_rx_ring), GFP_KERNEL); |
680 | if (!rxdr) | 677 | if (!rxdr) |
681 | goto err_alloc_rx; | 678 | goto err_alloc_rx; |
682 | 679 | ||
@@ -1053,23 +1050,24 @@ e1000_setup_desc_rings(struct e1000_adapter *adapter) | |||
1053 | struct e1000_rx_ring *rxdr = &adapter->test_rx_ring; | 1050 | struct e1000_rx_ring *rxdr = &adapter->test_rx_ring; |
1054 | struct pci_dev *pdev = adapter->pdev; | 1051 | struct pci_dev *pdev = adapter->pdev; |
1055 | uint32_t rctl; | 1052 | uint32_t rctl; |
1056 | int size, i, ret_val; | 1053 | int i, ret_val; |
1057 | 1054 | ||
1058 | /* Setup Tx descriptor ring and Tx buffers */ | 1055 | /* Setup Tx descriptor ring and Tx buffers */ |
1059 | 1056 | ||
1060 | if (!txdr->count) | 1057 | if (!txdr->count) |
1061 | txdr->count = E1000_DEFAULT_TXD; | 1058 | txdr->count = E1000_DEFAULT_TXD; |
1062 | 1059 | ||
1063 | size = txdr->count * sizeof(struct e1000_buffer); | 1060 | if (!(txdr->buffer_info = kcalloc(txdr->count, |
1064 | if (!(txdr->buffer_info = kmalloc(size, GFP_KERNEL))) { | 1061 | sizeof(struct e1000_buffer), |
1062 | GFP_KERNEL))) { | ||
1065 | ret_val = 1; | 1063 | ret_val = 1; |
1066 | goto err_nomem; | 1064 | goto err_nomem; |
1067 | } | 1065 | } |
1068 | memset(txdr->buffer_info, 0, size); | ||
1069 | 1066 | ||
1070 | txdr->size = txdr->count * sizeof(struct e1000_tx_desc); | 1067 | txdr->size = txdr->count * sizeof(struct e1000_tx_desc); |
1071 | E1000_ROUNDUP(txdr->size, 4096); | 1068 | E1000_ROUNDUP(txdr->size, 4096); |
1072 | if (!(txdr->desc = pci_alloc_consistent(pdev, txdr->size, &txdr->dma))) { | 1069 | if (!(txdr->desc = pci_alloc_consistent(pdev, txdr->size, |
1070 | &txdr->dma))) { | ||
1073 | ret_val = 2; | 1071 | ret_val = 2; |
1074 | goto err_nomem; | 1072 | goto err_nomem; |
1075 | } | 1073 | } |
@@ -1116,12 +1114,12 @@ e1000_setup_desc_rings(struct e1000_adapter *adapter) | |||
1116 | if (!rxdr->count) | 1114 | if (!rxdr->count) |
1117 | rxdr->count = E1000_DEFAULT_RXD; | 1115 | rxdr->count = E1000_DEFAULT_RXD; |
1118 | 1116 | ||
1119 | size = rxdr->count * sizeof(struct e1000_buffer); | 1117 | if (!(rxdr->buffer_info = kcalloc(rxdr->count, |
1120 | if (!(rxdr->buffer_info = kmalloc(size, GFP_KERNEL))) { | 1118 | sizeof(struct e1000_buffer), |
1119 | GFP_KERNEL))) { | ||
1121 | ret_val = 4; | 1120 | ret_val = 4; |
1122 | goto err_nomem; | 1121 | goto err_nomem; |
1123 | } | 1122 | } |
1124 | memset(rxdr->buffer_info, 0, size); | ||
1125 | 1123 | ||
1126 | rxdr->size = rxdr->count * sizeof(struct e1000_rx_desc); | 1124 | rxdr->size = rxdr->count * sizeof(struct e1000_rx_desc); |
1127 | if (!(rxdr->desc = pci_alloc_consistent(pdev, rxdr->size, &rxdr->dma))) { | 1125 | if (!(rxdr->desc = pci_alloc_consistent(pdev, rxdr->size, &rxdr->dma))) { |