diff options
Diffstat (limited to 'drivers/net/dummy.c')
-rw-r--r-- | drivers/net/dummy.c | 57 |
1 files changed, 3 insertions, 54 deletions
diff --git a/drivers/net/dummy.c b/drivers/net/dummy.c index 91126b9ce453..373ff700404f 100644 --- a/drivers/net/dummy.c +++ b/drivers/net/dummy.c | |||
@@ -37,11 +37,6 @@ | |||
37 | #include <linux/rtnetlink.h> | 37 | #include <linux/rtnetlink.h> |
38 | #include <net/rtnetlink.h> | 38 | #include <net/rtnetlink.h> |
39 | 39 | ||
40 | struct dummy_priv { | ||
41 | struct net_device *dev; | ||
42 | struct list_head list; | ||
43 | }; | ||
44 | |||
45 | static int numdummies = 1; | 40 | static int numdummies = 1; |
46 | 41 | ||
47 | static int dummy_xmit(struct sk_buff *skb, struct net_device *dev); | 42 | static int dummy_xmit(struct sk_buff *skb, struct net_device *dev); |
@@ -89,37 +84,9 @@ static int dummy_xmit(struct sk_buff *skb, struct net_device *dev) | |||
89 | return 0; | 84 | return 0; |
90 | } | 85 | } |
91 | 86 | ||
92 | static LIST_HEAD(dummies); | ||
93 | |||
94 | static int dummy_newlink(struct net_device *dev, | ||
95 | struct nlattr *tb[], struct nlattr *data[]) | ||
96 | { | ||
97 | struct dummy_priv *priv = netdev_priv(dev); | ||
98 | int err; | ||
99 | |||
100 | err = register_netdevice(dev); | ||
101 | if (err < 0) | ||
102 | return err; | ||
103 | |||
104 | priv->dev = dev; | ||
105 | list_add_tail(&priv->list, &dummies); | ||
106 | return 0; | ||
107 | } | ||
108 | |||
109 | static void dummy_dellink(struct net_device *dev) | ||
110 | { | ||
111 | struct dummy_priv *priv = netdev_priv(dev); | ||
112 | |||
113 | list_del(&priv->list); | ||
114 | unregister_netdevice(dev); | ||
115 | } | ||
116 | |||
117 | static struct rtnl_link_ops dummy_link_ops __read_mostly = { | 87 | static struct rtnl_link_ops dummy_link_ops __read_mostly = { |
118 | .kind = "dummy", | 88 | .kind = "dummy", |
119 | .priv_size = sizeof(struct dummy_priv), | ||
120 | .setup = dummy_setup, | 89 | .setup = dummy_setup, |
121 | .newlink = dummy_newlink, | ||
122 | .dellink = dummy_dellink, | ||
123 | }; | 90 | }; |
124 | 91 | ||
125 | /* Number of dummy devices to be set up by this module. */ | 92 | /* Number of dummy devices to be set up by this module. */ |
@@ -129,12 +96,9 @@ MODULE_PARM_DESC(numdummies, "Number of dummy pseudo devices"); | |||
129 | static int __init dummy_init_one(void) | 96 | static int __init dummy_init_one(void) |
130 | { | 97 | { |
131 | struct net_device *dev_dummy; | 98 | struct net_device *dev_dummy; |
132 | struct dummy_priv *priv; | ||
133 | int err; | 99 | int err; |
134 | 100 | ||
135 | dev_dummy = alloc_netdev(sizeof(struct dummy_priv), "dummy%d", | 101 | dev_dummy = alloc_netdev(0, "dummy%d", dummy_setup); |
136 | dummy_setup); | ||
137 | |||
138 | if (!dev_dummy) | 102 | if (!dev_dummy) |
139 | return -ENOMEM; | 103 | return -ENOMEM; |
140 | 104 | ||
@@ -146,10 +110,6 @@ static int __init dummy_init_one(void) | |||
146 | err = register_netdevice(dev_dummy); | 110 | err = register_netdevice(dev_dummy); |
147 | if (err < 0) | 111 | if (err < 0) |
148 | goto err; | 112 | goto err; |
149 | |||
150 | priv = netdev_priv(dev_dummy); | ||
151 | priv->dev = dev_dummy; | ||
152 | list_add_tail(&priv->list, &dummies); | ||
153 | return 0; | 113 | return 0; |
154 | 114 | ||
155 | err: | 115 | err: |
@@ -159,7 +119,6 @@ err: | |||
159 | 119 | ||
160 | static int __init dummy_init_module(void) | 120 | static int __init dummy_init_module(void) |
161 | { | 121 | { |
162 | struct dummy_priv *priv, *next; | ||
163 | int i, err = 0; | 122 | int i, err = 0; |
164 | 123 | ||
165 | rtnl_lock(); | 124 | rtnl_lock(); |
@@ -167,11 +126,8 @@ static int __init dummy_init_module(void) | |||
167 | 126 | ||
168 | for (i = 0; i < numdummies && !err; i++) | 127 | for (i = 0; i < numdummies && !err; i++) |
169 | err = dummy_init_one(); | 128 | err = dummy_init_one(); |
170 | if (err < 0) { | 129 | if (err < 0) |
171 | list_for_each_entry_safe(priv, next, &dummies, list) | ||
172 | dummy_dellink(priv->dev); | ||
173 | __rtnl_link_unregister(&dummy_link_ops); | 130 | __rtnl_link_unregister(&dummy_link_ops); |
174 | } | ||
175 | rtnl_unlock(); | 131 | rtnl_unlock(); |
176 | 132 | ||
177 | return err; | 133 | return err; |
@@ -179,14 +135,7 @@ static int __init dummy_init_module(void) | |||
179 | 135 | ||
180 | static void __exit dummy_cleanup_module(void) | 136 | static void __exit dummy_cleanup_module(void) |
181 | { | 137 | { |
182 | struct dummy_priv *priv, *next; | 138 | rtnl_link_unregister(&dummy_link_ops); |
183 | |||
184 | rtnl_lock(); | ||
185 | list_for_each_entry_safe(priv, next, &dummies, list) | ||
186 | dummy_dellink(priv->dev); | ||
187 | |||
188 | __rtnl_link_unregister(&dummy_link_ops); | ||
189 | rtnl_unlock(); | ||
190 | } | 139 | } |
191 | 140 | ||
192 | module_init(dummy_init_module); | 141 | module_init(dummy_init_module); |