1 files changed, 78 insertions, 89 deletions

diff --git a/drivers/net/8139cp.c b/drivers/net/8139cp.c
index 0cdc830449d8..5a4990ae3730 100644
--- a/drivers/net/8139cp.c
+++ b/drivers/net/8139cp.c
@@ -48,11 +48,10 @@
  */
 
 #define DRV_NAME                "8139cp"
-#define DRV_VERSION             "1.2"
+#define DRV_VERSION             "1.3"
 #define DRV_RELDATE             "Mar 22, 2004"
 
 
-#include <linux/config.h>
 #include <linux/module.h>
 #include <linux/moduleparam.h>
 #include <linux/kernel.h>
@@ -315,12 +314,6 @@ struct cp_desc {
         u64             addr;
 };
 
-struct ring_info {
-        struct sk_buff          *skb;
-        dma_addr_t              mapping;
-        u32                     len;
-};
-
 struct cp_dma_stats {
         u64                     tx_ok;
         u64                     rx_ok;
@@ -354,23 +347,23 @@ struct cp_private {
         struct net_device_stats net_stats;
         struct cp_extra_stats   cp_stats;
 
-        unsigned                rx_tail         ____cacheline_aligned;
+        unsigned                rx_head         ____cacheline_aligned;
+        unsigned                rx_tail;
         struct cp_desc          *rx_ring;
-        struct ring_info        rx_skb[CP_RX_RING_SIZE];
-        unsigned                rx_buf_sz;
+        struct sk_buff          *rx_skb[CP_RX_RING_SIZE];
 
         unsigned                tx_head         ____cacheline_aligned;
         unsigned                tx_tail;
-
         struct cp_desc          *tx_ring;
-        struct ring_info        tx_skb[CP_TX_RING_SIZE];
-        dma_addr_t              ring_dma;
+        struct sk_buff          *tx_skb[CP_TX_RING_SIZE];
+
+        unsigned                rx_buf_sz;
+        unsigned                wol_enabled : 1; /* Is Wake-on-LAN enabled? */
 
 #if CP_VLAN_TAG_USED
         struct vlan_group       *vlgrp;
 #endif
-
-        unsigned int            wol_enabled : 1; /* Is Wake-on-LAN enabled? */
+        dma_addr_t              ring_dma;
 
         struct mii_if_info      mii_if;
 };
@@ -408,10 +401,8 @@ static int cp_set_eeprom(struct net_device *dev,
                          struct ethtool_eeprom *eeprom, u8 *data);
 
 static struct pci_device_id cp_pci_tbl[] = {
-        { PCI_VENDOR_ID_REALTEK, PCI_DEVICE_ID_REALTEK_8139,
-          PCI_ANY_ID, PCI_ANY_ID, 0, 0, },
-        { PCI_VENDOR_ID_TTTECH, PCI_DEVICE_ID_TTTECH_MC322,
-          PCI_ANY_ID, PCI_ANY_ID, 0, 0, },
+        { PCI_DEVICE(PCI_VENDOR_ID_REALTEK,     PCI_DEVICE_ID_REALTEK_8139), },
+        { PCI_DEVICE(PCI_VENDOR_ID_TTTECH,      PCI_DEVICE_ID_TTTECH_MC322), },
         { },
 };
 MODULE_DEVICE_TABLE(pci, cp_pci_tbl);
@@ -543,7 +534,7 @@ rx_status_loop:
                 struct cp_desc *desc;
                 unsigned buflen;
 
-                skb = cp->rx_skb[rx_tail].skb;
+                skb = cp->rx_skb[rx_tail];
                 BUG_ON(!skb);
 
                 desc = &cp->rx_ring[rx_tail];
@@ -552,7 +543,7 @@ rx_status_loop:
                         break;
 
                 len = (status & 0x1fff) - 4;
-                mapping = cp->rx_skb[rx_tail].mapping;
+                mapping = le64_to_cpu(desc->addr);
 
                 if ((status & (FirstFrag | LastFrag)) != (FirstFrag | LastFrag)) {
                         /* we don't support incoming fragmented frames.
@@ -573,7 +564,7 @@ rx_status_loop:
 
                 if (netif_msg_rx_status(cp))
                         printk(KERN_DEBUG "%s: rx slot %d status 0x%x len %d\n",
-                               cp->dev->name, rx_tail, status, len);
+                               dev->name, rx_tail, status, len);
 
                 buflen = cp->rx_buf_sz + RX_OFFSET;
                 new_skb = dev_alloc_skb (buflen);
@@ -583,7 +574,7 @@ rx_status_loop:
                 }
 
                 skb_reserve(new_skb, RX_OFFSET);
-                new_skb->dev = cp->dev;
+                new_skb->dev = dev;
 
                 pci_unmap_single(cp->pdev, mapping,
                                  buflen, PCI_DMA_FROMDEVICE);
@@ -596,11 +587,9 @@ rx_status_loop:
 
                 skb_put(skb, len);
 
-                mapping =
-                cp->rx_skb[rx_tail].mapping =
-                        pci_map_single(cp->pdev, new_skb->data,
-                                       buflen, PCI_DMA_FROMDEVICE);
-                cp->rx_skb[rx_tail].skb = new_skb;
+                mapping = pci_map_single(cp->pdev, new_skb->data, buflen,
+                                         PCI_DMA_FROMDEVICE);
+                cp->rx_skb[rx_tail] = new_skb;
 
                 cp_rx_skb(cp, skb, desc);
                 rx++;
@@ -718,19 +707,21 @@ static void cp_tx (struct cp_private *cp)
         unsigned tx_tail = cp->tx_tail;
 
         while (tx_tail != tx_head) {
+                struct cp_desc *txd = cp->tx_ring + tx_tail;
                 struct sk_buff *skb;
                 u32 status;
 
                 rmb();
-                status = le32_to_cpu(cp->tx_ring[tx_tail].opts1);
+                status = le32_to_cpu(txd->opts1);
                 if (status & DescOwn)
                         break;
 
-                skb = cp->tx_skb[tx_tail].skb;
+                skb = cp->tx_skb[tx_tail];
                 BUG_ON(!skb);
 
-                pci_unmap_single(cp->pdev, cp->tx_skb[tx_tail].mapping,
-                                 cp->tx_skb[tx_tail].len, PCI_DMA_TODEVICE);
+                pci_unmap_single(cp->pdev, le64_to_cpu(txd->addr),
+                                 le32_to_cpu(txd->opts1) & 0xffff,
+                                 PCI_DMA_TODEVICE);
 
                 if (status & LastFrag) {
                         if (status & (TxError | TxFIFOUnder)) {
@@ -757,7 +748,7 @@ static void cp_tx (struct cp_private *cp)
                         dev_kfree_skb_irq(skb);
                 }
 
-                cp->tx_skb[tx_tail].skb = NULL;
+                cp->tx_skb[tx_tail] = NULL;
 
                 tx_tail = NEXT_TX(tx_tail);
         }
@@ -814,7 +805,7 @@ static int cp_start_xmit (struct sk_buff *skb, struct net_device *dev)
 
                 if (mss)
                         flags |= LargeSend | ((mss & MSSMask) << MSSShift);
-                else if (skb->ip_summed == CHECKSUM_HW) {
+                else if (skb->ip_summed == CHECKSUM_PARTIAL) {
                         const struct iphdr *ip = skb->nh.iph;
                         if (ip->protocol == IPPROTO_TCP)
                                 flags |= IPCS | TCPCS;
@@ -827,9 +818,7 @@ static int cp_start_xmit (struct sk_buff *skb, struct net_device *dev)
                 txd->opts1 = cpu_to_le32(flags);
                 wmb();
 
-                cp->tx_skb[entry].skb = skb;
-                cp->tx_skb[entry].mapping = mapping;
-                cp->tx_skb[entry].len = len;
+                cp->tx_skb[entry] = skb;
                 entry = NEXT_TX(entry);
         } else {
                 struct cp_desc *txd;
@@ -845,9 +834,7 @@ static int cp_start_xmit (struct sk_buff *skb, struct net_device *dev)
                 first_len = skb_headlen(skb);
                 first_mapping = pci_map_single(cp->pdev, skb->data,
                                                first_len, PCI_DMA_TODEVICE);
-                cp->tx_skb[entry].skb = skb;
-                cp->tx_skb[entry].mapping = first_mapping;
-                cp->tx_skb[entry].len = first_len;
+                cp->tx_skb[entry] = skb;
                 entry = NEXT_TX(entry);
 
                 for (frag = 0; frag < skb_shinfo(skb)->nr_frags; frag++) {
@@ -868,7 +855,7 @@ static int cp_start_xmit (struct sk_buff *skb, struct net_device *dev)
                         if (mss)
                                 ctrl |= LargeSend |
                                         ((mss & MSSMask) << MSSShift);
-                        else if (skb->ip_summed == CHECKSUM_HW) {
+                        else if (skb->ip_summed == CHECKSUM_PARTIAL) {
                                 if (ip->protocol == IPPROTO_TCP)
                                         ctrl |= IPCS | TCPCS;
                                 else if (ip->protocol == IPPROTO_UDP)
@@ -888,9 +875,7 @@ static int cp_start_xmit (struct sk_buff *skb, struct net_device *dev)
                         txd->opts1 = cpu_to_le32(ctrl);
                         wmb();
 
-                        cp->tx_skb[entry].skb = skb;
-                        cp->tx_skb[entry].mapping = mapping;
-                        cp->tx_skb[entry].len = len;
+                        cp->tx_skb[entry] = skb;
                         entry = NEXT_TX(entry);
                 }
 
@@ -899,7 +884,7 @@ static int cp_start_xmit (struct sk_buff *skb, struct net_device *dev)
                 txd->addr = cpu_to_le64(first_mapping);
                 wmb();
 
-                if (skb->ip_summed == CHECKSUM_HW) {
+                if (skb->ip_summed == CHECKSUM_PARTIAL) {
                         if (ip->protocol == IPPROTO_TCP)
                                 txd->opts1 = cpu_to_le32(first_eor | first_len |
                                                          FirstFrag | DescOwn |
@@ -943,8 +928,6 @@ static void __cp_set_rx_mode (struct net_device *dev)
         /* Note: do not reorder, GCC is clever about common statements. */
         if (dev->flags & IFF_PROMISC) {
                 /* Unconditionally log net taps. */
-                printk (KERN_NOTICE "%s: Promiscuous mode enabled.\n",
-                        dev->name);
                 rx_mode =
                     AcceptBroadcast | AcceptMulticast | AcceptMyPhys |
                     AcceptAllPhys;
@@ -1092,6 +1075,7 @@ static int cp_refill_rx (struct cp_private *cp)
 
         for (i = 0; i < CP_RX_RING_SIZE; i++) {
                 struct sk_buff *skb;
+                dma_addr_t mapping;
 
                 skb = dev_alloc_skb(cp->rx_buf_sz + RX_OFFSET);
                 if (!skb)
@@ -1100,12 +1084,12 @@ static int cp_refill_rx (struct cp_private *cp)
                 skb->dev = cp->dev;
                 skb_reserve(skb, RX_OFFSET);
 
-                cp->rx_skb[i].mapping = pci_map_single(cp->pdev,
-                        skb->data, cp->rx_buf_sz, PCI_DMA_FROMDEVICE);
-                cp->rx_skb[i].skb = skb;
+                mapping = pci_map_single(cp->pdev, skb->data, cp->rx_buf_sz,
+                                         PCI_DMA_FROMDEVICE);
+                cp->rx_skb[i] = skb;
 
                 cp->rx_ring[i].opts2 = 0;
-                cp->rx_ring[i].addr = cpu_to_le64(cp->rx_skb[i].mapping);
+                cp->rx_ring[i].addr = cpu_to_le64(mapping);
                 if (i == (CP_RX_RING_SIZE - 1))
                         cp->rx_ring[i].opts1 =
                                 cpu_to_le32(DescOwn | RingEnd | cp->rx_buf_sz);
@@ -1153,23 +1137,27 @@ static int cp_alloc_rings (struct cp_private *cp)
 
 static void cp_clean_rings (struct cp_private *cp)
 {
+        struct cp_desc *desc;
         unsigned i;
 
         for (i = 0; i < CP_RX_RING_SIZE; i++) {
-                if (cp->rx_skb[i].skb) {
-                        pci_unmap_single(cp->pdev, cp->rx_skb[i].mapping,
+                if (cp->rx_skb[i]) {
+                        desc = cp->rx_ring + i;
+                        pci_unmap_single(cp->pdev, le64_to_cpu(desc->addr),
                                          cp->rx_buf_sz, PCI_DMA_FROMDEVICE);
-                        dev_kfree_skb(cp->rx_skb[i].skb);
+                        dev_kfree_skb(cp->rx_skb[i]);
                 }
         }
 
         for (i = 0; i < CP_TX_RING_SIZE; i++) {
-                if (cp->tx_skb[i].skb) {
-                        struct sk_buff *skb = cp->tx_skb[i].skb;
-
-                        pci_unmap_single(cp->pdev, cp->tx_skb[i].mapping,
-                                         cp->tx_skb[i].len, PCI_DMA_TODEVICE);
-                        if (le32_to_cpu(cp->tx_ring[i].opts1) & LastFrag)
+                if (cp->tx_skb[i]) {
+                        struct sk_buff *skb = cp->tx_skb[i];
+
+                        desc = cp->tx_ring + i;
+                        pci_unmap_single(cp->pdev, le64_to_cpu(desc->addr),
+                                         le32_to_cpu(desc->opts1) & 0xffff,
+                                         PCI_DMA_TODEVICE);
+                        if (le32_to_cpu(desc->opts1) & LastFrag)
                                 dev_kfree_skb(skb);
                         cp->net_stats.tx_dropped++;
                 }
@@ -1178,8 +1166,8 @@ static void cp_clean_rings (struct cp_private *cp)
         memset(cp->rx_ring, 0, sizeof(struct cp_desc) * CP_RX_RING_SIZE);
         memset(cp->tx_ring, 0, sizeof(struct cp_desc) * CP_TX_RING_SIZE);
 
-        memset(&cp->rx_skb, 0, sizeof(struct ring_info) * CP_RX_RING_SIZE);
-        memset(&cp->tx_skb, 0, sizeof(struct ring_info) * CP_TX_RING_SIZE);
+        memset(cp->rx_skb, 0, sizeof(struct sk_buff *) * CP_RX_RING_SIZE);
+        memset(cp->tx_skb, 0, sizeof(struct sk_buff *) * CP_TX_RING_SIZE);
 }
 
 static void cp_free_rings (struct cp_private *cp)
@@ -1204,7 +1192,7 @@ static int cp_open (struct net_device *dev)
 
         cp_init_hw(cp);
 
-        rc = request_irq(dev->irq, cp_interrupt, SA_SHIRQ, dev->name, dev);
+        rc = request_irq(dev->irq, cp_interrupt, IRQF_SHARED, dev->name, dev);
         if (rc)
                 goto err_out_hw;
 
@@ -1558,7 +1546,7 @@ static void cp_get_ethtool_stats (struct net_device *dev,
         pci_free_consistent(cp->pdev, sizeof(*nic_stats), nic_stats, dma);
 }
 
-static struct ethtool_ops cp_ethtool_ops = {
+static const struct ethtool_ops cp_ethtool_ops = {
         .get_drvinfo            = cp_get_drvinfo,
         .get_regs_len           = cp_get_regs_len,
         .get_stats_count        = cp_get_stats_count,
@@ -1823,7 +1811,7 @@ static int cp_init_one (struct pci_dev *pdev, const struct pci_device_id *ent)
         struct cp_private *cp;
         int rc;
         void __iomem *regs;
-        long pciaddr;
+        resource_size_t pciaddr;
         unsigned int addr_len, i, pci_using_dac;
         u8 pci_rev;
 
@@ -1837,9 +1825,10 @@ static int cp_init_one (struct pci_dev *pdev, const struct pci_device_id *ent)
 
         if (pdev->vendor == PCI_VENDOR_ID_REALTEK &&
             pdev->device == PCI_DEVICE_ID_REALTEK_8139 && pci_rev < 0x20) {
-                printk(KERN_ERR PFX "pci dev %s (id %04x:%04x rev %02x) is not an 8139C+ compatible chip\n",
-                       pci_name(pdev), pdev->vendor, pdev->device, pci_rev);
-                printk(KERN_ERR PFX "Try the \"8139too\" driver instead.\n");
+                dev_err(&pdev->dev,
+                           "This (id %04x:%04x rev %02x) is not an 8139C+ compatible chip\n",
+                           pdev->vendor, pdev->device, pci_rev);
+                dev_err(&pdev->dev, "Try the \"8139too\" driver instead.\n");
                 return -ENODEV;
         }
 
@@ -1877,14 +1866,13 @@ static int cp_init_one (struct pci_dev *pdev, const struct pci_device_id *ent)
         pciaddr = pci_resource_start(pdev, 1);
         if (!pciaddr) {
                 rc = -EIO;
-                printk(KERN_ERR PFX "no MMIO resource for pci dev %s\n",
-                       pci_name(pdev));
+                dev_err(&pdev->dev, "no MMIO resource\n");
                 goto err_out_res;
         }
         if (pci_resource_len(pdev, 1) < CP_REGS_SIZE) {
                 rc = -EIO;
-                printk(KERN_ERR PFX "MMIO resource (%lx) too small on pci dev %s\n",
-                       pci_resource_len(pdev, 1), pci_name(pdev));
+                dev_err(&pdev->dev, "MMIO resource (%llx) too small\n",
+                       (unsigned long long)pci_resource_len(pdev, 1));
                 goto err_out_res;
         }
 
@@ -1898,14 +1886,15 @@ static int cp_init_one (struct pci_dev *pdev, const struct pci_device_id *ent)
 
                 rc = pci_set_dma_mask(pdev, DMA_32BIT_MASK);
                 if (rc) {
-                        printk(KERN_ERR PFX "No usable DMA configuration, "
-                               "aborting.\n");
+                        dev_err(&pdev->dev,
+                                   "No usable DMA configuration, aborting.\n");
                         goto err_out_res;
                 }
                 rc = pci_set_consistent_dma_mask(pdev, DMA_32BIT_MASK);
                 if (rc) {
-                        printk(KERN_ERR PFX "No usable consistent DMA configuration, "
-                               "aborting.\n");
+                        dev_err(&pdev->dev,
+                                   "No usable consistent DMA configuration, "
+                                   "aborting.\n");
                         goto err_out_res;
                 }
         }
@@ -1916,8 +1905,9 @@ static int cp_init_one (struct pci_dev *pdev, const struct pci_device_id *ent)
         regs = ioremap(pciaddr, CP_REGS_SIZE);
         if (!regs) {
                 rc = -EIO;
-                printk(KERN_ERR PFX "Cannot map PCI MMIO (%lx@%lx) on pci dev %s\n",
-                       pci_resource_len(pdev, 1), pciaddr, pci_name(pdev));
+                dev_err(&pdev->dev, "Cannot map PCI MMIO (%Lx@%Lx)\n",
+                       (unsigned long long)pci_resource_len(pdev, 1),
+                       (unsigned long long)pciaddr);
                 goto err_out_res;
         }
         dev->base_addr = (unsigned long) regs;
@@ -1986,7 +1976,8 @@ static int cp_init_one (struct pci_dev *pdev, const struct pci_device_id *ent)
         /* enable busmastering and memory-write-invalidate */
         pci_set_master(pdev);
 
-        if (cp->wol_enabled) cp_set_d3_state (cp);
+        if (cp->wol_enabled)
+                cp_set_d3_state (cp);
 
         return 0;
 
@@ -2008,10 +1999,10 @@ static void cp_remove_one (struct pci_dev *pdev)
         struct net_device *dev = pci_get_drvdata(pdev);
         struct cp_private *cp = netdev_priv(dev);
 
-        BUG_ON(!dev);
         unregister_netdev(dev);
         iounmap(cp->regs);
-        if (cp->wol_enabled) pci_set_power_state (pdev, PCI_D0);
+        if (cp->wol_enabled)
+                pci_set_power_state (pdev, PCI_D0);
         pci_release_regions(pdev);
         pci_clear_mwi(pdev);
         pci_disable_device(pdev);
@@ -2022,14 +2013,12 @@ static void cp_remove_one (struct pci_dev *pdev)
 #ifdef CONFIG_PM
 static int cp_suspend (struct pci_dev *pdev, pm_message_t state)
 {
-        struct net_device *dev;
-        struct cp_private *cp;
+        struct net_device *dev = pci_get_drvdata(pdev);
+        struct cp_private *cp = netdev_priv(dev);
         unsigned long flags;
 
-        dev = pci_get_drvdata (pdev);
-        cp  = netdev_priv(dev);
-
-        if (!dev || !netif_running (dev)) return 0;
+        if (!netif_running(dev))
+                return 0;
 
         netif_device_detach (dev);
         netif_stop_queue (dev);
@@ -2095,7 +2084,7 @@ static int __init cp_init (void)
 #ifdef MODULE
         printk("%s", version);
 #endif
-        return pci_module_init (&cp_driver);
+        return pci_register_driver(&cp_driver);
 }
 
 static void __exit cp_exit (void)